SeaBIOS

seabios@seabios.org

4 participants
3801 discussions

[PATCH 0/5] Use wrappers for VGA IO port accesses
by Kevin O'Connor 15 Jan '12

15 Jan '12

Introduce standard wrappers for accessing the VGA IO ports. The VGA ports are pretty bizarre - using wrappers makes the code easier to understand. -Kevin Kevin O'Connor (5): vgabios: Add wrapper functions for accessing standard VGA registers. vgabios: Use standard VGA IO wrapper functions in stdvga.c. vgabios: Use standard VGA IO wrapper functions in bochsvga. vgabios: Use standard VGA IO wrappers in clext.c. vgabios: Use standard VGA IO wrappers in geodevga.c. Makefile | 7 +- vgasrc/bochsvga.c | 53 +++----- vgasrc/bochsvga.h | 2 +- vgasrc/clext.c | 125 ++++++----------- vgasrc/geodevga.c | 19 +-- vgasrc/stdvga.c | 408 +++++++++++++---------------------------------------- vgasrc/stdvga.h | 31 +++- vgasrc/stdvgaio.c | 185 ++++++++++++++++++++++++ vgasrc/vgabios.c | 16 +- 9 files changed, 389 insertions(+), 457 deletions(-) create mode 100644 vgasrc/stdvgaio.c -- 1.7.6.4

1 5

[PATCH 1/2] Permit multiple BEV and BEV/BCV combinations in a single option rom.
by Kevin O'Connor 14 Jan '12

14 Jan '12

The BBS spec is unclear on multiple BEV entry points for a rom. However, the LSI scsi rom has been seen to register a BEV followed by multiple BCV entry points. Add support for it, as there's no harm in it. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- src/optionroms.c | 21 ++++++++++----------- 1 files changed, 10 insertions(+), 11 deletions(-) diff --git a/src/optionroms.c b/src/optionroms.c index 725767b..27cfffd 100644 --- a/src/optionroms.c +++ b/src/optionroms.c @@ -388,19 +388,18 @@ optionrom_setup(void) , getRomPriority(sources, rom, 0)); continue; } - // PnP rom. - if (pnp->bev) { - // Can boot system - add to IPL list. - boot_add_bev(FLATPTR_TO_SEG(rom), pnp->bev, pnp->productname - , getRomPriority(sources, rom, 0)); - } else { - // Check for BCV (there may be multiple). - int instance = 0; - while (pnp && pnp->bcv) { + // PnP rom - check for BEV and BCV boot capabilities. + int instance = 0; + while (pnp) { + if (pnp->bev) + boot_add_bev(FLATPTR_TO_SEG(rom), pnp->bev, pnp->productname + , getRomPriority(sources, rom, instance++)); + else if (pnp->bcv) boot_add_bcv(FLATPTR_TO_SEG(rom), pnp->bcv, pnp->productname , getRomPriority(sources, rom, instance++)); - pnp = get_pnp_next(rom, pnp); - } + else + break; + pnp = get_pnp_next(rom, pnp); } } } -- 1.7.6.4

2 2

[PATCH 00/15] More vgabios work.
by Kevin O'Connor 14 Jan '12

14 Jan '12

More work on the vgabios. Much of the changes are for unifying the mode lists shared between the various drivers. This series culminates with the Cirrus driver getting basic VBE support. -Kevin Kevin O'Connor (15): vgabios: Use vesa style memory model flags in stdvga code. vgabios: Use standard naming for cirrus memmodel. vgabios: Add char width to stdvga mode table. vgabios: Remove dummy 0xfe mode from list of cirrus modes. vgabios: Make struct vgamode_s more similar to bochs/cirrus mode tables. vgabios: Add memmodel field to bochsvga mode list. vgabios: Unify page size calculations; remove page size from vgamode_s. vgabios: Extract out common parts of struct vgamode_s. vgabios: Use vgamode_s in cirrus and bochsvga mode tables. vgabios: Unify code to generate the vbe mode list. vgabios: Make VBE code independent of bochsvga. vgabios: Unify cirrus and vbe vesa functions. vgabios: Make cirrus line lengths standard. vgabios: Hook up Cirrus extended bios functions. vgabios: Add cirrus linear framebuffer detection; enable VBE in cirrus. Makefile | 2 +- vgasrc/bochsvga.c | 327 +++++++++++++--------------------- vgasrc/bochsvga.h | 11 +- vgasrc/clext.c | 499 ++++++++++++++++++---------------------------------- vgasrc/clext.h | 6 +- vgasrc/geodevga.c | 6 +- vgasrc/stdvga.c | 34 ++-- vgasrc/stdvga.h | 36 +--- vgasrc/vbe.c | 94 +++++----- vgasrc/vgabios.c | 85 +++++---- vgasrc/vgabios.h | 42 +++-- vgasrc/vgafb.c | 90 ++++------ vgasrc/vgahw.h | 17 ++ vgasrc/vgatables.c | 86 +++++---- 14 files changed, 564 insertions(+), 771 deletions(-) -- 1.7.6.4

1 15

[PATCH 2/2] BCVs should inherrit the legacy harddrive priority.
by Kevin O'Connor 14 Jan '12

14 Jan '12

A BCV will (almost assuredly) be a hard drive, so it makes sense to prioritize them the same as builtin hard drives when only the legacy priority system is used. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- src/boot.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/boot.c b/src/boot.c index 93928d3..e26dad1 100644 --- a/src/boot.c +++ b/src/boot.c @@ -326,7 +326,7 @@ boot_add_bev(u16 seg, u16 bev, u16 desc, int prio) void boot_add_bcv(u16 seg, u16 ip, u16 desc, int prio) { - bootentry_add(IPL_TYPE_BCV, defPrio(prio, DEFAULT_PRIO) + bootentry_add(IPL_TYPE_BCV, defPrio(prio, DefaultHDPrio) , SEGOFF(seg, ip).segoff , desc ? MAKE_FLATPTR(seg, desc) : "Legacy option rom"); } -- 1.7.6.4

1 0

Re: [SeaBIOS] [PATCH 0/3] acpi_piix4: Add CPU eject handling
by Jan Kiszka 13 Jan '12

13 Jan '12

On 2012-01-13 12:11, Vasilis Liaskovitis wrote: > This patch series adds support for CPU _EJ0 callback in Seabios and qemu-kvm. > The first patch defines the CPU eject bitmap in Seabios and writes to it > during the callback. The second patch adds empty stub functions to qemu-kvm to > handle the bitmap writes. Please work against upstream (uq/master for kvm-related patches), not qemu-kvm. It possibly makes no technical difference here, but we do not want to let the code bases needlessly diverge again. If if does make a difference and upstream lacks further bits, push them first. Thanks, Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux

2 1

Re: [SeaBIOS] [PATCH 3/3] acpi_piix4: Call KVM_SETSTATE_VCPU ioctl on cpu ejection
by Jan Kiszka 13 Jan '12

13 Jan '12

On 2012-01-13 12:11, Vasilis Liaskovitis wrote: > Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis(a)profitbricks.com> > --- > hw/acpi_piix4.c | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c > index 8bf30dd..12eef55 100644 > --- a/hw/acpi_piix4.c > +++ b/hw/acpi_piix4.c > @@ -502,6 +502,27 @@ static uint32_t cpuej_read(void *opaque, uint32_t addr) > > static void cpuej_write(void *opaque, uint32_t addr, uint32_t val) > { > + struct kvm_vcpu_state state; > + CPUState *env; > + int cpu; > + int ret; > + > + cpu = ffs(val); > + /* zero means no bit was set, i.e. no CPU ejection happened */ > + if (!cpu) > + return; > + cpu--; > + env = cpu_phyid_to_cpu((uint64_t)cpu); > + if (env != NULL) { > + if (env->state == CPU_STATE_ZAPREQ) { > + state.vcpu_id = env->cpu_index; > + state.state = 1; > + ret = kvm_vm_ioctl(env->kvm_state, KVM_SETSTATE_VCPU, &state); That breaks in the absence of KVM or if it is not enabled. Also, where was this IOCTL introduced? Where are the linux header changes? > + if (ret) > + fprintf(stderr, "KVM_SETSTATE_VCPU failed: %s\n", > + strerror(ret)); > + } > + } > PIIX4_DPRINTF("cpuej write %x <== %d\n", addr, val); > } > Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux

2 1

[PATCH 3/3] acpi_piix4: Call KVM_SETSTATE_VCPU ioctl on cpu ejection
by Vasilis Liaskovitis 13 Jan '12

13 Jan '12

Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis(a)profitbricks.com> --- hw/acpi_piix4.c | 21 +++++++++++++++++++++ 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 8bf30dd..12eef55 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@ -502,6 +502,27 @@ static uint32_t cpuej_read(void *opaque, uint32_t addr) static void cpuej_write(void *opaque, uint32_t addr, uint32_t val) { + struct kvm_vcpu_state state; + CPUState *env; + int cpu; + int ret; + + cpu = ffs(val); + /* zero means no bit was set, i.e. no CPU ejection happened */ + if (!cpu) + return; + cpu--; + env = cpu_phyid_to_cpu((uint64_t)cpu); + if (env != NULL) { + if (env->state == CPU_STATE_ZAPREQ) { + state.vcpu_id = env->cpu_index; + state.state = 1; + ret = kvm_vm_ioctl(env->kvm_state, KVM_SETSTATE_VCPU, &state); + if (ret) + fprintf(stderr, "KVM_SETSTATE_VCPU failed: %s\n", + strerror(ret)); + } + } PIIX4_DPRINTF("cpuej write %x <== %d\n", addr, val); } -- 1.7.7.3

1 0

[PATCH 2/3] acpi_piix4: Add stub functions for CPU eject callback
by Vasilis Liaskovitis 13 Jan '12

13 Jan '12

Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis(a)profitbricks.com> --- hw/acpi_piix4.c | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index d5743b6..8bf30dd 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@ -37,6 +37,7 @@ #define GPE_BASE 0xafe0 #define PROC_BASE 0xaf00 +#define PROC_EJ_BASE 0xaf20 #define GPE_LEN 4 #define PCI_BASE 0xae00 #define PCI_EJ_BASE 0xae08 @@ -493,6 +494,17 @@ static void pcihotplug_write(void *opaque, uint32_t addr, uint32_t val) PIIX4_DPRINTF("pcihotplug write %x <== %d\n", addr, val); } +static uint32_t cpuej_read(void *opaque, uint32_t addr) +{ + PIIX4_DPRINTF("cpuej read %x\n", addr); + return 0; +} + +static void cpuej_write(void *opaque, uint32_t addr, uint32_t val) +{ + PIIX4_DPRINTF("cpuej write %x <== %d\n", addr, val); +} + static uint32_t pciej_read(void *opaque, uint32_t addr) { PIIX4_DPRINTF("pciej read %x\n", addr); @@ -553,6 +565,9 @@ static void piix4_acpi_system_hot_add_init(PCIBus *bus, PIIX4PMState *s) register_ioport_write(PROC_BASE, 32, 1, gpe_writeb, s); register_ioport_read(PROC_BASE, 32, 1, gpe_readb, s); + register_ioport_write(PROC_EJ_BASE, 32, 1, cpuej_write, s); + register_ioport_read(PROC_EJ_BASE, 32, 1, cpuej_read, s); + register_ioport_write(PCI_BASE, 8, 4, pcihotplug_write, pci0_status); register_ioport_read(PCI_BASE, 8, 4, pcihotplug_read, pci0_status); -- 1.7.7.3

1 0

[PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback
by Vasilis Liaskovitis 13 Jan '12

13 Jan '12

Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis(a)profitbricks.com> --- src/acpi-dsdt.dsl | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 7082b65..71d8ac4 100644 --- a/src/acpi-dsdt.dsl +++ b/src/acpi-dsdt.dsl @@ -650,8 +650,15 @@ DefinitionBlock ( Store(DerefOf(Index(CPON, Arg0)), Local0) If (Local0) { Return(0xF) } Else { Return(0x0) } } + /* CPU eject notify method */ + OperationRegion(PREJ, SystemIO, 0xaf20, 32) + Field (PREJ, ByteAcc, NoLock, Preserve) + { + PRE, 256 + } Method (CPEJ, 2, NotSerialized) { // _EJ0 method - eject callback + Store(ShiftLeft(1, Arg0), PRE) Sleep(200) } -- 1.7.7.3

1 0

[PATCH 0/3] acpi_piix4: Add CPU eject handling
by Vasilis Liaskovitis 13 Jan '12

13 Jan '12

This patch series adds support for CPU _EJ0 callback in Seabios and qemu-kvm. The first patch defines the CPU eject bitmap in Seabios and writes to it during the callback. The second patch adds empty stub functions to qemu-kvm to handle the bitmap writes. The third patch defines the eject method to handle the CPU_DEAD event in Liu Ping Fan's cpu lifecycle/destruction patchseries, see: http://patchwork.ozlabs.org/patch/127832/ This ACPI implementation can be used instead of the cpustate virtio/pci device in the original series. Vasilis Liaskovitis (2): acpi_piix4: Add CPU ejection handling acpi_piix4: Call KVM_SETSTATE_VCPU ioctl on cpu ejection hw/acpi_piix4.c | 36 ++++++++++++++++++++++++++++++++++++ 1 files changed, 36 insertions(+), 0 deletions(-) -- 1.7.7.3

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS