Hello,
this is my attempt to address the review comments I got for v2:
- Gerd pointed out that cbvesa should only use the modes where memmodel
== MM_DIRECT.
- Kevin noted that reading global variables need the GET_GLOBAL
wrapper. (I would have expected that the compiler does the right
thing here. Probably I'm still to wet behind the ears here :-)
Note this is only compile tested.
Uwe Kleine-König (2):
cbvga: reuse svga modes definitions from svgamodes.c
Add additional resolutions for 16:9 displays: 1600x900 and 2560x1440
vgasrc/cbvga.c | 80 ++++++----------------------------------------
vgasrc/svgamodes.c | 8 +++++
2 files changed, 17 insertions(+), 71 deletions(-)
--
2.20.1
v1:
Non-standard logical geometries break under QEMU.
A virtual disk which contains an operating system which depends on
logical geometries (consistent values being reported from BIOS INT13
AH=08) will most likely break under QEMU/SeaBIOS if it has non-standard
logical geometries - for example 56 SPT (sectors per track).
No matter what QEMU will guess - SeaBIOS, for large enough disks - will
use LBA translation, which will report 63 SPT instead.
In addition we can not enforce SeaBIOS to rely on phyiscal geometries at
all. A virtio-blk-pci virtual disk with 255 phyiscal heads can not
report more than 16 physical heads when moved to an IDE controller, the
ATA spec allows a maximum of 16 heads - this is an artifact of
virtualization.
By supplying the logical geometies directly we are able to support such
"exotic" disks.
We will use fw_cfg to do just that.
v2:
Fix missing parenthesis check in
"hd-geo-test: Add tests for lchs override"
v3:
* Rename fw_cfg key to "bios-geometry".
* Remove "extendible" interface.
* Add cpu_to_le32 fix as Laszlo suggested or big endian hosts
* Fix last qtest commit - automatic docker tester for some reason does not have qemu-img set
v4:
* Change fw_cfg interface from mixed textual/binary to textual only
v5:
* Fix line > 80 chars in tests/hd-geo-test.c
Sam Eiderman (8):
block: Refactor macros - fix tabbing
block: Support providing LCHS from user
bootdevice: Add interface to gather LCHS
scsi: Propagate unrealize() callback to scsi-hd
bootdevice: Gather LCHS from all relevant devices
bootdevice: Refactor get_boot_devices_list
bootdevice: FW_CFG interface for LCHS values
hd-geo-test: Add tests for lchs override
bootdevice.c | 148 +++++++++---
hw/block/virtio-blk.c | 6 +
hw/ide/qdev.c | 7 +-
hw/nvram/fw_cfg.c | 14 +-
hw/scsi/scsi-bus.c | 15 ++
hw/scsi/scsi-disk.c | 14 ++
include/hw/block/block.h | 22 +-
include/hw/scsi/scsi.h | 1 +
include/sysemu/sysemu.h | 4 +
tests/Makefile.include | 2 +-
tests/hd-geo-test.c | 582 +++++++++++++++++++++++++++++++++++++++++++++++
11 files changed, 774 insertions(+), 41 deletions(-)
--
2.13.3
Hi,
I use the simple coreboot config
https://github.com/merge/skulls/blob/master/x230/free-defconfig-555419f356
on today's coreboot master branch HEAD (403f433238), using SeaBIOS 1.12.1.
When choosing memtest86+ in SeaBIOS' menu, "Booting from CBFS" gets
printed but nothing else happens.
Booting into nvramcui or coreinfo works though.
(earlier, at least on coreboot 555419f356, using the same version of
SeaBIOS, things were fine).
Can you imagine why?
thanks,
martin
Hello, dear SeaBIOS community. I need your help.
I want to change character set with my own character table. Now I'm trying
to use Int 10h, function 11h. As SeaBIOS works with mode #3 by default
(text mode, 80x25 cells), I'm calling subservice 0h for set my table with
8x16 characters.
But It' doesn't work. Characters are changed, but symbol's form isn't
depends on what's my table contains. I think, It happens because I need to
set table pointer in registers es and bp. In flat model I can't get value
of segment, which contains my table.
I tried to write 0 in es register and allocate memory in low zone - didn't
changed anything.
So, can you help me? Maybe, I just using wrong way, and solution is much
easier?
Thank you for attention.
Novikov Konstantin
Hi folks.
I've recently ported coreboot on MBA 5,2 (13'' mid 2012 model) and MBP
10,1 (15'' mid 2012 retina model). The integrated keyboard on these
models is connected as a USB device, not PS/2. I have tested GRUB,
SeaBIOS and Tianocore payloads, and the keyboard works in GRUB and
Tianocore but not in SeaBIOS.
I was advised to send a log to this mailing list. It was created with
SEABIOS_DEBUG_LEVEL=9. I'm not yet familiar with SeaBIOS code, but with
your help perhaps I can debug and fix this.
v1:
Non-standard logical geometries break under QEMU.
A virtual disk which contains an operating system which depends on
logical geometries (consistent values being reported from BIOS INT13
AH=08) will most likely break under QEMU/SeaBIOS if it has non-standard
logical geometries - for example 56 SPT (sectors per track).
No matter what QEMU will guess - SeaBIOS, for large enough disks - will
use LBA translation, which will report 63 SPT instead.
In addition we can not enforce SeaBIOS to rely on phyiscal geometries at
all. A virtio-blk-pci virtual disk with 255 phyiscal heads can not
report more than 16 physical heads when moved to an IDE controller, the
ATA spec allows a maximum of 16 heads - this is an artifact of
virtualization.
By supplying the logical geometies directly we are able to support such
"exotic" disks.
We will use fw_cfg to do just that.
v2:
Rename bootdevices fw_cfg key to bios-geoemtry
v3:
Change fw_cfg interface from mixed binary/textual to textual only
Squash commit "config: Add toggle for bootdevice information"
v4:
* Rename TRANSLATION_MACHINE to TRANSLATION_HOST
* Rename "overriden" translation name to "host-supplied"
* Rename overriden_lchs_supplied() to host_lchs_supplied()
* Move sectors and heads check to host_lchs_supplied()
* Reuse duplicate code in boot.c
Sam Eiderman (5):
geometry: Read LCHS from fw_cfg
boot: Reorder functions in boot.c
boot: Build ata and scsi paths in function
geometry: Add boot_lchs_find_*() utility functions
geometry: Apply LCHS values for boot devices
src/Kconfig | 7 ++
src/block.c | 18 +++-
src/block.h | 1 +
src/boot.c | 273 +++++++++++++++++++++++++++++++++++++++++----------
src/hw/ahci.c | 1 +
src/hw/ata.c | 8 ++
src/hw/esp-scsi.c | 2 +
src/hw/lsi-scsi.c | 2 +
src/hw/megasas.c | 1 +
src/hw/mpt-scsi.c | 2 +
src/hw/pvscsi.c | 1 +
src/hw/virtio-blk.c | 2 +
src/hw/virtio-scsi.c | 2 +
src/util.h | 6 ++
14 files changed, 272 insertions(+), 54 deletions(-)
--
2.13.3
