Re: [SeaBIOS] [SeaBIOS PATCH v3] hotplug: Add device per func in ACPI DSDT tables
by Kevin O'Connor
On Tue, Dec 06, 2011 at 07:32:55PM -0500, Amos Kong wrote:
> ----- Original Message -----
> > On Tue, Dec 06, 2011 at 01:39:35PM +0800, Amos Kong wrote:
> > > Only func 0 is registered to guest driver (we can
> > > only found func 0 in slot->funcs list of driver),
> > > the other functions could not be cleaned when
> > > hot-removing the whole slot. This patch adds
> > > device per function in ACPI DSDT tables.
> > > Notify only when func0 is added and removed.
> > >
> > > Have tested with linux/winxp/win7, hot-adding/hot-remving,
> > > single/multiple function device, they are all fine(all
> > > added devices can be removed).
> > >
> > This includes some bits I wrote but this is not an ack
> > of the patch yet :)
> >
> > I find it surprising that this works: a function
> > has _EJ0 so would not guest expect that ejecting
> > a single one will only remove it, and not all functions?
>
> Removing single func is not supported by specific, and current code
> (qemu/kernel pci driver) process hot-remove with the whole slot.
> We could not hot-remove single func with/without this patch.
>
> Register _EJ0() for each func, then all the funcs will be record
> into the function list of the slot.
Just as an update - it's not clear to me what this patch does, and it
seems like Michael had some concerns.
Also, it doesn't seem right to hardcode the generation of that many
devices (248) in the AML code.
So, unless there are further comments I'm going to hold off on this
patch.
-Kevin
7 years, 3 months
Re: [SeaBIOS] bootslash.bmp
by Fred .
I've made a ImageMagick script to generate a image!
It is easy to change it to generate in other screen resolution or
change font size.
#!/bin/sh
convert -background black \
-font /usr/share/fonts/truetype/ubuntu-font-family/Ubuntu-R.ttf \
\( -pointsize 96 -size 320x480 \
-gravity East -fill '#2078cb' label:'Sea' \
-gravity West -fill white label:'BIOS' \
+append \) seabios.jpg
Looks awesome!
On Sun, Jan 29, 2012 at 3:04 PM, Fred . <eldmannen(a)gmail.com> wrote:
> Converted to JPG the file would be only about 9 kb.
>
> It could be generated from this SVG file I attached.
> This could be generated in a scripted manner using free open source
> software tools such as the 'convert' utility, part of ImageMagick.
>
> $ convert seabios.svg bootsplash.jpg
>
> Convert also supports -size parameter to resize to different sizes.
>
> The benefit of having it in the source tree is that it would make it
> easier for user to locate the path/directory where seabios looks for
> the bootsplash image, so they know where they should put their own
> bootsplash image.
> So they can just find the included bootsplash image and replace it
> with their own.
>
> Having a prominent logo displayed may also result in SeaBIOS receiving
> more attention.
>
> On Sun, Jan 29, 2012 at 6:32 AM, Peter Stuge <peter(a)stuge.se> wrote:
>> Fred . wrote:
>>> Add to source tree.
>>> bootsplash.bmp
>>
>> I'm afraid that's not likely.
>>
>> The file is 1.2 MB, which would grow the current repository size
>> over 30%. I find that unacceptable for a bootsplash file that most
>> will really notice or want.
>>
>> Recall the discussion when you first brought up the bootsplash topic.
>> SeaBIOS as you may have experienced by now only runs for a few
>> hundred milliseconds, and in fact running the VGA BIOS takes most of
>> that time, so a bootsplash would only be visible for maybe a tenth of
>> a second. Suggesting to add artificial delays would not be wise.
>>
>> Furthermore, if there is to be a bootsplash (which I for one don't
>> hold for impossible) then it needs to be generated from the
>> professional project logo (so far there is none) and preferably using
>> scripted free and libre tools.
>>
>> In any case, I think all graphics should be stored outside the source
>> tree, and be an optional addon.
>>
>> See e.g. what we do for the coreboot logo: http://coreboot.org/Logo
>>
>>
>> //Peter
>>
>> _______________________________________________
>> SeaBIOS mailing list
>> SeaBIOS(a)seabios.org
>> http://www.seabios.org/mailman/listinfo/seabios
7 years, 6 months
[PATCH] Introduce config option to select which IO port to send debug output on
by julian.pidancet＠gmail.com
From: Julian Pidancet <julian.pidancet(a)citrix.com>
Introduce CONFIG_DEBUG_IO_PORT config option which allow user
to choose on which port to send debug on at configure time.
Bochs users are likely to use 0x402 (default) for debugging purposes,
whereas Xen uses 0xe9, as IO port address.
Signed-off-by: Julian Pidancet <julian.pidancet(a)citrix.com>
---
src/Kconfig | 18 ++++++++++++++++++
src/output.c | 4 ++--
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/src/Kconfig b/src/Kconfig
index 9ea48bb..f57899b 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -348,4 +348,22 @@ menu "Debugging"
default 0x3f8
help
Base port for serial - generally 0x3f8, 0x2f8, 0x3e8, or 0x2e8.
+
+ config DEBUG_IO
+ depends on !COREBOOT && DEBUG_LEVEL != 0
+ bool "Special IO port debugging"
+ default y
+ help
+ Some emulators or hypervisors provide with a way to output debug
+ information by outputing strings in a special port present in the
+ IO space.
+
+ config DEBUG_IO_PORT
+ depends on DEBUG_IO
+ hex "Debug IO port address"
+ default 0x0402
+ help
+ Bochs uses the 0x0402 address by default, whereas Xen
+ makes the 0xe9 IO address available for guests use.
+
endmenu
diff --git a/src/output.c b/src/output.c
index 462ffb7..dd6d094 100644
--- a/src/output.c
+++ b/src/output.c
@@ -75,9 +75,9 @@ putc_debug(struct putcinfo *action, char c)
{
if (! CONFIG_DEBUG_LEVEL)
return;
- if (! CONFIG_COREBOOT)
+ if (! CONFIG_DEBUG_IO)
// Send character to debug port.
- outb(c, PORT_BIOS_DEBUG);
+ outb(c, CONFIG_DEBUG_IO_PORT);
if (c == '\n')
debug_serial('\r');
debug_serial(c);
--
Julian Pidancet
7 years, 6 months
[PATCH 0/3] Use VGA Hooks to make Xen VGA passthrough work on certain devices
by julian.pidancet＠gmail.com
From: Julian Pidancet <julian.pidancet(a)citrix.com>
The Intel gfx VGA option ROM on certain platforms requires the 155f50 BIOS function to be
implemented (even if it does nothing), to work properly. This series of patch allow
VGA passthrough on Xen to work on these platforms.
An example of these platform is the Dell Lattitude E6410 laptop, on which these patchs were
tested.
Julian Pidancet (3):
vgahooks: Allow usage of VGA hooks in the Xen case
vgahooks: Register 155f vga hooks for Xen Intel passthrough devices
vgahooks: Create 155f50 hook.
src/Kconfig | 2 +-
src/optionroms.c | 9 +++++++++
src/vgahooks.c | 29 ++++++++++++++++++++++++++++-
3 files changed, 38 insertions(+), 2 deletions(-)
--
Julian Pidancet
7 years, 6 months
Re: [SeaBIOS] [PATCH v2 3/4] uq/master: Add CPU eject handling for acpi_piix4
by Avi Kivity
On 01/24/2012 04:56 PM, Vasilis Liaskovitis wrote:
> On Tue, Jan 24, 2012 at 11:28:41AM +0100, Jan Kiszka wrote:
> > On 2012-01-24 11:10, Vasilis Liaskovitis wrote:
> > > Add stub functions for CPU eject callback. Define cpu_acpi_eject property and
> > > enable eject callback only for pc-1.1 machine model.
> >
> > Just to get the idea: What is the plan and advantage of introducing a
> > stub first? How much more is required to have some usable feature, even
> > if its just a friction of the full support?
> >
> There's not really an advantage to adding stubs first. The plan depends on the
> lifecycle patches getting accepted in some form at some point. The code is all
> out there, and some of it has been reviewed/commented on, but not accepted.
>
> kvm needs the following patches:
> https://lkml.org/lkml/2012/1/6/355 (v7, still in work)
> http://patchwork.ozlabs.org/patch/127828/
> This second patch introduces ioctl KVM_SETSTATE_VCPU, (qemu uses it to signal
> vcpu destruction to the host) but the review mentions there should be a
> simpler way. It's unclear to me whether this ioctl is desired or not.
Those patches are not strictly needed. On a kernel that doesn't have
them, you can simply park the vcpu thread in userspace until it is
re-added. I suggest writing the qemu patches without the assumption
that you're running on a 3.4+ kernel.
--
error compiling committee.c: too many arguments to function
7 years, 6 months
[PATCH] mask interrupts on S3 resume
by Gleb Natapov
i8259 clears interrupt mask on reset. Interrupt need to be
masked again before enabling interrupts on CPU. Since option
roms are called with interrupts enabled, resume should mask
interrupts in i8259 before calling vgabios.
Signed-off-by: Gleb Natapov <gleb(a)redhat.com>
diff --git a/src/resume.c b/src/resume.c
index 4390fb5..8f21938 100644
--- a/src/resume.c
+++ b/src/resume.c
@@ -39,6 +39,7 @@ handle_resume(void)
outb_cmos(0, CMOS_RESET_CODE);
dprintf(1, "In resume (status=%d)\n", status);
+ pic_setup();
init_dma();
switch (status) {
--
Gleb.
7 years, 6 months
Re: [SeaBIOS] Concept logos
by Kevin O'Connor
On Thu, Jan 26, 2012 at 12:07:03PM +0100, Fred . wrote:
> I drafted some concept logos.
> Please provide feedback.
> Perhaps we could have a vote?
>
> http://img585.imageshack.us/img585/3820/seabiosconceptlogos.png
I agree with Peter - I think the chip+wave looks the most promising of
the above. Random thoughts - the gear could be depicted as "spinning
fast", and maybe "SeaBIOS" could be written on the gear.
Thanks,
-Kevin
7 years, 6 months
[PATCH] make seabios 386/486 friendly
by Rudolf Marek
Hello,
Following patch makes seabios friendly to 386/486 CPUs, providing a way how to
emulate the CPUID instruction and using TSC only if CPU actually supports the
TSC. Otherwise it uses TSC emulation mode which is similar to what is used in
Xenomai except we use timer0 here.
With this patch it is able to run on 486SX class system aka bifferboard together
with coreboot.
Signed-off-by: Rudolf Marek <r.marek(a)assembler.cz>
Please let me know if you there is something you don't like in that patch.
Thanks
Rudolf
7 years, 6 months
Seabios: misc. fixes
by Philip Prindeville
Hi all,
Couple of minor patches:
(1) some messages are logged at level 1 that really shouldn't be;
(2) there's i8042 code being reached that shouldn't be if CONFIG_PS2PORT is off.
Thanks,
-Philip
7 years, 6 months
[PATCH 0/5] vgabios: build variants for qemu
by Gerd Hoffmann
Hi,
This patch series prepares vgabios for being used as qemu vga bios.
Qemu comes with multiple vga card emulations, so we need multiple
vgabios binaries. All build out of the same source tree, but with
different config options. Thus patch #1 revamps vgabios configuration
to allow building different variants in one go. Patches #2 .. #5 enable
more qemu virtual hardware support on top of that.
Gerd Hoffmann (5):
vgabios: support building multiple variants.
bochsvga: handle vmware vga.
bochsvga: build bios variant for vmware.
bochsvga: build bios variant for qxl.
bochsvga: build bios variant for isa-vga.
Makefile | 69 +++++++++++++++++++++++++++++----
vgasrc/Kconfig | 107 ++++++++++++++++++-----------------------------------
vgasrc/bochsvga.c | 18 ++++++--
vgasrc/vgaentry.S | 2 +-
4 files changed, 110 insertions(+), 86 deletions(-)
7 years, 6 months
