[PATCH v2] optionrom: disallow int19 redirect for pnp roms.
by Gerd Hoffmann
Check whenever pnp roms attempt to redirect int19, and in case it does
log a message and undo the redirect.
A pnp rom should not need this, we have BEVs and BCVs for that.
Nevertheless there are roms in the wild which are redirecting int19.
At least some BIOS implementations for physical hardware have a config
option in the setup to allow/disallow int19 redirections, so just not
allowing this seems to be the way to deal with this situation.
Buglink: https://bugzilla.redhat.com//show_bug.cgi?id=1642135
Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com>
---
src/optionroms.c | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/src/optionroms.c b/src/optionroms.c
index fc992f649f..e90900b790 100644
--- a/src/optionroms.c
+++ b/src/optionroms.c
@@ -8,6 +8,7 @@
#include "bregs.h" // struct bregs
#include "config.h" // CONFIG_*
#include "farptr.h" // FLATPTR_TO_SEG
+#include "biosvar.h" // GET_IVT
#include "hw/pci.h" // pci_config_readl
#include "hw/pcidevice.h" // foreachpci
#include "hw/pci_ids.h" // PCI_CLASS_DISPLAY_VGA
@@ -308,6 +309,24 @@ fail:
return NULL;
}
+static int boot_irq_captured(void)
+{
+ struct segoff_s current, seabios;
+
+ current = GET_IVT(0x19);
+ seabios = FUNC16(entry_19_official);
+ return ((current.seg != seabios.seg) ||
+ (current.offset != current.offset));
+}
+
+static void boot_irq_restore(void)
+{
+ struct segoff_s seabios;
+
+ seabios = FUNC16(entry_19_official);
+ SET_IVT(0x19, seabios);
+}
+
// Attempt to map and initialize the option rom on a given PCI device.
static void
init_pcirom(struct pci_device *pci, int isvga, u64 *sources)
@@ -327,8 +346,18 @@ init_pcirom(struct pci_device *pci, int isvga, u64 *sources)
if (! rom)
// No ROM present.
return;
+ int irq_was_captured = boot_irq_captured();
+ struct pnp_data *pnp = get_pnp_rom(rom);
setRomSource(sources, rom, RS_PCIROM | (u32)pci);
init_optionrom(rom, pci->bdf, isvga);
+ if (boot_irq_captured() && !irq_was_captured &&
+ !file && !isvga && pnp) {
+ // This PCI rom is misbehaving - recapture the boot irqs
+ char *desc = MAKE_FLATPTR(FLATPTR_TO_SEG(rom), pnp->productname);
+ dprintf(1, "PnP optionrom \"%s\" (bdf %pP) captured int19, restoring\n",
+ desc, pci);
+ boot_irq_restore();
+ }
}
--
2.9.3
2 months
[PATCH 1/5] vbe: add edid support.
by Gerd Hoffmann
VBE subfunction 0x15, read ddc data.
Add VBE_edid where drivers can fill in a EDID data blob.
If we find valid data there (checking the first two header
bytes), then report the function as supported and hand out
the data.
Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com>
---
vgasrc/vgautil.h | 1 +
vgasrc/vbe.c | 30 ++++++++++++++++++++++++++++++
2 files changed, 31 insertions(+)
diff --git a/vgasrc/vgautil.h b/vgasrc/vgautil.h
index a9940402e45b..dd1aa189547a 100644
--- a/vgasrc/vgautil.h
+++ b/vgasrc/vgautil.h
@@ -89,6 +89,7 @@ extern u32 VBE_total_memory;
extern u32 VBE_capabilities;
extern u32 VBE_framebuffer;
extern u16 VBE_win_granularity;
+extern u8 VBE_edid[256];
void handle_104f(struct bregs *regs);
// vgafonts.c
diff --git a/vgasrc/vbe.c b/vgasrc/vbe.c
index 724c1bad6d7a..66afb011ada0 100644
--- a/vgasrc/vbe.c
+++ b/vgasrc/vbe.c
@@ -25,6 +25,7 @@ u32 VBE_total_memory VAR16 = 256 * 1024;
u32 VBE_capabilities VAR16;
u32 VBE_framebuffer VAR16;
u16 VBE_win_granularity VAR16;
+u8 VBE_edid[256] VAR16;
static void
vbe_104f00(struct bregs *regs)
@@ -400,6 +401,34 @@ vbe_104f10(struct bregs *regs)
regs->ax = 0x004f;
}
+static void
+vbe_104f15(struct bregs *regs)
+{
+ int offset;
+
+ switch (regs->bl) {
+ case 0x00:
+ if (GET_GLOBAL(VBE_edid[0]) != 0x00 ||
+ GET_GLOBAL(VBE_edid[1]) != 0xff)
+ goto err;
+ regs->bx = 0x0103;
+ break;
+ case 0x01:
+ offset = regs->dx * 128;
+ if (offset >= sizeof(VBE_edid))
+ goto err;
+ memcpy_far(regs->es, (void*)(regs->di+0),
+ get_global_seg(), VBE_edid + offset,
+ 128);
+ break;
+ err:
+ default:
+ regs->ax = 0x014f;
+ return;
+ }
+ regs->ax = 0x004f;
+}
+
static void
vbe_104fXX(struct bregs *regs)
{
@@ -427,6 +456,7 @@ handle_104f(struct bregs *regs)
case 0x08: vbe_104f08(regs); break;
case 0x0a: vbe_104f0a(regs); break;
case 0x10: vbe_104f10(regs); break;
+ case 0x15: vbe_104f15(regs); break;
default: vbe_104fXX(regs); break;
}
}
--
2.18.1
2 months
[PATCH] optionrom: disallow int19 redirect for pnp roms.
by Gerd Hoffmann
Check whenever pnp roms attempt to redirect int19, and in case it does
log a message and undo the redirect.
A pnp rom should not need this, we have BEVs and BCVs for that.
Nevertheless there are roms in the wild which are redirecting int19.
At least some BIOS implementations for physical hardware have a config
option in the setup to allow/disallow int19 redirections, so just not
allowing this seems to be the way to deal with this situation.
Buglink: https://bugzilla.redhat.com//show_bug.cgi?id=1642135
Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com>
---
src/optionroms.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/src/optionroms.c b/src/optionroms.c
index fc992f649f..4ec5504ca9 100644
--- a/src/optionroms.c
+++ b/src/optionroms.c
@@ -8,6 +8,7 @@
#include "bregs.h" // struct bregs
#include "config.h" // CONFIG_*
#include "farptr.h" // FLATPTR_TO_SEG
+#include "biosvar.h" // GET_IVT
#include "hw/pci.h" // pci_config_readl
#include "hw/pcidevice.h" // foreachpci
#include "hw/pci_ids.h" // PCI_CLASS_DISPLAY_VGA
@@ -136,9 +137,24 @@ init_optionrom(struct rom_header *rom, u16 bdf, int isvga)
tpm_option_rom(newrom, rom->size * 512);
- if (isvga || get_pnp_rom(newrom))
+ struct pnp_data *pnp = get_pnp_rom(newrom);
+ if (isvga || pnp) {
+ struct segoff_s old19, new19;
// Only init vga and PnP roms here.
+ old19 = GET_IVT(0x19);
callrom(newrom, bdf);
+ new19 = GET_IVT(0x19);
+ if (old19.seg != new19.seg ||
+ old19.offset != new19.offset) {
+ dprintf(1, "WARNING! rom tried to hijack int19 "
+ "(vec %04x:%04x, pnp %s, bev %s, bvc %s)\n",
+ new19.seg, new19.offset,
+ pnp ? "yes" : "no",
+ pnp && pnp->bev ? "yes" : "no",
+ pnp && pnp->bcv ? "yes" : "no");
+ SET_IVT(0x19, old19);
+ }
+ }
return rom_confirm(newrom->size * 512);
}
--
2.9.3
2 months
[SeaBIOS][PATCH] smbios: Add missing zero byte to Type 0
by Sam Eiderman
According to SMBIOS Specification, section 6.1.3 Text Strings:
"Text strings associated with a given SMBIOS structure are returned in
the dmiStructBuffer, appended directly after the formatted portion of the
structure. This method of returning string information eliminates the
need for application software to deal with pointers embedded in the
SMBIOS structure. Each string is terminated with a null (00h) BYTE and
the set of strings is terminated with an additional null (00h) BYTE”
Furthermore:
"If the formatted portion of the structure contains string-reference
fields and all the string fields are set to 0 (no string references),
the formatted section of the structure is followed by two null (00h)
BYTES"
From the above it can be seen that any SMBIOS type which contains string
references should end with an additional zero byte.
This is currently handled in all SMBIOS types which use
load_str_field_with_default() besides type0.
Therefore, add the missing zero byte to SMBIOS Type 0.
Running QEMU with:
-machine pc-i440fx-2.0 (for legacy smbios)
-smbios type=0,vendor=,version=,date= (for zero str_index)
Will cause SMBIOS type0 entry to overrun type1 entry.
Reviewed-by: Ross Philipson <ross.philipson(a)oracle.com>
Reviewed-By: Liran Alon <liran.alon(a)oracle.com>
Signed-off-by: Sam Eiderman <shmuel.eiderman(a)oracle.com>
---
src/fw/smbios.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/fw/smbios.c b/src/fw/smbios.c
index f3b5ad9d..62a563b2 100644
--- a/src/fw/smbios.c
+++ b/src/fw/smbios.c
@@ -205,6 +205,10 @@ smbios_init_type_0(void *start)
*end = 0;
end++;
+ if (!str_index) {
+ *end = 0;
+ end++;
+ }
return end;
}
--
2.13.3
2 months, 1 week
Real mode kexec failure with non-IDE disk
by David Woodhouse
When I kexec either Xen or Linux in real mode, from either Xen or
Linux, it fails.
The last thing I see looks like SeaBIOS trying to use SMM for call32:
----------------
IN:
0x00000000000f70ec: mov %eax,%esi
0x00000000000f70ef: mov $0xb5,%eax
0x00000000000f70f5: mov $0x1234,%ecx
0x00000000000f70fb: mov $0xef3dc,%ebx
0x00000000000f7101: out %al,$0xb2
0x00000000000f7103: pause
----------------
IN:
0x00000000000ef3db: hlt
This happens when the real mode boot code calls INT 13h to read from
the disk. It seems to happen with virtio and SATA disks.
This is with the Ubuntu-packaged 1.10.2-1ubuntu1 SeaBIOS. Switching to
an IDE disk, or booting with 'edd=skipmbr', makes Xen work and Linux
get a little further before it dies anyway.
2 months, 2 weeks
Custom-sized, large floppy images?
by Rafael Send
Hi,
I'm working on stuffing a bootable Linux distro into coreboot. In QEMU I
already succeded by using coreboot's built-in kernel loading mechanism, but
that's without SeaBIOS.
I'd love to have it as a SeaBIOS payload so I can also boot other things,
but I guess I'd have to create a custom-sized floppy image for this or
figure out how to create an ELF payload out of a Linux kernel (I'm open to
either, but I wasn't able to find any documentation on the ELF method).
The guy who put Win 3.1 in coreboot attempted the floppy method, but
according to his article he did not find success with this method due to
unknown and complex issues in the floppy-side logic of SeaBIOS.
So, I'm making the question explicit: What would it take to support
custom-sized floppy images? In particular, I'm thinking of a 16MB device...
Alternatively, would it be possible to create an ELF file out of a Linux
kernel+initrd / bootable image?
Cheers,
Rafael
3 months
[PATCH es] bootmenu: Gerd Hoffman version - feedback
by Mike Banon
Dear Gerd Hoffman,
If my advanced_bootmenu new patch ( [*] link below ) is not
upstream-able ( for what reasons? ), I will be happy if your
alternative solution gets merged - at least because it is better than
what's currently in SeaBIOS master. However, I just tested your
patches and noticed some issues which did not exist at my original
version [*] - https://mail.coreboot.org/hyperkitty/list/seabios@seabios.org/thread/CKWL...
. I hope that you could review my feedback and address at least some
of them :
1) It is not possible to choose the boot entry by a single key press
of a fullsize keyboard. We have so many keyboard keys, why are we
limited to 1234567890 ? Seems inefficient. The alternative way, which
I followed, is to continue with qwertyuiop etc. - to utilize 4 rows of
keyboard keys - and make a single key press selection possible.
2) If there are >10 menu entries and you accidentally press '0'
instead of '1', there is no way to backspace/delete this wrong
character. Although, if there is an ability to remove the wrong
characters, then a confirmation of a correct input (e.g. by pressing
the Enter key) is also needed - to confirm that your last character
wasn't wrong. I implemented this mini console interface in my version
- but only for a numpad; for keyboard it wasn't needed because it is a
single key boot there.
3) If there are >20 menu entries, the first menu entries may not fit
on a screen. (That's why I had to add 2 pages support.) Perhaps you
think it's unlikely that anyone would need >20 menu entries: however,
if you are a floppy-based OS developer who is debugging something that
could be reproduced only at bare metal (so no QEMU) - you may want to
add a lot of different versions of your floppy to your coreboot build
- to reduce the amount of BIOS chip reflashes and just for your
convenience. I stopped at 35 max simply because ran out of keyboard
letter keys (could have gone double-letter but wanted to preserve a
single key boot).
4) Although a few USB numpads do have an Escape key (e.g. Motospeed
K23), the majority of them do not - so it is impossible for them to
open a boot menu by pressing Escape - simply because no such key.
(That's why I added "/" character to the menukeys - every USB numpad
has this key.) Also, in your patch version it's not possible to access
TPM from a numpad because no t or m keys on it - so I had to add '-'
character to the menukeys.
To summarize, perhaps the only advantage of your current patch version
is that it is 3 times smaller, so 3 times more likely to be merged.
However it doesn't necessarily mean that my original patch is
inefficient or bloated: I optimized it as best as I could, and quite
sure that if you'd have tried to implement the features mentioned
above - as well as some others I may have forgot to mention - then
your patch linecount would've jumped too.
P.S. If there are any issues with my patch, which have persuaded you
to create your own version (aside from the size issue) - I am open to
suggestions and could try to address them when I will have enough free
time.
Best regards,
Mike Banon
3 months, 1 week
[PATCH v3 1/2] get_keystroke: also return the key's ascii code.
by Gerd Hoffmann
Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com>
---
src/util.h | 2 +-
src/boot.c | 16 +++++++++-------
src/tcgbios.c | 8 ++++----
3 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/src/util.h b/src/util.h
index 9c06850353a4..fdb542c42964 100644
--- a/src/util.h
+++ b/src/util.h
@@ -36,7 +36,7 @@ int bootprio_find_pci_rom(struct pci_device *pci, int instance);
int bootprio_find_named_rom(const char *name, int instance);
struct usbdevice_s;
int bootprio_find_usb(struct usbdevice_s *usbdev, int lun);
-int get_keystroke(int msec);
+int get_keystroke(int msec, u8 *ascii);
// bootsplash.c
void enable_vga_console(void);
diff --git a/src/boot.c b/src/boot.c
index 9f82f3ca0c3e..47b039fbad09 100644
--- a/src/boot.c
+++ b/src/boot.c
@@ -435,23 +435,25 @@ check_for_keystroke(void)
// Return a keystroke - waiting forever if necessary.
static int
-get_raw_keystroke(void)
+get_raw_keystroke(u8 *ascii)
{
struct bregs br;
memset(&br, 0, sizeof(br));
br.flags = F_IF;
call16_int(0x16, &br);
+ if (ascii)
+ *ascii = br.al;
return br.ah;
}
// Read a keystroke - waiting up to 'msec' milliseconds.
int
-get_keystroke(int msec)
+get_keystroke(int msec, u8 *ascii)
{
u32 end = irqtimer_calc(msec);
for (;;) {
if (check_for_keystroke())
- return get_raw_keystroke();
+ return get_raw_keystroke(ascii);
if (irqtimer_check(end))
return -1;
yield_toirq();
@@ -474,7 +476,7 @@ interactive_bootmenu(void)
if (! CONFIG_BOOTMENU || !romfile_loadint("etc/show-boot-menu", 1))
return;
- while (get_keystroke(0) >= 0)
+ while (get_keystroke(0, NULL) >= 0)
;
char *bootmsg = romfile_loadfile("etc/boot-menu-message", NULL);
@@ -484,12 +486,12 @@ interactive_bootmenu(void)
u32 menutime = romfile_loadint("etc/boot-menu-wait", DEFAULT_BOOTMENU_WAIT);
enable_bootsplash();
- int scan_code = get_keystroke(menutime);
+ int scan_code = get_keystroke(menutime, NULL);
disable_bootsplash();
if (scan_code != menukey)
return;
- while (get_keystroke(0) >= 0)
+ while (get_keystroke(0, NULL) >= 0)
;
printf("Select boot device:\n\n");
@@ -514,7 +516,7 @@ interactive_bootmenu(void)
// multiple times and immediately booting the primary boot device.
int esc_accepted_time = irqtimer_calc(menukey == 1 ? 1500 : 0);
for (;;) {
- scan_code = get_keystroke(1000);
+ scan_code = get_keystroke(1000, NULL);
if (scan_code == 1 && !irqtimer_check(esc_accepted_time))
continue;
if (tpm_can_show_menu() && scan_code == 20 /* t */) {
diff --git a/src/tcgbios.c b/src/tcgbios.c
index 2e503f933524..a17239db21c9 100644
--- a/src/tcgbios.c
+++ b/src/tcgbios.c
@@ -2068,7 +2068,7 @@ tpm12_menu(void)
waitkey = 1;
while (waitkey) {
- while ((scancode = get_keystroke(1000)) == ~0)
+ while ((scancode = get_keystroke(1000, NULL)) == ~0)
;
switch (scancode) {
@@ -2156,7 +2156,7 @@ tpm20_menu_change_active_pcrbanks(void)
u8 flagnum;
int show = 0;
while (!show) {
- int scancode = get_keystroke(1000);
+ int scancode = get_keystroke(1000, NULL);
switch (scancode) {
case ~0:
@@ -2197,7 +2197,7 @@ tpm20_menu(void)
msgCode = TPM_PPI_OP_NOOP;
- while ((scan_code = get_keystroke(1000)) == ~0)
+ while ((scan_code = get_keystroke(1000, NULL)) == ~0)
;
switch (scan_code) {
@@ -2225,7 +2225,7 @@ tpm_menu(void)
if (!CONFIG_TCGBIOS)
return;
- while (get_keystroke(0) >= 0)
+ while (get_keystroke(0, NULL) >= 0)
;
wait_threads();
--
2.18.1
3 months, 1 week
SeaBIOS and Win 3.1: Windows 3.1 Flash Edition
by Paul Menzel
Dear SeaBIOS folks,
It was announced already on the coreboot mailing list [1], so some might
already know this.
redsPL got SeaBIOS and a Win 3.1 (floppy disk) (with coreboot) booting [2].
> Because the standard coreboot payload with SeaBIOS only occupies only
> about 1MB out of the full 8 on the ROM, I thought about embedding a
> full OS on the remaining 7 megs. It turns out that SeaBIOS has
> partial support for booting from flash - it sets up a virtual floppy
> drive with your floppy of choice loaded from floppyimg/<name>.lzma,
> but this gives us at best 2.88MB (standard ED floppy disk size,
> exactly 2x as large as a popular 1.44M), and I wanted more.
I guess it should be reproducible in QEMU too.
Kind regards,
Paul
[1]: https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/2Q...
[2]: https://sakamoto.pl/weblog/07-windows-3-flash-edition/
3 months, 1 week
[PATCH v2] bootmenu: add support for more than 9 entries
by Gerd Hoffmann
10th and following entries can be selected using letters.
Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com>
---
src/util.h | 1 +
src/boot.c | 49 ++++++++++++++++++++++++++++++++++---------------
src/kbd.c | 19 +++++++++++++++++--
3 files changed, 52 insertions(+), 17 deletions(-)
diff --git a/src/util.h b/src/util.h
index 9c06850353a4..c8e3b818d23e 100644
--- a/src/util.h
+++ b/src/util.h
@@ -189,6 +189,7 @@ void handle_15c2(struct bregs *regs);
void process_key(u8 key);
u8 enqueue_key(u16 keycode);
u16 ascii_to_keycode(u8 ascii);
+u16 ascii_to_scancode(u8 ascii);
// misc.c
extern int HaveRunPost;
diff --git a/src/boot.c b/src/boot.c
index 9f82f3ca0c3e..43160f8ee5b9 100644
--- a/src/boot.c
+++ b/src/boot.c
@@ -465,6 +465,14 @@ get_keystroke(int msec)
#define DEFAULT_BOOTMENU_WAIT 2500
+static const char menuchars[] = {
+ '1', '2', '3', '4', '5', '6', '7', '8', '9',
+ 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i',
+ 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r',
+ 's', /* skip t (tpm menu) */
+ 'u', 'v', 'w', 'x', 'y', 'z'
+};
+
// Show IPL option menu.
void
interactive_bootmenu(void)
@@ -497,12 +505,15 @@ interactive_bootmenu(void)
// Show menu items
int maxmenu = 0;
- struct bootentry_s *pos;
+ struct bootentry_s *pos, *boot = NULL;
hlist_for_each_entry(pos, &BootList, node) {
char desc[77];
- maxmenu++;
- printf("%d. %s\n", maxmenu
+ if (maxmenu >= ARRAY_SIZE(menuchars)) {
+ break;
+ }
+ printf("%c. %s\n", menuchars[maxmenu]
, strtcpy(desc, pos->description, ARRAY_SIZE(desc)));
+ maxmenu++;
}
if (tpm_can_show_menu()) {
printf("\nt. TPM Configuration\n");
@@ -521,23 +532,31 @@ interactive_bootmenu(void)
printf("\n");
tpm_menu();
}
- if (scan_code >= 1 && scan_code <= maxmenu+1)
+ if (scan_code == 1) {
+ // ESC
+ printf("\n");
+ return;
+ }
+
+ maxmenu = 0;
+ hlist_for_each_entry(pos, &BootList, node) {
+ if (maxmenu >= ARRAY_SIZE(menuchars))
+ break;
+ if (scan_code == ascii_to_scancode(menuchars[maxmenu])) {
+ boot = pos;
+ break;
+ }
+ maxmenu++;
+ }
+ if (boot)
break;
}
printf("\n");
- if (scan_code == 0x01)
- // ESC
- return;
// Find entry and make top priority.
- int choice = scan_code - 1;
- hlist_for_each_entry(pos, &BootList, node) {
- if (! --choice)
- break;
- }
- hlist_del(&pos->node);
- pos->priority = 0;
- hlist_add_head(&pos->node, &BootList);
+ hlist_del(&boot->node);
+ boot->priority = 0;
+ hlist_add_head(&boot->node, &BootList);
}
// BEV (Boot Execution Vector) list
diff --git a/src/kbd.c b/src/kbd.c
index 15e5ae789cd3..f54d9fe94287 100644
--- a/src/kbd.c
+++ b/src/kbd.c
@@ -271,12 +271,12 @@ handle_16(struct bregs *regs)
#define none 0
-static struct scaninfo {
+struct scaninfo {
u16 normal;
u16 shift;
u16 control;
u16 alt;
-} scan_to_keycode[] VAR16 = {
+} scan_to_keycode[] VARFSEG = {
{ none, none, none, none },
{ 0x011b, 0x011b, 0x011b, 0x01f0 }, /* escape */
{ 0x0231, 0x0221, none, 0x7800 }, /* 1! */
@@ -390,6 +390,21 @@ u16 ascii_to_keycode(u8 ascii)
return 0;
}
+u16 ascii_to_scancode(u8 ascii)
+{
+ int i;
+
+ for (i = 0; i < ARRAY_SIZE(scan_to_keycode); i++) {
+ if ((GET_GLOBAL(scan_to_keycode[i].normal) & 0xff) == ascii)
+ return i;
+ if ((GET_GLOBAL(scan_to_keycode[i].shift) & 0xff) == ascii)
+ return i;
+ if ((GET_GLOBAL(scan_to_keycode[i].control) & 0xff) == ascii)
+ return i;
+ }
+ return 0;
+}
+
// Handle a ps2 style scancode read from the keyboard.
static void
kbd_set_flag(int key_release, u16 set_bit0, u8 set_bit1, u16 toggle_bit)
--
2.18.1
3 months, 1 week
