Re: [SeaBIOS] [coreboot] Upgrade the 12 years old LZMA libraries - should we do it?
by Carl-Daniel Hailfinger
Hi Ivan,
On 03.04.2018 20:03, Ivan Ivanov wrote:
> I have noticed that both coreboot and seabios are using the very old
> versions of LZMA SDK.
True. I introduced the lzma code in coreboot (back when it was called
LinuxBIOS) when we were working on OLPC XO-1 support.
> If we will upgrade our LZMA libraries from the
> outdated-by-12-years 4.42 to the current version 18.04 , speed and
> compression ratio should improve and maybe a few bugs will be fixed.
Do you have any numbers for this? An improved compression ratio and
improved speed would be nice indeed, but how does the size of the
decompression code change? If the decompression code grows more than the
size reduction from better compression, it would be a net loss. A
significantly reduced decompression speed would also be a problem.
Decompression speed would have to be measured both for stream
decompression (i.e. the decompressor gets the compressed data in
single-byte or multibyte chunks) as well as full-size decompression
(i.e. the decompressor can access all compressed data at once). We also
have to make sure that stream decompression still works after the change.
> Do you think it should be done, or you are OK with using such an
> outdated version?
A size benefit for the resulting image is a good reason to switch.
Regards,
Carl-Daniel
6 months, 3 weeks
K-TEK-M275TP-FN-BL-ML USB keyboard support
by Аладышев Константин
Hello! I'm having problems with K-TEK-M275TP-FN-BL-ML keyboard
(http://www.key-tek.cn/Productview.asp?id=777). It is USB device with
keyboard and touchpad combined. It works in OS correctly, but doesn't work
in SeaBIOS.
I've tried to debug this issue and found that "usb_kbd_setup" function fails
on "(epdesc->wMaxPacketSize != 8)" check, cause "epdesc->wMaxPacketSize" is
actually 32. I've modified this "if" statement to pass 32 value also and now
function completes successfully. But it didn't help to solve my issue. There
are no interrupts from keyboard, "ehci_poll_intr" always returns -1 on
check:
if (token & QTD_STS_ACTIVE) {
// No intrs found.
return -1;
}
I don't know what to do now. What should I check next?
Does SeaBIOS support USB keyboard+touchpad devices at all?
1 year, 3 months
[PATCH] tpm: Request access to locality 0
by Stefan Berger
The CRB driver has to request access to locality 0. Our QEMU
CRB model will enforce that as well.
Signed-off-by: Stefan Berger <stefanb(a)linux.vnet.ibm.com>
---
src/hw/tpm_drivers.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/hw/tpm_drivers.c b/src/hw/tpm_drivers.c
index bd971f7..e4770b3 100644
--- a/src/hw/tpm_drivers.c
+++ b/src/hw/tpm_drivers.c
@@ -442,6 +442,8 @@ static u32 crb_activate(u8 locty)
if (!CONFIG_TCGBIOS)
return 0;
+ writeb(CRB_REG(locty, CRB_REG_LOC_CTRL), 1);
+
return 0;
}
--
2.5.5
1 year, 4 months
Re: [SeaBIOS] [coreboot] Upgrade the 12 years old LZMA libraries - should we do it?
by Zoran Stojsavljevic
Privet Ivan,
I would say that Coreboot should go for the greatest and latest. Since
everything from far back in Time is refined, mostly bug free (unless
the new releases do not include some new introduced bugs, which are
fixed (usually) in immediate releases).
This is more matter of the right chosen strategy, which every package
and/or library should follow.
Zoran
_______
On Tue, Apr 3, 2018 at 8:03 PM, Ivan Ivanov <qmastery16(a)gmail.com> wrote:
> I have noticed that both coreboot and seabios are using the very old
> versions of LZMA SDK. If we will upgrade our LZMA libraries from the
> outdated-by-12-years 4.42 to the current version 18.04 , speed and
> compression ratio should improve and maybe a few bugs will be fixed.
> Do you think it should be done, or you are OK with using such an
> outdated version?
>
> Best regards,
> Ivan Ivanov aka qmastery
>
> --
> coreboot mailing list: coreboot(a)coreboot.org
> https://mail.coreboot.org/mailman/listinfo/coreboot
1 year, 4 months
Upgrade the 12 years old LZMA libraries - should we do it?
by Ivan Ivanov
I have noticed that both coreboot and seabios are using the very old
versions of LZMA SDK. If we will upgrade our LZMA libraries from the
outdated-by-12-years 4.42 to the current version 18.04 , speed and
compression ratio should improve and maybe a few bugs will be fixed.
Do you think it should be done, or you are OK with using such an
outdated version?
Best regards,
Ivan Ivanov aka qmastery
1 year, 4 months
[PATCH] tpm: Disable TCGBIOS by default
by Jean Lucas
When TCGBIOS is enabled on a machine without a physical TPM, SeaBIOS
takes over half a minute to print to the display, and over another half
minute before handing control over to a boot device. Disable this option
by default to have it be an explicit choice.
Tested on a Dell Inspiron 660s (no TPM) configured with libgfxinit, and,
separately, configured with a PCIe video card with onboard VGA BIOS.
Signed-off-by: Jean Lucas <jean(a)4ray.co>
---
src/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Kconfig b/src/Kconfig
index 55a87cb..b5d370a 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -467,7 +467,7 @@ menu "BIOS interfaces"
config TCGBIOS
depends on S3_RESUME
bool "TPM support and TCG BIOS extensions"
- default y
+ default n
help
Provide TPM support along with TCG BIOS extensions
--
2.16.2
1 year, 4 months
