SeaBIOS July 2020

seabios@seabios.org

14 participants
12 discussions

[PATCH v3 0/5] Make seabios linkable with lld

by Fangrui Song

This patch series make seabios linkable with lld. This is beneficial for FreeBSD ports as well https://svnweb.freebsd.org/ports/head/misc/seabios/Makefile as they can drop an LLD_UNSAFE As a maintainer of lld ELF, I have triaged numerous pieces of software. seabios is the only one making use of This drops the only instance https://sourceware.org/bugzilla/show_bug.cgi?id=12726 1, 2, 3 and 4 are really independent and can be applied in arbitrary order. 5 depends on 4. I originally combined 4 and 5 and that was why I don't think a patch series made sense. Fangrui Song (5): romlayout.S: Add missing SHF_ALLOC flag to .fixedaddr.\addr Make rom16.o linkable with lld Makefile: Change ET_EXEC to ET_REL so that lld can link bios.bin.elf romlayout32flag.lds: Use `. +=` instead of `. =` test-build.sh: Delete unneeded LD capability test Makefile | 4 ++++ scripts/layoutrom.py | 13 ++++++++++--- scripts/test-build.sh | 42 +----------------------------------------- src/romlayout.S | 2 +- 4 files changed, 16 insertions(+), 45 deletions(-) -- 2.26.0.292.g33ef6b2f38-goog

7 months, 3 weeks

release planning

by Gerd Hoffmann

Hi, qemu 5.1 is coming closer, with freeze in a week and release in August. See https://wiki.qemu.org/Planning/5.1 We'll need a new seabios release for qemu 5.1, and the options we have are: (1) cherry-pick bugfixes (at least the cirrus vga fix, probably more) into 1.13-stable, tag a 1.13.1 stable release. (2) tag a 1.14 release from master branch. Given we have several useful changes in the master branch which I would not consider being bugfixes a 1.14 released would be nice. Freeze in a week and release in three weeks should work fine with the qemu release schedule. What do you think? take care, Gerd

8 months, 2 weeks

[PATCH v2] virtio-scsi: fix boot prio detection by using correct lun

by Stefan Reiter

Commits d6bdb85eb0 virtio-scsi: skip initializing non-bootable devices f82e82a5ab2 virtio-mmio: add support for scsi devices. both use the lun value from tmpl_drv, which is always 0, instead of the correct one passed as a separate parameter. This causes systems where LUNs other than 0 are set as bootable, but 0 is not, to not boot. Reviewed-by: Paul Menzel <pmenzel(a)molgen.mpg.de> Signed-off-by: Stefan Reiter <s.reiter(a)proxmox.com> --- v2: * sep*a*rate :) * collect Paul's R-b src/hw/virtio-scsi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/hw/virtio-scsi.c b/src/hw/virtio-scsi.c index 59f1c65..369c981 100644 --- a/src/hw/virtio-scsi.c +++ b/src/hw/virtio-scsi.c @@ -126,14 +126,14 @@ virtio_scsi_add_lun(u32 lun, struct drive_s *tmpl_drv) int prio = -1; if (tmpl_vlun->pci) - prio = bootprio_find_scsi_device(tmpl_vlun->pci, tmpl_vlun->target, tmpl_vlun->lun); + prio = bootprio_find_scsi_device(tmpl_vlun->pci, tmpl_vlun->target, lun); if (tmpl_vlun->mmio) - prio = bootprio_find_scsi_mmio_device(tmpl_vlun->mmio, tmpl_vlun->target, tmpl_vlun->lun); + prio = bootprio_find_scsi_mmio_device(tmpl_vlun->mmio, tmpl_vlun->target, lun); if (skip_nonbootable && prio < 0) { dprintf(1, "skipping init of a non-bootable virtio-scsi dev at %s," " target %d, lun %d\n", - tmpl_vlun->name, tmpl_vlun->target, tmpl_vlun->lun); + tmpl_vlun->name, tmpl_vlun->target, lun); return -1; } -- 2.20.1

8 months, 2 weeks

[PATCH] hw/nvme: Increase `nvme_cmd_readwrite()` message log level from 3 to 5

by Paul Menzel

Currently, setting SeaBIOS debug level to 3, the log is filled with messages like below. ns 1 read lba 11346288+8: 0 ns 1 read lba 11346296+4: 0 ns 1 read lba 11346300+4: 0 ns 1 read lba 11346304+8: 0 ns 1 read lba 11346312+8: 0 ns 1 read lba 11346320+8: 0 ns 1 read lba 11346328+8: 0 ns 1 read lba 11346336+8: 0 With SeaBIOS as coreboot payload, this fills up the CBMEM console buffer. So, increase the debug level to 5, so possible console buffer do not overflow. Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- src/hw/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hw/nvme.c b/src/hw/nvme.c index 41f3b76..6a01204 100644 --- a/src/hw/nvme.c +++ b/src/hw/nvme.c @@ -669,7 +669,7 @@ nvme_cmd_readwrite(struct nvme_namespace *ns, struct disk_op_s *op, int write) } res = nvme_io_readwrite(ns, op->lba + i, ns->dma_buffer, blocks, write); - dprintf(3, "ns %u %s lba %llu+%u: %d\n", ns->ns_id, write ? "write" + dprintf(5, "ns %u %s lba %llu+%u: %d\n", ns->ns_id, write ? "write" : "read", op->lba + i, blocks, res); -- 2.26.2

8 months, 2 weeks

[PATCHv2] ldnoexec: Add script to remove ET_EXEC flag from intermediate build objects

by Kevin O'Connor

Add a script to remove the ET_EXEC flag from the 16bit and "32bit segmented" intermediate objects. This avoids build failures with some linkers that will not allow linking these objects again. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> -- v2: Use python instead of python2 in the script header --- Makefile | 9 +++++---- scripts/ldnoexec.py | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 37 insertions(+), 4 deletions(-) create mode 100755 scripts/ldnoexec.py diff --git a/Makefile b/Makefile index c20be15..3d8943e 100644 --- a/Makefile +++ b/Makefile @@ -127,9 +127,10 @@ $(Q)printf '$(foreach i,$2,#include "$i"\n)' > $3.tmp.c $(Q)$(CC) -I. $1 $(CFLAGSWHOLE) -c $3.tmp.c -o $3 endef -%.strip.o: %.o +%.noexec.o: %.o @echo " Stripping $@" - $(Q)$(STRIP) $< -o $@ + $(Q)$(STRIP) $< -o $<.strip.o + $(Q)$(PYTHON) ./scripts/ldnoexec.py $<.strip.o $@ $(OUT)%.s: %.c @echo " Compiling to assembler $@" @@ -185,9 +186,9 @@ $(OUT)rom32seg.o: $(OUT)code32seg.o $(OUT)romlayout32seg.lds @echo " Linking $@" $(Q)$(LD) -T $(OUT)romlayout32seg.lds $< -o $@ -$(OUT)rom.o: $(OUT)rom16.strip.o $(OUT)rom32seg.strip.o $(OUT)code32flat.o $(OUT)romlayout32flat.lds +$(OUT)rom.o: $(OUT)rom16.noexec.o $(OUT)rom32seg.noexec.o $(OUT)code32flat.o $(OUT)romlayout32flat.lds @echo " Linking $@" - $(Q)$(LD) -N -T $(OUT)romlayout32flat.lds $(OUT)rom16.strip.o $(OUT)rom32seg.strip.o $(OUT)code32flat.o -o $@ + $(Q)$(LD) -N -T $(OUT)romlayout32flat.lds $(OUT)rom16.noexec.o $(OUT)rom32seg.noexec.o $(OUT)code32flat.o -o $@ $(OUT)bios.bin.prep: $(OUT)rom.o scripts/checkrom.py @echo " Prepping $@" diff --git a/scripts/ldnoexec.py b/scripts/ldnoexec.py new file mode 100755 index 0000000..6d4e14b --- /dev/null +++ b/scripts/ldnoexec.py @@ -0,0 +1,32 @@ +#!/usr/bin/env python +# Script to remove EXEC flag from an ELF file +# +# Copyright (C) 2020 Kevin O'Connor <kevin(a)koconnor.net> +# +# This file may be distributed under the terms of the GNU GPLv3 license. +import os, optparse, sys + +FLAG_OFFSET = 16 + +def main(): + # Parse command-line arguments + usage = "%prog <input_file> <output_file>" + opts = optparse.OptionParser(usage) + options, args = opts.parse_args() + if len(args) != 2: + opts.error("Incorrect number of arguments") + infilename, outfilename = args + # Read input + f = open(infilename, "rb") + srcdata = f.read() + f.close() + # Update + outdata = bytearray(srcdata) + outdata[FLAG_OFFSET] = 0x01 # change ET_EXEC to ET_REL + # Write output + f = open(outfilename, "wb") + f.write(outdata) + f.close() + +if __name__ == '__main__': + main() -- 2.26.2

8 months, 2 weeks

[PATCH] virtio-scsi: fix boot prio detection by using correct lun

by Stefan Reiter

Commits d6bdb85eb0 virtio-scsi: skip initializing non-bootable devices f82e82a5ab2 virtio-mmio: add support for scsi devices. both use the lun value from tmpl_drv, which is always 0, instead of the correct one passed as a seperate parameter. This causes systems where LUNs other than 0 are set as bootable, but 0 is not, to not boot. Signed-off-by: Stefan Reiter <s.reiter(a)proxmox.com> --- src/hw/virtio-scsi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/hw/virtio-scsi.c b/src/hw/virtio-scsi.c index 59f1c65..369c981 100644 --- a/src/hw/virtio-scsi.c +++ b/src/hw/virtio-scsi.c @@ -126,14 +126,14 @@ virtio_scsi_add_lun(u32 lun, struct drive_s *tmpl_drv) int prio = -1; if (tmpl_vlun->pci) - prio = bootprio_find_scsi_device(tmpl_vlun->pci, tmpl_vlun->target, tmpl_vlun->lun); + prio = bootprio_find_scsi_device(tmpl_vlun->pci, tmpl_vlun->target, lun); if (tmpl_vlun->mmio) - prio = bootprio_find_scsi_mmio_device(tmpl_vlun->mmio, tmpl_vlun->target, tmpl_vlun->lun); + prio = bootprio_find_scsi_mmio_device(tmpl_vlun->mmio, tmpl_vlun->target, lun); if (skip_nonbootable && prio < 0) { dprintf(1, "skipping init of a non-bootable virtio-scsi dev at %s," " target %d, lun %d\n", - tmpl_vlun->name, tmpl_vlun->target, tmpl_vlun->lun); + tmpl_vlun->name, tmpl_vlun->target, lun); return -1; } -- 2.20.1

8 months, 2 weeks

ps2port: `keyboard self test failed (got ab not 0xaa)`

by Paul Menzel

Dear SeaBIOS folks, On the laptop TUXEDO Book BU1406 (Clevo N240BU) with coreboot [1] and SeaBIOS master, the internal PS/2 keyboard often does not work. SeaBIOS (version rel-1.13.0-45-g6ada228) […] /7aa38000\ Start thread |7aa38000| Discarding ps2 data 41 (status=13) Searching bootorder for: HALT /7aa35000\ Start thread Found 0 lpt ports Found 0 serial ports |7aa38000| keyboard self test failed (got ab not 0xaa) \7aa38000/ End thread […] Kind regards, Paul [1]: https://review.coreboot.org/c/coreboot/+/43760/ "mb/clevo/kbl-u: Add Clevo N240BU as variant"

8 months, 3 weeks

recent ld built for x86_64 fails to accept 16bit code as input (seabios build)

by Michael Tokarev

Hello! To clarify from the very beginning, I don't know how this part of the larger picture actually works. The end result is that seabios project, with the current source tarball available for download from https://www.seabios.org/downloads/seabios-1.13.0.tar.gz , can't be built using GNU ld as of version 2.34.90.20200706. Here's the relevant output: seabios-1.13.0 $ make silentoldconfig seabios-1.13.0 $ make V=1 PYTHON=python3 ... Linking out/rom16.o ld -T out/romlayout16.lds out/code16.o -o out/rom16.o Stripping out/rom16.strip.o strip out/rom16.o -o out/rom16.strip.o Linking out/rom.o ld -N -T out/romlayout32flat.lds out/rom16.strip.o out/rom32seg.strip.o out/code32flat.o -o out/rom.o ld: cannot use executable file 'out/rom16.strip.o' as input to a link make: *** [Makefile:187: out/rom.o] Error 1 seabios-1.13.0 $ _ Previous versions of ld accepted this file just fine and produced valid out/bios.bin in the end. I dunno if this is a problem is seabios (which has actually been already reported to seabios by Paul Menzel today), or an issue in ld. These ROMs/firmwares are a bit tricky to build.. Thanks! /mjt

8 months, 3 weeks

[PATCH] ldnoexec: Add script to remove ET_EXEC flag from intermediate build objects

by Kevin O'Connor

Add a script to remove the ET_EXEC flag from the 16bit and "32bit segmented" intermediate objects. This avoids build failures with some linkers that will not allow linking these objects again. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- Makefile | 9 +++++---- scripts/ldnoexec.py | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 37 insertions(+), 4 deletions(-) create mode 100755 scripts/ldnoexec.py diff --git a/Makefile b/Makefile index c20be15..3d8943e 100644 --- a/Makefile +++ b/Makefile @@ -127,9 +127,10 @@ $(Q)printf '$(foreach i,$2,#include "$i"\n)' > $3.tmp.c $(Q)$(CC) -I. $1 $(CFLAGSWHOLE) -c $3.tmp.c -o $3 endef -%.strip.o: %.o +%.noexec.o: %.o @echo " Stripping $@" - $(Q)$(STRIP) $< -o $@ + $(Q)$(STRIP) $< -o $<.strip.o + $(Q)$(PYTHON) ./scripts/ldnoexec.py $<.strip.o $@ $(OUT)%.s: %.c @echo " Compiling to assembler $@" @@ -185,9 +186,9 @@ $(OUT)rom32seg.o: $(OUT)code32seg.o $(OUT)romlayout32seg.lds @echo " Linking $@" $(Q)$(LD) -T $(OUT)romlayout32seg.lds $< -o $@ -$(OUT)rom.o: $(OUT)rom16.strip.o $(OUT)rom32seg.strip.o $(OUT)code32flat.o $(OUT)romlayout32flat.lds +$(OUT)rom.o: $(OUT)rom16.noexec.o $(OUT)rom32seg.noexec.o $(OUT)code32flat.o $(OUT)romlayout32flat.lds @echo " Linking $@" - $(Q)$(LD) -N -T $(OUT)romlayout32flat.lds $(OUT)rom16.strip.o $(OUT)rom32seg.strip.o $(OUT)code32flat.o -o $@ + $(Q)$(LD) -N -T $(OUT)romlayout32flat.lds $(OUT)rom16.noexec.o $(OUT)rom32seg.noexec.o $(OUT)code32flat.o -o $@ $(OUT)bios.bin.prep: $(OUT)rom.o scripts/checkrom.py @echo " Prepping $@" diff --git a/scripts/ldnoexec.py b/scripts/ldnoexec.py new file mode 100755 index 0000000..b0b32d4 --- /dev/null +++ b/scripts/ldnoexec.py @@ -0,0 +1,32 @@ +#!/usr/bin/env python2 +# Script to remove EXEC flag from an ELF file +# +# Copyright (C) 2020 Kevin O'Connor <kevin(a)koconnor.net> +# +# This file may be distributed under the terms of the GNU GPLv3 license. +import os, optparse, sys + +FLAG_OFFSET = 16 + +def main(): + # Parse command-line arguments + usage = "%prog <input_file> <output_file>" + opts = optparse.OptionParser(usage) + options, args = opts.parse_args() + if len(args) != 2: + opts.error("Incorrect number of arguments") + infilename, outfilename = args + # Read input + f = open(infilename, "rb") + srcdata = f.read() + f.close() + # Update + outdata = bytearray(srcdata) + outdata[FLAG_OFFSET] = 0x01 # change ET_EXEC to ET_REL + # Write output + f = open(outfilename, "wb") + f.write(outdata) + f.close() + +if __name__ == '__main__': + main() -- 2.26.2

8 months, 3 weeks

[PATCH] vgabios: Fix preserve memory flag in handle_1000

by Kevin O'Connor

Commit 5108c69c made a change to the ordering of some code which broke the check for the MF_NOCLEARMEM flag. Reported by felix.von.s(a)posteo.de Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- vgasrc/vgabios.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/vgasrc/vgabios.c b/vgasrc/vgabios.c index 3b9694c..198ee55 100644 --- a/vgasrc/vgabios.c +++ b/vgasrc/vgabios.c @@ -336,6 +336,9 @@ static void handle_1000(struct bregs *regs) { int mode = regs->al & 0x7f; + int flags = MF_LEGACY | (GET_BDA(modeset_ctl) & (MF_NOPALETTE|MF_GRAYSUM)); + if (regs->al & 0x80) + flags |= MF_NOCLEARMEM; // Set regs->al if (mode > 7) @@ -345,10 +348,6 @@ handle_1000(struct bregs *regs) else regs->al = 0x30; - int flags = MF_LEGACY | (GET_BDA(modeset_ctl) & (MF_NOPALETTE|MF_GRAYSUM)); - if (regs->al & 0x80) - flags |= MF_NOCLEARMEM; - vga_set_mode(mode, flags); } -- 2.26.2

8 months, 4 weeks

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS July 2020