February 2010 - SeaBIOS - mail.coreboot.org

Re: [SeaBIOS] [Qemu-devel] SeaBIOS error with Juniper FreeBSD kernel
by Kevin O'Connor July 11, 2011

July 11, 2011

On Sun, Feb 21, 2010 at 04:18:38PM -0700, Brandon Bennett wrote: > > On Sat, Feb 20, 2010 at 9:05 PM, Kevin O'Connor <kevin(a)koconnor.net> wrote: > >> Should a kernel fail during boot, I'd suspect it doesn't like one of > >> the apm/pcibios callbacks, or it doesn't like one of the > >> smbios/mptable/acpi tables. You could try compiling the SeaBIOS code > >> (see http://seabios.org/Download ) and increasing the debugging by > >> modifying src/config.h. Specifically, you could increase > >> CONFIG_DEBUG_LEVEL, and set DEBUG_HDL_pcibios32 and DEBUG_HDL_apm to > >> 1. Also, you could try disabling some of the features to see if that > >> prevents the fault (eg, disabling CONFIG_ACPI / CONFIG_SMBIOS / > >> CONFIG_MPTABLE). > > > > I have narrowed it down to SMBIOS. If I disable CONFIG_SMBIOS the > image boots up fine. Gleb, have you seen this thread? Some of the recent changes to smbios that look like possible culprits are: Make SMBIOS table pass MS SVVP test Use MaxCountCPUs during building of per cpu tables. Add malloc_high/fseg() and rework bios table creation to use them. There were other changes, but the comments indicate they were only ports of changes already in bochs. I suppose it's also possible the lack of smbios is turning off some other feature in the guest (eg, acpi) that's the real culprit. -Kevin

5 10

Bochs cvs + SeaBIOS git master + FreeDOS = slow load + invalid opcode
by Sebastian Herbszt May 16, 2010

May 16, 2010

I have tried SeaBIOS 0.5.1 on Bochs cvs with FreeDOS 1.0 Final boot floppy. Loading from floppy was utterly slow and then FreeDOS dumped Invalid Opcode at 0013 0000 0202 800F 01F3 20F4 10AA 10AA 109A 0000 0000 0000 00 00 Bad or missing Command Interpreter: A:\COMMAND.COM A:\ /E:2048 /F /MSG /P=A:\FRE EDOS\FDAUTO.BAT Enter the full shell command line: Bochs log has 00477945139i[BIOS ] Booting from Floppy... 00510608951i[BIOS ] Booting from 0000:7c00 05264161428i[FDD ] controller reset in software 05445136148i[FDD ] controller reset in software 05625186768i[FDD ] controller reset in software 05803824012i[FDD ] controller reset in software 05985259728i[FDD ] controller reset in software 05985285461i[CPU0 ] LOCK prefix unallowed (op1=0x53, attr=0x0, mod=0x0, nnn=0) Same floppy and Bochs version work fine and fast with Bochs BIOS. Any clues? - Sebastian

3 14

Re: [SeaBIOS] [Qemu-devel] SeaBIOS error with Nextstep bootloader
by Kevin O'Connor March 14, 2010

March 14, 2010

On Mon, Feb 22, 2010 at 02:56:22AM +0000, Natalia Portillo wrote: > Ok, QEMU is absolutely unable to boot nextstep/openstep, while using > SeaBIOS. > > Changing to old Bochs BIOS, makes it work, however no video is > output (until NeXT starts using VESA). Hi Natalia, Is nextstep/openstep something that can be freely downloaded? It would help if you can extract some SeaBIOS debugging info. I've uploaded a SeaBIOS image with the debug level set to 8 and serial debugging enabled. It is at: http://linuxtogo.org/~kevin/SeaBIOS/test/bios.bin-0.5.1-debug-20100228 Can you use this image with qemu, add "-serial file:mylog" to qemu's command line, and forward the resulting "mylog" file back? Also, please include the full qemu command line that you used. Thanks, -Kevin

3 14

running vga bios on resume from S3
by Gleb Natapov March 1, 2010

March 1, 2010

Shouldn't we make CONFIG_S3_RESUME_VGA_INIT=1 by default. Otherwise console doesn't work on Linux after resume. -- Gleb.

3 5

[PATCH] Seabios e820 reservation portion
by Jes Sorensen Feb. 21, 2010

Feb. 21, 2010

Hi, This is the Seabios part to match my e820 reservation via fw_cfg patch. Cheers, Jes

2 3

[PATCH] USB HID does not support Set_Idle
by Kevin O'Connor Feb. 19, 2010

Feb. 19, 2010

I found that the QEMU USB keyboard support does not work properly with the Set_Idle command. Once a non-zero value is given to Set_Idle, then the keyboard reports an event on every poll - not based on the time issued in the Set_Idle command. I changed the code (see patch below) and it works for me. I'm not that familiar with the qemu internals, so I'm not sure if this is the best way to implement this feature. -Kevin diff --git a/hw/usb-hid.c b/hw/usb-hid.c index 4f320d7..bf456bb 100644 --- a/hw/usb-hid.c +++ b/hw/usb-hid.c @@ -66,6 +66,7 @@ typedef struct USBHIDState { int kind; int protocol; uint8_t idle; + int64_t next_idle_clock; int changed; void *datain_opaque; void (*datain)(void *); @@ -630,6 +631,11 @@ static void usb_keyboard_handle_reset(USBDevice *dev) s->protocol = 1; } +static void usb_hid_set_next_idle(USBHIDState *s, int64_t curtime) +{ + s->next_idle_clock = curtime + (get_ticks_per_sec() * s->idle * 4) / 1000; +} + static int usb_hid_handle_control(USBDevice *dev, int request, int value, int index, int length, uint8_t *data) { @@ -795,6 +801,7 @@ static int usb_hid_handle_control(USBDevice *dev, int request, int value, break; case SET_IDLE: s->idle = (uint8_t) (value >> 8); + usb_hid_set_next_idle(s, qemu_get_clock(vm_clock)); ret = 0; break; default: @@ -813,9 +820,10 @@ static int usb_hid_handle_data(USBDevice *dev, USBPacket *p) switch(p->pid) { case USB_TOKEN_IN: if (p->devep == 1) { - /* TODO: Implement finite idle delays. */ - if (!(s->changed || s->idle)) + int64_t curtime = qemu_get_clock(vm_clock); + if (!s->changed && (!s->idle || s->next_idle_clock - curtime > 0)) return USB_RET_NAK; + usb_hid_set_next_idle(s, curtime); s->changed = 0; if (s->kind == USB_MOUSE) ret = usb_mouse_poll(s, p->data, p->len);

2 1

[PATCH 0/8] Add USB disk booting support
by Kevin O'Connor Feb. 18, 2010

Feb. 18, 2010

This patch series adds the ability to boot from USB flash drives. The first seven patches are just cleanups. The eighth adds the MSC support. This is only preliminary support - I've booted under qemu using a "-usbdevice disk:foo" drive, and I've also booted my epia-cn with seabios and coreboot. However, handling of error conditions and timers still needs to be improved. Also, the current support is UHCI only (no ohci). Further testing on real hardware would be appreciated. -Kevin Kevin O'Connor (8): Dynamically allocate each drive_g with malloc_fseg(). Move common "command data block" functions to new file blockcmd.c. Don't require a valid physical cylinders/heads/spt for logical mapping. Fix off by one error in strtcpy. Minor - arrange struct drive_s to clarify field roles. USB UHCI cleanups. Introduce helper functions for finding USB end-points. Initial support for booting from USB drives. Makefile | 4 +- src/ata.c | 36 +++----- src/biosvar.h | 6 +- src/block.c | 69 ++++++--------- src/blockcmd.c | 78 +++++++++++++++++ src/blockcmd.h | 19 ++++ src/boot.c | 2 +- src/cdrom.c | 69 ++++----------- src/config.h | 6 +- src/disk.h | 33 +++---- src/floppy.c | 7 +- src/usb-hid.c | 26 ++---- src/usb-msc.c | 261 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ src/usb-msc.h | 25 ++++++ src/usb-uhci.c | 142 +++++++++++++++++++++++++++++-- src/usb-uhci.h | 4 +- src/usb.c | 81 +++++++++++++++++- src/usb.h | 6 ++ src/util.c | 2 +- 19 files changed, 706 insertions(+), 170 deletions(-) create mode 100644 src/blockcmd.c create mode 100644 src/usb-msc.c create mode 100644 src/usb-msc.h

2 10

compiling a working Seabios
by Greg Ungerer Feb. 18, 2010

Feb. 18, 2010

Hi All, I have an Intel/Truxton (Tolapai/EP80579) type platform that I am using coreboot and seabios on. Up to now I have been using a pre-compiled binary from Kevin's download site: http://linuxtogo.org/~kevin/SeaBIOS/seabios-0.5.1.tar.gz and that has been working fine. (The coreboot is modified to support some changes on this particular hardware platform). Now the problem is that I want to generate seabios binaries from source. And I can't seem to be able to compile a working one. My host build system is a Ubuntu 9.10 x86_64 install (using the most up to date packages). This a gcc-4.4.1 and binutils-2.20 setup. If I get the source seabios-0.5.1 package from Kevin's download page and compile that I end up with a bios.bin.elf that is: -rwxr-xr-x 1 gerg gerg 1048716 2010-02-17 15:11 bios.bin.elf Hmm, rather large :-) The actual contents maybe ok: out/bios.bin.elf: file format elf32-i386 Sections: Idx Name Size VMA LMA File off Algn 0 .text 00013000 000ed000 000ed000 000ed000 2**4 CONTENTS, ALLOC, LOAD, READONLY, CODE The file offset is looking bad here. If I instead use a binutils-2.18 "ld" that I have lying around (doing "make LD=i386-linux-ld") then I end up with a more reasonable sized bios.bin.elf of 82060 bytes. But this bios.bin.elf just hangs after being loaded by coreboot on my target. I tried compiling this same seabios version (0.5.1) on an older Fedora Core 9 system (also an x86_64 install), and again that produced a non-working bios.bin.elf. I also got the latest seabios git tree and tried that. I also couldn't get a working seabios binary using that either. What versions of gcc/binutils do others use? Does anyone have any ideas where by building could be going wrong? Regards Greg ------------------------------------------------------------------------ Greg Ungerer -- Principal Engineer EMAIL: gerg(a)snapgear.com SnapGear Group, McAfee PHONE: +61 7 3435 2888 8 Gardner Close FAX: +61 7 3217 5323 Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com

3 3

[PATCH] Add common "block command" definitions and update cdrom code.
by Kevin O'Connor Feb. 16, 2010

Feb. 16, 2010

Add common "block command" definitions and update cdrom code. Introduce standard definitions and names for the "command data block" commands used in the cdrom code. diff --git a/src/ata.c b/src/ata.c index ed7ef28..a27da56 100644 --- a/src/ata.c +++ b/src/ata.c @@ -17,6 +17,7 @@ #include "boot.h" // add_bcv_hd #include "disk.h" // struct ata_s #include "ata.h" // ATA_CB_STAT +#include "blockcmd.h" // CDB_CMD_READ_10 #define IDE_TIMEOUT 32000 //32 seconds max for IDE ops @@ -596,9 +597,11 @@ process_ata_op(struct disk_op_s *op) * ATAPI functions ****************************************************************/ +#define CDROM_CDB_SIZE 12 + // Low-level atapi command transmit function. -static int -atapi_cmd_data(struct disk_op_s *op, u8 *cmdbuf, u8 cmdlen, u16 blocksize) +int +atapi_cmd_data(struct disk_op_s *op, void *cdbcmd, u16 blocksize) { u8 ataid = GET_GLOBAL(op->drive_g->cntl_id); u8 channel = ataid / 2; @@ -622,7 +625,7 @@ atapi_cmd_data(struct disk_op_s *op, u8 *cmdbuf, u8 cmdlen, u16 blocksize) goto fail; // Send command to device - outsw_fl(iobase1, MAKE_FLATPTR(GET_SEG(SS), cmdbuf), cmdlen / 2); + outsw_fl(iobase1, MAKE_FLATPTR(GET_SEG(SS), cdbcmd), CDROM_CDB_SIZE / 2); int status = pause_await_not_bsy(iobase1, iobase2); if (status < 0) { @@ -657,17 +660,12 @@ fail: int cdrom_read(struct disk_op_s *op) { - u8 atacmd[12]; - memset(atacmd, 0, sizeof(atacmd)); - atacmd[0]=0x28; // READ command - atacmd[7]=(op->count & 0xff00) >> 8; // Sectors - atacmd[8]=(op->count & 0x00ff); - atacmd[2]=(op->lba & 0xff000000) >> 24; // LBA - atacmd[3]=(op->lba & 0x00ff0000) >> 16; - atacmd[4]=(op->lba & 0x0000ff00) >> 8; - atacmd[5]=(op->lba & 0x000000ff); - - return atapi_cmd_data(op, atacmd, sizeof(atacmd), CDROM_SECTOR_SIZE); + struct cdb_rwdata_10 cmd; + memset(&cmd, 0, sizeof(cmd)); + cmd.command = CDB_CMD_READ_10; + cmd.lba = htonl(op->lba); + cmd.count = htons(op->count); + return atapi_cmd_data(op, &cmd, CDROM_SECTOR_SIZE); } // 16bit command demuxer for ATAPI cdroms. @@ -689,20 +687,6 @@ process_atapi_op(struct disk_op_s *op) } } -// Send a simple atapi command to a drive. -int -ata_cmd_packet(struct drive_s *drive_g, u8 *cmdbuf, u8 cmdlen - , u32 length, void *buf_fl) -{ - struct disk_op_s dop; - memset(&dop, 0, sizeof(dop)); - dop.drive_g = drive_g; - dop.count = 1; - dop.buf_fl = buf_fl; - - return atapi_cmd_data(&dop, cmdbuf, cmdlen, length); -} - /**************************************************************** * ATA detect and init diff --git a/src/ata.h b/src/ata.h index d217280..ede5f17 100644 --- a/src/ata.h +++ b/src/ata.h @@ -15,8 +15,7 @@ struct ata_channel_s { // ata.c extern struct ata_channel_s ATA_channels[CONFIG_MAX_ATA_INTERFACES]; int cdrom_read(struct disk_op_s *op); -int ata_cmd_packet(struct drive_s *drive_g, u8 *cmdbuf, u8 cmdlen - , u32 length, void *buf_fl); +int atapi_cmd_data(struct disk_op_s *op, void *cdbcmd, u16 blocksize); void ata_setup(void); int process_ata_op(struct disk_op_s *op); int process_atapi_op(struct disk_op_s *op); @@ -144,6 +143,4 @@ void describe_atapi(struct drive_s *drive_g); #define ATA_CMD_READ_NATIVE_MAX_ADDRESS 0xF8 #define ATA_CMD_SET_MAX 0xF9 -#define ATA_CMD_REQUEST_SENSE 0x03 - #endif // ata.h diff --git a/src/blockcmd.h b/src/blockcmd.h new file mode 100644 index 0000000..28a4889 --- /dev/null +++ b/src/blockcmd.h @@ -0,0 +1,58 @@ +// Definitions for SCSI style command data blocks. +#ifndef __BLOCKCMD_H +#define __BLOCKCMD_H + +#include "types.h" // u8 + +#define CDB_CMD_READ_10 0x28 +#define CDB_CMD_VERIFY_10 0x2f +#define CDB_CMD_WRITE_10 0x2a + +struct cdb_rwdata_10 { + u8 command; + u8 flags; + u32 lba; + u8 resreved_06; + u16 count; + u8 reserved_09; + u8 pad[6]; +} PACKED; + +#define CDB_CMD_READ_CAPACITY 0x25 + +struct cdb_read_capacity { + u8 command; + u8 flags; + u8 resreved_02[8]; + u8 pad[6]; +} PACKED; + +struct cdbres_read_capacity { + u32 sectors; + u32 blksize; +} PACKED; + +#define CDB_CMD_REQUEST_SENSE 0x03 + +struct cdb_request_sense { + u8 command; + u8 flags; + u16 reserved_02; + u8 length; + u8 reserved_05; + u8 pad[10]; +} PACKED; + +struct cdbres_request_sense { + u8 errcode; + u8 segment; + u8 flags; + u32 info; + u8 additional; + u32 specific; + u8 asc; + u8 ascq; + u32 reserved_0e; +} PACKED; + +#endif // blockcmd.h diff --git a/src/cdrom.c b/src/cdrom.c index 883bffa..4e70729 100644 --- a/src/cdrom.c +++ b/src/cdrom.c @@ -10,6 +10,7 @@ #include "bregs.h" // struct bregs #include "biosvar.h" // GET_EBDA #include "ata.h" // ATA_CMD_REQUEST_SENSE +#include "blockcmd.h" // CDB_CMD_REQUEST_SENSE /**************************************************************** @@ -167,6 +168,8 @@ cdemu_134b(struct bregs *regs) if (regs->al == 0x00) { // FIXME ElTorito Various. Should be handled accordingly to spec SET_EBDA2(ebda_seg, cdemu.active, 0x00); // bye bye + + // XXX - update floppy/hd count. } disk_ret(regs, DISK_RET_SUCCESS); @@ -179,47 +182,47 @@ cdemu_134b(struct bregs *regs) // Request SENSE static int -atapi_get_sense(struct drive_s *drive_g, u8 *asc, u8 *ascq) +atapi_get_sense(struct disk_op_s *op, u8 *asc, u8 *ascq) { - u8 atacmd[12], buffer[18]; - memset(atacmd, 0, sizeof(atacmd)); - atacmd[0] = ATA_CMD_REQUEST_SENSE; - atacmd[4] = sizeof(buffer); - int ret = ata_cmd_packet(drive_g, atacmd, sizeof(atacmd), sizeof(buffer) - , MAKE_FLATPTR(GET_SEG(SS), buffer)); + struct cdb_request_sense cmd; + struct cdbres_request_sense data; + memset(&cmd, 0, sizeof(cmd)); + cmd.command = CDB_CMD_REQUEST_SENSE; + cmd.length = sizeof(data); + op->count = 1; + op->buf_fl = &data; + int ret = atapi_cmd_data(op, &cmd, sizeof(data)); if (ret) return ret; - *asc = buffer[12]; - *ascq = buffer[13]; - + *asc = data.asc; + *ascq = data.ascq; return 0; } // Request capacity static int -atapi_read_capacity(struct drive_s *drive_g, u32 *blksize, u32 *sectors) +atapi_read_capacity(struct disk_op_s *op, u32 *blksize, u32 *sectors) { - u8 packet[12], buf[8]; - memset(packet, 0, sizeof(packet)); - packet[0] = 0x25; /* READ CAPACITY */ - int ret = ata_cmd_packet(drive_g, packet, sizeof(packet), sizeof(buf) - , MAKE_FLATPTR(GET_SEG(SS), buf)); + struct cdb_read_capacity cmd; + struct cdbres_read_capacity data; + memset(&cmd, 0, sizeof(cmd)); + cmd.command = CDB_CMD_READ_CAPACITY; + op->count = 1; + op->buf_fl = &data; + int ret = atapi_cmd_data(op, &cmd, sizeof(data)); if (ret) return ret; - *blksize = (((u32)buf[4] << 24) | ((u32)buf[5] << 16) - | ((u32)buf[6] << 8) | ((u32)buf[7] << 0)); - *sectors = (((u32)buf[0] << 24) | ((u32)buf[1] << 16) - | ((u32)buf[2] << 8) | ((u32)buf[3] << 0)); - + *blksize = ntohl(data.blksize); + *sectors = ntohl(data.sectors); return 0; } static int -atapi_is_ready(struct drive_s *drive_g) +atapi_is_ready(struct disk_op_s *op) { - dprintf(6, "atapi_is_ready (drive=%p)\n", drive_g); + dprintf(6, "atapi_is_ready (drive=%p)\n", op->drive_g); /* Retry READ CAPACITY for 5 seconds unless MEDIUM NOT PRESENT is * reported by the device. If the device reports "IN PROGRESS", @@ -233,13 +236,13 @@ atapi_is_ready(struct drive_s *drive_g) return -1; } - int ret = atapi_read_capacity(drive_g, &blksize, &sectors); + int ret = atapi_read_capacity(op, &blksize, &sectors); if (!ret) // Success break; u8 asc, ascq; - ret = atapi_get_sense(drive_g, &asc, &ascq); + ret = atapi_get_sense(op, &asc, &ascq); if (ret) // Error - retry. continue; @@ -259,7 +262,7 @@ atapi_is_ready(struct drive_s *drive_g) } } - if (blksize != GET_GLOBAL(drive_g->blksize)) { + if (blksize != GET_GLOBAL(op->drive_g->blksize)) { printf("Unsupported sector size %u\n", blksize); return -1; } @@ -272,19 +275,18 @@ atapi_is_ready(struct drive_s *drive_g) int cdrom_boot(int cdid) { - struct drive_s *drive_g = getDrive(EXTTYPE_CD, cdid); - if (!drive_g) + struct disk_op_s dop; + memset(&dop, 0, sizeof(dop)); + dop.drive_g = getDrive(EXTTYPE_CD, cdid); + if (!dop.drive_g) return 1; - int ret = atapi_is_ready(drive_g); + int ret = atapi_is_ready(&dop); if (ret) dprintf(1, "atapi_is_ready returned %d\n", ret); // Read the Boot Record Volume Descriptor u8 buffer[2048]; - struct disk_op_s dop; - memset(&dop, 0, sizeof(dop)); - dop.drive_g = drive_g; dop.lba = 0x11; dop.count = 1; dop.buf_fl = MAKE_FLATPTR(GET_SEG(SS), buffer); @@ -325,7 +327,7 @@ cdrom_boot(int cdid) u8 media = buffer[0x21]; SET_EBDA2(ebda_seg, cdemu.media, media); - SET_EBDA2(ebda_seg, cdemu.emulated_drive, ADJUST_GLOBAL_PTR(drive_g)); + SET_EBDA2(ebda_seg, cdemu.emulated_drive, ADJUST_GLOBAL_PTR(dop.drive_g)); u16 boot_segment = *(u16*)&buffer[0x22]; if (!boot_segment) @@ -362,6 +364,7 @@ cdrom_boot(int cdid) if (media < 4) { // Floppy emulation SET_EBDA2(ebda_seg, cdemu.emulated_extdrive, 0x00); + // XXX - get and set actual floppy count. SETBITS_BDA(equipment_list_flags, 0x41); switch (media) {

1 0

[PATCH] Optimize ntohl() code.
by Kevin O'Connor Feb. 16, 2010

Feb. 16, 2010

Optimize ntohl() code. Use the assembler bswapl instruction if the value is not constant. diff --git a/src/util.h b/src/util.h index 4228904..eb62507 100644 --- a/src/util.h +++ b/src/util.h @@ -101,6 +101,21 @@ static inline u32 __fls(u32 word) return word; } +static inline u16 __htons_constant(u16 val) { + return (val<<8) | (val>>8); +} +static inline u32 __htonl_constant(u32 val) { + return (val<<24) | ((val&0xff00)<<8) | ((val&0xff0000)>>8) | (val>>24); +} +static inline u32 __htonl(u32 val) { + asm("bswapl %0" : "+r"(val)); + return val; +} +#define htonl(x) (__builtin_constant_p((u32)(x)) ? __htonl_constant(x) : __htonl(x)) +#define ntohl(x) htonl(x) +#define htons(x) __htons_constant(x) +#define ntohs(x) htons(x) + static inline u32 getesp(void) { u32 esp; asm("movl %%esp, %0" : "=rm"(esp)); @@ -395,11 +410,4 @@ extern u8 BiosChecksum; // version (auto generated file out/version.c) extern const char VERSION[]; -// XXX - optimize -#define ntohl(x) ((((x)&0xff)<<24) | (((x)&0xff00)<<8) | \ - (((x)&0xff0000) >> 8) | (((x)&0xff000000) >> 24)) -#define htonl(x) ntohl(x) -#define ntohs(x) ((((x)&0xff)<<8) | (((x)&0xff00)>>8)) -#define htons(x) ntohs(x) - #endif // util.h

1 0