SeaBIOS July 2014

seabios@seabios.org

10 participants
10 discussions

Current tip not booting from USB or SD cards
by Stefan Berger 10 Sep '14

10 Sep '14

Hello! The current git tip does not boot from USB or SD cards on an Acer C720. The issue seems to stem from: ab9d771ce14d5b8d38cde373d15a51b45efb99c6 is the first bad commit commit ab9d771ce14d5b8d38cde373d15a51b45efb99c6 Author: Kevin O'Connor <kevin(a)koconnor.net> Date: Sat Jun 14 12:48:35 2014 -0400 ehci: Update usb command timeouts to use usb_xfer_time() Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> :040000 040000 4fcdb230f8fcffc0d8256225eb3c3220bd2293d4 78b62cb78cc3537da5a2ce1f1417fb1e0a571ba1 M src Regards, Stefan

2 2

[PATCH v8 0/8] Add TPM support to SeaBIOS
by Stefan Berger 28 Aug '14

28 Aug '14

This is a repost of a series of patches providing TPM support to SeaBIOS. As an addition, this patch series now works on the Acer C720 Chromebook with limitations (S3 not getting invoked; no logging into TCPA table). The patch series cleanly applies to a checkout of tags/rel-1.7.5. The following set of patches add TPM and Trusted Computing support to SeaBIOS. In particular the patches add: - a TPM driver for the Qemu's TPM TIS emulation (not yet in Qemu git) - ACPI support for the TPM device (SSDT table) - ACPI support for measurement logging (TCPA table) - Support for initialzation of the TPM - Support for the TCG BIOS extensions (1ah handler [ah = 0xbb]) (used by trusted grub; http://trousers.sourceforge.net/grub.html) - Static Root of Trusted for Measurement (SRTM) support - Support for S3 resume (sends command to TPM upon resume) - TPM-specific menu for controlling aspects of the TPM All implementations necessarily follow specifications. When all patches are applied the following services are available - SSDT ACPI table for TPM support - initialization of the TPM upon VM start and S3 resume - Static root of trust for measurements (SRTM) that measures (some) data of SeaBIOS in TCPA ACPI table - 1ah interrupt handler offering APIs for measuring and sending commands to the TPM (trusted grub uses them) - User menu for controlling aspects of the state of the TPM Stefan Berger (8): Add an implementation of a TPM TIS driver Provide ACPI SSDT table for TPM device + S3 resume support Implementation of the TCG BIOS extensions Support for BIOS interrupt handler Add 'measurement' code to the BIOS Add a menu for TPM control Add a menu item for displaying TPM diagnostics Make the TPM menu work on a Chromebook (Acer C720) Makefile | 12 +- src/Kconfig | 15 + src/boot.c | 28 +- src/cdrom.c | 10 + src/clock.c | 12 + src/config.h | 1 + src/fw/acpi-tpm-ssdt.dsl | 24 + src/fw/acpi-tpm-ssdt.hex | 27 + src/fw/acpi.c | 41 + src/hw/tpm_drivers.c | 273 ++++++ src/hw/tpm_drivers.h | 91 ++ src/optionroms.c | 4 + src/post.c | 9 + src/resume.c | 2 + src/sha1.c | 145 +++ src/sha1.h | 8 + src/std/acpi.h | 20 + src/tcgbios.c | 2208 ++++++++++++++++++++++++++++++++++++++++++++++ src/tcgbios.h | 431 +++++++++ src/util.h | 32 + 20 files changed, 3388 insertions(+), 5 deletions(-) create mode 100644 src/fw/acpi-tpm-ssdt.dsl create mode 100644 src/fw/acpi-tpm-ssdt.hex create mode 100644 src/hw/tpm_drivers.c create mode 100644 src/hw/tpm_drivers.h create mode 100644 src/sha1.c create mode 100644 src/sha1.h create mode 100644 src/tcgbios.c create mode 100644 src/tcgbios.h -- 1.8.1.4

4 26

Coverity detected issues in SeaBIOS
by Ian Campbell 17 Jul '14

17 Jul '14

Hello, We run Coverity on the Xen source code occasionally and it happens to include SeaBIOS. The following new warnings have appeared since I pulled in rel-1.7.5. At least the MISSING_BREAK ones look likely to be valid to me. Not sure about the other two... Ian. -------- Forwarded Message -------- From: scan-admin(a)coverity.com Subject: New Defects reported by Coverity Scan for XenProject Date: Wed, 16 Jul 2014 07:16:19 -0700 Message-id: <53c68933a9a35_6cda4073389495a(a)209.249.196.67.mail> Hi, Please find the latest report on new defect(s) introduced to XenProject found with Coverity Scan. Defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s) ** CID 1226281: Unchecked return value (CHECKED_RETURN) /tools/firmware/seabios-dir-remote/src/fw/smbios.c: 578 in smbios_legacy_setup() ** CID 1226282: Missing break in switch (MISSING_BREAK) /tools/firmware/seabios-dir-remote/src/hw/blockcmd.c: 49 in cdb_cmd_data() ** CID 1226283: Missing break in switch (MISSING_BREAK) /tools/firmware/seabios-dir-remote/src/hw/blockcmd.c: 52 in cdb_cmd_data() ** CID 1226284: Missing break in switch (MISSING_BREAK) /tools/firmware/seabios-dir-remote/src/hw/blockcmd.c: 55 in cdb_cmd_data() ** CID 1226285: Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) /tools/firmware/seabios-dir-remote/src/hw/usb-xhci.c: 698 in configure_xhci() ________________________________________________________________________________________________________ *** CID 1226281: Unchecked return value (CHECKED_RETURN) /tools/firmware/seabios-dir-remote/src/fw/smbios.c: 578 in smbios_legacy_setup() 572 } 573 } 574 575 add_struct(32, p); 576 /* Add any remaining provided entries before the end marker */ 577 for (i = 0; i < 256; i++) >>> CID 1226281: Unchecked return value (CHECKED_RETURN) >>> Calling "get_external" without checking return value (as is done elsewhere 12 out of 13 times). 578 get_external(i, &p, &nr_structs, &max_struct_size, end); 579 add_struct(127, p); 580 581 #undef add_struct 582 583 smbios_entry_point_setup(max_struct_size, p - start, start, nr_structs); 584 free(start); ________________________________________________________________________________________________________ *** CID 1226282: Missing break in switch (MISSING_BREAK) /tools/firmware/seabios-dir-remote/src/hw/blockcmd.c: 49 in cdb_cmd_data() 43 return esp_scsi_cmd_data(op, cdbcmd, blocksize); 44 case DTYPE_MEGASAS: 45 return megasas_cmd_data(op, cdbcmd, blocksize); 46 case DTYPE_USB_32: 47 if (!MODESEGMENT) 48 return usb_cmd_data(op, cdbcmd, blocksize); >>> CID 1226282: Missing break in switch (MISSING_BREAK) >>> The above case falls through to this one. 49 case DTYPE_UAS_32: 50 if (!MODESEGMENT) 51 return uas_cmd_data(op, cdbcmd, blocksize); 52 case DTYPE_PVSCSI: 53 if (!MODESEGMENT) 54 return pvscsi_cmd_data(op, cdbcmd, blocksize); ________________________________________________________________________________________________________ *** CID 1226283: Missing break in switch (MISSING_BREAK) /tools/firmware/seabios-dir-remote/src/hw/blockcmd.c: 52 in cdb_cmd_data() 46 case DTYPE_USB_32: 47 if (!MODESEGMENT) 48 return usb_cmd_data(op, cdbcmd, blocksize); 49 case DTYPE_UAS_32: 50 if (!MODESEGMENT) 51 return uas_cmd_data(op, cdbcmd, blocksize); >>> CID 1226283: Missing break in switch (MISSING_BREAK) >>> The above case falls through to this one. 52 case DTYPE_PVSCSI: 53 if (!MODESEGMENT) 54 return pvscsi_cmd_data(op, cdbcmd, blocksize); 55 case DTYPE_AHCI_ATAPI: 56 if (!MODESEGMENT) 57 return ahci_cmd_data(op, cdbcmd, blocksize); ________________________________________________________________________________________________________ *** CID 1226284: Missing break in switch (MISSING_BREAK) /tools/firmware/seabios-dir-remote/src/hw/blockcmd.c: 55 in cdb_cmd_data() 49 case DTYPE_UAS_32: 50 if (!MODESEGMENT) 51 return uas_cmd_data(op, cdbcmd, blocksize); 52 case DTYPE_PVSCSI: 53 if (!MODESEGMENT) 54 return pvscsi_cmd_data(op, cdbcmd, blocksize); >>> CID 1226284: Missing break in switch (MISSING_BREAK) >>> The above case falls through to this one. 55 case DTYPE_AHCI_ATAPI: 56 if (!MODESEGMENT) 57 return ahci_cmd_data(op, cdbcmd, blocksize); 58 default: 59 return DISK_RET_EPARAM; 60 } ________________________________________________________________________________________________________ *** CID 1226285: Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) /tools/firmware/seabios-dir-remote/src/hw/usb-xhci.c: 698 in configure_xhci() 692 free(spba); 693 free(pad); 694 goto fail; 695 } 696 int i; 697 for (i = 0; i < spb; i++) >>> CID 1226285: Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) >>> Potentially overflowing expression "i * 4096" with type "int" (32 bits, signed) is evaluated using 32-bit arithmetic before being used in a context which expects an expression of type "u64" (64 bits, unsigned). To avoid overflow, cast either operand to "u64" before performing the multiplication. 698 spba[i] = (u32)pad + (i * PAGE_SIZE); 699 xhci->devs[0].ptr_low = (u32)spba; 700 xhci->devs[0].ptr_high = 0; 701 } 702 703 reg = readl(&xhci->op->usbcmd); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, http://scan.coverity.com/projects/606?tab=overview To unsubscribe from the email notification for new defects, http://scan5.coverity.com/cgi-bin/unsubscribe.py

3 3

Coreboot/Seabios cold boot laptop keyboard does not work
by Inez G 17 Jul '14

17 Jul '14

I have setup Coreboot with Seabios to run on a Lenovo X131e laptop. It works fine, except for the non-responsive keyboard on cold boots. With a warm reboot (restart) I can use the laptop keyboard to press F10 and then specify the number for the operating system/drive I want to boot from. But with a cold boot (from a previously powered-off state), the laptop keyboard does not work until I get to the password prompt in linux. So, with a cold boot, Seabios just defaults to boot from the first device in the boot order. An external USB keyboard, however, works fine (for both cold and warm reboots) to enter F10 for the boot order and to select the OS/drive I want. I tried setting the boot-menu-wait and the ps2-keyboard-spinup options with times as high as 90 seconds (90,000 milli sec), but the laptop keyboard still did not work on a cold boot. After the 90 seconds, Seabios just selects the first device to boot from. Any suggestions? Thanks

3 2

How to load but not run Option ROMs?
by Paul Menzel 16 Jul '14

16 Jul '14

Dear SeaBIOS folks, in the thread *Help for Coreboot project* [1] on the coreboot mailing list, Denis Carikli wrote that to get graphics under Linux (not GRUB or SeaBIOS) with AMD/ATI graphics devices it is enough to place/load(?) the Video BIOS/VGA Option ROM at the right place and not run it. The same is needed for some Intel devices (Google Chromebooks) so the VBT, needed for setting up the panel, is found. Enabling that option in coreboot (currently only possible by changing `def_bool` to `y`) and disabling Option ROM handling in SeaBIOS did not work. I think SeaBIOS overwrote the region (`/proc/iomem`). Looking for configuration options in SeaBIOS, there is the Kconfig option `OPTIONROMS_DEPLOYED`, which only available for QEMU though. Also it uses placed/loaded Option ROMs and still runs them. I guess more Kconfig options have to be added to support my use case. Is that wanted or should I do as Denis wrote and patch the SeaBIOS locally? Thanks, Paul [1] http://www.coreboot.org/pipermail/coreboot/2014-July/078293.html [2] http://review.coreboot.org/5594

3 2

[PATCH v3] hw/pci: reserve IO and mem for pci express downstream ports with no devices attached
by Marcel Apfelbaum 02 Jul '14

02 Jul '14

Commit c6e298e1f12e0f4ca02b6da5e42919ae055f6830 hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached introduced support for hot-plugging devices behind pci-2-pci bridges. Extend hotplug support also for pci express downstream ports. Signed-off-by: Marcel Apfelbaum <marcel.a(a)redhat.com> --- v2 -> v3: Addressed Michael S. Tsirkin comments: - Refactored pci_bus_hotplug_support function. - Removed PCI_EXP_FLAGS_TYPE_SHIFT macro. v1 -> v2: Wrong prefix on first patch. src/fw/pciinit.c | 34 ++++++++++++++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/src/fw/pciinit.c b/src/fw/pciinit.c index 0ad548f..fd5dfb9 100644 --- a/src/fw/pciinit.c +++ b/src/fw/pciinit.c @@ -636,6 +636,36 @@ pci_region_create_entry(struct pci_bus *bus, struct pci_device *dev, return entry; } +static int pci_bus_hotplug_support(struct pci_bus *bus) +{ + u8 pcie_cap = pci_find_capability(bus->bus_dev, PCI_CAP_ID_EXP); + u8 shpc_cap; + + if (pcie_cap) { + u16 pcie_flags = pci_config_readw(bus->bus_dev->bdf, + pcie_cap + PCI_EXP_FLAGS); + u8 port_type = ((pcie_flags & PCI_EXP_FLAGS_TYPE) >> + (__builtin_ffs(PCI_EXP_FLAGS_TYPE) - 1)); + u8 downstream_port = (port_type == PCI_EXP_TYPE_DOWNSTREAM) || + (port_type == PCI_EXP_TYPE_ROOT_PORT); + /* + * PCI Express SPEC, 7.8.2: + * Slot Implemented – When Set, this bit indicates that the Link + * HwInit associated with this Port is connected to a slot (as + * compared to being connected to a system-integrated device or + * being disabled). + * This bit is valid for Downstream Ports. This bit is undefined + * for Upstream Ports. + */ + u16 slot_implemented = pcie_flags & PCI_EXP_FLAGS_SLOT; + + return downstream_port && slot_implemented; + } + + shpc_cap = pci_find_capability(bus->bus_dev, PCI_CAP_ID_SHPC); + return !!shpc_cap; +} + static int pci_bios_check_devices(struct pci_bus *busses) { dprintf(1, "PCI: check devices\n"); @@ -678,7 +708,7 @@ static int pci_bios_check_devices(struct pci_bus *busses) continue; struct pci_bus *parent = &busses[pci_bdf_to_bus(s->bus_dev->bdf)]; int type; - u8 shpc_cap = pci_find_capability(s->bus_dev, PCI_CAP_ID_SHPC); + int hotplug_support = pci_bus_hotplug_support(s); for (type = 0; type < PCI_REGION_TYPE_COUNT; type++) { u64 align = (type == PCI_REGION_TYPE_IO) ? PCI_BRIDGE_IO_MIN : PCI_BRIDGE_MEM_MIN; @@ -687,7 +717,7 @@ static int pci_bios_check_devices(struct pci_bus *busses) if (pci_region_align(&s->r[type]) > align) align = pci_region_align(&s->r[type]); u64 sum = pci_region_sum(&s->r[type]); - if (!sum && shpc_cap) + if (!sum && hotplug_support) sum = align; /* reserve min size for hot-plug */ u64 size = ALIGN(sum, align); int is64 = pci_bios_bridge_region_is64(&s->r[type], -- 1.8.3.1

3 5

SeaBIOS TPM support on Chromebook Acer C720
by Stefan Berger 01 Jul '14

01 Jul '14

Hello! I added support from the TPM to SeaBIOS and have parts of the BIOS functionality successfully running on a Chromebook Acer C720 (as example hardware). Here are some findings on the Acer: The TPM is successfully detected but sending TPM_Startup(ST_Clear) to the TPM fails since either coreboot or some other firmware seems to already have initialized the TPM, which is fine, and also extended PCR 0 with at least one hash. Ideally there would be a TCPA ACPI table containing information about what was logged, since otherwise the state of the PCR seems not that useful. SeaBIOS's TPM extensions could then also use this TCPA table and add its own logs into it along with extending PCRs in the TPM. So, in this case the TPM SeaBIOS extensions don't log anything and adding additional ACPI tables to the existing coreboot tables seems 'impractical'. I was wondering if coreboot could add such a table if a TPM was found to be present? Regards, Stefan An older version of the SeaBIOS TPM patches can be found here (for now): http://www.seabios.org/pipermail/seabios/2011-August/002252.html

1 0

Jenkins build is back to normal : seabios #124
by Jenkins Build Host 01 Jul '14

01 Jul '14

See <http://jenkins.xeni.kraxel.org:8080/job/seabios/124/changes>

1 0

[Fwd: Build failed in Jenkins: seabios #123]
by Gerd Hoffmann 01 Jul '14

01 Jul '14

Hi, vgabios build is broken in master ... cheers, Gerd PS: The jenkins box is not reachable from the internet, so the links don't work. PPS: I've added the list address to the jenkins build reports. Mails should be infrequent (only failures are reported). -------- Forwarded Message -------- From: Jenkins Build Host <jenkins(a)kraxel.org> To: kraxel(a)gmail.com Subject: Build failed in Jenkins: seabios #123 Date: Tue, 1 Jul 2014 06:59:58 +0200 (CEST) See <http://jenkins.xeni.kraxel.org:8080/job/seabios/123/changes> Changes: [kevin] romlayout: Use "rep ; nop" not "rep nop". ------------------------------------------ [...truncated 617 lines...] ATA 32bit PIO (ATA_PIO32) [N/y/?] (NEW) AHCI controllers (AHCI) [Y/n/?] (NEW) virtio-blk controllers (VIRTIO_BLK) [Y/n/?] (NEW) virtio-scsi controllers (VIRTIO_SCSI) [Y/n/?] (NEW) PVSCSI controllers (PVSCSI) [Y/n/?] (NEW) AMD PCscsi controllers (ESP_SCSI) [Y/n/?] (NEW) lsi53c895a scsi controllers (LSI_SCSI) [Y/n/?] (NEW) LSI MegaRAID SAS controllers (MEGASAS) [Y/n/?] (NEW) Floppy controller (FLOPPY) [Y/n/?] (NEW) PS/2 port (PS2PORT) [Y/n/?] (NEW) USB (USB) [Y/n/?] (NEW) USB UHCI controllers (USB_UHCI) [Y/n/?] (NEW) USB OHCI controllers (USB_OHCI) [Y/n/?] (NEW) USB EHCI controllers (USB_EHCI) [Y/n/?] (NEW) USB XHCI controllers (USB_XHCI) [Y/n/?] (NEW) USB drives (USB_MSC) [Y/n/?] (NEW) UAS drives (USB_UAS) [Y/n/?] (NEW) USB hubs (USB_HUB) [Y/n/?] (NEW) USB keyboards (USB_KEYBOARD) [Y/n/?] (NEW) USB mice (USB_MOUSE) [Y/n/?] (NEW) Serial port (SERIAL) [Y/n/?] (NEW) Parallel port (LPT) [Y/n/?] (NEW) Use ACPI timer (PMTIMER) [Y/n/?] (NEW) * * BIOS interfaces * Drive interface (DRIVES) [Y/n/?] (NEW) DVD/CDROM booting (CDROM_BOOT) [Y/n/?] (NEW) DVD/CDROM boot drive emulation (CDROM_EMU) [Y/n/?] (NEW) PCIBIOS interface (PCIBIOS) [Y/n/?] (NEW) APM interface (APMBIOS) [Y/n/?] (NEW) PnP BIOS interface (PNPBIOS) [Y/n/?] (NEW) Option ROMS (OPTIONROMS) [Y/n/?] (NEW) PMM interface (PMM) [Y/n/?] (NEW) Boot interface (BOOT) [Y/n/?] (NEW) Keyboard interface (KEYBOARD) [Y/n/?] (NEW) Keyboard hook interface (KBD_CALL_INT15_4F) [Y/n/?] (NEW) Mouse interface (MOUSE) [Y/n/?] (NEW) S3 resume (S3_RESUME) [Y/n/?] (NEW) Hardware specific VGA helpers (VGAHOOKS) [Y/n/?] (NEW) Disable A20 (DISABLE_A20) [N/y/?] (NEW) * * VGA ROM * VGA Hardware Type 1. None (NO_VGABIOS) (NEW) 2. GeodeGX2 (VGA_GEODEGX2) (NEW) 3. GeodeLX (VGA_GEODELX) (NEW) > 4. coreboot linear framebuffer (VGA_COREBOOT) choice[1-4]: Allocate an internal stack for 16bit interrupt entry point (VGA_ALLOCATE_EXTRA_STACK) [Y/n/?] (NEW) Video BIOS Extensions (VBE) (VGA_VBE) [Y/n/?] (NEW) * * Debugging * Debug level (DEBUG_LEVEL) [1] (NEW) Serial port debugging (DEBUG_SERIAL) [N/y/?] (NEW) Special IO port debugging (DEBUG_IO) [N/y/?] n coreboot cbmem debug logging (DEBUG_COREBOOT) [Y/n/?] (NEW) # # configuration written to <http://jenkins.xeni.kraxel.org:8080/job/seabios/ws/rpmbuild/rpm/BUILD/seabi…> # + make Build Kconfig config file Compile checking out/src/misc.o Compile checking out/src/stacks.o Compile checking out/src/output.o Compile checking out/src/string.o Compile checking out/src/block.o Compile checking out/src/cdrom.o Compile checking out/src/disk.o Compile checking out/src/mouse.o Compile checking out/src/kbd.o Compile checking out/src/system.o Compile checking out/src/serial.o Compile checking out/src/clock.o Compile checking out/src/resume.o Compile checking out/src/pnpbios.o Compile checking out/src/vgahooks.o Compile checking out/src/pcibios.o Compile checking out/src/apm.o Compile checking out/src/hw/pci.o Compile checking out/src/hw/timer.o Compile checking out/src/hw/rtc.o Compile checking out/src/hw/dma.o Compile checking out/src/hw/pic.o Compile checking out/src/hw/ps2port.o Compile checking out/src/hw/serialio.o Compile checking out/src/hw/usb.o Compile checking out/src/hw/usb-uhci.o Compile checking out/src/hw/usb-ohci.o Compile checking out/src/hw/usb-ehci.o Compile checking out/src/hw/usb-hid.o Compile checking out/src/hw/usb-msc.o Compile checking out/src/hw/usb-uas.o Compile checking out/src/hw/blockcmd.o Compile checking out/src/hw/floppy.o Compile checking out/src/hw/ata.o Compile checking out/src/hw/ramdisk.o Compile checking out/src/hw/virtio-ring.o Compile checking out/src/hw/virtio-pci.o Compile checking out/src/hw/virtio-blk.o Compile checking out/src/hw/virtio-scsi.o Compile checking out/src/hw/lsi-scsi.o Compile checking out/src/hw/esp-scsi.o Compile checking out/src/hw/megasas.o Compile checking out/src/post.o Compile checking out/src/memmap.o Compile checking out/src/malloc.o Compile checking out/src/romfile.o Compile checking out/src/x86.o Compile checking out/src/optionroms.o Compile checking out/src/pmm.o Compile checking out/src/font.o Compile checking out/src/boot.o Compile checking out/src/bootsplash.o Compile checking out/src/jpeg.o Compile checking out/src/bmp.o Compile checking out/src/hw/ahci.o Compile checking out/src/hw/pvscsi.o Compile checking out/src/hw/usb-xhci.o Compile checking out/src/hw/usb-hub.o Compile checking out/src/fw/coreboot.o Compile checking out/src/fw/lzmadecode.o Compile checking out/src/fw/csm.o Compile checking out/src/fw/biostables.o Compile checking out/src/fw/paravirt.o Compile checking out/src/fw/shadow.o Compile checking out/src/fw/pciinit.o Compile checking out/src/fw/smm.o Compile checking out/src/fw/smp.o Compile checking out/src/fw/mtrr.o Compile checking out/src/fw/xen.o Compiling IASL out/src/fw/acpi-dsdt.hex ASL Input: out/src/fw/acpi-dsdt.dsl.i - 474 lines, 19153 bytes, 315 keywords AML Output: out/src/fw/acpi-dsdt.aml - 4405 bytes, 159 named objects, 156 executable opcodes Listing File: out/src/fw/acpi-dsdt.lst - 142998 bytes Hex Dump: out/src/fw/acpi-dsdt.hex - 41661 bytes Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 245 Optimizations Compiling IASL out/src/fw/ssdt-proc.hex ASL Input: out/src/fw/ssdt-proc.dsl.i - 35 lines, 762 bytes, 8 keywords AML Output: out/src/fw/ssdt-proc.aml - 120 bytes, 6 named objects, 2 executable opcodes Listing File: out/src/fw/ssdt-proc.lst - 2651 bytes Hex Dump: out/src/fw/ssdt-proc.hex - 1459 bytes Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 0 Optimizations Compiling IASL out/src/fw/ssdt-pcihp.hex ASL Input: out/src/fw/ssdt-pcihp.dsl.i - 36 lines, 758 bytes, 5 keywords AML Output: out/src/fw/ssdt-pcihp.aml - 87 bytes, 5 named objects, 0 executable opcodes Listing File: out/src/fw/ssdt-pcihp.lst - 2347 bytes Hex Dump: out/src/fw/ssdt-pcihp.hex - 1160 bytes Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 0 Optimizations Compiling IASL out/src/fw/ssdt-misc.hex ASL Input: out/src/fw/ssdt-misc.dsl.i - 101 lines, 2567 bytes, 35 keywords AML Output: out/src/fw/ssdt-misc.aml - 354 bytes, 24 named objects, 11 executable opcodes Listing File: out/src/fw/ssdt-misc.lst - 7656 bytes Hex Dump: out/src/fw/ssdt-misc.hex - 3710 bytes Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 2 Optimizations Compiling IASL out/src/fw/q35-acpi-dsdt.hex ASL Input: out/src/fw/q35-acpi-dsdt.dsl.i - 514 lines, 28284 bytes, 413 keywords AML Output: out/src/fw/q35-acpi-dsdt.aml - 7344 bytes, 239 named objects, 174 executable opcodes Listing File: out/src/fw/q35-acpi-dsdt.lst - 255960 bytes Hex Dump: out/src/fw/q35-acpi-dsdt.hex - 69190 bytes Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 445 Optimizations Compile checking out/src/fw/acpi.o Compile checking out/src/fw/mptable.o Compile checking out/src/fw/pirtable.o Compile checking out/src/fw/smbios.o Compile checking out/src/fw/romfile_loader.o Compiling whole program out/ccode32flat.o Compiling whole program out/code32seg.o Compiling whole program out/ccode16.o Compiling to assembler out/src/asm-offsets.s Generating offset file out/asm-offsets.h Compiling (16bit) out/romlayout.o Building ld scripts Version: 1.7.5-39.b123.g68354a6-20140701_065955-jenkins.xeni.kraxel.org Fixed space: 0xe05b-0x10000 total: 8101 slack: 13 Percent slack: 0.2% 16bit size: 35236 32bit segmented size: 1679 32bit flat size: 21840 32bit flat init size: 47632 Lowmem size: 2160 f-segment var size: 1197 Linking out/rom16.o Stripping out/rom16.strip.o Linking out/rom32seg.o Stripping out/rom32seg.strip.o Linking out/rom.o Prepping out/bios.bin.prep Total size: 112304 Fixed: 59952 Free: 18768 (used 85.7% of 128KiB rom) Creating out/bios.bin.elf Compile checking out/vgasrc/vgainit.o Compile checking out/vgasrc/vgabios.o Compile checking out/vgasrc/vgafb.o Compile checking out/vgasrc/vgafonts.o Compile checking out/vgasrc/vbe.o Compile checking out/vgasrc/stdvga.o Compile checking out/vgasrc/stdvgamodes.o Compile checking out/vgasrc/stdvgaio.o Compile checking out/vgasrc/clext.o Compile checking out/vgasrc/bochsvga.o Compile checking out/vgasrc/geodevga.o Compile checking out/vgasrc/cbvga.o Compiling whole program out/vgaccode16.raw.s Fixup VGA rom assembler Compiling (16bit) out/vgaentry.o Precompiling out/vgasrc/vgalayout.lds Linking out/vgarom.o Version: 1.7.5-39.b123.g68354a6-20140701_065957-jenkins.xeni.kraxel.org `.rodata' referenced in section `.text.dump_regs' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.dump_regs' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.dump_regs' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.__debug_stub' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.vga_set_mode' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.vga_post' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.vga_post' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.vga_post' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.vga_post' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.vga_post' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.vga_post' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.vga_post' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.vga_post' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.vga_post' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.vga_post' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.handle_104f' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.handle_104f' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.handle_104f' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.handle_104f' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.handle_104f' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.handle_104f' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.handle_104f' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.handle_104f' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.handle_10' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.handle_10' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.handle_10' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.handle_10' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o `.rodata' referenced in section `.text.handle_10' of out/vgaccode16.o: defined in discarded section `.rodata' of out/vgaccode16.o make: *** [out/vgarom.o] Error 1 error: Bad exit status from /var/tmp/rpm-tmp.rZ6X5X (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.rZ6X5X (%build) Build step 'Execute shell' marked build as failure Archiving artifacts

2 1

expecting string instruction after `rep' with latest SeaBIOS
by Ian Campbell 01 Jul '14

01 Jul '14

Building the seabios defconfig on a 64-bit Debian Wheezy system I'm seeing: Compiling (16bit) out/romlayout.o src/romlayout.S: Assembler messages: src/romlayout.S:285: Error: expecting string instruction after `rep' make: *** [out/romlayout.o] Error 1 That line is: // Acquire lock and take ownership of shared stack 1: rep nop I've also checked the preprocessed version and the nop isn't being disappeared or anything like that. This is with 083ee297ef88d "ohci: Update usb command timeouts to use usb_xfer_time()". I don't see it with the rel-1.7.5 tag. git bisect has fingered 0673b7870063a ""smp: Replace QEMU SMP init assembler code with C; run only in 32bit mode.", which makes sense since it made those additions to romlayout.S Other than a compiler bug I can't think what might be going on. Debian Wheezy has gcc 4.7.2 and binutils 2.22. Ian.

3 4

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS July 2014