Hello! I'm having problems with K-TEK-M275TP-FN-BL-ML keyboard
(http://www.key-tek.cn/Productview.asp?id=777). It is USB device with
keyboard and touchpad combined. It works in OS correctly, but doesn't work
in SeaBIOS.
I've tried to debug this issue and found that "usb_kbd_setup" function fails
on "(epdesc->wMaxPacketSize != 8)" check, cause "epdesc->wMaxPacketSize" is
actually 32. I've modified this "if" statement to pass 32 value also and now
function completes successfully. But it didn't help to solve my issue. There
are no interrupts from keyboard, "ehci_poll_intr" always returns -1 on
check:
if (token & QTD_STS_ACTIVE) {
// No intrs found.
return -1;
}
I don't know what to do now. What should I check next?
Does SeaBIOS support USB keyboard+touchpad devices at all?
Changes from v0 -> v1
Patch 1/3
*Rename sts to value
Patch 2/3
*No Change
Patch 3/3
*No longer sending command to the TPM. Instead check the
InterfaceVersion field in the TPM_INTF_CAPABILITY register if necessary.
*Removed "Tested-by:" since I wasn't able to find 1.2 hardware for
regression test.
Stephen Douthit (3):
tpm: Refactor duplicated wait code in tis_wait_sts() & crb_wait_reg()
tpm: Wait for interface startup when probing
tpm: Handle unimplemented TIS_REG_IFACE_ID in tis_get_tpm_version()
src/hw/tpm_drivers.c | 113 +++++++++++++++++++++++++++------------------------
1 file changed, 60 insertions(+), 53 deletions(-)
--
2.14.3
Hello all,
I ran into an issue getting a Infineon SLB9670 2.0 TPM running on an
Intel Denverton platform, and traced the problem to what seems to be
incorrect behavior of tis_get_tpm_version(). That function is returning
the version of the interface, and it seems the device version is what is
needed. The version check implemented here is based on the tpm2_probe()
function in the Linux tpm_tis driver.
This patch set applies on top of Marc-André and Stefan's "Add CRB TPM
device" patch series currently under review
I've tested this on real hardware with a SLB9670 hanging off of an
Intel C3758, but have not regression tested with TPM 1.2 devices.
Regards,
Steve
Stephen Douthit (3):
tpm: Refactor duplicated wait code in tis_wait_sts() & crb_wait_reg()
tpm: Wait for interface startup when probing
tpm: Support 2.0 TPM devices connected to a TIS host
src/hw/tpm_drivers.c | 114 +++++++++++++++++++++++++++------------------------
src/std/tcg.h | 1 +
src/tcgbios.c | 2 +-
src/tcgbios.h | 4 ++
4 files changed, 66 insertions(+), 55 deletions(-)
--
2.14.3
I was experimenting with old MS-DOS 6.22 under QEMU with the 'isapc' machine
type, and found it is not able to reboot the guest. Bisecting QEMU blamed
the QEMU change that rebased from "rel-1.9.3", to "rel-1.10.0". Further
bisecting SeaBIOS blames this change:
commit b837e68d5a6c1a5945513f1995875445a1594c8a (refs/bisect/bad)
Author: Kevin O'Connor <kevin(a)koconnor.net>
Date: Mon Nov 9 15:00:19 2015 -0500
resume: Make KVM soft reboot loop detection more flexible
Move the check for soft reboot loops from resume.c to shadow.c and
directly check for the case where the copy of the BIOS in flash
appears to be a memory alias instead. This prevents a hang if an
external reboot request occurs during the BIOS memcpy.
Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net>
I was testing as follows:
$ qemu-system-x86_64 -machine isapc -monitor stdio demo.img
where 'demo.img' is a disk image with MS-DOS installed (FreeDOS shows the
same problem too. Not checked any other OS).
Once C:\ command prompt is showing I enter
(qemu) sendkey ctrl-alt-delete
in the QEMU monitor console. Nothing visible will happen - the cursor will
stay flashing, but it no longer responds to input. Prior to this SeaBIOS
commit it will correctly reboot.
Interesting side note is that this only happens with QEMUs 'isapc' machine
type. The 'pc' machine type is still rebooting fine.
If I enable the isa-debugcon device in QEMU I see this when the 'isapc'
machine tries to reboot:
In resume (status=0)
In 32bit resume
Attempting a hard reboot
Unable to hard-reboot machine - attempting shutdown.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
The following series implements a TPM CRB driver. The TIS device with
a TPM 2.0 seems to be ignored by Windows 10, so I implemented a simple
CRB device that has now been integrated into QEMU. With the CRB device,
Windows 10 correctly recognizes and exchanges packets with a TPM 2.0.
Marc-André (and Stefan)
---
v1->v2:
- followed Kevin's suggestions for patch 4/4.
Marc-André Lureau (4):
x86: add readq()
tpm: generalize init_timeout()
tpm: use get_tpm_version() callback
tpm: add TPM CRB device support
src/hw/tpm_drivers.c | 224 ++++++++++++++++++++++++++++++++++++++++++++++++---
src/hw/tpm_drivers.h | 26 ++++++
src/x86.h | 5 ++
3 files changed, 243 insertions(+), 12 deletions(-)
--
2.5.5
On Sun, Feb 25, 2018 at 08:51:56PM +0300, Mike Banon wrote:
> >
> > Please see the developer documentation:
> >
>
> I am afraid this documentation does not answer why this build problem
> does not happen when I apply this patch to the standalone cloned seabios
> while it does happens when I apply it to the seabios built by a coreboot
The default seabios configuration is to build for qemu and not
coreboot. So, by default it would not include that code and would not
raise a compile time error. If you configured seabios to build for
coreboot and it didn't raise a compile time error then that seems like
a build defect.
-Kevin
The following series implements a TPM CRB driver. The TIS device with
a TPM 2.0 seems to be ignored by Windows 10, so I implemented a simple
CRB device that has now been integrated into QEMU. With the CRB device,
Windows 10 correctly recognizes and exchanges packets with a TPM 2.0.
Marc-André (and Stefan)
Marc-André Lureau (4):
x86: add readq()
tpm: generalize init_timeout()
tpm: use get_tpm_version() callback
tpm: add TPM CRB device support
src/hw/tpm_drivers.c | 226 ++++++++++++++++++++++++++++++++++++++++++++++++---
src/hw/tpm_drivers.h | 26 ++++++
src/x86.h | 5 ++
3 files changed, 245 insertions(+), 12 deletions(-)
--
2.5.5
On Sun, Feb 25, 2018 at 03:05:06AM +0300, Mike Banon wrote:
> Friends, I need your help. While trying to improve SeaBIOS I got stuck
> at this very strange problem - which does not appear when you do a
> standalone build of SeaBIOS but it happens when you try building a
> coreboot together with SeaBIOS. Steps to reproduce:
Please see the developer documentation:
https://www.seabios.org/Developer_Documentation
In particular, read the "memory model" and "execution and code phase"
documents.
-Kevin
Dear Mike,
Am 25.02.2018 um 01:05 schrieb Mike Banon:
> Friends, I need your help. While trying to improve SeaBIOS I got stuck
> at this very strange problem - which does not appear when you do a
> standalone build of SeaBIOS but it happens when you try building a
> coreboot together with SeaBIOS. Steps to reproduce:
Please attach your patch, so that it can easily applied and the build
problem reproduced.
[…]
Kind regards,
Paul
