November 2022 - SeaBIOS - mail.coreboot.org

[PATCH 0/4] misc tweaks for kvm and the 64bit pci window
by Gerd Hoffmann Jan. 20, 2023

Jan. 20, 2023

Gerd Hoffmann (4): better kvm detection detect physical address space size move 64bit pci window to end of address space be less conservative with the 64bit pci io window src/fw/paravirt.h | 2 ++ src/fw/paravirt.c | 87 ++++++++++++++++++++++++++++++++++++++++++----- src/fw/pciinit.c | 16 ++++++++- 3 files changed, 96 insertions(+), 9 deletions(-) -- 2.38.1

5 11

[PATCH v4 0/4] Make seabios linkable with lld
by Fangrui Song Dec. 7, 2022

Dec. 7, 2022

Another try after https://mail.coreboot.org/hyperkitty/list/seabios@seabios.org/thread/KBHQU4… The only change is the removal of `Makefile: Change ET_EXEC to ET_REL so that lld can link bios.bin.elf` since 699a4e5d6919cc8eae5342443025ceb6909dc276 ("ldnoexec: Add script to remove ET_EXEC flag from intermediate build objects") has done the same thing. For your convenience, the patch series is available on https://github.com/MaskRay/seabios/tree/lld Re-sending. I posted this 3 days but got bounced. I have now ensured there is my email address record on (previously not) https://mail.coreboot.org/postorius/lists/seabios.seabios.org/ as well as https://mail.coreboot.org/hyperkitty/list/seabios@seabios.org/ Fangrui Song (4): romlayout.S: Add missing SHF_ALLOC flag to .fixedaddr.\addr Make rom16.o linkable with lld romlayout32flag.lds: Use `. +=` instead of `. =` test-build.sh: Delete unneeded LD capability test scripts/layoutrom.py | 8 +++++++- scripts/test-build.sh | 42 +----------------------------------------- src/romlayout.S | 2 +- 3 files changed, 9 insertions(+), 43 deletions(-) -- 2.37.0.144.g8ac04bfd2-goog

3 7

SeaBIOS USB issues
by Sorin Pop Dec. 2, 2022

Dec. 2, 2022

Hi I have tried to get SeaBIOS to enable usb and mouse support but seabios always gets stuck while I have USB enabled and the devices connected (regardless if it is just the keyboard, mouse, usb mass storage or any combination of them) Below I have attached the logs from coreboot and seabios (I have tested both 1.11 and 1.16 and none work) Does anyone have any clue on what might be the problem? Thanks

2 1

[PATCH] acpi: parse Alias object
by Igor Mammedov Nov. 24, 2022

Nov. 24, 2022

Since QEMU commit dbce582a119 (acpi: pc/q35: drop ad-hoc PCI-ISA bridge AML routines and let bus ennumeration generate AML) SeaBIOS fails to parse ISA bridge AML with: parse_termlist: parse error, skip from 92/517 ... ACPI: no PS/2 keyboard present due to Alias term in DSDT which isn't handled by SeaBIOS properly. Add dumb Alias parsing which just skips over term, so the rest of AML could be parsed successfully. Signed-off-by: Igor Mammedov <imammedo(a)redhat.com> Reported-by: Volker Rümelin <vr_qemu(a)t-online.de> --- src/fw/dsdt_parser.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/fw/dsdt_parser.c b/src/fw/dsdt_parser.c index eb5496f3..2ac82821 100644 --- a/src/fw/dsdt_parser.c +++ b/src/fw/dsdt_parser.c @@ -417,6 +417,10 @@ static int parse_termobj(struct parse_state *s, break; case 0x01: /* one */ break; + case 0x06: /* AliasOp */ + offset += parse_namestring(s, ptr + offset, "SourceObject"); + offset += parse_namestring(s, ptr + offset, "AliasObject"); + break; case 0x08: /* name op */ offset += parse_namestring(s, ptr + offset, "name"); offset += parse_termobj(s, ptr + offset); -- 2.31.1

5 10

[PATCH] fix wrong init of keyboard/mouse's if first interface is not boot protocol
by qi zhou Nov. 23, 2022

Nov. 23, 2022

From 987b295099267bac3012fd401dc3ea34c3e40071 Mon Sep 17 00:00:00 2001 From: Qi Zhou <atmgnd(a)outlook.com> Date: Mon, 14 Nov 2022 20:55:44 +0800 Subject: [PATCH] fix wrong init of keyboard/mouse's if first interface is not boot protocol There is always some endpoint descriptors after each interface descriptor, We should only decrement num_iface if interface type is USB_DT_INTERFACE, see https://www.beyondlogic.org/usbnutshell/usb5.shtml#ConfigurationDescriptors Signed-off-by: Qi Zhou <atmgnd(a)outlook.com> --- src/hw/usb-hid.c | 13 ++++++++----- src/hw/usb.c | 12 +++++++----- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/src/hw/usb-hid.c b/src/hw/usb-hid.c index 92c6b19..dec198a 100644 --- a/src/hw/usb-hid.c +++ b/src/hw/usb-hid.c @@ -22,13 +22,13 @@ struct usb_pipe *mouse_pipe VARFSEG; // Send USB HID protocol message. static int -set_protocol(struct usb_pipe *pipe, u16 val) +set_protocol(struct usb_pipe *pipe, u16 val, u16 inferface) { struct usb_ctrlrequest req; req.bRequestType = USB_DIR_OUT | USB_TYPE_CLASS | USB_RECIP_INTERFACE; req.bRequest = HID_REQ_SET_PROTOCOL; req.wValue = val; - req.wIndex = 0; + req.wIndex = inferface; req.wLength = 0; return usb_send_default_control(pipe, &req, NULL); } @@ -76,9 +76,12 @@ usb_kbd_setup(struct usbdevice_s *usbdev } // Enable "boot" protocol. - int ret = set_protocol(usbdev->defpipe, 0); - if (ret) + int ret = set_protocol(usbdev->defpipe, 0, usbdev->iface->bInterfaceNumber); + if (ret) { + dprintf(3, "Failed to set boot protocol\n"); return -1; + } + // Periodically send reports to enable key repeat. ret = set_idle(usbdev->defpipe, KEYREPEATMS); if (ret) @@ -118,7 +121,7 @@ usb_mouse_setup(struct usbdevice_s *usbdev } // Enable "boot" protocol. - int ret = set_protocol(usbdev->defpipe, 0); + int ret = set_protocol(usbdev->defpipe, 0, usbdev->iface->bInterfaceNumber); if (ret) return -1; diff --git a/src/hw/usb.c b/src/hw/usb.c index 38a866a..409da8c 100644 --- a/src/hw/usb.c +++ b/src/hw/usb.c @@ -372,17 +372,19 @@ configure_usb_device(struct usbdevice_s *usbdev) void *config_end = (void*)config + config->wTotalLength; struct usb_interface_descriptor *iface = (void*)(&config[1]); for (;;) { - if (!num_iface-- || (void*)iface + iface->bLength > config_end) + if (!num_iface || (void*)iface + iface->bLength > config_end) // Not a supported device. goto fail; - if (iface->bDescriptorType == USB_DT_INTERFACE - && (iface->bInterfaceClass == USB_CLASS_HUB + if (iface->bDescriptorType == USB_DT_INTERFACE) { + num_iface--; + if (iface->bInterfaceClass == USB_CLASS_HUB || (iface->bInterfaceClass == USB_CLASS_MASS_STORAGE && (iface->bInterfaceProtocol == US_PR_BULK || iface->bInterfaceProtocol == US_PR_UAS)) || (iface->bInterfaceClass == USB_CLASS_HID - && iface->bInterfaceSubClass == USB_INTERFACE_SUBCLASS_BOOT))) - break; + && iface->bInterfaceSubClass == USB_INTERFACE_SUBCLASS_BOOT)) + break; + } iface = (void*)iface + iface->bLength; } -- 2.25.1

3 5

[PATCH] virtio-blk: Fix incorrect type conversion in virtio_blk_op()
by Xiaofei Nov. 22, 2022

Nov. 22, 2022

Fixes: a05af290bac5 ("virtio-blk: split large IO according to size_max") When using spdk aio bdev driver, the qemu command line like this: qemu-system-x86_64 \ -chardev socket,id=char0,path=/tmp/vhost.0 \ -device vhost-user-blk-pci,id=blk0,chardev=char0 \ ... Boot failure message as below: e820 map has 7 items: 0: 0000000000000000 - 000000000009fc00 = 1 RAM 1: 000000000009fc00 - 00000000000a0000 = 2 RESERVED 2: 00000000000f0000 - 0000000000100000 = 2 RESERVED 3: 0000000000100000 - 000000007ffdd000 = 1 RAM 4: 000000007ffdd000 - 0000000080000000 = 2 RESERVED 5: 00000000feffc000 - 00000000ff000000 = 2 RESERVED 6: 00000000fffc0000 - 0000000100000000 = 2 RESERVED enter handle_19: NULL Booting from Hard Disk... Boot failed: could not read the boot disk Signed-off-by: Xiaofei <hbuxiaofei(a)gmail.com> --- src/hw/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hw/virtio-blk.c b/src/hw/virtio-blk.c index 9b4a05a..ce3265e 100644 --- a/src/hw/virtio-blk.c +++ b/src/hw/virtio-blk.c @@ -92,7 +92,7 @@ virtio_blk_op(struct disk_op_s *op, int write) u16 blk_num_max; if (vdrive->drive.blksize != 0 && max_io_size != 0) - blk_num_max = (u16)max_io_size / vdrive->drive.blksize; + blk_num_max = (u16)(max_io_size / vdrive->drive.blksize); else /* default blk_num_max if hardware doesnot advise a proper value */ blk_num_max = 64; -- 2.27.0

7 9

[PATCH v1 0/2] virtio: finalize features before using modern device
by Xuan Zhuo Nov. 14, 2022

Nov. 14, 2022

https://www.mail-archive.com/qemu-devel@nongnu.org/msg920776.html Then: $ build/qemu-system-x86_64 -M accel=kvm -m 1G -cpu host -blockdev file,node-name=drive0,filename=test.img -device virtio-blk-pci,drive=drive0 qemu: queue_enable is only suppported in devices of virtio 1.0 or later. In this PATCH, it was added to check the FEATURE VIRTIO_1 when enabling queue. This code should not be executed, but it is reported here. Because Seabios use the legacy sequence to initialize the modern device. The driver MUST follow this sequence to initialize a device: 1. Reset the device. 2. Set the ACKNOWLEDGE status bit: the guest OS has noticed the device. 3. Set the DRIVER status bit: the guest OS knows how to drive the device. > 4. Read device feature bits, and write the subset of feature bits understood by the OS and driver to the device. During this step the driver MAY read (but MUST NOT write) the device-specific configuration fields to check that it can support the device before accepting it. > 5. Set the FEATURES_OK status bit. The driver MUST NOT accept new feature bits after this step. > 6. Re-read device status to ensure the FEATURES_OK bit is still set: otherwise, the device does not support our subset of features and the device is unusable. 7. Perform device-specific setup, including discovery of virtqueues for the device, optional per-bus setup, reading and possibly writing the device’s virtio configuration space, and population of virtqueues. 8. Set the DRIVER_OK status bit. At this point the device is “live”. Test with: qemu-system-x86_64 \ -M microvm,x-option-roms=off,pit=off,pic=off,isa-serial=off,rtc=off \ -global virtio-mmio.force-legacy={false,true} \ -enable-kvm -cpu host -m 512m -smp 2 \ -nodefaults -no-user-config -nographic \ -drive id=test,file=./test.img,format=raw,if=none \ -device virtio-blk-device,drive=test \ -bios ../../seabios/out/bios.bin \ -chardev stdio,id=seabios -device isa-debugcon,iobase=0x402,chardev=seabios qemu-system-x86_64 \ -M microvm,x-option-roms=off,pit=off,pic=off,isa-serial=off,rtc=off \ -global virtio-mmio.force-legacy={false,true} \ -enable-kvm -cpu host -m 512m -smp 2 \ -nodefaults -no-user-config -nographic \ -drive id=test,file=./test.img,format=raw,if=none \ -device virtio-scsi-device \ -bios ../../seabios/out/bios.bin \ -chardev stdio,id=seabios -device isa-debugcon,iobase=0x402,chardev=seabios qemu-system-x86_64 \ -enable-kvm -cpu host -m 512m -smp 2 \ -nodefaults -no-user-config -nographic \ -drive id=test,file=./test.img,format=raw,if=none \ -device virtio-scsi,disable-legacy={off,on},disable-modern={on,off} \ -bios ../../seabios/out/bios.bin \ -chardev stdio,id=seabios -device isa-debugcon,iobase=0x402,chardev=seabios qemu-system-x86_64 \ -enable-kvm -cpu host -m 512m -smp 2 \ -nodefaults -no-user-config -nographic \ -drive id=test,file=./test.img,format=raw,if=none \ -device virtio-blk-pci,drive=test,disable-legacy={off,on},disable-modern={on,off} \ -bios ../../seabios/out/bios.bin \ -chardev stdio,id=seabios -device isa-debugcon,iobase=0x402,chardev=seabios Xuan Zhuo (2): virtio-mmio: read/write the hi 32 features for mmio virtio: finalize features before using device src/hw/virtio-blk.c | 22 +++++++++++++--------- src/hw/virtio-pci.c | 7 +++++-- src/hw/virtio-scsi.c | 13 +++++++++++++ 3 files changed, 31 insertions(+), 11 deletions(-) -- 2.32.0.3.g01195cf9f

3 13

[PATCH] virtio: finalizing features before using device
by Xuan Zhuo Nov. 14, 2022

Nov. 14, 2022

Under the standard of Virtio 1.0, the initialization process of the device must first write sub-features back to device before using device, such as finding vqs. There are four places using vp_find_vq(). 1. virtio-blk.pci: put the finalizing features code in front of using device 2. virtio-blk.mmio: put the finalizing features code in front of using device 3. virtio-scsi.pci: is ok 4. virtio-scsi.mmio: add set features before vp_find_vq() Signed-off-by: Xuan Zhuo <xuanzhuo(a)linux.alibaba.com> --- src/hw/virtio-blk.c | 23 ++++++++++++++--------- src/hw/virtio-scsi.c | 18 ++++++++++++++++++ 2 files changed, 32 insertions(+), 9 deletions(-) diff --git a/src/hw/virtio-blk.c b/src/hw/virtio-blk.c index 9b4a05a..52eb08f 100644 --- a/src/hw/virtio-blk.c +++ b/src/hw/virtio-blk.c @@ -151,10 +151,6 @@ init_virtio_blk(void *data) vdrive->drive.cntl_id = pci->bdf; vp_init_simple(&vdrive->vp, pci); - if (vp_find_vq(&vdrive->vp, 0, &vdrive->vq) < 0 ) { - dprintf(1, "fail to find vq for virtio-blk %pP\n", pci); - goto fail; - } if (vdrive->vp.use_modern) { struct vp_device *vp = &vdrive->vp; @@ -212,7 +208,15 @@ init_virtio_blk(void *data) vp_read(&vp->device, struct virtio_blk_config, heads); vdrive->drive.pchs.sector = vp_read(&vp->device, struct virtio_blk_config, sectors); - } else { + } + + + if (vp_find_vq(&vdrive->vp, 0, &vdrive->vq) < 0 ) { + dprintf(1, "fail to find vq for virtio-blk %pP\n", pci); + goto fail; + } + + if (!vdrive->vp.use_modern) { struct virtio_blk_config cfg; vp_get_legacy(&vdrive->vp, 0, &cfg, sizeof(cfg)); @@ -272,10 +276,6 @@ init_virtio_blk_mmio(void *mmio) vdrive->drive.cntl_id = (u32)mmio; vp_init_mmio(&vdrive->vp, mmio); - if (vp_find_vq(&vdrive->vp, 0, &vdrive->vq) < 0 ) { - dprintf(1, "fail to find vq for virtio-blk-mmio %p\n", mmio); - goto fail; - } struct vp_device *vp = &vdrive->vp; u64 features = vp_get_features(vp); @@ -294,6 +294,11 @@ init_virtio_blk_mmio(void *mmio) goto fail; } + if (vp_find_vq(&vdrive->vp, 0, &vdrive->vq) < 0 ) { + dprintf(1, "fail to find vq for virtio-blk-mmio %p\n", mmio); + goto fail; + } + if (features & max_segment_size) vdrive->drive.max_segment_size = vp_read(&vp->device, struct virtio_blk_config, size_max); diff --git a/src/hw/virtio-scsi.c b/src/hw/virtio-scsi.c index 369c981..cf131fb 100644 --- a/src/hw/virtio-scsi.c +++ b/src/hw/virtio-scsi.c @@ -239,6 +239,24 @@ init_virtio_scsi_mmio(void *mmio) vp_init_mmio(vp, mmio); u8 status = VIRTIO_CONFIG_S_ACKNOWLEDGE | VIRTIO_CONFIG_S_DRIVER; + { + u64 features = vp_get_features(vp); + u64 version1 = 1ull << VIRTIO_F_VERSION_1; + u64 iommu_platform = 1ull << VIRTIO_F_IOMMU_PLATFORM; + if (!(features & version1)) { + dprintf(1, "modern device without virtio_1 feature bit: %pP\n", mmio); + goto fail; + } + + vp_set_features(vp, features & (version1 | iommu_platform)); + status |= VIRTIO_CONFIG_S_FEATURES_OK; + vp_set_status(vp, status); + if (!(vp_get_status(vp) & VIRTIO_CONFIG_S_FEATURES_OK)) { + dprintf(1, "device didn't accept features: %pP\n", mmio); + goto fail; + } + } + if (vp_find_vq(vp, 2, &vq) < 0 ) { dprintf(1, "fail to find vq for virtio-scsi-mmio %p\n", mmio); goto fail; -- 2.32.0.3.g01195cf9f

5 11

[PATCH 1/1] virtio-blk: Fix incorrect type conversion in virtio_blk_op()
by Xiaofei Nov. 11, 2022

Nov. 11, 2022

When using spdk aio bdev driver, the qemu command line like this: qemu-system-x86_64 \ -chardev socket,id=char0,path=/tmp/vhost.0 \ -device vhost-user-blk-pci,id=blk0,chardev=char0 \ ... Boot failure message as below: e820 map has 7 items: 0: 0000000000000000 - 000000000009fc00 = 1 RAM 1: 000000000009fc00 - 00000000000a0000 = 2 RESERVED 2: 00000000000f0000 - 0000000000100000 = 2 RESERVED 3: 0000000000100000 - 000000007ffdd000 = 1 RAM 4: 000000007ffdd000 - 0000000080000000 = 2 RESERVED 5: 00000000feffc000 - 00000000ff000000 = 2 RESERVED 6: 00000000fffc0000 - 0000000100000000 = 2 RESERVED enter handle_19: NULL Booting from Hard Disk... Boot failed: could not read the boot disk Signed-off-by: Xiaofei <hbuxiaofei(a)gmail.com> --- src/hw/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hw/virtio-blk.c b/src/hw/virtio-blk.c index 9b4a05a..ce3265e 100644 --- a/src/hw/virtio-blk.c +++ b/src/hw/virtio-blk.c @@ -92,7 +92,7 @@ virtio_blk_op(struct disk_op_s *op, int write) u16 blk_num_max; if (vdrive->drive.blksize != 0 && max_io_size != 0) - blk_num_max = (u16)max_io_size / vdrive->drive.blksize; + blk_num_max = (u16)(max_io_size / vdrive->drive.blksize); else /* default blk_num_max if hardware doesnot advise a proper value */ blk_num_max = 64; -- 2.27.0

2 2

Re: [PATCH 1/1] virtio-blk: Fix incorrect type conversion in virtio_blk_op()
by Xiaofei Nov. 11, 2022

Nov. 11, 2022

On Fri, 11 Nov 2022 09:35:19 +0800 Fei Xiao <hbuxiaofei(a)gmail.com> wrote: > [Cc: +Andy] > > Dear Xiaofei, > > > Thank you very much for the patch. > > Am 10.11.22 um 06:34 schrieb Xiaofei: > > When using spdk aio bdev driver, the qemu command line like > > this: > > Please remove the leading spaces in the line above. > > > qemu-system-x86_64 \ > > -chardev socket,id=char0,path=/tmp/vhost.0 \ > > -device vhost-user-blk-pci,id=blk0,chardev=char0 \ > > ... > > > > Boot failure message as below: > > Ditto. > > > e820 map has 7 items: > > 0: 0000000000000000 - 000000000009fc00 = 1 RAM > > 1: 000000000009fc00 - 00000000000a0000 = 2 RESERVED > > 2: 00000000000f0000 - 0000000000100000 = 2 RESERVED > > 3: 0000000000100000 - 000000007ffdd000 = 1 RAM > > 4: 000000007ffdd000 - 0000000080000000 = 2 RESERVED > > 5: 00000000feffc000 - 00000000ff000000 = 2 RESERVED > > 6: 00000000fffc0000 - 0000000100000000 = 2 RESERVED > > enter handle_19: > > NULL > > Booting from Hard Disk... > > Boot failed: could not read the boot disk > > Is this a regression in commit a05af290bac5 (virtio-blk: split large > IO according to size_max). If so, maybe add > > Fixes: a05af290bac5 ("virtio-blk: split large IO according to > size_max") > > > Signed-off-by: Xiaofei <hbuxiaofei(a)gmail.com> > > --- > > src/hw/virtio-blk.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/hw/virtio-blk.c b/src/hw/virtio-blk.c > > index 9b4a05a..ce3265e 100644 > > --- a/src/hw/virtio-blk.c > > +++ b/src/hw/virtio-blk.c > > @@ -92,7 +92,7 @@ virtio_blk_op(struct disk_op_s *op, int write) > > u16 blk_num_max; > > > > if (vdrive->drive.blksize != 0 && max_io_size != 0) > > - blk_num_max = (u16)max_io_size / vdrive->drive.blksize; > > + blk_num_max = (u16)(max_io_size / vdrive->drive.blksize); > > else > > /* default blk_num_max if hardware doesnot advise a > > proper > value */ > > blk_num_max = 64; > > Acked-by: Paul Menzel <pmenzel(a)molgen.mpg.de> > > > Kind regards, > > Paul > > > -- > > 2.27.0 > > > > _______________________________________________ > > SeaBIOS mailing list -- seabios(a)seabios.org > > To unsubscribe send an email to seabios-leave(a)seabios.org Thanks for your suggestion, this is indeed a bug of patch a05af290bac5. I will remove useless leading spaces. Regards, Xiaofei

1 0