SeaBIOS January 2012

seabios@seabios.org

20 participants
71 discussions

Re: [SeaBIOS] Geode vga pci code
by Kevin O'Connor 21 Jan '12

21 Jan '12

On Tue, Jan 17, 2012 at 12:06:54AM +0100, Nils wrote: > Op maandag 16-01-2012 om 00:23 uur [tijdzone -0500], schreef Kevin > O'Connor: > > Oh - it was on top of the recent patches I sent to the mailing list. > OK sorry! > > Now that i used that patch set also everything compiles. > > First i used your instructions and named the vgarom: "pci100b,0030.rom" > but then the vgabios is not run. (See attachment v475.log) Make sure you have CONFIG_VGA_BRIDGE_SETUP set in coreboot. Otherwise, I don't understand why it wouldn't run. (Your logs seem to indicate that optionroms.c:is_pci_vga() is failing - which I think would only happen if CONFIG_VGA_BRIDGE_SETUP isn't set.) > Second i used vgaroms/vgabios.bin as the vgabios name. > The vgabios gets run but i get no display output and SeaBIOS reboots > over and over. (see attachment v475-2.log) Yeah - it will break if it gets run via "vgaroms/" - I'll change the vgabios code to check for this. > This could have to do with vga region setup. > I wil investigate in the next day's (when i find time) how to initialize > MSR's to get pci access set up. > > Should the E820 table also reflect the vga range? > (I have no clue how to fix that) The e820 shouldn't have anything to do with this. -Kevin

2 3

Error booting from USB Storage Device in QEMU-KVM GIT MASTER
by Dyweni - Qemu-Devel 20 Jan '12

20 Jan '12

Hi, I am unable to boot KVM using a usb flash drive. I'm using QEMU-KVM built from GIT MASTER as of this morning. Here's my QEMU-KVM startup options: qemu-system-x86_64 \ -curses \ -m 512 \ -snapshot \ -device piix3-usb-uhci \ -drive id=usbflash,file=flash.img,if=none,boot=on,cache=writeback \ -device usb-storage,drive=usbflash \ -net nic,macaddr=$(getmacpublic),vlan=0 -net tap,vlan=0,ifname=$publictap,script=no \ -net nic,macaddr=$(getmacprivate),vlan=1 -net tap,vlan=1,ifname=$privatetap,script=no \ $* Here's the debugging output from SeaBIOS. (Notice the 'Unable to configure USB MSC device.' message): + qemu-system-x86_64 -m 512 -snapshot -device piix3-usb-uhci -drive id=usbflash,file=flash.img,if=none,boot=on,cache=writeback -device usb-storage,drive=usbflash -net nic,macaddr=00:AA:00:AA:62:AA,vlan=0 -net tap,vlan=0,ifname=tap0,script=no -net nic,macaddr=00:AA:00:D2:D1:BB,vlan=1 -net tap,vlan=1,ifname=tap1,script=no -chardev stdio,id=seabios -device isa-debugcon,iobase=0x402,chardev=seabios qemu-kvm: boot=on|off is deprecated and will be ignored. Future versions will reject this parameter. Please update your scripts. Start bios (version 1.6.3) Ram Size=0x20000000 (0x0000000000000000 high) Relocating init from 0x000e3b20 to 0x1ffe12e0 (size 60412) CPU Mhz=3601 === PCI bus & bridge init === PCI: pci_bios_init_bus_rec bus = 0x0 === PCI device probing === Found 8 PCI devices (max PCI bus is 00) === PCI new allocation pass #1 === PCI: check devices bus 0 === PCI new allocation pass #2 === PCI: init bases bus 0 (primary) type io max 100 sum 230 base c000 size 100: 2 bar(s), c000 -> c1ff size 20: 1 bar(s), c200 -> c21f size 10: 1 bar(s), c220 -> c22f type mem max 10000 sum 33000 base febc0000 size 10000: 3 bar(s), febc0000 -> febeffff size 1000: 3 bar(s), febf0000 -> febf2fff type prefmem max 2000000 sum 2000000 base fc000000 size 2000000: 1 bar(s), fc000000 -> fdffffff PCI: map device bus 0, bfd 0x0 PCI: map device bus 0, bfd 0x8 PCI: map device bus 0, bfd 0x9 bar 4, addr c220, size 10 [io] PCI: map device bus 0, bfd 0xb PCI: map device bus 0, bfd 0x10 bar 0, addr fc000000, size 2000000 [mem] bar 1, addr febf0000, size 1000 [mem] bar 6, addr febc0000, size 10000 [mem] PCI: map device bus 0, bfd 0x18 bar 0, addr c000, size 100 [io] bar 1, addr febf1000, size 100 [mem] bar 6, addr febd0000, size 10000 [mem] PCI: map device bus 0, bfd 0x20 bar 0, addr c100, size 100 [io] bar 1, addr febf2000, size 100 [mem] bar 6, addr febe0000, size 10000 [mem] PCI: map device bus 0, bfd 0x28 bar 4, addr c200, size 20 [io] PCI: bus=0 devfn=0x00: vendor_id=0x8086 device_id=0x1237 PCI: bus=0 devfn=0x08: vendor_id=0x8086 device_id=0x7000 PCI: bus=0 devfn=0x09: vendor_id=0x8086 device_id=0x7010 PCI: bus=0 devfn=0x0b: vendor_id=0x8086 device_id=0x7113 PCI: bus=0 devfn=0x10: vendor_id=0x1013 device_id=0x00b8 PCI: bus=0 devfn=0x18: vendor_id=0x10ec device_id=0x8139 PCI: bus=0 devfn=0x20: vendor_id=0x10ec device_id=0x8139 PCI: bus=0 devfn=0x28: vendor_id=0x8086 device_id=0x7020 PIIX3/PIIX4 init: elcr=00 0c Found 1 cpu(s) max supported 1 cpu(s) MP table addr=0x000fd620 MPC table addr=0x000fd630 size=240 SMBIOS ptr=0x000fd600 table=0x000fd4f0 size=263 ACPI tables: RSDP=0x000fd4c0 RSDT=0x1fffd7b0 Scan for VGA option rom Running option rom at c000:0003 Turning on vga text mode console SeaBIOS (version 1.6.3) UHCI init on dev 00:05.0 (io=c200) Found 1 lpt ports Found 1 serial ports ATA controller 1 at 1f0/3f4/0 (irq 14 dev 9) ATA controller 2 at 170/374/0 (irq 15 dev 9) DVD/CD [ata1-0: QEMU DVD-ROM ATAPI-4 DVD/CD] Searching bootorder for: /pci@i0cf8/*@1,1/drive@1/disk@0 ebda moved from 9fc00 to 9f800 USB MSC vendor='QEMU' product='QEMU HARDDISK' rev='1.0.' type=0 removable=0 Unable to configure USB MSC device. PS2 keyboard initialized All threads complete. Scan for option roms Running option rom at c900:0003 pmm call arg1=1 pmm call arg1=0 pmm call arg1=1 pmm call arg1=0 Running option rom at ca00:0003 pmm call arg1=1 pmm call arg1=1 Searching bootorder for: /pci@i0cf8/*@3 Searching bootorder for: /pci@i0cf8/*@4 Searching bootorder for: /rom(a)genroms/vapic.bin Running option rom at cb00:0003 ebda moved from 9f800 to 9f000 Returned 53248 bytes of ZoneHigh e820 map has 7 items: 0: 0000000000000000 - 000000000009f000 = 1 RAM 1: 000000000009f000 - 00000000000a0000 = 2 RESERVED 2: 00000000000f0000 - 0000000000100000 = 2 RESERVED 3: 0000000000100000 - 000000001fffd000 = 1 RAM 4: 000000001fffd000 - 0000000020000000 = 2 RESERVED 5: 00000000feffc000 - 00000000ff000000 = 2 RESERVED 6: 00000000fffc0000 - 0000000100000000 = 2 RESERVED enter handle_19: NULL Booting from DVD/CD... Device reports MEDIUM NOT PRESENT atapi_is_ready returned -1 Boot failed: Could not read from CDROM (code 0003) enter handle_18: NULL Booting from ROM... Booting from c900:0372 enter handle_18: NULL Booting from ROM... Booting from ca00:0372 In resume (status=0) In 32bit resume Attempting a hard reboot -- Thanks, Dyweni

3 4

Re: [SeaBIOS] [PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback
by Kevin O'Connor 20 Jan '12

20 Jan '12

On Thu, Jan 19, 2012 at 03:02:30PM +0100, Vasilis Liaskovitis wrote: > On Fri, Jan 13, 2012 at 07:27:01PM -0500, Kevin O'Connor wrote: > > > > [...] > > > Method (CPEJ, 2, NotSerialized) { > > > // _EJ0 method - eject callback > > > + Store(ShiftLeft(1, Arg0), PRE) > > > Sleep(200) > > > } > > > I have another question here: the PCI _EJO callback seems to return 0x0, but > the CPU _EJ0 doesn't return anything. THe ACPIspec4.0a draft section 6.3.3 > mentions that _EJx methods have no return value. Is the above difference > intentional? If the spec says it doesn't return anything, but the acpi code is, it's probably just an error. -Kevin

1 0

Re: [SeaBIOS] [PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback
by Kevin O'Connor 19 Jan '12

19 Jan '12

On Fri, Jan 13, 2012 at 12:11:30PM +0100, Vasilis Liaskovitis wrote: > > Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis(a)profitbricks.com> The SeaBIOS change is okay with me, but the qemu/kvm change needs to be accepted first. [...] > Method (CPEJ, 2, NotSerialized) { > // _EJ0 method - eject callback > + Store(ShiftLeft(1, Arg0), PRE) > Sleep(200) > } Is the Sleep() still needed? -Kevin

2 2

[RFC] acpi: Do not advertise S3
by Luiz Capitulino 16 Jan '12

16 Jan '12

S3 is broken in qemu in the following ways: 1. S3 is immediately followed by a resume (or it doesn't even take place) 2. The screen goes black after S3 3. Some people reported a hang (I couldn't reproduce it myself) Chances are we can get these bugs fixed for 1.1, until there let's not advertise S3 to prevent things like qemu-ga from breaking qemu. Signed-off-by: Luiz Capitulino <lcapitulino(a)redhat.com> --- src/acpi-dsdt.dsl | 3 +++ src/acpi-dsdt.hex | 16 ++-------------- 2 files changed, 5 insertions(+), 14 deletions(-) diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 7082b65..2bd8d95 100644 --- a/src/acpi-dsdt.dsl +++ b/src/acpi-dsdt.dsl @@ -599,6 +599,8 @@ DefinitionBlock ( * S3 (suspend-to-ram), S4 (suspend-to-disk) and S5 (power-off) type codes: * must match piix4 emulation. */ +#if 0 + S3 is br0ken in qemu, do not advertise it Name (\_S3, Package (0x04) { 0x01, /* PM1a_CNT.SLP_TYP */ @@ -606,6 +608,7 @@ DefinitionBlock ( Zero, /* reserved */ Zero /* reserved */ }) +#endif Name (\_S4, Package (0x04) { Zero, /* PM1a_CNT.SLP_TYP */ diff --git a/src/acpi-dsdt.hex b/src/acpi-dsdt.hex index 5dc7bb4..9dcef05 100644 --- a/src/acpi-dsdt.hex +++ b/src/acpi-dsdt.hex @@ -3,12 +3,12 @@ static unsigned char AmlCode[] = { 0x53, 0x44, 0x54, -0xd3, +0xc7, 0x10, 0x0, 0x0, 0x1, -0x2d, +0xa3, 0x42, 0x58, 0x50, @@ -3850,18 +3850,6 @@ static unsigned char AmlCode[] = { 0x8, 0x5f, 0x53, -0x33, -0x5f, -0x12, -0x6, -0x4, -0x1, -0x1, -0x0, -0x0, -0x8, -0x5f, -0x53, 0x34, 0x5f, 0x12, -- 1.7.9.rc0.dirty

4 4

Re: [SeaBIOS] [PATCH 2/3] acpi_piix4: Add stub functions for CPU eject callback
by Avi Kivity 16 Jan '12

16 Jan '12

On 01/16/2012 01:32 PM, Vasilis Liaskovitis wrote: > On Sun, Jan 15, 2012 at 02:38:52PM +0200, Avi Kivity wrote: > > On 01/13/2012 01:11 PM, Vasilis Liaskovitis wrote: > > > Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis(a)profitbricks.com> > > > --- > > > hw/acpi_piix4.c | 15 +++++++++++++++ > > > 1 files changed, 15 insertions(+), 0 deletions(-) > > > > > > diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c > > > index d5743b6..8bf30dd 100644 > > > --- a/hw/acpi_piix4.c > > > +++ b/hw/acpi_piix4.c > > > @@ -37,6 +37,7 @@ > > > > > > #define GPE_BASE 0xafe0 > > > #define PROC_BASE 0xaf00 > > > +#define PROC_EJ_BASE 0xaf20 > > > > > > > We're adding stuff to piix4 which was never there. At a minimum this > > needs to be documented. Also needs to be -M pc-1.1 and later only. > > Where should this be documented? PCI/ACPI hotplug addresses are documented in > docs/specs/acpi_pci_hotplug.txt A pleasant surprise > but for CPU hotplug documentation (i.e. > for the existing PROC_BASE) I don't see relevant documentation. I will > create a docs/specs/acpi_cpu_hotplug.txt if that sounds reasonable. I suggest renaming it to acpi_hotplug.txt, so it covers both cases. > For pc-1.1, a new QEMUmachine type will be needed I assume. Should a check be > made against the machine version in the piix4 code? any relevant examples? > The standard practice is to set a property. See for example pc_machine_v0_14 in hw/pc_piix.c, it autosets properties for devices (erroneously called "drivers" in the code). btw, I notice the I/O ports are write only and don't remember their state. I can't think offhand if there's anything bad about it (in fact not having state makes live migration more robust), but perhaps someone else will. -- error compiling committee.c: too many arguments to function

1 0

Re: [SeaBIOS] [PATCH 2/3] acpi_piix4: Add stub functions for CPU eject callback
by Avi Kivity 16 Jan '12

16 Jan '12

On 01/13/2012 01:11 PM, Vasilis Liaskovitis wrote: > Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis(a)profitbricks.com> > --- > hw/acpi_piix4.c | 15 +++++++++++++++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c > index d5743b6..8bf30dd 100644 > --- a/hw/acpi_piix4.c > +++ b/hw/acpi_piix4.c > @@ -37,6 +37,7 @@ > > #define GPE_BASE 0xafe0 > #define PROC_BASE 0xaf00 > +#define PROC_EJ_BASE 0xaf20 > We're adding stuff to piix4 which was never there. At a minimum this needs to be documented. Also needs to be -M pc-1.1 and later only. -- error compiling committee.c: too many arguments to function

2 1

[PATCH 0/4] vgabios Kconfig improvements
by Kevin O'Connor 16 Jan '12

16 Jan '12

Improvements to the Kconfig system. Namely, this series allows the main makefile target to build the vgabios if selected. (Thanks Nils for pointing this out.) It also fixes an issue causing the PCI vendor id and device id to often not be populated. -Kevin Kevin O'Connor (4): vgabios: Improve vgabios Kconfig menu. vgabios: Build vgabios by default if enabled in Kconfig. vgabios: Move vgabios Kconfig definitions to vgasrc/Kconfig. vgabios: Make VBE code depend on a config setting. Makefile | 42 ++++++++++++++----------- src/Kconfig | 55 +--------------------------------- vgasrc/Kconfig | 87 +++++++++++++++++++++++++++++++++++++++++++++++++++++ vgasrc/bochsvga.c | 1 - vgasrc/clext.c | 1 - vgasrc/vbe.c | 3 +- vgasrc/vgabios.h | 1 - 7 files changed, 112 insertions(+), 78 deletions(-) create mode 100644 vgasrc/Kconfig -- 1.7.6.4

1 4

[PATCH 0/3] Rename vgatables.c to stdvgamodes.c
by Kevin O'Connor 16 Jan '12

16 Jan '12

Minor cleanup - almost everything in vgatables in specific to the standard vga interface - name the file more clearly. -Kevin Kevin O'Connor (3): vgabios: Move static_functionality[] from vgatables.c to vgabios.c. vgabios: Move video_param_table definition to vgabios.c. vgabios: Rename vgatables.c to stdvgamodes.c. Makefile | 2 +- vgasrc/stdvga.h | 3 +- vgasrc/stdvgamodes.c | 362 +++++++++++++++++++++++++++++++++++++++++++ vgasrc/vgabios.c | 34 ++++- vgasrc/vgabios.h | 20 ++- vgasrc/vgatables.c | 419 -------------------------------------------------- 6 files changed, 413 insertions(+), 427 deletions(-) create mode 100644 vgasrc/stdvgamodes.c delete mode 100644 vgasrc/vgatables.c -- 1.7.6.4

1 3

Re: [SeaBIOS] Geode vga pci code
by Nils 16 Jan '12

16 Jan '12

Hi Kevin, You have been busy with patches, nice! :) You wrote: >I noticed that the Geode VGA code seems to be doing manual PCI reads - >which is kinda odd. Does the patch below work for you? > >You'll need to register the rom in cbfs as "pci100b,0030.rom", you'll >need to make sure coreboot is enabling the vga memory ranges, and >you'll need to make sure out/autoconf.h really has CONFIG_VGA_DID/VID >defined corectly - but otherwise it should work. I tried to compile your patch but it gave the following error: Linking out/vgarom.o out/vgalayout16.o: In function `vp_setup': /home/nils/seabios/seabios_test4/vgasrc/geodevga.c:267: undefined reference to `pci_config_readl' out/vgalayout16.o: In function `dc_setup': /home/nils/seabios/seabios_test4/vgasrc/geodevga.c:235: undefined reference to `pci_config_readl' make: *** [out/vgarom.o] Error 1 I don't have more time to investigate this further at the moment. (I did the #include "pci.h") Thanks, Nils.

2 1

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS January 2012