SeaBIOS

seabios@seabios.org

4 participants
3801 discussions

Re: [SeaBIOS] [PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback
by Kevin O'Connor 20 Jan '12

20 Jan '12

On Thu, Jan 19, 2012 at 03:02:30PM +0100, Vasilis Liaskovitis wrote: > On Fri, Jan 13, 2012 at 07:27:01PM -0500, Kevin O'Connor wrote: > > > > [...] > > > Method (CPEJ, 2, NotSerialized) { > > > // _EJ0 method - eject callback > > > + Store(ShiftLeft(1, Arg0), PRE) > > > Sleep(200) > > > } > > > I have another question here: the PCI _EJO callback seems to return 0x0, but > the CPU _EJ0 doesn't return anything. THe ACPIspec4.0a draft section 6.3.3 > mentions that _EJx methods have no return value. Is the above difference > intentional? If the spec says it doesn't return anything, but the acpi code is, it's probably just an error. -Kevin

1 0

Re: [SeaBIOS] [PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback
by Kevin O'Connor 19 Jan '12

19 Jan '12

On Fri, Jan 13, 2012 at 12:11:30PM +0100, Vasilis Liaskovitis wrote: > > Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis(a)profitbricks.com> The SeaBIOS change is okay with me, but the qemu/kvm change needs to be accepted first. [...] > Method (CPEJ, 2, NotSerialized) { > // _EJ0 method - eject callback > + Store(ShiftLeft(1, Arg0), PRE) > Sleep(200) > } Is the Sleep() still needed? -Kevin

2 2

[RFC] acpi: Do not advertise S3
by Luiz Capitulino 16 Jan '12

16 Jan '12

S3 is broken in qemu in the following ways: 1. S3 is immediately followed by a resume (or it doesn't even take place) 2. The screen goes black after S3 3. Some people reported a hang (I couldn't reproduce it myself) Chances are we can get these bugs fixed for 1.1, until there let's not advertise S3 to prevent things like qemu-ga from breaking qemu. Signed-off-by: Luiz Capitulino <lcapitulino(a)redhat.com> --- src/acpi-dsdt.dsl | 3 +++ src/acpi-dsdt.hex | 16 ++-------------- 2 files changed, 5 insertions(+), 14 deletions(-) diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 7082b65..2bd8d95 100644 --- a/src/acpi-dsdt.dsl +++ b/src/acpi-dsdt.dsl @@ -599,6 +599,8 @@ DefinitionBlock ( * S3 (suspend-to-ram), S4 (suspend-to-disk) and S5 (power-off) type codes: * must match piix4 emulation. */ +#if 0 + S3 is br0ken in qemu, do not advertise it Name (\_S3, Package (0x04) { 0x01, /* PM1a_CNT.SLP_TYP */ @@ -606,6 +608,7 @@ DefinitionBlock ( Zero, /* reserved */ Zero /* reserved */ }) +#endif Name (\_S4, Package (0x04) { Zero, /* PM1a_CNT.SLP_TYP */ diff --git a/src/acpi-dsdt.hex b/src/acpi-dsdt.hex index 5dc7bb4..9dcef05 100644 --- a/src/acpi-dsdt.hex +++ b/src/acpi-dsdt.hex @@ -3,12 +3,12 @@ static unsigned char AmlCode[] = { 0x53, 0x44, 0x54, -0xd3, +0xc7, 0x10, 0x0, 0x0, 0x1, -0x2d, +0xa3, 0x42, 0x58, 0x50, @@ -3850,18 +3850,6 @@ static unsigned char AmlCode[] = { 0x8, 0x5f, 0x53, -0x33, -0x5f, -0x12, -0x6, -0x4, -0x1, -0x1, -0x0, -0x0, -0x8, -0x5f, -0x53, 0x34, 0x5f, 0x12, -- 1.7.9.rc0.dirty

4 4

Re: [SeaBIOS] [PATCH 2/3] acpi_piix4: Add stub functions for CPU eject callback
by Avi Kivity 16 Jan '12

16 Jan '12

On 01/16/2012 01:32 PM, Vasilis Liaskovitis wrote: > On Sun, Jan 15, 2012 at 02:38:52PM +0200, Avi Kivity wrote: > > On 01/13/2012 01:11 PM, Vasilis Liaskovitis wrote: > > > Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis(a)profitbricks.com> > > > --- > > > hw/acpi_piix4.c | 15 +++++++++++++++ > > > 1 files changed, 15 insertions(+), 0 deletions(-) > > > > > > diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c > > > index d5743b6..8bf30dd 100644 > > > --- a/hw/acpi_piix4.c > > > +++ b/hw/acpi_piix4.c > > > @@ -37,6 +37,7 @@ > > > > > > #define GPE_BASE 0xafe0 > > > #define PROC_BASE 0xaf00 > > > +#define PROC_EJ_BASE 0xaf20 > > > > > > > We're adding stuff to piix4 which was never there. At a minimum this > > needs to be documented. Also needs to be -M pc-1.1 and later only. > > Where should this be documented? PCI/ACPI hotplug addresses are documented in > docs/specs/acpi_pci_hotplug.txt A pleasant surprise > but for CPU hotplug documentation (i.e. > for the existing PROC_BASE) I don't see relevant documentation. I will > create a docs/specs/acpi_cpu_hotplug.txt if that sounds reasonable. I suggest renaming it to acpi_hotplug.txt, so it covers both cases. > For pc-1.1, a new QEMUmachine type will be needed I assume. Should a check be > made against the machine version in the piix4 code? any relevant examples? > The standard practice is to set a property. See for example pc_machine_v0_14 in hw/pc_piix.c, it autosets properties for devices (erroneously called "drivers" in the code). btw, I notice the I/O ports are write only and don't remember their state. I can't think offhand if there's anything bad about it (in fact not having state makes live migration more robust), but perhaps someone else will. -- error compiling committee.c: too many arguments to function

1 0

Re: [SeaBIOS] [PATCH 2/3] acpi_piix4: Add stub functions for CPU eject callback
by Avi Kivity 16 Jan '12

16 Jan '12

On 01/13/2012 01:11 PM, Vasilis Liaskovitis wrote: > Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis(a)profitbricks.com> > --- > hw/acpi_piix4.c | 15 +++++++++++++++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c > index d5743b6..8bf30dd 100644 > --- a/hw/acpi_piix4.c > +++ b/hw/acpi_piix4.c > @@ -37,6 +37,7 @@ > > #define GPE_BASE 0xafe0 > #define PROC_BASE 0xaf00 > +#define PROC_EJ_BASE 0xaf20 > We're adding stuff to piix4 which was never there. At a minimum this needs to be documented. Also needs to be -M pc-1.1 and later only. -- error compiling committee.c: too many arguments to function

2 1

[PATCH 0/4] vgabios Kconfig improvements
by Kevin O'Connor 16 Jan '12

16 Jan '12

Improvements to the Kconfig system. Namely, this series allows the main makefile target to build the vgabios if selected. (Thanks Nils for pointing this out.) It also fixes an issue causing the PCI vendor id and device id to often not be populated. -Kevin Kevin O'Connor (4): vgabios: Improve vgabios Kconfig menu. vgabios: Build vgabios by default if enabled in Kconfig. vgabios: Move vgabios Kconfig definitions to vgasrc/Kconfig. vgabios: Make VBE code depend on a config setting. Makefile | 42 ++++++++++++++----------- src/Kconfig | 55 +--------------------------------- vgasrc/Kconfig | 87 +++++++++++++++++++++++++++++++++++++++++++++++++++++ vgasrc/bochsvga.c | 1 - vgasrc/clext.c | 1 - vgasrc/vbe.c | 3 +- vgasrc/vgabios.h | 1 - 7 files changed, 112 insertions(+), 78 deletions(-) create mode 100644 vgasrc/Kconfig -- 1.7.6.4

1 4

[PATCH 0/3] Rename vgatables.c to stdvgamodes.c
by Kevin O'Connor 16 Jan '12

16 Jan '12

Minor cleanup - almost everything in vgatables in specific to the standard vga interface - name the file more clearly. -Kevin Kevin O'Connor (3): vgabios: Move static_functionality[] from vgatables.c to vgabios.c. vgabios: Move video_param_table definition to vgabios.c. vgabios: Rename vgatables.c to stdvgamodes.c. Makefile | 2 +- vgasrc/stdvga.h | 3 +- vgasrc/stdvgamodes.c | 362 +++++++++++++++++++++++++++++++++++++++++++ vgasrc/vgabios.c | 34 ++++- vgasrc/vgabios.h | 20 ++- vgasrc/vgatables.c | 419 -------------------------------------------------- 6 files changed, 413 insertions(+), 427 deletions(-) create mode 100644 vgasrc/stdvgamodes.c delete mode 100644 vgasrc/vgatables.c -- 1.7.6.4

1 3

Re: [SeaBIOS] Geode vga pci code
by Nils 16 Jan '12

16 Jan '12

Hi Kevin, You have been busy with patches, nice! :) You wrote: >I noticed that the Geode VGA code seems to be doing manual PCI reads - >which is kinda odd. Does the patch below work for you? > >You'll need to register the rom in cbfs as "pci100b,0030.rom", you'll >need to make sure coreboot is enabling the vga memory ranges, and >you'll need to make sure out/autoconf.h really has CONFIG_VGA_DID/VID >defined corectly - but otherwise it should work. I tried to compile your patch but it gave the following error: Linking out/vgarom.o out/vgalayout16.o: In function `vp_setup': /home/nils/seabios/seabios_test4/vgasrc/geodevga.c:267: undefined reference to `pci_config_readl' out/vgalayout16.o: In function `dc_setup': /home/nils/seabios/seabios_test4/vgasrc/geodevga.c:235: undefined reference to `pci_config_readl' make: *** [out/vgarom.o] Error 1 I don't have more time to investigate this further at the moment. (I did the #include "pci.h") Thanks, Nils.

2 1

Re: [SeaBIOS] [RFC] acpi: Do not advertise S3
by Gleb Natapov 15 Jan '12

15 Jan '12

On Sun, Jan 15, 2012 at 12:35:07PM +0100, Fred . wrote: > SeaBIOS is used in more than just QEMU. The DSDT provided by Seabios is not used by anyone but QEMU (and may be XEN). > If QEMU does not support S3, then they should patch (or configure) > SeaBIOS to not advertise S3 support. > > On Sun, Jan 15, 2012 at 10:00 AM, Gleb Natapov <gleb(a)redhat.com> wrote: > > On Fri, Jan 13, 2012 at 05:11:27PM -0200, Luiz Capitulino wrote: > >> S3 is broken in qemu in the following ways: > >> > >> 1. S3 is immediately followed by a resume (or it doesn't even > >> take place) > > The only real problem. I am not aware of "it doesn't even take place" > > part. If there are such cases they are guest problems. Guest can refuse > > to do S3 for number of reasons. This has nothing to do with QEMU. > > > >> 2. The screen goes black after S3 > > Guest problem. > > > >> 3. Some people reported a hang (I couldn't reproduce it myself) > > Guest problem. > > > >> > >> Chances are we can get these bugs fixed for 1.1, until there let's > >> not advertise S3 to prevent things like qemu-ga from breaking qemu. > >> > > I am OK with this, but make it "#if DSDT_S3", so that it can be enabled > > without changing the source. > > > >> Signed-off-by: Luiz Capitulino <lcapitulino(a)redhat.com> > >> --- > >> src/acpi-dsdt.dsl | 3 +++ > >> src/acpi-dsdt.hex | 16 ++-------------- > >> 2 files changed, 5 insertions(+), 14 deletions(-) > >> > >> diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl > >> index 7082b65..2bd8d95 100644 > >> --- a/src/acpi-dsdt.dsl > >> +++ b/src/acpi-dsdt.dsl > >> @@ -599,6 +599,8 @@ DefinitionBlock ( > >> * S3 (suspend-to-ram), S4 (suspend-to-disk) and S5 (power-off) type codes: > >> * must match piix4 emulation. > >> */ > >> +#if 0 > >> + S3 is br0ken in qemu, do not advertise it > >> Name (\_S3, Package (0x04) > >> { > >> 0x01, /* PM1a_CNT.SLP_TYP */ > >> @@ -606,6 +608,7 @@ DefinitionBlock ( > >> Zero, /* reserved */ > >> Zero /* reserved */ > >> }) > >> +#endif > >> Name (\_S4, Package (0x04) > >> { > >> Zero, /* PM1a_CNT.SLP_TYP */ > >> diff --git a/src/acpi-dsdt.hex b/src/acpi-dsdt.hex > >> index 5dc7bb4..9dcef05 100644 > >> --- a/src/acpi-dsdt.hex > >> +++ b/src/acpi-dsdt.hex > >> @@ -3,12 +3,12 @@ static unsigned char AmlCode[] = { > >> 0x53, > >> 0x44, > >> 0x54, > >> -0xd3, > >> +0xc7, > >> 0x10, > >> 0x0, > >> 0x0, > >> 0x1, > >> -0x2d, > >> +0xa3, > >> 0x42, > >> 0x58, > >> 0x50, > >> @@ -3850,18 +3850,6 @@ static unsigned char AmlCode[] = { > >> 0x8, > >> 0x5f, > >> 0x53, > >> -0x33, > >> -0x5f, > >> -0x12, > >> -0x6, > >> -0x4, > >> -0x1, > >> -0x1, > >> -0x0, > >> -0x0, > >> -0x8, > >> -0x5f, > >> -0x53, > >> 0x34, > >> 0x5f, > >> 0x12, > >> -- > >> 1.7.9.rc0.dirty > > > > -- > > Gleb. > > > > _______________________________________________ > > SeaBIOS mailing list > > SeaBIOS(a)seabios.org > > http://www.seabios.org/mailman/listinfo/seabios -- Gleb.

2 2

Geode vga pci code
by Kevin O'Connor 15 Jan '12

15 Jan '12

Hi Nils, I noticed that the Geode VGA code seems to be doing manual PCI reads - which is kinda odd. Does the patch below work for you? You'll need to register the rom in cbfs as "pci100b,0030.rom", you'll need to make sure coreboot is enabling the vga memory ranges, and you'll need to make sure out/autoconf.h really has CONFIG_VGA_DID/VID defined corectly - but otherwise it should work. -Kevin --- a/vgasrc/geodevga.c +++ b/vgasrc/geodevga.c @@ -7,12 +7,13 @@ // This file may be distributed under the terms of the GNU LGPLv3 license. #include "geodevga.h" // geodevga_init -#include "ioport.h" // outb #include "farptr.h" // SET_FARVAR #include "biosvar.h" // GET_BDA #include "vgabios.h" // VGAREG_* #include "util.h" // memset #include "stdvga.h" // stdvga_crtc_write +#include "pci.h" // pci_config_readl +#include "pci_regs.h" // PCI_BASE_ADDRESS_0 /**************************************************************** @@ -226,8 +227,7 @@ static int dc_setup(void) /* read fb-bar from pci, then point dc to the fb base */ dc_fb = dc_read(seg,DC_GLIU0_MEM_OFFSET); - outl(GEODE_PCI_FB,PORT_PCI_CMD); - fb = inl(PORT_PCI_DATA); + fb = pci_config_readl(GET_GLOBAL(VgaBDF), PCI_BASE_ADDRESS_0); if (fb!=dc_fb) { dc_write(seg,DC_GLIU0_MEM_OFFSET,fb); } @@ -254,13 +254,12 @@ int vp_setup(void) dprintf(2,"VP_SETUP\n"); /* set output to crt and RGB/YUV */ if (CONFIG_VGA_GEODEGX2) - geode_msrWrite(VP_MSR_CONFIG_GX2,~0 ,~0xf8,0,0); + geode_msrWrite(VP_MSR_CONFIG_GX2, ~0, ~0xf8, 0, 0); else - geode_msrWrite(VP_MSR_CONFIG_LX,~0 ,~0xf8,0,0); + geode_msrWrite(VP_MSR_CONFIG_LX, ~0, ~0xf8, 0, 0); /* get vp register base from pci */ - outl(GEODE_PCI_VP,PORT_PCI_CMD); - vp = inl(PORT_PCI_DATA); + vp = pci_config_readl(GET_GLOBAL(VgaBDF), PCI_BASE_ADDRESS_3); /* Set mmio registers * there may be some timing issues here, the reads seem diff --git a/vgasrc/geodevga.h b/vgasrc/geodevga.h index ec019a4..fd7ce43 100644 --- a/vgasrc/geodevga.h +++ b/vgasrc/geodevga.h @@ -26,12 +26,6 @@ #define OEM_BAR2 0x58 #define OEM_BAR3 0x5C -#define GEODE_PCI_ADDR 0x80000900 -#define GEODE_PCI_CMD (GEODE_PCI_ADDR + 0x04) -#define GEODE_PCI_FB (GEODE_PCI_ADDR + 0x10) -#define GEODE_PCI_DC (GEODE_PCI_ADDR + 0x18) -#define GEODE_PCI_VP (GEODE_PCI_ADDR + 0x1c) - #define DC_LOCK_LOCK 0x00000000 #define DC_LOCK_UNLOCK 0x00004758

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS