SeaBIOS

seabios@seabios.org

5 participants
3802 discussions

Re: [SeaBIOS] [Qemu-devel] [PATCH RFC 10/13] i386: generate pc guest info
by Michael S. Tsirkin 14 May '13

14 May '13

On Mon, May 13, 2013 at 09:23:54PM +0100, Peter Maydell wrote: > On 13 May 2013 21:01, Michael S. Tsirkin <mst(a)redhat.com> wrote: > > This fills in guest info table with misc > > information of interest to the guest. > > Will be used by ACPI table generation code. > > Bunch of coding style violations in this patch which will > need fixing at some point in the RFC->patch process. > > thanks > -- PMM I went over it again and found one: + if (ram_size <= 0x80000000) + guest_info->pci_info.w32.begin = 0x80000000; + else if (ram_size <= 0xc0000000) + guest_info->pci_info.w32.begin = 0xc0000000; + else + guest_info->pci_info.w32.begin = 0xe0000000; should use {}. One is not a bunch so I obviously missed some - it might be helpful if you pointed them out. Thanks, -- MST

2 1

Re: [SeaBIOS] [Qemu-devel] [PATCH RFC 08/13] range: add Range structure
by Michael S. Tsirkin 14 May '13

14 May '13

On Mon, May 13, 2013 at 09:20:08PM +0100, Peter Maydell wrote: > On 13 May 2013 21:01, Michael S. Tsirkin <mst(a)redhat.com> wrote: > > Sometimes we need to pass ranges around, add a > > handy structure for this purpose. > > > > Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> > > --- > > include/qemu/range.h | 22 ++++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/include/qemu/range.h b/include/qemu/range.h > > index 3502372..4bcd346 100644 > > --- a/include/qemu/range.h > > +++ b/include/qemu/range.h > > @@ -1,6 +1,28 @@ > > #ifndef QEMU_RANGE_H > > #define QEMU_RANGE_H > > > > +#include <inttypes.h> > > + > > +/* > > + * Operations on 64 address ranges. > > missing "bit" ? > > > + * Notes: > > + * - ranges must not wrap around 0, but can include the last byte ~0x0LL. > > + * - this can not represent a full 0 to ~0x0LL range. > > + */ > > + > > +/* A structure representing a range of addresses. */ > > +struct Range { > > + uint64_t begin; /* First byte of the range, or 0 if empty. */ > > + uint64_t end; /* 1 + the last byte. 0 if range empty or ends at ~0x0LL. */ > > +}; > > +typedef struct Range Range; > > + > > +/* verify that range is not empty and does not overlap */ > > Doesn't overlap what? I meant wrap around there. > Why isn't an empty range valid? > The struct definition above says it's OK. Yes it's a bad name. Should be range_non_empty or something. > > +{ > > + return range->begin + 1 <= range->end; > > +} > > I note that memory.c defines its own concept of an AddrRange. > > thanks > -- PMM Good point, maybe I'll reuse that or just use two 64 bit fields explicitly. -- MST

1 0

Re: [SeaBIOS] [Qemu-devel] [PATCH RFC 01/13] apic: rename apic specific bitopts
by Michael S. Tsirkin 13 May '13

13 May '13

On Mon, May 13, 2013 at 09:22:20PM +0100, Peter Maydell wrote: > On 13 May 2013 21:00, Michael S. Tsirkin <mst(a)redhat.com> wrote: > > apic has its own version of bitops, with the > > difference that it works on u32 and not long. > > Add apic_ prefix to avoid namespace clashes. > > Wouldn't it be better to consolidate so we only have > one set of bitops rather than a local set in this file? > > thanks > -- PMM Yes but I'd like this patchset to focus on acpi. ATM including bitops in pc.h gives build errors. Thus this trivial patch, can be tested by comparing binary. Consolidation is better done in a separate patchset, and would need more testing. Any chance you can do this on top of this? -- MST

1 0

Re: [SeaBIOS] [Qemu-devel] [PATCH RFC 12/13] i386: ACPI table generation code from seabios
by Peter Maydell 13 May '13

13 May '13

On 13 May 2013 21:01, Michael S. Tsirkin <mst(a)redhat.com> wrote: > hw/i386/acpi-build.c | 685 +++++++++++++++++++++++++++++++++++++++++++ I'm sitting here hoping nobody ever asks me to add ACPI support for ARM QEMU :-) [not totally impossible one day in the future...] -- PMM

1 0

Re: [SeaBIOS] [Qemu-devel] [PATCH RFC 10/13] i386: generate pc guest info
by Peter Maydell 13 May '13

13 May '13

On 13 May 2013 21:01, Michael S. Tsirkin <mst(a)redhat.com> wrote: > This fills in guest info table with misc > information of interest to the guest. > Will be used by ACPI table generation code. Bunch of coding style violations in this patch which will need fixing at some point in the RFC->patch process. thanks -- PMM

1 0

Re: [SeaBIOS] [Qemu-devel] [PATCH RFC 01/13] apic: rename apic specific bitopts
by Peter Maydell 13 May '13

13 May '13

On 13 May 2013 21:00, Michael S. Tsirkin <mst(a)redhat.com> wrote: > apic has its own version of bitops, with the > difference that it works on u32 and not long. > Add apic_ prefix to avoid namespace clashes. Wouldn't it be better to consolidate so we only have one set of bitops rather than a local set in this file? thanks -- PMM

1 0

Re: [SeaBIOS] [Qemu-devel] [PATCH RFC 08/13] range: add Range structure
by Peter Maydell 13 May '13

13 May '13

On 13 May 2013 21:01, Michael S. Tsirkin <mst(a)redhat.com> wrote: > Sometimes we need to pass ranges around, add a > handy structure for this purpose. > > Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> > --- > include/qemu/range.h | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/include/qemu/range.h b/include/qemu/range.h > index 3502372..4bcd346 100644 > --- a/include/qemu/range.h > +++ b/include/qemu/range.h > @@ -1,6 +1,28 @@ > #ifndef QEMU_RANGE_H > #define QEMU_RANGE_H > > +#include <inttypes.h> > + > +/* > + * Operations on 64 address ranges. missing "bit" ? > + * Notes: > + * - ranges must not wrap around 0, but can include the last byte ~0x0LL. > + * - this can not represent a full 0 to ~0x0LL range. > + */ > + > +/* A structure representing a range of addresses. */ > +struct Range { > + uint64_t begin; /* First byte of the range, or 0 if empty. */ > + uint64_t end; /* 1 + the last byte. 0 if range empty or ends at ~0x0LL. */ > +}; > +typedef struct Range Range; > + > +/* verify that range is not empty and does not overlap */ Doesn't overlap what? Why isn't an empty range valid? The struct definition above says it's OK. > +static inline bool range_valid(struct Range *range) > +{ > + return range->begin + 1 <= range->end; > +} I note that memory.c defines its own concept of an AddrRange. thanks -- PMM

1 0

Re: [SeaBIOS] [Qemu-devel] [PATCH RFC 02/13] hw/i386/pc.c: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/apic.h
by Eric Blake 13 May '13

13 May '13

On 05/13/2013 02:00 PM, Michael S. Tsirkin wrote: > Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> > Signed-off-by: Laszlo Ersek <lersek(a)redhat.com> > Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> Looks odd to see your sign-off twice :) -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

1 0

another iasl update breaks seabios compilation again
by Michael Tokarev 13 May '13

13 May '13

[Resending after being subscribed to the list] I'm not sure what happened yet, but I noticed that current seabios does not build with 20130214-32 version of iasl. Apparently, the listing file (-l) produced now does not contain any comments from the original source, so tools/acpi_extract.py produce nothing from these files. Here's the diff between listing produced by two versions of iasl for ssdt-pcihp: ---------------- --- out/ssdt-pcihp.lst-20100528 2013-05-09 17:55:43.872160687 +0400 +++ out/ssdt-pcihp.lst-20130214-32 2013-05-09 17:57:45.222803783 +0400 @@ -1,84 +1,72 @@ Intel ACPI Component Architecture -ASL Optimizing Compiler version 20100528 [Jul 2 2010] -Copyright (c) 2000 - 2010 Intel Corporation -Supports ACPI Specification Revision 4.0a - -Compilation of "out/ssdt-pcihp.dsl.i" - Thu May 9 17:55:43 2013 - - 1.... - 2..../* ACPI_EXTRACT_ALL_CODE ssdp_pcihp_aml */ - 3.... - 4....DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPCIHP", 0x1) - -00000000....53 53 44 54 58 00 00 00 "SSDTX..." -00000008....01 77 42 58 50 43 00 00 ".wBXPC.." -00000010....42 58 53 53 44 54 50 43 "BXSSDTPC" -00000018....01 00 00 00 49 4E 54 4C "....INTL" -00000020....28 05 10 20 ............ "(.. " - - 5....{ - 6.... External(\_SB.PCI0, DeviceObj) - 7.... External(\_SB.PCI0.PCEJ, MethodObj) - 8.... Scope(\_SB.PCI0) { - -00000024....10 33 5C 2E 5F 53 42 5F ".3\._SB_" -0000002C....50 43 49 30 ............ "PCI0" - - 9.... - 10..../* ACPI_EXTRACT_DEVICE_START ssdt_pcihp_start */ - 11.... - 12.... - 13..../* ACPI_EXTRACT_DEVICE_END ssdt_pcihp_end */ - 14.... - 15.... - 16..../* ACPI_EXTRACT_DEVICE_STRING ssdt_pcihp_name */ - 17.... - 18.... Device(SAA) { - -00000030....5B 82 26 53 41 41 5F ... "[.&SAA_" - - 19.... - 20..../* ACPI_EXTRACT_NAME_BYTE_CONST ssdt_pcihp_id */ - 21.... - 22.... Name(_SUN, 0xAA) - -00000037....08 5F 53 55 4E 0A AA ... "._SUN.." - - 23.... - 24..../* ACPI_EXTRACT_NAME_DWORD_CONST ssdt_pcihp_adr */ - 25.... - 26.... Name(_ADR, 0xAA0000) - -0000003E....08 5F 41 44 52 0C 00 00 "._ADR..." -00000046....AA 00 .................. ".." - - 27.... - 28..../* ACPI_EXTRACT_METHOD_STRING ssdt_pcihp_ej0 */ - 29.... - 30.... Method(_EJ0, 1) { - -00000048....14 0F 5F 45 4A 30 01 ... ".._EJ0." - - 31.... Return (PCEJ(_SUN)) - -0000004F....A4 ..................... "." -00000050....50 43 45 4A 5F 53 55 4E "PCEJ_SUN" - 32.... } - 33.... } - 34.... } - 35....} - 36.... +ASL Optimizing Compiler version 20130214-32 [Apr 6 2013] +Copyright (c) 2000 - 2013 Intel Corporation + +Compilation of "out/ssdt-pcihp.dsl.i" - Thu May 9 17:57:45 2013 + + 4: DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPCIHP", 0x1) + +00000000: 53 53 44 54 58 00 00 00 "SSDTX..." +00000008: 01 8B 42 58 50 43 00 00 "..BXPC.." +00000010: 42 58 53 53 44 54 50 43 "BXSSDTPC" +00000018: 01 00 00 00 49 4E 54 4C "....INTL" +00000020: 14 02 13 20 ............ "... " + + 5: { + 6: External(\_SB.PCI0, DeviceObj) + 7: External(\_SB.PCI0.PCEJ, MethodObj) + 8: Scope(\_SB.PCI0) { + +00000024: 10 33 5C 2E 5F 53 42 5F ".3\._SB_" +0000002C: 50 43 49 30 ............ "PCI0" + + 18: Device(SAA) { + +00000030: 5B 82 26 53 41 41 5F ... "[.&SAA_" + + 22: Name(_SUN, 0xAA) + +00000037: 08 5F 53 55 4E 0A AA ... "._SUN.." + + 26: Name(_ADR, 0xAA0000) + +0000003E: 08 5F 41 44 52 0C 00 00 "._ADR..." +00000046: AA 00 .................. ".." + + 30: Method(_EJ0, 1) { + +00000048: 14 0F 5F 45 4A 30 01 ... ".._EJ0." + + 31: Return (PCEJ(_SUN)) + +[****iasl****] +out/ssdt-pcihp.dsl.i 31: Return (PCEJ(_SUN)) +Warning 1104 - ^ Reserved method should not return a value (_EJ0) + + + +0000004F: A4 ..................... "." +00000050: 50 43 45 4A 5F 53 55 4E "PCEJ_SUN" + 32: } + 33: } + 34: } + 35: } + Summary of errors and warnings +out/ssdt-pcihp.dsl.i 31: Return (PCEJ(_SUN)) +Warning 1104 - ^ Reserved method should not return a value (_EJ0) -ASL Optimizing Compiler version 20100528 [Jul 2 2010] -ASL Input: out/ssdt-pcihp.dsl.i - 37 lines, 767 bytes, 6 keywords -AML Output: out/ssdt-pcihp.aml - 88 bytes, 5 named objects, 1 executable opcodes +ASL Optimizing Compiler version 20130214-32 [Apr 6 2013] -Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 0 Optimizations +ASL Input: out/ssdt-pcihp.dsl.i - 37 lines, 359 bytes, 6 keywords +AML Output: out/ssdt-pcihp.aml - 88 bytes, 5 named objects, 1 executable opcodes +Listing File: out/ssdt-pcihp.lst - 2016 bytes +Hex Dump: out/ssdt-pcihp.hex - 228 bytes +Compilation complete. 0 Errors, 1 Warnings, 0 Remarks, 0 Optimizations ---------------- As you can see, there's no code comments anymore, so nothing to output by acpi_extract.py I haven't digged further yet -- just a heads-up for now. Thanks, /mjt

2 2

another iasl update breaks seabios compilation again
by Michael Tokarev 09 May '13

09 May '13

I'm not sure what happened yet, but I noticed that current seabios does not build with 20130214-32 version of iasl. Apparently, the listing file (-l) produced now does not contain any comments from the original source, so tools/acpi_extract.py produce nothing from these files. Here's the diff between listing produced by two versions of iasl for ssdt-pcihp: ---------------- --- out/ssdt-pcihp.lst-20100528 2013-05-09 17:55:43.872160687 +0400 +++ out/ssdt-pcihp.lst-20130214-32 2013-05-09 17:57:45.222803783 +0400 @@ -1,84 +1,72 @@ Intel ACPI Component Architecture -ASL Optimizing Compiler version 20100528 [Jul 2 2010] -Copyright (c) 2000 - 2010 Intel Corporation -Supports ACPI Specification Revision 4.0a - -Compilation of "out/ssdt-pcihp.dsl.i" - Thu May 9 17:55:43 2013 - - 1.... - 2..../* ACPI_EXTRACT_ALL_CODE ssdp_pcihp_aml */ - 3.... - 4....DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPCIHP", 0x1) - -00000000....53 53 44 54 58 00 00 00 "SSDTX..." -00000008....01 77 42 58 50 43 00 00 ".wBXPC.." -00000010....42 58 53 53 44 54 50 43 "BXSSDTPC" -00000018....01 00 00 00 49 4E 54 4C "....INTL" -00000020....28 05 10 20 ............ "(.. " - - 5....{ - 6.... External(\_SB.PCI0, DeviceObj) - 7.... External(\_SB.PCI0.PCEJ, MethodObj) - 8.... Scope(\_SB.PCI0) { - -00000024....10 33 5C 2E 5F 53 42 5F ".3\._SB_" -0000002C....50 43 49 30 ............ "PCI0" - - 9.... - 10..../* ACPI_EXTRACT_DEVICE_START ssdt_pcihp_start */ - 11.... - 12.... - 13..../* ACPI_EXTRACT_DEVICE_END ssdt_pcihp_end */ - 14.... - 15.... - 16..../* ACPI_EXTRACT_DEVICE_STRING ssdt_pcihp_name */ - 17.... - 18.... Device(SAA) { - -00000030....5B 82 26 53 41 41 5F ... "[.&SAA_" - - 19.... - 20..../* ACPI_EXTRACT_NAME_BYTE_CONST ssdt_pcihp_id */ - 21.... - 22.... Name(_SUN, 0xAA) - -00000037....08 5F 53 55 4E 0A AA ... "._SUN.." - - 23.... - 24..../* ACPI_EXTRACT_NAME_DWORD_CONST ssdt_pcihp_adr */ - 25.... - 26.... Name(_ADR, 0xAA0000) - -0000003E....08 5F 41 44 52 0C 00 00 "._ADR..." -00000046....AA 00 .................. ".." - - 27.... - 28..../* ACPI_EXTRACT_METHOD_STRING ssdt_pcihp_ej0 */ - 29.... - 30.... Method(_EJ0, 1) { - -00000048....14 0F 5F 45 4A 30 01 ... ".._EJ0." - - 31.... Return (PCEJ(_SUN)) - -0000004F....A4 ..................... "." -00000050....50 43 45 4A 5F 53 55 4E "PCEJ_SUN" - 32.... } - 33.... } - 34.... } - 35....} - 36.... +ASL Optimizing Compiler version 20130214-32 [Apr 6 2013] +Copyright (c) 2000 - 2013 Intel Corporation + +Compilation of "out/ssdt-pcihp.dsl.i" - Thu May 9 17:57:45 2013 + + 4: DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPCIHP", 0x1) + +00000000: 53 53 44 54 58 00 00 00 "SSDTX..." +00000008: 01 8B 42 58 50 43 00 00 "..BXPC.." +00000010: 42 58 53 53 44 54 50 43 "BXSSDTPC" +00000018: 01 00 00 00 49 4E 54 4C "....INTL" +00000020: 14 02 13 20 ............ "... " + + 5: { + 6: External(\_SB.PCI0, DeviceObj) + 7: External(\_SB.PCI0.PCEJ, MethodObj) + 8: Scope(\_SB.PCI0) { + +00000024: 10 33 5C 2E 5F 53 42 5F ".3\._SB_" +0000002C: 50 43 49 30 ............ "PCI0" + + 18: Device(SAA) { + +00000030: 5B 82 26 53 41 41 5F ... "[.&SAA_" + + 22: Name(_SUN, 0xAA) + +00000037: 08 5F 53 55 4E 0A AA ... "._SUN.." + + 26: Name(_ADR, 0xAA0000) + +0000003E: 08 5F 41 44 52 0C 00 00 "._ADR..." +00000046: AA 00 .................. ".." + + 30: Method(_EJ0, 1) { + +00000048: 14 0F 5F 45 4A 30 01 ... ".._EJ0." + + 31: Return (PCEJ(_SUN)) + +[****iasl****] +out/ssdt-pcihp.dsl.i 31: Return (PCEJ(_SUN)) +Warning 1104 - ^ Reserved method should not return a value (_EJ0) + + + +0000004F: A4 ..................... "." +00000050: 50 43 45 4A 5F 53 55 4E "PCEJ_SUN" + 32: } + 33: } + 34: } + 35: } + Summary of errors and warnings +out/ssdt-pcihp.dsl.i 31: Return (PCEJ(_SUN)) +Warning 1104 - ^ Reserved method should not return a value (_EJ0) -ASL Optimizing Compiler version 20100528 [Jul 2 2010] -ASL Input: out/ssdt-pcihp.dsl.i - 37 lines, 767 bytes, 6 keywords -AML Output: out/ssdt-pcihp.aml - 88 bytes, 5 named objects, 1 executable opcodes +ASL Optimizing Compiler version 20130214-32 [Apr 6 2013] -Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 0 Optimizations +ASL Input: out/ssdt-pcihp.dsl.i - 37 lines, 359 bytes, 6 keywords +AML Output: out/ssdt-pcihp.aml - 88 bytes, 5 named objects, 1 executable opcodes +Listing File: out/ssdt-pcihp.lst - 2016 bytes +Hex Dump: out/ssdt-pcihp.hex - 228 bytes +Compilation complete. 0 Errors, 1 Warnings, 0 Remarks, 0 Optimizations ---------------- As you can see, there's no code comments anymore, so nothing to output by acpi_extract.py I haven't digged further yet -- just a heads-up for now. Thanks, /mjt

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS