SeaBIOS

seabios@seabios.org

5 participants
3802 discussions

[PATCH RFC 0/3] seabios: move acpi table formatting out of bios
by Michael S. Tsirkin 09 May '13

09 May '13

Untested yet, but I thought I'd share the BIOS bits so we can agree on direction. In particular check out ROM sizes: - Before patchset with DSDT enabled Total size: 127880 Fixed: 59060 Free: 3192 (used 97.6% of 128KiB rom) - Before patchset with DSDT disabled Total size: 122844 Fixed: 58884 Free: 8228 (used 93.7% of 128KiB rom) - After patchset: Total size: 128776 Fixed: 59100 Free: 2296 (used 98.2% of 128KiB rom) - Legacy disabled at build time: Total size: 119836 Fixed: 58996 Free: 11236 (used 91.4% of 128KiB rom) As can be seen from this, most size savings come from dropping DSDT, but we do save a bit by removing other tables. Of course the real reason to move tables to QEMU is so that ACPI can better match hardware. This patchset adds an option to move all code for formatting acpi tables out of BIOS. With this, QEMU has full control over the table layout. All tables are loaded from the new "/etc/acpi/" directory. Any entries in this directory cause BIOS to disable ACPI table generation completely. A generic linker script, controlled by QEMU, is loaded from "/etc/linker-script". It is used to patch in table pointers and checksums. BIOS still has limited ability to parse the tables, for the following purposes: - locate resume vector - allocate RSDP in FSEG - allocate FACS at an aligned address -- MST Michael S. Tsirkin (3): linker: utility to patch in-memory ROM files acpi: load and link tables from /etc/acpi/ acpi: add an option to disable builtin tables Makefile | 2 +- src/Kconfig | 12 +++++++- src/acpi.c | 67 +++++++++++++++++++++++++++++++++++++++++++- src/linker.c | 90 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ src/linker.h | 50 +++++++++++++++++++++++++++++++++ src/util.h | 1 + 6 files changed, 219 insertions(+), 3 deletions(-) create mode 100644 src/linker.c create mode 100644 src/linker.h -- MST

4 19

[PATCH 0/2] accept MADT over fw_cfg
by Laszlo Ersek 08 May '13

08 May '13

The first patch cleans up some field assignments in build_madt(). The second one handles the case when MADT is provided by qemu over fw_cfg. I'll soon post the qemu-side series as well. I cross-tested {patched, unpatched} qemu with {patched, unpatched} seabios. Inside a RHEL-6 guest I dumped the RSDT, DSDT, and APIC (MADT) in all four cases, and compared the results. Patched qemu with unpatched seabios don't play nicely together (two APIC (MADT) tables present). Otherwise everything seemed fine to me. The CPU topology was set with -smp 3,maxcpus=16,sockets=2,cores=4,threads=2 The table dumps / disassemblies are too big to include here, please find them at <http://people.redhat.com/~lersek/acpi_move/madt_tests.tar.gz>. Laszlo Ersek (2): build_madt(): "fix" intsrcovr->{gsi,flags} and local_nmi->flags byte order accept MADT over fw_cfg src/acpi.c | 31 +++++++++++++++++++++++-------- 1 files changed, 23 insertions(+), 8 deletions(-)

7 64

Re: [SeaBIOS] How to modify qemu-kvm bios.bin?
by Peter Stuge 07 May '13

07 May '13

li peter wrote: > maybe qemu-kvm use non-coreboot uses, Correct. qemu-kvm unfortunately uses a special-case build of SeaBIOS without coreboot. > How do I do to reach my goal？ I am not sure. If SeaBIOS also has bootsplash support then you should see options in the SeaBIOS build configuration. If there are no options to enter e.g. a splash filename then probably there is no support. SeaBIOS also runs only for a rather short time, so splash support is not very meaningful. I think it would barely be noticeable when the VM starts. //Peter

2 1

How to modify qemu-kvm bios.bin?
by li peter 06 May '13

06 May '13

I know qemu-kvm use seabios as pc bios.i just want let vm created by qemu-kvm show a custom JPEG image during bootup. How to modify the file bios.bin? I see the following command on coreboot website，but i can't find coreboot.rom file in /usr/share/qemu-kvm/ . maybe qemu-kvm use non-coreboot uses,How do I do to reach my goal？ ./build/cbfstool build/coreboot.rom add -f /path/to/image.jpg -n bootsplash.jpg -t raw

1 0

[PATCH] acpi: minor clean-up of 64 bit window logic
by Michael S. Tsirkin 30 Apr '13

30 Apr '13

Make 64 bit window detection logic a bit cleaner: don't hardcode 0 address as invalid, instead check start < end. Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> --- src/acpi.c | 2 +- src/pciinit.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/acpi.c b/src/acpi.c index b03b2ba..1037093 100644 --- a/src/acpi.c +++ b/src/acpi.c @@ -355,7 +355,7 @@ build_ssdt(void) // store pci io windows *(u32*)&ssdt_ptr[acpi_pci32_start[0]] = cpu_to_le32(pcimem_start); *(u32*)&ssdt_ptr[acpi_pci32_end[0]] = cpu_to_le32(pcimem_end - 1); - if (pcimem64_start) { + if (pcimem64_start < pcimem64_end) { ssdt_ptr[acpi_pci64_valid[0]] = 1; *(u64*)&ssdt_ptr[acpi_pci64_start[0]] = cpu_to_le64(pcimem64_start); *(u64*)&ssdt_ptr[acpi_pci64_end[0]] = cpu_to_le64(pcimem64_end - 1); diff --git a/src/pciinit.c b/src/pciinit.c index a4a5bf5..fdf1362 100644 --- a/src/pciinit.c +++ b/src/pciinit.c @@ -818,7 +818,7 @@ static void pci_bios_map_devices(struct pci_bus *busses, struct pci_mem *mem) pci_region_map_entries(busses, &r64_pref); } else if (!mem) { // no bars mapped high -> drop 64bit window (see dsdt) - pcimem64_start = 0; + pcimem64_end = pcimem64_start = 0; } // Map regions on each device. int bus; -- MST

1 1

unaligned option rom
by Michael S. Tsirkin 30 Apr '13

30 Apr '13

Each time I boot seabios built with debug enabled, I see this on serial console: Scan for VGA option rom WARNING! Found unaligned PCI rom (vd=1013:00b8) Is this a bogus warning? -- MST

2 1

Re: [SeaBIOS] [PATCH 1/2] paravirt: init qemu cfg earlier
by Kevin O'Connor 30 Apr '13

30 Apr '13

On Mon, Apr 29, 2013 at 06:21:43PM +0300, Michael S. Tsirkin wrote: > This will make it possible to use fw config > info for pci initialization. > > Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> > --- > src/paravirt.c | 2 ++ > src/post.c | 1 - > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/paravirt.c b/src/paravirt.c > index e5027d0..85aa423 100644 > --- a/src/paravirt.c > +++ b/src/paravirt.c > @@ -97,6 +97,8 @@ qemu_platform_setup(void) > if (!CONFIG_QEMU) > return; > > + qemu_cfg_init(); That wont work - the romfile stuff is needed earlier (eg, in boot_init()). -Kevin

2 1

Re: [SeaBIOS] [PATCH 2/2] pci: load memory window setup from host
by Kevin O'Connor 30 Apr '13

30 Apr '13

On Mon, Apr 29, 2013 at 06:21:40PM +0300, Michael S. Tsirkin wrote: > Load memory window setup for pci from host. > This makes it possible for host to make sure > setup matches hardware exactly: especially important > for when ACPI tables are loaded from host. > This will also make it easier to add more chipsets > down the road. > > Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> > --- > src/paravirt.c | 25 ++++++++++++++++++++++++- > src/pciinit.c | 54 ++++++++++++++++++++++++++++++++++++++++-------------- > src/util.h | 8 +++++++- > 3 files changed, 71 insertions(+), 16 deletions(-) > > diff --git a/src/paravirt.c b/src/paravirt.c > index 85aa423..067a4dc 100644 > --- a/src/paravirt.c > +++ b/src/paravirt.c > @@ -91,14 +91,35 @@ qemu_preinit(void) > dprintf(1, "Ram Size=0x%08x (0x%016llx high)\n", RamSize, RamSizeOver4G); > } > > +struct pci_mem *qemu_get_pci_mem(void) > +{ > + int psize; > + struct pci_mem *mem = romfile_loadfile("etc/pci-info", &psize); > + if (!mem) > + return NULL; > + if (psize < sizeof *mem) { Please always add parenthesis to sizeof calls. > + free(mem); > + return NULL; > + } > + mem->start32 = le64_to_cpu(mem->start32); > + mem->end32 = le64_to_cpu(mem->end32); > + mem->start64 = le64_to_cpu(mem->start64); > + mem->end64 = le64_to_cpu(mem->end64); > + return mem; > +} > + > void > qemu_platform_setup(void) > { > + struct pci_mem *mem; > + > if (!CONFIG_QEMU) > return; > > qemu_cfg_init(); > > + mem = qemu_get_pci_mem(); > + > if (runningOnXen()) { > pci_probe_devices(); > xen_hypercall_setup(); > @@ -107,7 +128,7 @@ qemu_platform_setup(void) > } > > // Initialize pci > - pci_setup(); > + pci_setup(mem); I don't understand why this code is being added to paravirt.c. Just update pciinit.c with the romfile_loadfile() calls it needs. There is no reason to change the order of initialization or to add parameters to pci_setup. Otherwise, I'm fine with having QEMU send the PCI windows explicitly to SeaBIOS. -Kevin

2 1

[PATCH 0/2] paravirt: load pci window data from host
by Michael S. Tsirkin 29 Apr '13

29 Apr '13

This makes it possible to load pci window data from host, when running on qemu. This makes it possible for host to make sure setup matches hardware exactly: especially important for when ACPI tables are loaded from host. This will also make it easier to add more chipsets down the road. Michael S. Tsirkin (2): paravirt: init qemu cfg earlier pci: load memory window setup from host src/paravirt.c | 27 ++++++++++++++++++++++++++- src/pciinit.c | 54 ++++++++++++++++++++++++++++++++++++++++-------------- src/post.c | 1 - src/util.h | 8 +++++++- 4 files changed, 73 insertions(+), 17 deletions(-) -- MST

1 2

Re: [SeaBIOS] [Qemu-devel] [PATCH RFC 2/3] acpi: load and link tables from /etc/acpi/
by Laszlo Ersek 29 Apr '13

29 Apr '13

Not sure how much it counts, but I personally can agree with you on this direction :) One note below: > @@ -603,8 +604,72 @@ acpi_setup(void) > if (! CONFIG_ACPI) > return; > > + int acpi_generate = 1; > + > dprintf(3, "init ACPI tables\n"); > > + struct romfile_s *file = NULL; > + for (;;) { > + file = romfile_findprefix("/etc/acpi/", file); > + if (!file) > + break; > + > + /* > + * Disable ACPI table generation. All ACPI tables must come from > + * etc/acpi/ romfile entries. > + */ > + acpi_generate = 0; > + [...] > + } > + > + linker_link("/etc/linker-script"); > + > + if (!acpi_generate) { > + return; > + } > + > + dprintf(3, "generate ACPI tables\n"); > + > // This code is hardcoded for PIIX4 Power Management device. > struct pci_device *pci = pci_find_init_device(acpi_find_tbl, NULL); > if (!pci) Are you deliberately calling linker_link() independently from "acpi_generate"? My hunch is that linker_link() only makes sense if acpi_generate == 0 (ie. qemu has passed down at least one table to repoint some pointer to), but I may be missing a use case. Thanks Laszlo

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS