Re: [SeaBIOS] [PATCH 1/2] paravirt: init qemu cfg earlier

On Mon, Apr 29, 2013 at 06:21:43PM +0300, Michael S. Tsirkin wrote:
This will make it possible to use fw config info for pci initialization.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- src/paravirt.c | 2 ++ src/post.c | 1 - 2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/paravirt.c b/src/paravirt.c index e5027d0..85aa423 100644 --- a/src/paravirt.c +++ b/src/paravirt.c @@ -97,6 +97,8 @@ qemu_platform_setup(void) if (!CONFIG_QEMU) return;
+ qemu_cfg_init();
That wont work - the romfile stuff is needed earlier (eg, in boot_init()). -Kevin

On Mon, Apr 29, 2013 at 07:23:37PM -0400, Kevin O'Connor wrote:
On Mon, Apr 29, 2013 at 06:21:43PM +0300, Michael S. Tsirkin wrote:
This will make it possible to use fw config info for pci initialization.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- src/paravirt.c | 2 ++ src/post.c | 1 - 2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/paravirt.c b/src/paravirt.c index e5027d0..85aa423 100644 --- a/src/paravirt.c +++ b/src/paravirt.c @@ -97,6 +97,8 @@ qemu_platform_setup(void) if (!CONFIG_QEMU) return;
+ qemu_cfg_init();
That wont work - the romfile stuff is needed earlier (eg, in boot_init()).
-Kevin
True I was confused: static void maininit(void) { // Initialize internal interfaces. interface_init(); // Setup platform devices. platform_hardware_setup(); ... } I see this interface_init -> qemu_cfg_init platform_hardware_setup -> qemu_platform_setup -> pci_setup So it's already called before pci_setup. As you said no need to change things. -- MST
participants (2)
-
Kevin O'Connor
-
Michael S. Tsirkin