SeaBIOS

seabios@seabios.org

2 participants
3713 discussions

[SeaBIOS PATCH] xen: require Xen info structure at 0x1000 to detect Xen
by David Woodhouse 16 Mar '23

16 Mar '23

From: David Woodhouse <dwmw(a)amazon.co.uk> When running under Xen, hvmloader places a table at 0x1000 with the e820 information and BIOS tables. If this isn't present, SeaBIOS will currently panic. We now have support for running Xen guests natively in QEMU/KVM, which boots SeaBIOS directly instead of via hvmloader, and does not provide the same structure. As it happens, this doesn't matter on first boot. because although we set PlatformRunningOn to PF_QEMU|PF_XEN, reading it back again still gives zero. Presumably because in true Xen, this is all already RAM. But in QEMU with a faithfully-emulated PAM config in the host bridge, it's still in ROM mode at this point so we don't see what we've just written. On reboot, however, the region *is* set to RAM mode and we do see the updated value of PlatformRunningOn, do manage to remember that we've detected Xen in CPUID, and hit the panic. It's not trivial to detect QEMU vs. real Xen at the time xen_preinit() runs, because it's so early. We can't even make a XENVER_extraversion hypercall to look for hints, because we haven't set up the hypercall page (and don't have an allocator to give us a page in which to do so). So just make Xen detection contingent on the info structure being present. If it wasn't, we were going to panic anyway. That leaves us taking the standard QEMU init path for Xen guests in native QEMU, which is just fine. Untested on actual Xen but ObviouslyCorrect™. Signed-off-by: David Woodhouse <dwmw(a)amazon.co.uk> --- src/fw/xen.c | 45 ++++++++++++++++++++++++++++++++------------- 1 file changed, 32 insertions(+), 13 deletions(-) diff --git a/src/fw/xen.c b/src/fw/xen.c index a215b9e..00e4b0c 100644 --- a/src/fw/xen.c +++ b/src/fw/xen.c @@ -40,16 +40,25 @@ struct xen_seabios_info { u32 e820_nr; } PACKED; -static void validate_info(struct xen_seabios_info *t) +static struct xen_seabios_info *validate_info(void) { - if ( memcmp(t->signature, "XenHVMSeaBIOS", 14) ) - panic("Bad Xen info signature\n"); + struct xen_seabios_info *t = (void *)INFO_PHYSICAL_ADDRESS; - if ( t->length < sizeof(struct xen_seabios_info) ) - panic("Bad Xen info length\n"); + if ( memcmp(t->signature, "XenHVMSeaBIOS", 14) ) { + dprintf(1, "Bad Xen info signature\n"); + return NULL; + } + + if ( t->length < sizeof(struct xen_seabios_info) ) { + dprintf(1, "Bad Xen info length\n"); + return NULL; + } - if (checksum(t, t->length) != 0) - panic("Bad Xen info checksum\n"); + if (checksum(t, t->length) != 0) { + dprintf(1, "Bad Xen info checksum\n"); + return NULL; + } + return t; } void xen_preinit(void) @@ -86,7 +95,10 @@ void xen_preinit(void) dprintf(1, "No Xen hypervisor found.\n"); return; } - PlatformRunningOn = PF_QEMU|PF_XEN; + if (validate_info()) + PlatformRunningOn = PF_QEMU|PF_XEN; + else + dprintf(1, "Not enabling Xen support due to lack of Xen info\n"); } static int hypercall_xen_version( int cmd, void *arg) @@ -122,10 +134,14 @@ void xen_hypercall_setup(void) void xen_biostable_setup(void) { - struct xen_seabios_info *info = (void *)INFO_PHYSICAL_ADDRESS; - void **tables = (void*)info->tables; + struct xen_seabios_info *info = validate_info(); + void **tables; int i; + if (!info) + panic("Xen info corrupted\n"); + + tables = (void*)info->tables; dprintf(1, "xen: copy BIOS tables...\n"); for (i=0; i<info->tables_nr; i++) copy_table(tables[i]); @@ -136,12 +152,15 @@ void xen_biostable_setup(void) void xen_ramsize_preinit(void) { int i; - struct xen_seabios_info *info = (void *)INFO_PHYSICAL_ADDRESS; - struct e820entry *e820 = (struct e820entry *)info->e820; - validate_info(info); + struct xen_seabios_info *info = validate_info(); + struct e820entry *e820; + + if (!info) + panic("Xen info corrupted\n"); dprintf(1, "xen: copy e820...\n"); + e820 = (struct e820entry *)info->e820; for (i = 0; i < info->e820_nr; i++) { struct e820entry *e = &e820[i]; e820_add(e->start, e->size, e->type); -- 2.34.1

4 8

[PATCH] Fix Bay Trail Chromebook Bootup
by Christopher Lentocha 15 Feb '23

15 Feb '23

on MrChromebox's Custom Firmware while using the SeaBios payload with MrChromebox's SMM variable in coreboot. This is required even if we are booting off of a USB, since it will give MMC errors in Linux and Windows 10 won't see it. See comments and code in ./src/boot.c for more information. Signed-off-by: Christopher Lentocha <christopherericlentocha(a)gmail.com> --- src/boot.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/boot.c b/src/boot.c index 1effd80..8433f51 100644 --- a/src/boot.c +++ b/src/boot.c @@ -871,6 +871,21 @@ call_boot_entry(struct segoff_s bootsegip, u8 bootdrv) // Set the magic number in ax and the boot drive in dl. br.dl = bootdrv; br.ax = 0xaa55; + // Fix Bay Trail Chromebook Bootup + // on MrChromebox's Custom Firmware + // while using the SeaBios payload + // with MrChromebox's SMM variable in coreboot. + // This is required even if we are booting off of a USB, + // since it will give MMC errors in Linux and Windows 10 + // won't see it. + outb(0xcd, 0xb2); + // Don't Add the line above this comment to CBFS booting, + // because EDK2 as 2nd payload breaks, + // since its already being applied there too, + // and we should expect all CBFS payloads in ROM to do + // what we are doing here. + // The same bug is also in EDK2, so this line would need to be + // added in a similar way for EDK2 code. farcall16(&br); } -- 2.35.1

5 4

SeaBIOS 1.16.1 release
by Marek Marczykowski-Górecki 03 Feb '23

03 Feb '23

Hello, I see rel-1.16.1 tag on https://review.coreboot.org/plugins/gitiles/seabios/, but that's about the only place where it's visible - no tarball, no info on https://www.seabios.org/Releases etc. Is 1.16.1 an actual release? -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab

2 1

[PATCH 0/4] misc tweaks for kvm and the 64bit pci window
by Gerd Hoffmann 20 Jan '23

20 Jan '23

Gerd Hoffmann (4): better kvm detection detect physical address space size move 64bit pci window to end of address space be less conservative with the 64bit pci io window src/fw/paravirt.h | 2 ++ src/fw/paravirt.c | 87 ++++++++++++++++++++++++++++++++++++++++++----- src/fw/pciinit.c | 16 ++++++++- 3 files changed, 96 insertions(+), 9 deletions(-) -- 2.38.1

5 11

"Press ESC for boot menu"
by Mahmut Olger 21 Dec '22

21 Dec '22

Hello, We are using intel atom C3558 denverton_NS platform. This platform is booting with coreboot4.16. Payload of coreboot is Seabios. Openbsd running in our board. Coreboot is booting successfully. I press ESC key when I see "Press ESC for boot menu" print but I can not select boot device. It is booting automatically. I want to select boot device. I check seabios community and disabled CONFIG_HARDWARE_IRQ but nothing changed. You can find seabios config file above. You can find coreboot config file above. How can i solve this problem. Mahmut ÖLGER Embedded Software Engineer.

2 1

[PATCH v4 0/4] Make seabios linkable with lld
by Fangrui Song 07 Dec '22

07 Dec '22

Another try after https://mail.coreboot.org/hyperkitty/list/seabios@seabios.org/thread/KBHQU4… The only change is the removal of `Makefile: Change ET_EXEC to ET_REL so that lld can link bios.bin.elf` since 699a4e5d6919cc8eae5342443025ceb6909dc276 ("ldnoexec: Add script to remove ET_EXEC flag from intermediate build objects") has done the same thing. For your convenience, the patch series is available on https://github.com/MaskRay/seabios/tree/lld Re-sending. I posted this 3 days but got bounced. I have now ensured there is my email address record on (previously not) https://mail.coreboot.org/postorius/lists/seabios.seabios.org/ as well as https://mail.coreboot.org/hyperkitty/list/seabios@seabios.org/ Fangrui Song (4): romlayout.S: Add missing SHF_ALLOC flag to .fixedaddr.\addr Make rom16.o linkable with lld romlayout32flag.lds: Use `. +=` instead of `. =` test-build.sh: Delete unneeded LD capability test scripts/layoutrom.py | 8 +++++++- scripts/test-build.sh | 42 +----------------------------------------- src/romlayout.S | 2 +- 3 files changed, 9 insertions(+), 43 deletions(-) -- 2.37.0.144.g8ac04bfd2-goog

3 7

SeaBIOS USB issues
by Sorin Pop 02 Dec '22

02 Dec '22

Hi I have tried to get SeaBIOS to enable usb and mouse support but seabios always gets stuck while I have USB enabled and the devices connected (regardless if it is just the keyboard, mouse, usb mass storage or any combination of them) Below I have attached the logs from coreboot and seabios (I have tested both 1.11 and 1.16 and none work) Does anyone have any clue on what might be the problem? Thanks

2 1

[PATCH] acpi: parse Alias object
by Igor Mammedov 24 Nov '22

24 Nov '22

Since QEMU commit dbce582a119 (acpi: pc/q35: drop ad-hoc PCI-ISA bridge AML routines and let bus ennumeration generate AML) SeaBIOS fails to parse ISA bridge AML with: parse_termlist: parse error, skip from 92/517 ... ACPI: no PS/2 keyboard present due to Alias term in DSDT which isn't handled by SeaBIOS properly. Add dumb Alias parsing which just skips over term, so the rest of AML could be parsed successfully. Signed-off-by: Igor Mammedov <imammedo(a)redhat.com> Reported-by: Volker Rümelin <vr_qemu(a)t-online.de> --- src/fw/dsdt_parser.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/fw/dsdt_parser.c b/src/fw/dsdt_parser.c index eb5496f3..2ac82821 100644 --- a/src/fw/dsdt_parser.c +++ b/src/fw/dsdt_parser.c @@ -417,6 +417,10 @@ static int parse_termobj(struct parse_state *s, break; case 0x01: /* one */ break; + case 0x06: /* AliasOp */ + offset += parse_namestring(s, ptr + offset, "SourceObject"); + offset += parse_namestring(s, ptr + offset, "AliasObject"); + break; case 0x08: /* name op */ offset += parse_namestring(s, ptr + offset, "name"); offset += parse_termobj(s, ptr + offset); -- 2.31.1

5 10

[PATCH] fix wrong init of keyboard/mouse's if first interface is not boot protocol
by qi zhou 23 Nov '22

23 Nov '22

From 987b295099267bac3012fd401dc3ea34c3e40071 Mon Sep 17 00:00:00 2001 From: Qi Zhou <atmgnd(a)outlook.com> Date: Mon, 14 Nov 2022 20:55:44 +0800 Subject: [PATCH] fix wrong init of keyboard/mouse's if first interface is not boot protocol There is always some endpoint descriptors after each interface descriptor, We should only decrement num_iface if interface type is USB_DT_INTERFACE, see https://www.beyondlogic.org/usbnutshell/usb5.shtml#ConfigurationDescriptors Signed-off-by: Qi Zhou <atmgnd(a)outlook.com> --- src/hw/usb-hid.c | 13 ++++++++----- src/hw/usb.c | 12 +++++++----- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/src/hw/usb-hid.c b/src/hw/usb-hid.c index 92c6b19..dec198a 100644 --- a/src/hw/usb-hid.c +++ b/src/hw/usb-hid.c @@ -22,13 +22,13 @@ struct usb_pipe *mouse_pipe VARFSEG; // Send USB HID protocol message. static int -set_protocol(struct usb_pipe *pipe, u16 val) +set_protocol(struct usb_pipe *pipe, u16 val, u16 inferface) { struct usb_ctrlrequest req; req.bRequestType = USB_DIR_OUT | USB_TYPE_CLASS | USB_RECIP_INTERFACE; req.bRequest = HID_REQ_SET_PROTOCOL; req.wValue = val; - req.wIndex = 0; + req.wIndex = inferface; req.wLength = 0; return usb_send_default_control(pipe, &req, NULL); } @@ -76,9 +76,12 @@ usb_kbd_setup(struct usbdevice_s *usbdev } // Enable "boot" protocol. - int ret = set_protocol(usbdev->defpipe, 0); - if (ret) + int ret = set_protocol(usbdev->defpipe, 0, usbdev->iface->bInterfaceNumber); + if (ret) { + dprintf(3, "Failed to set boot protocol\n"); return -1; + } + // Periodically send reports to enable key repeat. ret = set_idle(usbdev->defpipe, KEYREPEATMS); if (ret) @@ -118,7 +121,7 @@ usb_mouse_setup(struct usbdevice_s *usbdev } // Enable "boot" protocol. - int ret = set_protocol(usbdev->defpipe, 0); + int ret = set_protocol(usbdev->defpipe, 0, usbdev->iface->bInterfaceNumber); if (ret) return -1; diff --git a/src/hw/usb.c b/src/hw/usb.c index 38a866a..409da8c 100644 --- a/src/hw/usb.c +++ b/src/hw/usb.c @@ -372,17 +372,19 @@ configure_usb_device(struct usbdevice_s *usbdev) void *config_end = (void*)config + config->wTotalLength; struct usb_interface_descriptor *iface = (void*)(&config[1]); for (;;) { - if (!num_iface-- || (void*)iface + iface->bLength > config_end) + if (!num_iface || (void*)iface + iface->bLength > config_end) // Not a supported device. goto fail; - if (iface->bDescriptorType == USB_DT_INTERFACE - && (iface->bInterfaceClass == USB_CLASS_HUB + if (iface->bDescriptorType == USB_DT_INTERFACE) { + num_iface--; + if (iface->bInterfaceClass == USB_CLASS_HUB || (iface->bInterfaceClass == USB_CLASS_MASS_STORAGE && (iface->bInterfaceProtocol == US_PR_BULK || iface->bInterfaceProtocol == US_PR_UAS)) || (iface->bInterfaceClass == USB_CLASS_HID - && iface->bInterfaceSubClass == USB_INTERFACE_SUBCLASS_BOOT))) - break; + && iface->bInterfaceSubClass == USB_INTERFACE_SUBCLASS_BOOT)) + break; + } iface = (void*)iface + iface->bLength; } -- 2.25.1

3 5

[PATCH] virtio-blk: Fix incorrect type conversion in virtio_blk_op()
by Xiaofei 22 Nov '22

22 Nov '22

Fixes: a05af290bac5 ("virtio-blk: split large IO according to size_max") When using spdk aio bdev driver, the qemu command line like this: qemu-system-x86_64 \ -chardev socket,id=char0,path=/tmp/vhost.0 \ -device vhost-user-blk-pci,id=blk0,chardev=char0 \ ... Boot failure message as below: e820 map has 7 items: 0: 0000000000000000 - 000000000009fc00 = 1 RAM 1: 000000000009fc00 - 00000000000a0000 = 2 RESERVED 2: 00000000000f0000 - 0000000000100000 = 2 RESERVED 3: 0000000000100000 - 000000007ffdd000 = 1 RAM 4: 000000007ffdd000 - 0000000080000000 = 2 RESERVED 5: 00000000feffc000 - 00000000ff000000 = 2 RESERVED 6: 00000000fffc0000 - 0000000100000000 = 2 RESERVED enter handle_19: NULL Booting from Hard Disk... Boot failed: could not read the boot disk Signed-off-by: Xiaofei <hbuxiaofei(a)gmail.com> --- src/hw/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hw/virtio-blk.c b/src/hw/virtio-blk.c index 9b4a05a..ce3265e 100644 --- a/src/hw/virtio-blk.c +++ b/src/hw/virtio-blk.c @@ -92,7 +92,7 @@ virtio_blk_op(struct disk_op_s *op, int write) u16 blk_num_max; if (vdrive->drive.blksize != 0 && max_io_size != 0) - blk_num_max = (u16)max_io_size / vdrive->drive.blksize; + blk_num_max = (u16)(max_io_size / vdrive->drive.blksize); else /* default blk_num_max if hardware doesnot advise a proper value */ blk_num_max = 64; -- 2.27.0

7 9

Jump to page:

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS