Hi Gerd and Michael,
After a quick review it seems a few .c files in the SeaBIOS repo are
missing the typical LGPLv3 license statement.
egrep LGPLv3 -R --include='*.c' -L vgasrc/ src/
If we ignore build files and files from external projects it finds:
vgasrc/ramfb.c
vgasrc/bochsdisplay.c
src/cp437.c
src/fw/romfile_loader.c
Gerd, the first three look like yours - could you add a copyright
notice to them?
Michael, are you okay with me adding your copyright to the top of
src/fw/romfile_loader.c? Something like:
// Support for loading QEMU provided tables into memory
//
// Copyright (C) 2013 Michael S. Tsirkin <mst(a)redhat.com>
//
// This file may be distributed under the terms of the GNU LGPLv3 license.
Thanks,
-Kevin
Update the documentation to be explicit about the signed-off-by
convention.
Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net>
---
docs/Contributing.md | 5 ++++
docs/developer-certificate-of-origin | 37 ++++++++++++++++++++++++++++
2 files changed, 42 insertions(+)
create mode 100644 docs/developer-certificate-of-origin
diff --git a/docs/Contributing.md b/docs/Contributing.md
index d0f2b5b..88888d7 100644
--- a/docs/Contributing.md
+++ b/docs/Contributing.md
@@ -18,3 +18,8 @@ submit patches. The SeaBIOS C code does follow a slightly different
coding style from QEMU (eg, mixed code and C99 style variable
declarations are encouraged, braces are not required around single
statement blocks), however patches in the QEMU style are acceptable.
+
+As with QEMU, commits should contain a "Signed-off-by" line using your
+real name (sorry, no pseudonyms or anonymous contributions) and a
+current email address. It indicates agreement with the terms of the
+[developer certificate of origin](https://git.seabios.org/cgit/seabios.git/tree/docs/developer-cert....
diff --git a/docs/developer-certificate-of-origin b/docs/developer-certificate-of-origin
new file mode 100644
index 0000000..8201f99
--- /dev/null
+++ b/docs/developer-certificate-of-origin
@@ -0,0 +1,37 @@
+Developer Certificate of Origin
+Version 1.1
+
+Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
+1 Letterman Drive
+Suite D4700
+San Francisco, CA, 94129
+
+Everyone is permitted to copy and distribute verbatim copies of this
+license document, but changing it is not allowed.
+
+
+Developer's Certificate of Origin 1.1
+
+By making a contribution to this project, I certify that:
+
+(a) The contribution was created in whole or in part by me and I
+ have the right to submit it under the open source license
+ indicated in the file; or
+
+(b) The contribution is based upon previous work that, to the best
+ of my knowledge, is covered under an appropriate open source
+ license and I have the right under that license to submit that
+ work with modifications, whether created in whole or in part
+ by me, under the same open source license (unless I am
+ permitted to submit under a different license), as indicated
+ in the file; or
+
+(c) The contribution was provided directly to me by some other
+ person who certified (a), (b) or (c) and I have not modified
+ it.
+
+(d) I understand and agree that this project and the contribution
+ are public and that a record of the contribution (including all
+ personal information I submit with it, including my sign-off) is
+ maintained indefinitely and may be redistributed consistent with
+ this project or the open source license(s) involved.
--
2.21.0
v1:
Non-standard logical geometries break under QEMU.
A virtual disk which contains an operating system which depends on
logical geometries (consistent values being reported from BIOS INT13
AH=08) will most likely break under QEMU/SeaBIOS if it has non-standard
logical geometries - for example 56 SPT (sectors per track).
No matter what QEMU will guess - SeaBIOS, for large enough disks - will
use LBA translation, which will report 63 SPT instead.
In addition we can not enforce SeaBIOS to rely on phyiscal geometries at
all. A virtio-blk-pci virtual disk with 255 phyiscal heads can not
report more than 16 physical heads when moved to an IDE controller, the
ATA spec allows a maximum of 16 heads - this is an artifact of
virtualization.
By supplying the logical geometies directly we are able to support such
"exotic" disks.
We will use fw_cfg to do just that.
v2:
Fix missing parenthesis check in
"hd-geo-test: Add tests for lchs override"
v3:
* Rename fw_cfg key to "bios-geometry".
* Remove "extendible" interface.
* Add cpu_to_le32 fix as Laszlo suggested or big endian hosts
* Fix last qtest commit - automatic docker tester for some reason does not have qemu-img set
v4:
* Change fw_cfg interface from mixed textual/binary to textual only
v5:
* Fix line > 80 chars in tests/hd-geo-test.c
v6:
* Small fixes for issues pointed by Max
* (&conf->conf)->lcyls to conf->conf.lcyls and so on
* Remove scsi_unrealize from everything other than scsi-hd
* Add proper include to sysemu.h
* scsi_device_unrealize() after scsi_device_purge_requests()
v7:
* Adapted last commit (tests) to changes in qtest
v8:
* Fixed BE issue with tests by using qfw_cfg_get_file() instead of
read_fw_cfg_file(), thanks Laszlo.
* Removed incorrect comment in 7/8.
Sam Eiderman (8):
block: Refactor macros - fix tabbing
block: Support providing LCHS from user
bootdevice: Add interface to gather LCHS
scsi: Propagate unrealize() callback to scsi-hd
bootdevice: Gather LCHS from all relevant devices
bootdevice: Refactor get_boot_devices_list
bootdevice: FW_CFG interface for LCHS values
hd-geo-test: Add tests for lchs override
bootdevice.c | 147 +++++++++--
hw/block/virtio-blk.c | 6 +
hw/ide/qdev.c | 7 +-
hw/nvram/fw_cfg.c | 14 +-
hw/scsi/scsi-bus.c | 16 ++
hw/scsi/scsi-disk.c | 12 +
include/hw/block/block.h | 22 +-
include/hw/scsi/scsi.h | 1 +
include/sysemu/sysemu.h | 4 +
tests/Makefile.include | 2 +-
tests/hd-geo-test.c | 551 +++++++++++++++++++++++++++++++++++++++
11 files changed, 741 insertions(+), 41 deletions(-)
--
2.23.0.700.g56cf767bdb-goog
Hi,
I've built SeaBIOS 1.12.1 with coreboot for the Thinkpad X210 (51nb
aftermarket board).
Generally I can get into SeaBIOS itself just fine, but I haven't had
any luck loading much of anything besides Linux Live. Tianocore &
other payloads work just fine as far as I can tell.
I've prepared various Windows install USBs (using Media Creation Tool,
Rufus, Windows 7 Creator etc) making sure that they actually boot on
non-coreboot machines. I tested them with an old Core2Duo as well as
the current machine in question set to Legacy mode, and they load
fine.
I've read SeaBIOS is supposed to be fairly compatible these days, so
I'm surprised I can't load these things.
How could I debug this / is there anything I should be checking for?
SeaBIOS / coreboot is built with vgabios.bin extracted from my board,
not gfxinit. Although using gfxinit doesn't make any difference
though, it behaves the same...
Thanks,
Rafael
Hi,
Almost a year since 1.12.0 was tagged (Nov 17th to be exact),
time to plan the 1.13 release I think ...
How about freeze in a week or two, release by mid-november?
Pending stuff I'm aware of is the disk geometry patch series.
The corresponding qemu series is still waiting to be merged.
There already was a pull request for it though, it only was
dropped due to a regression showing up, so I think there is
still a chance that it'll be merged shortly given that no
objections where raised during review.
Anything else which should be considered for 1.13?
cheers,
Gerd
When coreboot calls payloads it passes a pointer to the coreboot
tables as an argument. SeaBIOS does not make use of this functionality
and instead tries to find the coreboot tables via a pointer placed in
lower memory. To improve compatibility when calling payloads from
SeaBIOS call payloads with the coreboot table as an argument.
This fixes Tianocore with UefiPayloadPkg not booting when loaded from
SeaBIOS.
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
diff --git a/src/fw/coreboot.c b/src/fw/coreboot.c
index 7c0954b..25317ca 100644
--- a/src/fw/coreboot.c
+++ b/src/fw/coreboot.c
@@ -518,9 +518,10 @@ cbfs_run_payload(struct cbfs_file *fhdr)
memset(dest, 0, dest_len);
break;
case PAYLOAD_SEGMENT_ENTRY: {
- dprintf(1, "Calling addr %p\n", dest);
- void (*func)(void) = dest;
- func();
+ void *arg = find_cb_table();
+ dprintf(1, "Calling addr %p(%p)\n", dest, arg);
+ void (*func)(void *) = dest;
+ func(arg);
return;
}
default:
--
2.23.0
Hello,
this is my attempt to address the review comments I got for v2:
- Gerd pointed out that cbvesa should only use the modes where memmodel
== MM_DIRECT.
- Kevin noted that reading global variables need the GET_GLOBAL
wrapper. (I would have expected that the compiler does the right
thing here. Probably I'm still to wet behind the ears here :-)
Note this is only compile tested.
Uwe Kleine-König (2):
cbvga: reuse svga modes definitions from svgamodes.c
Add additional resolutions for 16:9 displays: 1600x900 and 2560x1440
vgasrc/cbvga.c | 80 ++++++----------------------------------------
vgasrc/svgamodes.c | 8 +++++
2 files changed, 17 insertions(+), 71 deletions(-)
--
2.20.1
v1:
* more verbose commit message [Gerd]
---
The goal of the patch is to work around a performance bug in guest
linux kernels.
Old linux kernels has a performance flaw in virtio block device access:
on some frequent disk access patterns, e.g. 1M read, the kernel produces
more block requests than needed. This happens because of virtio seg_max
parameter set to 126 (virtqueue_size - 2) which limits the maximum block
request to 516096 (126 * 4096_PAGE_SIZE) bytes.
Setting seg_max > 126 fixes the issue, however, not all linux kernels
allow that without increasing virtio virtqueue size. The old kernels have
a restriction: virtqueue_size >= seg_max. In case of the restriction
violation the old kernels crash.
The restriction is relaxed in the recent linux kernels (ver >= 4.13) with:
commit 44ed8089e991a60d614abe0ee4b9057a28b364e4
Author: Richard W.M. Jones
Date: Thu Aug 10 17:56:51 2017 +0100
scsi: virtio: Reduce BUG if total_sg > virtqueue size to WARN.
and the recent linux kernels don't crash if total_sg > virtqueue size
allowing to set seg_max to the needed value without virtqueue size
increasing.
To fix the performance flaw in the old linux kernels, it's needed to
increse seg_max to 254, and comply the restriction by setting
virtqueue_size to 256.
This is achievable if seabios can support virtqueue size > 128
which this patch actually does.
Windows kernels don't have virtqueue_size >= seg_max restriction and
isn't affected with this kind of the performance bug.
Signed-off-by: Denis Plotnikov <dplotnikov(a)virtuozzo.com>
---
src/hw/virtio-ring.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/hw/virtio-ring.h b/src/hw/virtio-ring.h
index 8604a01..dccc50d 100644
--- a/src/hw/virtio-ring.h
+++ b/src/hw/virtio-ring.h
@@ -20,7 +20,7 @@
#define VIRTIO_F_VERSION_1 32
#define VIRTIO_F_IOMMU_PLATFORM 33
-#define MAX_QUEUE_NUM (128)
+#define MAX_QUEUE_NUM (256)
#define VRING_DESC_F_NEXT 1
#define VRING_DESC_F_WRITE 2
--
2.17.0
