SeaBIOS

seabios@seabios.org

3 participants
3808 discussions

PATCH: Fix AHCI init regression on the coreboot payload
by Leah Rowe 05 May '25

05 May '25

Hello SeaBIOS community, Please look at the patch I've attached to this email. It fixes a regression recently introduced in SeaBIOS, introduced by SeaBIOS git commit ID 8863cbbd. I request that this patch by merged, and I will now explain why. A recent SeaBIOS patch (commit 8863cbbd) adds AHCI controller reset prior to enablement, as a way to make SeaBIOS's AHCI driver work correctly on CSM-based setups. However, that commit (commit 8863cbbd) broke AHCI initialisation on the Lenovo ThinkPad T420 when testing SeaBIOS as a coreboot payload. It caused an AHCI timeout. I tried to include these logs on the mailing list but it came back telling me my message was too big. Anyways To mitigate this, I have provided for SeaBIOS a patch to this email (0004-ahci-Only-reset-controller-on-CSM.patch). My patch retains the new behaviour, resetting the AHCI controller prior to enablement, so that it will continue to function correctly on CSM, but it *only* applies that new behaviour on CSM setups. With my patch, the *old* behaviour is used (enable the controller from its current state), if a CSM is not in use. This was confirmed to work correctly, fixing the issue when re-tested on the same ThinkPad T420. I am also using this fix in Libreboot, see: https://browse.libreboot.org/lbmk.git/commit/?id=c073ee9d4fc4a631c16ff681bb… That's where the patch is from. I put it there first. SeaBIOS devs are welcome to merge this if they wish. -- Company director, Minifree Ltd Registered in England, No. 9361826 | VAT No. GB202190462 Registered Office: 19 Hilton Road, Canvey Island, Essex SS8 9QA, UK

3 3

disk not shown in boot options
by Marco Moock 08 Apr '25

08 Apr '25

Hello! I ordered a virtual machine that uses qemu and seabios. The boot menu shows the DVD drives, PXE etc, but not the HDD. The HDD is being detected in the live system (FreeBSD) and I was able to let the installer install the OS (FreeBSD 14.2) to it (GPT with bios-boot partition). Are there any checks before a device is being listed in the boot menu, e.g. if there is an MBR partition with an active flag (already experienced that on some motherboards)? I would like to exclude the OS as a source for the problem. Is there a way to list all devices? -- kind regards Marco Send unsolicited bulk mail to 1744049808muell(a)stinkedores.dorfdsl.de

2 2

[PATCH v2 0/2] add guest hint for memory layout, take three
by Gerd Hoffmann 08 Apr '25

08 Apr '25

Gerd Hoffmann (2): add romfile_loadbool() update pci_pad_mem64 handling src/romfile.h | 1 + src/fw/pciinit.c | 13 ++++++++++--- src/romfile.c | 23 +++++++++++++++++++++++ 3 files changed, 34 insertions(+), 3 deletions(-) -- 2.47.0

3 8

[PATCH] kconfig: fix the check-lxdialog.sh to work with gcc 14+
by nikolar 10 Mar '25

10 Mar '25

--- scripts/kconfig/lxdialog/check-lxdialog.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh index 9d2a4c58..66bfcb54 100644 --- a/scripts/kconfig/lxdialog/check-lxdialog.sh +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh @@ -43,7 +43,7 @@ trap "rm -f $tmp" 0 1 2 3 15 check() { $cc -x c - -o $tmp 2>/dev/null <<'EOF' #include CURSES_LOC -main() {} +int main() {} EOF if [ $? != 0 ]; then echo " *** Unable to find the ncurses libraries or the" 1>&2 -- 2.48.1

2 1

[PATCH] Fix AHCI Disk Detection when using EDK2 CSM
by Christopher Lentocha 10 Mar '25

10 Mar '25

3 9

[PATCH] NVRAM bootorder
by Timothy Kenno Handojo 14 Feb '25

14 Feb '25

Revision from a previous patch. Sorry it took so long. This change allows seabios to load bootorder not only from CBFS but also from the NVRAM as well, making use of coreboot's cmos.layout. Tested on QEMU Q35 From 3aee65ff1a9d5926ff18fa0770362e59e8b52257 Mon Sep 17 00:00:00 2001 From: Timothy Kenno Handojo <timkenhan(a)mailbox.org> Date: Wed, 22 Jan 2025 14:40:18 +0700 Subject: [PATCH] boot: Allow setting bootorder from CMOS entry The original bootorder from CBFS remains, but takes lower priority. Signed-off-by: Timothy Kenno Handojo <timkenhan(a)mailbox.org> --- Makefile | 2 +- src/boot.c | 9 +++- src/nvram.c | 144 ++++++++++++++++++++++++++++++++++++++++++++++++++++ src/nvram.h | 46 +++++++++++++++++ 4 files changed, 199 insertions(+), 2 deletions(-) create mode 100644 src/nvram.c create mode 100644 src/nvram.h diff --git a/Makefile b/Makefile index d3341870..48f0b9ac 100644 --- a/Makefile +++ b/Makefile @@ -46,7 +46,7 @@ SRC32FLAT=$(SRCBOTH) post.c e820map.c malloc.c romfile.c x86.c \ fw/mtrr.c fw/xen.c fw/acpi.c fw/mptable.c fw/pirtable.c \ fw/smbios.c fw/romfile_loader.c fw/dsdt_parser.c hw/virtio-ring.c \ hw/virtio-pci.c hw/virtio-mmio.c hw/virtio-blk.c hw/virtio-scsi.c \ - hw/tpm_drivers.c hw/nvme.c sha256.c sha512.c + hw/tpm_drivers.c hw/nvme.c sha256.c sha512.c nvram.c SRC32SEG=string.c output.c pcibios.c apm.c stacks.c hw/pci.c hw/serialio.c DIRS=src src/hw src/fw vgasrc diff --git a/src/boot.c b/src/boot.c index 5c37dafd..c5e102cf 100644 --- a/src/boot.c +++ b/src/boot.c @@ -21,6 +21,8 @@ #include "string.h" // memset #include "util.h" // irqtimer_calc #include "tcgbios.h" // tpm_* +#include "nvram.h" // get_nvram_bootorder + /**************************************************************** * Helper search functions @@ -250,8 +252,13 @@ loadBootOrder(void) { if (!CONFIG_BOOTORDER) return; + char *f = NULL; + + f = get_nvram_bootorder(); + + if (!f) + f = romfile_loadfile("bootorder", NULL); - char *f = romfile_loadfile("bootorder", NULL); if (!f) return; diff --git a/src/nvram.c b/src/nvram.c new file mode 100644 index 00000000..145a062d --- /dev/null +++ b/src/nvram.c @@ -0,0 +1,144 @@ +// Code to manipulate NVRAM configuration +// +// Copyright (C) 2024-2025 Timothy Kenno Handojo <timkenhan(a)mailbox.org> +// Taken and adapted from coreboot's libpayload +// +// This file may be distributed under the terms of the GNU LGPLv3 license. + +/* NOTE: +To avoid confusion, it is important to keep in mind that in this file, +the term CMOS does NOT refer to the RTC, but instead the NVRAM as a whole. +While this technically includes the RTC part, the main focus wouldn't be it, +and instead be the configurable parts (i.e. BIOS settings). +*/ + +#include "nvram.h" +#include "string.h" // memcmp, strlen +#include "malloc.h" // malloc_low +#include "x86.h" // inb, outb +#include "output.h" // dprintf +#include "util.h" // cb_header, find_cb_table, find_cb_subtable + +#define CB_TAG_CMOS_OPTION_TABLE 0x00c8 +#define CB_TAG_OPTION 0x00c9 +#define CB_TAG_OPTION_CHECKSUM 0x00cc + + +u8 nvram_read(u8 addr){ + u16 rtc_port = addr < 128 ? RTC_PORT_STANDARD : RTC_PORT_EXTENDED; + + outb(addr, rtc_port); + return inb(rtc_port + 1); +} + +void nvram_write(u8 val, u8 addr) +{ + u16 rtc_port = addr < 128 ? RTC_PORT_STANDARD : RTC_PORT_EXTENDED; + + outb(addr, rtc_port); + outb(val, rtc_port + 1); +} + +struct nvram_accessor { + u8 (*read)(u8 reg); + void (*write)(u8 val, u8 reg); +}; + +struct nvram_accessor *use_nvram = &(struct nvram_accessor) { + nvram_read, + nvram_write +}; + +static struct cb_cmos_entries *lookup_cmos_entry(struct cb_cmos_option_table *option_table, const char *name) +{ + struct cb_cmos_entries *cmos_entry, *next; + int len = name ? strlen(name) : 0; + + /* CMOS entries are located right after the option table */ + cmos_entry = (struct cb_cmos_entries*)((unsigned char *)option_table + option_table->header_length); + while (cmos_entry) { + if (memcmp((const char*)cmos_entry->name, name, len) == 0) + return cmos_entry; + next = (struct cb_cmos_entries*)((unsigned char *)cmos_entry + cmos_entry->size); + cmos_entry = (next->tag == CB_TAG_OPTION) ? next : NULL; + } + + dprintf(1, "ERROR: No such CMOS option (%s)\n", name); + return NULL; +} + +static int get_cmos_value(const struct nvram_accessor *nvram, u32 bitnum, u32 len, void *valptr) +{ + u8 *value = valptr; + int offs = 0; + u32 addr, bit; + u8 reg8; + + /* Convert to byte borders */ + addr=(bitnum / 8); + bit=(bitnum % 8); + + /* Handle single byte or less */ + if(len <= 8) { + reg8 = nvram->read(addr); + reg8 >>= bit; + value[0] = reg8 & ((1 << len) -1); + return 0; + } + + /* When handling more than a byte, copy whole bytes */ + while (len > 0) { + len -= 8; + value[offs++]=nvram->read(addr++); + } + + return 0; +} + +int options_checksum_valid(const struct nvram_accessor *nvram, struct cb_cmos_checksum *option_checksum) +{ + int i; + int checksum_location = option_checksum->location / 8; + u16 checksum = 0, checksum_old; + + for(i = option_checksum->range_start; i <= option_checksum->range_end; i++) { + checksum += nvram->read(i); + } + + checksum_old = ((nvram->read(checksum_location)<<8) | nvram->read(checksum_location+1)); + + return (checksum_old == checksum); +} + +void *get_nvram_bootorder() +{ + const char *name = "bootorder"; + struct cb_header *cbh = find_cb_table(); + + if (!cbh) + return NULL; + struct cb_cmos_option_table *option_table = find_cb_subtable(cbh, CB_TAG_CMOS_OPTION_TABLE); + struct cb_cmos_checksum *option_checksum = find_cb_subtable(cbh, CB_TAG_OPTION_CHECKSUM); + if (option_table == NULL) { + dprintf(1, "Could not find coreboot option table.\n"); + return NULL; + } + + struct cb_cmos_entries *cmos_entry = lookup_cmos_entry(option_table, name); + + if (!cmos_entry) + return NULL; + int cmos_length = cmos_entry->length; + + /* extra byte to ensure 0-terminated strings */ + void *buf = malloc_low(cmos_length+1); + memset(buf, 0, cmos_length+1); + + if(!options_checksum_valid(use_nvram, option_checksum)) { + dprintf(1, "Invalid option checksum.\n"); + return NULL; + } + get_cmos_value(use_nvram, cmos_entry->bit, cmos_entry->length, buf); + + return buf; +} diff --git a/src/nvram.h b/src/nvram.h new file mode 100644 index 00000000..e57b9e1c --- /dev/null +++ b/src/nvram.h @@ -0,0 +1,46 @@ +// Definitions for NVRAM configuration + +/* NOTE: +To avoid confusion, it is important to keep in mind that in this file, +the term CMOS does NOT refer to the RTC, but instead the NVRAM as a whole. +While this technically includes the RTC part, the main focus wouldn't be it, +and instead be the configurable parts (i.e. BIOS settings). +*/ + +#ifndef __NVRAM_H +#define __NVRAM_H + +#include "types.h" // u32, u8 + +#define RTC_PORT_STANDARD 0x70 +#define RTC_PORT_EXTENDED 0x72 + +struct cb_cmos_option_table { + u32 tag; + u32 size; + u32 header_length; +}; + +#define CB_CMOS_MAX_NAME_LENGTH 32 +struct cb_cmos_entries { + u32 tag; + u32 size; + u32 bit; + u32 length; + u32 config; + u32 config_id; + u8 name[CB_CMOS_MAX_NAME_LENGTH]; +}; + +struct cb_cmos_checksum { + u32 tag; + u32 size; + u32 range_start; + u32 range_end; + u32 location; + u32 type; +}; + +void *get_nvram_bootorder(); + +#endif \ No newline at end of file -- 2.39.5

2 3

Re: [PATCH] NVRAM bootorder
by Kevin O'Connor 23 Jan '25

23 Jan '25

On Wed, Jan 22, 2025 at 02:46:09PM +0700, Timothy Kenno Handojo wrote: > Revision from a previous patch. Sorry it took so long. > > This change allows seabios to load bootorder not only from CBFS but > also from the NVRAM as well, making use of coreboot's cmos.layout. Thanks. However, I don't think it's a good idea to use the "CMOS" chip (aka nvram, aka rtc) to communicate settings to SeaBIOS. There's already a well defined mechanism to pass settings via the "romfile" system (fw_cfg on qemu, cbfs on coreboot). I think we should continue to use that "romfile" system instead of adding new mechanisms. I'm also leery of using the NVRAM part of the RTC chip in general, as it has been notoriously finicky - batteries often die causing random values to be reported and many legacy applications have undocumented expectations about the layout of the NVRAM. SeaBIOS has historically not used the NVRAM settings in the RTC chip for any purpose when on coreboot (and only using it for the bare minimum when on qemu). Cheers, -Kevin > > Tested on QEMU Q35 > > From 3aee65ff1a9d5926ff18fa0770362e59e8b52257 Mon Sep 17 00:00:00 2001 > From: Timothy Kenno Handojo <timkenhan(a)mailbox.org> > Date: Wed, 22 Jan 2025 14:40:18 +0700 > Subject: [PATCH] boot: Allow setting bootorder from CMOS entry > > The original bootorder from CBFS remains, but takes lower priority. > > Signed-off-by: Timothy Kenno Handojo <timkenhan(a)mailbox.org> > --- > Makefile | 2 +- > src/boot.c | 9 +++- > src/nvram.c | 144 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > src/nvram.h | 46 +++++++++++++++++ > 4 files changed, 199 insertions(+), 2 deletions(-) > create mode 100644 src/nvram.c > create mode 100644 src/nvram.h > > diff --git a/Makefile b/Makefile > index d3341870..48f0b9ac 100644 > --- a/Makefile > +++ b/Makefile > @@ -46,7 +46,7 @@ SRC32FLAT=$(SRCBOTH) post.c e820map.c malloc.c > romfile.c x86.c \ > fw/mtrr.c fw/xen.c fw/acpi.c fw/mptable.c fw/pirtable.c \ > fw/smbios.c fw/romfile_loader.c fw/dsdt_parser.c hw/virtio-ring.c \ > hw/virtio-pci.c hw/virtio-mmio.c hw/virtio-blk.c hw/virtio-scsi.c \ > - hw/tpm_drivers.c hw/nvme.c sha256.c sha512.c > + hw/tpm_drivers.c hw/nvme.c sha256.c sha512.c nvram.c > SRC32SEG=string.c output.c pcibios.c apm.c stacks.c hw/pci.c hw/serialio.c > DIRS=src src/hw src/fw vgasrc > diff --git a/src/boot.c b/src/boot.c > index 5c37dafd..c5e102cf 100644 > --- a/src/boot.c > +++ b/src/boot.c > @@ -21,6 +21,8 @@ > #include "string.h" // memset > #include "util.h" // irqtimer_calc > #include "tcgbios.h" // tpm_* > +#include "nvram.h" // get_nvram_bootorder > + > /**************************************************************** > * Helper search functions > @@ -250,8 +252,13 @@ loadBootOrder(void) > { > if (!CONFIG_BOOTORDER) > return; > + char *f = NULL; > + > + f = get_nvram_bootorder(); > + > + if (!f) > + f = romfile_loadfile("bootorder", NULL); > - char *f = romfile_loadfile("bootorder", NULL); > if (!f) > return; > diff --git a/src/nvram.c b/src/nvram.c > new file mode 100644 > index 00000000..145a062d > --- /dev/null > +++ b/src/nvram.c > @@ -0,0 +1,144 @@ > +// Code to manipulate NVRAM configuration > +// > +// Copyright (C) 2024-2025 Timothy Kenno Handojo <timkenhan(a)mailbox.org> > +// Taken and adapted from coreboot's libpayload > +// > +// This file may be distributed under the terms of the GNU LGPLv3 license. > + > +/* NOTE: > +To avoid confusion, it is important to keep in mind that in this file, > +the term CMOS does NOT refer to the RTC, but instead the NVRAM as a whole. > +While this technically includes the RTC part, the main focus wouldn't be it, > +and instead be the configurable parts (i.e. BIOS settings). > +*/ > + > +#include "nvram.h" > +#include "string.h" // memcmp, strlen > +#include "malloc.h" // malloc_low > +#include "x86.h" // inb, outb > +#include "output.h" // dprintf > +#include "util.h" // cb_header, find_cb_table, find_cb_subtable > + > +#define CB_TAG_CMOS_OPTION_TABLE 0x00c8 > +#define CB_TAG_OPTION 0x00c9 > +#define CB_TAG_OPTION_CHECKSUM 0x00cc > + > + > +u8 nvram_read(u8 addr){ > + u16 rtc_port = addr < 128 ? RTC_PORT_STANDARD : RTC_PORT_EXTENDED; > + > + outb(addr, rtc_port); > + return inb(rtc_port + 1); > +} > + > +void nvram_write(u8 val, u8 addr) > +{ > + u16 rtc_port = addr < 128 ? RTC_PORT_STANDARD : RTC_PORT_EXTENDED; > + > + outb(addr, rtc_port); > + outb(val, rtc_port + 1); > +} > + > +struct nvram_accessor { > + u8 (*read)(u8 reg); > + void (*write)(u8 val, u8 reg); > +}; > + > +struct nvram_accessor *use_nvram = &(struct nvram_accessor) { > + nvram_read, > + nvram_write > +}; > + > +static struct cb_cmos_entries *lookup_cmos_entry(struct > cb_cmos_option_table *option_table, const char *name) > +{ > + struct cb_cmos_entries *cmos_entry, *next; > + int len = name ? strlen(name) : 0; > + > + /* CMOS entries are located right after the option table */ > + cmos_entry = (struct cb_cmos_entries*)((unsigned char *)option_table > + option_table->header_length); > + while (cmos_entry) { > + if (memcmp((const char*)cmos_entry->name, name, len) == 0) > + return cmos_entry; > + next = (struct cb_cmos_entries*)((unsigned char *)cmos_entry + > cmos_entry->size); > + cmos_entry = (next->tag == CB_TAG_OPTION) ? next : NULL; > + } > + > + dprintf(1, "ERROR: No such CMOS option (%s)\n", name); > + return NULL; > +} > + > +static int get_cmos_value(const struct nvram_accessor *nvram, u32 > bitnum, u32 len, void *valptr) > +{ > + u8 *value = valptr; > + int offs = 0; > + u32 addr, bit; > + u8 reg8; > + > + /* Convert to byte borders */ > + addr=(bitnum / 8); > + bit=(bitnum % 8); > + > + /* Handle single byte or less */ > + if(len <= 8) { > + reg8 = nvram->read(addr); > + reg8 >>= bit; > + value[0] = reg8 & ((1 << len) -1); > + return 0; > + } > + > + /* When handling more than a byte, copy whole bytes */ > + while (len > 0) { > + len -= 8; > + value[offs++]=nvram->read(addr++); > + } > + > + return 0; > +} > + > +int options_checksum_valid(const struct nvram_accessor *nvram, struct > cb_cmos_checksum *option_checksum) > +{ > + int i; > + int checksum_location = option_checksum->location / 8; > + u16 checksum = 0, checksum_old; > + > + for(i = option_checksum->range_start; i <= option_checksum->range_end; i++) { > + checksum += nvram->read(i); > + } > + > + checksum_old = ((nvram->read(checksum_location)<<8) | > nvram->read(checksum_location+1)); > + > + return (checksum_old == checksum); > +} > + > +void *get_nvram_bootorder() > +{ > + const char *name = "bootorder"; > + struct cb_header *cbh = find_cb_table(); > + > + if (!cbh) > + return NULL; > + struct cb_cmos_option_table *option_table = find_cb_subtable(cbh, > CB_TAG_CMOS_OPTION_TABLE); > + struct cb_cmos_checksum *option_checksum = find_cb_subtable(cbh, > CB_TAG_OPTION_CHECKSUM); > + if (option_table == NULL) { > + dprintf(1, "Could not find coreboot option table.\n"); > + return NULL; > + } > + > + struct cb_cmos_entries *cmos_entry = lookup_cmos_entry(option_table, name); > + > + if (!cmos_entry) > + return NULL; > + int cmos_length = cmos_entry->length; > + > + /* extra byte to ensure 0-terminated strings */ > + void *buf = malloc_low(cmos_length+1); > + memset(buf, 0, cmos_length+1); > + > + if(!options_checksum_valid(use_nvram, option_checksum)) { > + dprintf(1, "Invalid option checksum.\n"); > + return NULL; > + } > + get_cmos_value(use_nvram, cmos_entry->bit, cmos_entry->length, buf); > + > + return buf; > +} > diff --git a/src/nvram.h b/src/nvram.h > new file mode 100644 > index 00000000..e57b9e1c > --- /dev/null > +++ b/src/nvram.h > @@ -0,0 +1,46 @@ > +// Definitions for NVRAM configuration > + > +/* NOTE: > +To avoid confusion, it is important to keep in mind that in this file, > +the term CMOS does NOT refer to the RTC, but instead the NVRAM as a whole. > +While this technically includes the RTC part, the main focus wouldn't be it, > +and instead be the configurable parts (i.e. BIOS settings). > +*/ > + > +#ifndef __NVRAM_H > +#define __NVRAM_H > + > +#include "types.h" // u32, u8 > + > +#define RTC_PORT_STANDARD 0x70 > +#define RTC_PORT_EXTENDED 0x72 > + > +struct cb_cmos_option_table { > + u32 tag; > + u32 size; > + u32 header_length; > +}; > + > +#define CB_CMOS_MAX_NAME_LENGTH 32 > +struct cb_cmos_entries { > + u32 tag; > + u32 size; > + u32 bit; > + u32 length; > + u32 config; > + u32 config_id; > + u8 name[CB_CMOS_MAX_NAME_LENGTH]; > +}; > + > +struct cb_cmos_checksum { > + u32 tag; > + u32 size; > + u32 range_start; > + u32 range_end; > + u32 location; > + u32 type; > +}; > + > +void *get_nvram_bootorder(); > + > +#endif > \ No newline at end of file > -- > 2.39.5 > _______________________________________________ > SeaBIOS mailing list -- seabios(a)seabios.org > To unsubscribe send an email to seabios-leave(a)seabios.org

1 0

[PATCH] Fix AHCI Disk Detection when using EDK2 CSM
by Christopher Lentocha 21 Jan '25

21 Jan '25

For whatever reason, when you compile SeaBIOS in Csm16 mode, and use it under EDK2's OvmfPkg, the ATA_CMD_IDENTIFY_PACKET_DEVICE command doesn't work properly, therefore, SeaBIOS detects the "SATA HARDDISK" as a "SATA CDROM" device, in QEMU. Despite the Tianocore developers seem to have removed support for Csm16 some time ago, if we decide to remove Csm16 mode in SeaBIOS in favor of that, at least we have the last commit of Csm16 working properly and not half-broken. In order to fix this bug, I decided to move the "detected as a disk" function to be a goto, so code isn't sloppy, by being copied and pasted 1:1 (though this can be changed back later if needed), and in the detected as CDROM function, when it fails at its point, assume its a harddisk, make sure it is with the ATA_CMD_IDENTIFY_DEVICE (which works fine in my testing) command, and continue from there. Signed-off-by: Christopher Lentocha <christopherericlentocha(a)gmail.com> --- src/hw/ahci.c | 191 ++++++++++++++++++++++++++------------------------ 1 file changed, 101 insertions(+), 90 deletions(-) diff --git a/src/hw/ahci.c b/src/hw/ahci.c index 4f0f640a..e53c26be 100644 --- a/src/hw/ahci.c +++ b/src/hw/ahci.c @@ -501,89 +501,7 @@ static int ahci_port_setup(struct ahci_port_s *port) port->drive.removable = (buffer[0] & 0x80) ? 1 : 0; if (!port->atapi) { - // found disk (ata) - port->drive.type = DTYPE_AHCI; - port->drive.blksize = DISK_SECTOR_SIZE; - port->drive.pchs.cylinder = buffer[1]; - port->drive.pchs.head = buffer[3]; - port->drive.pchs.sector = buffer[6]; - - u64 sectors; - if (buffer[83] & (1 << 10)) // word 83 - lba48 support - sectors = *(u64*)&buffer[100]; // word 100-103 - else - sectors = *(u32*)&buffer[60]; // word 60 and word 61 - port->drive.sectors = sectors; - u64 adjsize = sectors >> 11; - char adjprefix = 'M'; - if (adjsize >= (1 << 16)) { - adjsize >>= 10; - adjprefix = 'G'; - } - port->desc = znprintf(MAXDESCSIZE - , "AHCI/%d: %s ATA-%d Hard-Disk (%u %ciBytes)" - , port->pnr - , ata_extract_model(model, MAXMODEL, buffer) - , ata_extract_version(buffer) - , (u32)adjsize, adjprefix); - port->prio = bootprio_find_ata_device(ctrl->pci_tmp, pnr, 0); - - s8 multi_dma = -1; - s8 pio_mode = -1; - s8 udma_mode = -1; - // If bit 2 in word 53 is set, udma information is valid in word 88. - if (buffer[53] & 0x04) { - udma_mode = 6; - while ((udma_mode >= 0) && - !((buffer[88] & 0x7f) & ( 1 << udma_mode ))) { - udma_mode--; - } - } - // If bit 1 in word 53 is set, multiword-dma and advanced pio modes - // are available in words 63 and 64. - if (buffer[53] & 0x02) { - pio_mode = 4; - multi_dma = 3; - while ((multi_dma >= 0) && - !((buffer[63] & 0x7) & ( 1 << multi_dma ))) { - multi_dma--; - } - while ((pio_mode >= 3) && - !((buffer[64] & 0x3) & ( 1 << ( pio_mode - 3 ) ))) { - pio_mode--; - } - } - dprintf(2, "AHCI/%d: supported modes: udma %d, multi-dma %d, pio %d\n", - port->pnr, udma_mode, multi_dma, pio_mode); - - sata_prep_simple(&port->cmd->fis, ATA_CMD_SET_FEATURES); - port->cmd->fis.feature = ATA_SET_FEATRUE_TRANSFER_MODE; - // Select used mode. UDMA first, then Multi-DMA followed by - // advanced PIO modes 3 or 4. If non, set default PIO. - if (udma_mode >= 0) { - dprintf(1, "AHCI/%d: Set transfer mode to UDMA-%d\n", - port->pnr, udma_mode); - port->cmd->fis.sector_count = ATA_TRANSFER_MODE_ULTRA_DMA - | udma_mode; - } else if (multi_dma >= 0) { - dprintf(1, "AHCI/%d: Set transfer mode to Multi-DMA-%d\n", - port->pnr, multi_dma); - port->cmd->fis.sector_count = ATA_TRANSFER_MODE_MULTIWORD_DMA - | multi_dma; - } else if (pio_mode >= 3) { - dprintf(1, "AHCI/%d: Set transfer mode to PIO-%d\n", - port->pnr, pio_mode); - port->cmd->fis.sector_count = ATA_TRANSFER_MODE_PIO_FLOW_CTRL - | pio_mode; - } else { - dprintf(1, "AHCI/%d: Set transfer mode to default PIO\n", - port->pnr); - port->cmd->fis.sector_count = ATA_TRANSFER_MODE_DEFAULT_PIO; - } - rc = ahci_command(port, 1, 0, 0, 0); - if (rc < 0) { - dprintf(1, "AHCI/%d: Set transfer mode failed.\n", port->pnr); - } + goto is_ata_disk; } else { // found cdrom (atapi) port->drive.type = DTYPE_AHCI_ATAPI; @@ -592,14 +510,107 @@ static int ahci_port_setup(struct ahci_port_s *port) u8 iscd = ((buffer[0] >> 8) & 0x1f) == 0x05; if (!iscd) { dprintf(1, "AHCI/%d: atapi device isn't a cdrom\n", port->pnr); - return -1; + port->atapi = 0; + sata_prep_simple(&port->cmd->fis, ATA_CMD_IDENTIFY_DEVICE); + rc = ahci_command(port, 0, 0, buffer, sizeof(buffer)); + if (rc < 0) + return -1; + goto is_ata_disk; + } else { + port->desc = znprintf(MAXDESCSIZE + , "DVD/CD [AHCI/%d: %s ATAPI-%d DVD/CD]" + , port->pnr + , ata_extract_model(model, MAXMODEL, buffer) + , ata_extract_version(buffer)); + port->prio = bootprio_find_ata_device(ctrl->pci_tmp, pnr, 0); + boot_lchs_find_ata_device(ctrl->pci_tmp, pnr, 0, &(port->drive.lchs)); } - port->desc = znprintf(MAXDESCSIZE - , "DVD/CD [AHCI/%d: %s ATAPI-%d DVD/CD]" - , port->pnr - , ata_extract_model(model, MAXMODEL, buffer) - , ata_extract_version(buffer)); - port->prio = bootprio_find_ata_device(ctrl->pci_tmp, pnr, 0); + } + return 0; + +is_ata_disk: + // found disk (ata) + port->drive.type = DTYPE_AHCI; + port->drive.blksize = DISK_SECTOR_SIZE; + port->drive.pchs.cylinder = buffer[1]; + port->drive.pchs.head = buffer[3]; + port->drive.pchs.sector = buffer[6]; + + u64 sectors; + if (buffer[83] & (1 << 10)) // word 83 - lba48 support + sectors = *(u64*)&buffer[100]; // word 100-103 + else + sectors = *(u32*)&buffer[60]; // word 60 and word 61 + port->drive.sectors = sectors; + u64 adjsize = sectors >> 11; + char adjprefix = 'M'; + if (adjsize >= (1 << 16)) { + adjsize >>= 10; + adjprefix = 'G'; + } + port->desc = znprintf(MAXDESCSIZE + , "AHCI/%d: %s ATA-%d Hard-Disk (%u %ciBytes)" + , port->pnr + , ata_extract_model(model, MAXMODEL, buffer) + , ata_extract_version(buffer) + , (u32)adjsize, adjprefix); + port->prio = bootprio_find_ata_device(ctrl->pci_tmp, pnr, 0); + + s8 multi_dma = -1; + s8 pio_mode = -1; + s8 udma_mode = -1; + // If bit 2 in word 53 is set, udma information is valid in word 88. + if (buffer[53] & 0x04) { + udma_mode = 6; + while ((udma_mode >= 0) && + !((buffer[88] & 0x7f) & ( 1 << udma_mode ))) { + udma_mode--; + } + } + // If bit 1 in word 53 is set, multiword-dma and advanced pio modes + // are available in words 63 and 64. + if (buffer[53] & 0x02) { + pio_mode = 4; + multi_dma = 3; + while ((multi_dma >= 0) && + !((buffer[63] & 0x7) & ( 1 << multi_dma ))) { + multi_dma--; + } + while ((pio_mode >= 3) && + !((buffer[64] & 0x3) & ( 1 << ( pio_mode - 3 ) ))) { + pio_mode--; + } + } + dprintf(2, "AHCI/%d: supported modes: udma %d, multi-dma %d, pio %d\n", + port->pnr, udma_mode, multi_dma, pio_mode); + + sata_prep_simple(&port->cmd->fis, ATA_CMD_SET_FEATURES); + port->cmd->fis.feature = ATA_SET_FEATRUE_TRANSFER_MODE; + // Select used mode. UDMA first, then Multi-DMA followed by + // advanced PIO modes 3 or 4. If non, set default PIO. + if (udma_mode >= 0) { + dprintf(1, "AHCI/%d: Set transfer mode to UDMA-%d\n", + port->pnr, udma_mode); + port->cmd->fis.sector_count = ATA_TRANSFER_MODE_ULTRA_DMA + | udma_mode; + } else if (multi_dma >= 0) { + dprintf(1, "AHCI/%d: Set transfer mode to Multi-DMA-%d\n", + port->pnr, multi_dma); + port->cmd->fis.sector_count = ATA_TRANSFER_MODE_MULTIWORD_DMA + | multi_dma; + } else if (pio_mode >= 3) { + dprintf(1, "AHCI/%d: Set transfer mode to PIO-%d\n", + port->pnr, pio_mode); + port->cmd->fis.sector_count = ATA_TRANSFER_MODE_PIO_FLOW_CTRL + | pio_mode; + } else { + dprintf(1, "AHCI/%d: Set transfer mode to default PIO\n", + port->pnr); + port->cmd->fis.sector_count = ATA_TRANSFER_MODE_DEFAULT_PIO; + } + rc = ahci_command(port, 1, 0, 0, 0); + if (rc < 0) { + dprintf(1, "AHCI/%d: Set transfer mode failed.\n", port->pnr); } boot_lchs_find_ata_device(ctrl->pci_tmp, pnr, 0, &(port->drive.lchs)); return 0; -- 2.38.1

2 2

[PATCH 0/2] drop acpi support for qemu 1.6 and older.
by Gerd Hoffmann 16 Jan '25

16 Jan '25

Gerd Hoffmann (2): drop obsolete acpi table code drop acpi tables and hex includes Makefile | 15 - src/fw/acpi.c | 668 +------------------------------ src/Kconfig | 10 - src/fw/acpi-dsdt-cpu-hotplug.dsl | 78 ---- src/fw/acpi-dsdt-dbug.dsl | 26 -- src/fw/acpi-dsdt-hpet.dsl | 36 -- src/fw/acpi-dsdt-isa.dsl | 102 ----- src/fw/acpi-dsdt-pci-crs.dsl | 90 ----- src/fw/acpi-dsdt.dsl | 342 ---------------- src/fw/acpi-dsdt.hex | 554 ------------------------- src/fw/q35-acpi-dsdt.dsl | 450 --------------------- src/fw/ssdt-misc.dsl | 104 ----- src/fw/ssdt-misc.hex | 88 ---- src/fw/ssdt-pcihp.dsl | 36 -- src/fw/ssdt-pcihp.hex | 38 -- src/fw/ssdt-proc.dsl | 48 --- src/fw/ssdt-proc.hex | 35 -- 17 files changed, 1 insertion(+), 2719 deletions(-) delete mode 100644 src/fw/acpi-dsdt-cpu-hotplug.dsl delete mode 100644 src/fw/acpi-dsdt-dbug.dsl delete mode 100644 src/fw/acpi-dsdt-hpet.dsl delete mode 100644 src/fw/acpi-dsdt-isa.dsl delete mode 100644 src/fw/acpi-dsdt-pci-crs.dsl delete mode 100644 src/fw/acpi-dsdt.dsl delete mode 100644 src/fw/acpi-dsdt.hex delete mode 100644 src/fw/q35-acpi-dsdt.dsl delete mode 100644 src/fw/ssdt-misc.dsl delete mode 100644 src/fw/ssdt-misc.hex delete mode 100644 src/fw/ssdt-pcihp.dsl delete mode 100644 src/fw/ssdt-pcihp.hex delete mode 100644 src/fw/ssdt-proc.dsl delete mode 100644 src/fw/ssdt-proc.hex -- 2.47.0

3 7

[PATCH] Support multiple USB HID keyboards/mice
by Daniel Khodabakhsh 07 Jan '25

07 Jan '25

This change allows the use of multiple USB HID keyboards and mice. It's similar to the change by Stef van Os from this thread: https://mail.coreboot.org/hyperkitty/list/seabios@seabios.org/thread/O6Y4LU… however this new change uses the linked list approach instead of a fixed array. Tested on QEMU and an Asus KGPE-D16 with 2 keyboards and one mice

3 13

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS