Re: [SeaBIOS] [Qemu-devel] [PATCH RFC 10/13] i386: generate pc guest info

[Michael S. Tsirkin]

On Mon, May 13, 2013 at 09:23:54PM +0100, Peter Maydell wrote:
> On 13 May 2013 21:01, Michael S. Tsirkin  wrote:
> > This fills in guest info table with misc
> > information of interest to the guest.
> > Will be used by ACPI table generation code.
>
> Bunch of coding style violations in this patch which will
> need fixing at some point in the RFC->patch process.
>
> thanks
> -- PMM

I went over it again and found one:
+    if (ram_size <= 0x80000000)
+        guest_info->pci_info.w32.begin = 0x80000000;
+    else if (ram_size <= 0xc0000000)
+        guest_info->pci_info.w32.begin = 0xc0000000;
+    else
+        guest_info->pci_info.w32.begin = 0xe0000000;

should use {}.

One is not a bunch so I obviously missed some - it might be helpful if
you pointed them out.

Thanks,

[Qemu-devel] [PATCH RFC 10/13] i386: generate pc guest info

[Peter Maydell]

On 14 May 2013 09:06, Michael S. Tsirkin  wrote:
> On Mon, May 13, 2013 at 09:23:54PM +0100, Peter Maydell wrote:
> > Bunch of coding style violations in this patch which will
> > need fixing at some point in the RFC->patch process.
> I went over it again and found one:
> One is not a bunch so I obviously missed some - it might be
> helpful if you pointed them out.

Mmm, I only see one so I think that was just late night
sloppy wording on my part; apologies. If checkpatch is
happy then that's cool.

thanks
-- PMM