SeaBIOS July 2012

seabios@seabios.org

37 participants
119 discussions

Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with its ACPI code
by Kevin O'Connor 25 Jul '12

25 Jul '12

On Wed, Jul 25, 2012 at 01:44:20PM +0200, Idwer Vollering wrote: > Unmodified tree, at 9d6bac1d32b72cdf7c0ad009c1371a2e69084de3 At a guess, the iasl warnings are confusing the acpi_extract_preprocess.py script. What version of iasl do you have? -Kevin

2 1

Compiling SeaBIOS for coreboot has problems with its ACPI code
by Idwer Vollering 25 Jul '12

25 Jul '12

Unmodified tree, at 9d6bac1d32b72cdf7c0ad009c1371a2e69084de3 $ make clean ; make V=1 Working around non-functional -combine Working around non-functional -combine mkdir -p out//tools/kconfig/lxdialog mkdir -p out//include/config make -C out/ -f /home/idwer/coreboot/git/seabios/tools/kconfig/Makefile srctree=/home/idwer/coreboot/git/seabios src=tools/kconfig obj=tools/kconfig Q= Kconfig=/home/idwer/coreboot/git/seabios/src/Kconfig silentoldconfig make[1]: Entering directory `/home/idwer/coreboot/git/seabios/out' cc -Itools/kconfig -I/home/idwer/coreboot/git/seabios/tools/kconfig -DCURSES_LOC="<ncurses.h>" -DLOCALE -c -o tools/kconfig/conf.o /home/idwer/coreboot/git/seabios/tools/kconfig/conf.c cc -Itools/kconfig -I/home/idwer/coreboot/git/seabios/tools/kconfig -DCURSES_LOC="<ncurses.h>" -DLOCALE -c -o tools/kconfig/kxgettext.o /home/idwer/coreboot/git/seabios/tools/kconfig/kxgettext.c cat /home/idwer/coreboot/git/seabios/tools/kconfig/zconf.tab.c_shipped > tools/kconfig/zconf.tab.c cat /home/idwer/coreboot/git/seabios/tools/kconfig/lex.zconf.c_shipped > tools/kconfig/lex.zconf.c cat /home/idwer/coreboot/git/seabios/tools/kconfig/zconf.hash.c_shipped > tools/kconfig/zconf.hash.c cc -Itools/kconfig -I/home/idwer/coreboot/git/seabios/tools/kconfig -Itools/kconfig -DCURSES_LOC="<ncurses.h>" -DLOCALE -c -o tools/kconfig/zconf.tab.o tools/kconfig/zconf.tab.c cc -o tools/kconfig/conf tools/kconfig/conf.o tools/kconfig/zconf.tab.o Build Kconfig config file mkdir -p include/generated tools/kconfig/conf --silentoldconfig /home/idwer/coreboot/git/seabios/src/Kconfig make[1]: Leaving directory `/home/idwer/coreboot/git/seabios/out' Compiling IASL out/acpi-dsdt.hex cpp -P src/acpi-dsdt.dsl > out/acpi-dsdt.dsl.i.orig python ./tools/acpi_extract_preprocess.py out/acpi-dsdt.dsl.i.orig > out/acpi-dsdt.dsl.i iasl -vs -l -tc -p out/acpi-dsdt out/acpi-dsdt.dsl.i out/acpi-dsdt.dsl.i 579: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L00) out/acpi-dsdt.dsl.i 582: Return(\_SB.PCI0.PCNF()) Warning 1104 - Reserved method should not return a value ^ (_E01) out/acpi-dsdt.dsl.i 585: Return(\_SB.PRSC()) Warning 1104 - ^ Reserved method should not return a value (_E02) out/acpi-dsdt.dsl.i 588: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L03) out/acpi-dsdt.dsl.i 591: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L04) out/acpi-dsdt.dsl.i 594: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L05) out/acpi-dsdt.dsl.i 597: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L06) out/acpi-dsdt.dsl.i 600: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L07) out/acpi-dsdt.dsl.i 603: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L08) out/acpi-dsdt.dsl.i 606: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L09) out/acpi-dsdt.dsl.i 609: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L0A) out/acpi-dsdt.dsl.i 612: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L0B) out/acpi-dsdt.dsl.i 615: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L0C) out/acpi-dsdt.dsl.i 618: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L0D) out/acpi-dsdt.dsl.i 621: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L0E) out/acpi-dsdt.dsl.i 624: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L0F) ASL Input: out/acpi-dsdt.dsl.i - 629 lines, 22922 bytes, 344 keywords AML Output: out/acpi-dsdt.aml - 4682 bytes, 163 named objects, 181 executable opcodes Listing File: out/acpi-dsdt.lst - 152056 bytes Hex Dump: out/acpi-dsdt.hex - 44279 bytes Compilation complete. 0 Errors, 16 Warnings, 0 Remarks, 257 Optimizations python ./tools/acpi_extract.py out/acpi-dsdt.lst > out/acpi-dsdt.off cat out/acpi-dsdt.off > out/acpi-dsdt.hex Compiling IASL out/ssdt-proc.hex cpp -P src/ssdt-proc.dsl > out/ssdt-proc.dsl.i.orig python ./tools/acpi_extract_preprocess.py out/ssdt-proc.dsl.i.orig > out/ssdt-proc.dsl.i iasl -vs -l -tc -p out/ssdt-proc out/ssdt-proc.dsl.i ASL Input: out/ssdt-proc.dsl.i - 36 lines, 496 bytes, 8 keywords AML Output: out/ssdt-proc.aml - 120 bytes, 6 named objects, 2 executable opcodes Listing File: out/ssdt-proc.lst - 2502 bytes Hex Dump: out/ssdt-proc.hex - 1452 bytes Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 0 Optimizations python ./tools/acpi_extract.py out/ssdt-proc.lst > out/ssdt-proc.off cat out/ssdt-proc.off > out/ssdt-proc.hex Compiling IASL out/ssdt-pcihp.hex cpp -P src/ssdt-pcihp.dsl > out/ssdt-pcihp.dsl.i.orig python ./tools/acpi_extract_preprocess.py out/ssdt-pcihp.dsl.i.orig > out/ssdt-pcihp.dsl.i iasl -vs -l -tc -p out/ssdt-pcihp out/ssdt-pcihp.dsl.i out/ssdt-pcihp.dsl.i 13: Method (_EJ0, 1) { Return(PCEJ(0x01)) } Name (_SUN, 0x01) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 18: Method (_EJ0, 1) { Return(PCEJ(0x02)) } Name (_SUN, 0x02) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 23: Method (_EJ0, 1) { Return(PCEJ(0x03)) } Name (_SUN, 0x03) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 28: Method (_EJ0, 1) { Return(PCEJ(0x04)) } Name (_SUN, 0x04) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 33: Method (_EJ0, 1) { Return(PCEJ(0x05)) } Name (_SUN, 0x05) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 38: Method (_EJ0, 1) { Return(PCEJ(0x06)) } Name (_SUN, 0x06) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 43: Method (_EJ0, 1) { Return(PCEJ(0x07)) } Name (_SUN, 0x07) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 48: Method (_EJ0, 1) { Return(PCEJ(0x08)) } Name (_SUN, 0x08) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 53: Method (_EJ0, 1) { Return(PCEJ(0x09)) } Name (_SUN, 0x09) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 58: Method (_EJ0, 1) { Return(PCEJ(0x0a)) } Name (_SUN, 0x0a) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 63: Method (_EJ0, 1) { Return(PCEJ(0x0b)) } Name (_SUN, 0x0b) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 68: Method (_EJ0, 1) { Return(PCEJ(0x0c)) } Name (_SUN, 0x0c) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 73: Method (_EJ0, 1) { Return(PCEJ(0x0d)) } Name (_SUN, 0x0d) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 78: Method (_EJ0, 1) { Return(PCEJ(0x0e)) } Name (_SUN, 0x0e) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 83: Method (_EJ0, 1) { Return(PCEJ(0x0f)) } Name (_SUN, 0x0f) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 88: Method (_EJ0, 1) { Return(PCEJ(0x10)) } Name (_SUN, 0x10) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 93: Method (_EJ0, 1) { Return(PCEJ(0x11)) } Name (_SUN, 0x11) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 98: Method (_EJ0, 1) { Return(PCEJ(0x12)) } Name (_SUN, 0x12) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 103: Method (_EJ0, 1) { Return(PCEJ(0x13)) } Name (_SUN, 0x13) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 108: Method (_EJ0, 1) { Return(PCEJ(0x14)) } Name (_SUN, 0x14) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 113: Method (_EJ0, 1) { Return(PCEJ(0x15)) } Name (_SUN, 0x15) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 118: Method (_EJ0, 1) { Return(PCEJ(0x16)) } Name (_SUN, 0x16) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 123: Method (_EJ0, 1) { Return(PCEJ(0x17)) } Name (_SUN, 0x17) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 128: Method (_EJ0, 1) { Return(PCEJ(0x18)) } Name (_SUN, 0x18) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 133: Method (_EJ0, 1) { Return(PCEJ(0x19)) } Name (_SUN, 0x19) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 138: Method (_EJ0, 1) { Return(PCEJ(0x1a)) } Name (_SUN, 0x1a) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 143: Method (_EJ0, 1) { Return(PCEJ(0x1b)) } Name (_SUN, 0x1b) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 148: Method (_EJ0, 1) { Return(PCEJ(0x1c)) } Name (_SUN, 0x1c) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 153: Method (_EJ0, 1) { Return(PCEJ(0x1d)) } Name (_SUN, 0x1d) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 158: Method (_EJ0, 1) { Return(PCEJ(0x1e)) } Name (_SUN, 0x1e) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 163: Method (_EJ0, 1) { Return(PCEJ(0x1f)) } Name (_SUN, 0x1f) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) ASL Input: out/ssdt-pcihp.dsl.i - 232 lines, 5795 bytes, 254 keywords AML Output: out/ssdt-pcihp.aml - 1646 bytes, 130 named objects, 124 executable opcodes Listing File: out/ssdt-pcihp.lst - 36135 bytes Hex Dump: out/ssdt-pcihp.hex - 15779 bytes Compilation complete. 0 Errors, 31 Warnings, 0 Remarks, 3 Optimizations python ./tools/acpi_extract.py out/ssdt-pcihp.lst > out/ssdt-pcihp.off cat out/ssdt-pcihp.off > out/ssdt-pcihp.hex Compiling whole program out/ccode32flat.o printf '#include "../src/misc.c"\n #include "../src/stacks.c"\n #include "../src/pmm.c"\n #include "../src/output.c"\n #include "../src/util.c"\n #include "../src/block.c"\n #include "../src/floppy.c"\n #include "../src/ata.c"\n #include "../src/mouse.c"\n #include "../src/kbd.c"\n #include "../src/pci.c"\n #include "../src/serial.c"\n #include "../src/clock.c"\n #include "../src/pic.c"\n #include "../src/cdrom.c"\n #include "../src/ps2port.c"\n #include "../src/smp.c"\n #include "../src/resume.c"\n #include "../src/pnpbios.c"\n #include "../src/pirtable.c"\n #include "../src/vgahooks.c"\n #include "../src/ramdisk.c"\n #include "../src/pcibios.c"\n #include "../src/blockcmd.c"\n #include "../src/usb.c"\n #include "../src/usb-uhci.c"\n #include "../src/usb-ohci.c"\n #include "../src/usb-ehci.c"\n #include "../src/usb-hid.c"\n #include "../src/usb-msc.c"\n #include "../src/virtio-ring.c"\n #include "../src/virtio-pci.c"\n #include "../src/virtio-blk.c"\n #include "../src/virtio-scsi.c"\n #include "../src/apm.c"\n #include "../src/ahci.c"\n #include "../src/usb-uas.c"\n #include "../src/lsi-scsi.c"\n #include "../src/post.c"\n #include "../src/shadow.c"\n #include "../src/memmap.c"\n #include "../src/coreboot.c"\n #include "../src/boot.c"\n #include "../src/acpi.c"\n #include "../src/smm.c"\n #include "../src/mptable.c"\n #include "../src/smbios.c"\n #include "../src/pciinit.c"\n #include "../src/optionroms.c"\n #include "../src/mtrr.c"\n #include "../src/lzmadecode.c"\n #include "../src/bootsplash.c"\n #include "../src/jpeg.c"\n #include "../src/usb-hub.c"\n #include "../src/paravirt.c"\n #include "../src/biostables.c"\n #include "../src/xen.c"\n #include "../src/bmp.c"\n #include "../src/romfile.c"\n' > out/ccode32flat.o.tmp.c cc -Iout/ -Os -MD -g -Wall -Wno-strict-aliasing -Wold-style-definition -Wtype-limits -m32 -march=i386 -mregparm=3 -mpreferred-stack-boundary=2 -minline-all-stringops -freg-struct-return -ffreestanding -fno-delete-null-pointer-checks -ffunction-sections -fdata-sections -fno-common -fno-stack-protector -DMODE16=0 -DMODESEGMENT=0 -fomit-frame-pointer -fwhole-program -DWHOLE_PROGRAM -c out/ccode32flat.o.tmp.c -o out/ccode32flat.o In file included from out/ccode32flat.o.tmp.c:44:0: out/../src/acpi.c: In function 'build_ssdt': out/../src/acpi.c:417:34: error: 'ssdt_proc_end' undeclared (first use in this function) out/../src/acpi.c:417:34: note: each undeclared identifier is reported only once for each function it appears in out/../src/acpi.c:417:34: error: 'ssdt_proc_start' undeclared (first use in this function) out/../src/acpi.c:439:26: error: 'ssdp_proc_aml' undeclared (first use in this function) out/../src/acpi.c:440:18: error: 'ssdt_proc_name' undeclared (first use in this function) out/../src/acpi.c:443:18: error: 'ssdt_proc_id' undeclared (first use in this function) In file included from out/ccode32flat.o.tmp.c:44:0: out/../src/acpi.c: In function 'build_pcihp': out/../src/acpi.c:527:35: error: 'ssdp_pcihp_aml' undeclared (first use in this function) out/../src/acpi.c:536:9: error: 'aml_ej0_name' undeclared (first use in this function) out/../src/acpi.c:536:37: error: 'aml_adr_dword' undeclared (first use in this function) out/../src/acpi.c:560:14: error: 'acpi_s3_name' undeclared (first use in this function) out/../src/acpi.c:562:14: error: 'acpi_s4_name' undeclared (first use in this function) out/../src/acpi.c:564:14: error: 'acpi_s4_pkg' undeclared (first use in this function) out/../src/acpi.c: In function 'acpi_bios_init': out/../src/acpi.c:779:41: error: 'AmlCode' undeclared (first use in this function) make: *** [out/ccode32flat.o] Error 1 Non-fix #1: $ git diff Makefile ; cat make2 diff --git a/Makefile b/Makefile index dfdec5c..b1c256c 100644 --- a/Makefile +++ b/Makefile @@ -97,7 +97,7 @@ ifeq "$(COMPSTRAT)" "1" # First method - use -fwhole-program without -combine. define whole-compile @echo " Compiling whole program $3" -$(Q)printf '$(foreach i,$2,#include "../$i"\n)' > $3.tmp.c +$(Q)echo -e '$(foreach i,$2,#include "../$i")\n' > $3.tmp.c $(Q)$(CC) $1 -fwhole-program -DWHOLE_PROGRAM -c $3.tmp.c -o $3 endef else @@ -105,7 +105,7 @@ ifeq "$(COMPSTRAT)" "2" # Second menthod - don't use -fwhole-program at all. define whole-compile @echo " Compiling whole program $3" -$(Q)printf '$(foreach i,$2,#include "../$i"\n)' > $3.tmp.c +$(Q)echo -e '$(foreach i,$2,#include "../$i")\n' > $3.tmp.c $(Q)$(CC) $1 -c $3.tmp.c -o $3 endef else $ make clean ; make V=1 Working around non-functional -combine mkdir -p out//tools/kconfig/lxdialog mkdir -p out//include/config make -C out/ -f /home/idwer/coreboot/git/seabios/tools/kconfig/Makefile srctree=/home/idwer/coreboot/git/seabios src=tools/kconfig obj=tools/kconfig Q= Kconfig=/home/idwer/coreboot/git/seabios/src/Kconfig silentoldconfig make[1]: Entering directory `/home/idwer/coreboot/git/seabios/out' cc -Itools/kconfig -I/home/idwer/coreboot/git/seabios/tools/kconfig -DCURSES_LOC="<ncurses.h>" -DLOCALE -c -o tools/kconfig/conf.o /home/idwer/coreboot/git/seabios/tools/kconfig/conf.c cc -Itools/kconfig -I/home/idwer/coreboot/git/seabios/tools/kconfig -DCURSES_LOC="<ncurses.h>" -DLOCALE -c -o tools/kconfig/kxgettext.o /home/idwer/coreboot/git/seabios/tools/kconfig/kxgettext.c cat /home/idwer/coreboot/git/seabios/tools/kconfig/zconf.tab.c_shipped > tools/kconfig/zconf.tab.c cat /home/idwer/coreboot/git/seabios/tools/kconfig/lex.zconf.c_shipped > tools/kconfig/lex.zconf.c cat /home/idwer/coreboot/git/seabios/tools/kconfig/zconf.hash.c_shipped > tools/kconfig/zconf.hash.c cc -Itools/kconfig -I/home/idwer/coreboot/git/seabios/tools/kconfig -Itools/kconfig -DCURSES_LOC="<ncurses.h>" -DLOCALE -c -o tools/kconfig/zconf.tab.o tools/kconfig/zconf.tab.c cc -o tools/kconfig/conf tools/kconfig/conf.o tools/kconfig/zconf.tab.o Build Kconfig config file mkdir -p include/generated tools/kconfig/conf --silentoldconfig /home/idwer/coreboot/git/seabios/src/Kconfig make[1]: Leaving directory `/home/idwer/coreboot/git/seabios/out' Compiling IASL out/acpi-dsdt.hex cpp -P src/acpi-dsdt.dsl > out/acpi-dsdt.dsl.i.orig python ./tools/acpi_extract_preprocess.py out/acpi-dsdt.dsl.i.orig > out/acpi-dsdt.dsl.i iasl -vs -l -tc -p out/acpi-dsdt out/acpi-dsdt.dsl.i out/acpi-dsdt.dsl.i 579: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L00) out/acpi-dsdt.dsl.i 582: Return(\_SB.PCI0.PCNF()) Warning 1104 - Reserved method should not return a value ^ (_E01) out/acpi-dsdt.dsl.i 585: Return(\_SB.PRSC()) Warning 1104 - ^ Reserved method should not return a value (_E02) out/acpi-dsdt.dsl.i 588: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L03) out/acpi-dsdt.dsl.i 591: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L04) out/acpi-dsdt.dsl.i 594: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L05) out/acpi-dsdt.dsl.i 597: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L06) out/acpi-dsdt.dsl.i 600: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L07) out/acpi-dsdt.dsl.i 603: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L08) out/acpi-dsdt.dsl.i 606: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L09) out/acpi-dsdt.dsl.i 609: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L0A) out/acpi-dsdt.dsl.i 612: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L0B) out/acpi-dsdt.dsl.i 615: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L0C) out/acpi-dsdt.dsl.i 618: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L0D) out/acpi-dsdt.dsl.i 621: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L0E) out/acpi-dsdt.dsl.i 624: Return(0x01) Warning 1104 - ^ Reserved method should not return a value (_L0F) ASL Input: out/acpi-dsdt.dsl.i - 629 lines, 22922 bytes, 344 keywords AML Output: out/acpi-dsdt.aml - 4682 bytes, 163 named objects, 181 executable opcodes Listing File: out/acpi-dsdt.lst - 152056 bytes Hex Dump: out/acpi-dsdt.hex - 44279 bytes Compilation complete. 0 Errors, 16 Warnings, 0 Remarks, 257 Optimizations python ./tools/acpi_extract.py out/acpi-dsdt.lst > out/acpi-dsdt.off cat out/acpi-dsdt.off > out/acpi-dsdt.hex Compiling IASL out/ssdt-proc.hex cpp -P src/ssdt-proc.dsl > out/ssdt-proc.dsl.i.orig python ./tools/acpi_extract_preprocess.py out/ssdt-proc.dsl.i.orig > out/ssdt-proc.dsl.i iasl -vs -l -tc -p out/ssdt-proc out/ssdt-proc.dsl.i ASL Input: out/ssdt-proc.dsl.i - 36 lines, 496 bytes, 8 keywords AML Output: out/ssdt-proc.aml - 120 bytes, 6 named objects, 2 executable opcodes Listing File: out/ssdt-proc.lst - 2502 bytes Hex Dump: out/ssdt-proc.hex - 1452 bytes Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 0 Optimizations python ./tools/acpi_extract.py out/ssdt-proc.lst > out/ssdt-proc.off cat out/ssdt-proc.off > out/ssdt-proc.hex Compiling IASL out/ssdt-pcihp.hex cpp -P src/ssdt-pcihp.dsl > out/ssdt-pcihp.dsl.i.orig python ./tools/acpi_extract_preprocess.py out/ssdt-pcihp.dsl.i.orig > out/ssdt-pcihp.dsl.i iasl -vs -l -tc -p out/ssdt-pcihp out/ssdt-pcihp.dsl.i out/ssdt-pcihp.dsl.i 13: Method (_EJ0, 1) { Return(PCEJ(0x01)) } Name (_SUN, 0x01) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 18: Method (_EJ0, 1) { Return(PCEJ(0x02)) } Name (_SUN, 0x02) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 23: Method (_EJ0, 1) { Return(PCEJ(0x03)) } Name (_SUN, 0x03) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 28: Method (_EJ0, 1) { Return(PCEJ(0x04)) } Name (_SUN, 0x04) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 33: Method (_EJ0, 1) { Return(PCEJ(0x05)) } Name (_SUN, 0x05) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 38: Method (_EJ0, 1) { Return(PCEJ(0x06)) } Name (_SUN, 0x06) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 43: Method (_EJ0, 1) { Return(PCEJ(0x07)) } Name (_SUN, 0x07) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 48: Method (_EJ0, 1) { Return(PCEJ(0x08)) } Name (_SUN, 0x08) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 53: Method (_EJ0, 1) { Return(PCEJ(0x09)) } Name (_SUN, 0x09) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 58: Method (_EJ0, 1) { Return(PCEJ(0x0a)) } Name (_SUN, 0x0a) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 63: Method (_EJ0, 1) { Return(PCEJ(0x0b)) } Name (_SUN, 0x0b) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 68: Method (_EJ0, 1) { Return(PCEJ(0x0c)) } Name (_SUN, 0x0c) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 73: Method (_EJ0, 1) { Return(PCEJ(0x0d)) } Name (_SUN, 0x0d) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 78: Method (_EJ0, 1) { Return(PCEJ(0x0e)) } Name (_SUN, 0x0e) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 83: Method (_EJ0, 1) { Return(PCEJ(0x0f)) } Name (_SUN, 0x0f) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 88: Method (_EJ0, 1) { Return(PCEJ(0x10)) } Name (_SUN, 0x10) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 93: Method (_EJ0, 1) { Return(PCEJ(0x11)) } Name (_SUN, 0x11) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 98: Method (_EJ0, 1) { Return(PCEJ(0x12)) } Name (_SUN, 0x12) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 103: Method (_EJ0, 1) { Return(PCEJ(0x13)) } Name (_SUN, 0x13) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 108: Method (_EJ0, 1) { Return(PCEJ(0x14)) } Name (_SUN, 0x14) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 113: Method (_EJ0, 1) { Return(PCEJ(0x15)) } Name (_SUN, 0x15) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 118: Method (_EJ0, 1) { Return(PCEJ(0x16)) } Name (_SUN, 0x16) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 123: Method (_EJ0, 1) { Return(PCEJ(0x17)) } Name (_SUN, 0x17) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 128: Method (_EJ0, 1) { Return(PCEJ(0x18)) } Name (_SUN, 0x18) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 133: Method (_EJ0, 1) { Return(PCEJ(0x19)) } Name (_SUN, 0x19) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 138: Method (_EJ0, 1) { Return(PCEJ(0x1a)) } Name (_SUN, 0x1a) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 143: Method (_EJ0, 1) { Return(PCEJ(0x1b)) } Name (_SUN, 0x1b) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 148: Method (_EJ0, 1) { Return(PCEJ(0x1c)) } Name (_SUN, 0x1c) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 153: Method (_EJ0, 1) { Return(PCEJ(0x1d)) } Name (_SUN, 0x1d) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 158: Method (_EJ0, 1) { Return(PCEJ(0x1e)) } Name (_SUN, 0x1e) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) out/ssdt-pcihp.dsl.i 163: Method (_EJ0, 1) { Return(PCEJ(0x1f)) } Name (_SUN, 0x1f) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) ASL Input: out/ssdt-pcihp.dsl.i - 232 lines, 5795 bytes, 254 keywords AML Output: out/ssdt-pcihp.aml - 1646 bytes, 130 named objects, 124 executable opcodes Listing File: out/ssdt-pcihp.lst - 36135 bytes Hex Dump: out/ssdt-pcihp.hex - 15779 bytes Compilation complete. 0 Errors, 31 Warnings, 0 Remarks, 3 Optimizations python ./tools/acpi_extract.py out/ssdt-pcihp.lst > out/ssdt-pcihp.off cat out/ssdt-pcihp.off > out/ssdt-pcihp.hex Compiling whole program out/ccode32flat.o echo -e '#include "../src/misc.c" #include "../src/stacks.c" #include "../src/pmm.c" #include "../src/output.c" #include "../src/util.c" #include "../src/block.c" #include "../src/floppy.c" #include "../src/ata.c" #include "../src/mouse.c" #include "../src/kbd.c" #include "../src/pci.c" #include "../src/serial.c" #include "../src/clock.c" #include "../src/pic.c" #include "../src/cdrom.c" #include "../src/ps2port.c" #include "../src/smp.c" #include "../src/resume.c" #include "../src/pnpbios.c" #include "../src/pirtable.c" #include "../src/vgahooks.c" #include "../src/ramdisk.c" #include "../src/pcibios.c" #include "../src/blockcmd.c" #include "../src/usb.c" #include "../src/usb-uhci.c" #include "../src/usb-ohci.c" #include "../src/usb-ehci.c" #include "../src/usb-hid.c" #include "../src/usb-msc.c" #include "../src/virtio-ring.c" #include "../src/virtio-pci.c" #include "../src/virtio-blk.c" #include "../src/virtio-scsi.c" #include "../src/apm.c" #include "../src/ahci.c" #include "../src/usb-uas.c" #include "../src/lsi-scsi.c" #include "../src/post.c" #include "../src/shadow.c" #include "../src/memmap.c" #include "../src/coreboot.c" #include "../src/boot.c" #include "../src/acpi.c" #include "../src/smm.c" #include "../src/mptable.c" #include "../src/smbios.c" #include "../src/pciinit.c" #include "../src/optionroms.c" #include "../src/mtrr.c" #include "../src/lzmadecode.c" #include "../src/bootsplash.c" #include "../src/jpeg.c" #include "../src/usb-hub.c" #include "../src/paravirt.c" #include "../src/biostables.c" #include "../src/xen.c" #include "../src/bmp.c" #include "../src/romfile.c"\n' > out/ccode32flat.o.tmp.c cc -Iout/ -Os -MD -g -Wall -Wno-strict-aliasing -Wold-style-definition -Wtype-limits -m32 -march=i386 -mregparm=3 -mpreferred-stack-boundary=2 -minline-all-stringops -freg-struct-return -ffreestanding -fno-delete-null-pointer-checks -ffunction-sections -fdata-sections -fno-common -fno-stack-protector -DMODE16=0 -DMODESEGMENT=0 -fomit-frame-pointer -fwhole-program -DWHOLE_PROGRAM -c out/ccode32flat.o.tmp.c -o out/ccode32flat.o out/ccode32flat.o.tmp.c:1:26: warning: extra tokens at end of #include directive [enabled by default] Compiling whole program out/code32seg.o echo -e '#include "../src/util.c" #include "../src/output.c" #include "../src/pci.c" #include "../src/pcibios.c" #include "../src/apm.c" #include "../src/stacks.c"\n' > out/code32seg.o.tmp.c cc -Iout/ -Os -MD -g -Wall -Wno-strict-aliasing -Wold-style-definition -Wtype-limits -m32 -march=i386 -mregparm=3 -mpreferred-stack-boundary=2 -minline-all-stringops -freg-struct-return -ffreestanding -fno-delete-null-pointer-checks -ffunction-sections -fdata-sections -fno-common -fno-stack-protector -DMODESEGMENT=1 -fno-defer-pop -fno-jump-tables -fno-tree-switch-conversion -DMODE16=0 -fomit-frame-pointer -fwhole-program -DWHOLE_PROGRAM -c out/code32seg.o.tmp.c -o out/code32seg.o out/code32seg.o.tmp.c:1:26: warning: extra tokens at end of #include directive [enabled by default] Compiling whole program out/ccode16.o echo -e '#include "../src/misc.c" #include "../src/stacks.c" #include "../src/pmm.c" #include "../src/output.c" #include "../src/util.c" #include "../src/block.c" #include "../src/floppy.c" #include "../src/ata.c" #include "../src/mouse.c" #include "../src/kbd.c" #include "../src/pci.c" #include "../src/serial.c" #include "../src/clock.c" #include "../src/pic.c" #include "../src/cdrom.c" #include "../src/ps2port.c" #include "../src/smp.c" #include "../src/resume.c" #include "../src/pnpbios.c" #include "../src/pirtable.c" #include "../src/vgahooks.c" #include "../src/ramdisk.c" #include "../src/pcibios.c" #include "../src/blockcmd.c" #include "../src/usb.c" #include "../src/usb-uhci.c" #include "../src/usb-ohci.c" #include "../src/usb-ehci.c" #include "../src/usb-hid.c" #include "../src/usb-msc.c" #include "../src/virtio-ring.c" #include "../src/virtio-pci.c" #include "../src/virtio-blk.c" #include "../src/virtio-scsi.c" #include "../src/apm.c" #include "../src/ahci.c" #include "../src/usb-uas.c" #include "../src/lsi-scsi.c" #include "../src/system.c" #include "../src/disk.c" #include "../src/font.c"\n' > out/ccode16.o.tmp.c cc -Iout/ -Os -MD -g -Wall -Wno-strict-aliasing -Wold-style-definition -Wtype-limits -m32 -march=i386 -mregparm=3 -mpreferred-stack-boundary=2 -minline-all-stringops -freg-struct-return -ffreestanding -fno-delete-null-pointer-checks -ffunction-sections -fdata-sections -fno-common -fno-stack-protector -DMODESEGMENT=1 -fno-defer-pop -fno-jump-tables -fno-tree-switch-conversion -DMODE16=1 -Wa,src/code16gcc.s --param large-stack-frame=4 -fomit-frame-pointer -fwhole-program -DWHOLE_PROGRAM -c out/ccode16.o.tmp.c -o out/ccode16.o out/ccode16.o.tmp.c:1:26: warning: extra tokens at end of #include directive [enabled by default] Compiling to assembler out/asm-offsets.s cc -Iout/ -Os -MD -g -Wall -Wno-strict-aliasing -Wold-style-definition -Wtype-limits -m32 -march=i386 -mregparm=3 -mpreferred-stack-boundary=2 -minline-all-stringops -freg-struct-return -ffreestanding -fno-delete-null-pointer-checks -ffunction-sections -fdata-sections -fno-common -fno-stack-protector -DMODESEGMENT=1 -fno-defer-pop -fno-jump-tables -fno-tree-switch-conversion -DMODE16=1 -Wa,src/code16gcc.s --param large-stack-frame=4 -fomit-frame-pointer -S -c src/asm-offsets.c -o out/asm-offsets.s Generating offset file out/asm-offsets.h ./tools/gen-offsets.sh out/asm-offsets.s out/asm-offsets.h Compiling (16bit) out/romlayout.o cc -Iout/ -Os -MD -g -Wall -Wno-strict-aliasing -Wold-style-definition -Wtype-limits -m32 -march=i386 -mregparm=3 -mpreferred-stack-boundary=2 -minline-all-stringops -freg-struct-return -ffreestanding -fno-delete-null-pointer-checks -ffunction-sections -fdata-sections -fno-common -fno-stack-protector -DMODESEGMENT=1 -fno-defer-pop -fno-jump-tables -fno-tree-switch-conversion -DMODE16=1 -Wa,src/code16gcc.s --param large-stack-frame=4 -fomit-frame-pointer -c -D__ASSEMBLY__ src/romlayout.S -o out/romlayout.o Building ld scripts ./tools/buildversion.sh out/version.c Version: rel-1.7.0-82-g9d6bac1-dirty-20120724_181335-tp-x60-1707cto cc -Iout/ -Os -MD -g -Wall -Wno-strict-aliasing -Wold-style-definition -Wtype-limits -m32 -march=i386 -mregparm=3 -mpreferred-stack-boundary=2 -minline-all-stringops -freg-struct-return -ffreestanding -fno-delete-null-pointer-checks -ffunction-sections -fdata-sections -fno-common -fno-stack-protector -DMODE16=0 -DMODESEGMENT=0 -fomit-frame-pointer -c out/version.c -o out/version.o ld -melf_i386 -r out/ccode32flat.o out/version.o -o out/code32flat.o ld -melf_i386 -r out/ccode16.o out/romlayout.o -o out/code16.o objdump -thr out/code32flat.o > out/code32flat.o.objdump objdump -thr out/code32seg.o > out/code32seg.o.objdump objdump -thr out/code16.o > out/code16.o.objdump python ./tools/layoutrom.py out/code16.o.objdump out/code32seg.o.objdump out/code32flat.o.objdump out/romlayout16.lds out/romlayout32seg.lds out/romlayout32flat.lds Fixed space: 0xe05b-0x10000 total: 8101 slack: 7273 Percent slack: 89.8% 16bit size: 8200 32bit segmented size: 0 32bit flat size: 8 32bit flat init size: 0 Lowmem size: 0 Linking out/rom16.o ld -T out/romlayout16.lds out/code16.o -o out/rom16.o out/code16.o: In function `handle_05': /home/idwer/coreboot/git/seabios/out/../src/misc.c:45: undefined reference to `__debug_enter' out/code16.o: In function `handle_02': /home/idwer/coreboot/git/seabios/out/../src/misc.c:60: undefined reference to `__debug_isr' out/code16.o: In function `entry_resume': /home/idwer/coreboot/git/seabios/src/romlayout.S:247: undefined reference to `ExtraStack' /home/idwer/coreboot/git/seabios/src/romlayout.S:249: undefined reference to `handle_resume' out/code16.o: In function `entry_pcibios32': /home/idwer/coreboot/git/seabios/src/romlayout.S:344: undefined reference to `_cfunc32seg_handle_pcibios32' out/code16.o: In function `entry_elf': /home/idwer/coreboot/git/seabios/src/romlayout.S:383: undefined reference to `_cfunc32flat_handle_post' out/code16.o: In function `irqentry_extrastack': /home/idwer/coreboot/git/seabios/src/romlayout.S:401: undefined reference to `StackPos' out/code16.o: In function `entry_13': /home/idwer/coreboot/git/seabios/src/romlayout.S:463: undefined reference to `handle_13' out/code16.o: In function `entry_19': /home/idwer/coreboot/git/seabios/src/romlayout.S:474: undefined reference to `_cfunc32flat_handle_19' out/code16.o: In function `entry_post': /home/idwer/coreboot/git/seabios/src/romlayout.S:492: undefined reference to `HaveRunPost' /home/idwer/coreboot/git/seabios/src/romlayout.S:494: undefined reference to `_cfunc32flat_handle_post' out/code16.o: In function `entry_14': /home/idwer/coreboot/git/seabios/src/romlayout.S:516: undefined reference to `handle_14' out/code16.o: In function `entry_16': /home/idwer/coreboot/git/seabios/src/romlayout.S:519: undefined reference to `handle_16' out/code16.o: In function `entry_09': /home/idwer/coreboot/git/seabios/src/romlayout.S:522: undefined reference to `handle_09' out/code16.o: In function `entry_40': /home/idwer/coreboot/git/seabios/src/romlayout.S:525: undefined reference to `handle_40' out/code16.o: In function `entry_0e': /home/idwer/coreboot/git/seabios/src/romlayout.S:528: undefined reference to `handle_0e' out/code16.o: In function `entry_17': /home/idwer/coreboot/git/seabios/src/romlayout.S:533: undefined reference to `handle_17' out/code16.o: In function `entry_15': /home/idwer/coreboot/git/seabios/src/romlayout.S:552: undefined reference to `handle_15' out/code16.o: In function `entry_1a': /home/idwer/coreboot/git/seabios/src/romlayout.S:557: undefined reference to `handle_1a' out/code16.o: In function `entry_08': /home/idwer/coreboot/git/seabios/src/romlayout.S:560: undefined reference to `handle_08' make: *** [out/rom16.o] Error 1 Non-fix #2: $ git diff diff --git a/Makefile b/Makefile index dfdec5c..3373c8b 100644 --- a/Makefile +++ b/Makefile @@ -97,7 +97,7 @@ ifeq "$(COMPSTRAT)" "1" # First method - use -fwhole-program without -combine. define whole-compile @echo " Compiling whole program $3" -$(Q)printf '$(foreach i,$2,#include "../$i"\n)' > $3.tmp.c +$(Q)echo -e '$(foreach i,$2,#include "../$i"\n)' | sed -e "s/^ //" > $3.tmp.c $(Q)$(CC) $1 -fwhole-program -DWHOLE_PROGRAM -c $3.tmp.c -o $3 endef else @@ -105,7 +105,7 @@ ifeq "$(COMPSTRAT)" "2" # Second menthod - don't use -fwhole-program at all. define whole-compile @echo " Compiling whole program $3" -$(Q)printf '$(foreach i,$2,#include "../$i"\n)' > $3.tmp.c +$(Q)echo '$(foreach i,$2,#include "../$i")' > $3.tmp.c $(Q)$(CC) $1 -c $3.tmp.c -o $3 endef else

1 0

Re: [SeaBIOS] [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions
by Eduardo Habkost 24 Jul '12

24 Jul '12

On Mon, Jul 23, 2012 at 07:44:44PM +0000, Blue Swirl wrote: > On Mon, Jul 23, 2012 at 7:28 PM, Eduardo Habkost <ehabkost(a)redhat.com> wrote: > > On Mon, Jul 23, 2012 at 07:11:11PM +0000, Blue Swirl wrote: > >> On Mon, Jul 23, 2012 at 6:59 PM, Eduardo Habkost <ehabkost(a)redhat.com> wrote: > >> > On Mon, Jul 23, 2012 at 04:49:07PM +0000, Blue Swirl wrote: > >> >> On Mon, Jul 16, 2012 at 5:42 PM, Eduardo Habkost <ehabkost(a)redhat.com> wrote: > >> >> > On Sat, Jul 14, 2012 at 09:14:30AM +0000, Blue Swirl wrote: > >> >> > [...] > >> >> >> >> > diff --git a/tests/Makefile b/tests/Makefile > >> >> >> >> > index b605e14..89bd890 100644 > >> >> >> >> > --- a/tests/Makefile > >> >> >> >> > +++ b/tests/Makefile > >> >> >> >> > @@ -15,6 +15,7 @@ check-unit-y += tests/test-string-output-visitor$(EXESUF) > >> >> >> >> > check-unit-y += tests/test-coroutine$(EXESUF) > >> >> >> >> > check-unit-y += tests/test-visitor-serialization$(EXESUF) > >> >> >> >> > check-unit-y += tests/test-iov$(EXESUF) > >> >> >> >> > +check-unit-y += tests/test-x86-cpuid$(EXESUF) > >> >> >> >> > >> >> >> >> This probably tries to build the cpuid test also for non-x86 targets > >> >> >> >> and break them all. > >> >> >> > > >> >> >> > I don't think there's any concept of "targets" for the check-unit tests. > >> >> >> > >> >> >> How about: > >> >> >> check-qtest-i386-y = tests/test-x86-cpuid$(EXESUF) > >> >> > > >> >> > test-x86-cpuid is not a qtest test case. > >> >> > >> >> Why not? I don't think it is a unit test either, judging from what the > >> >> other unit tests do. > >> > > >> > It is absolutely a unit test. I don't know why you don't think so. It > >> > simply checks the results of the APIC ID calculation functions. > >> > >> Yes, but the other 'unit tests' (the names used here are very > >> confusing, btw) check supporting functions like coroutines, not > >> hardware. Hardware tests (qtest) need to bind to an architecture, in > >> this case x86. > > > > test-x86-cpuid doesn't check hardware, either. It just checks the simple > > functions that calculate APIC IDs (to make sure the math is correct). > > Those functions aren't even used by any hardware emulation code until > > later in the patch series (when the CPU initialization code gets changed > > to use the new function). > > By that time the function is clearly x86 HW and the check is an x86 > hardware check. QEMU as whole consists of simple functions that > calculate something. It's useful onily for a specific architecture, yes, but it surely doesn't make libqtest necessary. That's the difference between the unit tests and qtest test cases: unit tests simply test small parts of the code (that may or may not be hardware-specific), and qtest tests hardware emulation after starting up a whole qemu process. It's a different kind of testing, with different sets of goals. I suppose you are not arguing that no function inside target-* would be ever allowed to have a unit test written for it. That would be a very silly constraint for people writing tests. -- Eduardo

2 1

[Seabois] BSOD during start of Win2003 installation
by Alexey Korolev 24 Jul '12

24 Jul '12

Hi, Win2003 falls to BSOD during early init stage of installer. It is ACPI related issue and it appears in any configuration. RAM size is 6GB Error code is : 0x000000A5 (0x02, 0xFFFFfADF6A446880, 0x1, 0xFFFFFADFAA34690) The things get broken after commit 2062f2bab81915c5c1f7af12a49ad8d4b3fd23fb (update dsdt resources at runtime) I've tried to debug this issue but haven't succeed yet. One strange thing here is that the code doesn't reach the _CRS method. We have added a debug output but nothing related to CRS was printed. May be you have any ideas why it may fail. I would much appreciate any help on this. Thanks, Alexey

1 0

[seabios PATCH 0/2] Allow non-contiguous APIC IDs
by Eduardo Habkost 24 Jul '12

24 Jul '12

Now this is an actual proposal I would like to get included on Seabios. It's much simpler than the previous RFCs. It simply changes the ACPI and mptable code to not require APIC IDs to be contiguous, eliminates references to the CountCPUs variable, using a 256-bit APIC ID bitmap to find out which CPUs are present on boot. Eduardo Habkost (2): acpi: set I/O APIC ID to 0 by default allow CPUs to have non-contiguous Local APIC IDs src/acpi-dsdt.dsl | 4 +++- src/acpi.c | 11 ++++++----- src/config.h | 2 ++ src/mptable.c | 2 +- src/smp.c | 17 +++++++++++++++++ src/util.h | 1 + 6 files changed, 30 insertions(+), 7 deletions(-) -- 1.7.10.4

3 8

Re: [SeaBIOS] [PATCH] geodevga: make use of readl and writel for mmio access
by Kevin O'Connor 24 Jul '12

24 Jul '12

On Wed, Jul 18, 2012 at 07:10:33PM +0200, Christian Gmeiner wrote: > On the other hand I will try to find someone how uses the vgabios on a > geode with a vga connector. Nils was able to run tests last time. -Kevin

3 3

Re: [SeaBIOS] [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions
by Eduardo Habkost 23 Jul '12

23 Jul '12

On Mon, Jul 23, 2012 at 07:11:11PM +0000, Blue Swirl wrote: > On Mon, Jul 23, 2012 at 6:59 PM, Eduardo Habkost <ehabkost(a)redhat.com> wrote: > > On Mon, Jul 23, 2012 at 04:49:07PM +0000, Blue Swirl wrote: > >> On Mon, Jul 16, 2012 at 5:42 PM, Eduardo Habkost <ehabkost(a)redhat.com> wrote: > >> > On Sat, Jul 14, 2012 at 09:14:30AM +0000, Blue Swirl wrote: > >> > [...] > >> >> >> > diff --git a/tests/Makefile b/tests/Makefile > >> >> >> > index b605e14..89bd890 100644 > >> >> >> > --- a/tests/Makefile > >> >> >> > +++ b/tests/Makefile > >> >> >> > @@ -15,6 +15,7 @@ check-unit-y += tests/test-string-output-visitor$(EXESUF) > >> >> >> > check-unit-y += tests/test-coroutine$(EXESUF) > >> >> >> > check-unit-y += tests/test-visitor-serialization$(EXESUF) > >> >> >> > check-unit-y += tests/test-iov$(EXESUF) > >> >> >> > +check-unit-y += tests/test-x86-cpuid$(EXESUF) > >> >> >> > >> >> >> This probably tries to build the cpuid test also for non-x86 targets > >> >> >> and break them all. > >> >> > > >> >> > I don't think there's any concept of "targets" for the check-unit tests. > >> >> > >> >> How about: > >> >> check-qtest-i386-y = tests/test-x86-cpuid$(EXESUF) > >> > > >> > test-x86-cpuid is not a qtest test case. > >> > >> Why not? I don't think it is a unit test either, judging from what the > >> other unit tests do. > > > > It is absolutely a unit test. I don't know why you don't think so. It > > simply checks the results of the APIC ID calculation functions. > > Yes, but the other 'unit tests' (the names used here are very > confusing, btw) check supporting functions like coroutines, not > hardware. Hardware tests (qtest) need to bind to an architecture, in > this case x86. test-x86-cpuid doesn't check hardware, either. It just checks the simple functions that calculate APIC IDs (to make sure the math is correct). Those functions aren't even used by any hardware emulation code until later in the patch series (when the CPU initialization code gets changed to use the new function). -- Eduardo

2 1

Re: [SeaBIOS] [Qemu-devel] SeaBIOS, FW_CFG_NUMA, and FW_CFG_MAX_CPUS
by Eduardo Habkost 23 Jul '12

23 Jul '12

On Mon, Jul 23, 2012 at 07:25:01PM +0000, Blue Swirl wrote: > On Mon, Jul 23, 2012 at 7:09 PM, Eduardo Habkost <ehabkost(a)redhat.com> wrote: > > On Mon, Jul 23, 2012 at 06:40:51PM +0000, Blue Swirl wrote: > >> On Fri, Jul 20, 2012 at 8:00 PM, Eduardo Habkost <ehabkost(a)redhat.com> wrote: > >> > Hi, > >> > > >> > While working at the CPU index vs APIC ID changes, I stumbled upon > >> > another not-very-well-defined interface between SeaBIOS and QEMU, and I > >> > would like to clarify the semantics and constraints of some FW_CFG > >> > entries. > >> > > >> > First, the facts/assumptions: > >> > > >> > - There's no concept of "CPU index" or "CPU identifier" that SeaBIOS and > >> > QEMU agree upon, except for the APIC ID. All SeaBIOS can really see > >> > are the CPU APIC IDs, on boot or on CPU hotplug. > >> > - The APIC ID is already a perfectly good CPU identifier, that is > >> > present on bare metal hardware too. > >> > - Adding a new kind of "CPU identifier" in addition to the APIC ID > >> > would just make things more complex. > >> > - The only problem with APIC IDs is that they may not be contiguous. > >> > > >> > That said, I would like to clarify the meaning of: > >> > > >> > - FW_CFG_MAX_CPUS > >> > > >> > What are the basic semantics and expectations about FW_CFG_MAX_CPUS? > >> > >> FYI: This originates from Sparc and PPC, it says how many SMP CPUs > >> there are in the system. There we don't have (at least now) any CPU > >> IDs and of course no APIC. > > > > Aren't you describing FW_CFG_NB_CPUS? If not, what's the difference > > between FS_CFG_NB_CPUS and FW_CFG_MAX_CPUS on those architectures? > > Yes, sorry. There's no difference. > > > > > Until now, the only purpose I see for max_cpus/FW_CFG_MAX_CPUS is to > > allow CPU hotplug. I don't know if there are other use cases where > > max_cpus/FW_CFG_MAX_CPUS is useful. > > > > > >> > >> But I have no idea what x86 should use. As a general rule, what would > >> happen on a real machine should be emulated, but QEMU can also assist > >> BIOS (for example to skip some complex HW probes). > > > > Right now I am divided between two approaches: > > > > - In case FW_CFG_MAX_CPUS' only purpose is to allow CPU hotplug, make it > > really mean "upper limit to APIC ID values" in x86; > > - Otherwise, I am inclined to add a FW_CFG_MAX_APIC_ID entry to x86, so > > the firmware can (optionally) choose appropriate sizes for its > > internal APIC-ID-based data structures. > > One integer does not tell very much. It tells a lot: it contains exactly 32 perfectly good bits of information. ;-) Jokes aside: one integer like that would be very helpful to SeaBIOS: by knowing what's the maximum APIC ID value it would ever see, it can build ACPI tables and support CPU hotplug without having to maintain and update Processor ID => APIC ID tables inside the ACPI ASL code (that's very hard to debug). > > > > >> > >> > Considering that the APIC IDs may not be contiguous, is it supposed to > >> > be: > >> > > >> > a) the maximum number of CPUs that will be ever online, doesn't matter > >> > their APIC IDs, or > >> > b) a value so that every CPU has APIC ID < MAX_CPUS. > >> > > >> > A practical example: suppose we have a machine with 18 CPUs with the > >> > following APIC IDs: 0x00, 0x01, 0x02, 0x04, 0x05, 0x06, 0x08, 0x09, > >> > 0x0a, 0x10, 0x11, 0x12, 0x14, 0x15, 0x16, 0x18, 0x19, 0x1a. > >> > > >> > (That's the expected result for a machine with 2 sockets, 3 cores per > >> > socket, 3 threads per core.) > >> > > >> > In that case, should FW_CFG_MAX_CPUS be: a) 18, or b) 27 (0x1b)? > >> > > >> > If it should be 18, it will require additional work on SeaBIOS to make: > >> > - CPU hotplug work > >> > - SRAT/MADT/SSDT tables be built with Processor ID != APIC ID > >> > - SRAT/MADT/SSDT tables be kept stable if the system is hibernated and > >> > resumed after a CPU is hot-plugged. > >> > > >> > (Probably in that case I would suggest introducing a FW_CFG_MAX_APIC_ID > >> > entry, so that SeaBIOS can still build the ACPI tables more easily). > >> > > >> > > >> > - FW_CFG_NUMA > >> > > >> > The first problem with FW_CFG_NUMA is that it depends on FW_CFG_MAX_CPUS > >> > (so it inherits the same questions above). The second is that > >> > FW_CFG_NUMA is a CPU-based table, but there's nothing SeaBIOS can use to > >> > know what CPUs FW_CFG_NUMA is refering to, except for the APIC IDs. So, > >> > should FW_CFG_NUMA be indexed by APIC IDs? > >> > > >> > > >> > - My proposal: > >> > > >> > My proposal is to try to keep things simple, and just use the following > >> > rule: > >> > > >> > - Never have a CPU with APIC ID > FW_CFG_MAX_CPUS. > >> > > >> > This way: > >> > - The SeaBIOS ACPI code can be kept simple. > >> > - The current CPU hotplug interface can work as-is (up to 256 CPUs), > >> > based on APIC IDs. > >> > - The current FW_CFG_NUMA interface can work as-is, indexed by APIC IDs. > >> > - The ACPI tables can be easily kept stable between hibernate and > >> > resume, after CPU hotplug. > >> > > >> > This is the direction I am trying to go, and I am sending this just to > >> > make sure nobody is against it, and to not surprise anybody when I send > >> > a QEMU patch to make FW_CFG_MAX_CPUS be based on APIC IDs. > >> > > >> > > >> > My second proposal would be to introduce a FW_CFG_MAX_APIC_ID entry, so > >> > the SeaBIOS ACPI code can be kept simple. > >> > > >> > My third proposal would be to introduce a FW_CFG CPU Index => APIC ID > >> > table, but I really wouldn't like to introduce a new type of CPU > >> > identifier to be used between QEMU and SeaBIOS, when the APIC ID is a > >> > perfectly good unique CPU identifier that already exists in bare metal > >> > hardware. > >> > > >> > -- > >> > Eduardo > >> > > >> > > > > -- > > Eduardo > -- Eduardo

1 0

Re: [SeaBIOS] [Qemu-devel] SeaBIOS, FW_CFG_NUMA, and FW_CFG_MAX_CPUS
by Eduardo Habkost 23 Jul '12

23 Jul '12

On Mon, Jul 23, 2012 at 06:40:51PM +0000, Blue Swirl wrote: > On Fri, Jul 20, 2012 at 8:00 PM, Eduardo Habkost <ehabkost(a)redhat.com> wrote: > > Hi, > > > > While working at the CPU index vs APIC ID changes, I stumbled upon > > another not-very-well-defined interface between SeaBIOS and QEMU, and I > > would like to clarify the semantics and constraints of some FW_CFG > > entries. > > > > First, the facts/assumptions: > > > > - There's no concept of "CPU index" or "CPU identifier" that SeaBIOS and > > QEMU agree upon, except for the APIC ID. All SeaBIOS can really see > > are the CPU APIC IDs, on boot or on CPU hotplug. > > - The APIC ID is already a perfectly good CPU identifier, that is > > present on bare metal hardware too. > > - Adding a new kind of "CPU identifier" in addition to the APIC ID > > would just make things more complex. > > - The only problem with APIC IDs is that they may not be contiguous. > > > > That said, I would like to clarify the meaning of: > > > > - FW_CFG_MAX_CPUS > > > > What are the basic semantics and expectations about FW_CFG_MAX_CPUS? > > FYI: This originates from Sparc and PPC, it says how many SMP CPUs > there are in the system. There we don't have (at least now) any CPU > IDs and of course no APIC. Aren't you describing FW_CFG_NB_CPUS? If not, what's the difference between FS_CFG_NB_CPUS and FW_CFG_MAX_CPUS on those architectures? Until now, the only purpose I see for max_cpus/FW_CFG_MAX_CPUS is to allow CPU hotplug. I don't know if there are other use cases where max_cpus/FW_CFG_MAX_CPUS is useful. > > But I have no idea what x86 should use. As a general rule, what would > happen on a real machine should be emulated, but QEMU can also assist > BIOS (for example to skip some complex HW probes). Right now I am divided between two approaches: - In case FW_CFG_MAX_CPUS' only purpose is to allow CPU hotplug, make it really mean "upper limit to APIC ID values" in x86; - Otherwise, I am inclined to add a FW_CFG_MAX_APIC_ID entry to x86, so the firmware can (optionally) choose appropriate sizes for its internal APIC-ID-based data structures. > > > Considering that the APIC IDs may not be contiguous, is it supposed to > > be: > > > > a) the maximum number of CPUs that will be ever online, doesn't matter > > their APIC IDs, or > > b) a value so that every CPU has APIC ID < MAX_CPUS. > > > > A practical example: suppose we have a machine with 18 CPUs with the > > following APIC IDs: 0x00, 0x01, 0x02, 0x04, 0x05, 0x06, 0x08, 0x09, > > 0x0a, 0x10, 0x11, 0x12, 0x14, 0x15, 0x16, 0x18, 0x19, 0x1a. > > > > (That's the expected result for a machine with 2 sockets, 3 cores per > > socket, 3 threads per core.) > > > > In that case, should FW_CFG_MAX_CPUS be: a) 18, or b) 27 (0x1b)? > > > > If it should be 18, it will require additional work on SeaBIOS to make: > > - CPU hotplug work > > - SRAT/MADT/SSDT tables be built with Processor ID != APIC ID > > - SRAT/MADT/SSDT tables be kept stable if the system is hibernated and > > resumed after a CPU is hot-plugged. > > > > (Probably in that case I would suggest introducing a FW_CFG_MAX_APIC_ID > > entry, so that SeaBIOS can still build the ACPI tables more easily). > > > > > > - FW_CFG_NUMA > > > > The first problem with FW_CFG_NUMA is that it depends on FW_CFG_MAX_CPUS > > (so it inherits the same questions above). The second is that > > FW_CFG_NUMA is a CPU-based table, but there's nothing SeaBIOS can use to > > know what CPUs FW_CFG_NUMA is refering to, except for the APIC IDs. So, > > should FW_CFG_NUMA be indexed by APIC IDs? > > > > > > - My proposal: > > > > My proposal is to try to keep things simple, and just use the following > > rule: > > > > - Never have a CPU with APIC ID > FW_CFG_MAX_CPUS. > > > > This way: > > - The SeaBIOS ACPI code can be kept simple. > > - The current CPU hotplug interface can work as-is (up to 256 CPUs), > > based on APIC IDs. > > - The current FW_CFG_NUMA interface can work as-is, indexed by APIC IDs. > > - The ACPI tables can be easily kept stable between hibernate and > > resume, after CPU hotplug. > > > > This is the direction I am trying to go, and I am sending this just to > > make sure nobody is against it, and to not surprise anybody when I send > > a QEMU patch to make FW_CFG_MAX_CPUS be based on APIC IDs. > > > > > > My second proposal would be to introduce a FW_CFG_MAX_APIC_ID entry, so > > the SeaBIOS ACPI code can be kept simple. > > > > My third proposal would be to introduce a FW_CFG CPU Index => APIC ID > > table, but I really wouldn't like to introduce a new type of CPU > > identifier to be used between QEMU and SeaBIOS, when the APIC ID is a > > perfectly good unique CPU identifier that already exists in bare metal > > hardware. > > > > -- > > Eduardo > > > -- Eduardo

2 1

Re: [SeaBIOS] [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions
by Eduardo Habkost 23 Jul '12

23 Jul '12

On Mon, Jul 23, 2012 at 04:49:07PM +0000, Blue Swirl wrote: > On Mon, Jul 16, 2012 at 5:42 PM, Eduardo Habkost <ehabkost(a)redhat.com> wrote: > > On Sat, Jul 14, 2012 at 09:14:30AM +0000, Blue Swirl wrote: > > [...] > >> >> > diff --git a/tests/Makefile b/tests/Makefile > >> >> > index b605e14..89bd890 100644 > >> >> > --- a/tests/Makefile > >> >> > +++ b/tests/Makefile > >> >> > @@ -15,6 +15,7 @@ check-unit-y += tests/test-string-output-visitor$(EXESUF) > >> >> > check-unit-y += tests/test-coroutine$(EXESUF) > >> >> > check-unit-y += tests/test-visitor-serialization$(EXESUF) > >> >> > check-unit-y += tests/test-iov$(EXESUF) > >> >> > +check-unit-y += tests/test-x86-cpuid$(EXESUF) > >> >> > >> >> This probably tries to build the cpuid test also for non-x86 targets > >> >> and break them all. > >> > > >> > I don't think there's any concept of "targets" for the check-unit tests. > >> > >> How about: > >> check-qtest-i386-y = tests/test-x86-cpuid$(EXESUF) > > > > test-x86-cpuid is not a qtest test case. > > Why not? I don't think it is a unit test either, judging from what the > other unit tests do. It is absolutely a unit test. I don't know why you don't think so. It simply checks the results of the APIC ID calculation functions. > > > > >> > >> > I had to do the following, to be able to make a test that uses the > >> > target-i386 code: > >> > > >> >> > +tests/test-x86-cpuid.o: QEMU_INCLUDES += -Itarget-i386 > >> > > >> > Any suggestions to avoid this hack would be welcome. > >> > >> Maybe it would be simpler to adjust #include path in the file. > > > > Using the full path on the #include line would break in case > > target-i386/topology.h include other files from the target-i386 > > directory. > > That's fragile. Maybe the target-xyz files should use the full path. Yes, it would be fragile. That's why I used -Itarget-i386 (not a perfect solution, but more likely to stay working and not break easily). I don't know if I understand what you propose. You mean to change the 256 target-specific #include lines inside qemu? $ git grep -f <(find target-* -name '*.h' | sed -e 's@target-[^/]*/@#include "@' | sort -u) target-* | wc -l 256 -- Eduardo

2 1

← Newer
1
2
3
4
5
6
7
...
12
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS July 2012