July 2012 - SeaBIOS - mail.coreboot.org

Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with its ACPI code
by Idwer Vollering July 31, 2012

July 31, 2012

2012/7/31 Moore, Robert <robert.moore(a)intel.com>: > On Debian, we are using > > Flex 2.5.35 > Bison 2.4.1 My build machine runs 64-bit archlinux and has gcc 4.7.1, flex 2.5.36 and bison 2.6 installed. P.S. please use reply-to-all, so everyone is informed.

1 0

Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with its ACPI code
by Idwer Vollering July 31, 2012

July 31, 2012

2012/7/31 Moore, Robert <robert.moore(a)intel.com>: > We are using gcc 4.6.3 here. > > Can you send me the error output from the use of -Wredundant-decls? > > Thanks, > Bob $ make clean ; make V=1 rm -f iasl iasl.exe aslcompilerlex.o aslcompilerparse.o dtparserlex.o dtparserparse.o prparserlex.o prparserparse.o adfile.o adisasm.o adwalk.o ahpredef.o aslanalyze.o aslbtypes.o aslcodegen.o aslcompile.o aslerror.o aslfiles.o aslfold.o asllength.o asllisting.o aslload.o asllookup.o aslmain.o aslmap.o aslopcodes.o asloperands.o aslopt.o aslpredef.o aslresource.o aslrestype1.o aslrestype1i.o aslrestype2.o aslrestype2d.o aslrestype2e.o aslrestype2s.o aslrestype2q.o aslrestype2w.o aslstartup.o aslstubs.o asltransform.o asltree.o aslutils.o asluuid.o aslwalks.o dtcompile.o dtexpress.o dtfield.o dtio.o dtsubtable.o dttable.o dttemplate.o dtutils.o dbfileio.o dmbuffer.o dmextern.o dmnames.o dmobject.o dmopcode.o dmresrc.o dmresrcl.o dmresrcl2.o dmresrcs.o dmrestag.o dmtable.o dmtbdump.o dmtbinfo.o dmutils.o dmwalk.o dsargs.o dscontrol.o dsfield.o dsobject.o dsopcode.o dsutils.o dswexec.o dswload.o dswload2.o dswscope.o dswstate.o exconvrt.o excreate.o exdump.o exmisc.o exmutex.o exnames.o exoparg1.o exoparg2.o exoparg3.o exoparg6.o exprep.o exregion.o exresnte.o exresolv.o exresop.o exstore.o exstoren.o exstorob.o exsystem.o exutils.o getopt.o nsaccess.o nsalloc.o nsdump.o nsnames.o nsobject.o nsparse.o nssearch.o nsutils.o nswalk.o nsxfobj.o osunixxf.o prexpress.o prmacros.o prscan.o prutils.o psargs.o psloop.o psopcode.o psparse.o psscope.o pstree.o psutils.o pswalk.o tbfadt.o tbinstal.o tbutils.o tbxface.o utaddress.o utalloc.o utcache.o utcopy.o utdebug.o utdecode.o utdelete.o utexcep.o utglobal.o utinit.o utlock.o utmath.o utmisc.o utmutex.o utobject.o utresrc.o utstate.o utxferror.o utxface.o aslcompilerlex.c aslcompilerparse.c dtparserlex.c dtparserparse.c prparserlex.c prparserparse.c aslcompilerparse.h aslcompiler.y.h aslcompilerparse.output dtparserparse.h dtparser.y.h dtparserparse.output prparserparse.h prparser.y.h prparserparse.output flex -i -s -PAslCompiler -oaslcompilerlex.c ../../source/compiler/aslcompiler.l bison -v -d -y -pAslCompiler -oaslcompilerparse.c ../../source/compiler/aslcompiler.y flex -i -s -PDtParser -odtparserlex.c ../../source/compiler/dtparser.l bison -v -d -y -pDtParser -odtparserparse.c ../../source/compiler/dtparser.y flex -i -s -PPrParser -oprparserlex.c ../../source/compiler/prparser.l bison -v -d -y -pPrParser -oprparserparse.c ../../source/compiler/prparser.y Copy intermediate file: 'aslcompilerparse.h' -> 'aslcompiler.y.h' Copy intermediate file: 'dtparserparse.h' -> 'dtparser.y.h' Copy intermediate file: 'prparserparse.h' -> 'prparser.y.h' cc -c -D_LINUX -D_GNU_SOURCE -DACPI_ASL_COMPILER -I../../source/include -I../../source/compiler -Wall -Werror -Wstrict-aliasing=0 -oaslcompilerlex.o aslcompilerlex.c cc -c -D_LINUX -D_GNU_SOURCE -DACPI_ASL_COMPILER -I../../source/include -I../../source/compiler -Wall -Werror -Wstrict-aliasing=0 -oaslcompilerparse.o aslcompilerparse.c cc -c -D_LINUX -D_GNU_SOURCE -DACPI_ASL_COMPILER -I../../source/include -I../../source/compiler -Wall -Werror -Wstrict-aliasing=0 -odtparserlex.o dtparserlex.c cc -c -D_LINUX -D_GNU_SOURCE -DACPI_ASL_COMPILER -I../../source/include -I../../source/compiler -Wall -Werror -Wstrict-aliasing=0 -odtparserparse.o dtparserparse.c cc -c -D_LINUX -D_GNU_SOURCE -DACPI_ASL_COMPILER -I../../source/include -I../../source/compiler -Wall -Werror -Wstrict-aliasing=0 -oprparserlex.o prparserlex.c cc -c -D_LINUX -D_GNU_SOURCE -DACPI_ASL_COMPILER -I../../source/include -I../../source/compiler -Wall -Werror -Wstrict-aliasing=0 -oprparserparse.o prparserparse.c cc -c -D_LINUX -D_GNU_SOURCE -DACPI_ASL_COMPILER -I../../source/include -I../../source/compiler -ansi -Wall -Wbad-function-cast -Wdeclaration-after-statement -Werror -Wformat=2 -Wmissing-declarations -Wmissing-prototypes -Wstrict-aliasing=0 -Wstrict-prototypes -Wswitch-default -Wpointer-arith -Wundef -Waddress -Waggregate-return -Wchar-subscripts -Wempty-body -Wlogical-op -Wmissing-declarations -Wmissing-field-initializers -Wmissing-parameter-type -Wnested-externs -Wold-style-declaration -Wold-style-definition -Wredundant-decls -Wtype-limits -oadfile.o ../../source/common/adfile.c cc -c -D_LINUX -D_GNU_SOURCE -DACPI_ASL_COMPILER -I../../source/include -I../../source/compiler -ansi -Wall -Wbad-function-cast -Wdeclaration-after-statement -Werror -Wformat=2 -Wmissing-declarations -Wmissing-prototypes -Wstrict-aliasing=0 -Wstrict-prototypes -Wswitch-default -Wpointer-arith -Wundef -Waddress -Waggregate-return -Wchar-subscripts -Wempty-body -Wlogical-op -Wmissing-declarations -Wmissing-field-initializers -Wmissing-parameter-type -Wnested-externs -Wold-style-declaration -Wold-style-definition -Wredundant-decls -Wtype-limits -oadisasm.o ../../source/common/adisasm.c cc -c -D_LINUX -D_GNU_SOURCE -DACPI_ASL_COMPILER -I../../source/include -I../../source/compiler -ansi -Wall -Wbad-function-cast -Wdeclaration-after-statement -Werror -Wformat=2 -Wmissing-declarations -Wmissing-prototypes -Wstrict-aliasing=0 -Wstrict-prototypes -Wswitch-default -Wpointer-arith -Wundef -Waddress -Waggregate-return -Wchar-subscripts -Wempty-body -Wlogical-op -Wmissing-declarations -Wmissing-field-initializers -Wmissing-parameter-type -Wnested-externs -Wold-style-declaration -Wold-style-definition -Wredundant-decls -Wtype-limits -oadwalk.o ../../source/common/adwalk.c cc -c -D_LINUX -D_GNU_SOURCE -DACPI_ASL_COMPILER -I../../source/include -I../../source/compiler -ansi -Wall -Wbad-function-cast -Wdeclaration-after-statement -Werror -Wformat=2 -Wmissing-declarations -Wmissing-prototypes -Wstrict-aliasing=0 -Wstrict-prototypes -Wswitch-default -Wpointer-arith -Wundef -Waddress -Waggregate-return -Wchar-subscripts -Wempty-body -Wlogical-op -Wmissing-declarations -Wmissing-field-initializers -Wmissing-parameter-type -Wnested-externs -Wold-style-declaration -Wold-style-definition -Wredundant-decls -Wtype-limits -oahpredef.o ../../source/common/ahpredef.c cc -c -D_LINUX -D_GNU_SOURCE -DACPI_ASL_COMPILER -I../../source/include -I../../source/compiler -ansi -Wall -Wbad-function-cast -Wdeclaration-after-statement -Werror -Wformat=2 -Wmissing-declarations -Wmissing-prototypes -Wstrict-aliasing=0 -Wstrict-prototypes -Wswitch-default -Wpointer-arith -Wundef -Waddress -Waggregate-return -Wchar-subscripts -Wempty-body -Wlogical-op -Wmissing-declarations -Wmissing-field-initializers -Wmissing-parameter-type -Wnested-externs -Wold-style-declaration -Wold-style-definition -Wredundant-decls -Wtype-limits -oaslanalyze.o aslanalyze.c In file included from aslanalyze.c:118:0: aslcompilerparse.h:738:5: error: redundant redeclaration of 'AslCompilerparse' [-Werror=redundant-decls] In file included from aslanalyze.c:117:0: aslcompiler.h:163:1: note: previous declaration of 'AslCompilerparse' was here cc1: all warnings being treated as errors make: *** [aslanalyze.o] Error 1

1 0

Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with its ACPI code
by Idwer Vollering July 31, 2012

July 31, 2012

Adding some details. 2012/7/31 Moore, Robert <robert.moore(a)intel.com>: > Please let me know if the -Pn option works for you. > Thanks, > Bob -Pn works for me, with acpica-20120420-64 and with acpica-unix-20120711. acpica-unix-20120711 needs this patch, for gcc 4.7.1: diff -ur acpica-unix-20120711/source/compiler/Makefile acpica-unix-20120711-patched/source/compiler/Makefile --- acpica-unix-20120711/source/compiler/Makefile 2012-07-11 17:55:10.000000000 +0200 +++ acpica-unix-20120711-patched/source/compiler/Makefile 2012-07-31 19:50:59.077389584 +0200 @@ -270,7 +270,6 @@ -Wnested-externs \ -Wold-style-declaration \ -Wold-style-definition \ - -Wredundant-decls \ -Wtype-limits #

1 0

Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with its ACPI code
by Idwer Vollering July 31, 2012

July 31, 2012

2012/7/31 Moore, Robert <robert.moore(a)intel.com>: > Please let me know if the -Pn option works for you. > Thanks, > Bob -Pn works for me, on acpica-20120420-64. acpica-unix-20120711 needs this patch, for gcc 4.7.1: diff -ur acpica-unix-20120711/source/compiler/Makefile acpica-unix-20120711-patched/source/compiler/Makefile --- acpica-unix-20120711/source/compiler/Makefile 2012-07-11 17:55:10.000000000 +0200 +++ acpica-unix-20120711-patched/source/compiler/Makefile 2012-07-31 19:50:59.077389584 +0200 @@ -270,7 +270,6 @@ -Wnested-externs \ -Wold-style-declaration \ -Wold-style-definition \ - -Wredundant-decls \ -Wtype-limits #

1 0

[PATCH] Add an IPMI SMBIOS entry
by minyard＠acm.org July 31, 2012

July 31, 2012

From: Corey Minyard <cminyard(a)mvista.com> An IPMI device is being added to the qemu code, and it has an SMBIOS entry to describe the interface characteristics. So add the SMBIOS entry to the BIOS so it can handle this. Signed-off-by: Corey Minyard <cminyard(a)mvista.com> --- Makefile | 2 +- src/ipmi.c | 16 ++++++++++++++++ src/ipmi.h | 27 +++++++++++++++++++++++++++ src/paravirt.c | 18 ++++++++++++++++++ src/paravirt.h | 9 +++++++++ src/post.c | 2 ++ src/smbios.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ src/smbios.h | 12 ++++++++++++ src/util.h | 5 +++++ 9 files changed, 144 insertions(+), 1 deletions(-) create mode 100644 src/ipmi.c create mode 100644 src/ipmi.h diff --git a/Makefile b/Makefile index dfdec5c..1b6eb96 100644 --- a/Makefile +++ b/Makefile @@ -13,7 +13,7 @@ SRCBOTH=misc.c stacks.c pmm.c output.c util.c block.c floppy.c ata.c mouse.c \ pnpbios.c pirtable.c vgahooks.c ramdisk.c pcibios.c blockcmd.c \ usb.c usb-uhci.c usb-ohci.c usb-ehci.c usb-hid.c usb-msc.c \ virtio-ring.c virtio-pci.c virtio-blk.c virtio-scsi.c apm.c ahci.c \ - usb-uas.c lsi-scsi.c + usb-uas.c lsi-scsi.c ipmi.c SRC16=$(SRCBOTH) system.c disk.c font.c SRC32FLAT=$(SRCBOTH) post.c shadow.c memmap.c coreboot.c boot.c \ acpi.c smm.c mptable.c smbios.c pciinit.c optionroms.c mtrr.c \ diff --git a/src/ipmi.c b/src/ipmi.c new file mode 100644 index 0000000..7521a8b --- /dev/null +++ b/src/ipmi.c @@ -0,0 +1,16 @@ +// IPMI setup information +// +// Copyright (C) 2012 Corey Minyard <cminyard(a)mvista.com> +// +// This file may be distributed under the terms of the GNU LGPLv3 license. + +#include "ipmi.h" +#include "paravirt.h" + +struct ipmi_info ipmi_info; + +void +ipmi_setup(void) +{ + qemu_cfg_load_ipmi(&ipmi_info); +} diff --git a/src/ipmi.h b/src/ipmi.h new file mode 100644 index 0000000..b0cf61e --- /dev/null +++ b/src/ipmi.h @@ -0,0 +1,27 @@ +// IPMI setup information +// +// Copyright (C) 2012 Corey Minyard <cminyard(a)mvista.com> +// +// This file may be distributed under the terms of the GNU LGPLv3 license. + +#ifndef __IPMI_H +#define __IPMI_H + +#include "config.h" // CONFIG_COREBOOT +#include "types.h" + +struct ipmi_info { + u64 base_addr; + u8 interface; + u8 reg_space; + u8 reg_spacing; + u8 slave_addr; + u8 irq; + u8 version; +}; + +extern struct ipmi_info ipmi_info; + +void ipmi_setup(void); + +#endif diff --git a/src/paravirt.c b/src/paravirt.c index 2a98d53..4986cfb 100644 --- a/src/paravirt.c +++ b/src/paravirt.c @@ -148,6 +148,24 @@ void* qemu_cfg_e820_load_next(void *addr) return addr; } +void qemu_cfg_load_ipmi(struct ipmi_info *info) +{ + qemu_cfg_read_entry(&info->interface, QEMU_CFG_IPMI_INTERFACE, sizeof(u8)); + qemu_cfg_read_entry(&info->base_addr, QEMU_CFG_IPMI_BASE_ADDR, sizeof(u64)); + + if ((info->interface == 0) || (info->base_addr == 0)) + return; + + info->base_addr = le64_to_cpu(info->base_addr); + qemu_cfg_read_entry(&info->reg_spacing, QEMU_CFG_IPMI_REG_SPACING, + sizeof(u8)); + qemu_cfg_read_entry(&info->reg_space, QEMU_CFG_IPMI_REG_SPACE, sizeof(u8)); + qemu_cfg_read_entry(&info->version, QEMU_CFG_IPMI_VERSION, sizeof(u8)); + qemu_cfg_read_entry(&info->slave_addr, QEMU_CFG_IPMI_SLAVE_ADDR, + sizeof(u8)); + qemu_cfg_read_entry(&info->irq, QEMU_CFG_IPMI_IRQ, sizeof(u8)); +} + struct smbios_header { u16 length; u8 type; diff --git a/src/paravirt.h b/src/paravirt.h index a284c41..b14e41b 100644 --- a/src/paravirt.h +++ b/src/paravirt.h @@ -3,6 +3,7 @@ #include "config.h" // CONFIG_COREBOOT #include "util.h" +#include "ipmi.h" // struct ipmi_info /* This CPUID returns the signature 'KVMKVMKVM' in ebx, ecx, and edx. It * should be used to determine that a VM is running under KVM. @@ -35,6 +36,13 @@ static inline int kvm_para_available(void) #define QEMU_CFG_BOOT_MENU 0x0e #define QEMU_CFG_MAX_CPUS 0x0f #define QEMU_CFG_FILE_DIR 0x19 +#define QEMU_CFG_IPMI_INTERFACE 0x30 +#define QEMU_CFG_IPMI_BASE_ADDR 0x31 +#define QEMU_CFG_IPMI_REG_SPACE 0x32 +#define QEMU_CFG_IPMI_REG_SPACING 0x33 +#define QEMU_CFG_IPMI_SLAVE_ADDR 0x34 +#define QEMU_CFG_IPMI_IRQ 0x35 +#define QEMU_CFG_IPMI_VERSION 0x36 #define QEMU_CFG_ARCH_LOCAL 0x8000 #define QEMU_CFG_ACPI_TABLES (QEMU_CFG_ARCH_LOCAL + 0) #define QEMU_CFG_SMBIOS_ENTRIES (QEMU_CFG_ARCH_LOCAL + 1) @@ -64,6 +72,7 @@ struct e820_reservation { }; u32 qemu_cfg_e820_entries(void); void* qemu_cfg_e820_load_next(void *addr); +void qemu_cfg_load_ipmi(struct ipmi_info *info); void qemu_cfg_romfile_setup(void); #endif diff --git a/src/post.c b/src/post.c index 0f31b4c..69834b6 100644 --- a/src/post.c +++ b/src/post.c @@ -28,6 +28,7 @@ #include "virtio-blk.h" // virtio_blk_setup #include "virtio-scsi.h" // virtio_scsi_setup #include "lsi-scsi.h" // lsi_scsi_setup +#include "ipmi.h" // ipmi_setup /**************************************************************** @@ -255,6 +256,7 @@ maininit(void) pnp_setup(); kbd_setup(); mouse_setup(); + ipmi_setup(); init_bios_tables(); // Run vga option rom diff --git a/src/smbios.c b/src/smbios.c index fc84aad..9576c02 100644 --- a/src/smbios.c +++ b/src/smbios.c @@ -422,6 +422,58 @@ smbios_init_type_32(void *start) return start+2; } +/* Type 38 -- System Boot Information */ +static void * +smbios_init_type_38(void *start, struct ipmi_info *info) +{ + struct smbios_type_38 *p = (struct smbios_type_38 *)start; + + p->header.type = 38; + p->header.length = sizeof(struct smbios_type_38); + p->header.handle = 0x2100; + + p->interface_type = info->interface; + + p->base_addr = info->base_addr & ~1ULL; + /* Bit 0 goes into a special place */ + p->base_addr_mod_and_irq_info = (info->base_addr & 1) << 4; + + switch (info->reg_spacing) { + case 4: + p->base_addr_mod_and_irq_info |= (1 << 6); + break; + case 16: + p->base_addr_mod_and_irq_info |= (2 << 6); + break; + case 1: + default: + /* zero is the right value */ + break; + } + + if (info->reg_space) + p->base_addr |= 1; /* I/O space */ + + if (info->version) + p->ipmi_version = info->version; + else + p->ipmi_version = 0x15; + + if (info->slave_addr) + p->i2c_slave_addr = info->slave_addr; + else + p->i2c_slave_addr = 0x20; + + p->nv_storage_dev_addr = 0; + + p->interrupt_number = info->irq; + + start += sizeof(struct smbios_type_38); + *((u16 *)start) = 0; + + return start+2; +} + /* Type 127 -- End of Table */ static void * smbios_init_type_127(void *start) @@ -510,6 +562,8 @@ smbios_init(void) } add_struct(32, p); + if (ipmi_info.interface) + add_struct(38, p, &ipmi_info); /* Add any remaining provided entries before the end marker */ for (i = 0; i < 256; i++) qemu_cfg_smbios_load_external(i, &p, &nr_structs, &max_struct_size, diff --git a/src/smbios.h b/src/smbios.h index 9d54e80..1935335 100644 --- a/src/smbios.h +++ b/src/smbios.h @@ -160,6 +160,18 @@ struct smbios_type_32 { u8 boot_status; } PACKED; +/* SMBIOS type 38 - IPMI Information */ +struct smbios_type_38 { + struct smbios_structure_header header; + u8 interface_type; + u8 ipmi_version; + u8 i2c_slave_addr; + u8 nv_storage_dev_addr; + u64 base_addr; + u8 base_addr_mod_and_irq_info; + u8 interrupt_number; +} PACKED; + /* SMBIOS type 127 -- End-of-table */ struct smbios_type_127 { struct smbios_structure_header header; diff --git a/src/util.h b/src/util.h index ef8ec7c..415f518 100644 --- a/src/util.h +++ b/src/util.h @@ -134,6 +134,11 @@ static inline u32 le32_to_cpu(u32 x) return x; } +static inline u64 le64_to_cpu(u64 x) +{ + return x; +} + static inline u32 getesp(void) { u32 esp; asm("movl %%esp, %0" : "=rm"(esp)); -- 1.7.4.1

4 5

Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with its ACPI code
by Moore, Robert July 31, 2012

July 31, 2012

Please let me know if the -Pn option works for you. Thanks, Bob > -----Original Message----- > From: Moore, Robert > Sent: Monday, July 30, 2012 12:43 PM > To: Idwer Vollering > Cc: Michael S. Tsirkin; Kevin O'Connor; seabios(a)seabios.org; Tang, Feng > Subject: RE: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with > its ACPI code > > Yes, you are correct, the listing no longer includes the comments. > > Sorry for causing you a problem. > > What is happening is that the preprocessor parser is stripping the > comments during the creation of the .i file. Then, the compiler is > invoked on the .i file -- thus, the comments are gone. > > This is going to take a bit of work to correct, but we will do it. > > In the meantime, try using the -Pn flag to disable the preprocessor. > When this flag is set, the preprocessor is completely bypassed and the > compiler should function as it did previously. > > Example below: > > > /* > * Intel ACPI Component Architecture > * iASL Compiler/Disassembler version 20120711-32 [Jul 30 2012] > * Copyright (c) 2000 - 2012 Intel Corporation > * > * Template for [DSDT] ACPI Table > */ > > DefinitionBlock ("dsdt.aml", "DSDT", 2, "Intel", "Template", > 0x00000001) { > /* Comment for MAIN method */ > > Method (MAIN, 0, NotSerialized) > { > Return (Zero) > } > } > > > C:\Acpi\listing>iasl -l -Pn dsdt.asl > > Intel ACPI Component Architecture > ASL Optimizing Compiler version 20120711-32 [Jul 30 2012] Copyright (c) > 2000 - 2012 Intel Corporation > > ASL Input: dsdt.asl - 19 lines, 377 bytes, 2 keywords > AML Output: dsdt.aml - 45 bytes, 1 named objects, 1 executable > opcodes > Listing File: dsdt.lst - 1536 bytes > > Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 0 Optimizations > > > dsdt.lst > -------- > > Intel ACPI Component Architecture > ASL Optimizing Compiler version 20120711-32 [Jul 30 2012] Copyright (c) > 2000 - 2012 Intel Corporation > > Compilation of "dsdt.asl" - Mon Jul 30 12:37:36 2012 > > 1..../* > 2.... * Intel ACPI Component Architecture > 3.... * iASL Compiler/Disassembler version 20120711-32 [Jul 19 > 2012] > 4.... * Copyright (c) 2000 - 2012 Intel Corporation > 5.... * > 6.... * Template for [DSDT] ACPI Table > 7.... */ > 8.... > 9....DefinitionBlock ("dsdt.aml", "DSDT", 2, "Intel", > "Template", 0x00000001) > > 00000000....44 53 44 54 2D 00 00 00 "DSDT-..." > 00000008....02 03 49 6E 74 65 6C 00 "..Intel." > 00000010....54 65 6D 70 6C 61 74 65 "Template" > 00000018....01 00 00 00 49 4E 54 4C "....INTL" > 00000020....11 07 12 20 ............ "... " > > 10....{ > 11.... /* Comment for MAIN method */ > 12.... > 13.... Method (MAIN, 0, NotSerialized) > > 00000024....14 08 4D 41 49 4E 00 ... "..MAIN." > > 14.... { > 15.... Return (Zero) > > 0000002B....A4 00 .................. ".." > 16.... } > 17....} > 18.... > 19.... > > > > > > > -----Original Message----- > > From: Moore, Robert > > Sent: Monday, July 30, 2012 10:57 AM > > To: 'Idwer Vollering' > > Cc: Michael S. Tsirkin; Kevin O'Connor; seabios(a)seabios.org > > Subject: RE: [SeaBIOS] Compiling SeaBIOS for coreboot has problems > > with its ACPI code > > > > OK, I will take a look at it. > > > > Are all the comments throughout the code stripped from the listing? > > > > > -----Original Message----- > > > From: Idwer Vollering [mailto:vidwer@gmail.com] > > > Sent: Monday, July 30, 2012 10:35 AM > > > To: Moore, Robert > > > Cc: Michael S. Tsirkin; Kevin O'Connor; seabios(a)seabios.org > > > Subject: Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems > > > with its ACPI code > > > > > > 2012/7/30 Moore, Robert <robert.moore(a)intel.com>: > > > > We have made some fixes regarding listing support in conjunction > > > > with > > > the new preprocessor. > > > > > > > > Please try the very latest iASL compiler, version 20120711. > > > > > > > > Thanks, > > > > Bob > > > > > > Actually I have tried acpica-unix-20120711 (and > > > acpica-unix-20120320, acpica-unix-20120420, acpica-unix-20120518, > acpica-unix-20120620). > > > The last version of iASL that worked (for me) with SeaBIOS is > > > acpica- unix-20120215. > > > > > > Idwer

1 0

Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with its ACPI code
by Moore, Robert July 30, 2012

July 30, 2012

Yes, you are correct, the listing no longer includes the comments. Sorry for causing you a problem. What is happening is that the preprocessor parser is stripping the comments during the creation of the .i file. Then, the compiler is invoked on the .i file -- thus, the comments are gone. This is going to take a bit of work to correct, but we will do it. In the meantime, try using the -Pn flag to disable the preprocessor. When this flag is set, the preprocessor is completely bypassed and the compiler should function as it did previously. Example below: /* * Intel ACPI Component Architecture * iASL Compiler/Disassembler version 20120711-32 [Jul 30 2012] * Copyright (c) 2000 - 2012 Intel Corporation * * Template for [DSDT] ACPI Table */ DefinitionBlock ("dsdt.aml", "DSDT", 2, "Intel", "Template", 0x00000001) { /* Comment for MAIN method */ Method (MAIN, 0, NotSerialized) { Return (Zero) } } C:\Acpi\listing>iasl -l -Pn dsdt.asl Intel ACPI Component Architecture ASL Optimizing Compiler version 20120711-32 [Jul 30 2012] Copyright (c) 2000 - 2012 Intel Corporation ASL Input: dsdt.asl - 19 lines, 377 bytes, 2 keywords AML Output: dsdt.aml - 45 bytes, 1 named objects, 1 executable opcodes Listing File: dsdt.lst - 1536 bytes Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 0 Optimizations dsdt.lst -------- Intel ACPI Component Architecture ASL Optimizing Compiler version 20120711-32 [Jul 30 2012] Copyright (c) 2000 - 2012 Intel Corporation Compilation of "dsdt.asl" - Mon Jul 30 12:37:36 2012 1..../* 2.... * Intel ACPI Component Architecture 3.... * iASL Compiler/Disassembler version 20120711-32 [Jul 19 2012] 4.... * Copyright (c) 2000 - 2012 Intel Corporation 5.... * 6.... * Template for [DSDT] ACPI Table 7.... */ 8.... 9....DefinitionBlock ("dsdt.aml", "DSDT", 2, "Intel", "Template", 0x00000001) 00000000....44 53 44 54 2D 00 00 00 "DSDT-..." 00000008....02 03 49 6E 74 65 6C 00 "..Intel." 00000010....54 65 6D 70 6C 61 74 65 "Template" 00000018....01 00 00 00 49 4E 54 4C "....INTL" 00000020....11 07 12 20 ............ "... " 10....{ 11.... /* Comment for MAIN method */ 12.... 13.... Method (MAIN, 0, NotSerialized) 00000024....14 08 4D 41 49 4E 00 ... "..MAIN." 14.... { 15.... Return (Zero) 0000002B....A4 00 .................. ".." 16.... } 17....} 18.... 19.... > -----Original Message----- > From: Moore, Robert > Sent: Monday, July 30, 2012 10:57 AM > To: 'Idwer Vollering' > Cc: Michael S. Tsirkin; Kevin O'Connor; seabios(a)seabios.org > Subject: RE: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with > its ACPI code > > OK, I will take a look at it. > > Are all the comments throughout the code stripped from the listing? > > > -----Original Message----- > > From: Idwer Vollering [mailto:vidwer@gmail.com] > > Sent: Monday, July 30, 2012 10:35 AM > > To: Moore, Robert > > Cc: Michael S. Tsirkin; Kevin O'Connor; seabios(a)seabios.org > > Subject: Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems > > with its ACPI code > > > > 2012/7/30 Moore, Robert <robert.moore(a)intel.com>: > > > We have made some fixes regarding listing support in conjunction > > > with > > the new preprocessor. > > > > > > Please try the very latest iASL compiler, version 20120711. > > > > > > Thanks, > > > Bob > > > > Actually I have tried acpica-unix-20120711 (and acpica-unix-20120320, > > acpica-unix-20120420, acpica-unix-20120518, acpica-unix-20120620). > > The last version of iASL that worked (for me) with SeaBIOS is acpica- > > unix-20120215. > > > > Idwer

1 0

Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with its ACPI code
by Moore, Robert July 30, 2012

July 30, 2012

OK, I will take a look at it. Are all the comments throughout the code stripped from the listing? > -----Original Message----- > From: Idwer Vollering [mailto:vidwer@gmail.com] > Sent: Monday, July 30, 2012 10:35 AM > To: Moore, Robert > Cc: Michael S. Tsirkin; Kevin O'Connor; seabios(a)seabios.org > Subject: Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with > its ACPI code > > 2012/7/30 Moore, Robert <robert.moore(a)intel.com>: > > We have made some fixes regarding listing support in conjunction with > the new preprocessor. > > > > Please try the very latest iASL compiler, version 20120711. > > > > Thanks, > > Bob > > Actually I have tried acpica-unix-20120711 (and acpica-unix-20120320, > acpica-unix-20120420, acpica-unix-20120518, acpica-unix-20120620). > The last version of iASL that worked (for me) with SeaBIOS is acpica- > unix-20120215. > > Idwer

1 0

Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with its ACPI code
by Idwer Vollering July 30, 2012

July 30, 2012

2012/7/30 Moore, Robert <robert.moore(a)intel.com>: > We have made some fixes regarding listing support in conjunction with the new preprocessor. > > Please try the very latest iASL compiler, version 20120711. > > Thanks, > Bob Actually I have tried acpica-unix-20120711 (and acpica-unix-20120320, acpica-unix-20120420, acpica-unix-20120518, acpica-unix-20120620). The last version of iASL that worked (for me) with SeaBIOS is acpica-unix-20120215. Idwer

1 0

Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with its ACPI code
by Kevin O'Connor July 30, 2012

July 30, 2012

On Thu, Jul 26, 2012 at 03:56:50PM +0200, Idwer Vollering wrote: > 2012/7/26 Kevin O'Connor <kevin(a)koconnor.net>: > > This is typically due to oddities with the compiler. What version of > > compiler and binutils do you have? Can you tar up the "out/" > > directory and email it to me? > > http://ra.openbios.org/~idwer/seabios_out.tar The SeaBIOS acpi_extract.py build tool is relying on the acpi output including the comments from the source acpi file. It looks like the latest acpi compiler versions are stripping the comments out. You'll have to use an older version of the iasl compiler until we can update the SeaBIOS build. -Kevin

3 2