2012/7/31 Moore, Robert <robert.moore(a)intel.com>:
> On Debian, we are using
>
> Flex 2.5.35
> Bison 2.4.1
My build machine runs 64-bit archlinux and has gcc 4.7.1, flex 2.5.36
and bison 2.6 installed.
P.S. please use reply-to-all, so everyone is informed.
Adding some details.
2012/7/31 Moore, Robert <robert.moore(a)intel.com>:
> Please let me know if the -Pn option works for you.
> Thanks,
> Bob
-Pn works for me, with acpica-20120420-64 and with acpica-unix-20120711.
acpica-unix-20120711 needs this patch, for gcc 4.7.1:
diff -ur acpica-unix-20120711/source/compiler/Makefile
acpica-unix-20120711-patched/source/compiler/Makefile
--- acpica-unix-20120711/source/compiler/Makefile 2012-07-11
17:55:10.000000000 +0200
+++ acpica-unix-20120711-patched/source/compiler/Makefile
2012-07-31 19:50:59.077389584 +0200
@@ -270,7 +270,6 @@
-Wnested-externs \
-Wold-style-declaration \
-Wold-style-definition \
- -Wredundant-decls \
-Wtype-limits
#
2012/7/31 Moore, Robert <robert.moore(a)intel.com>:
> Please let me know if the -Pn option works for you.
> Thanks,
> Bob
-Pn works for me, on acpica-20120420-64.
acpica-unix-20120711 needs this patch, for gcc 4.7.1:
diff -ur acpica-unix-20120711/source/compiler/Makefile
acpica-unix-20120711-patched/source/compiler/Makefile
--- acpica-unix-20120711/source/compiler/Makefile 2012-07-11
17:55:10.000000000 +0200
+++ acpica-unix-20120711-patched/source/compiler/Makefile
2012-07-31 19:50:59.077389584 +0200
@@ -270,7 +270,6 @@
-Wnested-externs \
-Wold-style-declaration \
-Wold-style-definition \
- -Wredundant-decls \
-Wtype-limits
#
Please let me know if the -Pn option works for you.
Thanks,
Bob
> -----Original Message-----
> From: Moore, Robert
> Sent: Monday, July 30, 2012 12:43 PM
> To: Idwer Vollering
> Cc: Michael S. Tsirkin; Kevin O'Connor; seabios(a)seabios.org; Tang, Feng
> Subject: RE: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with
> its ACPI code
>
> Yes, you are correct, the listing no longer includes the comments.
>
> Sorry for causing you a problem.
>
> What is happening is that the preprocessor parser is stripping the
> comments during the creation of the .i file. Then, the compiler is
> invoked on the .i file -- thus, the comments are gone.
>
> This is going to take a bit of work to correct, but we will do it.
>
> In the meantime, try using the -Pn flag to disable the preprocessor.
> When this flag is set, the preprocessor is completely bypassed and the
> compiler should function as it did previously.
>
> Example below:
>
>
> /*
> * Intel ACPI Component Architecture
> * iASL Compiler/Disassembler version 20120711-32 [Jul 30 2012]
> * Copyright (c) 2000 - 2012 Intel Corporation
> *
> * Template for [DSDT] ACPI Table
> */
>
> DefinitionBlock ("dsdt.aml", "DSDT", 2, "Intel", "Template",
> 0x00000001) {
> /* Comment for MAIN method */
>
> Method (MAIN, 0, NotSerialized)
> {
> Return (Zero)
> }
> }
>
>
> C:\Acpi\listing>iasl -l -Pn dsdt.asl
>
> Intel ACPI Component Architecture
> ASL Optimizing Compiler version 20120711-32 [Jul 30 2012] Copyright (c)
> 2000 - 2012 Intel Corporation
>
> ASL Input: dsdt.asl - 19 lines, 377 bytes, 2 keywords
> AML Output: dsdt.aml - 45 bytes, 1 named objects, 1 executable
> opcodes
> Listing File: dsdt.lst - 1536 bytes
>
> Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 0 Optimizations
>
>
> dsdt.lst
> --------
>
> Intel ACPI Component Architecture
> ASL Optimizing Compiler version 20120711-32 [Jul 30 2012] Copyright (c)
> 2000 - 2012 Intel Corporation
>
> Compilation of "dsdt.asl" - Mon Jul 30 12:37:36 2012
>
> 1..../*
> 2.... * Intel ACPI Component Architecture
> 3.... * iASL Compiler/Disassembler version 20120711-32 [Jul 19
> 2012]
> 4.... * Copyright (c) 2000 - 2012 Intel Corporation
> 5.... *
> 6.... * Template for [DSDT] ACPI Table
> 7.... */
> 8....
> 9....DefinitionBlock ("dsdt.aml", "DSDT", 2, "Intel",
> "Template", 0x00000001)
>
> 00000000....44 53 44 54 2D 00 00 00 "DSDT-..."
> 00000008....02 03 49 6E 74 65 6C 00 "..Intel."
> 00000010....54 65 6D 70 6C 61 74 65 "Template"
> 00000018....01 00 00 00 49 4E 54 4C "....INTL"
> 00000020....11 07 12 20 ............ "... "
>
> 10....{
> 11.... /* Comment for MAIN method */
> 12....
> 13.... Method (MAIN, 0, NotSerialized)
>
> 00000024....14 08 4D 41 49 4E 00 ... "..MAIN."
>
> 14.... {
> 15.... Return (Zero)
>
> 0000002B....A4 00 .................. ".."
> 16.... }
> 17....}
> 18....
> 19....
>
>
>
>
>
> > -----Original Message-----
> > From: Moore, Robert
> > Sent: Monday, July 30, 2012 10:57 AM
> > To: 'Idwer Vollering'
> > Cc: Michael S. Tsirkin; Kevin O'Connor; seabios(a)seabios.org
> > Subject: RE: [SeaBIOS] Compiling SeaBIOS for coreboot has problems
> > with its ACPI code
> >
> > OK, I will take a look at it.
> >
> > Are all the comments throughout the code stripped from the listing?
> >
> > > -----Original Message-----
> > > From: Idwer Vollering [mailto:vidwer@gmail.com]
> > > Sent: Monday, July 30, 2012 10:35 AM
> > > To: Moore, Robert
> > > Cc: Michael S. Tsirkin; Kevin O'Connor; seabios(a)seabios.org
> > > Subject: Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems
> > > with its ACPI code
> > >
> > > 2012/7/30 Moore, Robert <robert.moore(a)intel.com>:
> > > > We have made some fixes regarding listing support in conjunction
> > > > with
> > > the new preprocessor.
> > > >
> > > > Please try the very latest iASL compiler, version 20120711.
> > > >
> > > > Thanks,
> > > > Bob
> > >
> > > Actually I have tried acpica-unix-20120711 (and
> > > acpica-unix-20120320, acpica-unix-20120420, acpica-unix-20120518,
> acpica-unix-20120620).
> > > The last version of iASL that worked (for me) with SeaBIOS is
> > > acpica- unix-20120215.
> > >
> > > Idwer
Yes, you are correct, the listing no longer includes the comments.
Sorry for causing you a problem.
What is happening is that the preprocessor parser is stripping the comments during the creation of the .i file. Then, the compiler is invoked on the .i file -- thus, the comments are gone.
This is going to take a bit of work to correct, but we will do it.
In the meantime, try using the -Pn flag to disable the preprocessor. When this flag is set, the preprocessor is completely bypassed and the compiler should function as it did previously.
Example below:
/*
* Intel ACPI Component Architecture
* iASL Compiler/Disassembler version 20120711-32 [Jul 30 2012]
* Copyright (c) 2000 - 2012 Intel Corporation
*
* Template for [DSDT] ACPI Table
*/
DefinitionBlock ("dsdt.aml", "DSDT", 2, "Intel", "Template", 0x00000001)
{
/* Comment for MAIN method */
Method (MAIN, 0, NotSerialized)
{
Return (Zero)
}
}
C:\Acpi\listing>iasl -l -Pn dsdt.asl
Intel ACPI Component Architecture
ASL Optimizing Compiler version 20120711-32 [Jul 30 2012]
Copyright (c) 2000 - 2012 Intel Corporation
ASL Input: dsdt.asl - 19 lines, 377 bytes, 2 keywords
AML Output: dsdt.aml - 45 bytes, 1 named objects, 1 executable opcodes
Listing File: dsdt.lst - 1536 bytes
Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 0 Optimizations
dsdt.lst
--------
Intel ACPI Component Architecture
ASL Optimizing Compiler version 20120711-32 [Jul 30 2012]
Copyright (c) 2000 - 2012 Intel Corporation
Compilation of "dsdt.asl" - Mon Jul 30 12:37:36 2012
1..../*
2.... * Intel ACPI Component Architecture
3.... * iASL Compiler/Disassembler version 20120711-32 [Jul 19 2012]
4.... * Copyright (c) 2000 - 2012 Intel Corporation
5.... *
6.... * Template for [DSDT] ACPI Table
7.... */
8....
9....DefinitionBlock ("dsdt.aml", "DSDT", 2, "Intel", "Template", 0x00000001)
00000000....44 53 44 54 2D 00 00 00 "DSDT-..."
00000008....02 03 49 6E 74 65 6C 00 "..Intel."
00000010....54 65 6D 70 6C 61 74 65 "Template"
00000018....01 00 00 00 49 4E 54 4C "....INTL"
00000020....11 07 12 20 ............ "... "
10....{
11.... /* Comment for MAIN method */
12....
13.... Method (MAIN, 0, NotSerialized)
00000024....14 08 4D 41 49 4E 00 ... "..MAIN."
14.... {
15.... Return (Zero)
0000002B....A4 00 .................. ".."
16.... }
17....}
18....
19....
> -----Original Message-----
> From: Moore, Robert
> Sent: Monday, July 30, 2012 10:57 AM
> To: 'Idwer Vollering'
> Cc: Michael S. Tsirkin; Kevin O'Connor; seabios(a)seabios.org
> Subject: RE: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with
> its ACPI code
>
> OK, I will take a look at it.
>
> Are all the comments throughout the code stripped from the listing?
>
> > -----Original Message-----
> > From: Idwer Vollering [mailto:vidwer@gmail.com]
> > Sent: Monday, July 30, 2012 10:35 AM
> > To: Moore, Robert
> > Cc: Michael S. Tsirkin; Kevin O'Connor; seabios(a)seabios.org
> > Subject: Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems
> > with its ACPI code
> >
> > 2012/7/30 Moore, Robert <robert.moore(a)intel.com>:
> > > We have made some fixes regarding listing support in conjunction
> > > with
> > the new preprocessor.
> > >
> > > Please try the very latest iASL compiler, version 20120711.
> > >
> > > Thanks,
> > > Bob
> >
> > Actually I have tried acpica-unix-20120711 (and acpica-unix-20120320,
> > acpica-unix-20120420, acpica-unix-20120518, acpica-unix-20120620).
> > The last version of iASL that worked (for me) with SeaBIOS is acpica-
> > unix-20120215.
> >
> > Idwer
OK, I will take a look at it.
Are all the comments throughout the code stripped from the listing?
> -----Original Message-----
> From: Idwer Vollering [mailto:vidwer@gmail.com]
> Sent: Monday, July 30, 2012 10:35 AM
> To: Moore, Robert
> Cc: Michael S. Tsirkin; Kevin O'Connor; seabios(a)seabios.org
> Subject: Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with
> its ACPI code
>
> 2012/7/30 Moore, Robert <robert.moore(a)intel.com>:
> > We have made some fixes regarding listing support in conjunction with
> the new preprocessor.
> >
> > Please try the very latest iASL compiler, version 20120711.
> >
> > Thanks,
> > Bob
>
> Actually I have tried acpica-unix-20120711 (and acpica-unix-20120320,
> acpica-unix-20120420, acpica-unix-20120518, acpica-unix-20120620).
> The last version of iASL that worked (for me) with SeaBIOS is acpica-
> unix-20120215.
>
> Idwer
2012/7/30 Moore, Robert <robert.moore(a)intel.com>:
> We have made some fixes regarding listing support in conjunction with the new preprocessor.
>
> Please try the very latest iASL compiler, version 20120711.
>
> Thanks,
> Bob
Actually I have tried acpica-unix-20120711 (and acpica-unix-20120320,
acpica-unix-20120420, acpica-unix-20120518, acpica-unix-20120620).
The last version of iASL that worked (for me) with SeaBIOS is
acpica-unix-20120215.
Idwer
On Thu, Jul 26, 2012 at 03:56:50PM +0200, Idwer Vollering wrote:
> 2012/7/26 Kevin O'Connor <kevin(a)koconnor.net>:
> > This is typically due to oddities with the compiler. What version of
> > compiler and binutils do you have? Can you tar up the "out/"
> > directory and email it to me?
>
> http://ra.openbios.org/~idwer/seabios_out.tar
The SeaBIOS acpi_extract.py build tool is relying on the acpi output
including the comments from the source acpi file. It looks like the
latest acpi compiler versions are stripping the comments out.
You'll have to use an older version of the iasl compiler until we can
update the SeaBIOS build.
-Kevin