SeaBIOS July 2012

seabios@seabios.org

37 participants
119 discussions

Re: [SeaBIOS] [BUG] BSOD on Win2003 Server when 64bit PCI resource is present
by Paolo Bonzini 29 Jul '12

29 Jul '12

Il 26/07/2012 17:38, Alexey Korolev ha scritto: > If I add any DBUG call in acpi-dst it will cause BSOD on win2003 (win2008 works fine) You can try inlining it (in practice this means adding simple Store(0x41, DBGB) here and there). Paolo

1 0

Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with its ACPI code
by Kevin O'Connor 27 Jul '12

27 Jul '12

On Thu, Jul 26, 2012 at 03:54:59PM +0200, Idwer Vollering wrote: > 2012/7/26 Kevin O'Connor <kevin(a)koconnor.net>: > > I don't understand why you're changing the makefile. > > I was assuming the generation of out/ccode32flat.o.tmp.c was wrong, > which isn't wrong... > > $ LC_ALL=C LD=/home/idwer/coreboot/git/coreboot/util/crossgcc/xgcc/bin/i386-elf-ld > CC=/home/idwer/coreboot/git/coreboot/util/crossgcc/xgcc/bin/i386-elf-gcc > IASL=/home/idwer/coreboot/git/coreboot/util/crossgcc/xgcc/bin/iasl > make menuconfig V=1 I don't think you want to use that syntax for overriding variables - use: make CC=abc IASL=xyz LD=lmn [...] > /home/idwer/coreboot/git/seabios/tools/kconfig/conf.c:6:20: fatal > error: locale.h: No such file or directory > compilation terminated. > make[1]: *** [tools/kconfig/conf.o] Error 1 > make[1]: Leaving directory `/home/idwer/coreboot/git/seabios/out' > make: *** [menuconfig] Error 2 > > What's the right option to extend, COMMONCFLAGS or MAKEFLAGS? On my box it's /usr/include/locale.h - a glibc header. I don't know why that isn't being found. -Kevin

1 0

Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with its ACPI code
by Bruce Griffith 27 Jul '12

27 Jul '12

I am having similar problems using a locally built version of IASL from the 20120420-32 source. I can switch to a locally built version of the IASL compiler from the 20110623-32 source with no other changes and successfully build SeaBIOS. Note that I cannot build with IASL 20110623 binaries (Windows) from ACPICA, so there's something unique about our 20110623 build. ==== (-1): 20120711-32 (Windows using ACPICA binary) =========================== Compiling DSDT Intel ACPI Component Architecture ASL Optimizing Compiler version 20120711-32 [Jul 11 2012] Copyright (c) 2000 - 2012 Intel Corporation Error 4092 - Could not open file "ssdt-proc.dsl.i" (No such file or directory) Makefile:223: recipe for target `src/ssdt-proc.hex' failed make[2]: *** [src/ssdt-proc.hex] Error 1 make[2]: *** Waiting for unfinished jobs.... Intel ACPI Component Architecture ASL Optimizing Compiler version 20120711-32 [Jul 11 2012] Copyright (c) 2000 - 2012 Intel Corporation Error 4092 - Could not open file "acpi-dsdt.dsl.i" (No such file or directory) Makefile:223: recipe for target `src/acpi-dsdt.hex' failed make[2]: *** [src/acpi-dsdt.hex] Error 1 Intel ACPI Component Architecture ASL Optimizing Compiler version 20120711-32 [Jul 11 2012] Copyright (c) 2000 - 2012 Intel Corporation Error 4092 - Could not open file "ssdt-pcihp.dsl.i" (No such file or directory) Makefile:223: recipe for target `src/ssdt-pcihp.hex' failed make[2]: *** [src/ssdt-pcihp.hex] Error 1 make[2]: *** wait: No child processes. Stop. Makefile.inc:37: recipe for target `build' failed make[1]: *** [build] Error 2 src/arch/x86/Makefile.inc:362: recipe for target `seabios' failed make: *** [seabios] Error 2 ============================================================================ ==== ==== (-1): 20120420-32 (Windows) =============================================== Compiling DSDT Compiling DSDT make[3]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. Build Kconfig config file /cygdrive/c/xxxxxxx/build/seabios/.config:89:warning: override: reassigning to symbol COREBOOT /cygdrive/c/xxxxxxx/build/seabios/.config:90:warning: override: reassigning to symbol DEBUG_SERIAL /cygdrive/c/xxxxxxx/build/seabios/.config:95:warning: override: reassigning to symbol VGAHOOKS /cygdrive/c/xxxxxxx/build/seabios/.config:96:warning: override: reassigning to symbol DEBUG_LEVEL # # configuration written to /cygdrive/c/xxxxxxx/build/seabios/.config # Compiling DSDT Intel ACPI Component Architecture ASL Optimizing Compiler version 20120420-32 [May 27 2012] Copyright (c) 2000 - 2012 Intel Corporation ASL Input: /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-proc.dsl.i - 36 lines, 507 bytes, 8 keywords AML Output: /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-proc.aml - 120 bytes, 6 named objects, 2 executable opcodes Listing File: /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-proc.lst - 2635 bytes Hex Dump: /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-proc.hex - 1493 bytes Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 0 Optimizations Intel ACPI Component Architecture ASL Optimizing Compiler version 20120420-32 [May 27 2012] Copyright (c) 2000 - 2012 Intel Corporation /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 546: Return(0x01) Warning 1104 - Reserved method should not return a value ^ (_L00) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 549: Return(\_SB.PCI0.PCNF()) Warning 1104 - Reserved method should not return a value ^ (_E01) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 552: Return(\_SB.PRSC()) Warning 1104 - Reserved method should not return a value ^ (_E02) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 555: Return(0x01) Warning 1104 - Reserved method should not return a value ^ (_L03) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 558: Return(0x01) Warning 1104 - Reserved method should not return a value ^ (_L04) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 561: Return(0x01) Warning 1104 - Reserved method should not return a value ^ (_L05) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 564: Return(0x01) Warning 1104 - Reserved method should not return a value ^ (_L06) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 567: Return(0x01) Warning 1104 - Reserved method should not return a value ^ (_L07) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 570: Return(0x01) Warning 1104 - Reserved method should not return a value ^ (_L08) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 573: Return(0x01) Warning 1104 - Reserved method should not return a value ^ (_L09) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 576: Return(0x01) Warning 1104 - Reserved method should not return a value ^ (_L0A) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 579: Return(0x01) Warning 1104 - Reserved method should not return a value ^ (_L0B) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 582: Return(0x01) Warning 1104 - Reserved method should not return a value ^ (_L0C) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 585: Return(0x01) Warning 1104 - Reserved method should not return a value ^ (_L0D) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 588: Return(0x01) Warning 1104 - Reserved method should not return a value ^ (_L0E) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 591: Return(0x01) Warning 1104 - Reserved method should not return a value ^ (_L0F) ASL Input: /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i - 596 lines, 21480 bytes, 323 keywords AML Output: /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.aml - 4385 bytes, 156 named objects, 167 executable opcodes Listing File: /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.lst - 168353 bytes Hex Dump: /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.hex - 41545 bytes Compilation complete. 0 Errors, 16 Warnings, 0 Remarks, 254 Optimizations Compiling whole program /cygdrive/c/xxxxxxx/build/seabios/out/code32seg.o Intel ACPI Component Architecture ASL Optimizing Compiler version 20120420-32 [May 27 2012] Copyright (c) 2000 - 2012 Intel Corporation /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 21: Method (_EJ0, 1) { Return(PCEJ(0x01)) } Name (_SUN, 0x01) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 26: Method (_EJ0, 1) { Return(PCEJ(0x02)) } Name (_SUN, 0x02) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 31: Method (_EJ0, 1) { Return(PCEJ(0x03)) } Name (_SUN, 0x03) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 36: Method (_EJ0, 1) { Return(PCEJ(0x04)) } Name (_SUN, 0x04) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 41: Method (_EJ0, 1) { Return(PCEJ(0x05)) } Name (_SUN, 0x05) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 46: Method (_EJ0, 1) { Return(PCEJ(0x06)) } Name (_SUN, 0x06) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 51: Method (_EJ0, 1) { Return(PCEJ(0x07)) } Name (_SUN, 0x07) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 56: Method (_EJ0, 1) { Return(PCEJ(0x08)) } Name (_SUN, 0x08) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 61: Method (_EJ0, 1) { Return(PCEJ(0x09)) } Name (_SUN, 0x09) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 66: Method (_EJ0, 1) { Return(PCEJ(0x0a)) } Name (_SUN, 0x0a) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 71: Method (_EJ0, 1) { Return(PCEJ(0x0b)) } Name (_SUN, 0x0b) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 76: Method (_EJ0, 1) { Return(PCEJ(0x0c)) } Name (_SUN, 0x0c) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 81: Method (_EJ0, 1) { Return(PCEJ(0x0d)) } Name (_SUN, 0x0d) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 86: Method (_EJ0, 1) { Return(PCEJ(0x0e)) } Name (_SUN, 0x0e) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 91: Method (_EJ0, 1) { Return(PCEJ(0x0f)) } Name (_SUN, 0x0f) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 96: Method (_EJ0, 1) { Return(PCEJ(0x10)) } Name (_SUN, 0x10) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 101: Method (_EJ0, 1) { Return(PCEJ(0x11)) } Name (_SUN, 0x11) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 106: Method (_EJ0, 1) { Return(PCEJ(0x12)) } Name (_SUN, 0x12) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 111: Method (_EJ0, 1) { Return(PCEJ(0x13)) } Name (_SUN, 0x13) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 116: Method (_EJ0, 1) { Return(PCEJ(0x14)) } Name (_SUN, 0x14) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 121: Method (_EJ0, 1) { Return(PCEJ(0x15)) } Name (_SUN, 0x15) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 126: Method (_EJ0, 1) { Return(PCEJ(0x16)) } Name (_SUN, 0x16) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 131: Method (_EJ0, 1) { Return(PCEJ(0x17)) } Name (_SUN, 0x17) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 136: Method (_EJ0, 1) { Return(PCEJ(0x18)) } Name (_SUN, 0x18) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 141: Method (_EJ0, 1) { Return(PCEJ(0x19)) } Name (_SUN, 0x19) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 146: Method (_EJ0, 1) { Return(PCEJ(0x1a)) } Name (_SUN, 0x1a) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 151: Method (_EJ0, 1) { Return(PCEJ(0x1b)) } Name (_SUN, 0x1b) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 156: Method (_EJ0, 1) { Return(PCEJ(0x1c)) } Name (_SUN, 0x1c) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 161: Method (_EJ0, 1) { Return(PCEJ(0x1d)) } Name (_SUN, 0x1d) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 166: Method (_EJ0, 1) { Return(PCEJ(0x1e)) } Name (_SUN, 0x1e) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 171: Method (_EJ0, 1) { Return(PCEJ(0x1f)) } Name (_SUN, 0x1f) } Warning 1104 - Reserved method should not return a value ^ (_EJ0) ASL Input: /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i - 208 lines, 5688 bytes, 250 keywords AML Output: /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.aml - 1604 bytes, 126 named objects, 124 executable opcodes Listing File: /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.lst - 42970 bytes Hex Dump: /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.hex - 15445 bytes Compilation complete. 0 Errors, 31 Warnings, 0 Remarks, 3 Optimizations Compiling whole program /cygdrive/c/xxxxxxx/build/seabios/out/ccode16.o Compiling to assembler /cygdrive/c/xxxxxxx/build/seabios/out/asm-offsets.s Compiling whole program /cygdrive/c/xxxxxxx/build/seabios/out/ccode32flat.o Generating offset file /cygdrive/c/xxxxxxx/build/seabios/out/asm-offsets.h In file included from /cygdrive/c/xxxxxxx/build/seabios/out/ccode32flat.o.tmp.c:42:0: /cygdrive/c/xxxxxxx/build/seabios/out/../src/acpi.c: In function 'build_ssdt': /cygdrive/c/xxxxxxx/build/seabios/out/../src/acpi.c:416:34: error: 'ssdt_proc_end' undeclared (first use in this function) /cygdrive/c/xxxxxxx/build/seabios/out/../src/acpi.c:416:34: note: each undeclared identifier is reported only once for each function it appears in /cygdrive/c/xxxxxxx/build/seabios/out/../src/acpi.c:416:34: error: 'ssdt_proc_start' undeclared (first use in this function) /cygdrive/c/xxxxxxx/build/seabios/out/../src/acpi.c:437:26: error: 'ssdp_proc_aml' undeclared (first use in this function) /cygdrive/c/xxxxxxx/build/seabios/out/../src/acpi.c:438:18: error: 'ssdt_proc_name' undeclared (first use in this function) /cygdrive/c/xxxxxxx/build/seabios/out/../src/acpi.c:441:18: error: 'ssdt_proc_id' undeclared (first use in this function) In file included from /cygdrive/c/xxxxxxx/build/seabios/out/ccode32flat.o.tmp.c:42:0: /cygdrive/c/xxxxxxx/build/seabios/out/../src/acpi.c: In function 'build_pcihp': /cygdrive/c/xxxxxxx/build/seabios/out/../src/acpi.c:498:35: error: 'ssdp_pcihp_aml' undeclared (first use in this function) /cygdrive/c/xxxxxxx/build/seabios/out/../src/acpi.c:507:9: error: 'aml_ej0_name' undeclared (first use in this function) /cygdrive/c/xxxxxxx/build/seabios/out/../src/acpi.c:507:37: error: 'aml_adr_dword' undeclared (first use in this function) /cygdrive/c/xxxxxxx/build/seabios/out/../src/acpi.c: In function 'acpi_bios_init': /cygdrive/c/xxxxxxx/build/seabios/out/../src/acpi.c:737:41: error: 'AmlCode' undeclared (first use in this function) Makefile:143: recipe for target `/cygdrive/c/xxxxxxx/build/seabios/out/ccode32flat.o' failed make[2]: *** [/cygdrive/c/xxxxxxx/build/seabios/out/ccode32flat.o] Error 1 Makefile.inc:37: recipe for target `build' failed make[1]: *** [build] Error 2 src/arch/x86/Makefile.inc:362: recipe for target `seabios' failed make: *** [seabios] Error 2=========================================================================== ===== ==== (+1): 20110623-32 (Windows) =============================================== Compiling DSDT Intel ACPI Component Architecture ASL Optimizing Compiler version 20110623-32 [May 7 2012] Copyright (c) 2000 - 2011 Intel Corporation ASL Input: /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-proc.dsl.i - 36 lines, 765 bytes, 8 keywords AML Output: /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-proc.aml - 120 bytes, 6 named objects, 2 executable opcodes Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 0 Optimizations Intel ACPI Component Architecture ASL Optimizing Compiler version 20110623-32 [May 7 2012] Copyright (c) 2000 - 2011 Intel Corporation /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 546: Return(0x01) Warning 1128 - Reserved method should not return a value ^ (_L00) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 549: Return(\_SB.PCI0.PCNF()) Warning 1128 - Reserved method should not return a value ^ (_E01) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 552: Return(\_SB.PRSC()) Warning 1128 - Reserved method should not return a value ^ (_E02) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 555: Return(0x01) Warning 1128 - Reserved method should not return a value ^ (_L03) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 558: Return(0x01) Warning 1128 - Reserved method should not return a value ^ (_L04) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 561: Return(0x01) Warning 1128 - Reserved method should not return a value ^ (_L05) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 564: Return(0x01) Warning 1128 - Reserved method should not return a value ^ (_L06) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 567: Return(0x01) Warning 1128 - Reserved method should not return a value ^ (_L07) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 570: Return(0x01) Warning 1128 - Reserved method should not return a value ^ (_L08) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 573: Return(0x01) Warning 1128 - Reserved method should not return a value ^ (_L09) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 576: Return(0x01) Warning 1128 - Reserved method should not return a value ^ (_L0A) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 579: Return(0x01) Warning 1128 - Reserved method should not return a value ^ (_L0B) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 582: Return(0x01) Warning 1128 - Reserved method should not return a value ^ (_L0C) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 585: Return(0x01) Warning 1128 - Reserved method should not return a value ^ (_L0D) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 588: Return(0x01) Warning 1128 - Reserved method should not return a value ^ (_L0E) /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i 591: Return(0x01) Warning 1128 - Reserved method should not return a value ^ (_L0F) ASL Input: /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.dsl.i - 596 lines, 21515 bytes, 323 keywords AML Output: /cygdrive/c/xxxxxxx/build/seabios/out/acpi-dsdt.aml - 4385 bytes, 156 named objects, 167 executable opcodes Compilation complete. 0 Errors, 16 Warnings, 0 Remarks, 254 Optimizations Compiling whole program /cygdrive/c/xxxxxxx/build/seabios/out/code32seg.o Intel ACPI Component Architecture ASL Optimizing Compiler version 20110623-32 [May 7 2012] Copyright (c) 2000 - 2011 Intel Corporation /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 21: Method (_EJ0, 1) { Return(PCEJ(0x01)) } Name (_SUN, 0x01) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 26: Method (_EJ0, 1) { Return(PCEJ(0x02)) } Name (_SUN, 0x02) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 31: Method (_EJ0, 1) { Return(PCEJ(0x03)) } Name (_SUN, 0x03) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 36: Method (_EJ0, 1) { Return(PCEJ(0x04)) } Name (_SUN, 0x04) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 41: Method (_EJ0, 1) { Return(PCEJ(0x05)) } Name (_SUN, 0x05) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 46: Method (_EJ0, 1) { Return(PCEJ(0x06)) } Name (_SUN, 0x06) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 51: Method (_EJ0, 1) { Return(PCEJ(0x07)) } Name (_SUN, 0x07) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 56: Method (_EJ0, 1) { Return(PCEJ(0x08)) } Name (_SUN, 0x08) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 61: Method (_EJ0, 1) { Return(PCEJ(0x09)) } Name (_SUN, 0x09) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 66: Method (_EJ0, 1) { Return(PCEJ(0x0a)) } Name (_SUN, 0x0a) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 71: Method (_EJ0, 1) { Return(PCEJ(0x0b)) } Name (_SUN, 0x0b) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 76: Method (_EJ0, 1) { Return(PCEJ(0x0c)) } Name (_SUN, 0x0c) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 81: Method (_EJ0, 1) { Return(PCEJ(0x0d)) } Name (_SUN, 0x0d) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 86: Method (_EJ0, 1) { Return(PCEJ(0x0e)) } Name (_SUN, 0x0e) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 91: Method (_EJ0, 1) { Return(PCEJ(0x0f)) } Name (_SUN, 0x0f) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 96: Method (_EJ0, 1) { Return(PCEJ(0x10)) } Name (_SUN, 0x10) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 101: Method (_EJ0, 1) { Return(PCEJ(0x11)) } Name (_SUN, 0x11) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 106: Method (_EJ0, 1) { Return(PCEJ(0x12)) } Name (_SUN, 0x12) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 111: Method (_EJ0, 1) { Return(PCEJ(0x13)) } Name (_SUN, 0x13) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 116: Method (_EJ0, 1) { Return(PCEJ(0x14)) } Name (_SUN, 0x14) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 121: Method (_EJ0, 1) { Return(PCEJ(0x15)) } Name (_SUN, 0x15) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 126: Method (_EJ0, 1) { Return(PCEJ(0x16)) } Name (_SUN, 0x16) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 131: Method (_EJ0, 1) { Return(PCEJ(0x17)) } Name (_SUN, 0x17) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 136: Method (_EJ0, 1) { Return(PCEJ(0x18)) } Name (_SUN, 0x18) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 141: Method (_EJ0, 1) { Return(PCEJ(0x19)) } Name (_SUN, 0x19) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 146: Method (_EJ0, 1) { Return(PCEJ(0x1a)) } Name (_SUN, 0x1a) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 151: Method (_EJ0, 1) { Return(PCEJ(0x1b)) } Name (_SUN, 0x1b) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 156: Method (_EJ0, 1) { Return(PCEJ(0x1c)) } Name (_SUN, 0x1c) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 161: Method (_EJ0, 1) { Return(PCEJ(0x1d)) } Name (_SUN, 0x1d) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 166: Method (_EJ0, 1) { Return(PCEJ(0x1e)) } Name (_SUN, 0x1e) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i 171: Method (_EJ0, 1) { Return(PCEJ(0x1f)) } Name (_SUN, 0x1f) } Warning 1128 - Reserved method should not return a value ^ (_EJ0) ASL Input: /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.dsl.i - 208 lines, 8429 bytes, 250 keywords AML Output: /cygdrive/c/xxxxxxx/build/seabios/out/ssdt-pcihp.aml - 1604 bytes, 126 named objects, 124 executable opcodes Compilation complete. 0 Errors, 31 Warnings, 0 Remarks, 3 Optimizations ============================================================================ ====

1 0

Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with its ACPI code
by Kevin O'Connor 26 Jul '12

26 Jul '12

On Thu, Jul 26, 2012 at 11:25:51AM +0200, Idwer Vollering wrote: > 2012/7/26 Kevin O'Connor <kevin(a)koconnor.net>: > > On Wed, Jul 25, 2012 at 02:45:31PM +0200, Idwer Vollering wrote: > >> 2012/7/25 Kevin O'Connor <kevin(a)koconnor.net>: > >> > On Wed, Jul 25, 2012 at 01:44:20PM +0200, Idwer Vollering wrote: > >> >> Unmodified tree, at 9d6bac1d32b72cdf7c0ad009c1371a2e69084de3 > >> > > >> > At a guess, the iasl warnings are confusing the > >> > acpi_extract_preprocess.py script. What version of iasl do you have? > >> > >> The distribution version is iasl 20120620-1: ASL Optimizing Compiler > >> version 20120620-64 [Jun 24 2012] > >> coreboot build: ASL Optimizing Compiler version 20120420-64 [Jul 13 2012] > > > > Does the patch below fix this for you? > > Unfortunately it doesn't fix this, I just tested a 'regular' compile > (make menuconfig and exit without changing any option) which seems to > stop with the same errors. > > With this patch (and reverting the change to src/acpi-dsdt.dsl) I see > some progress (see below for the resulting output of make): > > diff --git a/Makefile b/Makefile > index dfdec5c..b55705b 100644 > --- a/Makefile > +++ b/Makefile > @@ -97,7 +97,7 @@ ifeq "$(COMPSTRAT)" "1" > # First method - use -fwhole-program without -combine. > define whole-compile > @echo " Compiling whole program $3" > -$(Q)printf '$(foreach i,$2,#include "../$i"\n)' > $3.tmp.c > +$(Q)printf '$(foreach i,$2,#include "../$i")\n' >> $3.tmp.c > $(Q)$(CC) $1 -fwhole-program -DWHOLE_PROGRAM -c $3.tmp.c -o $3 > endef I don't understand why you're changing the makefile. [...] > Linking out/rom16.o > ld -T out/romlayout16.lds out/code16.o -o out/rom16.o > out/code16.o: In function `handle_12': > /home/idwer/coreboot/git/seabios/out/../src/misc.c:29: undefined > reference to `__debug_enter' This is typically due to oddities with the compiler. What version of compiler and binutils do you have? Can you tar up the "out/" directory and email it to me? -Kevin

2 3

[SeaBIOS PATCH 0/2] Allow non-contiguous APIC IDs (v2)
by Eduardo Habkost 26 Jul '12

26 Jul '12

Small changes from the previous series: - Patch 1/2: cosmetic whitespace change - Patch 2/2: use size suffixes on asm instructions on smp.c - New patch descriptions Eduardo Habkost (2): acpi: report real I/O APIC ID (0) on MADT table allow CPUs to have non-contiguous Local APIC IDs (v2) src/acpi-dsdt.dsl | 4 +++- src/acpi.c | 11 ++++++----- src/config.h | 1 + src/mptable.c | 2 +- src/smp.c | 17 +++++++++++++++++ src/util.h | 1 + 6 files changed, 29 insertions(+), 7 deletions(-) -- 1.7.10.4

3 12

[BUG] BSOD on Win2003 Server when 64bit PCI resource is present
by Alexey Korolev 26 Jul '12

26 Jul '12

HI, Current version of Seabios is causing blue screen on Windows2003 when 64bit PCI resource is present and occupies high memory. BSOD Error code is: 0x000000A5 (0x02, 0xFFFFfADF6A446880, 0x1, 0xFFFFFADFAA34690) The issue is localized, it is related to presence of 64bit resource in _CRS method. If we disable a 64bit region from _CRS the Win2003 load normally but this doesn't allow Windows to use 64bit resources. At the moment I have no idea how to fix this. Please help! P/S Yet another issue is related to debug messages. If I add any DBUG call in acpi-dst it will cause BSOD on win2003 (win2008 works fine)

1 0

ISA device and shared memory
by Albin Kauffmann 26 Jul '12

26 Jul '12

Hello, I'm trying to add the support for an old com90c65 ISA card (a network device using the old ARCnet protocol and handled by the com90xx Linux module). This device is using both IO ports and IO memory. The I/O ports are working and the code is largely inspired from the ne2k_isa support. However, I have not find the right way to register the I/O memory. I've tried the following code : static const MemoryRegionOps com90c65_mmio_ops = { .read = com90c65_mmio_read, .write = com90c65_mmio_write, .endianness = DEVICE_NATIVE_ENDIAN, }; [...] memory_region_init_io(&s->mmio, &com90c65_mmio_ops, s, "com90c65-mmio", size); memory_region_add_subregion(isa_address_space(dev), isa_mem_base + isa->mmiobase, &s->mmio); Depending on mmiobase, I get : - mmiobase == 0xd0000 : no error message but debuging QEMU shows me that my read/write functions are not called. - mmiobase == 0xd0800 : the following error : qemu-system-i386: [...]/qemu-1.1.0/exec.c:2371: register_subpage: Assertion `existing->mr->subpage || existing->mr == &io_mem_unassigned' failed Because the ISA and PCI memory areas seem to overlap and as the ISA bus is accessed via a PCI to ISA bridge, they might be something else to initialize but I can't find what and browsing the QEMU code didn't help me. However, I have managed to make it work by using a call to memory_region_add_subregion_overlap() with a priority bigger than the PCI one (priority >= 2) but it only works with mmiobase == 0xd0000. As it might also be a seabios configuration problem, I have added the seabios mailing list in the recipients. In attachement, you'll find the output of info mtree, info qtree and the logs of seabios. Any help will be really appreciated, Thanks :) -- Albin Kauffmann

1 0

Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with its ACPI code
by Kevin O'Connor 26 Jul '12

26 Jul '12

On Wed, Jul 25, 2012 at 02:45:31PM +0200, Idwer Vollering wrote: > 2012/7/25 Kevin O'Connor <kevin(a)koconnor.net>: > > On Wed, Jul 25, 2012 at 01:44:20PM +0200, Idwer Vollering wrote: > >> Unmodified tree, at 9d6bac1d32b72cdf7c0ad009c1371a2e69084de3 > > > > At a guess, the iasl warnings are confusing the > > acpi_extract_preprocess.py script. What version of iasl do you have? > > The distribution version is iasl 20120620-1: ASL Optimizing Compiler > version 20120620-64 [Jun 24 2012] > coreboot build: ASL Optimizing Compiler version 20120420-64 [Jul 13 2012] Does the patch below fix this for you? -Kevin diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 2060686..f45162c 100644 --- a/src/acpi-dsdt.dsl +++ b/src/acpi-dsdt.dsl @@ -556,7 +556,6 @@ DefinitionBlock ( PCNT(Local0, 3) } } - Return(One) } } @@ -735,7 +734,6 @@ DefinitionBlock ( } Increment(Local0) } - Return(One) } } @@ -749,54 +747,40 @@ DefinitionBlock ( Name(_HID, "ACPI0006") Method(_L00) { - Return(0x01) } Method(_E01) { // PCI hotplug event - Return(\_SB.PCI0.PCNF()) + \_SB.PCI0.PCNF() } Method(_E02) { // CPU hotplug event - Return(\_SB.PRSC()) + \_SB.PRSC() } Method(_L03) { - Return(0x01) } Method(_L04) { - Return(0x01) } Method(_L05) { - Return(0x01) } Method(_L06) { - Return(0x01) } Method(_L07) { - Return(0x01) } Method(_L08) { - Return(0x01) } Method(_L09) { - Return(0x01) } Method(_L0A) { - Return(0x01) } Method(_L0B) { - Return(0x01) } Method(_L0C) { - Return(0x01) } Method(_L0D) { - Return(0x01) } Method(_L0E) { - Return(0x01) } Method(_L0F) { - Return(0x01) } } }

2 1

[SeaBIOS PATCH] ALT+NUMPAD and INT15 compatiblity patches
by Yeong Uk Jo 26 Jul '12

26 Jul '12

Includes two patches. 1. Add ALT+NUMPAD function to keyboard handler. 2. INT15 AH=80,81,82,90,91 return success like many BIOSes do. Signed-off-by: Yeong-uk Jo<greatpsycho at yahoo.com> --- src/kbd.c | 34 +++++++++++++++++++++++----------- src/system.c | 26 ++++++++++++++++++++++++++ 2 files changed, 49 insertions(+), 11 deletions(-) diff --git a/src/kbd.c b/src/kbd.c index e9ea594..b100008 100644 --- a/src/kbd.c +++ b/src/kbd.c @@ -358,18 +358,18 @@ static struct scaninfo { { 0x4400, 0x5d00, 0x6700, 0x7100, none }, /* F10 */ { none, none, none, none, none }, /* Num Lock */ { none, none, none, none, none }, /* Scroll Lock */ - { 0x4700, 0x4737, 0x7700, none, MNUM }, /* 7 Home */ - { 0x4800, 0x4838, none, none, MNUM }, /* 8 UP */ - { 0x4900, 0x4939, 0x8400, none, MNUM }, /* 9 PgUp */ + { 0x4700, 0x4737, 0x7700, 0xf700, MNUM }, /* 7 Home */ + { 0x4800, 0x4838, none, 0xf800, MNUM }, /* 8 UP */ + { 0x4900, 0x4939, 0x8400, 0xf900, MNUM }, /* 9 PgUp */ { 0x4a2d, 0x4a2d, none, none, none }, /* - */ - { 0x4b00, 0x4b34, 0x7300, none, MNUM }, /* 4 Left */ - { 0x4c00, 0x4c35, none, none, MNUM }, /* 5 */ - { 0x4d00, 0x4d36, 0x7400, none, MNUM }, /* 6 Right */ + { 0x4b00, 0x4b34, 0x7300, 0xf400, MNUM }, /* 4 Left */ + { 0x4c00, 0x4c35, none, 0xf500, MNUM }, /* 5 */ + { 0x4d00, 0x4d36, 0x7400, 0xf600, MNUM }, /* 6 Right */ { 0x4e2b, 0x4e2b, none, none, none }, /* + */ - { 0x4f00, 0x4f31, 0x7500, none, MNUM }, /* 1 End */ - { 0x5000, 0x5032, none, none, MNUM }, /* 2 Down */ - { 0x5100, 0x5133, 0x7600, none, MNUM }, /* 3 PgDn */ - { 0x5200, 0x5230, none, none, MNUM }, /* 0 Ins */ + { 0x4f00, 0x4f31, 0x7500, 0xf100, MNUM }, /* 1 End */ + { 0x5000, 0x5032, none, 0xf200, MNUM }, /* 2 Down */ + { 0x5100, 0x5133, 0x7600, 0xf300, MNUM }, /* 3 PgDn */ + { 0x5200, 0x5230, none, 0xf000, MNUM }, /* 0 Ins */ { 0x5300, 0x532e, none, none, MNUM }, /* Del */ { none, none, none, none, none }, { none, none, none, none, none }, @@ -385,6 +385,7 @@ __process_key(u8 scancode) u8 flags0 = GET_BDA(kbd_flag0); u8 flags1 = GET_BDA(kbd_flag1); u8 flags2 = GET_BDA(kbd_flag2); + u8 asciicode; if (flags2 & KF2_LAST_E1) { // Part of "pause" key (sequence is e1 1d 45 e1 9d c5) @@ -462,6 +463,13 @@ __process_key(u8 scancode) flags2 &= ~KF2_RALT; else flags1 &= ~KF1_LALT; + + /* Process ALT + NUMPAD */ + if((asciicode = GET_BDA(alt_keypad))) + { + enqueue_key(0, asciicode); + SET_BDA(alt_keypad, 0); + } break; case 0x45: /* Num Lock press */ @@ -506,11 +514,15 @@ __process_key(u8 scancode) , scancode); return; } - u8 asciicode; struct scaninfo *info = &scan_to_scanascii[scancode]; if (flags0 & KF0_ALTACTIVE) { asciicode = GET_GLOBAL(info->alt); scancode = GET_GLOBAL(info->alt) >> 8; + if((scancode & 0xf0) == 0xf0) + { + SET_BDA(alt_keypad, GET_BDA(alt_keypad) * 10 + (scancode & 0x0f)); + scancode = 0; + } } else if (flags0 & KF0_CTRLACTIVE) { asciicode = GET_GLOBAL(info->control); scancode = GET_GLOBAL(info->control) >> 8; diff --git a/src/system.c b/src/system.c index 6658e22..00aba7c 100644 --- a/src/system.c +++ b/src/system.c @@ -80,6 +80,27 @@ handle_1552(struct bregs *regs) set_code_success(regs); } +// Device open +static void +handle_1580(struct bregs *regs) +{ + set_code_success(regs); +} + +// Device close +static void +handle_1581(struct bregs *regs) +{ + set_code_success(regs); +} + +// Process termination +static void +handle_1582(struct bregs *regs) +{ + set_code_success(regs); +} + static void handle_1587(struct bregs *regs) { @@ -230,12 +251,14 @@ handle_1589(struct bregs *regs) static void handle_1590(struct bregs *regs) { + set_code_success(regs); } // Interrupt complete. Called by Int 16h when key becomes available static void handle_1591(struct bregs *regs) { + set_code_success(regs); } // keyboard intercept @@ -349,6 +372,9 @@ handle_15(struct bregs *regs) case 0x52: handle_1552(regs); break; case 0x53: handle_1553(regs); break; case 0x5f: handle_155f(regs); break; + case 0x80: handle_1580(regs); break; + case 0x81: handle_1581(regs); break; + case 0x82: handle_1582(regs); break; case 0x83: handle_1583(regs); break; case 0x86: handle_1586(regs); break; case 0x87: handle_1587(regs); break; -- 1.7.10

1 0

SeaBIOS, FW_CFG_NUMA, and FW_CFG_MAX_CPUS
by Eduardo Habkost 25 Jul '12

25 Jul '12

Hi, While working at the CPU index vs APIC ID changes, I stumbled upon another not-very-well-defined interface between SeaBIOS and QEMU, and I would like to clarify the semantics and constraints of some FW_CFG entries. First, the facts/assumptions: - There's no concept of "CPU index" or "CPU identifier" that SeaBIOS and QEMU agree upon, except for the APIC ID. All SeaBIOS can really see are the CPU APIC IDs, on boot or on CPU hotplug. - The APIC ID is already a perfectly good CPU identifier, that is present on bare metal hardware too. - Adding a new kind of "CPU identifier" in addition to the APIC ID would just make things more complex. - The only problem with APIC IDs is that they may not be contiguous. That said, I would like to clarify the meaning of: - FW_CFG_MAX_CPUS What are the basic semantics and expectations about FW_CFG_MAX_CPUS? Considering that the APIC IDs may not be contiguous, is it supposed to be: a) the maximum number of CPUs that will be ever online, doesn't matter their APIC IDs, or b) a value so that every CPU has APIC ID < MAX_CPUS. A practical example: suppose we have a machine with 18 CPUs with the following APIC IDs: 0x00, 0x01, 0x02, 0x04, 0x05, 0x06, 0x08, 0x09, 0x0a, 0x10, 0x11, 0x12, 0x14, 0x15, 0x16, 0x18, 0x19, 0x1a. (That's the expected result for a machine with 2 sockets, 3 cores per socket, 3 threads per core.) In that case, should FW_CFG_MAX_CPUS be: a) 18, or b) 27 (0x1b)? If it should be 18, it will require additional work on SeaBIOS to make: - CPU hotplug work - SRAT/MADT/SSDT tables be built with Processor ID != APIC ID - SRAT/MADT/SSDT tables be kept stable if the system is hibernated and resumed after a CPU is hot-plugged. (Probably in that case I would suggest introducing a FW_CFG_MAX_APIC_ID entry, so that SeaBIOS can still build the ACPI tables more easily). - FW_CFG_NUMA The first problem with FW_CFG_NUMA is that it depends on FW_CFG_MAX_CPUS (so it inherits the same questions above). The second is that FW_CFG_NUMA is a CPU-based table, but there's nothing SeaBIOS can use to know what CPUs FW_CFG_NUMA is refering to, except for the APIC IDs. So, should FW_CFG_NUMA be indexed by APIC IDs? - My proposal: My proposal is to try to keep things simple, and just use the following rule: - Never have a CPU with APIC ID > FW_CFG_MAX_CPUS. This way: - The SeaBIOS ACPI code can be kept simple. - The current CPU hotplug interface can work as-is (up to 256 CPUs), based on APIC IDs. - The current FW_CFG_NUMA interface can work as-is, indexed by APIC IDs. - The ACPI tables can be easily kept stable between hibernate and resume, after CPU hotplug. This is the direction I am trying to go, and I am sending this just to make sure nobody is against it, and to not surprise anybody when I send a QEMU patch to make FW_CFG_MAX_CPUS be based on APIC IDs. My second proposal would be to introduce a FW_CFG_MAX_APIC_ID entry, so the SeaBIOS ACPI code can be kept simple. My third proposal would be to introduce a FW_CFG CPU Index => APIC ID table, but I really wouldn't like to introduce a new type of CPU identifier to be used between QEMU and SeaBIOS, when the APIC ID is a perfectly good unique CPU identifier that already exists in bare metal hardware. -- Eduardo

3 3

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS July 2012