Updated _CRS method for HPET, bringing it in line with the way it is presented on recent hardware (e.g. Dell Latitude D630, MacPro5,1, etc); Allows it to be detected and utilized from Mac OS X; Also tested OK on Linux (F16 64-bit install DVD) and Windows (Win7 64-bit install DVD).
Signed-off-by: Gabriel Somlo somlo@cmu.edu --- src/acpi-dsdt.dsl | 20 +++++++++----------- 1 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index d2575a5..065a3e5 100644 --- a/src/acpi-dsdt.dsl +++ b/src/acpi-dsdt.dsl @@ -251,6 +251,12 @@ DefinitionBlock ( Device(HPET) { Name(_HID, EISAID("PNP0103")) Name(_UID, 0) + Name(BUF0, ResourceTemplate() { + Memory32Fixed (ReadOnly, + 0xFED00000, // Address Base + 0x00000400, // Address Length + ) + }) OperationRegion(HPTM, SystemMemory , 0xFED00000, 0x400) Field(HPTM, DWordAcc, Lock, Preserve) { VEND, 32, @@ -268,17 +274,9 @@ DefinitionBlock ( } Return (0x0F) } - Name(_CRS, ResourceTemplate() { - DWordMemory( - ResourceConsumer, PosDecode, MinFixed, MaxFixed, - NonCacheable, ReadWrite, - 0x00000000, - 0xFED00000, - 0xFED003FF, - 0x00000000, - 0x00000400 /* 1K memory: FED00000 - FED003FF */ - ) - }) + Method (_CRS, 0, NotSerialized) { + Return (BUF0) + } } }
On Mon, Oct 29, 2012 at 12:29:47PM -0400, Gabriel L. Somlo wrote:
Updated _CRS method for HPET, bringing it in line with the way it is presented on recent hardware (e.g. Dell Latitude D630, MacPro5,1, etc); Allows it to be detected and utilized from Mac OS X; Also tested OK on Linux (F16 64-bit install DVD) and Windows (Win7 64-bit install DVD).
Thanks. Can someone from the qemu or kvm lists Ack this change?
-Kevin
On 10/29/12 17:29, Gabriel L. Somlo wrote:
Updated _CRS method for HPET, bringing it in line with the way it is presented on recent hardware (e.g. Dell Latitude D630, MacPro5,1, etc); Allows it to be detected and utilized from Mac OS X; Also tested OK on Linux (F16 64-bit install DVD) and Windows (Win7 64-bit install DVD).
Any reason you are making this a method?
Name(BUF0, ResourceTemplate() {Memory32Fixed (ReadOnly,0xFED00000, // Address Base0x00000400, // Address Length)})
Just "Name(_CRS, ..." should work equally well.
/me wonders where the "ReadOnly" comes from as the hpet has writable registers. I see this on real hardware too, so it is probably correct. Would be nice to have this confirmed by some specification reference though.
cheers, Gerd
Updated _CRS method for HPET, bringing it in line with the way it is presented on recent hardware (e.g. Dell Latitude D630, MacPro5,1, etc); Allows it to be detected and utilized from Mac OS X; Also tested OK on Linux (F16 64-bit install DVD) and Windows (Win7 64-bit install DVD).
Signed-off-by: Gabriel Somlo somlo@cmu.edu ---
On Wed, Nov 07, 2012 at 07:30:31AM +0100, Gerd Hoffmann wrote:
Any reason you are making this a method?
Not really, I was just imitating the convention used by the hardware implementation(s) I was using for inspiration :) That being said, I do agree it looks better and more concise if left as "Name...", as you suggested (see below).
/me wonders where the "ReadOnly" comes from as the hpet has writable registers. I see this on real hardware too, so it is probably correct. Would be nice to have this confirmed by some specification reference though.
My guess would be subsection 2.3.2 (page 10) of the HPET spec rev. 1.0a: "2. Software should not write to read-only registers". Since at this level of detail we don't know where those registers are, only that they're out there somewhere, I'm guessing the thinking was that the safe course of action would be to declare it all ReadOnly, and leave it to the (hopefully more knowledgeable) OS driver to decide if/when to override that...
Thanks, Gabriel
src/acpi-dsdt.dsl | 13 ++++--------- 1 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 284d70d..e19f886 100644 --- a/src/acpi-dsdt.dsl +++ b/src/acpi-dsdt.dsl @@ -269,15 +269,10 @@ DefinitionBlock ( Return (0x0F) } Name(_CRS, ResourceTemplate() { - DWordMemory( - ResourceConsumer, PosDecode, MinFixed, MaxFixed, - NonCacheable, ReadWrite, - 0x00000000, - 0xFED00000, - 0xFED003FF, - 0x00000000, - 0x00000400 /* 1K memory: FED00000 - FED003FF */ - ) + Memory32Fixed (ReadOnly, + 0xFED00000, // Address Base + 0x00000400, // Address Length + ) }) } }
On 11/07/12 17:42, Gabriel L. Somlo wrote:
Any reason you are making this a method?
Not really, I was just imitating the convention used by the hardware implementation(s) I was using for inspiration :) That being said, I do agree it looks better and more concise if left as "Name...", as you suggested (see below).
Looks good to me now.
cheers, Gerd
Updated _CRS method for HPET, bringing it in line with the way it is presented on recent hardware (e.g. Dell Latitude D630, MacPro5,1, etc); Allows it to be detected and utilized from Mac OS X; Also tested OK on Linux (F16 64-bit install DVD) and Windows (Win7 64-bit install DVD).
Signed-off-by: Gabriel Somlo somlo@cmu.edu ---
On Thu, Nov 08, 2012 at 04:12:07PM +0100, Gerd Hoffmann wrote:
Looks good to me now.
One more thing, the "IRQNoFlags" line (also present on the real hardware I used as examples) makes it possible to start OS X with multiple virtual CPUs in qemu (e.g. -smp 4,cores=2). Re-ran tests on Fedora16 and Windows7 successfully (also with smp enabled).
Thanks, --Gabriel
src/acpi-dsdt.dsl | 14 +++++--------- 1 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 284d70d..711302e 100644 --- a/src/acpi-dsdt.dsl +++ b/src/acpi-dsdt.dsl @@ -269,15 +269,11 @@ DefinitionBlock ( Return (0x0F) } Name(_CRS, ResourceTemplate() { - DWordMemory( - ResourceConsumer, PosDecode, MinFixed, MaxFixed, - NonCacheable, ReadWrite, - 0x00000000, - 0xFED00000, - 0xFED003FF, - 0x00000000, - 0x00000400 /* 1K memory: FED00000 - FED003FF */ - ) + IRQNoFlags () {2, 8} + Memory32Fixed (ReadOnly, + 0xFED00000, // Address Base + 0x00000400, // Address Length + ) }) } }
Hi Gabriel,
On 08.11.2012, at 18:35, Gabriel L. Somlo wrote:
Updated _CRS method for HPET, bringing it in line with the way it is presented on recent hardware (e.g. Dell Latitude D630, MacPro5,1, etc); Allows it to be detected and utilized from Mac OS X; Also tested OK on Linux (F16 64-bit install DVD) and Windows (Win7 64-bit install DVD).
Signed-off-by: Gabriel Somlo somlo@cmu.edu
On Thu, Nov 08, 2012 at 04:12:07PM +0100, Gerd Hoffmann wrote:
Looks good to me now.
One more thing, the "IRQNoFlags" line (also present on the real hardware I used as examples) makes it possible to start OS X with multiple virtual CPUs in qemu (e.g. -smp 4,cores=2). Re-ran tests on Fedora16 and Windows7 successfully (also with smp enabled).
What did the Darwin kernel do before with -smp > 1?
I ask, because for me it booted already, just was not stable. The question is: Is OS X stable for you with -smp > 1 under load?
René
Thanks, --Gabriel
src/acpi-dsdt.dsl | 14 +++++--------- 1 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 284d70d..711302e 100644 --- a/src/acpi-dsdt.dsl +++ b/src/acpi-dsdt.dsl @@ -269,15 +269,11 @@ DefinitionBlock ( Return (0x0F) } Name(_CRS, ResourceTemplate() {
DWordMemory(ResourceConsumer, PosDecode, MinFixed, MaxFixed,NonCacheable, ReadWrite,0x00000000,0xFED00000,0xFED003FF,0x00000000,0x00000400 /* 1K memory: FED00000 - FED003FF */)
IRQNoFlags () {2, 8}Memory32Fixed (ReadOnly,0xFED00000, // Address Base0x00000400, // Address Length) }) }-- 1.7.7.6
ping
On Thu, Nov 08, 2012 at 12:35:17PM -0500, Gabriel L. Somlo wrote:
Updated _CRS method for HPET, bringing it in line with the way it is presented on recent hardware (e.g. Dell Latitude D630, MacPro5,1, etc); Allows it to be detected and utilized from Mac OS X; Also tested OK on Linux (F16 64-bit install DVD) and Windows (Win7 64-bit install DVD).
Signed-off-by: Gabriel Somlo somlo@cmu.edu
On Thu, Nov 08, 2012 at 04:12:07PM +0100, Gerd Hoffmann wrote:
Looks good to me now.
One more thing, the "IRQNoFlags" line (also present on the real hardware I used as examples) makes it possible to start OS X with multiple virtual CPUs in qemu (e.g. -smp 4,cores=2). Re-ran tests on Fedora16 and Windows7 successfully (also with smp enabled).
Thanks, --Gabriel
src/acpi-dsdt.dsl | 14 +++++--------- 1 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 284d70d..711302e 100644 --- a/src/acpi-dsdt.dsl +++ b/src/acpi-dsdt.dsl @@ -269,15 +269,11 @@ DefinitionBlock ( Return (0x0F) } Name(_CRS, ResourceTemplate() {
DWordMemory(ResourceConsumer, PosDecode, MinFixed, MaxFixed,NonCacheable, ReadWrite,0x00000000,0xFED00000,0xFED003FF,0x00000000,0x00000400 /* 1K memory: FED00000 - FED003FF */)
IRQNoFlags () {2, 8}Memory32Fixed (ReadOnly,0xFED00000, // Address Base0x00000400, // Address Length) }) }-- 1.7.7.6
On Fri, Nov 16, 2012 at 01:02:18PM -0500, Gabriel L. Somlo wrote:
ping
On Thu, Nov 08, 2012 at 12:35:17PM -0500, Gabriel L. Somlo wrote:
Updated _CRS method for HPET, bringing it in line with the way it is presented on recent hardware (e.g. Dell Latitude D630, MacPro5,1, etc); Allows it to be detected and utilized from Mac OS X; Also tested OK on Linux (F16 64-bit install DVD) and Windows (Win7 64-bit install DVD).
Signed-off-by: Gabriel Somlo somlo@cmu.edu
I'm okay with the patch. I'm looking to see an Ack from one of the kvm/qemu developers. (I saw Gerd was okay with the last version of the patch.)
-Kevin
On 16.11.2012, at 19:46, Kevin O'Connor wrote:
On Fri, Nov 16, 2012 at 01:02:18PM -0500, Gabriel L. Somlo wrote:
ping
On Thu, Nov 08, 2012 at 12:35:17PM -0500, Gabriel L. Somlo wrote:
Updated _CRS method for HPET, bringing it in line with the way it is presented on recent hardware (e.g. Dell Latitude D630, MacPro5,1, etc); Allows it to be detected and utilized from Mac OS X; Also tested OK on Linux (F16 64-bit install DVD) and Windows (Win7 64-bit install DVD).
Signed-off-by: Gabriel Somlo somlo@cmu.edu
I'm okay with the patch. I'm looking to see an Ack from one of the kvm/qemu developers. (I saw Gerd was okay with the last version of the patch.)
IIRC Marcelo was the one changing the DSDT code from what this patch produces to what we have today. My initial HPET DSDT entry was also copied from real hardware.
Marcelo, any memory on this? :) Keep in mind I might be misremembering - maybe it was someone else after all ;).
Alex
On Mon, Nov 19, 2012 at 11:22:48AM +0100, Alexander Graf wrote:
On 16.11.2012, at 19:46, Kevin O'Connor wrote:
On Fri, Nov 16, 2012 at 01:02:18PM -0500, Gabriel L. Somlo wrote:
ping
On Thu, Nov 08, 2012 at 12:35:17PM -0500, Gabriel L. Somlo wrote:
Updated _CRS method for HPET, bringing it in line with the way it is presented on recent hardware (e.g. Dell Latitude D630, MacPro5,1, etc); Allows it to be detected and utilized from Mac OS X; Also tested OK on Linux (F16 64-bit install DVD) and Windows (Win7 64-bit install DVD).
Signed-off-by: Gabriel Somlo somlo@cmu.edu
I'm okay with the patch. I'm looking to see an Ack from one of the kvm/qemu developers. (I saw Gerd was okay with the last version of the patch.)
IIRC Marcelo was the one changing the DSDT code from what this patch produces to what we have today. My initial HPET DSDT entry was also copied from real hardware.
Marcelo, any memory on this? :) Keep in mind I might be misremembering - maybe it was someone else after all ;).
I think you are misremembering. Git shows that HPET entry was taken from pcbios code and my old pcbios git tree says that the dsdt code was contributed by Beth Kon and it is the same as we have it now in SeaBIOS.
The patch looks OK.
-- Gleb.
On 19.11.2012, at 12:33, Gleb Natapov wrote:
On Mon, Nov 19, 2012 at 11:22:48AM +0100, Alexander Graf wrote:
On 16.11.2012, at 19:46, Kevin O'Connor wrote:
On Fri, Nov 16, 2012 at 01:02:18PM -0500, Gabriel L. Somlo wrote:
ping
On Thu, Nov 08, 2012 at 12:35:17PM -0500, Gabriel L. Somlo wrote:
Updated _CRS method for HPET, bringing it in line with the way it is presented on recent hardware (e.g. Dell Latitude D630, MacPro5,1, etc); Allows it to be detected and utilized from Mac OS X; Also tested OK on Linux (F16 64-bit install DVD) and Windows (Win7 64-bit install DVD).
Signed-off-by: Gabriel Somlo somlo@cmu.edu
I'm okay with the patch. I'm looking to see an Ack from one of the kvm/qemu developers. (I saw Gerd was okay with the last version of the patch.)
IIRC Marcelo was the one changing the DSDT code from what this patch produces to what we have today. My initial HPET DSDT entry was also copied from real hardware.
Marcelo, any memory on this? :) Keep in mind I might be misremembering - maybe it was someone else after all ;).
I think you are misremembering. Git shows that HPET entry was taken from pcbios code and my old pcbios git tree says that the dsdt code was contributed by Beth Kon and it is the same as we have it now in SeaBIOS.
Hrm. I'm 100% sure that from my code (which Beth based on) to the code that we have, someone had completely rewritten the DSDT entry. Either way, not complaining as long as we get it sorted out eventually :).
The patch looks OK.
Mind to make this a formal acked-by? :)
Alex
On Mon, Nov 19, 2012 at 12:35:47PM +0100, Alexander Graf wrote:
On 19.11.2012, at 12:33, Gleb Natapov wrote:
On Mon, Nov 19, 2012 at 11:22:48AM +0100, Alexander Graf wrote:
On 16.11.2012, at 19:46, Kevin O'Connor wrote:
On Fri, Nov 16, 2012 at 01:02:18PM -0500, Gabriel L. Somlo wrote:
ping
On Thu, Nov 08, 2012 at 12:35:17PM -0500, Gabriel L. Somlo wrote:
Updated _CRS method for HPET, bringing it in line with the way it is presented on recent hardware (e.g. Dell Latitude D630, MacPro5,1, etc); Allows it to be detected and utilized from Mac OS X; Also tested OK on Linux (F16 64-bit install DVD) and Windows (Win7 64-bit install DVD).
Signed-off-by: Gabriel Somlo somlo@cmu.edu
I'm okay with the patch. I'm looking to see an Ack from one of the kvm/qemu developers. (I saw Gerd was okay with the last version of the patch.)
IIRC Marcelo was the one changing the DSDT code from what this patch produces to what we have today. My initial HPET DSDT entry was also copied from real hardware.
Marcelo, any memory on this? :) Keep in mind I might be misremembering - maybe it was someone else after all ;).
I think you are misremembering. Git shows that HPET entry was taken from pcbios code and my old pcbios git tree says that the dsdt code was contributed by Beth Kon and it is the same as we have it now in SeaBIOS.
Hrm. I'm 100% sure that from my code (which Beth based on) to the code that we have, someone had completely rewritten the DSDT entry. Either way, not complaining as long as we get it sorted out eventually :).
Here is Beth's commit in bochs :) http://0x0badc0.de/gitweb?p=bochs/.git;a=commitdiff;h=874040e817e49811c30405...
I added _STA logic in SeaBIOS but otherwise the code is the same.
The patch looks OK.
Mind to make this a formal acked-by? :)
Sure, will do.
-- Gleb.
On 19.11.2012, at 12:51, Gleb Natapov wrote:
On Mon, Nov 19, 2012 at 12:35:47PM +0100, Alexander Graf wrote:
On 19.11.2012, at 12:33, Gleb Natapov wrote:
On Mon, Nov 19, 2012 at 11:22:48AM +0100, Alexander Graf wrote:
On 16.11.2012, at 19:46, Kevin O'Connor wrote:
On Fri, Nov 16, 2012 at 01:02:18PM -0500, Gabriel L. Somlo wrote:
ping
On Thu, Nov 08, 2012 at 12:35:17PM -0500, Gabriel L. Somlo wrote: > Updated _CRS method for HPET, bringing it in line with the way it is > presented on recent hardware (e.g. Dell Latitude D630, MacPro5,1, etc); > Allows it to be detected and utilized from Mac OS X; Also tested OK on > Linux (F16 64-bit install DVD) and Windows (Win7 64-bit install DVD). > > Signed-off-by: Gabriel Somlo somlo@cmu.edu
I'm okay with the patch. I'm looking to see an Ack from one of the kvm/qemu developers. (I saw Gerd was okay with the last version of the patch.)
IIRC Marcelo was the one changing the DSDT code from what this patch produces to what we have today. My initial HPET DSDT entry was also copied from real hardware.
Marcelo, any memory on this? :) Keep in mind I might be misremembering - maybe it was someone else after all ;).
I think you are misremembering. Git shows that HPET entry was taken from pcbios code and my old pcbios git tree says that the dsdt code was contributed by Beth Kon and it is the same as we have it now in SeaBIOS.
Hrm. I'm 100% sure that from my code (which Beth based on) to the code that we have, someone had completely rewritten the DSDT entry. Either way, not complaining as long as we get it sorted out eventually :).
Here is Beth's commit in bochs :) http://0x0badc0.de/gitweb?p=bochs/.git;a=commitdiff;h=874040e817e49811c30405...
Ah, apparently Beth's DSDT bits were a rewrite done by Ryan. My original version looked like this:
http://lists.gnu.org/archive/html/qemu-devel/2008-01/msg00180.html
but obviously broke quite a few things along the way ;). Also, I do remember that I extracted the HPET bits from there and submitted them individually, but I might really just be misremembering and it's not like that makes any difference.
I added _STA logic in SeaBIOS but otherwise the code is the same.
The patch looks OK.
Mind to make this a formal acked-by? :)
Sure, will do.
Just reply with the line ;)
Alex
On Mon, Nov 19, 2012 at 01:00:56PM +0100, Alexander Graf wrote:
On 19.11.2012, at 12:51, Gleb Natapov wrote:
On Mon, Nov 19, 2012 at 12:35:47PM +0100, Alexander Graf wrote:
On 19.11.2012, at 12:33, Gleb Natapov wrote:
On Mon, Nov 19, 2012 at 11:22:48AM +0100, Alexander Graf wrote:
On 16.11.2012, at 19:46, Kevin O'Connor wrote:
On Fri, Nov 16, 2012 at 01:02:18PM -0500, Gabriel L. Somlo wrote: > ping > > On Thu, Nov 08, 2012 at 12:35:17PM -0500, Gabriel L. Somlo wrote: >> Updated _CRS method for HPET, bringing it in line with the way it is >> presented on recent hardware (e.g. Dell Latitude D630, MacPro5,1, etc); >> Allows it to be detected and utilized from Mac OS X; Also tested OK on >> Linux (F16 64-bit install DVD) and Windows (Win7 64-bit install DVD). >> >> Signed-off-by: Gabriel Somlo somlo@cmu.edu
I'm okay with the patch. I'm looking to see an Ack from one of the kvm/qemu developers. (I saw Gerd was okay with the last version of the patch.)
IIRC Marcelo was the one changing the DSDT code from what this patch produces to what we have today. My initial HPET DSDT entry was also copied from real hardware.
Marcelo, any memory on this? :) Keep in mind I might be misremembering - maybe it was someone else after all ;).
I think you are misremembering. Git shows that HPET entry was taken from pcbios code and my old pcbios git tree says that the dsdt code was contributed by Beth Kon and it is the same as we have it now in SeaBIOS.
Hrm. I'm 100% sure that from my code (which Beth based on) to the code that we have, someone had completely rewritten the DSDT entry. Either way, not complaining as long as we get it sorted out eventually :).
Here is Beth's commit in bochs :) http://0x0badc0.de/gitweb?p=bochs/.git;a=commitdiff;h=874040e817e49811c30405...
Ah, apparently Beth's DSDT bits were a rewrite done by Ryan. My original version looked like this:
http://lists.gnu.org/archive/html/qemu-devel/2008-01/msg00180.html
but obviously broke quite a few things along the way ;). Also, I do remember that I extracted the HPET bits from there and submitted them individually, but I might really just be misremembering and it's not like that makes any difference.
Just wanted to make sure that we do not revert someone's change without understanding why it was done in the first place.
I added _STA logic in SeaBIOS but otherwise the code is the same.
The patch looks OK.
Mind to make this a formal acked-by? :)
Sure, will do.
Just reply with the line ;)
Did it in a most formal way by answering to the patch itself :)
-- Gleb.
On Thu, Nov 08, 2012 at 12:35:17PM -0500, Gabriel L. Somlo wrote:
Updated _CRS method for HPET, bringing it in line with the way it is presented on recent hardware (e.g. Dell Latitude D630, MacPro5,1, etc); Allows it to be detected and utilized from Mac OS X; Also tested OK on Linux (F16 64-bit install DVD) and Windows (Win7 64-bit install DVD).
Signed-off-by: Gabriel Somlo somlo@cmu.edu
Acked-by: Gleb Natapov gleb@redhat.com
On Thu, Nov 08, 2012 at 04:12:07PM +0100, Gerd Hoffmann wrote:
Looks good to me now.
One more thing, the "IRQNoFlags" line (also present on the real hardware I used as examples) makes it possible to start OS X with multiple virtual CPUs in qemu (e.g. -smp 4,cores=2). Re-ran tests on Fedora16 and Windows7 successfully (also with smp enabled).
Thanks, --Gabriel
src/acpi-dsdt.dsl | 14 +++++--------- 1 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 284d70d..711302e 100644 --- a/src/acpi-dsdt.dsl +++ b/src/acpi-dsdt.dsl @@ -269,15 +269,11 @@ DefinitionBlock ( Return (0x0F) } Name(_CRS, ResourceTemplate() {
DWordMemory(ResourceConsumer, PosDecode, MinFixed, MaxFixed,NonCacheable, ReadWrite,0x00000000,0xFED00000,0xFED003FF,0x00000000,0x00000400 /* 1K memory: FED00000 - FED003FF */)
IRQNoFlags () {2, 8}Memory32Fixed (ReadOnly,0xFED00000, // Address Base0x00000400, // Address Length) }) }-- 1.7.7.6
SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios
-- Gleb.
On Thu, Nov 08, 2012 at 12:35:17PM -0500, Gabriel L. Somlo wrote:
Updated _CRS method for HPET, bringing it in line with the way it is presented on recent hardware (e.g. Dell Latitude D630, MacPro5,1, etc); Allows it to be detected and utilized from Mac OS X; Also tested OK on Linux (F16 64-bit install DVD) and Windows (Win7 64-bit install DVD).
Signed-off-by: Gabriel Somlo somlo@cmu.edu
Thanks - I applied this patch.
-Kevin
-
Alexander Graf -
Gabriel L. Somlo -
Gerd Hoffmann -
Gleb Natapov -
Kevin O'Connor -
Rene Rebe