Re: [SeaBIOS] [PATCH] DSDT: Fix HPET _CRS Method

[Gerd Hoffmann]

On 10/29/12 17:29, Gabriel L. Somlo wrote:
> Updated _CRS method for HPET, bringing it in line with the way it is
> presented on recent hardware (e.g. Dell Latitude D630, MacPro5,1, etc);
> Allows it to be detected and utilized from Mac OS X; Also tested OK on
> Linux (F16 64-bit install DVD) and Windows (Win7 64-bit install DVD).

Any reason you are making this a method?
>        Name(BUF0, ResourceTemplate() {
>            Memory32Fixed (ReadOnly,
>                0xFED00000,         // Address Base
>                0x00000400,         // Address Length
>                )
>        })

Just "Name(_CRS, ..." should work equally well.

/me wonders where the "ReadOnly" comes from as the hpet has writable
registers.  I see this on real hardware too, so it is probably correct.
 Would be nice to have this confirmed by some specification reference
though.

cheers,
  Gerd