SeaBIOS

seabios@seabios.org

3783 discussions

Re: [SeaBIOS] [QUESTION]stuck in SeaBIOS and vm cannot be reset any more
by Paolo Bonzini 09 Aug '16

09 Aug '16

On 09/08/2016 10:04, Xulei (Stone) wrote: > Following your suggestion, i'm now sure it is caused by missing SMI. > I have tried adding dprintf() like this: > > --- a/roms/seabios/src/fw/smm.c > +++ b/roms/seabios/src/fw/smm.c > @@ -65,7 +65,8 @@ handle_smi(u16 cs) > u8 cmd = inb(PORT_SMI_CMD); > struct smm_layout *smm = MAKE_FLATPTR(cs, 0); > u32 rev = smm->cpu.i32.smm_rev & SMM_REV_MASK; > - dprintf(DEBUG_HDL_smi, "handle_smi cmd=%x smbase=%p\n", cmd, smm); > + if(cmd == 0x00) { > + dprintf(1, "handle_smi cmd=%x smbase=%p\n", cmd, smm); > + } > > if (smm == (void*)BUILD_SMM_INIT_ADDR) { > // relocate SMBASE to 0xa0000 > @@ -147,14 +148,14 @@ smm_relocate_and_restore(void) { > /* init APM status port */ > outb(0x01, PORT_SMI_STATUS); > + dprintf(1,"before SMI====\n"); > > /* raise an SMI interrupt */ > outb(0x00, PORT_SMI_CMD); > + dprintf(1,"after SMI=====\n"); > > /* wait until SMM code executed */ > while (inb(PORT_SMI_STATUS) != 0x00) > ; > + dprintf(1,"smm code executes complete====\n"); > > And the failed case log output like this: > 2016-08-03 16:23:15PCI: Using 00:02.0 for primary VGA > 2016-08-03 16:23:15smm_device_setup start > 2016-08-03 16:23:15init smm > 2016-08-03 16:23:15before SMI==== > 2016-08-03 16:23:15after SMI===== > > So, it's obviously that after outb(0x01, PORT_SMI_STATUS), bios does not > handle_smi, so PORT_SMI_STATUS is always 0x01. What's more, when this > problem happens, rebooting vm cannot restore it any more. My vm is always > stuck at the same place until i destroy it. > > And I have already tried kernel commit c43203cab1e which still can not > solve this problem. > Any idea, Kevin and Paolo? 0xb2 is handled within QEMU, so it may be useful to make sure that QEMU is sending the KVM_SMI ioctl. From there the best tool is still KVM tracing and printk. I suggest replacing the dprintf with a simple outb like outb(0x21, 0x402) (before) and outb(0x23, 0x402) (after). They show as "!" and "#" in the trace, and they are easy to spot in the KVM trace. Paolo

1 0

Re: [SeaBIOS] [QUESTION]stuck in SeaBIOS and vm cannot be reset any more
by Xulei (Stone) 09 Aug '16

09 Aug '16

>On Tue, Aug 02, 2016 at 04:18:30AM +0000, Xulei (Stone) wrote: >> >On Fri, Jul 29, 2016 at 04:04:59AM +0000, Xulei (Stone) wrote: >> >> After one day, the vm is stuck. Looking from the following seabios >> >> log, it seems seabios stops at "PCI: Using 00:02.0 for primary >> >> VGA", and can not execute handle_smp() any more. >> >> What may be the reason? >> > >> >More debugging info would be necessary to find this problem. You >> >could try reproducing and attaching gdb ( >> >http://www.seabios.org/Debugging#Debugging_with_gdb_on_QEMU ). >> >Alternatively, a kvm trace log may help. >> > >> kvm trace (seems useful) indicates that cpu 0 keeps always to access 0x00b3 ioport. >> 0x00b3 is PORT_SMI_STATUS, so i guess my bios is stuck in the >> function smm_relocate_and_restore { >> ... >> /* wait until SMM code executed */ >> while (inb(PORT_SMI_STATUS) != 0x00) >> ... >> } > >I'd try adding dprintf() statements around all the code at the top of >smm_relocate_and_restore() and enable the dprintf() at the top of >handle_smi(). > >It would also be useful if you can extract the log from the last two >working reboots to compare it to the failed case. Following your suggestion, i'm now sure it is caused by missing SMI. I have tried adding dprintf() like this: --- a/roms/seabios/src/fw/smm.c +++ b/roms/seabios/src/fw/smm.c @@ -65,7 +65,8 @@ handle_smi(u16 cs) u8 cmd = inb(PORT_SMI_CMD); struct smm_layout *smm = MAKE_FLATPTR(cs, 0); u32 rev = smm->cpu.i32.smm_rev & SMM_REV_MASK; - dprintf(DEBUG_HDL_smi, "handle_smi cmd=%x smbase=%p\n", cmd, smm); + if(cmd == 0x00) { + dprintf(1, "handle_smi cmd=%x smbase=%p\n", cmd, smm); + } if (smm == (void*)BUILD_SMM_INIT_ADDR) { // relocate SMBASE to 0xa0000 @@ -147,14 +148,14 @@ smm_relocate_and_restore(void) { /* init APM status port */ outb(0x01, PORT_SMI_STATUS); + dprintf(1,"before SMI====\n"); /* raise an SMI interrupt */ outb(0x00, PORT_SMI_CMD); + dprintf(1,"after SMI=====\n"); /* wait until SMM code executed */ while (inb(PORT_SMI_STATUS) != 0x00) ; + dprintf(1,"smm code executes complete====\n"); And the failed case log output like this: 2016-08-03 16:23:15PCI: Using 00:02.0 for primary VGA 2016-08-03 16:23:15smm_device_setup start 2016-08-03 16:23:15init smm 2016-08-03 16:23:15before SMI==== 2016-08-03 16:23:15after SMI===== So, it's obviously that after outb(0x01, PORT_SMI_STATUS), bios does not handle_smi, so PORT_SMI_STATUS is always 0x01. What's more, when this problem happens, rebooting vm cannot restore it any more. My vm is always stuck at the same place until i destroy it. And I have already tried kernel commit c43203cab1e which still can not solve this problem. Any idea, Kevin and Paolo? > > > >-Kevin

1 0

[PATCH 1/2] swcursor: Move swcursor code from vgafb.c to new file swcursor.c
by Kevin O'Connor 06 Aug '16

06 Aug '16

Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- Makefile | 2 +- vgasrc/swcursor.c | 65 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ vgasrc/vgabios.h | 2 ++ vgasrc/vgafb.c | 57 ------------------------------------------------ 4 files changed, 68 insertions(+), 58 deletions(-) create mode 100644 vgasrc/swcursor.c diff --git a/Makefile b/Makefile index 4930b3a..41bfcf4 100644 --- a/Makefile +++ b/Makefile @@ -207,7 +207,7 @@ $(OUT)bios.bin.elf: $(OUT)rom.o $(OUT)bios.bin.prep # VGA src files SRCVGA=src/output.c src/string.c src/hw/pci.c src/hw/serialio.c \ - vgasrc/vgainit.c vgasrc/vgabios.c vgasrc/vgafb.c \ + vgasrc/vgainit.c vgasrc/vgabios.c vgasrc/vgafb.c vgasrc/swcursor.c \ vgasrc/vgafonts.c vgasrc/vbe.c \ vgasrc/stdvga.c vgasrc/stdvgamodes.c vgasrc/stdvgaio.c \ vgasrc/clext.c vgasrc/bochsvga.c vgasrc/geodevga.c \ diff --git a/vgasrc/swcursor.c b/vgasrc/swcursor.c new file mode 100644 index 0000000..35f857a --- /dev/null +++ b/vgasrc/swcursor.c @@ -0,0 +1,65 @@ +// Virtual software based cursor support +// +// Copyright (C) 2014-2016 Kevin O'Connor <kevin(a)koconnor.net> +// +// This file may be distributed under the terms of the GNU LGPLv3 license. + +#include "biosvar.h" // GET_BDA +#include "vgabios.h" // handle_gfx_op + +// Draw/undraw a cursor on the framebuffer by xor'ing the cursor cell +static void +gfx_set_swcursor(struct vgamode_s *vmode_g, int enable, struct cursorpos cp) +{ + u16 cursor_type = get_cursor_shape(); + u8 start = cursor_type >> 8, end = cursor_type & 0xff; + struct gfx_op op; + init_gfx_op(&op, vmode_g); + op.x = cp.x * 8; + int cheight = GET_BDA(char_height); + op.y = cp.y * cheight + start; + + int i; + for (i = start; i < cheight && i <= end; i++, op.y++) { + op.op = GO_READ8; + handle_gfx_op(&op); + int j; + for (j = 0; j < 8; j++) + op.pixels[j] ^= 0x07; + op.op = GO_WRITE8; + handle_gfx_op(&op); + } +} + +// Draw/undraw a cursor on the screen +void +vgafb_set_swcursor(int enable) +{ + if (!vga_emulate_text()) + return; + u8 flags = GET_BDA_EXT(flags); + if (!!(flags & BF_SWCURSOR) == enable) + // Already in requested mode. + return; + struct vgamode_s *vmode_g = get_current_mode(); + if (!vmode_g) + return; + struct cursorpos cp = get_cursor_pos(GET_BDA(video_page)); + if (cp.x >= GET_BDA(video_cols) || cp.y > GET_BDA(video_rows) + || GET_BDA(cursor_type) >= 0x2000) + // Cursor not visible + return; + + SET_BDA_EXT(flags, (flags & ~BF_SWCURSOR) | (enable ? BF_SWCURSOR : 0)); + + if (GET_GLOBAL(vmode_g->memmodel) != MM_TEXT) { + gfx_set_swcursor(vmode_g, enable, cp); + return; + } + + // In text mode, swap foreground and background attributes for cursor + void *dest_far = text_address(cp) + 1; + u8 attr = GET_FARVAR(GET_GLOBAL(vmode_g->sstart), *(u8*)dest_far); + attr = (attr >> 4) | (attr << 4); + SET_FARVAR(GET_GLOBAL(vmode_g->sstart), *(u8*)dest_far, attr); +} diff --git a/vgasrc/vgabios.h b/vgasrc/vgabios.h index 9fbfb14..9764020 100644 --- a/vgasrc/vgabios.h +++ b/vgasrc/vgabios.h @@ -132,6 +132,8 @@ void vgafb_write_char(struct cursorpos cp, struct carattr ca); struct carattr vgafb_read_char(struct cursorpos cp); void vgafb_write_pixel(u8 color, u16 x, u16 y); u8 vgafb_read_pixel(u16 x, u16 y); + +// swcursor.c void vgafb_set_swcursor(int enable); // vbe.c diff --git a/vgasrc/vgafb.c b/vgasrc/vgafb.c index bd1c8dd..46a1ab8 100644 --- a/vgasrc/vgafb.c +++ b/vgasrc/vgafb.c @@ -497,30 +497,6 @@ fail: return (struct carattr){0, 0, 0}; } -// Draw/undraw a cursor on the framebuffer by xor'ing the cursor cell -void -gfx_set_swcursor(struct vgamode_s *vmode_g, int enable, struct cursorpos cp) -{ - u16 cursor_type = get_cursor_shape(); - u8 start = cursor_type >> 8, end = cursor_type & 0xff; - struct gfx_op op; - init_gfx_op(&op, vmode_g); - op.x = cp.x * 8; - int cheight = GET_BDA(char_height); - op.y = cp.y * cheight + start; - - int i; - for (i = start; i < cheight && i <= end; i++, op.y++) { - op.op = GO_READ8; - handle_gfx_op(&op); - int j; - for (j = 0; j < 8; j++) - op.pixels[j] ^= 0x07; - op.op = GO_WRITE8; - handle_gfx_op(&op); - } -} - // Set the pixel at the given position. void vgafb_write_pixel(u8 color, u16 x, u16 y) @@ -686,36 +662,3 @@ vgafb_read_char(struct cursorpos cp) u16 v = GET_FARVAR(GET_GLOBAL(vmode_g->sstart), *dest_far); return (struct carattr){v, v>>8, 0}; } - -// Draw/undraw a cursor on the screen -void -vgafb_set_swcursor(int enable) -{ - if (!vga_emulate_text()) - return; - u8 flags = GET_BDA_EXT(flags); - if (!!(flags & BF_SWCURSOR) == enable) - // Already in requested mode. - return; - struct vgamode_s *vmode_g = get_current_mode(); - if (!vmode_g) - return; - struct cursorpos cp = get_cursor_pos(GET_BDA(video_page)); - if (cp.x >= GET_BDA(video_cols) || cp.y > GET_BDA(video_rows) - || GET_BDA(cursor_type) >= 0x2000) - // Cursor not visible - return; - - SET_BDA_EXT(flags, (flags & ~BF_SWCURSOR) | (enable ? BF_SWCURSOR : 0)); - - if (GET_GLOBAL(vmode_g->memmodel) != MM_TEXT) { - gfx_set_swcursor(vmode_g, enable, cp); - return; - } - - // In text mode, swap foreground and background attributes for cursor - void *dest_far = text_address(cp) + 1; - u8 attr = GET_FARVAR(GET_GLOBAL(vmode_g->sstart), *(u8*)dest_far); - attr = (attr >> 4) | (attr << 4); - SET_FARVAR(GET_GLOBAL(vmode_g->sstart), *(u8*)dest_far, attr); -} -- 2.5.5

1 1

[PATCH v2 0/6] tpm: Extend PCRs in all available PCR banks
by Stefan Berger 05 Aug '16

05 Aug '16

This series of patches extends the TPM2 code to extend the BIOS related PCRs 0-7 in all available banks. This prevents that these PCRs remain untouched and filled with bogus values by applications. For example, the SHA1 hash is extended into the SHA256 bank. The value that is extended into this bank is essentially a SHA1 with zero bytes used for filling it to the size of a sha256 hash. This is done for all PCR banks of the TPM2 where these PCRs are available. In v2 of this series I also extended the log functions for logging the additional hashes. So there are more patches now. Regards, Stefan Stefan Berger (6): tpm: Retrieve the PCR Bank configuration tpm: Restructure tpm20_extend to use buffer and take hash as parameter tpm: Extend tpm20_extend to support extending to multiple PCR banks tpm: Move tpm_log_init to a later point tpm: Adjust the TPM2 log header to show all hashes tpm: Append to TPM2 log the hashes used for PCR extension src/std/tcg.h | 78 +++++++++++-- src/tcgbios.c | 348 ++++++++++++++++++++++++++++++++++++++++++++++++++-------- 2 files changed, 371 insertions(+), 55 deletions(-) -- 2.5.5

2 10

Re: [SeaBIOS] [QUESTION]stuck in SeaBIOS and vm can not be reset any more
by Kevin O'Connor 03 Aug '16

03 Aug '16

On Tue, Aug 02, 2016 at 04:18:30AM +0000, Xulei (Stone) wrote: > >On Fri, Jul 29, 2016 at 04:04:59AM +0000, Xulei (Stone) wrote: > >> After one day, the vm is stuck. Looking from the following seabios log, > >> it seems seabios stops at "PCI: Using 00:02.0 for primary VGA", and can > >> not execute handle_smp() any more. > >> What may be the reason? > > > >More debugging info would be necessary to find this problem. You > >could try reproducing and attaching gdb ( > >http://www.seabios.org/Debugging#Debugging_with_gdb_on_QEMU ). > >Alternatively, a kvm trace log may help. > > > kvm trace (seems useful) indicates that cpu 0 keeps always to access 0x00b3 ioport. > 0x00b3 is PORT_SMI_STATUS, so i guess my bios is stuck in the function > smm_relocate_and_restore > { > ... > /* wait until SMM code executed */ > while (inb(PORT_SMI_STATUS) != 0x00) > ... > } I'd try adding dprintf() statements around all the code at the top of smm_relocate_and_restore() and enable the dprintf() at the top of handle_smi(). It would also be useful if you can extract the log from the last two working reboots to compare it to the failed case. -Kevin

2 1

[BUG?] Doesn't retrieve control after coreboot payload return
by Antonello Dettori 03 Aug '16

03 Aug '16

Hi everyone. I'm currently working on coreboot but I stumbled on a strange SeaBIOS behaviour. After executing a payload and returning control to the caller SeaBIOS crashes. The problem is currently solved by rebooting before the payload returns but doing so also makes chaining multiple payloads impossible so I'm trying to look into a solution. I tried to increment the debug level to 8 to get more information and the attached log is what I got. I also attached a build of coreboot with this problem if someone wants to try it in QEMU. I'm not terribly knowledgeable about SeaBIOS so I'm a bit lost. Could anyone point me where the problem could be originating from? Thanks in advance, Antonello Dettori

2 4

Re: [SeaBIOS] [QUESTION]stuck in SeaBIOS and vm can not be reset any more
by Kevin O'Connor 02 Aug '16

02 Aug '16

On Fri, Jul 29, 2016 at 04:04:59AM +0000, Xulei (Stone) wrote: > Hi, all: > Recently when i try to reset a vm, I find it may be stuck in SeaBIOS. > I use a shell script to continuously reset a vm to see what may happen. > > #!/bin/bash > while((1)) > do > virsh reset VMNAME > sleep 1 > done > > After one day, the vm is stuck. Looking from the following seabios log, > it seems seabios stops at "PCI: Using 00:02.0 for primary VGA", and can > not execute handle_smp() any more. > What may be the reason? More debugging info would be necessary to find this problem. You could try reproducing and attaching gdb ( http://www.seabios.org/Debugging#Debugging_with_gdb_on_QEMU ). Alternatively, a kvm trace log may help. -Kevin

2 1

[QUESTION]stuck in SeaBIOS and vm can not be reset any more
by Xulei (Stone) 29 Jul '16

29 Jul '16

Hi, all: Recently when i try to reset a vm, I find it may be stuck in SeaBIOS. I use a shell script to continuously reset a vm to see what may happen. #!/bin/bash while((1)) do virsh reset VMNAME sleep 1 done After one day, the vm is stuck. Looking from the following seabios log, it seems seabios stops at "PCI: Using 00:02.0 for primary VGA", and can not execute handle_smp() any more. What may be the reason? ============My SeaBIOS log============ 2016-07-26 14:58:49PCI: Using 00:02.0 for primary VGA 2016-07-26 14:58:51In resume (status=0) 2016-07-26 14:58:51In 32bit resume 2016-07-26 14:58:51Attempting a hard reboot 2016-07-26 14:58:51SeaBIOS (version rel-1.9.1-0-gb3ef39f-20160720_133625-HGH1000003484) 2016-07-26 14:58:51BUILD: gcc: (GCC) 4.8.3 20140911 (EulerOS 4.8.3-10) binutils: version 2.23.52.0.1-55 20130226 2016-07-26 14:58:51No Xen hypervisor found. 2016-07-26 14:58:51Running on QEMU (i440fx) 2016-07-26 14:58:51Running on KVM 2016-07-26 14:58:51RamSize: 0xc0000000 [cmos] 2016-07-26 14:58:51Relocating init from 0x000dc320 to 0xbffad7e0 (size 75664) 2016-07-26 14:58:51Found QEMU fw_cfg 2016-07-26 14:58:51QEMU fw_cfg DMA interface supported 2016-07-26 14:58:51RamBlock: addr 0x0000000000000000 len 0x00000000c0000000 [e820] 2016-07-26 14:58:51RamBlock: addr 0x0000000100000000 len 0x0000000040000000 [e820] 2016-07-26 14:58:51Moving pm_base to 0x600 2016-07-26 14:58:51boot order: 2016-07-26 14:58:511: /pci@i0cf8/scsi@4/channel@0/disk@0,0 2016-07-26 14:58:512: HALT 2016-07-26 14:58:51=== PCI bus & bridge init === 2016-07-26 14:58:51PCI: pci_bios_init_bus_rec bus = 0x0 2016-07-26 14:58:51=== PCI device probing === 2016-07-26 14:58:51Found 10 PCI devices (max PCI bus is 00) 2016-07-26 14:58:51=== PCI new allocation pass #1 === 2016-07-26 14:58:51PCI: check devices 2016-07-26 14:58:51=== PCI new allocation pass #2 === 2016-07-26 14:58:51PCI: IO: c000 - c1af 2016-07-26 14:58:51PCI: 32: 00000000c0000000 - 00000000fec00000 2016-07-26 14:58:51PCI: map device bdf=00:1f.0 bar 0, addr 0000c000, size 00000100 [io] 2016-07-26 14:58:51PCI: map device bdf=00:04.0 bar 0, addr 0000c100, size 00000040 [io] 2016-07-26 14:58:51PCI: map device bdf=00:01.2 bar 4, addr 0000c140, size 00000020 [io] 2016-07-26 14:58:51PCI: map device bdf=00:03.0 bar 0, addr 0000c160, size 00000020 [io] 2016-07-26 14:58:51PCI: map device bdf=00:05.0 bar 0, addr 0000c180, size 00000020 [io] 2016-07-26 14:58:51PCI: map device bdf=00:01.1 bar 4, addr 0000c1a0, size 00000010 [io] 2016-07-26 14:58:51PCI: map device bdf=00:03.0 bar 6, addr feb80000, size 00040000 [mem] 2016-07-26 14:58:51PCI: map device bdf=00:02.0 bar 6, addr febc0000, size 00010000 [mem] 2016-07-26 14:58:51PCI: map device bdf=00:02.0 bar 1, addr febd0000, size 00001000 [mem] 2016-07-26 14:58:51PCI: map device bdf=00:03.0 bar 1, addr febd1000, size 00001000 [mem] 2016-07-26 14:58:51PCI: map device bdf=00:04.0 bar 1, addr febd2000, size 00001000 [mem] 2016-07-26 14:58:51PCI: map device bdf=00:05.0 bar 1, addr febd3000, size 00001000 [mem] 2016-07-26 14:58:51PCI: map device bdf=00:02.0 bar 0, addr fc000000, size 02000000 [prefmem] 2016-07-26 14:58:51PCI: init bdf=00:00.0 id=8086:1237 2016-07-26 14:58:51PCI: init bdf=00:01.0 id=8086:7000 2016-07-26 14:58:51PIIX3/PIIX4 init: elcr=00 0c 2016-07-26 14:58:51PCI: init bdf=00:01.1 id=8086:7010 2016-07-26 14:58:51PCI: init bdf=00:01.2 id=8086:7020 2016-07-26 14:58:51PCI: init bdf=00:01.3 id=8086:7113 2016-07-26 14:58:51Using pmtimer, ioport 0x608 2016-07-26 14:58:51PCI: init bdf=00:02.0 id=1013:00b8 2016-07-26 14:58:51PCI: init bdf=00:03.0 id=1af4:1000 2016-07-26 14:58:51PCI: init bdf=00:04.0 id=1af4:1004 2016-07-26 14:58:51PCI: init bdf=00:05.0 id=1af4:1003 2016-07-26 14:58:51PCI: init bdf=00:1f.0 id=1af4:8888 2016-07-26 14:58:51PCI: Using 00:02.0 for primary VGA <---------- stuck here 2016-07-26 14:58:52In resume (status=0) 2016-07-26 14:58:52In 32bit resume 2016-07-26 14:58:53Attempting a hard reboot 2016-07-26 14:58:53SeaBIOS (version rel-1.9.1-0-gb3ef39f-20160720_133625-HGH1000003484) 2016-07-26 14:58:53BUILD: gcc: (GCC) 4.8.3 20140911 (EulerOS 4.8.3-10) binutils: version 2.23.52.0.1-55 20130226 2016-07-26 14:58:53No Xen hypervisor found. 2016-07-26 14:58:53Running on QEMU (i440fx) 2016-07-26 14:58:53Running on KVM 2016-07-26 14:58:53RamSize: 0xc0000000 [cmos] 2016-07-26 14:58:53Relocating init from 0x000dc320 to 0xbffad7e0 (size 75664) 2016-07-26 14:58:53Found QEMU fw_cfg 2016-07-26 14:58:53QEMU fw_cfg DMA interface supported 2016-07-26 14:58:53RamBlock: addr 0x0000000000000000 len 0x00000000c0000000 [e820] 2016-07-26 14:58:53RamBlock: addr 0x0000000100000000 len 0x0000000040000000 [e820] 2016-07-26 14:58:53Moving pm_base to 0x600 2016-07-26 14:58:53boot order: 2016-07-26 14:58:531: /pci@i0cf8/scsi@4/channel@0/disk@0,0 2016-07-26 14:58:532: HALT 2016-07-26 14:58:53=== PCI bus & bridge init === 2016-07-26 14:58:53PCI: pci_bios_init_bus_rec bus = 0x0 2016-07-26 14:58:53=== PCI device probing === 2016-07-26 14:58:53Found 10 PCI devices (max PCI bus is 00) 2016-07-26 14:58:53=== PCI new allocation pass #1 === 2016-07-26 14:58:53PCI: check devices 2016-07-26 14:58:53=== PCI new allocation pass #2 === 2016-07-26 14:58:53PCI: IO: c000 - c1af 2016-07-26 14:58:53PCI: 32: 00000000c0000000 - 00000000fec00000 2016-07-26 14:58:53PCI: map device bdf=00:1f.0 bar 0, addr 0000c000, size 00000100 [io] 2016-07-26 14:58:53PCI: map device bdf=00:04.0 bar 0, addr 0000c100, size 00000040 [io] 2016-07-26 14:58:53PCI: map device bdf=00:01.2 bar 4, addr 0000c140, size 00000020 [io] 2016-07-26 14:58:53PCI: map device bdf=00:03.0 bar 0, addr 0000c160, size 00000020 [io] 2016-07-26 14:58:53PCI: map device bdf=00:05.0 bar 0, addr 0000c180, size 00000020 [io] 2016-07-26 14:58:53PCI: map device bdf=00:01.1 bar 4, addr 0000c1a0, size 00000010 [io] 2016-07-26 14:58:53PCI: map device bdf=00:03.0 bar 6, addr feb80000, size 00040000 [mem] 2016-07-26 14:58:53PCI: map device bdf=00:02.0 bar 6, addr febc0000, size 00010000 [mem] 2016-07-26 14:58:53PCI: map device bdf=00:02.0 bar 1, addr febd0000, size 00001000 [mem] 2016-07-26 14:58:53PCI: map device bdf=00:03.0 bar 1, addr febd1000, size 00001000 [mem] 2016-07-26 14:58:53PCI: map device bdf=00:04.0 bar 1, addr febd2000, size 00001000 [mem] 2016-07-26 14:58:53PCI: map device bdf=00:05.0 bar 1, addr febd3000, size 00001000 [mem] 2016-07-26 14:58:53PCI: map device bdf=00:02.0 bar 0, addr fc000000, size 02000000 [prefmem] 2016-07-26 14:58:53PCI: init bdf=00:00.0 id=8086:1237 2016-07-26 14:58:53PCI: init bdf=00:01.0 id=8086:7000 2016-07-26 14:58:53PIIX3/PIIX4 init: elcr=00 0c 2016-07-26 14:58:53PCI: init bdf=00:01.1 id=8086:7010 2016-07-26 14:58:53PCI: init bdf=00:01.2 id=8086:7020 2016-07-26 14:58:53PCI: init bdf=00:01.3 id=8086:7113 2016-07-26 14:58:53Using pmtimer, ioport 0x608 2016-07-26 14:58:53PCI: init bdf=00:02.0 id=1013:00b8 2016-07-26 14:58:53PCI: init bdf=00:03.0 id=1af4:1000 2016-07-26 14:58:53PCI: init bdf=00:04.0 id=1af4:1004 2016-07-26 14:58:53PCI: init bdf=00:05.0 id=1af4:1003 2016-07-26 14:58:53PCI: init bdf=00:1f.0 id=1af4:8888 2016-07-26 14:58:53PCI: Using 00:02.0 for primary VGA <---- i wait here for 3 days, seabios can not go on 2016-07-29 11:33:56In resume (status=0) 2016-07-29 11:33:56In 32bit resume 2016-07-29 11:33:56Attempting a hard reboot 2016-07-29 11:33:56SeaBIOS (version rel-1.9.1-0-gb3ef39f-20160720_133625-HGH1000003484) 2016-07-29 11:33:56BUILD: gcc: (GCC) 4.8.3 20140911 (EulerOS 4.8.3-10) binutils: version 2.23.52.0.1-55 20130226 2016-07-29 11:33:56No Xen hypervisor found. 2016-07-29 11:33:56Running on QEMU (i440fx) 2016-07-29 11:33:56Running on KVM 2016-07-29 11:33:56RamSize: 0xc0000000 [cmos] 2016-07-29 11:33:56Relocating init from 0x000dc320 to 0xbffad7e0 (size 75664) 2016-07-29 11:33:56Found QEMU fw_cfg 2016-07-29 11:33:56QEMU fw_cfg DMA interface supported 2016-07-29 11:33:56RamBlock: addr 0x0000000000000000 len 0x00000000c0000000 [e820] 2016-07-29 11:33:56RamBlock: addr 0x0000000100000000 len 0x0000000040000000 [e820] 2016-07-29 11:33:56Moving pm_base to 0x600 2016-07-29 11:33:56boot order: 2016-07-29 11:33:561: /pci@i0cf8/scsi@4/channel@0/disk@0,0 2016-07-29 11:33:562: HALT 2016-07-29 11:33:56=== PCI bus & bridge init === 2016-07-29 11:33:56PCI: pci_bios_init_bus_rec bus = 0x0 2016-07-29 11:33:56=== PCI device probing === 2016-07-29 11:33:56Found 10 PCI devices (max PCI bus is 00) 2016-07-29 11:33:56=== PCI new allocation pass #1 === 2016-07-29 11:33:56PCI: check devices 2016-07-29 11:33:56=== PCI new allocation pass #2 === 2016-07-29 11:33:56PCI: IO: c000 - c1af 2016-07-29 11:33:56PCI: 32: 00000000c0000000 - 00000000fec00000 2016-07-29 11:33:56PCI: map device bdf=00:1f.0 bar 0, addr 0000c000, size 00000100 [io] 2016-07-29 11:33:56PCI: map device bdf=00:04.0 bar 0, addr 0000c100, size 00000040 [io] 2016-07-29 11:33:56PCI: map device bdf=00:01.2 bar 4, addr 0000c140, size 00000020 [io] 2016-07-29 11:33:56PCI: map device bdf=00:03.0 bar 0, addr 0000c160, size 00000020 [io] 2016-07-29 11:33:56PCI: map device bdf=00:05.0 bar 0, addr 0000c180, size 00000020 [io] 2016-07-29 11:33:56PCI: map device bdf=00:01.1 bar 4, addr 0000c1a0, size 00000010 [io] 2016-07-29 11:33:56PCI: map device bdf=00:03.0 bar 6, addr feb80000, size 00040000 [mem] 2016-07-29 11:33:56PCI: map device bdf=00:02.0 bar 6, addr febc0000, size 00010000 [mem] 2016-07-29 11:33:56PCI: map device bdf=00:02.0 bar 1, addr febd0000, size 00001000 [mem] 2016-07-29 11:33:56PCI: map device bdf=00:03.0 bar 1, addr febd1000, size 00001000 [mem] 2016-07-29 11:33:56PCI: map device bdf=00:04.0 bar 1, addr febd2000, size 00001000 [mem] 2016-07-29 11:33:56PCI: map device bdf=00:05.0 bar 1, addr febd3000, size 00001000 [mem] 2016-07-29 11:33:56PCI: map device bdf=00:02.0 bar 0, addr fc000000, size 02000000 [prefmem] 2016-07-29 11:33:56PCI: init bdf=00:00.0 id=8086:1237 2016-07-29 11:33:56PCI: init bdf=00:01.0 id=8086:7000 2016-07-29 11:33:56PIIX3/PIIX4 init: elcr=00 0c 2016-07-29 11:33:56PCI: init bdf=00:01.1 id=8086:7010 2016-07-29 11:33:56PCI: init bdf=00:01.2 id=8086:7020 2016-07-29 11:33:56PCI: init bdf=00:01.3 id=8086:7113 2016-07-29 11:33:56Using pmtimer, ioport 0x608 2016-07-29 11:33:56PCI: init bdf=00:02.0 id=1013:00b8 2016-07-29 11:33:56PCI: init bdf=00:03.0 id=1af4:1000 2016-07-29 11:33:56PCI: init bdf=00:04.0 id=1af4:1004 2016-07-29 11:33:56PCI: init bdf=00:05.0 id=1af4:1003 2016-07-29 11:33:56PCI: init bdf=00:1f.0 id=1af4:8888 2016-07-29 11:33:56PCI: Using 00:02.0 for primary VGA -------------- Xulei (Stone)

1 0

[PATCH] vgabios: Simplify scroll logic
by Kevin O'Connor 29 Jul '16

29 Jul '16

Introduce a new function vgafb_scroll() to scroll a window on the screen and update vgabios.c to use only that function for scrolling. This makes the low-level vgafb_move_chars() and vgafb_clear_chars() local to vgafb.c, and it simplifies the callers. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- vgasrc/vgabios.c | 57 ++++++++++++--------------------------------- vgasrc/vgabios.h | 6 ++--- vgasrc/vgafb.c | 70 ++++++++++++++++++++++++++++++++++++++------------------ 3 files changed, 64 insertions(+), 69 deletions(-) diff --git a/vgasrc/vgabios.c b/vgasrc/vgabios.c index cfb6ba2..2c8cc79 100644 --- a/vgasrc/vgabios.c +++ b/vgasrc/vgabios.c @@ -198,15 +198,10 @@ write_teletype(struct cursorpos *pcp, struct carattr ca) if (pcp->y > nbrows) { pcp->y--; - struct cursorpos dest = {0, 0, pcp->page}; - struct cursorpos src = {0, 1, pcp->page}; - struct cursorpos size = {GET_BDA(video_cols), nbrows}; - vgafb_move_chars(dest, src, size); - - struct cursorpos clr = {0, nbrows, pcp->page}; + struct cursorpos win = {0, 0, pcp->page}; + struct cursorpos winsize = {GET_BDA(video_cols), nbrows+1}; struct carattr attr = {' ', 0, 0}; - struct cursorpos clrsize = {GET_BDA(video_cols), 1}; - vgafb_clear_chars(clr, attr, clrsize); + vgafb_scroll(win, winsize, 1, attr); } } @@ -400,6 +395,7 @@ handle_1005(struct bregs *regs) static void verify_scroll(struct bregs *regs, int dir) { + // Verify parameters u8 ulx = regs->cl, uly = regs->ch, lrx = regs->dl, lry = regs->dh; u16 nbrows = GET_BDA(video_rows) + 1; if (lry >= nbrows) @@ -410,41 +406,16 @@ verify_scroll(struct bregs *regs, int dir) int wincols = lrx - ulx + 1, winrows = lry - uly + 1; if (wincols <= 0 || winrows <= 0) return; - - u8 page = GET_BDA(video_page); - int clearlines = regs->al, movelines = winrows - clearlines; - if (!clearlines || movelines <= 0) { - // Clear whole area. - struct cursorpos clr = {ulx, uly, page}; - struct carattr attr = {' ', regs->bh, 1}; - struct cursorpos clrsize = {wincols, winrows}; - vgafb_clear_chars(clr, attr, clrsize); - return; - } - - if (dir > 0) { - // Normal scroll - struct cursorpos dest = {ulx, uly, page}; - struct cursorpos src = {ulx, uly + clearlines, page}; - struct cursorpos size = {wincols, movelines}; - vgafb_move_chars(dest, src, size); - - struct cursorpos clr = {ulx, uly + movelines, page}; - struct carattr attr = {' ', regs->bh, 1}; - struct cursorpos clrsize = {wincols, clearlines}; - vgafb_clear_chars(clr, attr, clrsize); - } else { - // Scroll down - struct cursorpos dest = {ulx, uly + clearlines, page}; - struct cursorpos src = {ulx, uly, page}; - struct cursorpos size = {wincols, movelines}; - vgafb_move_chars(dest, src, size); - - struct cursorpos clr = {ulx, uly, page}; - struct carattr attr = {' ', regs->bh, 1}; - struct cursorpos clrsize = {wincols, clearlines}; - vgafb_clear_chars(clr, attr, clrsize); - } + int lines = regs->al; + if (lines >= winrows) + lines = 0; + lines *= dir; + + // Scroll (or clear) window + struct cursorpos win = {ulx, uly, GET_BDA(video_page)}; + struct cursorpos winsize = {wincols, winrows}; + struct carattr attr = {' ', regs->bh, 1}; + vgafb_scroll(win, winsize, lines, attr); } static void diff --git a/vgasrc/vgabios.h b/vgasrc/vgabios.h index 831f694..9fbfb14 100644 --- a/vgasrc/vgabios.h +++ b/vgasrc/vgabios.h @@ -126,10 +126,8 @@ extern struct video_func_static static_functionality; void init_gfx_op(struct gfx_op *op, struct vgamode_s *vmode_g); void handle_gfx_op(struct gfx_op *op); void *text_address(struct cursorpos cp); -void vgafb_move_chars(struct cursorpos dest - , struct cursorpos src, struct cursorpos movesize); -void vgafb_clear_chars(struct cursorpos dest - , struct carattr ca, struct cursorpos movesize); +void vgafb_scroll(struct cursorpos win, struct cursorpos winsize + , int lines, struct carattr ca); void vgafb_write_char(struct cursorpos cp, struct carattr ca); struct carattr vgafb_read_char(struct cursorpos cp); void vgafb_write_pixel(u8 color, u16 x, u16 y); diff --git a/vgasrc/vgafb.c b/vgasrc/vgafb.c index 58c60ad..bd1c8dd 100644 --- a/vgasrc/vgafb.c +++ b/vgasrc/vgafb.c @@ -346,7 +346,7 @@ handle_gfx_op(struct gfx_op *op) // Move characters when in graphics mode. static void gfx_move_chars(struct vgamode_s *vmode_g, struct cursorpos dest - , struct cursorpos src, struct cursorpos movesize) + , struct cursorpos movesize, int lines) { struct gfx_op op; init_gfx_op(&op, vmode_g); @@ -355,23 +355,23 @@ gfx_move_chars(struct vgamode_s *vmode_g, struct cursorpos dest int cheight = GET_BDA(char_height); op.y = dest.y * cheight; op.ylen = movesize.y * cheight; - op.srcy = src.y * cheight; + op.srcy = op.y + lines * cheight; op.op = GO_MEMMOVE; handle_gfx_op(&op); } // Clear area of screen in graphics mode. static void -gfx_clear_chars(struct vgamode_s *vmode_g, struct cursorpos dest - , struct carattr ca, struct cursorpos clearsize) +gfx_clear_chars(struct vgamode_s *vmode_g, struct cursorpos win + , struct cursorpos winsize, struct carattr ca) { struct gfx_op op; init_gfx_op(&op, vmode_g); - op.x = dest.x * 8; - op.xlen = clearsize.x * 8; + op.x = win.x * 8; + op.xlen = winsize.x * 8; int cheight = GET_BDA(char_height); - op.y = dest.y * cheight; - op.ylen = clearsize.y * cheight; + op.y = win.y * cheight; + op.ylen = winsize.y * cheight; op.pixels[0] = ca.attr; if (vga_emulate_text()) op.pixels[0] = ca.attr >> 4; @@ -580,45 +580,71 @@ text_address(struct cursorpos cp) } // Move characters on screen. -void -vgafb_move_chars(struct cursorpos dest - , struct cursorpos src, struct cursorpos movesize) +static void +vgafb_move_chars(struct cursorpos dest, struct cursorpos movesize, int lines) { struct vgamode_s *vmode_g = get_current_mode(); if (!vmode_g) return; - vgafb_set_swcursor(0); if (GET_GLOBAL(vmode_g->memmodel) != MM_TEXT) { - gfx_move_chars(vmode_g, dest, src, movesize); + gfx_move_chars(vmode_g, dest, movesize, lines); return; } int stride = GET_BDA(video_cols) * 2; - memmove_stride(GET_GLOBAL(vmode_g->sstart) - , text_address(dest), text_address(src) + void *dest_addr = text_address(dest), *src_addr = dest_addr + lines * stride; + memmove_stride(GET_GLOBAL(vmode_g->sstart), dest_addr, src_addr , movesize.x * 2, stride, movesize.y); } // Clear area of screen. -void -vgafb_clear_chars(struct cursorpos dest - , struct carattr ca, struct cursorpos clearsize) +static void +vgafb_clear_chars(struct cursorpos win, struct cursorpos winsize + , struct carattr ca) { struct vgamode_s *vmode_g = get_current_mode(); if (!vmode_g) return; - vgafb_set_swcursor(0); if (GET_GLOBAL(vmode_g->memmodel) != MM_TEXT) { - gfx_clear_chars(vmode_g, dest, ca, clearsize); + gfx_clear_chars(vmode_g, win, winsize, ca); return; } int stride = GET_BDA(video_cols) * 2; u16 attr = ((ca.use_attr ? ca.attr : 0x07) << 8) | ca.car; - memset16_stride(GET_GLOBAL(vmode_g->sstart), text_address(dest), attr - , clearsize.x * 2, stride, clearsize.y); + memset16_stride(GET_GLOBAL(vmode_g->sstart), text_address(win), attr + , winsize.x * 2, stride, winsize.y); +} + +// Scroll characters within a window on the screen +void +vgafb_scroll(struct cursorpos win, struct cursorpos winsize + , int lines, struct carattr ca) +{ + vgafb_set_swcursor(0); + if (!lines) { + // Clear window + vgafb_clear_chars(win, winsize, ca); + } else if (lines > 0) { + // Scroll the window up (eg, from page down key) + winsize.y -= lines; + vgafb_move_chars(win, winsize, lines); + + win.y += winsize.y; + winsize.y = lines; + vgafb_clear_chars(win, winsize, ca); + } else { + // Scroll the window down (eg, from page up key) + win.y -= lines; + winsize.y += lines; + vgafb_move_chars(win, winsize, lines); + + win.y += lines; + winsize.y = -lines; + vgafb_clear_chars(win, winsize, ca); + } } // Write a character to the screen. -- 2.5.5

1 1

Re: [SeaBIOS] How CPU executes bios code before copying bios to shadow ram?
by Kevin O'Connor 26 Jul '16

26 Jul '16

On Tue, Jul 26, 2016 at 03:02:02PM +0800, Li Wang wrote: > Hi all, > I am reading seaBios code, and I have a question about the shadow memory > copy part. In fw/shadow.c:make_bios_writable_intel() reads pam0 to see if > shadow memory is already readable (if pam0's fourth bit is set), if pam0 > shows shadow memory is not readable running __make_bios_writable_intel from > high-memory flash location (statements marked green below). > But in my understanding the entry point of bios is 0xffff:fff0, then it > jumps to 0xf000:e05b, which points to memory space in shadowing, but before > __make_bios_writable_intel copying bios from high-memory flash to shadow > memory, shadow memory is disabled, so these codes are forwarded to > high-memory flash, including code to read pam0 before invoking > __make_bios_writable_intel (statement marked red below). Why these codes > are not relocate to high-memory flash, but only the invocation of > __make_bios_writable_intel is need to be relocated? > If shadow ram is present and readable, how cpu execute bios codes in > 0xf000:xxxx before copying them to shadow ram? This code only runs on QEMU and is very specific to the quirky way that QEMU implements the pam registers. When emulation starts, QEMU places a read-only copy of the code in 0xe0000-0x100000. When SeaBIOS requests that 0xc0000-0x100000 be read/writable ram by writing to the pam registers in __make_bios_writable_intel(), then qemu converts the region to uninitialized memory. This is why __make_bios_writable_intel() needs to run from the copy of the code in the "flash" location at the end of the first 4Gig of ram. The make_bios_writable_intel() code can run in 0xe0000-0x100000 because prior to __make_bios_writable_intel() QEMU places a read-only copy of the code there and after __make_bios_writable_intel() SeaBIOS has restored the code by copying the code back to that ram. -Kevin

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS