SeaBIOS

seabios@seabios.org

3806 discussions

Regarding the contribution to the seabios project
by Aditya Patil 07 Nov '23

07 Nov '23

I am attaching the patch with this email. The fixes were about the code optimizations in the Python scripts. These were mainly about file handling and this patch addresses the issues with file handling. Some of the files that were opened by the script were not closed. There has been an addition to the code optimization by using "with" statements providing more readable code.

2 2

Git Not working?
by Pvt Snafu 07 Nov '23

07 Nov '23

I started getting intermittent 502 server errors last week when I checked for updates. Now I'm consistently getting them. Is the server misconfigured or failed? Does it need to be reset? Using https://git.seabios.org/seabios.git/ as my origin. If I check https://git.seabios.org/ in my browser, it redirects to coreboot.org and says to clone from ssh://review.coreboot.org:29418/seabios, but when I do that, it starts complaining about not having the key (I guess the ssh server mirror isn't configged for public access?) I'm not trying to submit anything, just looking to keep my repo up to date.

2 1

new release tag?
by Niklas Cassel 12 Sep '23

12 Sep '23

Hello Seabios maintainers, I was wondering, is there any chance of getting a new release tag (e.g. rel-1.16.3) anytime soon? Or is there any plan on when it will be tagged? I'm waiting to send out a (AHCI specific) QEMU patch, but I can't do so until: 1) there is a new Seabios tag 2) QEMU has updated to the latest Seabios release tag No trying to stress anyone, just looking forward to cross things from my todo list :) Kind regards, Niklas

2 3

Malloc Question
by Kieran Kunhya 11 Sep '23

11 Sep '23

Hello, I'm trying to update this patch for 2017 as I have the same issue as the author in that I can't use the KVM virtual keyboard and a physical keyboard at the same time: https://patchew.org/Seabios/20171215100946.58298-1-stef.van.os@prodrive-tec… I have implemented a linked list as recommended but this has not worked as expected. Assuming I have not made an obvious mistake, I think maybe this patch is not working because I'm using the wrong malloc. Which one should I be using? Thanks for your help. Regards, Kieran Kunhya

3 3

[PATCH] add multiple usb-hid support
by Kieran Kunhya 11 Sep '23

11 Sep '23

Based on a patch from Stef van Os --- src/hw/usb-hid.c | 49 +++++++++++++++++++++++++++++++++++++----------- 1 file changed, 38 insertions(+), 11 deletions(-) diff --git a/src/hw/usb-hid.c b/src/hw/usb-hid.c index dec198a..62c046a 100644 --- a/src/hw/usb-hid.c +++ b/src/hw/usb-hid.c @@ -11,8 +11,14 @@ #include "usb.h" // usb_ctrlrequest #include "usb-hid.h" // usb_keyboard_setup #include "util.h" // process_key +#include "malloc.h" // malloc_low -struct usb_pipe *keyboard_pipe VARFSEG; +struct keyboard_list { + struct usb_pipe *keyboard_pipe; + struct keyboard_list *next; +}; + +struct keyboard_list *keyboard_list VARFSEG; struct usb_pipe *mouse_pipe VARFSEG; @@ -62,11 +68,13 @@ static int usb_kbd_setup(struct usbdevice_s *usbdev , struct usb_endpoint_descriptor *epdesc) { + int kbd_idx = 0; + struct usb_pipe *keyboard_pipe; + struct keyboard_list *prev; + struct keyboard_list *end; + if (! CONFIG_USB_KEYBOARD) return -1; - if (keyboard_pipe) - // XXX - this enables the first found keyboard (could be random) - return -1; if (epdesc->wMaxPacketSize < sizeof(struct keyevent) || epdesc->wMaxPacketSize > MAX_KBD_EVENT) { @@ -91,7 +99,26 @@ usb_kbd_setup(struct usbdevice_s *usbdev if (!keyboard_pipe) return -1; - dprintf(1, "USB keyboard initialized\n"); + prev = end = GET_GLOBAL(keyboard_list); + while (end) { + prev = end; + end = end->next; + kbd_idx++; + } + + end = malloc_low(sizeof(*end)); + if (!end) + return -1; + + end->keyboard_pipe = keyboard_pipe; + end->next = NULL; + + if (!prev) + keyboard_list = end; + else + prev->next = end; + + dprintf(1, "USB keyboard %d initialized\n", kbd_idx); return 0; } @@ -321,13 +348,10 @@ handle_key(struct keyevent *data) // Check if a USB keyboard event is pending and process it if so. static void -usb_check_key(void) +usb_check_key(struct usb_pipe *pipe) { if (! CONFIG_USB_KEYBOARD) return; - struct usb_pipe *pipe = GET_GLOBAL(keyboard_pipe); - if (!pipe) - return; for (;;) { u8 data[MAX_KBD_EVENT]; @@ -344,7 +368,7 @@ usb_kbd_active(void) { if (! CONFIG_USB_KEYBOARD) return 0; - return GET_GLOBAL(keyboard_pipe) != NULL; + return GET_GLOBAL(keyboard_list) != NULL; } // Handle a ps2 style keyboard command. @@ -451,6 +475,9 @@ usb_mouse_command(int command, u8 *param) void usb_check_event(void) { - usb_check_key(); + struct keyboard_list *kbd_list = GET_GLOBAL(keyboard_list); + + for(; kbd_list != NULL; kbd_list = kbd_list->next) + usb_check_key(kbd_list->keyboard_pipe); usb_check_mouse(); } -- 2.25.1

2 1

[PATCH v4 0/6] misc tweaks for kvm and the 64bit pci window
by Gerd Hoffmann 11 Sep '23

11 Sep '23

v4 changes: - fix handling of 32bit memory bars. v3 changes: - rename variables, use u8 for CPULongMode. v2 changes: - e820 conflict fix Gerd Hoffmann (6): better kvm detection detect physical address space size move 64bit pci window to end of address space be less conservative with the 64bit pci io window qemu: log reservations in fw_cfg e820 table check for e820 conflict src/e820map.h | 1 + src/fw/paravirt.h | 2 ++ src/e820map.c | 15 ++++++++ src/fw/paravirt.c | 89 +++++++++++++++++++++++++++++++++++++++++------ src/fw/pciinit.c | 26 +++++++++++--- 5 files changed, 119 insertions(+), 14 deletions(-) -- 2.41.0

2 8

[PATCH v3 0/3] esp-scsi: fix reliance on QEMU ESP SCSI implementation bugs
by Mark Cave-Ayland 24 Aug '23

24 Aug '23

Whilst trying to improve QEMU's ESP SCSI implementation with regard to the NCR datasheet, I noticed that SeaBIOS would fail to boot one of my Debian test images with my patches applied. Further investigation revealed that the SeaBIOS esp-scsi driver inadvertently relies on existing bugs in QEMU's ESP SCSI emulation to work correctly, so this series changes the driver to work as described in the NCR datasheet. With this series applied it is possible for the updated SeaBIOS to boot both QEMU current git HEAD as well as my local WIP branch containing various fixes and improvements to QEMU's ESP SCSI emulation. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)ilande.co.uk> v3: - Add R-B tags for patches 1 and 2 from Paolo - Add patch 3 to handle another bug to be fixed in QEMU's ESP emulation v2: - Fix typo in patch 2 commit message - Add reference to datasheet in patch 2 commit message as requested by Paul Mark Cave-Ayland (3): esp-scsi: flush FIFO before sending SCSI command esp-scsi: check for INTR_BS/INTR_FC instead of STAT_TC for command completion esp-scsi: handle non-DMA SCSI commands with no data phase src/hw/esp-scsi.c | 49 +++++++++++++++++++++++++++++++++-------------- 1 file changed, 35 insertions(+), 14 deletions(-) -- 2.39.2

3 5

[Increase BUILD_MAX_E820 to 128] Increase BUILD_MAX_E820 to 128
by Tony Titus 24 Aug '23

24 Aug '23

For platforms with high number of numa nodes, 32 e820 entries are not enough. Linux kernel sets the maximum e820 entries to a base value of 128. Setting BUILD_MAX_E820 to 128 to be in sync with this base value. Signed-off-by: Tony Titus <tonydt(a)amazon.com> --- src/config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/config.h b/src/config.h index 9abe355..16952eb 100644 --- a/src/config.h +++ b/src/config.h @@ -15,7 +15,7 @@ #define BUILD_APPNAME4 "BXPC" // Maximum number of map entries in the e820 map -#define BUILD_MAX_E820 32 +#define BUILD_MAX_E820 128 // Space to reserve in high-memory for tables #define BUILD_MIN_HIGHTABLE (256*1024) #define BUILD_MAX_HIGHTABLE (16*1024*1024) -- 2.40.1

2 1

[PATCH v2 0/2] esp-scsi: fix reliance on QEMU ESP SCSI implementation bugs
by Mark Cave-Ayland 07 Aug '23

07 Aug '23

Whilst trying to improve QEMU's ESP SCSI implementation with regard to the NCR datasheet, I noticed that SeaBIOS would fail to boot one of my Debian test images with my patches applied. Further investigation revealed that the SeaBIOS esp-scsi driver inadvertently relies on existing bugs in QEMU's ESP SCSI emulation to work correctly, so this series changes the driver to work as described in the NCR datasheet. With this series applied it is possible for the updated SeaBIOS to boot both QEMU current git HEAD as well as my local WIP branch containing various fixes and improvements to QEMU's ESP SCSI emulation. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)ilande.co.uk> v2: - Fix typo in patch 2 commit message - Add reference to datasheet in patch 2 commit message as requested by Paul Mark Cave-Ayland (2): esp-scsi: flush FIFO before sending SCSI command esp-scsi: check for INTR_BS/INTR_FC instead of STAT_TC for command completion src/hw/esp-scsi.c | 38 +++++++++++++++++++++++++------------- 1 file changed, 25 insertions(+), 13 deletions(-) -- 2.39.2

3 5

[PATCH 0/2] esp-scsi: fix reliance on QEMU ESP SCSI implementation bugs
by Mark Cave-Ayland 02 Aug '23

02 Aug '23

Whilst trying to improve QEMU's ESP SCSI implementation with regard to the NCR datasheet, I noticed that SeaBIOS would fail to boot one of my Debian test images with my patches applied. Further investigation revealed that the SeaBIOS esp-scsi driver inadvertently relies on existing bugs in QEMU's ESP SCSI emulation to work correctly, so this series changes the driver to work as described in the NCR datasheet. With this series applied it is possible for the updated SeaBIOS to boot both QEMU current git HEAD as well as my local WIP branch containing various fixes and improvements to QEMU's ESP SCSI emulation. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)ilande.co.uk> Mark Cave-Ayland (2): esp-scsi: flush FIFO before sending SCSI command esp-scsi: check for INTR_BS/INTR_FC instead of STAT_TC for command completion src/hw/esp-scsi.c | 38 +++++++++++++++++++++++++------------- 1 file changed, 25 insertions(+), 13 deletions(-) -- 2.30.2

3 7

← Newer
1
...
5
6
7
8
9
10
11
...
381
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS