SeaBIOS

seabios@seabios.org

3770 discussions

[PATCH] Fix high memory zone initialization in CSM mode
by José Martínez 13 Jun '23

13 Jun '23

malloc_high() cannot allocate any memory in CSM mode due to an empty ZoneHigh. SeaBIOS cannot find any disk to boot from because device initialization fails. The bug was introduced in 1.16.1 (commit dc88f9b) when the meaning of BUILD_MAX_HIGHTABLE changed but CSM code was not updated. This patch reverts to the previous behavior by using BUILD_MIN_HIGHTABLE in CSM methods. Signed-off-by: José Martínez <xose(a)google.com> --- src/fw/csm.c | 4 ++-- src/malloc.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/fw/csm.c b/src/fw/csm.c index bc14a92..579debd 100644 --- a/src/fw/csm.c +++ b/src/fw/csm.c @@ -150,9 +150,9 @@ handle_csm_0002(struct bregs *regs) for (i=0; i < csm_compat_table.E820Length / sizeof(struct e820entry); i++) e820_add(p[i].start, p[i].size, p[i].type); - if (csm_init_table->HiPmmMemorySizeInBytes > BUILD_MAX_HIGHTABLE) { + if (csm_init_table->HiPmmMemorySizeInBytes > BUILD_MIN_HIGHTABLE) { u32 hi_pmm_end = csm_init_table->HiPmmMemory + csm_init_table->HiPmmMemorySizeInBytes; - e820_add(hi_pmm_end - BUILD_MAX_HIGHTABLE, BUILD_MAX_HIGHTABLE, E820_RESERVED); + e820_add(hi_pmm_end - BUILD_MIN_HIGHTABLE, BUILD_MIN_HIGHTABLE, E820_RESERVED); } // For PCIBIOS 1ab10e diff --git a/src/malloc.c b/src/malloc.c index da84098..30b2c92 100644 --- a/src/malloc.c +++ b/src/malloc.c @@ -460,10 +460,10 @@ malloc_csm_preinit(u32 low_pmm, u32 low_pmm_size, u32 hi_pmm, u32 hi_pmm_size) { ASSERT32FLAT(); - if (hi_pmm_size > BUILD_MAX_HIGHTABLE) { + if (hi_pmm_size > BUILD_MIN_HIGHTABLE) { u32 hi_pmm_end = hi_pmm + hi_pmm_size; - alloc_add(&ZoneTmpHigh, hi_pmm, hi_pmm_end - BUILD_MAX_HIGHTABLE); - alloc_add(&ZoneHigh, hi_pmm_end - BUILD_MAX_HIGHTABLE, hi_pmm_end); + alloc_add(&ZoneTmpHigh, hi_pmm, hi_pmm_end - BUILD_MIN_HIGHTABLE); + alloc_add(&ZoneHigh, hi_pmm_end - BUILD_MIN_HIGHTABLE, hi_pmm_end); } else { alloc_add(&ZoneTmpHigh, hi_pmm, hi_pmm + hi_pmm_size); } -- 2.40.1.606.ga4b1b128d6-goog

3 3

Need Easy Instructions For Installing SeaBIOS
by Ratchet Meister 28 May '23

28 May '23

...on a Chromebook. I have an Acer c740 - C4Pe, and I have already removed the WP screw and swapped out the 16GB SSD for 128GB and returned the outdated Chrome OS via USB flash drive. Now, I've been reading and watching video tutorials to get up the nerve to install this new BIOS, as I'd like to run another OS without installing and to use an external hard drive that's fully loaded with the latest version of Mint Cinnamon. I've come to the conclusion that there may be updates that won't allow me to use the Linux Developers Environment -- that never made it. Mine stopped in June of 2021. I'm having some difficulty installing with the easiest of commands. I can enter the Linux Environment and it looks like it's working, but then there are messages at the end that will say that something isn't signed, or it's old suite and other things. Help. Jane P.

1 0

[PATCH v3 0/6] misc tweaks for kvm and the 64bit pci window
by Gerd Hoffmann 16 May '23

16 May '23

v3 changes: - rename variables, use u8 for CPULongMode. v2 changes: - e820 conflict fix Gerd Hoffmann (6): better kvm detection detect physical address space size move 64bit pci window to end of address space be less conservative with the 64bit pci io window qemu: log reservations in fw_cfg e820 table check for e820 conflict src/e820map.h | 1 + src/fw/paravirt.h | 2 ++ src/e820map.c | 15 +++++++++ src/fw/paravirt.c | 86 ++++++++++++++++++++++++++++++++++++++++++----- src/fw/pciinit.c | 20 ++++++++++- 5 files changed, 114 insertions(+), 10 deletions(-) -- 2.40.1

3 9

[PATCH] disable array bounds warning
by Gerd Hoffmann 16 May '23

16 May '23

The segmented pointer casting magic confuses gcc, recent versions throw array bound warnings. Disable the warning. Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index c108f87de768..d3341870a760 100644 --- a/Makefile +++ b/Makefile @@ -71,6 +71,7 @@ COMMONCFLAGS += $(call cc-option,$(CC),-fno-stack-protector,) COMMONCFLAGS += $(call cc-option,$(CC),-fno-stack-protector-all,) COMMONCFLAGS += $(call cc-option,$(CC),-fstack-check=no,) COMMONCFLAGS += $(call cc-option,$(CC),-Wno-address-of-packed-member,) +COMMONCFLAGS += $(call cc-option,$(CC),-Wno-array-bounds,) COMMONCFLAGS += $(call cc-option,$(CC),-fcf-protection=none,) COMMA := , -- 2.40.1

2 2

[PATCH 0/2] print some errors to the screen
by Gerd Hoffmann 10 May '23

10 May '23

Gerd Hoffmann (2): add hwerr_printf function for threads display error message for blocksizes != 512 src/output.h | 5 +++++ src/hw/blockcmd.c | 2 +- src/hw/virtio-blk.c | 4 ++-- src/output.c | 17 +++++++++++++++++ src/post.c | 4 ++++ 5 files changed, 29 insertions(+), 3 deletions(-) -- 2.40.1

2 5

[PATCH v2 0/6] misc tweaks for kvm and the 64bit pci window
by Gerd Hoffmann 04 May '23

04 May '23

v2 changes: - e820 conflict fix Gerd Hoffmann (6): better kvm detection detect physical address space size move 64bit pci window to end of address space be less conservative with the 64bit pci io window qemu: log reservations in fw_cfg e820 table check for e820 conflict src/e820map.h | 1 + src/fw/paravirt.h | 2 ++ src/e820map.c | 15 +++++++++ src/fw/paravirt.c | 86 ++++++++++++++++++++++++++++++++++++++++++----- src/fw/pciinit.c | 20 ++++++++++- 5 files changed, 114 insertions(+), 10 deletions(-) -- 2.40.1

2 7

Large 32 bit BAR's
by Wannes Bouwen (Nokia) 14 Apr '23

14 Apr '23

Hello, I'm running a x86 QEMU with Ubuntu. On this system we want to emulate a PCIe device which contains a large 32-bit BAR (2 GiB). This is not working and I get following error: SeaBIOS (version rel-1.14.0-0-g155821a-20210629_105355-sharpie) BUILD: gcc: (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36) binutils: version 2.27-34.base.el7 No Xen hypervisor found. Running on QEMU (q35) Running on KVM Found QEMU fw_cfg QEMU fw_cfg DMA interface supported qemu/e820: addr 0x0000000000000000 len 0x0000000080000000 [RAM] qemu/e820: addr 0x0000000100000000 len 0x0000000180000000 [RAM] Relocating init from 0x000d4de0 to 0x7ffa9420 (size 93008) Moving pm_base to 0x600 kvmclock: at 0xeb040 (msr 0x4b564d01) kvmclock: stable tsc, 2992 MHz CPU Mhz=2992 (kvmclock) === PCI bus & bridge init === PCI: pci_bios_init_bus_rec bus = 0x0 PCI: pci_bios_init_bus_rec bdf = 0x20 PCI: primary bus = 0x0 PCI: secondary bus = 0xff -> 0x1 PCI: pci_bios_init_bus_rec bus = 0x1 PCI: subordinate bus = 0x0 -> 0x1 === PCI device probing === Found 12 PCI devices (max PCI bus is 01) PCIe: using q35 mmconfig at 0xb0000000 === PCI new allocation pass #1 === PCI: check devices PCI: secondary bus 1 size 00000000 type io PCI: secondary bus 1 size 100000000 type mem PCI: secondary bus 1 size 100000000 type prefmem === PCI new allocation pass #2 === PCI: IO: c000 - c0ff PCI: 32: 00000000c0000000 - 00000000fec00000 PCI: out of 32bit address space I've had a look at the code and it seems that 32-bit BAR's have a limited memory region available (less than 1 GiB). Is there a possibility to use such large 32-bit BAR's in combination with SeaBios by e.g. mapping them in the higher memory region where 64-bit BAR's are mapped? Thanks in advance! Kind regards, Wannes

4 8

[SeaBIOS PATCH] xen: require Xen info structure at 0x1000 to detect Xen
by David Woodhouse 16 Mar '23

16 Mar '23

From: David Woodhouse <dwmw(a)amazon.co.uk> When running under Xen, hvmloader places a table at 0x1000 with the e820 information and BIOS tables. If this isn't present, SeaBIOS will currently panic. We now have support for running Xen guests natively in QEMU/KVM, which boots SeaBIOS directly instead of via hvmloader, and does not provide the same structure. As it happens, this doesn't matter on first boot. because although we set PlatformRunningOn to PF_QEMU|PF_XEN, reading it back again still gives zero. Presumably because in true Xen, this is all already RAM. But in QEMU with a faithfully-emulated PAM config in the host bridge, it's still in ROM mode at this point so we don't see what we've just written. On reboot, however, the region *is* set to RAM mode and we do see the updated value of PlatformRunningOn, do manage to remember that we've detected Xen in CPUID, and hit the panic. It's not trivial to detect QEMU vs. real Xen at the time xen_preinit() runs, because it's so early. We can't even make a XENVER_extraversion hypercall to look for hints, because we haven't set up the hypercall page (and don't have an allocator to give us a page in which to do so). So just make Xen detection contingent on the info structure being present. If it wasn't, we were going to panic anyway. That leaves us taking the standard QEMU init path for Xen guests in native QEMU, which is just fine. Untested on actual Xen but ObviouslyCorrect™. Signed-off-by: David Woodhouse <dwmw(a)amazon.co.uk> --- src/fw/xen.c | 45 ++++++++++++++++++++++++++++++++------------- 1 file changed, 32 insertions(+), 13 deletions(-) diff --git a/src/fw/xen.c b/src/fw/xen.c index a215b9e..00e4b0c 100644 --- a/src/fw/xen.c +++ b/src/fw/xen.c @@ -40,16 +40,25 @@ struct xen_seabios_info { u32 e820_nr; } PACKED; -static void validate_info(struct xen_seabios_info *t) +static struct xen_seabios_info *validate_info(void) { - if ( memcmp(t->signature, "XenHVMSeaBIOS", 14) ) - panic("Bad Xen info signature\n"); + struct xen_seabios_info *t = (void *)INFO_PHYSICAL_ADDRESS; - if ( t->length < sizeof(struct xen_seabios_info) ) - panic("Bad Xen info length\n"); + if ( memcmp(t->signature, "XenHVMSeaBIOS", 14) ) { + dprintf(1, "Bad Xen info signature\n"); + return NULL; + } + + if ( t->length < sizeof(struct xen_seabios_info) ) { + dprintf(1, "Bad Xen info length\n"); + return NULL; + } - if (checksum(t, t->length) != 0) - panic("Bad Xen info checksum\n"); + if (checksum(t, t->length) != 0) { + dprintf(1, "Bad Xen info checksum\n"); + return NULL; + } + return t; } void xen_preinit(void) @@ -86,7 +95,10 @@ void xen_preinit(void) dprintf(1, "No Xen hypervisor found.\n"); return; } - PlatformRunningOn = PF_QEMU|PF_XEN; + if (validate_info()) + PlatformRunningOn = PF_QEMU|PF_XEN; + else + dprintf(1, "Not enabling Xen support due to lack of Xen info\n"); } static int hypercall_xen_version( int cmd, void *arg) @@ -122,10 +134,14 @@ void xen_hypercall_setup(void) void xen_biostable_setup(void) { - struct xen_seabios_info *info = (void *)INFO_PHYSICAL_ADDRESS; - void **tables = (void*)info->tables; + struct xen_seabios_info *info = validate_info(); + void **tables; int i; + if (!info) + panic("Xen info corrupted\n"); + + tables = (void*)info->tables; dprintf(1, "xen: copy BIOS tables...\n"); for (i=0; i<info->tables_nr; i++) copy_table(tables[i]); @@ -136,12 +152,15 @@ void xen_biostable_setup(void) void xen_ramsize_preinit(void) { int i; - struct xen_seabios_info *info = (void *)INFO_PHYSICAL_ADDRESS; - struct e820entry *e820 = (struct e820entry *)info->e820; - validate_info(info); + struct xen_seabios_info *info = validate_info(); + struct e820entry *e820; + + if (!info) + panic("Xen info corrupted\n"); dprintf(1, "xen: copy e820...\n"); + e820 = (struct e820entry *)info->e820; for (i = 0; i < info->e820_nr; i++) { struct e820entry *e = &e820[i]; e820_add(e->start, e->size, e->type); -- 2.34.1

4 8

[PATCH] Fix Bay Trail Chromebook Bootup
by Christopher Lentocha 15 Feb '23

15 Feb '23

on MrChromebox's Custom Firmware while using the SeaBios payload with MrChromebox's SMM variable in coreboot. This is required even if we are booting off of a USB, since it will give MMC errors in Linux and Windows 10 won't see it. See comments and code in ./src/boot.c for more information. Signed-off-by: Christopher Lentocha <christopherericlentocha(a)gmail.com> --- src/boot.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/boot.c b/src/boot.c index 1effd80..8433f51 100644 --- a/src/boot.c +++ b/src/boot.c @@ -871,6 +871,21 @@ call_boot_entry(struct segoff_s bootsegip, u8 bootdrv) // Set the magic number in ax and the boot drive in dl. br.dl = bootdrv; br.ax = 0xaa55; + // Fix Bay Trail Chromebook Bootup + // on MrChromebox's Custom Firmware + // while using the SeaBios payload + // with MrChromebox's SMM variable in coreboot. + // This is required even if we are booting off of a USB, + // since it will give MMC errors in Linux and Windows 10 + // won't see it. + outb(0xcd, 0xb2); + // Don't Add the line above this comment to CBFS booting, + // because EDK2 as 2nd payload breaks, + // since its already being applied there too, + // and we should expect all CBFS payloads in ROM to do + // what we are doing here. + // The same bug is also in EDK2, so this line would need to be + // added in a similar way for EDK2 code. farcall16(&br); } -- 2.35.1

5 4

SeaBIOS 1.16.1 release
by Marek Marczykowski-Górecki 03 Feb '23

03 Feb '23

Hello, I see rel-1.16.1 tag on https://review.coreboot.org/plugins/gitiles/seabios/, but that's about the only place where it's visible - no tarball, no info on https://www.seabios.org/Releases etc. Is 1.16.1 an actual release? -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab

2 1

← Newer
1
2
3
4
5
6
7
8
9
...
377
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS