SeaBIOS

seabios@seabios.org

3 participants
3801 discussions

Re: [SeaBIOS] [PATCH RFC 3/7] Add configuration menu for the VGA ROM
by Kevin O'Connor 17 Dec '11

17 Dec '11

On Sat, Dec 17, 2011 at 04:22:01PM +0000, Julian Pidancet wrote: > On Sat, Dec 17, 2011 at 4:07 PM, Kevin O'Connor <kevin(a)koconnor.net> wrote: > > struct pci_data rom_pci_data VAR16VISIBLE = { > > .vendor = CONFIG_VGA_VID, > > .device = CONFIG_VGA_DID, > > .dlen = 0x18, > > .class_hi = 0x300, > > ... > > }; > > > > The PCI firmware specification only requires the PCI header to be > located in the first 64KB of the option ROM image, I don't know if > there's a way we can enforce that if it is declared in C. If the option rom is over 64K, then things will break anyway as the code is all 16bit and there are no provisions for far jumping. -Kevin

1 0

Re: [SeaBIOS] [patch] Skip the bootmenu if only one device is found
by Kevin O'Connor 17 Dec '11

17 Dec '11

On Fri, Dec 16, 2011 at 03:29:17PM -0700, Marc Jones wrote: > The bootmenu is only useful if there are multiple devices. We can > speed up theboot by a few seconds if there is only a single device to > try to boot from. > Signed-off-by: Marc Jones <marcj303(a)gmail.com> As Sebastian points out, this came up once before. I fear altering the timeout dynamically will cause confusion. It's possible to tune the timeout via cbfs, and CONFIG_THREAD_OPTIONROMS can also "speed up" the timeout by allowing hardware init to run in parallel with the delay. -Kevin

1 0

Re: [SeaBIOS] [PATCH RFC 3/7] Add configuration menu for the VGA ROM
by Kevin O'Connor 17 Dec '11

17 Dec '11

On Fri, Dec 16, 2011 at 02:15:09PM +0000, Julian Pidancet wrote: > This patch adds a configuration menu for the VGA ROM, it also allow > the creation of a PCI header so the ROM can be extracted from a PCI > device. [...] > +/**************************************************************** > + * PCI Data > + ****************************************************************/ > +#ifdef CONFIG_PCIBIOS > +_rom_pci_data: > + .ascii "PCIR" > +#if defined(CONFIG_VGA_VID) && defined(CONFIG_VGA_DID) > + .word CONFIG_VGA_VID /* VendorID */ > + .word CONFIG_VGA_DID /* DeviceID */ > +#elif defined(CONFIG_VGA_CIRRUS) > + .word 0x1013 > + .word 0x00b8 > +#elif defined(CONFIG_VGA_BOCHS) > + .word 0x1234 > + .word 0x1111 One other note on this - can't _rom_pci_data be declared in the C code as: struct pci_data rom_pci_data VAR16VISIBLE = { .vendor = CONFIG_VGA_VID, .device = CONFIG_VGA_DID, .dlen = 0x18, .class_hi = 0x300, ... }; -Kevin

2 1

Re: [SeaBIOS] [PATCH RFC 6/7] Partially implement VBE interface, create VBE driver skeleton
by Kevin O'Connor 17 Dec '11

17 Dec '11

On Fri, Dec 16, 2011 at 02:15:12PM +0000, Julian Pidancet wrote: [...] > +struct CRTCInfoBlock > +{ > + u16 horiz_total; > + u16 horiz_sync_start; > + u16 horiz_sync_end; > + u16 vert_total; > + u16 vert_sync_start; > + u16 vert_sync_end; > + u8 flags; > + u32 pixclock; Won't all these structs need to be declared as PACKED? -Kevin

2 1

Re: [SeaBIOS] [PATCH RFC 1/7] Only use -fomit-frame-pointer with 32bit flat code
by Kevin O'Connor 17 Dec '11

17 Dec '11

On Fri, Dec 16, 2011 at 02:15:07PM +0000, Julian Pidancet wrote: > The real-mode emulator that Windows 7 uses to execute the vga bios rom > becomes very confused when the code tries to dereference the stack > pointer instead of using the frame pointer, leading to corruption of > parameters passed on the stack from one function to another. > > Signed-off-by: Julian Pidancet <julian.pidancet(a)gmail.com> Wow - I can only imagine how hard it was to find that. I'm okay with turning off omit-frame-pointer for the vga bios. However, I'd prefer not to turn it off for the main seabios build. Does the emulator also try to emulate parts of the BIOS, which would make that a problem? -Kevin

2 1

Re: [SeaBIOS] [PATCH RFC 3/7] Add configuration menu for the VGA ROM
by Kevin O'Connor 17 Dec '11

17 Dec '11

On Fri, Dec 16, 2011 at 02:15:09PM +0000, Julian Pidancet wrote: > This patch adds a configuration menu for the VGA ROM, it also allow > the creation of a PCI header so the ROM can be extracted from a PCI > device. [...] > +menu "VGA ROM" > + config VGA_CIRRUS [...] > +#ifdef CONFIG_VGA_PCI The SeaBIOS Kconfig has been modified to always define symbols. If the user doesn't select an option it is defined as zero. [...] > +#ifdef CONFIG_PCIBIOS > +_rom_pci_data: > + .ascii "PCIR" > +#if defined(CONFIG_VGA_VID) && defined(CONFIG_VGA_DID) > + .word CONFIG_VGA_VID /* VendorID */ > + .word CONFIG_VGA_DID /* DeviceID */ > +#elif defined(CONFIG_VGA_CIRRUS) > + .word 0x1013 > + .word 0x00b8 > +#elif defined(CONFIG_VGA_BOCHS) > + .word 0x1234 > + .word 0x1111 I wonder if it would be nicer to move the defaults into the Kconfig. -Kevin

1 0

IRQ issues
by Gerd Hoffmann 17 Dec '11

17 Dec '11

Hi, Latest seabios master has trouble with interrupts. Running qemu 1.0, Fedora 16 (linux kernel 3.1) as guest. Linux ends up disabling both IRQ 10 and 11. Device drivers seem to miss interrupts: ehci_hcd 0000:00:1d.7: Unlink after no-IRQ? Controller is probably using the wrong IRQ. Bisecting points to this commit: commit a65f417c8430ce6781cbbfe84381a97d60628d81 Author: Kevin O'Connor <kevin(a)koconnor.net> Date: Sun Sep 25 23:08:58 2011 -0400 Consolidate DSDT copy-and-paste PCI IRQ code into method calls. Use method calls in LNK[ABCDS] object methods - this reduces the cut-and-paste code. It also makes it simpler and the object size smaller. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> Ideas anyone? thanks, Gerd

3 3

how to boot seabios with a raid controller?
by Marc Jones 16 Dec '11

16 Dec '11

I'm trying coreboot + seabios on a system with a raid controller. What is the expected behavior in seabios for booting a sata raid controller? The controller supports raid and shows up as a raid class device. The raid option rom is loaded, but doesn't find any raid arrays. Later, seabios doesn't find the sata drive. I would expect that seabios or the optionrom (int13?) would still be able to support a normal sata drive. Thoughts, comments? Regards, Marc -- http://se-eng.com

1 0

[patch] Skip the bootmenu if only one device is found
by Marc Jones 16 Dec '11

16 Dec '11

The bootmenu is only useful if there are multiple devices. We can speed up theboot by a few seconds if there is only a single device to try to boot from. Signed-off-by: Marc Jones <marcj303(a)gmail.com> -- http://se-eng.com

1 0

Re: [SeaBIOS] [PATCH RFC 1/7] Only use -fomit-frame-pointer with 32bit flat code
by Paolo Bonzini 16 Dec '11

16 Dec '11

On 12/16/2011 03:15 PM, Julian Pidancet wrote: > The real-mode emulator that Windows 7 uses to execute the vga bios rom > becomes very confused when the code tries to dereference the stack > pointer instead of using the frame pointer, leading to corruption of > parameters passed on the stack from one function to another. > > Signed-off-by: Julian Pidancet<julian.pidancet(a)gmail.com> > --- > Makefile | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index c3ba2f3..cb00958 100644 > --- a/Makefile > +++ b/Makefile > @@ -32,14 +32,14 @@ COMMONCFLAGS = -I$(OUT) -Os -MD \ > $(call cc-option,$(CC),-Wtype-limits,) \ > -m32 -march=i386 -mregparm=3 -mpreferred-stack-boundary=2 \ > -mrtd -minline-all-stringops \ > - -freg-struct-return -ffreestanding -fomit-frame-pointer \ > + -freg-struct-return -ffreestanding \ > -fno-delete-null-pointer-checks \ > -ffunction-sections -fdata-sections -fno-common > COMMONCFLAGS += $(call cc-option,$(CC),-nopie,) > COMMONCFLAGS += $(call cc-option,$(CC),-fno-stack-protector,) > COMMONCFLAGS += $(call cc-option,$(CC),-fno-stack-protector-all,) > > -CFLAGS32FLAT = $(COMMONCFLAGS) -g -DMODE16=0 -DMODESEGMENT=0 > +CFLAGS32FLAT = $(COMMONCFLAGS) -fomit-frame-pointer -g -DMODE16=0 -DMODESEGMENT=0 > CFLAGSSEG = $(COMMONCFLAGS) -DMODESEGMENT=1 -fno-defer-pop \ > $(call cc-option,$(CC),-fno-jump-tables,-DMANUAL_NO_JUMP_TABLE) \ > $(call cc-option,$(CC),-fno-tree-switch-conversion,) Ouch. I can imagine how fun it must have been to debug this. Good catch. Paolo

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS