Re: [SeaBIOS] [PATCH RFC 3/7] Add configuration menu for the VGA ROM
On Fri, Dec 16, 2011 at 02:15:09PM +0000, Julian Pidancet wrote:
This patch adds a configuration menu for the VGA ROM, it also allow the creation of a PCI header so the ROM can be extracted from a PCI device. [...] +menu "VGA ROM" + config VGA_CIRRUS [...] +#ifdef CONFIG_VGA_PCI
The SeaBIOS Kconfig has been modified to always define symbols. If the user doesn't select an option it is defined as zero. [...]
+#ifdef CONFIG_PCIBIOS +_rom_pci_data: + .ascii "PCIR" +#if defined(CONFIG_VGA_VID) && defined(CONFIG_VGA_DID) + .word CONFIG_VGA_VID /* VendorID */ + .word CONFIG_VGA_DID /* DeviceID */ +#elif defined(CONFIG_VGA_CIRRUS) + .word 0x1013 + .word 0x00b8 +#elif defined(CONFIG_VGA_BOCHS) + .word 0x1234 + .word 0x1111
I wonder if it would be nicer to move the defaults into the Kconfig. -Kevin
participants (1)
-
Kevin O'Connor