SeaBIOS

seabios@seabios.org

4 participants
3801 discussions

[PATCH] Replace level gpe event with edge gpe event for hot-plug handlers
by Igor Mammedov 05 Apr '12

05 Apr '12

in current code, pci hot-plug gpe event handler is defined as a level one "_L01" 1. hw adds device, sets GPE.1 bit and sends SCI 2. OSPM gets SCI, reads GPE00.sts and masks GPE.1 bit in GPE00.en 3. OSPM executes _L01 4. hw adds second device and sets GPE.1 bit but SCI is not asserted since GPE00.en masks event 5. OSPM resets GPE.1 bit in GPE00.sts and umasks it in GPE00.en as result event for step 4 is lost because step 5 clears it and OS will not see added second device. ACPI 50 spec: 5.6.4 General-Purpose Event Handling defines GPE event handling as following: 1. Disables the interrupt source (GPEx_BLK EN bit). 2. If an edge event, clears the status bit. 3. Performs one of the following: * Dispatches to an ACPI-aware device driver. * Queues the matching control method for execution. * Manages a wake event using device _PRW objects. 4. If a level event, clears the status bit. 5. Enables the interrupt source. Switching from level to edge event handler reduces chances to hit race window. Same applies to cpu-hotplug, so switch it to edge handler as well. Tested with RHEL6, 3.3.+ kernel, winxp, and w2008r2, and I wasn't able to trigger race after using edge event handler. Signed-off-by: Igor Mammedov <imammedo(a)redhat.com> --- src/acpi-dsdt.dsl | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 4e04c48..4bdc268 100644 --- a/src/acpi-dsdt.dsl +++ b/src/acpi-dsdt.dsl @@ -723,11 +723,11 @@ DefinitionBlock ( Method(_L00) { Return(0x01) } - Method(_L01) { + Method(_E01) { // PCI hotplug event Return(\_SB.PCI0.PCNF()) } - Method(_L02) { + Method(_E02) { // CPU hotplug event Return(\_SB.PRSC()) } -- 1.7.7.6

3 2

Wrong address returned by container _of macro
by Daniel Castro 04 Apr '12

04 Apr '12

Hello All, I have a little problem, when I try to get my drive on boot (16bit) I am getting the wrong address: This code: struct xendrive_s * xendrive = GLOBALFLAT2GLOBAL(container_of(GET_GLOBAL(op->drive_g), struct xendrive_s, drive)); dprintf(1,"Xendrive at:%p\n",xendrive); Returns this: Xendrive at:0xfff10000 But it should be this instead: dprintf(1,"TEST drive 0 %p \n",i,GET_GLOBAL(xendrives[0])); returns this: TEST drive 0 0x000fd620 This last address is the address returned when done this: struct xendrive_s *xd = malloc_fseg(sizeof(struct xendrive_s*)); SET_FLATPTR(xendrives[count_drives],xd); The xd pointer is later used for: boot_add_hd(&xd->drive,desc,drives); Any tip to solve this will be greatly appreciated. Thanks you all, Daniel -- +-=====---------------------------+ | +---------------------------------+ | This space intentionally blank for notetaking. | | | Daniel Castro, | | | | Consultant/Programmer.| | | | U Andes | +-------------------------------------+

1 0

Re: [SeaBIOS] [PATCH v2] x86emu: Correctly handle 0x66 prefix for some instructions
by Michael Tokarev 02 Apr '12

02 Apr '12

What is the outcome of this patch? I mean, does it actually fix something visible, instead of a potential problem? [] >>> Anyone interested in this ? Is there a maintainer for x86emu ? The >>> MAINTAINERS file in xorg-docs doesn't mention anything about it. >> >> CCed: Adam Jackson >> >> Adam, you seem to be the maintainer of the xorg vesa driver. I think >> this patch is closely related. Would you mind taking a look at it ? I asked another question related to xorg vesa driver, also related to qemu, about it being unable to find available resolutions when run under qemu -- this: http://lists.x.org/archives/xorg-devel/2012-March/030037.html Is this 0x66 issue related to my question somehow? :) Thanks, /mjt

2 1

Re: [SeaBIOS] [PATCH v2] x86emu: Correctly handle 0x66 prefix for some instructions
by Julian Pidancet 01 Apr '12

01 Apr '12

On Thu, Mar 15, 2012 at 10:45 PM, Julian Pidancet <julian.pidancet(a)gmail.com> wrote: > On Thu, Mar 15, 2012 at 10:39 PM, Julian Pidancet > <julian.pidancet(a)gmail.com> wrote: >> On Fri, Mar 9, 2012 at 2:08 AM, Guillem Jover <guillem(a)hadrons.org> wrote: >>> On Fri, 2012-03-09 at 00:02:55 +0000, Julian Pidancet wrote: >>>> Some instructions are not emulated correctly by x86emu when they >>>> are prefixed by the 0x66 opcode. >>>> I've identified problems in the emulation of these intructions: ret, >>>> enter, leave, iret and some forms of call. >>>> >>>> Most of the time, the problem is that these instructions should push or >>>> pop 32-bit values to/from the stack, instead of 16bit, when they are >>>> prefixed by the 0x66 special opcode. >>>> >>>> The SeaBIOS project aims to produce a complete legacy BIOS >>>> implementation as well as a VGA option ROM, entirely written in C and >>>> using the GCC compiler. >>>> >>>> In 16bit code produced by the GCC compiler, the 0x66 prefix is used >>>> almost everywhere. This patch is necessary to allow the SeaBIOS VGA >>>> option ROM to function with Xorg when using the vesa driver. >>>> >>>> v2: - Decrement BP instead of EBP in accordance with the Intel Manual >>>> - Assign EIP instead of IP when poping the return address from the >>>> stack in 32-bit operand size mode in ret_far_IMM, ret_far, and iret >>>> - When poping EFLAGS from the stack in iret in 32-bit operand size >>>> mode, apply some mask to preserve Read-only flags. >>>> >>>> Signed-off-by: Julian Pidancet <julian.pidancet(a)gmail.com> >>> >>> Looks good to me: >>> >>> Reviewed-by: Guillem Jover <guillem(a)hadrons.org> >>> >>> thanks, >>> guillem >> >> Anyone interested in this ? Is there a maintainer for x86emu ? The >> MAINTAINERS file in xorg-docs doesn't mention anything about it. >> > > CCed: Adam Jackson > > Adam, you seem to be the maintainer of the xorg vesa driver. I think > this patch is closely related. Would you mind taking a look at it ? > > Thanks, > Ping ? -- Julian

1 0

Next release
by Kevin O'Connor 01 Apr '12

01 Apr '12

Hi, As previously discussed, I think it is approaching the time for the next release of SeaBIOS. I plan to make the next version number be v1.7.0. If anyone knows of any bugs, patches, or issues that need to be addressed prior to making a release, please let me know. Thanks, -Kevin

1 0

[PATCH 2/2] acpi: clear up/down bits on interrupt
by Michael S. Tsirkin 01 Apr '12

01 Apr '12

qemu added a way for bios to clear bits in the up/down register. Do this in PCNF so that we wont trigger multiple events for the same slot. This does nothing when running on an old qemu. Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> --- src/acpi-dsdt.dsl | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 15201e9..e17e0e2 100644 --- a/src/acpi-dsdt.dsl +++ b/src/acpi-dsdt.dsl @@ -132,6 +132,13 @@ DefinitionBlock ( B0EJ, 32, } + OperationRegion(PCCL, SystemIO, 0xae10, 0x08) + Field (PCST, DWordAcc, NoLock, WriteAsZeros) + { + PCCU, 32, + PCCD, 32, + } + Name (_CRS, ResourceTemplate () { WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode, @@ -489,6 +496,8 @@ DefinitionBlock ( Store (Zero, Local0) Store (PCIU, Local1) Store (PCID, Local2) + Store (Local1, PCCU) + Store (Local2, PCCD) While (LLess(Local0, 31)) { Increment(Local0) If (And(Local1, ShiftLeft(1, Local0))) { -- 1.7.9.111.gf3fb0

2 2

[PATCH] seabios: readd Makefile rule for ACPI
by Michael S. Tsirkin 01 Apr '12

01 Apr '12

Commit 36feea9317b45abf3a540e9d82ad1723bebe3ebd removed the dependency of output file on acpi output. This means it's not rebuilt on acpi source or hex file updates. Re-introduce this dependency. Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> --- Makefile | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index a4d548d..48715bf 100644 --- a/Makefile +++ b/Makefile @@ -227,6 +227,7 @@ src/%.hex: src/%.dsl ./tools/acpi_extract_preprocess.py ./tools/acpi_extract.py $(Q)$(PYTHON) ./tools/acpi_extract.py $(OUT)$*.lst > $(OUT)$*.off $(Q)cat $(OUT)$*.off > $@ +$(OUT)ccode32flat.o: src/acpi-dsdt.hex src/ssdt-proc.hex src/ssdt-pcihp.hex ################ Kconfig rules -- 1.7.9.111.gf3fb0

3 2

[PATCH 1/2] acpi: remove unnecessary reads
by Michael S. Tsirkin 28 Mar '12

28 Mar '12

Read each of the up/down registers only once and store in a local temporary. This refactoring makes it a bit easier to clear these registers, which is done by a follow-up patch. Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> --- src/acpi-dsdt.dsl | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 4e04c48..15201e9 100644 --- a/src/acpi-dsdt.dsl +++ b/src/acpi-dsdt.dsl @@ -487,12 +487,14 @@ DefinitionBlock ( Method(PCNF, 0) { // Local0 = iterator Store (Zero, Local0) + Store (PCIU, Local1) + Store (PCID, Local2) While (LLess(Local0, 31)) { Increment(Local0) - If (And(PCIU, ShiftLeft(1, Local0))) { + If (And(Local1, ShiftLeft(1, Local0))) { PCNT(Local0, 1) } - If (And(PCID, ShiftLeft(1, Local0))) { + If (And(Local2, ShiftLeft(1, Local0))) { PCNT(Local0, 3) } } -- 1.7.9.111.gf3fb0

1 0

Re: [SeaBIOS] bootorder: iPXE or gPXE?
by Kevin O'Connor 24 Mar '12

24 Mar '12

On Fri, Mar 23, 2012 at 09:25:24AM -0600, Steve Goodrich wrote: > I don't yet understand the syntax of the bootorder file, and I'm trying to > use iPXE as one of the boot sources. Could someone either: > 1. Show me how to set this up, or > 2. Point me to documentation somewhere that explains PXE boot as controlled > by SeaBIOS's bootorder file, or > 3. Show me another way to do it? As before, there is some documentation at: http://www.coreboot.org/SeaBIOS#Configuring_boot_order Basically, extract the SeaBIOS log and look for lines with "Searching bootorder for" and then put the line corresponding to the device you wish to boot from into the file. If you're still having issues, please post your log along with the bootorder file that you attempted. -Kevin

1 0

[PATCH] test-gcc: do not truncate stderr
by Ian Campbell 24 Mar '12

24 Mar '12

Using "> /dev/fd/2" causes stderr to get truncated, which is mangles the log file if the user happens to have redirected it there. Use ">&2" instead which redirects to the already open stderr and doesn't truncate it. Reported-by: Tim Deegan <tim(a)xen.org> Tested-by: Tim Deegan <tim(a)xen.org> Signed-off-by: Ian Campbell <ian.campbell(a)citrix.com> --- If this could go into the next stable release that would be very nice. Thanks, Ian. --- tools/test-gcc.sh | 20 ++++++++++---------- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/tools/test-gcc.sh b/tools/test-gcc.sh index 935f211..05bae29 100755 --- a/tools/test-gcc.sh +++ b/tools/test-gcc.sh @@ -30,13 +30,13 @@ EOF $CC -O -g -c $TMPFILE1 -o $TMPFILE1o > /dev/null 2>&1 $LD -T $TMPFILE1_ld $TMPFILE1o -o $TMPFILE2o > /dev/null 2>&1 if [ $? -ne 0 ]; then - echo "The version of LD on this system does not properly handle" > /dev/fd/2 - echo "alignments. As a result, this project can not be built." > /dev/fd/2 - echo "" > /dev/fd/2 - echo "The problem may be the result of this LD bug report:" > /dev/fd/2 - echo " http://sourceware.org/bugzilla/show_bug.cgi?id=12726" > /dev/fd/2 - echo "" > /dev/fd/2 - echo "Please update to a working version of binutils and retry." > /dev/fd/2 + echo "The version of LD on this system does not properly handle" >&2 + echo "alignments. As a result, this project can not be built." >&2 + echo "" >&2 + echo "The problem may be the result of this LD bug report:" >&2 + echo " http://sourceware.org/bugzilla/show_bug.cgi?id=12726" >&2 + echo "" >&2 + echo "Please update to a working version of binutils and retry." >&2 echo -1 exit 0 fi @@ -45,7 +45,7 @@ fi # support the whole-program optimization - detect that. $CC -fwhole-program -S -o /dev/null -xc /dev/null > /dev/null 2>&1 if [ $? -ne 0 ]; then - echo " Working around no -fwhole-program" > /dev/fd/2 + echo " Working around no -fwhole-program" >&2 echo 2 exit 0 fi @@ -69,7 +69,7 @@ EOF $CC -Os -c -fwhole-program $TMPFILE2 -o $TMPFILE2o > /dev/null 2>&1 $CC -nostdlib -Os $TMPFILE1o $TMPFILE2o -o $TMPFILE3o > /dev/null 2>&1 if [ $? -ne 0 ]; then - echo " Working around non-functional -fwhole-program" > /dev/fd/2 + echo " Working around non-functional -fwhole-program" >&2 echo 2 exit 0 fi @@ -104,7 +104,7 @@ $CC -O -g -fwhole-program -combine -c $TMPFILE1 $TMPFILE2 -o $TMPFILE1o > /dev/n if [ $? -eq 0 ]; then echo 0 else - echo " Working around non-functional -combine" > /dev/fd/2 + echo " Working around non-functional -combine" >&2 echo 1 fi -- 1.7.2.5

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS