SeaBIOS

seabios@seabios.org

4 participants
3801 discussions

bootorder: iPXE or gPXE?
by Steve Goodrich 23 Mar '12

23 Mar '12

I don't yet understand the syntax of the bootorder file, and I'm trying to use iPXE as one of the boot sources. Could someone either: 1. Show me how to set this up, or 2. Point me to documentation somewhere that explains PXE boot as controlled by SeaBIOS's bootorder file, or 3. Show me another way to do it? Thanks! -- Steve G.

1 0

[PATCH v2] Halt if number of started cpus are more then expected
by Igor Mammedov 22 Mar '12

22 Mar '12

Reduce amount of consumed cpu time (i.e. don't spin forever) if number of started cpus are more then expected. And print a bug message into debug port. And it is not safe to continue to boot if CountCPUs is more than cmos_smp_count and might be still racing, due to mp/acpi could be build with still changing CountCPUs. It is safer to stop and allow user to notice and restart system rather than debug possible inxplicable bugs later. v2: extendend commit message with explanation why not continue to boot Signed-off-by: Igor Mammedov <imammedo(a)redhat.com> --- src/smp.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/src/smp.c b/src/smp.c index 8c077a1..9933ac6 100644 --- a/src/smp.c +++ b/src/smp.c @@ -115,8 +115,14 @@ smp_probe(void) msleep(10); } else { u8 cmos_smp_count = inb_cmos(CMOS_BIOS_SMP_COUNT); - while (cmos_smp_count + 1 != readl(&CountCPUs)) + while (cmos_smp_count + 1 != readl(&CountCPUs)) { + if (cmos_smp_count + 1 < readl(&CountCPUs)) { + dprintf(1, "BUG: Expected %d cpu(s) but %d cpus started\n", + cmos_smp_count + 1, readl(&CountCPUs)); + hlt(); + } yield(); + } } // Restore memory. -- 1.7.7.6

2 2

[PATCH] update version banner
by Gerd Hoffmann 22 Mar '12

22 Mar '12

This patch changes the seabios version banner printed. When building from a git repository 'git describe' is used to generate a version tag which includes the (short) commit hash and thus can be used to identify the commit used to build the binary. Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> --- Makefile | 13 ++++++++++++- 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index abbac8c..6577ad3 100644 --- a/Makefile +++ b/Makefile @@ -5,7 +5,18 @@ # This file may be distributed under the terms of the GNU LGPLv3 license. # Program version -VERSION=pre-1.6.4-$(shell date +"%Y%m%d_%H%M%S")-$(shell hostname) +RELEASE := pre-1.6.4 + +GIT_DESC := $(shell test -d .git && git describe --tags) +ifeq ($(GIT_DESC),) + # building from release tarball + VERSION := $(RELEASE) +else + # building from git repository + VERSION := $(GIT_DESC) +endif +VERSION += $(shell date +"%Y%m%d_%H%M%S") +VERSION += $(shell hostname) # Output directory OUT=out/ -- 1.7.1

2 2

CD-ROM boot broken on current revision?
by fellaw＠gmx.net 21 Mar '12

21 Mar '12

Hi, I'm a new subscriber to seabios.org. Not much exp. with mailing lists nor C++, so feel free to straighten me out as necessary. I found out an issue: Booting from CD-ROM doesn't work anymore, though related make options have been set. I tried to debug it a little bit. To me it looks that order changes related to media sensing/capacity request broke it up. In 1.6.3, cdb_read_capacity(line 204 in src/cdrom.c) takes place before cdb_get_sense(line 209) resulting in a break. In current revision, this has been changed, has it? cdrom_boot(src/cdrom.cline 188) calls scsi_is_ready(line 197), which looks similar to atapi_is_ready from 1.6.3/src/cdrom.c. However: scsi_is_ready is missing struct cdbres_read_capacity info; ret = cdb_read_capacity(op, &info); if (!ret) // Success break; contrary to 1.6.3. In line cdb_get_sense returns 0xC with a medium in the drive, but this seems to result into an endless loop due to continue; For me, I added above snippet to blockcmd.c right before ret = cdb_get_sense(..) and it worked. Later CD-ROM boots using boot managers(e.g. grub4dos or PloP) work fine without changes, though. Debugging was done in Qemu 1.0.1. Since I'm on Windows, I used this build: http://lassauge.free.fr/qemu/release/Qemu-1.0.1-windows.zip Please confirm or advise. Kind Regards, fellaw

3 4

[PATCH] Drop FIX_RTC flag from FADT.
by Gleb Natapov 21 Mar '12

21 Mar '12

FIX_RTC flag should be set if RTC wake status is _not_ reported in fixed register space, but this is not the case for QEMU. So drop it from FADT. Signed-off-by: Gleb Natapov <gleb(a)redhat.com> diff --git a/src/acpi.c b/src/acpi.c index 6174e04..30888b9 100644 --- a/src/acpi.c +++ b/src/acpi.c @@ -294,8 +294,8 @@ build_fadt(struct pci_device *pci) fadt->plvl2_lat = cpu_to_le16(0xfff); // C2 state not supported fadt->plvl3_lat = cpu_to_le16(0xfff); // C3 state not supported pci_init_device(fadt_init_tbl, pci, fadt); - /* WBINVD + PROC_C1 + SLP_BUTTON + FIX_RTC + RTC_S4 */ - fadt->flags = cpu_to_le32((1 << 0) | (1 << 2) | (1 << 5) | (1 << 6) | (1 << 7)); + /* WBINVD + PROC_C1 + SLP_BUTTON + RTC_S4 */ + fadt->flags = cpu_to_le32((1 << 0) | (1 << 2) | (1 << 5) | (1 << 7)); build_header((void*)fadt, FACP_SIGNATURE, sizeof(*fadt), 1); -- Gleb.

2 1

Re: [SeaBIOS] usb ohci pipe free fix
by Kevin O'Connor 21 Mar '12

21 Mar '12

On Wed, Mar 21, 2012 at 10:50:17PM +0100, Nils wrote: > Op zaterdag 10-03-2012 om 14:05 uur [tijdzone -0500], schreef Kevin > O'Connor: > > It looks pretty clear that the controller doesn't like 9-segment nor > > e-segment addresses. You could try "malloc_low() - 0x50000" to see > > how the controller likes 4-segment address, but basically the only > > hope of getting this to work is to see if you can fix the controller. > I studied the datasheets and tried different things but had no result. > > Then i tried "malloc_low() - 0x100" and the controller seems to work. > > Could it be that some SeaBIOS parts overlap at LOWRAM_END ? > ( ohci controller and (E)BDA ?) The logs pretty clearly indicate that the ram is in the 9-segment and not the a-segment. It may be a hardware bug that confuses addresses that are close. > Do you have any suggestions ? > > Attached log from latest git + debugging patch and log from same code > but with "malloc_low() - 0x100" . If it's just a 256 byte offset, you can add a "malloc_low(256)" to the top of usb.c:usb_setup() to reserve the troublesome addresses. Note though, the e-segment values we tested before seem to be also impacted. I have a vague plan to change SeaBIOS in the future to use e-segment addresses instead of 9-segment addresses. -Kevin

1 0

[PATCH 0/6] Redesign of pciinit.c (take 2)
by Alexey Korolev 20 Mar '12

20 Mar '12

Hi, This patch series redesigns the existing pciinit.c code and introduces linked list operations. Changes are more about structures definitions rather than functionality. There are no more arrays of bases and counts in new implementation. The new implementation is based on dynamic allocation of pci_region_entry structures. Each pci_region_entry structure could be a PCI bar or a downstream PCI region (bridge). Each entry has a set of attributes: type (IO, MEM, PREFMEM), is64bit, size, base address, PCI device owner, and a pointer to the pci_bus it belongs to. Also this series introduces list head operations which could be quite handy not only for pciinit.c code but for post memory manager and thread operations. The patch series includes 3 patches. 1. Introduce List operations 2. Add pci_region_entry and linked lists operations in place while still using the array system to do the allocations. 3. Switch to lists operations 4. Delete old code. (3 & 4 are split for better readability) 5. Get rid of size element from bus->r structure, now we use entry->size for the same purpose 6. Make use of list operations in pmm.c and stack.c src/pciinit.c | 270 ++++++++++++++++++++++++++------------------------------- src/pmm.c | 29 ++---- src/stacks.c | 8 +-- src/util.h | 32 +++++++ 4 files changed, 165 insertions(+), 174 deletions(-) P/s It is basically the same functionality as in previous version. I just split commit in more pieces to make the changes to be as obvious as possible.

2 10

Re: [SeaBIOS] Boot failure with MS-Dos 6.22 (due to bad BIOS build?)
by Jan Kiszka 20 Mar '12

20 Mar '12

On 2012-02-27 10:51, Daniel P. Berrange wrote: > I'm seeing current QEMU GIT fail to boot MS-Dos 6.22 with the following > crash: > > # qemu-system-x86_64 -fda ~/MS-DOS\ 6.22.img -m 1 -curses > iPXE v1.0.0-591-g7aee315 > iPXE (http://ipxe.org) 00:03.0 C900 PCI2.10 PnP PMM+00000000+00000000 C900 > > Booting from Floppy.. > . qemu: fatal: Trying to execute code outside RAM or ROM at 0x00000001000effff > > EAX=ffffffff EBX=ffffffff ECX=0000c934 EDX=00000068 > ESI=00006801 EDI=00000000 EBP=0000002b ESP=0000fff5 > EIP=ffffffff EFL=00000002 [-------] CPL=0 II=0 A20=1 SMM=0 HLT=0 > ES =0040 00000400 0000ffff 00009300 > CS =f000 000f0000 0000ffff 00009b00 > SS =9ec4 0009ec40 0000ffff 00009300 > DS =9ec4 0009ec40 0000ffff 00009300 > FS =0000 00000000 0000ffff 00009300 > GS =0000 00000000 0000ffff 00009300 > LDT=0000 00000000 0000ffff 00008200 > TR =0000 00000000 0000ffff 00008b00 > GDT= 000fcd78 00000037 > IDT= 00000000 000003ff > CR0=00000010 CR2=00000000 CR3=00000000 CR4=00000000 > DR0=0000000000000000 DR1=0000000000000000 DR2=0000000000000000 DR3=0000000000000000 > DR6=00000000ffff0ff0 DR7=0000000000000400 > CCS=000000d0 CCD=00000068 CCO=SARL > EFER=0000000000000000 > FCW=037f FSW=0000 [ST=0] FTW=00 MXCSR=00001f80 > FPR0=0000000000000000 0000 FPR1=0000000000000000 0000 > FPR2=0000000000000000 0000 FPR3=0000000000000000 0000 > FPR4=0000000000000000 0000 FPR5=0000000000000000 0000 > FPR6=0000000000000000 0000 FPR7=0000000000000000 0000 > XMM00=00000000000000000000000000000000 XMM01=00000000000000000000000000000000 > XMM02=00000000000000000000000000000000 XMM03=00000000000000000000000000000000 > XMM04=00000000000000000000000000000000 XMM05=00000000000000000000000000000000 > XMM06=00000000000000000000000000000000 XMM07=00000000000000000000000000000000 > Aborted > > > Git bisect blames this > > commit 41bd360325168b3c1db78eb7311420a1607d521f > Author: Jan Kiszka <jan.kiszka(a)siemens.com> > Date: Sun Jan 15 17:48:25 2012 +0100 > > seabios: Update to release 1.6.3.1 > > User visible changes in seabios: > - Probe HPET existence (fix for -no-hpet) > - Probe PCI existence (fix for -machine isapc) > - usb: fix boot paths > > Signed-off-by: Jan Kiszka <jan.kiszka(a)siemens.com> > > > I tried to bisect Seabios, but every revision in Seabios upstream works > fine. > > Then I noticed, that if I rebuild the BIOS, from the exact same revision > 1.6.3.1 revision that is committed in 'seabios' submodule in QEMU, then > it works fine. So AFAICT, it is not the Seabios source code at fault, > but rather the binary build we have commited to GIT. Should/can we rebuild > the bios.bin in GIT ? Probably not without understanding what causes this strange inconsistency. If Seabios builds without errors and then later on fails, this is also a bug. Kevin, what information do you need to assess my tool chain? Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux

6 10

Re: [SeaBIOS] usb-msc.c: TEST_UNIT_READY needs USB_DIR_OUT?
by Kevin O'Connor 17 Mar '12

17 Mar '12

On Wed, Mar 14, 2012 at 01:02:39PM -0600, Steve Goodrich wrote: > I've been working with coreboot and SeaBIOS lately to try to get a platform > working, including having boot capability using an SD-to-USB adapter. I got > stuck on this last part: the USB/SD adapter would start enumeration, but > would fail out during TEST_UNIT_READY because the device came back with a > STALL (this via a LeCroy/CACT USB analyzer). I compared the transactions to > those done during USB enumeration/configuration in Linux, and I noticed that > the Direction bit in bmCBWFlags is *cleared* for the TEST_UNIT_READY command > in Linux, but *set* in coreboot. If Linux always clears the direction bit for zero length transfers, then I think it should be safe to do that in SeaBIOS also. How about the patch below? -Kevin >From 1fd9a89082b807a4bb4ab6ce1285df474cb75746 Mon Sep 17 00:00:00 2001 From: Kevin O'Connor <kevin(a)koconnor.net> Date: Wed, 14 Mar 2012 21:27:45 -0400 Subject: [PATCH] Use OUT mode for all zero byte "scsi" transfers. Some devices can get confused if asked to "read" data during a zero byte transfer, so consider these transfers as "writes". (Reported by Steve Goodrich.) Also, extract out the code to determine the transfer direction into cdb_is_read(). Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- src/blockcmd.c | 7 +++++++ src/blockcmd.h | 1 + src/usb-msc.c | 4 ++-- src/virtio-scsi.c | 7 ++++--- 4 files changed, 14 insertions(+), 5 deletions(-) diff --git a/src/blockcmd.c b/src/blockcmd.c index 8d881a5..2dda04d 100644 --- a/src/blockcmd.c +++ b/src/blockcmd.c @@ -35,6 +35,13 @@ cdb_cmd_data(struct disk_op_s *op, void *cdbcmd, u16 blocksize) } } +// Determine if the command is a request to pull data from the device +int +cdb_is_read(u8 *cdbcmd, u16 blocksize) +{ + return blocksize && cdbcmd[0] != CDB_CMD_WRITE_10; +} + int scsi_is_ready(struct disk_op_s *op) { diff --git a/src/blockcmd.h b/src/blockcmd.h index ccfeeaf..8459d3e 100644 --- a/src/blockcmd.h +++ b/src/blockcmd.h @@ -100,6 +100,7 @@ struct cdbres_mode_sense_geom { } PACKED; // blockcmd.c +int cdb_is_read(u8 *cdbcmd, u16 blocksize); int cdb_get_inquiry(struct disk_op_s *op, struct cdbres_inquiry *data); int cdb_get_sense(struct disk_op_s *op, struct cdbres_request_sense *data); int cdb_test_unit_ready(struct disk_op_s *op); diff --git a/src/usb-msc.c b/src/usb-msc.c index dadb9ca..c53a1f5 100644 --- a/src/usb-msc.c +++ b/src/usb-msc.c @@ -77,13 +77,13 @@ usb_cmd_data(struct disk_op_s *op, void *cdbcmd, u16 blocksize) cbw.dCBWSignature = CBW_SIGNATURE; cbw.dCBWTag = 999; // XXX cbw.dCBWDataTransferLength = bytes; - cbw.bmCBWFlags = (cbw.CBWCB[0] == CDB_CMD_WRITE_10) ? USB_DIR_OUT : USB_DIR_IN; + cbw.bmCBWFlags = cdb_is_read(cdbcmd, blocksize) ? USB_DIR_IN : USB_DIR_OUT; cbw.bCBWLUN = 0; // XXX cbw.bCBWCBLength = USB_CDB_SIZE; // Transfer cbw to device. int ret = usb_msc_send(udrive_g, USB_DIR_OUT - , MAKE_FLATPTR(GET_SEG(SS), &cbw), sizeof(cbw)); + , MAKE_FLATPTR(GET_SEG(SS), &cbw), sizeof(cbw)); if (ret) goto fail; diff --git a/src/virtio-scsi.c b/src/virtio-scsi.c index 3c59438..50339d7 100644 --- a/src/virtio-scsi.c +++ b/src/virtio-scsi.c @@ -31,7 +31,7 @@ struct virtio_lun_s { static int virtio_scsi_cmd(u16 ioaddr, struct vring_virtqueue *vq, struct disk_op_s *op, - void *cdbcmd, u16 target, u16 lun, u32 len) + void *cdbcmd, u16 target, u16 lun, u16 blocksize) { struct virtio_scsi_req_cmd req; struct virtio_scsi_resp_cmd resp; @@ -44,7 +44,8 @@ virtio_scsi_cmd(u16 ioaddr, struct vring_virtqueue *vq, struct disk_op_s *op, req.lun[3] = (lun & 0xff); memcpy(req.cdb, cdbcmd, 16); - int datain = (req.cdb[0] != CDB_CMD_WRITE_10); + u32 len = op->count * blocksize; + int datain = cdb_is_read(cdbcmd, blocksize); int data_idx = (datain ? 2 : 1); int out_num = (datain ? 1 : 2); int in_num = (len ? 3 : 2) - out_num; @@ -89,7 +90,7 @@ virtio_scsi_cmd_data(struct disk_op_s *op, void *cdbcmd, u16 blocksize) return virtio_scsi_cmd(GET_GLOBAL(vlun->ioaddr), GET_GLOBAL(vlun->vq), op, cdbcmd, GET_GLOBAL(vlun->target), GET_GLOBAL(vlun->lun), - blocksize * op->count); + blocksize); } static int -- 1.7.6.5

5 6

[PATCH] if HPET is not present do not report it in DSDT
by Gleb Natapov 17 Mar '12

17 Mar '12

Replicate the check that detects if HPET table should be created in AML too. Signed-off-by: Gleb Natapov <gleb(a)redhat.com> diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 7082b65..4e04c48 100644 --- a/src/acpi-dsdt.dsl +++ b/src/acpi-dsdt.dsl @@ -188,8 +188,22 @@ DefinitionBlock ( Device(HPET) { Name(_HID, EISAID("PNP0103")) Name(_UID, 0) + OperationRegion(HPTM, SystemMemory , 0xFED00000, 0x400) + Field(HPTM, DWordAcc, Lock, Preserve) { + VEND, 32, + PRD, 32, + } Method (_STA, 0, NotSerialized) { - Return(0x0F) + Store (VEND, Local0) + Store (PRD, Local1) + ShiftRight(Local0, 16, Local0) + If (LOr (LEqual(Local0, 0), LEqual(Local0, 0xffff))) { + Return (0x0) + } + If (LOr (LEqual(Local1, 0), LGreater(Local1, 100000000))) { + Return (0x0) + } + Return (0x0F) } Name(_CRS, ResourceTemplate() { DWordMemory( -- Gleb.

3 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS