SeaBIOS

seabios@seabios.org

4 participants
3801 discussions

[PATCH] Cache romfile entries.
by Kevin O'Connor 31 May '12

31 May '12

Create a 'struct romfile_s' and populate a list of all romfiles at start of init. Caching the romfiles both simplifies the code and makes it more efficient. Also, convert the ramdisk code to use romfile helpers instead of directly accessing cbfs. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- Makefile | 2 +- src/boot.c | 4 +- src/bootsplash.c | 1 - src/coreboot.c | 208 +++++++++++++++++------------------------------------- src/optionroms.c | 16 ++-- src/paravirt.c | 138 +++++++---------------------------- src/paravirt.h | 45 +------------ src/pci.c | 2 +- src/post.c | 4 + src/ps2port.c | 1 - src/ramdisk.c | 12 ++-- src/romfile.c | 96 +++++++++++++++++++++++++ src/util.h | 24 +++++-- 13 files changed, 232 insertions(+), 321 deletions(-) create mode 100644 src/romfile.c diff --git a/Makefile b/Makefile index 5f3740d..fe974f7 100644 --- a/Makefile +++ b/Makefile @@ -17,7 +17,7 @@ SRC16=$(SRCBOTH) system.c disk.c font.c SRC32FLAT=$(SRCBOTH) post.c shadow.c memmap.c coreboot.c boot.c \ acpi.c smm.c mptable.c smbios.c pciinit.c optionroms.c mtrr.c \ lzmadecode.c bootsplash.c jpeg.c usb-hub.c paravirt.c \ - biostables.c xen.c bmp.c + biostables.c xen.c bmp.c romfile.c SRC32SEG=util.c output.c pci.c pcibios.c apm.c stacks.c # Default compiler flags diff --git a/src/boot.c b/src/boot.c index 3f6375b..6949490 100644 --- a/src/boot.c +++ b/src/boot.c @@ -11,8 +11,8 @@ #include "bregs.h" // struct bregs #include "boot.h" // func defs #include "cmos.h" // inb_cmos -#include "paravirt.h" // romfile_loadfile -#include "pci.h" //pci_bdf_to_* +#include "paravirt.h" // qemu_cfg_show_boot_menu +#include "pci.h" // pci_bdf_to_* #include "usb.h" // struct usbdevice_s diff --git a/src/bootsplash.c b/src/bootsplash.c index f85f734..a85e2b2 100644 --- a/src/bootsplash.c +++ b/src/bootsplash.c @@ -10,7 +10,6 @@ #include "config.h" // CONFIG_* #include "util.h" // dprintf #include "jpeg.h" // splash -#include "paravirt.h" // romfile_find #include "vbe.h" // struct vbe_info #include "bmp.h" diff --git a/src/coreboot.c b/src/coreboot.c index e116a14..d93196f 100644 --- a/src/coreboot.c +++ b/src/coreboot.c @@ -121,8 +121,8 @@ static struct cb_memory *CBMemTable; const char *CBvendor = "", *CBpart = ""; // Populate max ram and e820 map info by scanning for a coreboot table. -static void -coreboot_fill_map(void) +void +coreboot_setup(void) { dprintf(3, "Attempting to find coreboot table\n"); @@ -286,25 +286,6 @@ struct cbfs_header { u32 pad[2]; } PACKED; -static struct cbfs_header *CBHDR; - -static void -cbfs_setup(void) -{ - if (!CONFIG_COREBOOT || !CONFIG_COREBOOT_FLASH) - return; - - CBHDR = *(void **)CBFS_HEADPTR_ADDR; - if (CBHDR->magic != htonl(CBFS_HEADER_MAGIC)) { - dprintf(1, "Unable to find CBFS (ptr=%p; got %x not %x)\n" - , CBHDR, CBHDR->magic, htonl(CBFS_HEADER_MAGIC)); - CBHDR = NULL; - return; - } - - dprintf(1, "Found CBFS header at %p\n", CBHDR); -} - #define CBFS_FILE_MAGIC 0x455649484352414cLL // LARCHIVE struct cbfs_file { @@ -316,124 +297,22 @@ struct cbfs_file { char filename[0]; } PACKED; -// Verify a cbfs entry looks valid. -static struct cbfs_file * -cbfs_verify(struct cbfs_file *file) -{ - if (file < (struct cbfs_file *)(0xFFFFFFFF - ntohl(CBHDR->romsize))) - return NULL; - u64 magic = file->magic; - if (magic == CBFS_FILE_MAGIC) { - dprintf(8, "Found CBFS file %s\n", file->filename); - return file; - } - return NULL; -} - -// Return the first file in the CBFS archive -static struct cbfs_file * -cbfs_getfirst(void) -{ - if (! CBHDR) - return NULL; - return cbfs_verify((void *)(0 - ntohl(CBHDR->romsize) + ntohl(CBHDR->offset))); -} - -// Return the file after the given file. -static struct cbfs_file * -cbfs_getnext(struct cbfs_file *file) -{ - file = (void*)file + ALIGN(ntohl(file->len) + ntohl(file->offset), ntohl(CBHDR->align)); - return cbfs_verify(file); -} - -// Find the file with the given filename. -struct cbfs_file * -cbfs_findfile(const char *fname) -{ - dprintf(7, "Searching CBFS for %s\n", fname); - struct cbfs_file *file; - for (file = cbfs_getfirst(); file; file = cbfs_getnext(file)) - if (strcmp(fname, file->filename) == 0) - return file; - return NULL; -} - -// Find next file with the given filename prefix. -struct cbfs_file * -cbfs_findprefix(const char *prefix, struct cbfs_file *last) -{ - if (!CONFIG_COREBOOT || !CONFIG_COREBOOT_FLASH) - return NULL; - - dprintf(7, "Searching CBFS for prefix %s\n", prefix); - int len = strlen(prefix); - struct cbfs_file *file; - if (! last) - file = cbfs_getfirst(); - else - file = cbfs_getnext(last); - for (; file; file = cbfs_getnext(file)) - if (memcmp(prefix, file->filename, len) == 0) - return file; - return NULL; -} - -// Find a file with the given filename (possibly with ".lzma" extension). -struct cbfs_file * -cbfs_finddatafile(const char *fname) -{ - int fnlen = strlen(fname); - struct cbfs_file *file = NULL; - for (;;) { - file = cbfs_findprefix(fname, file); - if (!file) - return NULL; - if (file->filename[fnlen] == '\0' - || strcmp(&file->filename[fnlen], ".lzma") == 0) - return file; - } -} - -// Determine whether the file has a ".lzma" extension. -static int -cbfs_iscomp(struct cbfs_file *file) -{ - int fnamelen = strlen(file->filename); - return fnamelen > 5 && strcmp(&file->filename[fnamelen-5], ".lzma") == 0; -} - -// Return the filename of a given file. -const char * -cbfs_filename(struct cbfs_file *file) -{ - return file->filename; -} - -// Determine the uncompressed size of a datafile. -u32 -cbfs_datasize(struct cbfs_file *file) -{ - void *src = (void*)file + ntohl(file->offset); - if (cbfs_iscomp(file)) - return *(u32*)(src + LZMA_PROPERTIES_SIZE); - return ntohl(file->len); -} - // Copy a file to memory (uncompressing if necessary) -int -cbfs_copyfile(struct cbfs_file *file, void *dst, u32 maxlen) +static int +cbfs_copyfile(struct romfile_s *file, void *dst, u32 maxlen) { - if (!CONFIG_COREBOOT || !CONFIG_COREBOOT_FLASH || !file) + if (!CONFIG_COREBOOT || !CONFIG_COREBOOT_FLASH) return -1; - u32 size = ntohl(file->len); - void *src = (void*)file + ntohl(file->offset); - if (cbfs_iscomp(file)) { + u32 size = file->rawsize; + void *src = file->data; + if (file->flags) { // Compressed - copy to temp ram and uncompress it. void *temp = malloc_tmphigh(size); - if (!temp) + if (!temp) { + warn_noalloc(); return -1; + } iomemcpy(temp, src, size); int ret = ulzma(dst, maxlen, temp, size); yield(); @@ -451,6 +330,53 @@ cbfs_copyfile(struct cbfs_file *file, void *dst, u32 maxlen) return size; } +void +coreboot_cbfs_setup(void) +{ + if (!CONFIG_COREBOOT || !CONFIG_COREBOOT_FLASH) + return; + + struct cbfs_header *hdr = *(void **)CBFS_HEADPTR_ADDR; + if (hdr->magic != htonl(CBFS_HEADER_MAGIC)) { + dprintf(1, "Unable to find CBFS (ptr=%p; got %x not %x)\n" + , hdr, hdr->magic, htonl(CBFS_HEADER_MAGIC)); + return; + } + dprintf(1, "Found CBFS header at %p\n", hdr); + + struct cbfs_file *cfile = (void *)(0 - ntohl(hdr->romsize) + + ntohl(hdr->offset)); + for (;;) { + if (cfile < (struct cbfs_file *)(0xFFFFFFFF - ntohl(hdr->romsize))) + break; + u64 magic = cfile->magic; + if (magic != CBFS_FILE_MAGIC) + break; + struct romfile_s *file = malloc_tmp(sizeof(*file)); + if (!file) { + warn_noalloc(); + break; + } + memset(file, 0, sizeof(*file)); + strtcpy(file->name, cfile->filename, sizeof(file->name)); + dprintf(3, "Found CBFS file: %s\n", file->name); + file->size = file->rawsize = ntohl(cfile->len); + file->id = (u32)cfile; + file->copy = cbfs_copyfile; + file->data = (void*)cfile + ntohl(cfile->offset); + int len = strlen(file->name); + if (len > 5 && strcmp(&file->name[len-5], ".lzma") == 0) { + // Using compression. + file->flags = 1; + file->name[len-5] = '\0'; + file->size = *(u32*)(file->data + LZMA_PROPERTIES_SIZE); + } + romfile_add(file); + + cfile = (void*)ALIGN((u32)file->data + file->size, ntohl(hdr->align)); + } +} + struct cbfs_payload_segment { u32 type; u32 compression; @@ -524,20 +450,16 @@ cbfs_run_payload(struct cbfs_file *file) void cbfs_payload_setup(void) { - struct cbfs_file *file = NULL; + if (!CONFIG_COREBOOT || !CONFIG_COREBOOT_FLASH) + return; + struct romfile_s *file = NULL; for (;;) { - file = cbfs_findprefix("img/", file); + file = romfile_findprefix("img/", file); if (!file) break; - const char *filename = cbfs_filename(file); + const char *filename = file->name; char *desc = znprintf(MAXDESCSIZE, "Payload [%s]", &filename[4]); - boot_add_cbfs(file, desc, bootprio_find_named_rom(filename, 0)); + boot_add_cbfs((void*)file->id, desc + , bootprio_find_named_rom(filename, 0)); } } - -void -coreboot_setup(void) -{ - coreboot_fill_map(); - cbfs_setup(); -} diff --git a/src/optionroms.c b/src/optionroms.c index bd2f977..00697b2 100644 --- a/src/optionroms.c +++ b/src/optionroms.c @@ -13,7 +13,6 @@ #include "pci_regs.h" // PCI_ROM_ADDRESS #include "pci_ids.h" // PCI_CLASS_DISPLAY_VGA #include "boot.h" // IPL -#include "paravirt.h" // qemu_cfg_* #include "optionroms.h" // struct rom_header @@ -151,7 +150,8 @@ getRomPriority(u64 *sources, struct rom_header *rom, int instance) return -1; if (source & RS_PCIROM) return bootprio_find_pci_rom((void*)(u32)source, instance); - return bootprio_find_named_rom(romfile_name(source), instance); + struct romfile_s *file = (void*)(u32)source; + return bootprio_find_named_rom(file->name, instance); } @@ -160,15 +160,15 @@ getRomPriority(u64 *sources, struct rom_header *rom, int instance) ****************************************************************/ static struct rom_header * -deploy_romfile(u32 file) +deploy_romfile(struct romfile_s *file) { - u32 size = romfile_size(file); + u32 size = file->size; struct rom_header *rom = rom_reserve(size); if (!rom) { warn_noalloc(); return NULL; } - int ret = romfile_copy(file, rom, size); + int ret = file->copy(file, rom, size); if (ret <= 0) return NULL; return rom; @@ -181,7 +181,7 @@ lookup_hardcode(struct pci_device *pci) char fname[17]; snprintf(fname, sizeof(fname), "pci%04x,%04x.rom" , pci->vendor, pci->device); - u32 file = romfile_find(fname); + struct romfile_s *file = romfile_find(fname); if (file) return deploy_romfile(file); return NULL; @@ -191,14 +191,14 @@ lookup_hardcode(struct pci_device *pci) static void run_file_roms(const char *prefix, int isvga, u64 *sources) { - u32 file = 0; + struct romfile_s *file = NULL; for (;;) { file = romfile_findprefix(prefix, file); if (!file) break; struct rom_header *rom = deploy_romfile(file); if (rom) { - setRomSource(sources, rom, file); + setRomSource(sources, rom, (u32)file); init_optionrom(rom, 0, isvga); } } diff --git a/src/paravirt.c b/src/paravirt.c index 9cf77de..31759e8 100644 --- a/src/paravirt.c +++ b/src/paravirt.c @@ -305,126 +305,44 @@ u16 qemu_cfg_get_max_cpus(void) return cnt; } -static QemuCfgFile LastFile; - -static u32 -__cfg_next_prefix_file(const char *prefix, int prefixlen, u32 prevselect) -{ - if (!qemu_cfg_present) - return 0; - - u32 count; - qemu_cfg_read_entry(&count, QEMU_CFG_FILE_DIR, sizeof(count)); - count = ntohl(count); - u32 e; - for (e = 0; e < count; e++) { - qemu_cfg_read((void*)&LastFile, sizeof(LastFile)); - u32 select = ntohs(LastFile.select); - if (select <= prevselect) - continue; - if (memcmp(prefix, LastFile.name, prefixlen) == 0) - return select; - } - return 0; -} - -u32 qemu_cfg_next_prefix_file(const char *prefix, u32 prevselect) +int qemu_cfg_read_file(struct romfile_s *file, void *dst, u32 maxlen) { - return __cfg_next_prefix_file(prefix, strlen(prefix), prevselect); + if (file->size > maxlen) + return -1; + qemu_cfg_read_entry(dst, file->id, file->size); + return file->size; } -u32 qemu_cfg_find_file(const char *name) -{ - return __cfg_next_prefix_file(name, strlen(name) + 1, 0); -} +struct QemuCfgFile { + u32 size; /* file size */ + u16 select; /* write this to 0x510 to read it */ + u16 reserved; + char name[56]; +}; -static int -__qemu_cfg_set_file(u32 select) +void qemu_cfg_romfile_setup(void) { - if (!qemu_cfg_present || !select) - return -1; - if (select == ntohs(LastFile.select)) - return 0; + if (CONFIG_COREBOOT || !qemu_cfg_present) + return; u32 count; qemu_cfg_read_entry(&count, QEMU_CFG_FILE_DIR, sizeof(count)); count = ntohl(count); u32 e; for (e = 0; e < count; e++) { - qemu_cfg_read((void*)&LastFile, sizeof(LastFile)); - if (select == ntohs(LastFile.select)) - return 0; - } - return -1; -} - -int qemu_cfg_size_file(u32 select) -{ - if (__qemu_cfg_set_file(select)) - return -1; - return ntohl(LastFile.size); -} - -const char* qemu_cfg_name_file(u32 select) -{ - if (__qemu_cfg_set_file(select)) - return NULL; - return LastFile.name; -} - -int qemu_cfg_read_file(u32 select, void *dst, u32 maxlen) -{ - if (__qemu_cfg_set_file(select)) - return -1; - int len = qemu_cfg_size_file(select); - if (len < 0 || len > maxlen) - return -1; - qemu_cfg_read_entry(dst, select, len); - return len; -} - -// Helper function to find, malloc_tmphigh, and copy a romfile. This -// function adds a trailing zero to the malloc'd copy. -void * -romfile_loadfile(const char *name, int *psize) -{ - u32 file = romfile_find(name); - if (!file) - return NULL; - - int filesize = romfile_size(file); - if (!filesize) - return NULL; - - char *data = malloc_tmphigh(filesize+1); - if (!data) { - warn_noalloc(); - return NULL; + struct QemuCfgFile qfile; + qemu_cfg_read((void*)&qfile, sizeof(qfile)); + struct romfile_s *file = malloc_tmp(sizeof(*file)); + if (!file) { + warn_noalloc(); + return; + } + memset(file, 0, sizeof(*file)); + strtcpy(file->name, qfile.name, sizeof(file->name)); + file->size = qfile.size; + file->id = qfile.select; + file->copy = qemu_cfg_read_file; + romfile_add(file); + dprintf(3, "Found fw_cfg file: %s\n", file->name); } - - dprintf(5, "Copying romfile '%s' (len %d)\n", name, filesize); - romfile_copy(file, data, filesize); - if (psize) - *psize = filesize; - data[filesize] = '\0'; - return data; -} - -// Attempt to load an integer from the given file - return 'defval' -// if unsuccesful. -u64 -romfile_loadint(const char *name, u64 defval) -{ - u32 file = romfile_find(name); - if (!file) - return defval; - - int filesize = romfile_size(file); - if (!filesize || filesize > sizeof(u64) || (filesize & (filesize-1))) - // Doesn't look like a valid integer. - return defval; - - u64 val = 0; - romfile_copy(file, &val, sizeof(val)); - return val; } diff --git a/src/paravirt.h b/src/paravirt.h index f39e226..a284c41 100644 --- a/src/paravirt.h +++ b/src/paravirt.h @@ -57,56 +57,13 @@ int qemu_cfg_smbios_load_external(int type, char **p, unsigned *nr_structs, int qemu_cfg_get_numa_nodes(void); void qemu_cfg_get_numa_data(u64 *data, int n); u16 qemu_cfg_get_max_cpus(void); - -typedef struct QemuCfgFile { - u32 size; /* file size */ - u16 select; /* write this to 0x510 to read it */ - u16 reserved; - char name[56]; -} QemuCfgFile; - struct e820_reservation { u64 address; u64 length; u32 type; }; - -u32 qemu_cfg_next_prefix_file(const char *prefix, u32 prevselect); -u32 qemu_cfg_find_file(const char *name); -int qemu_cfg_size_file(u32 select); -const char* qemu_cfg_name_file(u32 select); -int qemu_cfg_read_file(u32 select, void *dst, u32 maxlen); - -// Wrappers that select cbfs or qemu_cfg file interface. -static inline u32 romfile_findprefix(const char *prefix, u32 previd) { - if (CONFIG_COREBOOT) - return (u32)cbfs_findprefix(prefix, (void*)previd); - return qemu_cfg_next_prefix_file(prefix, previd); -} -static inline u32 romfile_find(const char *name) { - if (CONFIG_COREBOOT) - return (u32)cbfs_finddatafile(name); - return qemu_cfg_find_file(name); -} -static inline u32 romfile_size(u32 fileid) { - if (CONFIG_COREBOOT) - return cbfs_datasize((void*)fileid); - return qemu_cfg_size_file(fileid); -} -static inline int romfile_copy(u32 fileid, void *dst, u32 maxlen) { - if (CONFIG_COREBOOT) - return cbfs_copyfile((void*)fileid, dst, maxlen); - return qemu_cfg_read_file(fileid, dst, maxlen); -} -static inline const char* romfile_name(u32 fileid) { - if (CONFIG_COREBOOT) - return cbfs_filename((void*)fileid); - return qemu_cfg_name_file(fileid); -} -void *romfile_loadfile(const char *name, int *psize); -u64 romfile_loadint(const char *name, u64 defval); - u32 qemu_cfg_e820_entries(void); void* qemu_cfg_e820_load_next(void *addr); +void qemu_cfg_romfile_setup(void); #endif diff --git a/src/pci.c b/src/pci.c index 49bc34e..071c302 100644 --- a/src/pci.c +++ b/src/pci.c @@ -5,10 +5,10 @@ // // This file may be distributed under the terms of the GNU LGPLv3 license. +#include "config.h" // CONFIG_* #include "pci.h" // pci_config_writel #include "ioport.h" // outl #include "util.h" // dprintf -#include "paravirt.h" // romfile_loadint #include "farptr.h" // MAKE_FLATPTR #include "pci_regs.h" // PCI_VENDOR_ID #include "pci_ids.h" // PCI_CLASS_DISPLAY_VGA diff --git a/src/post.c b/src/post.c index d2f40f4..1d0d35a 100644 --- a/src/post.c +++ b/src/post.c @@ -214,6 +214,10 @@ startBoot(void) static void maininit(void) { + // Setup romfile items. + qemu_cfg_romfile_setup(); + coreboot_cbfs_setup(); + // Setup ivt/bda/ebda init_ivt(); init_bda(); diff --git a/src/ps2port.c b/src/ps2port.c index c835e14..601e40d 100644 --- a/src/ps2port.c +++ b/src/ps2port.c @@ -7,7 +7,6 @@ #include "ioport.h" // inb #include "util.h" // dprintf -#include "paravirt.h" // romfile_loadint #include "biosvar.h" // GET_LOW #include "ps2port.h" // ps2_kbd_command #include "pic.h" // eoi_pic1 diff --git a/src/ramdisk.c b/src/ramdisk.c index bae30e2..9249a49 100644 --- a/src/ramdisk.c +++ b/src/ramdisk.c @@ -14,15 +14,15 @@ void ramdisk_setup(void) { - if (!CONFIG_COREBOOT || !CONFIG_COREBOOT_FLASH || !CONFIG_FLASH_FLOPPY) + if (!CONFIG_FLASH_FLOPPY) return; // Find image. - struct cbfs_file *file = cbfs_findprefix("floppyimg/", NULL); + struct romfile_s *file = romfile_findprefix("floppyimg/", NULL); if (!file) return; - const char *filename = cbfs_filename(file); - u32 size = cbfs_datasize(file); + const char *filename = file->name; + u32 size = file->size; dprintf(3, "Found floppy file %s of size %d\n", filename, size); int ftype = find_floppy_type(size); if (ftype < 0) { @@ -39,7 +39,9 @@ ramdisk_setup(void) add_e820((u32)pos, size, E820_RESERVED); // Copy image into ram. - cbfs_copyfile(file, pos, size); + int ret = file->copy(file, pos, size); + if (ret < 0) + return; // Setup driver. struct drive_s *drive_g = init_floppy((u32)pos, ftype); diff --git a/src/romfile.c b/src/romfile.c new file mode 100644 index 0000000..b732e29 --- /dev/null +++ b/src/romfile.c @@ -0,0 +1,96 @@ +// Access to pseudo "file" interface for configuration information. +// +// Copyright (C) 2012 Kevin O'Connor <kevin(a)koconnor.net> +// +// This file may be distributed under the terms of the GNU LGPLv3 license. + +#include "config.h" // CONFIG_* +#include "util.h" // dprintf + +static struct romfile_s *RomfileRoot; + +void +romfile_add(struct romfile_s *file) +{ + file->next = RomfileRoot; + RomfileRoot = file; +} + +// Search for the specified file. +static struct romfile_s * +__romfile_findprefix(const char *prefix, int prefixlen, struct romfile_s *prev) +{ + struct romfile_s *cur = RomfileRoot; + if (prev) + cur = prev->next; + while (cur) { + if (memcmp(prefix, cur->name, prefixlen) == 0) + return cur; + cur = cur->next; + } + return NULL; +} + +struct romfile_s * +romfile_findprefix(const char *prefix, struct romfile_s *prev) +{ + return __romfile_findprefix(prefix, strlen(prefix), prev); +} + +struct romfile_s * +romfile_find(const char *name) +{ + return __romfile_findprefix(name, strlen(name) + 1, NULL); +} + +// Helper function to find, malloc_tmphigh, and copy a romfile. This +// function adds a trailing zero to the malloc'd copy. +void * +romfile_loadfile(const char *name, int *psize) +{ + struct romfile_s *file = romfile_find(name); + if (!file) + return NULL; + + int filesize = file->size; + if (!filesize) + return NULL; + + char *data = malloc_tmphigh(filesize+1); + if (!data) { + warn_noalloc(); + return NULL; + } + + dprintf(5, "Copying romfile '%s' (len %d)\n", name, filesize); + int ret = file->copy(file, data, filesize); + if (ret < 0) { + free(data); + return NULL; + } + if (psize) + *psize = filesize; + data[filesize] = '\0'; + return data; +} + +// Attempt to load an integer from the given file - return 'defval' +// if unsuccesful. +u64 +romfile_loadint(const char *name, u64 defval) +{ + struct romfile_s *file = romfile_find(name); + if (!file) + return defval; + + int filesize = file->size; + if (!filesize || filesize > sizeof(u64) || (filesize & (filesize-1))) + // Doesn't look like a valid integer. + return defval; + + u64 val = 0; + int ret = file->copy(file, &val, sizeof(val)); + if (ret < 0) + return defval; + return val; +} diff --git a/src/util.h b/src/util.h index e5d494e..39350cc 100644 --- a/src/util.h +++ b/src/util.h @@ -353,15 +353,11 @@ void smp_probe(void); // coreboot.c extern const char *CBvendor, *CBpart; struct cbfs_file; -struct cbfs_file *cbfs_finddatafile(const char *fname); -struct cbfs_file *cbfs_findprefix(const char *prefix, struct cbfs_file *last); -u32 cbfs_datasize(struct cbfs_file *file); -const char *cbfs_filename(struct cbfs_file *file); -int cbfs_copyfile(struct cbfs_file *file, void *dst, u32 maxlen); void cbfs_run_payload(struct cbfs_file *file); void coreboot_copy_biostable(void); void cbfs_payload_setup(void); void coreboot_setup(void); +void coreboot_cbfs_setup(void); // biostable.c void copy_pir(void *pos); @@ -458,6 +454,24 @@ static inline void free(void *data) { // mtrr.c void mtrr_setup(void); +// romfile.c +struct romfile_s { + struct romfile_s *next; + char name[128]; + u32 size; + int (*copy)(struct romfile_s *file, void *dest, u32 maxlen); + + u32 id; + u32 rawsize; + u32 flags; + void *data; +}; +void romfile_add(struct romfile_s *file); +struct romfile_s *romfile_findprefix(const char *prefix, struct romfile_s *prev); +struct romfile_s *romfile_find(const char *name); +void *romfile_loadfile(const char *name, int *psize); +u64 romfile_loadint(const char *name, u64 defval); + // romlayout.S void reset_vector(void) __noreturn; -- 1.7.6.5

1 0

[PATCH] Remove CanPreempt check from pmm code.
by Kevin O'Connor 31 May '12

31 May '12

The CanPreempt check in pmm is a leftover from when memory could be allocated from the 9-segment. It is no longer needed. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- src/pmm.c | 10 ---------- src/util.h | 1 - 2 files changed, 0 insertions(+), 11 deletions(-) diff --git a/src/pmm.c b/src/pmm.c index 4cee401..5d43645 100644 --- a/src/pmm.c +++ b/src/pmm.c @@ -537,13 +537,6 @@ handle_pmm(u16 *args) u16 arg1 = args[0]; dprintf(DEBUG_HDL_pmm, "pmm call arg1=%x\n", arg1); - int oldpreempt; - if (CONFIG_THREAD_OPTIONROMS) { - // Not a preemption event - don't wait in wait_preempt() - oldpreempt = CanPreempt; - CanPreempt = 0; - } - u32 ret; switch (arg1) { case 0x00: ret = handle_pmm00(args); break; @@ -552,9 +545,6 @@ handle_pmm(u16 *args) default: ret = handle_pmmXX(args); break; } - if (CONFIG_THREAD_OPTIONROMS) - CanPreempt = oldpreempt; - return ret; } diff --git a/src/util.h b/src/util.h index 0d41785..e5d494e 100644 --- a/src/util.h +++ b/src/util.h @@ -225,7 +225,6 @@ void wait_threads(void); struct mutex_s { u32 isLocked; }; void mutex_lock(struct mutex_s *mutex); void mutex_unlock(struct mutex_s *mutex); -extern int CanPreempt; void start_preempt(void); void finish_preempt(void); int wait_preempt(void); -- 1.7.6.5

1 0

Re: [SeaBIOS] [PATCH 0/6] pci patches
by Sebastian Herbszt 30 May '12

30 May '12

ron minnich wrote: > Ah,the A5 BSOD, the bane of my life. > > This is an ACPI issue. > > That last paramter, 494e495f, is a *CLUE*. It is ASCII. It is _INI. No > idea if that helps. > > There is more info available ... just google Windows A5 Stop. > > thanks > > ron Excerpt from KB 314830 [1]: (0x00000003, Parameter2, Parameter3, Parameter4): This error is defined as "ACPI failed must succeed method." This error occurs if ACPI cannot build a control method to reference the ACPI namespace. Other arguments for this error reference the ACPI object that was being run and the name of the control method. One greatly simplified explanation (which might not be completely accurate) is that the system cannot find a way to get to the ACPI tables that define the Plug and Play and Power Management capabilities of the system. [1] http://support.microsoft.com/kb/314830/en-us Sebastian

3 3

[PATCH 00/13] Enhance extra stack and reduce overall 16bit stack usage
by Kevin O'Connor 29 May '12

29 May '12

This patch series reduces the overall stack usage of the 16bit code. The biggest change is the enhancment of the "extra stack" in the e-segment to be re-entrant. The "extra stack" was previously used only by the resume code and disk code. It has been made more flexible so that it can be used by other callers. After this series, SeaBIOS will never expose the extra stack to any external code - on any irq enable or external call point SeaBIOS will jump back to the original stack first. Because the extra stack is only used by SeaBIOS code now, the stack space in use can be tracked and re-entrant callers can be handled safely. All of the hardware irq handlers have been updated to jump into the extra stack upon being called. This makes the stack space used by SeaBIOS based hardware irq handlers virtually zero. -Kevin Kevin O'Connor (13): Rename wait_irq to yield_toirq. Don't restrict VISIBLEx C functions to only x mode. Rename call16 to farcall16. Move farcall16 code from util.c to stacks.c and reorg stacks.c. Replace 32bit->16bit farcall system with regular calls. Make the extra stack re-entrant and "hop back" to check for irqs. Automatically hop off the extra stack when far calling 16bit code. Run all hardware irq handlers on the extra stack. Use the extra stack for 16bit USB and PS2 keyboard/mouse commands. Remove "noinline" declarations from keyboard/mouse driver code. Set noinline on kbd.c interface functions that take stack variable pointers. Make sure to set dependency to segment registers in inline asm. Rework disk.c:fillLCHS to avoid using pointer parameters. src/apm.c | 15 +-- src/asm-offsets.c | 1 + src/boot.c | 6 +- src/clock.c | 22 +++-- src/disk.c | 40 ++++---- src/disk.h | 1 + src/floppy.c | 8 +- src/kbd.c | 30 +++--- src/misc.c | 14 ++- src/mouse.c | 63 ++++++----- src/optionroms.c | 2 +- src/output.c | 9 -- src/post.c | 3 + src/ps2port.c | 8 +- src/resume.c | 2 +- src/romlayout.S | 153 ++++++++++++++++++--------- src/stacks.c | 285 ++++++++++++++++++++++++++++++++++----------------- src/system.c | 6 +- src/types.h | 16 ++-- src/usb-hid.c | 2 +- src/usb.c | 2 +- src/util.c | 62 ++---------- src/util.h | 47 +++------ tools/checkstack.py | 2 +- 24 files changed, 439 insertions(+), 360 deletions(-) -- 1.7.6.5

1 13

Re: [SeaBIOS] OS that don't work?
by Peter Stuge 27 May '12

27 May '12

Fred . wrote: > Why does not Windows 98 work with SeaBIOS? You could contribute significantly to the project by doing the debugging. Asking the question doesn't help much on the other hand. //Peter

1 0

Re: [SeaBIOS] OS that don't work?
by nap 27 May '12

27 May '12

Le 26/05/2012 14:06, Fred . a écrit : > Is there any x86 operating system that SeaBIOS can not boot? > Why? > > _______________________________________________ > SeaBIOS mailing list > SeaBIOS(a)seabios.org > http://www.seabios.org/mailman/listinfo/seabios > SeaBIOS is not currently (1.6.3) fully able to boot W98SE. That is just for information, I am in fact quite happy to be able to use a new box with W98SE. I am currently upgrading from a quite old and deceased box with W98SE on it to a QEMU/SeaBIOS brand new box. After some expected difficulties mostly linked to get proper information, I am now trying to assess the interaction between QEMU/Seabios and W98SE. I can say that during the upgrade process, W98SE recognize SeaBIOS as "BIOS Plug-and-Play", something new to install but W98SE consider it as not functioning properly. If you let W98SE try to install it, it crash with no progress at reboot. If you don't let it install it, it does not crash and at the end of the upgrade it is able to reboot, but not exactly normally, even if you are able to use it. I will commit a full report. So, for me, SeaBIOS is not currently (1.6.3) fully able to boot W98SE.

3 2

OS that don't work?
by Fred . 26 May '12

26 May '12

Is there any x86 operating system that SeaBIOS can not boot? Why?

1 0

VirtualBox BIOS
by Fred . 26 May '12

26 May '12

Can SeaBIOS be used with VirtualBox? Why isn't SeaBIOS the default BIOS in VirtualBox? Since VirtualBox is open source, can or does the SeaBIOS project look at the source code of the BIOS implementation in VirtualBox for hints how things are done? Can SeaBIOS be used with VMware?

1 0

[PATCH 3/3] Misc conversions to GET/SET_LOWFLAT().
by Kevin O'Connor 26 May '12

26 May '12

Convert from GET/SET_FLATPTR() to GET/SET_LOWFLAT() - the latter produces better code. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- src/ata.c | 4 ++-- src/usb.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ata.c b/src/ata.c index b261bfe..3246acb 100644 --- a/src/ata.c +++ b/src/ata.c @@ -408,14 +408,14 @@ ata_try_dma(struct disk_op_s *op, int iswrite, int blocksize) if (count > max) count = max; - SET_FLATPTR(dma->buf_fl, dest); + SET_LOWFLAT(dma->buf_fl, dest); bytes -= count; if (!bytes) // Last descriptor. count |= 1<<31; dprintf(16, "dma@%p: %08x %08x\n", dma, dest, count); dest += count; - SET_FLATPTR(dma->count, count); + SET_LOWFLAT(dma->count, count); dma++; } diff --git a/src/usb.c b/src/usb.c index aaa2c8e..1391f0e 100644 --- a/src/usb.c +++ b/src/usb.c @@ -59,7 +59,7 @@ send_control(struct usb_pipe *pipe, int dir, const void *cmd, int cmdsize int usb_send_bulk(struct usb_pipe *pipe_fl, int dir, void *data, int datasize) { - switch (GET_FLATPTR(pipe_fl->type)) { + switch (GET_LOWFLAT(pipe_fl->type)) { default: case USB_TYPE_UHCI: return uhci_send_bulk(pipe_fl, dir, data, datasize); @@ -73,7 +73,7 @@ usb_send_bulk(struct usb_pipe *pipe_fl, int dir, void *data, int datasize) int noinline usb_poll_intr(struct usb_pipe *pipe_fl, void *data) { - switch (GET_FLATPTR(pipe_fl->type)) { + switch (GET_LOWFLAT(pipe_fl->type)) { default: case USB_TYPE_UHCI: return uhci_poll_intr(pipe_fl, data); -- 1.7.6.5

1 0

[PATCH 2/3] Convert virtio code to use GET/SET_LOWFLAT().
by Kevin O'Connor 26 May '12

26 May '12

Convert from GET/SET_FLATPTR() to GET/SET_LOWFLAT() - the latter produces better code. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- src/virtio-ring.c | 66 ++++++++++++++++++++++++++-------------------------- 1 files changed, 33 insertions(+), 33 deletions(-) diff --git a/src/virtio-ring.c b/src/virtio-ring.c index 97a3ffe..0883330 100644 --- a/src/virtio-ring.c +++ b/src/virtio-ring.c @@ -37,8 +37,8 @@ int vring_more_used(struct vring_virtqueue *vq) { - struct vring_used *used = GET_FLATPTR(vq->vring.used); - int more = GET_FLATPTR(vq->last_used_idx) != GET_FLATPTR(used->idx); + struct vring_used *used = GET_LOWFLAT(vq->vring.used); + int more = GET_LOWFLAT(vq->last_used_idx) != GET_LOWFLAT(used->idx); /* Make sure ring reads are done after idx read above. */ smp_rmb(); return more; @@ -53,19 +53,19 @@ int vring_more_used(struct vring_virtqueue *vq) void vring_detach(struct vring_virtqueue *vq, unsigned int head) { struct vring *vr = &vq->vring; - struct vring_desc *desc = GET_FLATPTR(vr->desc); + struct vring_desc *desc = GET_LOWFLAT(vr->desc); unsigned int i; /* find end of given descriptor */ i = head; - while (GET_FLATPTR(desc[i].flags) & VRING_DESC_F_NEXT) - i = GET_FLATPTR(desc[i].next); + while (GET_LOWFLAT(desc[i].flags) & VRING_DESC_F_NEXT) + i = GET_LOWFLAT(desc[i].next); /* link it with free list and point to it */ - SET_FLATPTR(desc[i].next, GET_FLATPTR(vq->free_head)); - SET_FLATPTR(vq->free_head, head); + SET_LOWFLAT(desc[i].next, GET_LOWFLAT(vq->free_head)); + SET_LOWFLAT(vq->free_head, head); } /* @@ -79,22 +79,22 @@ int vring_get_buf(struct vring_virtqueue *vq, unsigned int *len) { struct vring *vr = &vq->vring; struct vring_used_elem *elem; - struct vring_used *used = GET_FLATPTR(vq->vring.used); + struct vring_used *used = GET_LOWFLAT(vq->vring.used); u32 id; int ret; // BUG_ON(!vring_more_used(vq)); - elem = &used->ring[GET_FLATPTR(vq->last_used_idx) % GET_FLATPTR(vr->num)]; - id = GET_FLATPTR(elem->id); + elem = &used->ring[GET_LOWFLAT(vq->last_used_idx) % GET_LOWFLAT(vr->num)]; + id = GET_LOWFLAT(elem->id); if (len != NULL) - *len = GET_FLATPTR(elem->len); + *len = GET_LOWFLAT(elem->len); - ret = GET_FLATPTR(vq->vdata[id]); + ret = GET_LOWFLAT(vq->vdata[id]); vring_detach(vq, id); - SET_FLATPTR(vq->last_used_idx, GET_FLATPTR(vq->last_used_idx) + 1); + SET_LOWFLAT(vq->last_used_idx, GET_LOWFLAT(vq->last_used_idx) + 1); return ret; } @@ -106,46 +106,46 @@ void vring_add_buf(struct vring_virtqueue *vq, { struct vring *vr = &vq->vring; int i, av, head, prev; - struct vring_desc *desc = GET_FLATPTR(vr->desc); - struct vring_avail *avail = GET_FLATPTR(vr->avail); + struct vring_desc *desc = GET_LOWFLAT(vr->desc); + struct vring_avail *avail = GET_LOWFLAT(vr->avail); BUG_ON(out + in == 0); prev = 0; - head = GET_FLATPTR(vq->free_head); - for (i = head; out; i = GET_FLATPTR(desc[i].next), out--) { - SET_FLATPTR(desc[i].flags, VRING_DESC_F_NEXT); - SET_FLATPTR(desc[i].addr, (u64)virt_to_phys(list->addr)); - SET_FLATPTR(desc[i].len, list->length); + head = GET_LOWFLAT(vq->free_head); + for (i = head; out; i = GET_LOWFLAT(desc[i].next), out--) { + SET_LOWFLAT(desc[i].flags, VRING_DESC_F_NEXT); + SET_LOWFLAT(desc[i].addr, (u64)virt_to_phys(list->addr)); + SET_LOWFLAT(desc[i].len, list->length); prev = i; list++; } - for ( ; in; i = GET_FLATPTR(desc[i].next), in--) { - SET_FLATPTR(desc[i].flags, VRING_DESC_F_NEXT|VRING_DESC_F_WRITE); - SET_FLATPTR(desc[i].addr, (u64)virt_to_phys(list->addr)); - SET_FLATPTR(desc[i].len, list->length); + for ( ; in; i = GET_LOWFLAT(desc[i].next), in--) { + SET_LOWFLAT(desc[i].flags, VRING_DESC_F_NEXT|VRING_DESC_F_WRITE); + SET_LOWFLAT(desc[i].addr, (u64)virt_to_phys(list->addr)); + SET_LOWFLAT(desc[i].len, list->length); prev = i; list++; } - SET_FLATPTR(desc[prev].flags, - GET_FLATPTR(desc[prev].flags) & ~VRING_DESC_F_NEXT); + SET_LOWFLAT(desc[prev].flags, + GET_LOWFLAT(desc[prev].flags) & ~VRING_DESC_F_NEXT); - SET_FLATPTR(vq->free_head, i); + SET_LOWFLAT(vq->free_head, i); - SET_FLATPTR(vq->vdata[head], index); + SET_LOWFLAT(vq->vdata[head], index); - av = (GET_FLATPTR(avail->idx) + num_added) % GET_FLATPTR(vr->num); - SET_FLATPTR(avail->ring[av], head); + av = (GET_LOWFLAT(avail->idx) + num_added) % GET_LOWFLAT(vr->num); + SET_LOWFLAT(avail->ring[av], head); } void vring_kick(unsigned int ioaddr, struct vring_virtqueue *vq, int num_added) { struct vring *vr = &vq->vring; - struct vring_avail *avail = GET_FLATPTR(vr->avail); + struct vring_avail *avail = GET_LOWFLAT(vr->avail); /* Make sure idx update is done after ring write. */ smp_wmb(); - SET_FLATPTR(avail->idx, GET_FLATPTR(avail->idx) + num_added); + SET_LOWFLAT(avail->idx, GET_LOWFLAT(avail->idx) + num_added); - vp_notify(ioaddr, GET_FLATPTR(vq->queue_index)); + vp_notify(ioaddr, GET_LOWFLAT(vq->queue_index)); } -- 1.7.6.5

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS