SeaBIOS

seabios@seabios.org

2 participants
3799 discussions

[PATCH RESEND] nvme: look for NVMe namespace in boot rom file
by Thanos Makatos 22 Apr '21

22 Apr '21

From: Thanos Makatos <thanos(a)nutanix.com> This patch allows specifying an NVMe namespace ID in the boot ROM file in the form /pci@0cf8/*@*/nvme/ns@*, where the 2nd component is the PCI device and the last component is the namespace ID. E.g. booting from namespace 2: boot order: 1: /pci@i0cf8/pci4e58,0001@6/nvme/ns@2 2: /rom(a)genroms/bootfail.bin 3: HAL ... |3ffa9000| Searching bootorder for: /pci@i0cf8/*@6/nvme/ns@2 |3ffa9000| NS 2 prio 1 |3ffa9000| phys_alloc zone=0x3ffbfeb8 size=80 align=10 ret=3ffac6e0 (detail=0x3ffac6b0) |3ffa9000| phys_alloc zone=0x3ffbfeb8 size=24 align=10 ret=3ffac690 (detail=0x3ffac660) |3ffa9000| Registering bootable: NVMe NS 2: 19073 MiB (39062500 512-byte blocks + 0-byte metadata) (type:2 prio:1 data:f4050) |3ffa9000| NVMe initialization complete! \3ffa9000/ End thread If we find a specific namespace we're looking for then we stop probing all other namespaces as there's no point in doing so. If a namespace is not specified in the boot ROM file then we default to the old way of booting from NVMe. As a future optimization we can avoid keeping information for all namespaces and operate on a single namespace at at time. This way we won't run out of memory even if the NVMe controller has the maximum number of namespaces (2^32 - 1). The corresponding QEMU patches haven't been upstreamed yet. Signed-off-by: Thanos Makatos <thanos.makatos(a)nutanix.com> -- Resending patch since it never reached the list, including a more detailed commit message. --- src/boot.c | 12 ++++++++++++ src/hw/nvme.c | 49 +++++++++++++++++++++++++++++++++++++++---------- src/util.h | 1 + 3 files changed, 52 insertions(+), 10 deletions(-) diff --git a/src/boot.c b/src/boot.c index 1effd80..6c2a150 100644 --- a/src/boot.c +++ b/src/boot.c @@ -325,6 +325,18 @@ int bootprio_find_mmio_device(void *mmio) return find_prio(desc); } +int bootprio_find_nvme_device(struct pci_device *pci, u32 ns_id) +{ + if (CONFIG_CSM) + return csm_bootprio_pci(pci); + if (!CONFIG_BOOTORDER) + return -1; + char desc[256], *p; + p = build_pci_path(desc, sizeof(desc), "*", pci); + snprintf(p, desc+sizeof(desc)-p, "/nvme/ns@%u", ns_id); + return find_prio(desc); +} + int bootprio_find_scsi_device(struct pci_device *pci, int target, int lun) { if (!CONFIG_BOOTORDER) diff --git a/src/hw/nvme.c b/src/hw/nvme.c index f26b811..b35a273 100644 --- a/src/hw/nvme.c +++ b/src/hw/nvme.c @@ -233,10 +233,23 @@ nvme_admin_identify_ns(struct nvme_ctrl *ctrl, u32 ns_id) ns_id)->ns; } -static void +static char* +nvme_ns_desc(const struct nvme_namespace *ns, u32 ns_id) +{ + return znprintf(MAXDESCSIZE, "NVMe NS %u: %llu MiB (%llu %u-byte " + "blocks + %u-byte metadata)\n", + ns_id, (ns->lba_count * ns->block_size) >> 20, + ns->lba_count, ns->block_size, + ns->metadata_size); +} + +/* Returns 0 if the namespace is usable, -1 otherwise. */ +static int nvme_probe_ns(struct nvme_ctrl *ctrl, struct nvme_namespace *ns, u32 ns_id, u8 mdts) { + int ret = -1; + ns->ctrl = ctrl; ns->ns_id = ns_id; @@ -288,16 +301,14 @@ nvme_probe_ns(struct nvme_ctrl *ctrl, struct nvme_namespace *ns, u32 ns_id, ns->dma_buffer = zalloc_page_aligned(&ZoneHigh, NVME_PAGE_SIZE); - char *desc = znprintf(MAXDESCSIZE, "NVMe NS %u: %llu MiB (%llu %u-byte " - "blocks + %u-byte metadata)\n", - ns_id, (ns->lba_count * ns->block_size) >> 20, - ns->lba_count, ns->block_size, ns->metadata_size); - + char *desc = nvme_ns_desc(ns, ns_id); dprintf(3, "%s", desc); - boot_add_hd(&ns->drive, desc, bootprio_find_pci_device(ctrl->pci)); + free(desc); + ret = 0; free_buffer: free (id); + return ret; } @@ -635,10 +646,28 @@ nvme_controller_enable(struct nvme_ctrl *ctrl) memset(ctrl->ns, 0, sizeof(*ctrl->ns) * ctrl->ns_count); /* Populate namespace IDs */ - int ns_idx; - for (ns_idx = 0; ns_idx < ctrl->ns_count; ns_idx++) { - nvme_probe_ns(ctrl, &ctrl->ns[ns_idx], ns_idx + 1, identify->mdts); + int ns_idx, first_ns_idx = -1, prio = -1; + for (ns_idx = 0; ns_idx < ctrl->ns_count && prio == -1; ns_idx++) { + if (!nvme_probe_ns(ctrl, &ctrl->ns[ns_idx], ns_idx + 1, identify->mdts)) { + /* Check whether the NS is explicitly specified. */ + if (first_ns_idx == -1) { + first_ns_idx = ns_idx; + } + prio = bootprio_find_nvme_device(ctrl->pci, ns_idx + 1); + } } + /* no NS specified, use the first one */ + if (prio != -1) { + ns_idx--; + } else if (first_ns_idx != -1) { + ns_idx = first_ns_idx; + dprintf(3, "no NVMe NS specified, defaulting to NS %u\n", ns_idx + 1); + prio = bootprio_find_pci_device(ctrl->pci); + } + if (prio != -1) { + boot_add_hd(&ctrl->ns[ns_idx].drive, + nvme_ns_desc(&ctrl->ns[ns_idx], ns_idx + 1), prio); + } dprintf(3, "NVMe initialization complete!\n"); return 0; diff --git a/src/util.h b/src/util.h index 0de3522..ad2d0ef 100644 --- a/src/util.h +++ b/src/util.h @@ -31,6 +31,7 @@ u8 is_bootprio_strict(void); struct pci_device; int bootprio_find_pci_device(struct pci_device *pci); int bootprio_find_mmio_device(void *mmio); +int bootprio_find_nvme_device(struct pci_device *pci, u32 ns_id); int bootprio_find_scsi_device(struct pci_device *pci, int target, int lun); int bootprio_find_scsi_mmio_device(void *mmio, int target, int lun); int bootprio_find_ata_device(struct pci_device *pci, int chanid, int slave); -- 2.22.3

1 0

[PATCH] make BUILD_MIN_BIOSTABLE configurable
by Gerd Hoffmann 16 Apr '21

16 Apr '21

Add config option for BUILD_MIN_BIOSTABLE. Default is 8k for bios images being 256k or larger in size, 2k (current value) otherwise. Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> --- Makefile | 2 +- scripts/layoutrom.py | 3 ++- src/Kconfig | 7 +++++++ 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 3d8943ef5f25..ddcd1dff399d 100644 --- a/Makefile +++ b/Makefile @@ -172,7 +172,7 @@ $(OUT)romlayout16.lds: $(OUT)ccode32flat.o $(OUT)code32seg.o $(OUT)ccode16.o $(O $(Q)$(OBJDUMP) -thr $(OUT)code32flat.o > $(OUT)code32flat.o.objdump $(Q)$(OBJDUMP) -thr $(OUT)code32seg.o > $(OUT)code32seg.o.objdump $(Q)$(OBJDUMP) -thr $(OUT)code16.o > $(OUT)code16.o.objdump - $(Q)$(PYTHON) ./scripts/layoutrom.py $(OUT)code16.o.objdump $(OUT)code32seg.o.objdump $(OUT)code32flat.o.objdump $(OUT)$(KCONFIG_AUTOHEADER) $(OUT)romlayout16.lds $(OUT)romlayout32seg.lds $(OUT)romlayout32flat.lds + $(Q)$(PYTHON) ./scripts/layoutrom.py $(OUT)code16.o.objdump $(OUT)code32seg.o.objdump $(OUT)code32flat.o.objdump $(OUT)$(KCONFIG_AUTOHEADER) $(OUT)romlayout16.lds $(OUT)romlayout32seg.lds $(OUT)romlayout32flat.lds $(CONFIG_MIN_BIOSTABLE) # These are actually built by scripts/layoutrom.py above, but by pulling them # into an extra rule we prevent make -j from spawning layoutrom.py 4 times. diff --git a/scripts/layoutrom.py b/scripts/layoutrom.py index 6616721d1b58..94deca9fcc85 100755 --- a/scripts/layoutrom.py +++ b/scripts/layoutrom.py @@ -636,7 +636,8 @@ def scanconfig(file): def main(): # Get output name - in16, in32seg, in32flat, cfgfile, out16, out32seg, out32flat = sys.argv[1:] + in16, in32seg, in32flat, cfgfile, out16, out32seg, out32flat, biostable = sys.argv[1:] + BUILD_MIN_BIOSTABLE = biostable * 1024 # Read in the objdump information infile16 = open(in16, 'r') diff --git a/src/Kconfig b/src/Kconfig index 3a8ffa15fded..95519fc50fa3 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -140,6 +140,13 @@ endchoice it into 128 KB (which was big enouth for a long time) you'll probably have to disable some featues such as xhci support. + config MIN_BIOSTABLE + int "biostable size (in KB)" + default 8 if ROM_SIZE >= 256 + default 2 + help + Memory space for BIOS tables in f-segment. + endmenu menu "Hardware support" -- 2.30.2

2 1

SeaBIOS only tries to boot from first namespace of NVMe controller
by Thanos Makatos 15 Apr '21

15 Apr '21

I discovered that SeaBIOS only tries to boot from the first NVMe namespace of an NVMe controller. Therefore, if the OS is installed in the 2nd namespace boot will fail. Is there a reason why all other namespaces aren't tried? I've looked at the code and IIUC each namespace is treated as a separate disk. Would we ever want to fix this? If not, maybe we should update the documentation accordingly?

1 0

[PATCH] boot: add config option for fast device init
by Gerd Hoffmann 14 Apr '21

14 Apr '21

Add a config option for fast device init (i.e. skip non-bootable devices). This optimization breaks boot in some rare configurations, specifically in case the boot loader needs access to secondary disks. Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> --- src/boot.c | 2 ++ src/Kconfig | 10 ++++++++++ 2 files changed, 12 insertions(+) diff --git a/src/boot.c b/src/boot.c index 1effd802ce06..771d2382e38f 100644 --- a/src/boot.c +++ b/src/boot.c @@ -299,6 +299,8 @@ u8 is_bootprio_strict(void) { static int prio_halt = -2; + if (!CONFIG_BOOT_FAST_INIT) + return 0; if (prio_halt == -2) prio_halt = find_prio("HALT"); return prio_halt >= 0; diff --git a/src/Kconfig b/src/Kconfig index 3a8ffa15fded..6b750a41b42c 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -72,6 +72,16 @@ endchoice help Support controlling of the boot order via the fw_cfg/CBFS "bootorder" file. + config BOOT_FAST_INIT + depends on BOOTORDER + bool "Fast boot device init" + default y + help + Skip initialization for devices without bootindex. Speeds + up boot and reduced memory footprint, but may cause boot + problems in case the bootloader needs access to secondary + disks. + config HOST_BIOS_GEOMETRY depends on BOOT bool "Boot device bios geometry override" -- 2.30.2

3 5

SeaBIOS debugging - breakpoint placement problems
by Krzysztof Bordon 14 Apr '21

14 Apr '21

Hello, I am experiencing problems with effective breakpoint setting at particular addresses while debugging Seabios with GNU GDB. The problem is that placing a breakpoint at an address (i.e.) *0xc3a8a, which belongs to vgabios region, and specifying an ignore count say 5 should make the gdb stop at it after it hits 5 times the address (on the 6th hit), but it never does - it seems to ignore the "ignore count" and stop on the next crossing instead. The same happens with some other addresses, like 0xf732a. What's more - the output of "info b" command shows that ignore counter is not updated after a hit. I suppose the reason for this misbehavior might be that those addresses belong to regions that are read only - the 0xc3a8a is a vga rom address and the 0xf732a lies somewhere in the rodata section. But if that was the case, hardware breakpoints could work, but neither those can. This is the example session showing the problem: $ ./qemu-system-x86_64 -s -S -singlestep -machine type=q35 -m 4096 -bios ~/Pobrane/seabios_1.14.0.orig/seabios-1.14.0/out/bios.bin $ $ gdb -q (gdb) target remote localhost:1234 Remote debugging using localhost:1234 warning: No executable has been specified and target does not support determining executable automatically. Try using the "file" command. 0x000000000000fff0 in ?? () (gdb) b *0xf732a Breakpoint 1 at 0xf732a (gdb) ignore 1 5 Will ignore next 5 crossings of breakpoint 1. (gdb) c Continuing. Program received signal SIGTRAP, Trace/breakpoint trap. 0x000000000000732a in ?? () (gdb) info b Num Type Disp Enb Address What 1 breakpoint keep y 0x00000000000f732a ignore next 5 hits (gdb) c Continuing. Program received signal SIGTRAP, Trace/breakpoint trap. 0x000000000000732a in ?? () (gdb) info b Num Type Disp Enb Address What 1 breakpoint keep y 0x00000000000f732a ignore next 5 hits I am using qemu 5.2.0, GNU gdb (Ubuntu 9.2-0ubuntu2) 9.2, and SeaBIOS 1.14.0 Is it possible to set a bp on any of the mentioned addresses so that their ignore counters are taken into account ?

1 0

Bump max MPTABLE and SMBIOS sizes from 600 to 768
by Mike Banon 04 Apr '21

04 Apr '21

There are plenty of coreboot platforms whose MPTABLE size is just slightly larger than the current uneven limit of 600 bytes, which prevents these important tables from being copied. For example, G505S has 628 bytes and A88XM-E has 740 bytes. I propose 768 bytes as a new saner default for MPTABLE size, to replace the current uneven limit of 600. SMBIOS size should be bumped the similar way as well. Signed-off-by: Mike Banon <mikebdp2 at gmail.com> --- diff --git a/src/config.h b/src/config.h index 93c8dbc..71333f8 100644 --- a/src/config.h +++ b/src/config.h @@ -21,9 +21,9 @@ // Largest supported externaly facing drive id #define BUILD_MAX_EXTDRIVE 16 // Number of bytes the smbios may be and still live in the f-segment -#define BUILD_MAX_SMBIOS_FSEG 600 +#define BUILD_MAX_SMBIOS_FSEG 768 // Maximum number of bytes the mptable may be and still be copied to f-segment -#define BUILD_MAX_MPTABLE_FSEG 600 +#define BUILD_MAX_MPTABLE_FSEG 768 #define BUILD_MODEL_ID 0xFC #define BUILD_SUBMODEL_ID 0x00

2 5

[PATCH] malloc: Add check to avoid dereference NULL pointer.
by likejun (A) 03 Apr '21

03 Apr '21

From: Kejun Li <likejun6(a)huawei.com<mailto:likejun6@huawei.com>> Date: Mon, 22 Mar 2021 14:03:10 +0800 Subject: [PATCH] malloc: Add check to avoid dereference NULL pointer. info = alloc_find_lowest() may return NULL, should check before dereference it to avoid potential coredump. Signed-off-by: Kejun Li <likejun6(a)huawei.com<mailto:likejun6@huawei.com>> --- src/malloc.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/malloc.c b/src/malloc.c index 3733855..d355b77 100644 --- a/src/malloc.c +++ b/src/malloc.c @@ -544,10 +544,12 @@ malloc_prepboot(void) // Clear unused f-seg ram. struct allocinfo_s *info = alloc_find_lowest(&ZoneFSeg); - u32 size = info->range_end - info->range_start; - memset(memremap(info->range_start, size), 0, size); - dprintf(1, "Space available for UMB: %x-%x, %x-%x\n" - , RomEnd, base, info->range_start, info->range_end); + if (info) { + u32 size = info->range_end - info->range_start; + memset(memremap(info->range_start, size), 0, size); + dprintf(1, "Space available for UMB: %x-%x, %x-%x\n" + , RomEnd, base, info->range_start, info->range_end); + } // Give back unused high ram. info = alloc_find_lowest(&ZoneHigh); -- 2.19.1

2 1

[PATCH] AHCI: The attached ATA device cannot be detected when binding AHCI controller to Virtual Machine
by RunaGuo-oc＠zhaoxin.com 29 Mar '21

29 Mar '21

When binding AHCI controller to virtual machine, the attached ATA device cannot be recognized for the following reason: The first Identify PACKET CMD will be failed without dobut which will lead PORT_IRQ_TF_ERR be set in PxIS due to ERR bit set to 1 in D2H Register FIS(PxTFD.STS.ERR=1). In this case, the first CMD will be timeout for seabios only polling PORT_IRQ_D2H_REG_FIS & PORT_IRQ_PIOS_FIS before triggering error handling which leads AHCI controller is an error state, then the second IDENTIFY CMD cannot be issued by AHCI controller, no ATA device will be detected. In AHCI spec HBA Port State Machine section(5.3.8.1 and 5.3.16.5), we can see this sequence: RegFIS:Entry --> ERR:FatalTaskfile (PxTFD.STS.ERR=1) --> ERR:WaitForClear, no entry for PORT_IRQ_D2H_REG_FIS/PORT_IRQ_PIOS_FIS to be set at this time. May be we can also add PORT_IRQ_TF_ERR bit check when polling command completion status? fail log: 02.386: |bffa6000| AHCI/1: link up 02.387: |bffa6000| AHCI/1: send cmd ... 02.387: |bffa7000| phys_free bffa9c00 (detail=0xbffaa320) 02.396: |bffa7000| phys_free bffaa200 (detail=0xbffaa1d0) 02.396: |bffa7000| phys_free bffaa000 (detail=0xbffaa1a0) 02.396: |bffa7000| phys_free bffaa380 (detail=0xbffaa350) 02.400: \bffa7000/ End thread 02.401: phys_free bffa7000 (detail=0xbffaa170) 34.391: |bffa6000| WARNING - Timeout at ahci_command:153! 34.392: |bffa6000| AHCI/1: send cmd ... 66.397: |bffa6000| WARNING - Timeout at ahci_command:153! Signed-off-by: zhaoxin\runaguooc <RunaGuo-oc(a)zhaoxin.com> --- src/hw/ahci.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/hw/ahci.c b/src/hw/ahci.c index d45b430..bab5c35 100644 --- a/src/hw/ahci.c +++ b/src/hw/ahci.c @@ -104,7 +104,7 @@ static void ahci_port_writel(struct ahci_ctrl_s *ctrl, u32 pnr, u32 reg, u32 val static int ahci_command(struct ahci_port_s *port_gf, int iswrite, int isatapi, void *buffer, u32 bsize) { - u32 val, status, success, flags, intbits, error; + u32 val, status, success, flags, intbits, error, tf; struct ahci_ctrl_s *ctrl = port_gf->ctrl; struct ahci_cmd_s *cmd = port_gf->cmd; struct ahci_fis_s *fis = port_gf->fis; @@ -148,6 +148,14 @@ static int ahci_command(struct ahci_port_s *port_gf, int iswrite, int isatapi, error = GET_LOWFLAT(fis->rfis[3]); break; } + + if(intbits & PORT_IRQ_TF_ERR){ + tf = ahci_port_readl(ctrl,pnr,PORT_TFDATA); + status = tf & 0xff; + error = tf & 0xff00; + break; + } + } if (timer_check(end)) { warn_timeout(); -- 2.17.1

6 9

[PATCH v3] The attached ATA device cannot be detected when binding AHCI controller to Virtual Machine
by zhaoxin\runaguooc 29 Mar '21

29 Mar '21

From: Runa Guo-oc <RunaGuo-oc(a)zhaoxin.com> 1: The first ATA_CMD_IDENTIFY_PACKET_DEVICE command will be failed for ATA device with PORT_IRQ_IF_ERR from ahci spec; 2: I have not yet found any evidences which can be used to combine above fail with PORT_IRQ_D2H/PIO_FIS set to 1 from ahci spec; 3: Seabios code only polling PORT_IRQ_D2H/PIO_FIS for command completion, then the above fail will be regarded as timeout, no eh will be triggered to reset port state machine, then the following ATA_ID_CMD will not be issued by HAB. May be the following patch will be work. Signed-off-by: Runa Guo-oc <RunaGuo-oc(a)zhaoxin.com> --- src/hw/ahci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hw/ahci.c b/src/hw/ahci.c index d45b430..c9d379d 100644 --- a/src/hw/ahci.c +++ b/src/hw/ahci.c @@ -143,7 +143,7 @@ static int ahci_command(struct ahci_port_s *port_gf, int iswrite, int isatapi, error = GET_LOWFLAT(fis->psfis[3]); break; } - if (intbits & 0x01) { + if (intbits & (0x01| PORT_IRQ_TF_ERR)) { status = GET_LOWFLAT(fis->rfis[2]); error = GET_LOWFLAT(fis->rfis[3]); break; -- 2.17.1

1 0

seabios unable to boot from iscsi disk in a vm with 11 virtio disks and 1 iscsi disk.
by Yiguang Chen 26 Mar '21

26 Mar '21

The seabios version is ref-1.13.0. I have a qemu vm with 11 virtio disks and 1 iscsi disk. The iscsi disk has a bootable windows system and the bootorder is '1'. When the vm start, the seabios show me "No bootable device". 

2 2

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS