SeaBIOS

seabios@seabios.org

2 participants
3799 discussions

[PATCH v2] make BUILD_MIN_BIOSTABLE configurable
by Gerd Hoffmann 27 May '21

27 May '21

BUILD_MIN_BIOSTABLE reserves space in the f-segment. Some data structures -- for example disk drives known to seabios -- must be stored there, so the space available here limits the number of devices seabios is able to manage. This patch adds an config option for BUILD_MIN_BIOSTABLE so the size of the reservation can be configured at build time. Default is 8k for bios images being 256k or larger in size (32bit code is moved off then so we have more room in the f-segment), 2k (current value) otherwise. Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> --- Makefile | 2 +- scripts/layoutrom.py | 3 ++- src/Kconfig | 7 +++++++ 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 3d8943ef5f25..ddcd1dff399d 100644 --- a/Makefile +++ b/Makefile @@ -172,7 +172,7 @@ $(OUT)romlayout16.lds: $(OUT)ccode32flat.o $(OUT)code32seg.o $(OUT)ccode16.o $(O $(Q)$(OBJDUMP) -thr $(OUT)code32flat.o > $(OUT)code32flat.o.objdump $(Q)$(OBJDUMP) -thr $(OUT)code32seg.o > $(OUT)code32seg.o.objdump $(Q)$(OBJDUMP) -thr $(OUT)code16.o > $(OUT)code16.o.objdump - $(Q)$(PYTHON) ./scripts/layoutrom.py $(OUT)code16.o.objdump $(OUT)code32seg.o.objdump $(OUT)code32flat.o.objdump $(OUT)$(KCONFIG_AUTOHEADER) $(OUT)romlayout16.lds $(OUT)romlayout32seg.lds $(OUT)romlayout32flat.lds + $(Q)$(PYTHON) ./scripts/layoutrom.py $(OUT)code16.o.objdump $(OUT)code32seg.o.objdump $(OUT)code32flat.o.objdump $(OUT)$(KCONFIG_AUTOHEADER) $(OUT)romlayout16.lds $(OUT)romlayout32seg.lds $(OUT)romlayout32flat.lds $(CONFIG_MIN_BIOSTABLE) # These are actually built by scripts/layoutrom.py above, but by pulling them # into an extra rule we prevent make -j from spawning layoutrom.py 4 times. diff --git a/scripts/layoutrom.py b/scripts/layoutrom.py index 6616721d1b58..94deca9fcc85 100755 --- a/scripts/layoutrom.py +++ b/scripts/layoutrom.py @@ -636,7 +636,8 @@ def scanconfig(file): def main(): # Get output name - in16, in32seg, in32flat, cfgfile, out16, out32seg, out32flat = sys.argv[1:] + in16, in32seg, in32flat, cfgfile, out16, out32seg, out32flat, biostable = sys.argv[1:] + BUILD_MIN_BIOSTABLE = biostable * 1024 # Read in the objdump information infile16 = open(in16, 'r') diff --git a/src/Kconfig b/src/Kconfig index 3a8ffa15fded..95519fc50fa3 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -140,6 +140,13 @@ endchoice it into 128 KB (which was big enouth for a long time) you'll probably have to disable some featues such as xhci support. + config MIN_BIOSTABLE + int "biostable size (in KB)" + default 8 if ROM_SIZE >= 256 + default 2 + help + Memory space for BIOS tables in f-segment. + endmenu menu "Hardware support" -- 2.31.1

2 1

[PATCH v2 0/1] fix PS/2 keyboard initialization failures
by Volker Rümelin 26 May '21

26 May '21

Hi, I wrote a few patches for qemu [1] and patch 10/11 exposes a bug in seabios. Sometimes the PS/2 keyboard initialization fails and seabios doesn't detect the keyboard. This patch fixes the PS/2 keyboard initialization. I wouldn't be surprised if my patch also fixes PS/2 keyboard initialization problems on bare metal. A few bug reports look very similar to what I see on my computer with qemu. With best regards, Volker v2: Kevin suggested to call check_irqs() in run_thread(). [1] https://lists.nongnu.org/archive/html/qemu-devel/2021-05/msg02152.html Volker Rümelin (1): stacks: call check_irqs() in run_thread() src/stacks.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) -- 2.26.2

2 3

[PATCH] vgasrc/vgalayout.lds.S: ignore .node.gnu.property (binutils-2.36 support)
by Sergei Trofimovich 26 May '21

26 May '21

From: Sergei Trofimovich <slyfox(a)gentoo.org> Modern binutils unconditionally tracks x86_64 ISA levels in intermediate files in .note.gnu.property. Custom liker script does not handle the section and complains about it: ld --gc-sections -T out/vgasrc/vgalayout.lds out/vgaccode16.o \ out/vgaentry.o out/vgaversion.o -o out/vgarom.o ld: section .note.gnu.property LMA [0000000000000000,0000000000000027] \ overlaps section .text LMA [0000000000000000,00000000000098af] The change ignores .note.gnu.property section. Signed-off-by: Sergei Trofimovich <slyfox(a)gentoo.org> --- vgasrc/vgalayout.lds.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vgasrc/vgalayout.lds.S b/vgasrc/vgalayout.lds.S index 533734d..e17d89e 100644 --- a/vgasrc/vgalayout.lds.S +++ b/vgasrc/vgalayout.lds.S @@ -19,5 +19,5 @@ SECTIONS // Discard regular data sections to force a link error if // 16bit code attempts to access data not marked with VAR16. - /DISCARD/ : { *(.text*) *(.rodata*) *(.data*) *(.bss*) *(COMMON) } + /DISCARD/ : { *(.text*) *(.rodata*) *(.data*) *(.bss*) *(COMMON) *(.note.gnu.property) } } -- 2.31.1

2 4

SeaBIOS fails to boot from NVMe controller with lots of namespaces
by Thanos Makatos 26 May '21

26 May '21

I'm using SeaBIOS (b0d61ec) to boot from a virtual NVMe controller that has relatively many namespaces (64). The exact error is : /3ff9f000\ Start thread |3ff9f000| Searching bootorder for: /pci@i0cf8/*@6 ... |3ff9f000| WARNING - Unable to allocate resource at nvme_controller_enable:632! I changed the number of namespaces my controller reports to 1 and it worked fine. Is there an easy way to get around this or do I have to fix the code? I haven't looked at the code in detail, but I think we don't have to allocate the array of namespaces in nvme_controller_enable; instead, we can probe a namespace right before we attempt to boot from it (not sure where exactly this is done).

4 16

patch: add run-time option to load but not execute option roms
by Leah Rowe 22 May '21

22 May '21

Hi, Can someone review this patch? It's a very simple one. Applied on top of commit 9b30973d7db7572dc8bae301a1f8259992e6d215 using `git am` I'm Leah from the Libreboot project

2 3

Anonymous git clone access broken?
by Pvt Snafu 22 May '21

22 May '21

Hi, I'm more of a follower than a contributor, but I've kind of followed the seabios project for awhile. I like to keep my git repos up to date. However, when I run: $ git pull fatal: unable to update url base from redirection: asked for: https://git.seabios.org/cgit/seabios.git/info/refs?service=git-upload-pack redirect: https://review.coreboot.org/plugins/gitiles/seabios/ Now, mind you, my remote was set to git.seabios.org/cgit/seabios.git. So seeing the error, I opted to go to the repository myself to see what the matter was. My browser redirected me to https://review.coreboot.org/plugins/gitiles/seabios/ which included a directive to "git clone ssh://review.coreboot.org:29418/seabios" to clone the repo. So I tried it. However, this failed with: $ git clone ssh://review.coreboot.org:29418/seabios Cloning into 'seabios'... xxxxxxxx(a)review.coreboot.org: Permission denied (publickey). fatal: Could not read from remote repository. Obviously my pubkey isn't going to be in any authorized_keys file, nor would I expect it to be. So my question is: how do I keep my seabios repo up-to-date, as the repo seems to have moved and something is possibly fubar. Is anonymous read-only access even a thing for seabios anymore?

2 1

New build warnings by GCC 11
by Paul Menzel 22 May '21

22 May '21

Dear SeaBIOS folks, Using GCC 11.1 to build SeaBIOS I get the warnings below. ``` In file included from scripts/kconfig/zconf.tab.c:2534: /dev/shm/coreboot/payloads/external/SeaBIOS/seabios/scripts/kconfig/confdata.c: In function 'conf_write': /dev/shm/coreboot/payloads/external/SeaBIOS/seabios/scripts/kconfig/confdata.c:774:20: warning: '.tmpconfig.' directive writing 11 bytes into a region of size between 1 and 4097 [-Wformat-overflow=] 774 | sprintf(tmpname, "%s.tmpconfig.%d", dirname, (int)getpid()); | ^~~~~~~~~~~~~~~~~ /dev/shm/coreboot/payloads/external/SeaBIOS/seabios/scripts/kconfig/confdata.c:774:3: note: 'sprintf' output between 13 and 4119 bytes into a destination of size 4097 774 | sprintf(tmpname, "%s.tmpconfig.%d", dirname, (int)getpid()); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` ``` Compile checking out/src/post.o src/post.c: In function 'reloc_preinit': src/post.c:248:34: warning: array subscript 'u32 {aka unsigned int}[0]' is partly outside array bounds of 'char[1]' [-Warray-bounds] 248 | *((u32*)(dest + *reloc)) += delta; | ^~ In file included from src/biosvar.h:11, from src/post.c:8: src/post.c:278:26: note: while referencing 'code32flat_start' 278 | updateRelocs(VSYMBOL(code32flat_start), VSYMBOL(_reloc_init_start) | ^~~~~~~~~~~~~~~~ src/memmap.h:18:36: note: in definition of macro 'SYMBOL' 18 | #define SYMBOL(SYM) ({ extern char SYM; (u32)&SYM; }) | ^~~ src/post.c:278:18: note: in expansion of macro 'VSYMBOL' 278 | updateRelocs(VSYMBOL(code32flat_start), VSYMBOL(_reloc_init_start) | ^~~~~~~ src/post.c:248:34: warning: array subscript 'u32 {aka unsigned int}[0]' is partly outside array bounds of 'char[1]' [-Warray-bounds] 248 | *((u32*)(dest + *reloc)) += delta; | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ In file included from src/biosvar.h:11, from src/post.c:8: src/post.c:278:26: note: while referencing 'code32flat_start' 278 | updateRelocs(VSYMBOL(code32flat_start), VSYMBOL(_reloc_init_start) | ^~~~~~~~~~~~~~~~ src/memmap.h:18:36: note: in definition of macro 'SYMBOL' 18 | #define SYMBOL(SYM) ({ extern char SYM; (u32)&SYM; }) | ^~~ src/post.c:278:18: note: in expansion of macro 'VSYMBOL' 278 | updateRelocs(VSYMBOL(code32flat_start), VSYMBOL(_reloc_init_start) | ^~~~~~~ ``` ``` Compile checking out/src/fw/smm.o In file included from src/fw/smm.c:18: In function 'smm_save_and_copy', inlined from 'ich9_lpc_apmc_smm_setup' at src/fw/smm.c:216:5: src/string.h:23:16: warning: '__builtin_memcpy' offset [0, 511] is out of the bounds [0, 0] [-Warray-bounds] 23 | #define memcpy __builtin_memcpy src/fw/smm.c:148:5: note: in expansion of macro 'memcpy' 148 | memcpy(&smm->cpu, &initsmm->cpu, sizeof(smm->cpu)); | ^~~~~~ In function 'smm_relocate_and_restore', inlined from 'ich9_lpc_apmc_smm_setup' at src/fw/smm.c:227:5: src/string.h:23:16: warning: '__builtin_memcpy' offset [0, 511] is out of the bounds [0, 0] [-Warray-bounds] 23 | #define memcpy __builtin_memcpy src/fw/smm.c:171:5: note: in expansion of macro 'memcpy' 171 | memcpy(&initsmm->cpu, &smm->cpu, sizeof(initsmm->cpu)); | ^~~~~~ ``` ``` Compiling whole program out/ccode32flat.o In file included from out/ccode32flat.o.tmp.c:42: ./src/post.c: In function 'dopost': ./src/post.c:248:34: warning: array subscript 'u32 {aka unsigned int}[0]' is partly outside array bounds of 'char[1]' [-Warray-bounds] 248 | *((u32*)(dest + *reloc)) += delta; | ^~ In file included from ./src/biosvar.h:11, from ./src/misc.c:8, from out/ccode32flat.o.tmp.c:1: ./src/fw/shadow.c:190:29: note: while referencing 'code32flat_start' 190 | u32 cstart = SYMBOL(code32flat_start), cend = SYMBOL(code32flat_end); | ^~~~~~~~~~~~~~~~ ./src/memmap.h:18:36: note: in definition of macro 'SYMBOL' 18 | #define SYMBOL(SYM) ({ extern char SYM; (u32)&SYM; }) | ^~~ In file included from out/ccode32flat.o.tmp.c:42: ./src/post.c:248:34: warning: array subscript 'u32 {aka unsigned int}[0]' is partly outside array bounds of 'char[1]' [-Warray-bounds] 248 | *((u32*)(dest + *reloc)) += delta; | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ In file included from ./src/biosvar.h:11, from ./src/misc.c:8, from out/ccode32flat.o.tmp.c:1: ./src/fw/shadow.c:190:29: note: while referencing 'code32flat_start' 190 | u32 cstart = SYMBOL(code32flat_start), cend = SYMBOL(code32flat_end); | ^~~~~~~~~~~~~~~~ ./src/memmap.h:18:36: note: in definition of macro 'SYMBOL' 18 | #define SYMBOL(SYM) ({ extern char SYM; (u32)&SYM; }) | ``` Kind regards, Paul

1 0

[PATCH 0/1] fix PS/2 keyboard initialization failures
by Volker Rümelin 21 May '21

21 May '21

Hi, I wrote a few patches for qemu [1] and patch 10/11 exposes a bug in seabios. Sometimes the PS/2 keyboard initialization fails and seabios doesn't detect the keyboard. This patch fixes the PS/2 keyboard initialization. I wouldn't be surprised if my patch also fixes PS/2 keyboard initialization problems on bare metal. A few bug reports look very similar to what I see on my computer with qemu. With best regards, Volker [1] https://lists.nongnu.org/archive/html/qemu-devel/2021-05/msg02152.html Volker Rümelin (1): stacks: always call check_irqs() in yield() src/stacks.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) -- 2.26.2

2 6

[PATCH v2 0/3] Add support for all HD and QXGA resolutions
by Elliot Killick 21 May '21

21 May '21

Hi, This patch series adds support for all HD and QXGA resolutions. I've taken Gerd's advice on the v1 patch and split the formatting improvments into a separate patch. I also tried to take Gerd's advice on removing some of the older colors depths for higher resolutions. However, upon doing this Windows was no longer recognizing some of the resolutions so I had to add them back. I split that up into a separate patch in case anyone wants to try and reproduce the issue. But, it should be fine to include those common color depths anyway for maximal compatibility. Best regards, Elliot Elliot Killick (3): svgamodes: Add all HD and QXGA resolutions svgamodes: Improve formatting svgamodes: Add color depths other than just 32-bit vgasrc/svgamodes.c | 217 +++++++++++++++++++++++++++++---------------- 1 file changed, 140 insertions(+), 77 deletions(-) -- 2.30.0

3 6

Invitation: [Events] "vBeer v2" online Party! - 7th May at 3PM UTC @ Fri 7 May 17:00 - Sat 8 May 2021 01:30 (CEST) (seabios@seabios.org)
by pietrushnic＠gmail.com 05 May '21

05 May '21

You have been invited to the following event. Title: [Events] "vBeer v2" online Party! - 7th May at 3PM UTC Dear friends, on behalf of 3mdeb I invite you to a fresh "vBeer v2"! Let's discuss the open/libre firmware/hardware and other nice embedded things you have in mind. To join us go to http://vpub.3mdeb.com/may7th on 7th May at 3PM UTCat "v1" there was a great discussion with 50 firmware masters from all over the world! Here's my blogpost about it. And this time - together with your surprise suggestions (you're welcome!) - we could explore:new advances at opensource firmware/hardware world, like this new initiative for opensource FPGAsis the new emerging RISC-V hardware such as BeagleV - truly open?results of "Ideal platform for coreboot training" survey (which is still going on btw)- and much more! There'd be a productive talk with a cosy atmosphere and good vibes - so, feel invited and take your beer! ;) http://vpub.3mdeb.com/may7th , 7th May at 3PM UTC When: Fri 7 May 17:00 – Sat 8 May 2021 01:30 Central European Time - Warsaw Joining info: Join with Google Meet https://meet.google.com/nbv-azeo-mrp?hs=224 Calendar: seabios(a)seabios.org Who: * pietrushnic(a)gmail.com- organiser * mikebdp2(a)gmail.com- creator * insurgotech(a)gmail.com * rminnich(a)gmail.com * thierry.laurion(a)gmail.com * michal.zygowski(a)3mdeb.com * ntzrmtthihu777(a)gmail.com * krystian.hebel(a)3mdeb.com * getinaks(a)gmail.com * pkubaj(a)anongoth.pl * florian.samson(a)bsi.bund.de * felixsinger(a)posteo.net * mobil(a)fsamson.de * info(a)orangecms.org * w96k(a)riseup.net * andrew.cooper3(a)citrix.com * xx.pechoes.xx(a)gmail.com * marvin(a)ceres-sys.de * hudson(a)trmm.net * david.hendricks(a)gmail.com * thrilleratplay(a)gmail.com * klaus(a)linux.vnet.ibm.com * tcrawford(a)system76.com * jason.glenesk(a)gmail.com * felix-coreboot(a)felixheld.de * jaytalbott(a)sysproconsulting.com * Martin Roth * matt.devillier(a)gmail.com * grao.v80(a)gmail.com * marshalldawson3rd(a)gmail.com * Patrick Georgi * christian.walter(a)9elements.com * th3fanbus(a)gmail.com * epeers(a)google.com * jonzhang(a)fb.com * stefan.reinauer(a)coreboot.org * rphagura(a)fb.com * werner.zeh(a)siemens.com * harshitsharmajs(a)gmail.com * arthur(a)aheymans.xyz * nico.h(a)gmx.de * paulepanter(a)users.sourceforge.net * lynxis(a)fe80.eu * qmastery16(a)gmail.com * michael.larabel(a)phoronix.com * rrangel(a)chromium.org * richard(a)hughsie.com * Furquan Shaikh * foss(a)mniewoehner.de * jsteckli(a)amazon.de * subrata.banik(a)intel.com * anpetrov(a)fb.com * quasisec(a)chromium.org * aklm(a)chromium.org * admin(a)starlabs.systems * buurin(a)gmail.com * seabios(a)seabios.org * nartemiev(a)google.com * Aaron Durbin * peter(a)stuge.se * matthewwbradley6(a)gmail.com * bruts(a)netc.fr * akuss(a)protonmail.ch Event details: https://calendar.google.com/calendar/event?action=VIEW&eid=Mjh0M2RqbnBoM2I5… Invitation from Google Calendar: https://calendar.google.com/calendar/ You are receiving this courtesy email at the account seabios(a)seabios.org because you are an attendee of this event. To stop receiving future updates for this event, decline this event. Alternatively, you can sign up for a Google Account at https://calendar.google.com/calendar/ and control your notification settings for your entire calendar. Forwarding this invitation could allow any recipient to send a response to the organiser and be added to the guest list, invite others regardless of their own invitation status or to modify your RSVP. Learn more at https://support.google.com/calendar/answer/37135#forwarding

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS