SeaBIOS

seabios@seabios.org

4 participants
3801 discussions

[PATCH] boot: Change ":rom%d" boot order rom instance to ":rom%x"
by Kevin O'Connor 26 Aug '14

26 Aug '14

Use hex numbers for the rom instance count in boot order open firmware device naming. The ":rom" suffix isn't part of a standard and it's highly unlikely any rom would have 10 or more drives on it, but this change makes the code more similar to the numbering of other boot order devices. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- src/boot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/boot.c b/src/boot.c index 34088c8..f23e9e1 100644 --- a/src/boot.c +++ b/src/boot.c @@ -189,7 +189,7 @@ int bootprio_find_pci_rom(struct pci_device *pci, int instance) char desc[256], *p; p = build_pci_path(desc, sizeof(desc), "*", pci); if (instance) - snprintf(p, desc+sizeof(desc)-p, ":rom%d", instance); + snprintf(p, desc+sizeof(desc)-p, ":rom%x", instance); return find_prio(desc); } @@ -201,7 +201,7 @@ int bootprio_find_named_rom(const char *name, int instance) char desc[256], *p; p = desc + snprintf(desc, sizeof(desc), "/rom@%s", name); if (instance) - snprintf(p, desc+sizeof(desc)-p, ":rom%d", instance); + snprintf(p, desc+sizeof(desc)-p, ":rom%x", instance); return find_prio(desc); } -- 1.9.3

3 2

[PATCH 0/2] Set FORCE_APIC_CLUSTER_MODEL bit of FADT flags
by zhanghailiang 25 Aug '14

25 Aug '14

This patch mainly to address the problem of windows 2008 R2 DataCenter can not show all processors within Task Manager when we do hot-add cpus. Also i found in code, there are places which use magic-number, it is better to use specified macros instead. zhanghailiang (2): acpi: use specified macro instead of magic-number acpi: Set FORCE_APIC_CLUSTER_MODEL bit of FADT flags src/fw/acpi.c | 18 ++++++++++++------ src/std/acpi.h | 25 +++++++++++++++++++++++++ 2 files changed, 37 insertions(+), 6 deletions(-) -- 1.7.12.4

2 5

Re: [SeaBIOS] Print to screen in Romlayout.S
by Yang Zhang 20 Aug '14

20 Aug '14

Hi, Wang Fei, Thanks for responding my post. I put my own boot loader in the MBR, and I’m sure that my code can’t print that meassage. On the other hand, the error happens before seabios load the MBR at 0x7c00. Thus I think it isn’t possible from MBR. Yang Zhang > On Aug 20, 2014, at 6:42 AM, WANG FEI <wangfei.jimei(a)gmail.com> wrote: > > Yang Zhang, > > Is it possible the error message from MBR? > > -Fei > > > On Mon, Aug 18, 2014 at 8:50 PM, Yang Zhang <udapostate(a)gmail.com> wrote: > Hi, > I meet a boot failure when I use seabios to load my own boot loader on virtual machine. The error message printed on screen say that ”Error loading from operating system”, which neither comes from seabios or my boot loader(I have read the source code of seabios, but I didn’t find any code can print a such message). Actually I don’t know where the error message come from. Therefore I have to trace the execution of seabios and my boot loader. It seems like the error happens before seabios load my boot loader(in the file romlayout.S), but I don’t know the exact position. Can anyone tell me how to print something to screen in the romlayout.S? (I can’t use gdb to debug because the virtual machine is running on our own OS). Thank you very much. > Yang Zhang > > > > > > _______________________________________________ > SeaBIOS mailing list > SeaBIOS(a)seabios.org > http://www.seabios.org/mailman/listinfo/seabios >

1 0

Print to screen in Romlayout.S
by Yang Zhang 20 Aug '14

20 Aug '14

Hi, I meet a boot failure when I use seabios to load my own boot loader on virtual machine. The error message printed on screen say that ”Error loading from operating system”, which neither comes from seabios or my boot loader(I have read the source code of seabios, but I didn’t find any code can print a such message). Actually I don’t know where the error message come from. Therefore I have to trace the execution of seabios and my boot loader. It seems like the error happens before seabios load my boot loader(in the file romlayout.S), but I don’t know the exact position. Can anyone tell me how to print something to screen in the romlayout.S? (I can’t use gdb to debug because the virtual machine is running on our own OS). Thank you very much. Yang Zhang

2 1

[PATCH v3] boot: Fix boot order for SCSI target, lun > 9
by Markus Armbruster 18 Aug '14

18 Aug '14

We identify devices by their Open Firmware device paths. The path component for the logical unit on a bus is incorrect: bootprio_find_scsi_device() and bootprio_find_usb() format target (a.k.a. SCSI ID) and lun in decimal, while QEMU uses hexadecimal. Bootorder list entries with target, lun > 9 aren't found (lucky case), or attributed to the wrong logical unit (unlucky case). The relevant spec[*] agrees with QEMU (and OVMF, for that matter). Change %d to %x. No actual impact on USB, because QEMU only uses LUN 0 there. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1096560 [*] Open Firmware Recommended Practice: SCSI-3 Parallel Interface, Version 1, Section 3.1 Physical Address Formats and Representations http://www.openfirmware.org/1275/practice/spi/spi1_0.ps IEEE Standard for Boot (Initialization Configuration) Firmware: Core Requirements and Practices, IEEE Std 1275-1994, Annex E SCSI host adapter package class, section E.2.1 Physical address formats and representations Signed-off-by: Markus Armbruster <armbru(a)redhat.com> --- v3: * Fix bootprio_find_usb() as well [Kevin] * Also point to IEEE 1275 Annex E in commit message v2: * Fix the link to the spec (d'oh) * While we're linking, link to RHBZ src/boot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/boot.c b/src/boot.c index 5837ad0..34088c8 100644 --- a/src/boot.c +++ b/src/boot.c @@ -145,7 +145,7 @@ int bootprio_find_scsi_device(struct pci_device *pci, int target, int lun) // Find scsi drive - for example: /pci@i0cf8/scsi@5/channel@0/disk@1,0 char desc[256], *p; p = build_pci_path(desc, sizeof(desc), "*", pci); - snprintf(p, desc+sizeof(desc)-p, "/*@0/*@%d,%d", target, lun); + snprintf(p, desc+sizeof(desc)-p, "/*@0/*@%x,%x", target, lun); return find_prio(desc); } @@ -224,7 +224,7 @@ int bootprio_find_usb(struct usbdevice_s *usbdev, int lun) char desc[256], *p; p = build_pci_path(desc, sizeof(desc), "usb", usbdev->hub->cntl->pci); p = build_usb_path(p, desc+sizeof(desc)-p, usbdev->hub); - snprintf(p, desc+sizeof(desc)-p, "/storage@%x/*@0/*@0,%d" + snprintf(p, desc+sizeof(desc)-p, "/storage@%x/*@0/*@0,%x" , usbdev->port+1, lun); int ret = find_prio(desc); if (ret >= 0) -- 1.9.3

4 5

Re: [SeaBIOS] SeaBios/QEMU issue
by Yasser Asmi 16 Aug '14

16 Aug '14

(resending, because last attempt failed) From: yasserasmi(a)live.com To: seabios(a)seabios.org Subject: SeaBios/QEMU issue Date: Wed, 6 Aug 2014 11:53:30 -0700 Hi I am using qemu-system-i386 (version 2.0.0 ) on Ubuntu running on an ARM system. I am testing setting up Windows 7 in this emulator (so X86 on ARM). The setup starts in text mode saying "loading files" with a progress bar. It crashes as soon as it tries to display graphics (logo or blue screen) after "windows is loading files..". I suspect it might be a seabios bios or VGA bios issue. Following output is generated on the console. The last line displayed before the hang "VBE current mode=4118". Do you think it is a Seabios issue? Any hints? Thank you! ===== Start bios (version 1.7.4-20140219_122725-roseapple) No Xen hypervisor found. Running on QEMU (i440fx) RamSize: 0x40000000 [cmos] Relocating init from 0x000dfe99 to 0x3ffdf190 (size 69036) Found QEMU fw_cfg RamBlock: addr 0x0000000000000000 len 0x0000000040000000 [e820] CPU Mhz=0 === PCI bus & bridge init === PCI: pci_bios_init_bus_rec bus = 0x0 === PCI device probing === Found 6 PCI devices (max PCI bus is 00) === PCI new allocation pass #1 === PCI: check devices === PCI new allocation pass #2 === PCI: 32: 0000000080000000 - 00000000fec00000 PCI: map device bdf=00:03.0 bar 1, addr 0000c000, size 00000040 [io] PCI: map device bdf=00:01.1 bar 4, addr 0000c040, size 00000010 [io] PCI: map device bdf=00:03.0 bar 6, addr feb80000, size 00040000 [mem] PCI: map device bdf=00:03.0 bar 0, addr febc0000, size 00020000 [mem] PCI: map device bdf=00:02.0 bar 6, addr febe0000, size 00010000 [mem] PCI: map device bdf=00:02.0 bar 1, addr febf0000, size 00001000 [mem] PCI: map device bdf=00:02.0 bar 0, addr fc000000, size 02000000 [prefmem] PCI: init bdf=00:00.0 id=8086:1237 PCI: init bdf=00:01.0 id=8086:7000 PIIX3/PIIX4 init: elcr=00 0c PCI: init bdf=00:01.1 id=8086:7010 PCI: init bdf=00:01.3 id=8086:7113 Using pmtimer, ioport 0xb008 PCI: init bdf=00:02.0 id=1013:00b8 PCI: init bdf=00:03.0 id=8086:100e PCI: Using 00:02.0 for primary VGA Found 1 cpu(s) max supported 1 cpu(s) MP table addr=0x000f0b70 MPC table addr=0x000f0b80 size=208 SMBIOS ptr=0x000f0b50 table=0x000f0a10 size=307 Scan for VGA option rom Running option rom at c000:0003 Start SeaVGABIOS (version 1.7.4-20140219_122730-roseapple) enter vga_post: a=00000010 b=0000ffff c=00000000 d=0000ffff ds=0000 es=f000 ss=0000 si=00000000 di=00006580 bp=00000000 sp=00006d1a cs=f000 ip=d256 f=0000 cirrus init cirrus init 2 Attempting to allocate VGA stack via pmm call to f000:d2ce pmm call arg1=0 VGA stack allocated at ed790 Turning on vga text mode console set VGA mode 3 cirrus mode switch regular SeaBIOS (version 1.7.4-20140219_122725-roseapple) Found 1 lpt ports Found 1 serial ports Searching bootorder for: /pci@i0cf8/isa@1/fdc@03f0/floppy@0 ATA controller 1 at 1f0/3f4/0 (irq 14 dev 9) ATA controller 2 at 170/374/0 (irq 15 dev 9) ata0-0: QEMU HARDDISK ATA-7 Hard-Disk (8192 MiBytes) Searching bootorder for: /pci@i0cf8/*@1,1/drive@0/disk@0 DVD/CD [ata1-0: QEMU DVD-ROM ATAPI-4 DVD/CD] Searching bootorder for: /pci@i0cf8/*@1,1/drive@1/disk@0 PS2 keyboard initialized All threads complete. Scan for option roms Running option rom at c900:0003 pmm call arg1=1 pmm call arg1=0 pmm call arg1=1 pmm call arg1=0 Searching bootorder for: /pci@i0cf8/*@3 Searching bootorder for: /rom(a)genroms/kvmvapic.bin Searching bootorder for: HALT drive 0x000f0960: PCHS=16383/16/63 translation=lba LCHS=1024/255/63 s=16777216 Running option rom at ca00:0003 Space available for UMB: cc800-ec800, f0000-f0900 Returned 57344 bytes of ZoneHigh e820 map has 6 items: 0: 0000000000000000 - 000000000009fc00 = 1 RAM 1: 000000000009fc00 - 00000000000a0000 = 2 RESERVED 2: 00000000000f0000 - 0000000000100000 = 2 RESERVED 3: 0000000000100000 - 000000003fffe000 = 1 RAM 4: 000000003fffe000 - 0000000040000000 = 2 RESERVED 5: 00000000fffc0000 - 0000000100000000 = 2 RESERVED enter handle_19: NULL Booting from Hard Disk... Booting from 0000:7c00 VBE current mode=3 VBE mode info request: 3 VBE mode info request: 3 VBE mode info request: 101 VBE mode info request: 111 VBE mode info request: 110 VBE mode info request: 112 VBE mode info request: 103 VBE mode info request: 114 VBE mode info request: 113 VBE mode info request: 105 VBE mode info request: 117 VBE mode info request: 116 VBE mode info request: 115 VBE mode info request: 118 VBE mode set: 4118 set VGA mode 118 VBE mode info request: 118 VBE current mode=4118 qemu: terminating on signal 2

2 1

[PATCH v2] boot: Fix boot order for SCSI target, lun > 9
by Markus Armbruster 15 Aug '14

15 Aug '14

We identify devices by their Open Firmware device paths. The path component for the logical unit on a bus is incorrect: bootprio_find_pci_device() formats target (a.k.a. SCSI ID) and lun in decimal, while QEMU uses hexadecimal. Bootorder list entries with target, lun > 9 aren't found (lucky case), or attributed to the wrong logical unit (unlucky case). The relevant spec[*] agrees with QEMU (and OVMF, for that matter). Change %d to %x. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1096560 [*] Open Firmware Recommended Practice: SCSI-3 Parallel Interface, Version 1, section 3.1 Physical Address Formats and Representations http://www.openfirmware.org/1275/practice/spi/spi1_0.ps Signed-off-by: Markus Armbruster <armbru(a)redhat.com> --- v2: - Fix the link to the spec (d'oh) - While we're linking, link to RHBZ src/boot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/boot.c b/src/boot.c index 5837ad0..6e41ccf 100644 --- a/src/boot.c +++ b/src/boot.c @@ -145,7 +145,7 @@ int bootprio_find_scsi_device(struct pci_device *pci, int target, int lun) // Find scsi drive - for example: /pci@i0cf8/scsi@5/channel@0/disk@1,0 char desc[256], *p; p = build_pci_path(desc, sizeof(desc), "*", pci); - snprintf(p, desc+sizeof(desc)-p, "/*@0/*@%d,%d", target, lun); + snprintf(p, desc+sizeof(desc)-p, "/*@0/*@%x,%x", target, lun); return find_prio(desc); } -- 1.9.3

3 5

[PATCH] boot: Fix boot order for SCSI target, lun > 9
by Markus Armbruster 14 Aug '14

14 Aug '14

We identify devices by their Open Firmware device paths. The path component for the logical unit on a bus is incorrect: bootprio_find_pci_device() formats target (a.k.a. SCSI ID) and lun in decimal, while QEMU uses hexadecimal. Bootorder list entries with target, lun > 9 aren't found (lucky case), or attributed to the wrong logical unit (unlucky case). The relevant spec[*] agrees with QEMU (and OVMF, for that matter). Change %d to %x. [*] Open Firmware Recommended Practice: SCSI-3 Parallel Interface, Version 1, section 3.1 Physical Address Formats and Representations http://www.openfirmware.org/1275/bindings/usb/usb-1_0.ps Signed-off-by: Markus Armbruster <armbru(a)redhat.com> --- src/boot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/boot.c b/src/boot.c index 5837ad0..6e41ccf 100644 --- a/src/boot.c +++ b/src/boot.c @@ -145,7 +145,7 @@ int bootprio_find_scsi_device(struct pci_device *pci, int target, int lun) // Find scsi drive - for example: /pci@i0cf8/scsi@5/channel@0/disk@1,0 char desc[256], *p; p = build_pci_path(desc, sizeof(desc), "*", pci); - snprintf(p, desc+sizeof(desc)-p, "/*@0/*@%d,%d", target, lun); + snprintf(p, desc+sizeof(desc)-p, "/*@0/*@%x,%x", target, lun); return find_prio(desc); } -- 1.9.3

1 0

Mailing list problems
by Kevin O'Connor 14 Aug '14

14 Aug '14

Hi, The seabios mailing list was experiencing problems the last few weeks, and it looks like emails were not making it to the list. I apologies for not picking up on the problem sooner. The issue should be fixed now. -Kevin

1 0

Coverity detected issues in SeaBIOS
by Ian Campbell 17 Jul '14

17 Jul '14

Hello, We run Coverity on the Xen source code occasionally and it happens to include SeaBIOS. The following new warnings have appeared since I pulled in rel-1.7.5. At least the MISSING_BREAK ones look likely to be valid to me. Not sure about the other two... Ian. -------- Forwarded Message -------- From: scan-admin(a)coverity.com Subject: New Defects reported by Coverity Scan for XenProject Date: Wed, 16 Jul 2014 07:16:19 -0700 Message-id: <53c68933a9a35_6cda4073389495a(a)209.249.196.67.mail> Hi, Please find the latest report on new defect(s) introduced to XenProject found with Coverity Scan. Defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s) ** CID 1226281: Unchecked return value (CHECKED_RETURN) /tools/firmware/seabios-dir-remote/src/fw/smbios.c: 578 in smbios_legacy_setup() ** CID 1226282: Missing break in switch (MISSING_BREAK) /tools/firmware/seabios-dir-remote/src/hw/blockcmd.c: 49 in cdb_cmd_data() ** CID 1226283: Missing break in switch (MISSING_BREAK) /tools/firmware/seabios-dir-remote/src/hw/blockcmd.c: 52 in cdb_cmd_data() ** CID 1226284: Missing break in switch (MISSING_BREAK) /tools/firmware/seabios-dir-remote/src/hw/blockcmd.c: 55 in cdb_cmd_data() ** CID 1226285: Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) /tools/firmware/seabios-dir-remote/src/hw/usb-xhci.c: 698 in configure_xhci() ________________________________________________________________________________________________________ *** CID 1226281: Unchecked return value (CHECKED_RETURN) /tools/firmware/seabios-dir-remote/src/fw/smbios.c: 578 in smbios_legacy_setup() 572 } 573 } 574 575 add_struct(32, p); 576 /* Add any remaining provided entries before the end marker */ 577 for (i = 0; i < 256; i++) >>> CID 1226281: Unchecked return value (CHECKED_RETURN) >>> Calling "get_external" without checking return value (as is done elsewhere 12 out of 13 times). 578 get_external(i, &p, &nr_structs, &max_struct_size, end); 579 add_struct(127, p); 580 581 #undef add_struct 582 583 smbios_entry_point_setup(max_struct_size, p - start, start, nr_structs); 584 free(start); ________________________________________________________________________________________________________ *** CID 1226282: Missing break in switch (MISSING_BREAK) /tools/firmware/seabios-dir-remote/src/hw/blockcmd.c: 49 in cdb_cmd_data() 43 return esp_scsi_cmd_data(op, cdbcmd, blocksize); 44 case DTYPE_MEGASAS: 45 return megasas_cmd_data(op, cdbcmd, blocksize); 46 case DTYPE_USB_32: 47 if (!MODESEGMENT) 48 return usb_cmd_data(op, cdbcmd, blocksize); >>> CID 1226282: Missing break in switch (MISSING_BREAK) >>> The above case falls through to this one. 49 case DTYPE_UAS_32: 50 if (!MODESEGMENT) 51 return uas_cmd_data(op, cdbcmd, blocksize); 52 case DTYPE_PVSCSI: 53 if (!MODESEGMENT) 54 return pvscsi_cmd_data(op, cdbcmd, blocksize); ________________________________________________________________________________________________________ *** CID 1226283: Missing break in switch (MISSING_BREAK) /tools/firmware/seabios-dir-remote/src/hw/blockcmd.c: 52 in cdb_cmd_data() 46 case DTYPE_USB_32: 47 if (!MODESEGMENT) 48 return usb_cmd_data(op, cdbcmd, blocksize); 49 case DTYPE_UAS_32: 50 if (!MODESEGMENT) 51 return uas_cmd_data(op, cdbcmd, blocksize); >>> CID 1226283: Missing break in switch (MISSING_BREAK) >>> The above case falls through to this one. 52 case DTYPE_PVSCSI: 53 if (!MODESEGMENT) 54 return pvscsi_cmd_data(op, cdbcmd, blocksize); 55 case DTYPE_AHCI_ATAPI: 56 if (!MODESEGMENT) 57 return ahci_cmd_data(op, cdbcmd, blocksize); ________________________________________________________________________________________________________ *** CID 1226284: Missing break in switch (MISSING_BREAK) /tools/firmware/seabios-dir-remote/src/hw/blockcmd.c: 55 in cdb_cmd_data() 49 case DTYPE_UAS_32: 50 if (!MODESEGMENT) 51 return uas_cmd_data(op, cdbcmd, blocksize); 52 case DTYPE_PVSCSI: 53 if (!MODESEGMENT) 54 return pvscsi_cmd_data(op, cdbcmd, blocksize); >>> CID 1226284: Missing break in switch (MISSING_BREAK) >>> The above case falls through to this one. 55 case DTYPE_AHCI_ATAPI: 56 if (!MODESEGMENT) 57 return ahci_cmd_data(op, cdbcmd, blocksize); 58 default: 59 return DISK_RET_EPARAM; 60 } ________________________________________________________________________________________________________ *** CID 1226285: Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) /tools/firmware/seabios-dir-remote/src/hw/usb-xhci.c: 698 in configure_xhci() 692 free(spba); 693 free(pad); 694 goto fail; 695 } 696 int i; 697 for (i = 0; i < spb; i++) >>> CID 1226285: Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) >>> Potentially overflowing expression "i * 4096" with type "int" (32 bits, signed) is evaluated using 32-bit arithmetic before being used in a context which expects an expression of type "u64" (64 bits, unsigned). To avoid overflow, cast either operand to "u64" before performing the multiplication. 698 spba[i] = (u32)pad + (i * PAGE_SIZE); 699 xhci->devs[0].ptr_low = (u32)spba; 700 xhci->devs[0].ptr_high = 0; 701 } 702 703 reg = readl(&xhci->op->usbcmd); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, http://scan.coverity.com/projects/606?tab=overview To unsubscribe from the email notification for new defects, http://scan5.coverity.com/cgi-bin/unsubscribe.py

3 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS