Attention is currently required from: Tarun Tuli, Subrata Banik, Nick Vaccaro.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66915 )
Change subject: mainboard/brya: Invoke power cycle of FPMCU on startup
......................................................................
Patch Set 14:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/66915/comment/0579d005_742043ad
PS14, Line 7: mainboard/brya
nit: `mb/google/brya`
https://review.coreboot.org/c/coreboot/+/66915/comment/49091c14_96cd91a5
PS14, Line 21: the power and reset appropriately and ensures the FPMCU is unpowered for >200ms on boot.
72 chars wide
https://review.coreboot.org/c/coreboot/+/66915/comment/04c220f2_352d0262
PS14, Line 24: Finger Print
FPMCU ?
Patchset:
PS14:
Conflicts with master branch
--
To view, visit https://review.coreboot.org/c/coreboot/+/66915
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9694f8837e0a72eaed42a5eeee92b0f120269086
Gerrit-Change-Number: 66915
Gerrit-PatchSet: 14
Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 21:40:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Wilson Chou, Marc Jones, Nico Huber, Ryback Hung, Johnny Lin, Tim Wawrzynczak, Paul Menzel, Shuming Chu (Shuming).
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67264 )
Change subject: device: Clear lane error status
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS2:
> Well, that's the only link training triggered by corebooot. If we want to do […]
Wilson, let's add a code comment accordingly: Lane error status is cleared if PCIEXP_LANE_ERR_STAT_CLEAR is set. Lane error is normal during link training, so we need to clear it. At this moment, link has been used, but for a very short duration.
File src/device/pciexp_device.c:
https://review.coreboot.org/c/coreboot/+/67264/comment/7677f6e4_4fb67bf0
PS5, Line 551: printk(BIOS_DEBUG, "%s: Clear Lane Error Status.\n", dev_path(dev));
> Would anyone ever be interested in the value it may have had before it gets cleared?
Wilson, let's print the current value while we clear it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/67264
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6344223636409d8fc25e365a6375fc81e69f41a5
Gerrit-Change-Number: 67264
Gerrit-PatchSet: 5
Gerrit-Owner: Wilson Chou <wilson.chou%quantatw.com(a)gtempaccount.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Ryback Hung <ryback.hung(a)quantatw.com>
Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Wilson Chou <wilson.chou%quantatw.com(a)gtempaccount.com>
Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Ryback Hung <ryback.hung(a)quantatw.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 21:37:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wilson Chou <wilson.chou%quantatw.com(a)gtempaccount.com>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Ahamed Husni.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67341 )
Change subject: src/console: attach smbus console driver
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/smbus/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/67341/comment/5d4c0576_ebdf5b39
PS4, Line 2: bootblock-y += i2c_smbus_console.c
: romstage-y += i2c_smbus_console.c
: ramstage-y += i2c_smbus_console.c
why not `all-y += ... `
is there some reason not to use this in other stages?
--
To view, visit https://review.coreboot.org/c/coreboot/+/67341
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a9bf64e59d529253bfdcdfa565bb2bb92975728
Gerrit-Change-Number: 67341
Gerrit-PatchSet: 4
Gerrit-Owner: Ahamed Husni <ahamedhusni73(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Ahamed Husni <ahamedhusni73(a)gmail.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 21:29:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Raul Rangel, Tim Wawrzynczak.
Dmitry Torokhov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67385 )
Change subject: Documentation: Add wake source info to device tree documentation
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/67385
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifcdbd5371408784bf9b81c1ade90263de8c60e0f
Gerrit-Change-Number: 67385
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Dmitry Torokhov <dtor(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jon Murphy <jpmurphy(a)google.com>
Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-CC: Mark Hasemeyer <markhas(a)google.com>
Gerrit-CC: Robert Zieba <robertzieba(a)google.com>
Gerrit-CC: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Tue, 06 Sep 2022 21:16:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Wilson Chou, Marc Jones, Nico Huber, Jonathan Zhang, Ryback Hung, Johnny Lin, Paul Menzel, Shuming Chu (Shuming).
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67264 )
Change subject: device: Clear lane error status
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File src/device/pciexp_device.c:
https://review.coreboot.org/c/coreboot/+/67264/comment/4e384909_13168275
PS5, Line 551: printk(BIOS_DEBUG, "%s: Clear Lane Error Status.\n", dev_path(dev));
Would anyone ever be interested in the value it may have had before it gets cleared?
--
To view, visit https://review.coreboot.org/c/coreboot/+/67264
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6344223636409d8fc25e365a6375fc81e69f41a5
Gerrit-Change-Number: 67264
Gerrit-PatchSet: 5
Gerrit-Owner: Wilson Chou <wilson.chou%quantatw.com(a)gtempaccount.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Ryback Hung <ryback.hung(a)quantatw.com>
Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Wilson Chou <wilson.chou%quantatw.com(a)gtempaccount.com>
Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Ryback Hung <ryback.hung(a)quantatw.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 21:15:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Selma Bensaid, Nick Vaccaro.
Hello build bot (Jenkins), Selma Bensaid, Tim Wawrzynczak, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67021
to look at the new patch set (#5).
Change subject: mb/google/brya/var/skolas4es: Configure _DSC for camera devices
......................................................................
mb/google/brya/var/skolas4es: Configure _DSC for camera devices
Configure _DSC to ACPI_DEVICE_SLEEP_D3_COLD so that the driver skips
initial probe during kernel boot and prevent privacy LED blink.
BUG=b:194979741
BRANCH=firmware-brya-14505.B
TEST=Build and boot skolas to OS. Verify entries in SSDT.
Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com>
Change-Id: I3c32dd71ab454227b15913bda7f542230e5568db
---
M src/mainboard/google/brya/variants/skolas4es/overridetree.cb
1 file changed, 48 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/67021/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/67021
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c32dd71ab454227b15913bda7f542230e5568db
Gerrit-Change-Number: 67021
Gerrit-PatchSet: 5
Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: newpatchset
Ahamed Husni has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67386 )
Change subject: Documentation: document the new smbus console feature
......................................................................
Documentation: document the new smbus console feature
Signed-off-by: Husni Faiz <ahamedhusni73(a)gmail.com>
Change-Id: I50cafbbaaea133c9ea50131e455151287c96176a
---
A Documentation/technotes/console.md
M Documentation/technotes/index.md
2 files changed, 70 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/67386/1
diff --git a/Documentation/technotes/console.md b/Documentation/technotes/console.md
new file mode 100644
index 0000000..9a84b5f
--- /dev/null
+++ b/Documentation/technotes/console.md
@@ -0,0 +1,59 @@
+# coreboot Console
+
+coreboot supports multiple ways to access its console.
+https://www.coreboot.org/Console_and_outputs
+
+
+## SMBus Console
+
+SMBus is a two-wire interface which is based on the principles of operation
+of I2C. SMBus, was first was designed to allow a battery to communicate with the
+charger, the system host, and/or other power-related components in the system.
+
+Enable the SMBus console with `CONSOLE_I2C_SMBUS` Kconfig. Set
+`CONSOLE_I2C_SMBUS_SLAVE_ADDRESS` and `CONSOLE_I2C_SMBUS_SLAVE_DATA_REGISTER`
+configuration values of the slave I2C device which you will use to capture
+I2C packets.
+
+Currently SMBus console is supported in `BOOTBLOCK`, `ROMSTAGE` and `RAMSTAGE`.
+
+Modern computer Random Access Memory (RAM) slot has SMBus in it according to
+the JEDEC standards. We can use a breakoutboard to expose those SMBus pins.
+Some mainboard have SMBus pins in the PCIe slot as well.
+
+This feature has been tested on the following platforms:
+```eval_rst
++------------------------------------+-------------------------------+
+| Platform | Support |
++====================================+===============================+
+| GA-H61M-S2PV + Intel Ivy Bridge | BOOTBLOCK, ROMSTAGE, RAMSTAGE |
++---------------------+----------------------------------------------+
+```
+
+A minimal DDR3 DIMM breakout board with only the SDA(Data line) and
+SCL(Clock line) pins of I2C/SMBus can be found
+[here](https://github.com/drac98/ram-breakout-board).
+
+NOTE:
+To capture the I2C packets, an I2C slave device is required. The easiest way to
+capture the log message is to use a I2C to UART converter chip with a UART to
+USB converter chip. The setup would be as follows.
+```text
+ +---------+ +-------------+ +-------------+
+ + PC +--------+ UART to USB +--------+ I2C to UART |
+ +---------+ +-------------+ +-------------+
+ | |
+------------------------------------------------------------+-- System Management
+----------------------------------------------------------+---- Bus
+```
+
+Watch this [video](https://youtu.be/Q0dK41n9db8) to see how it is set up.
+
+If you are using a `SC16IS750` I2C to UART converter chip, you can enable the
+`SC16IS750_INIT` option to initialize the chip.
+
+If not we can use a Beagleboard or an Arduino as an I2C slave device.
+
+This feature was added as part of a GSoC 2022 project. Checkout the
+[coreboot Console via SMBus — Part I](https://medium.com/@husnifaiz/coreboot-console-via-smbus-introduction-38…
+blog post for more details.
\ No newline at end of file
diff --git a/Documentation/technotes/index.md b/Documentation/technotes/index.md
index fda8bd6..da5b864 100644
--- a/Documentation/technotes/index.md
+++ b/Documentation/technotes/index.md
@@ -5,3 +5,4 @@
* [Unit testing coreboot](2020-03-unit-testing-coreboot.md)
* [Unit Test Code Coverage](2021-05-code-coverage.md)
* [Address Sanitizer](asan.md)
+* [coreboot Consoles](console.md)
--
To view, visit https://review.coreboot.org/c/coreboot/+/67386
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50cafbbaaea133c9ea50131e455151287c96176a
Gerrit-Change-Number: 67386
Gerrit-PatchSet: 1
Gerrit-Owner: Ahamed Husni <ahamedhusni73(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Felix Singer, Ahamed Husni, Tim Wawrzynczak.
Hello Felix Singer, build bot (Jenkins), Raul Rangel, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67339
to look at the new patch set (#2).
Change subject: drivers/smbus: smbus console driver
......................................................................
drivers/smbus: smbus console driver
Change-Id: Ife77fb2c3e1cc77678a4972701317d50624ceb95
Signed-off-by: Husni Faiz <ahamedhusni73(a)gmail.com>
---
M src/console/Kconfig
A src/drivers/smbus/i2c_smbus_console.c
A src/include/console/i2c_smbus.h
3 files changed, 84 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/67339/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/67339
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife77fb2c3e1cc77678a4972701317d50624ceb95
Gerrit-Change-Number: 67339
Gerrit-PatchSet: 2
Gerrit-Owner: Ahamed Husni <ahamedhusni73(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Ahamed Husni <ahamedhusni73(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset