coreboot-gerrit September 2022

coreboot-gerrit@coreboot.org

1 participants
4678 discussions

[S] Change in coreboot[master]: mb/google/brya/var/kinox: Modify fan speed/duty table
by Dtrain Hsu (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Dtrain Hsu, Ricky Chang. Hello Frank Wu, John Su, build bot (Jenkins), Tim Wawrzynczak, Sumeet R Pawnikar, Ricky Chang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67307 to look at the new patch set (#4). Change subject: mb/google/brya/var/kinox: Modify fan speed/duty table ...................................................................... mb/google/brya/var/kinox: Modify fan speed/duty table Modify fan speed/duty table follow "Duty table.xlsx". BUG=b:244262869 TEST=Boot to ChromeOS. Using SDV system, enter duty vaule,and then system feedback fan speed. Signed-off-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Change-Id: Id5e885b96624d5fc31f1d42e3582c3ab01e08458 --- M src/mainboard/google/brya/variants/kinox/overridetree.cb 1 file changed, 36 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/67307/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/67307 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5e885b96624d5fc31f1d42e3582c3ab01e08458 Gerrit-Change-Number: 67307 Gerrit-PatchSet: 4 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: Recently published Intel CedarIslandFSP binary contains PE images in ...
by Ed Sharma (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Arthur Heymans, Furquan Shaikh, Subrata Banik, Jonathan Zhang, Johnny Lin, Tim Wawrzynczak, Julian Schroeder, Nathaniel L Desimone, Felix Held, Isaac W Oram. Ed Sharma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66819 ) Change subject: Recently published Intel CedarIslandFSP binary contains PE images in FSP-M and FSP-S. This causes coreboot boot hang on DeltaLake servers. ...................................................................... Patch Set 1: (11 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/66819/comment/b4527454_48485638 PS1, Line 8: FSP-M and FSP-S. This causes coreboot boot hang on DeltaLake servers. > You may also want to point to FSP spec that boot loader needs support PE image format. I tried to search for PE and TE in the FSP spec but could not find the info in the spec anywhere. Do you have that information handy, else it may not exist in the spec to add as a reference? https://review.coreboot.org/c/coreboot/+/66819/comment/8f1bc7f1_3b4c13f1 PS1, Line 10: The change required to add support for pe_relocate in fsp-relocate.c > Suppose to add message stating that PE32 format support is added, but PE64 format support is left fo […] Done https://review.coreboot.org/c/coreboot/+/66819/comment/07965ace_edc9d6f5 PS1, Line 15: This code is tested with FSP version 33A for DeltaLake boot. > You could add test descriptions after "TEST=". Done Patchset: PS1: Updated commit and responded to all comments File src/commonlib/fsp_relocate.c: https://review.coreboot.org/c/coreboot/+/66819/comment/82bcf849_79b94d83 PS1, Line 145: /* FSP_INFO_HEADER at first file in FV within first RAW section. */ > FSP_INFO_HEADER (is located) at Done https://review.coreboot.org/c/coreboot/+/66819/comment/43763486_43669537 PS1, Line 211: printk(FSP_DBG_LVL, "FSP InfoHdr Image Base is %x\n", image_base); > Does it make sense to say "FSP PE32 InfoHdr Image Base is... […] FspInfoHdr is for the entire FSP image, not just for PE. There is one per FSP. https://review.coreboot.org/c/coreboot/+/66819/comment/c016799f_2e27bfc2 PS1, Line 242: printk(FSP_DBG_LVL, "%d Relocs for RVA %x\n", rnum, vaddr); > Suggest to add a tab \t to make the debug message more clear. Done https://review.coreboot.org/c/coreboot/+/66819/comment/ecafd0a4_9cf83392 PS1, Line 249: printk(FSP_DBG_LVL, "reloc type %x offset %x aoff %x, base-0x%x\n", > suggest to add two tabs \t\t Done https://review.coreboot.org/c/coreboot/+/66819/comment/e75d1740_10f9978d PS1, Line 277: // printk(FSP_DBG_LVL, "FSP InfoHdr Image Base updated to %lx\n", new_addr); > These comments could be deleted. Done https://review.coreboot.org/c/coreboot/+/66819/comment/5ce34ccf_800e369b PS1, Line 650: printk(FSP_DBG_LVL, "PE image at offset %zx\n", > PE32 image Done https://review.coreboot.org/c/coreboot/+/66819/comment/8088044a_52c5de40 PS1, Line 653: } > Suggest catching the case where the type is neither EFI_SECTION_TE nor EFI_SECTION_PE32. This suggestion does not work. It halts BIOS execution for some reason. Perhaps there are other sections that are not either of these and don't need relocation but we cannot return an error from this loop since we need to still calculate those offsets for the next one that might need relocation. -- To view, visit https://review.coreboot.org/c/coreboot/+/66819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01e2c123d74f735a647b994aa66419c9796f193e Gerrit-Change-Number: 66819 Gerrit-PatchSet: 1 Gerrit-Owner: Ed Sharma <aeddiesharma(a)fb.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Isaac W Oram <isaac.w.oram(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Julian Schroeder <julianmarcusschroeder(a)gmail.com> Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Julian Schroeder <julianmarcusschroeder(a)gmail.com> Gerrit-Attention: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Isaac W Oram <isaac.w.oram(a)intel.com> Gerrit-Comment-Date: Wed, 07 Sep 2022 01:46:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: Recently published Intel CedarIslandFSP binary contains PE images in ...
by build bot (Jenkins) (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Arthur Heymans, Furquan Shaikh, Subrata Banik, Johnny Lin, Ed Sharma, Tim Wawrzynczak, Julian Schroeder, Nathaniel L Desimone, Felix Held, Isaac W Oram. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66819 ) Change subject: Recently published Intel CedarIslandFSP binary contains PE images in FSP-M and FSP-S. This causes coreboot boot hang on DeltaLake servers. ...................................................................... Patch Set 2: (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158189): https://review.coreboot.org/c/coreboot/+/66819/comment/4c1577db_f2e77d18 PS2, Line 6: Possible long commit subject (prefer a maximum 65 characters) File src/commonlib/fsp_relocate.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158189): https://review.coreboot.org/c/coreboot/+/66819/comment/e1051fad_9e5e2e86 PS2, Line 223: roffset = read_le32(&ophdr->DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_BASERELOC].VirtualAddress); line length of 103 exceeds 96 columns -- To view, visit https://review.coreboot.org/c/coreboot/+/66819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01e2c123d74f735a647b994aa66419c9796f193e Gerrit-Change-Number: 66819 Gerrit-PatchSet: 2 Gerrit-Owner: Ed Sharma <aeddiesharma(a)fb.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Isaac W Oram <isaac.w.oram(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Julian Schroeder <julianmarcusschroeder(a)gmail.com> Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Ed Sharma <aeddiesharma(a)fb.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Julian Schroeder <julianmarcusschroeder(a)gmail.com> Gerrit-Attention: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Isaac W Oram <isaac.w.oram(a)intel.com> Gerrit-Comment-Date: Wed, 07 Sep 2022 01:45:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: Recently published Intel CedarIslandFSP binary contains PE images in ...
by Ed Sharma (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Arthur Heymans, Furquan Shaikh, Subrata Banik, Johnny Lin, Ed Sharma, Tim Wawrzynczak, Julian Schroeder, Nathaniel L Desimone, Felix Held, Isaac W Oram. Hello Arthur Heymans, build bot (Jenkins), Furquan Shaikh, Subrata Banik, Jonathan Zhang, Johnny Lin, Tim Wawrzynczak, Julian Schroeder, Nathaniel L Desimone, Felix Held, Isaac W Oram, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/66819 to look at the new patch set (#2). Change subject: Recently published Intel CedarIslandFSP binary contains PE images in FSP-M and FSP-S. This causes coreboot boot hang on DeltaLake servers. ...................................................................... Recently published Intel CedarIslandFSP binary contains PE images in FSP-M and FSP-S. This causes coreboot boot hang on DeltaLake servers. The change required to add support for pe_relocate in fsp-relocate.c I had to move a few functions to top of file as they need to be used by pe_relocate but were placed below the te_relocate function. I chose to place pe_relocate function next to te_relocate. The code supports PE32 format, not PE64, at this time. TEST= This code is tested with FSP version 33A for DeltaLake boot. Change-Id: I01e2c123d74f735a647b994aa66419c9796f193e Signed-off-by: Eddie Sharma <aeddiesharma(a)fb.com> --- M src/commonlib/fsp_relocate.c 1 file changed, 214 insertions(+), 37 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/66819/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/66819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01e2c123d74f735a647b994aa66419c9796f193e Gerrit-Change-Number: 66819 Gerrit-PatchSet: 2 Gerrit-Owner: Ed Sharma <aeddiesharma(a)fb.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Isaac W Oram <isaac.w.oram(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Julian Schroeder <julianmarcusschroeder(a)gmail.com> Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Ed Sharma <aeddiesharma(a)fb.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Julian Schroeder <julianmarcusschroeder(a)gmail.com> Gerrit-Attention: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Isaac W Oram <isaac.w.oram(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/grunt: Enable AC wake
by Daisuke Nojiri (Code Review) 07 Sep '22

07 Sep '22

Daisuke Nojiri has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67389 ) Change subject: mb/google/grunt: Enable AC wake ...................................................................... mb/google/grunt: Enable AC wake This patch enables AC plug/unplug for resume. BUG=b:188457962 BRANCH=grunt TEST=Verified AC plug/unplug wakes up Treeya. Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> Change-Id: I10480f8224b909fefe42d46d7c03fc9d3fe5abfe --- M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/67389/1 diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h index bd5c295..2b89387 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h @@ -38,7 +38,9 @@ #define MAINBOARD_EC_S3_WAKE_EVENTS \ (MAINBOARD_EC_S5_WAKE_EVENTS |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE)) + EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_CONNECTED) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_DISCONNECTED)) /* Log EC wake events plus EC shutdown events */ #define MAINBOARD_EC_LOG_EVENTS \ -- To view, visit https://review.coreboot.org/c/coreboot/+/67389 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10480f8224b909fefe42d46d7c03fc9d3fe5abfe Gerrit-Change-Number: 67389 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[master]: qualcomm/sc7280: remove unnecessary malloc and early return on failure
by Shelley Chen (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Venkat Thogaru, Julius Werner. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66975 ) Change subject: qualcomm/sc7280: remove unnecessary malloc and early return on failure ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/66975 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I51f7a86d143128d2c426fb8940ff34a66152b426 Gerrit-Change-Number: 66975 Gerrit-PatchSet: 4 Gerrit-Owner: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 07 Sep 2022 00:35:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: guybrush: remove RO_GSCVD area from FMAP
by Julius Werner (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Jason Nien, Harsha B R, Himanshu Sahdev, Martin Roth. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67376 ) Change subject: guybrush: remove RO_GSCVD area from FMAP ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > adding julius werner, can you please quote the reason for not using gscvd on CR50 devices by default […] GSC verification is a feature that will first roll out with Ti50. There is a Cr50 implementation but I believe(?) we ended up deciding not to use that. I think it was added to guybrush here before that decision was made, so taking it back out now seems reasonable. -- To view, visit https://review.coreboot.org/c/coreboot/+/67376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I896b871bf2ac64e334514b979add9b8ac2c43945 Gerrit-Change-Number: 67376 Gerrit-PatchSet: 2 Gerrit-Owner: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Reviewer: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Wed, 07 Sep 2022 00:22:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Add WWAN ACPI support
by Eric Lai (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Tim Wawrzynczak, Kapil Porwal, Ivy Jian. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67336 ) Change subject: mb/google/rex: Add WWAN ACPI support ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/mainboard/google/rex/variants/rex0/overridetree.cb: https://review.coreboot.org/c/coreboot/+/67336/comment/c1498fb2_246361f3 PS2, Line 232: # register "reset_delay_ms" = "1000" > is this needed? IIRC, we need 10s wait for FW ready again like power on. -- To view, visit https://review.coreboot.org/c/coreboot/+/67336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6114c589769d2eca882cf1a5255cf4c5937121a6 Gerrit-Change-Number: 67336 Gerrit-PatchSet: 2 Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 07 Sep 2022 00:03:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/rex: Set up MIPI cameras via ACPI
by Daniel Kang (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Tian Shu Qiu, Tarun Tuli, Bingbu Cao, Dalibor Segan, Wonkyu Kim, Subrata Banik, Paul Menzel, Rizwan Qureshi, Kapil Porwal. Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67085 ) Change subject: mb/google/rex: Set up MIPI cameras via ACPI ...................................................................... Patch Set 15: (1 comment) File src/mainboard/google/rex/variants/rex0/overridetree.cb: https://review.coreboot.org/c/coreboot/+/67085/comment/26799110_ad4c86a9 PS15, Line 314: Controls > clock control seems to be missed for UCAM. […] UCAM uses its own clock while WCAM gets the clock from host. -- To view, visit https://review.coreboot.org/c/coreboot/+/67085 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaa16e491a66500606b3a9eb1d87f396641778e0 Gerrit-Change-Number: 67085 Gerrit-PatchSet: 15 Gerrit-Owner: Daniel Kang <daniel.h.kang(a)intel.com> Gerrit-Reviewer: Bingbu Cao <bingbu.cao(a)intel.com> Gerrit-Reviewer: Dalibor Segan <dalibor.segan(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tian Shu Qiu <tian.shu.qiu(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tian Shu Qiu <tian.shu.qiu(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Bingbu Cao <bingbu.cao(a)intel.com> Gerrit-Attention: Dalibor Segan <dalibor.segan(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 23:09:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/rex: Set up MIPI cameras via ACPI
by Wonkyu Kim (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Tian Shu Qiu, Tarun Tuli, Daniel Kang, Bingbu Cao, Dalibor Segan, Subrata Banik, Paul Menzel, Rizwan Qureshi, Kapil Porwal. Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67085 ) Change subject: mb/google/rex: Set up MIPI cameras via ACPI ...................................................................... Patch Set 15: (1 comment) File src/mainboard/google/rex/variants/rex0/overridetree.cb: https://review.coreboot.org/c/coreboot/+/67085/comment/90da8c74_51c46221 PS15, Line 314: Controls clock control seems to be missed for UCAM. Don't we need to control clock control like WCAM? -- To view, visit https://review.coreboot.org/c/coreboot/+/67085 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaa16e491a66500606b3a9eb1d87f396641778e0 Gerrit-Change-Number: 67085 Gerrit-PatchSet: 15 Gerrit-Owner: Daniel Kang <daniel.h.kang(a)intel.com> Gerrit-Reviewer: Bingbu Cao <bingbu.cao(a)intel.com> Gerrit-Reviewer: Dalibor Segan <dalibor.segan(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tian Shu Qiu <tian.shu.qiu(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tian Shu Qiu <tian.shu.qiu(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Daniel Kang <daniel.h.kang(a)intel.com> Gerrit-Attention: Bingbu Cao <bingbu.cao(a)intel.com> Gerrit-Attention: Dalibor Segan <dalibor.segan(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 22:54:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2022