Attention is currently required from: Jason Nien, Harsha B R, Himanshu Sahdev, Martin Roth.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67376 )
Change subject: guybrush: remove RO_GSCVD area from FMAP
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
adding julius werner, can you please quote the reason for not using gscvd on CR50 devices by default […]
GSC verification is a feature that will first roll out with Ti50. There is a Cr50 implementation but I believe(?) we ended up deciding not to use that. I think it was added to guybrush here before that decision was made, so taking it back out now seems reasonable.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67376
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I896b871bf2ac64e334514b979add9b8ac2c43945
Gerrit-Change-Number: 67376
Gerrit-PatchSet: 2
Gerrit-Owner: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-Reviewer: Harsha B R
harsha.b.r@intel.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Harsha B R
harsha.b.r@intel.com
Gerrit-Attention: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Wed, 07 Sep 2022 00:22:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-MessageType: comment