Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49729 )
Change subject: soc/amd/picasso/Kconfig: drop EHCI_BAR
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/49729
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e904c160c68805a8606a8b2d1ab4fb6172066e7
Gerrit-Change-Number: 49729
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 20 Jan 2021 03:46:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Bao Zheng, Jason Glenesk, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held.
Hello build bot (Jenkins), Jason Glenesk, Patrick Georgi, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49734
to look at the new patch set (#2).
Change subject: soc/amd/picasso: Use option instead of hardcode to location UCODE
......................................................................
soc/amd/picasso: Use option instead of hardcode to location UCODE
Change-Id: Iae3d159aa5413a416c54935ab7a809d0f4ff776f
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M src/soc/amd/picasso/Makefile.inc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/49734/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/49734
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae3d159aa5413a416c54935ab7a809d0f4ff776f
Gerrit-Change-Number: 49734
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: John Zhao, Tim Wawrzynczak, Brandon Breitenstein, Rajmohan Mani.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49257 )
Change subject: ec/google/chromeec: Provide EC access for Retimer firmware update
......................................................................
Patch Set 5:
(1 comment)
File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/49257/comment/a82d4333_1394ff1c
PS4, Line 242: \\_SB_.PCI0.LPCB.EC0_.
> oh that's right, there is no struct/device in the hierarchy right now which will resolve to an ACPI […]
Ah well, sorry for the diversion. I'll add cleaning up the EC ACPI path to the endless todo list..
--
To view, visit https://review.coreboot.org/c/coreboot/+/49257
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3817d93cfdeedf15825dab6c537b151fd063338b
Gerrit-Change-Number: 49257
Gerrit-PatchSet: 5
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: John Zhao <john.zhao(a)intel.corp-partner.google.com>
Gerrit-Attention: John Zhao <john.zhao(a)intel.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: John Zhao <john.zhao(a)intel.com>
Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Attention: Rajmohan Mani <rajmohan.mani(a)intel.com>
Gerrit-Comment-Date: Wed, 20 Jan 2021 03:12:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: John Zhao <john.zhao(a)intel.corp-partner.google.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: John Zhao <john.zhao(a)intel.com>
Comment-In-Reply-To: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Zheng Bao.
Hello Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/49734
to review the following change.
Change subject: soc/amd/picasso: Use option instead of hardcode to location UCODE
......................................................................
soc/amd/picasso: Use option instead of hardcode to location UCODE
Change-Id: Iae3d159aa5413a416c54935ab7a809d0f4ff776f
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M src/soc/amd/picasso/Makefile.inc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/49734/1
diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc
index a0f3ec4..acf4e93 100644
--- a/src/soc/amd/picasso/Makefile.inc
+++ b/src/soc/amd/picasso/Makefile.inc
@@ -305,6 +305,6 @@
$(call strip_quotes,$(CONFIG_FSP_M_CBFS))-options := -b $(CONFIG_FSP_M_ADDR)
-cpu_microcode_bins += $(wildcard 3rdparty/amd_blobs/picasso/PSP/UcodePatch_*.bin)
+cpu_microcode_bins += $(wildcard {FIRMWARE_LOCATION}/UcodePatch_*.bin)
endif # ($(CONFIG_SOC_AMD_PICASSO),y)
--
To view, visit https://review.coreboot.org/c/coreboot/+/49734
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae3d159aa5413a416c54935ab7a809d0f4ff776f
Gerrit-Change-Number: 49734
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Attention: Zheng Bao
Gerrit-MessageType: newchange
Attention is currently required from: Martin Roth, Henry Sun, Evan Green.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Henry Sun, Evan Green, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49469
to look at the new patch set (#7).
Change subject: mb/google/dedede/var/drawcia: Add support to handle pen detection
......................................................................
mb/google/dedede/var/drawcia: Add support to handle pen detection
Drawlat/Drawman/Drawcia share the same AP firmware, and only Drawcia is
convertible. So, use tablet mode bit of fw config to override GPP_C12.
BUG=b:177618684
TEST=emerge-dedede coreboot, check evtest if SW_PEN_INSERTED event
(value:1/0) when insert/eject pen, and eject pen to wake system from s0ix
Signed-off-by: Wisley Chen <wisley.chen(a)quantatw.com>
Change-Id: I503873afb48384168dcd8a822c7246655898356e
---
M src/mainboard/google/dedede/variants/drawcia/Makefile.inc
A src/mainboard/google/dedede/variants/drawcia/gpio.c
M src/mainboard/google/dedede/variants/drawcia/overridetree.cb
3 files changed, 32 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/49469/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/49469
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I503873afb48384168dcd8a822c7246655898356e
Gerrit-Change-Number: 49469
Gerrit-PatchSet: 7
Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Evan Green <evgreen(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Henry Sun, Evan Green.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49469 )
Change subject: mb/google/dedede/var/drawcia: Add support to handle pen detection
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/google/dedede/variants/drawcia/gpio.c:
https://review.coreboot.org/c/coreboot/+/49469/comment/1918cacc_4057c800
PS6, Line 17: if (fw_config_probe(FW_CONFIG(TABLETMODE, TABLETMODE_ENABLED))){
space required before the open brace '{'
https://review.coreboot.org/c/coreboot/+/49469/comment/66a02546_f79c1de8
PS6, Line 17: if (fw_config_probe(FW_CONFIG(TABLETMODE, TABLETMODE_ENABLED))){
braces {} are not necessary for single statement blocks
--
To view, visit https://review.coreboot.org/c/coreboot/+/49469
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I503873afb48384168dcd8a822c7246655898356e
Gerrit-Change-Number: 49469
Gerrit-PatchSet: 6
Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Evan Green <evgreen(a)chromium.org>
Gerrit-Comment-Date: Wed, 20 Jan 2021 02:54:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Henry Sun, Evan Green.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Henry Sun, Evan Green, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49469
to look at the new patch set (#6).
Change subject: mb/google/dedede/var/drawcia: Add support to handle pen detection
......................................................................
mb/google/dedede/var/drawcia: Add support to handle pen detection
Drawlat/Drawman/Drawcia share the same AP firmware, and only Drawcia is
convertible. So, use tablet mode bit of fw config to override GPP_C12.
BUG=b:177618684
TEST=emerge-dedede coreboot, check evtest if SW_PEN_INSERTED event
(value:1/0) when insert/eject pen, and eject pen to wake system from s0ix
Signed-off-by: Wisley Chen <wisley.chen(a)quantatw.com>
Change-Id: I503873afb48384168dcd8a822c7246655898356e
---
M src/mainboard/google/dedede/variants/drawcia/Makefile.inc
A src/mainboard/google/dedede/variants/drawcia/gpio.c
M src/mainboard/google/dedede/variants/drawcia/overridetree.cb
3 files changed, 34 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/49469/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/49469
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I503873afb48384168dcd8a822c7246655898356e
Gerrit-Change-Number: 49469
Gerrit-PatchSet: 6
Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Evan Green <evgreen(a)chromium.org>
Gerrit-MessageType: newpatchset