- coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: mb/lenovo/w541: Add Thinkpad W541

by amersel (Code Review)

Attention is currently required from: Peter Lemenkov, Angel Pons, Alexander Couzens, Patrick Rudolph, Iru Cai (vimacs). amersel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52659 ) Change subject: mb/lenovo/w541: Add Thinkpad W541 ...................................................................... Patch Set 21: (1 comment) Patchset: PS20: > Simply including the change doesn't solve the problem and it's a bit unclear how to use this. […] Figured out a way to enable the backlight. Using ectool as shown in this reddit post, I was able to enable and disable the backlight. This works without the addition of +51412. https://www.reddit.com/r/coreboot/comments/eqz5xa/t440p_backlit_tester_need… ``` low brightness sudo ./ectool -w 0xd -z 0x42 high brightness sudo ./ectool -w 0xd -z 0x82 disable backlight sudo ./ectool -w 0xd -z 0x02 ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/52659 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08 Gerrit-Change-Number: 52659 Gerrit-PatchSet: 21 Gerrit-Owner: amersel Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Iru Cai (vimacs) <mytbk920423(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Attention: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Iru Cai (vimacs) <mytbk920423(a)gmail.com> Gerrit-Comment-Date: Sat, 12 Jun 2021 23:29:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peter Lemenkov <lemenkov(a)gmail.com> Comment-In-Reply-To: amersel Gerrit-MessageType: comment

31 minutes

1
0
0 0

Change in coreboot[master]: soc/intel/common: Add InSMM.STS support

by Michael Niewöhner (Code Review)

Attention is currently required from: Nico Huber, Benjamin Doron, Paul Menzel, Angel Pons, Arthur Heymans, Patrick Rudolph. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51796 ) Change subject: soc/intel/common: Add InSMM.STS support ...................................................................... Patch Set 10: (1 comment) File src/soc/intel/common/block/smm/smihandler.c: https://review.coreboot.org/c/coreboot/+/51796/comment/eee348af_799e0e4e PS9, Line 276: 0x1fe > It's called SPCL_CHIPSET_USAGE, and there's no define for it. […] probably src/include/cpu/intel/msr.h -- To view, visit https://review.coreboot.org/c/coreboot/+/51796 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia90c0e3f8ccf895bfb6d46ffe26750393dab95fb Gerrit-Change-Number: 51796 Gerrit-PatchSet: 10 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 12 Jun 2021 21:24:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

2 hours, 36 minutes

1
0
0 0

Change in coreboot[master]: util/intelp2m/fsp: Fix wrong register decoding for direction and inte...

by Michael Niewöhner (Code Review)

Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54973 ) Change subject: util/intelp2m/fsp: Fix wrong register decoding for direction and interrupt ...................................................................... util/intelp2m/fsp: Fix wrong register decoding for direction and interrupt Using the wrong registers to build the fields led to incorrect GPIO direction and interrupt trigger values. Change the calls to fix the tables. Change-Id: Icbeeb1fec6a863d0f86659c21924e15ae6765d47 Signed-off-by: Benjamin Doron <benjamin.doron00(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/54973 Reviewed-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M util/intelp2m/fields/fsp/fsp.go 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Maxim Polyakov: Looks good to me, approved Michael Niewöhner: Looks good to me, approved diff --git a/util/intelp2m/fields/fsp/fsp.go b/util/intelp2m/fields/fsp/fsp.go index 360333a..be3cde9 100644 --- a/util/intelp2m/fields/fsp/fsp.go +++ b/util/intelp2m/fields/fsp/fsp.go @@ -74,7 +74,7 @@ 1 << 4 | 0: "GpioDirInInvOut", 1 << 4 | 1: "GpioDirInInv", }, - value : dw0.GetRxInvert() << 4 | dw0.GetRXLevelEdgeConfiguration(), + value : dw0.GetRxInvert() << 4 | dw0.GetGPIORxTxDisableStatus(), }, &field { @@ -116,7 +116,7 @@ 2: "GpioIntLvlEdgDis", 3: "GpioIntBothEdge", }, - value : dw0.GetResetConfig(), + value : dw0.GetRXLevelEdgeConfiguration(), }, &field { -- To view, visit https://review.coreboot.org/c/coreboot/+/54973 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbeeb1fec6a863d0f86659c21924e15ae6765d47 Gerrit-Change-Number: 54973 Gerrit-PatchSet: 4 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

2 hours, 39 minutes

1
0
0 0

Change in coreboot[master]: mb/{fb/fbg1701,portwell/m107}: Don't select HAVE_FSP_BIN

by Arthur Heymans (Code Review)

Attention is currently required from: Arthur Heymans. Hello Arthur Heymans, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/55453 to review the following change. Change subject: mb/{fb/fbg1701,portwell/m107}: Don't select HAVE_FSP_BIN ...................................................................... mb/{fb/fbg1701,portwell/m107}: Don't select HAVE_FSP_BIN This selected by default if 3rdparty/fsp is used. There is no need to override this behavior in the mainboard Kconfig. Change-Id: I01ee2e90e0eceaa3100d911b5460cf99f413b185 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/facebook/fbg1701/Kconfig M src/mainboard/portwell/m107/Kconfig 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/55453/1 diff --git a/src/mainboard/facebook/fbg1701/Kconfig b/src/mainboard/facebook/fbg1701/Kconfig index 73294f8..dc3cdd9 100644 --- a/src/mainboard/facebook/fbg1701/Kconfig +++ b/src/mainboard/facebook/fbg1701/Kconfig @@ -15,7 +15,6 @@ select SOC_INTEL_BRASWELL select SOC_INTEL_COMMON_BLOCK_HDA_VERB select PCIEXP_L1_SUB_STATE - select HAVE_FSP_BIN select DISABLE_HPET select INTEL_GMA_HAVE_VBT select HAVE_SPD_IN_CBFS diff --git a/src/mainboard/portwell/m107/Kconfig b/src/mainboard/portwell/m107/Kconfig index 59a4bdd..c4a903d 100644 --- a/src/mainboard/portwell/m107/Kconfig +++ b/src/mainboard/portwell/m107/Kconfig @@ -9,7 +9,6 @@ select HAVE_OPTION_TABLE select SOC_INTEL_BRASWELL select PCIEXP_L1_SUB_STATE - select HAVE_FSP_BIN select DISABLE_HPET select HAVE_SPD_IN_CBFS -- To view, visit https://review.coreboot.org/c/coreboot/+/55453 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01ee2e90e0eceaa3100d911b5460cf99f413b185 Gerrit-Change-Number: 55453 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

3 hours, 13 minutes

1
0
0 0

Change in coreboot[master]: arch/x86/walkcbfs.S: Use FMAP instead of "cbfs master header"

by Arthur Heymans (Code Review)

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52879 ) Change subject: arch/x86/walkcbfs.S: Use FMAP instead of "cbfs master header" ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > FYI, this change can break platforms with FMD file containing a statement like "FLASH 8M", because on x86 flash is memory mapped under 4GB. It results in fmap_config.h with "#define FMAP_SECTION_FLASH_START 0" and all offsets to regions relative to zero. There is difference bewteen COREBOOT let's say at 0x400000 and at 0xffc00000. So the correct statement in FMD would be "FLASH@<4GB - flash_size> <flash_size>" like "FLASH@0xff800000 8M". If one does not use any FMD file, the autogenerated fmap_config will contain absolute addresses and it will work with this patch. Just found it out with my Dell Optiplex 9010 and a FMD file with "FLASH 12M" statement. Thanks for finding this: fixed in CB:55452 -- To view, visit https://review.coreboot.org/c/coreboot/+/52879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibab657cc40cd5c09c3a73c54950b98ac45a98dbf Gerrit-Change-Number: 52879 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 12 Jun 2021 20:39:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: comment

3 hours, 21 minutes

1
0
0 0

Change in coreboot[master]: arch/x86/walkcbfs.S: Fix the cbfs base addr for some fmap

by Arthur Heymans (Code Review)

Attention is currently required from: Arthur Heymans. Hello Arthur Heymans, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/55452 to review the following change. Change subject: arch/x86/walkcbfs.S: Fix the cbfs base addr for some fmap ...................................................................... arch/x86/walkcbfs.S: Fix the cbfs base addr for some fmap Defining the memory mapped base in fmap for example "FLASH@0xff800000 0x80000" for a 8M flash is optional in fmap files. This will also reflect in the generated fmap_config.h. Fix the assembly cbfs walker walkcbfs.S for fmap lacking a definition of the flash base. Change-Id: I96b18f675e625abee503648ffdc6031978a4269a Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/arch/x86/walkcbfs.S 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/55452/1 diff --git a/src/arch/x86/walkcbfs.S b/src/arch/x86/walkcbfs.S index 4608e2c..208a128 100644 --- a/src/arch/x86/walkcbfs.S +++ b/src/arch/x86/walkcbfs.S @@ -13,6 +13,12 @@ #define CBFS_FILE_STRUCTSIZE (CBFS_FILE_OFFSET + 4) +#if FMAP_SECTION_COREBOOT_START < (0xffffffff - CONFIG_ROM_SIZE + 1) +#define COREBOOT_CBFS_START (0xffffffff - CONFIG_ROM_SIZE + 1 + FMAP_SECTION_COREBOOT_START) +#else +#define COREBOOT_CBFS_START FMAP_SECTION_COREBOOT_START +#endif + .code32 .section .init .global walkcbfs_asm @@ -26,7 +32,7 @@ walkcbfs_asm: cld - movl $FMAP_SECTION_COREBOOT_START, %ebx + movl $COREBOOT_CBFS_START, %ebx /* determine filename length */ mov $0, %eax -- To view, visit https://review.coreboot.org/c/coreboot/+/55452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96b18f675e625abee503648ffdc6031978a4269a Gerrit-Change-Number: 55452 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

3 hours, 23 minutes

1
0
0 0

Change in coreboot[master]: util/intelp2m/fsp: Update some deprecated macros

by Benjamin Doron (Code Review)

Attention is currently required from: Angel Pons. Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54974 ) Change subject: util/intelp2m/fsp: Update some deprecated macros ...................................................................... Patch Set 4: (2 comments) File util/intelp2m/fields/fsp/fsp.go: https://review.coreboot.org/c/coreboot/+/54974/comment/6b15d9a9_723e621c PS3, Line 125: 1: "GpioHostDeepReset", : 2: "GpioPlatformReset", : 3: "GpioResumeReset", > It seemed to me that fsp and edk2-platform use the same macros as intel reference bios, but I was wr […] Not a problem. https://review.coreboot.org/c/coreboot/+/54974/comment/2f0650c1_b3de83a9 PS3, Line 128: }, > Please could you add a comment about Coffee Lake and GpioResetPwrGood? Should I add the comment to the code as well? -- To view, visit https://review.coreboot.org/c/coreboot/+/54974 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab0bb09adad997bef3a2133c443471d4c634f423 Gerrit-Change-Number: 54974 Gerrit-PatchSet: 4 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 12 Jun 2021 20:20:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maxim Polyakov <max.senia.poliak(a)gmail.com> Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-MessageType: comment

3 hours, 40 minutes

1
0
0 0

Change in coreboot[master]: util/intelp2m/fsp: Update some deprecated macros

by Benjamin Doron (Code Review)

Attention is currently required from: Benjamin Doron, Angel Pons. Hello build bot (Jenkins), Maxim Polyakov, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54974 to look at the new patch set (#4). Change subject: util/intelp2m/fsp: Update some deprecated macros ...................................................................... util/intelp2m/fsp: Update some deprecated macros Avoid using deprecated macros, where possible. "GpioResetPwrGood" represents multiple valid updated values, depending on the GPIO community and will be more difficult to update. While Kabylake supports both sets of macros, it will cause build errors on Coffeelake. In the GPD group, replace with "GpioDswReset." Replace with "GpioResumeReset" in any GPP group. Change-Id: Iab0bb09adad997bef3a2133c443471d4c634f423 Signed-off-by: Benjamin Doron <benjamin.doron00(a)gmail.com> --- M util/intelp2m/fields/fsp/fsp.go 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/54974/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/54974 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab0bb09adad997bef3a2133c443471d4c634f423 Gerrit-Change-Number: 54974 Gerrit-PatchSet: 4 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

3 hours, 51 minutes

1
0
0 0

Change in coreboot[master]: mb/lenovo/w541: Add Thinkpad W541

by Peter Lemenkov (Code Review)

Attention is currently required from: Peter Lemenkov, Angel Pons, Alexander Couzens, Patrick Rudolph, amersel, Iru Cai (vimacs). Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52659 ) Change subject: mb/lenovo/w541: Add Thinkpad W541 ...................................................................... Patch Set 21: Code-Review+1 (1 comment) Patchset: PS21: Looks good to me -- To view, visit https://review.coreboot.org/c/coreboot/+/52659 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08 Gerrit-Change-Number: 52659 Gerrit-PatchSet: 21 Gerrit-Owner: amersel Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Iru Cai (vimacs) <mytbk920423(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Attention: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: amersel Gerrit-Attention: Iru Cai (vimacs) <mytbk920423(a)gmail.com> Gerrit-Comment-Date: Sat, 12 Jun 2021 19:22:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 hours, 38 minutes

1
0
0 0

Change in coreboot[master]: util/intelp2m/fsp: Update some deprecated macros

by Maxim Polyakov (Code Review)

Attention is currently required from: Benjamin Doron, Angel Pons. Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54974 ) Change subject: util/intelp2m/fsp: Update some deprecated macros ...................................................................... Patch Set 3: Code-Review+2 (2 comments) File util/intelp2m/fields/fsp/fsp.go: https://review.coreboot.org/c/coreboot/+/54974/comment/ae91eb96_5fe283a2 PS3, Line 125: 1: "GpioHostDeepReset", : 2: "GpioPlatformReset", : 3: "GpioResumeReset", > They were deprecated in Kabylake as well, see https://github. […] It seemed to me that fsp and edk2-platform use the same macros as intel reference bios, but I was wrong. Thanks for clarification. https://review.coreboot.org/c/coreboot/+/54974/comment/be6148fd_d994399f PS3, Line 128: }, > I'm not sure I understand, these are deprecated. […] Please could you add a comment about Coffee Lake and GpioResetPwrGood? -- To view, visit https://review.coreboot.org/c/coreboot/+/54974 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab0bb09adad997bef3a2133c443471d4c634f423 Gerrit-Change-Number: 54974 Gerrit-PatchSet: 3 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 12 Jun 2021 17:43:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Maxim Polyakov <max.senia.poliak(a)gmail.com> Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-MessageType: comment

6 hours, 17 minutes

1
0
0 0

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit