August 2018 - coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: mainboard/google/kahlee/var/liara: Enable Synaptics touchpad device
by Martin Roth (Code Review) Sept. 1, 2018

Sept. 1, 2018

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28398 ) Change subject: mainboard/google/kahlee/var/liara: Enable Synaptics touchpad device ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/28398 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icdafe34a00fd55d5338fa07ffa304e48e7b85e7b Gerrit-Change-Number: 28398 Gerrit-PatchSet: 3 Gerrit-Owner: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> Gerrit-Reviewer: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 31 Aug 2018 22:00:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Fix Coverity Scan report
by Pratikkumar V Prajapati (Code Review) Aug. 31, 2018

Aug. 31, 2018

Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/28409 ) Change subject: soc/intel/cannonlake: Fix Coverity Scan report ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28409 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I050287370f7321ff9905937304bb3cc7f20d8c6a Gerrit-Change-Number: 28409 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Fri, 31 Aug 2018 21:53:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: AMD microcodes: scripts for applying the unofficial (not-merged-yet) ...
by Mike Banon (Code Review) Aug. 31, 2018

Aug. 31, 2018

Mike Banon has abandoned this change. ( https://review.coreboot.org/28425 ) Change subject: AMD microcodes: scripts for applying the unofficial (not-merged-yet) updates ...................................................................... Abandoned I've tested this change and it seems good, but I'll mark it as "Abandoned" because this change is NOT FOR MERGE to the official coreboot -- To view, visit https://review.coreboot.org/28425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ic16c1c4b86576ee7505cceed871b47a2b82f3c56 Gerrit-Change-Number: 28425 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: AMD microcodes: scripts for applying the unofficial (not-merged-yet) ...
by Mike Banon (Code Review) Aug. 31, 2018

Aug. 31, 2018

Mike Banon has posted comments on this change. ( https://review.coreboot.org/28425 ) Change subject: AMD microcodes: scripts for applying the unofficial (not-merged-yet) updates ...................................................................... Patch Set 2: Code-Review+1 I've tested this change and it seems good, but I'll mark it as "Abandoned" because this change is NOT FOR MERGE to the official coreboot -- To view, visit https://review.coreboot.org/28425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic16c1c4b86576ee7505cceed871b47a2b82f3c56 Gerrit-Change-Number: 28425 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 31 Aug 2018 21:50:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: AMD microcodes: scripts for applying the unofficial (not-merged-yet) ...
by build bot (Jenkins) (Code Review) Aug. 31, 2018

Aug. 31, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28425 ) Change subject: AMD microcodes: scripts for applying the unofficial (not-merged-yet) updates ...................................................................... Patch Set 2: (6 comments) https://review.coreboot.org/#/c/28425/2/apply_ucode_patches.sh File apply_ucode_patches.sh: https://review.coreboot.org/#/c/28425/2/apply_ucode_patches.sh@4 PS2, Line 4: ### src/vendorcode/amd/agesa/f15tn: Update microcode to version 0x600111F 2018-03-05 line over 80 characters https://review.coreboot.org/#/c/28425/2/apply_ucode_patches.sh@9 PS2, Line 9: ### src/vendorcode/amd/agesa/f16kb: Update microcode to version 0x7000110 2018-02-09 line over 80 characters https://review.coreboot.org/#/c/28425/2/apply_ucode_patches.sh@14 PS2, Line 14: ### src/vendorcode/amd/agesa/f12: Update microcode to version 0x3000027 2011-09-13 line over 80 characters https://review.coreboot.org/#/c/28425/2/get_ucode_patches.sh File get_ucode_patches.sh: https://review.coreboot.org/#/c/28425/2/get_ucode_patches.sh@5 PS2, Line 5: ### src/vendorcode/amd/agesa/f15tn: Update microcode to version 0x600111F 2018-03-05 line over 80 characters https://review.coreboot.org/#/c/28425/2/get_ucode_patches.sh@11 PS2, Line 11: ### src/vendorcode/amd/agesa/f16kb: Update microcode to version 0x7000110 2018-02-09 line over 80 characters https://review.coreboot.org/#/c/28425/2/get_ucode_patches.sh@17 PS2, Line 17: ### src/vendorcode/amd/agesa/f12: Update microcode to version 0x3000027 2011-09-13 line over 80 characters -- To view, visit https://review.coreboot.org/28425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic16c1c4b86576ee7505cceed871b47a2b82f3c56 Gerrit-Change-Number: 28425 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 31 Aug 2018 21:29:56 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: AMD microcodes: scripts for applying the unofficial (not-merged-yet) ...
by build bot (Jenkins) (Code Review) Aug. 31, 2018

Aug. 31, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28425 ) Change subject: AMD microcodes: scripts for applying the unofficial (not-merged-yet) updates ...................................................................... Patch Set 1: (6 comments) https://review.coreboot.org/#/c/28425/1/apply_ucode_patches.sh File apply_ucode_patches.sh: https://review.coreboot.org/#/c/28425/1/apply_ucode_patches.sh@4 PS1, Line 4: ### src/vendorcode/amd/agesa/f15tn: Update microcode to version 0x600111F 2018-03-05 line over 80 characters https://review.coreboot.org/#/c/28425/1/apply_ucode_patches.sh@9 PS1, Line 9: ### src/vendorcode/amd/agesa/f16kb: Update microcode to version 0x7000110 2018-02-09 line over 80 characters https://review.coreboot.org/#/c/28425/1/apply_ucode_patches.sh@14 PS1, Line 14: ### src/vendorcode/amd/agesa/f12: Update microcode to version 0x3000027 2011-09-13 line over 80 characters https://review.coreboot.org/#/c/28425/1/get_ucode_patches.sh File get_ucode_patches.sh: https://review.coreboot.org/#/c/28425/1/get_ucode_patches.sh@5 PS1, Line 5: ### src/vendorcode/amd/agesa/f15tn: Update microcode to version 0x600111F 2018-03-05 line over 80 characters https://review.coreboot.org/#/c/28425/1/get_ucode_patches.sh@11 PS1, Line 11: ### src/vendorcode/amd/agesa/f16kb: Update microcode to version 0x7000110 2018-02-09 line over 80 characters https://review.coreboot.org/#/c/28425/1/get_ucode_patches.sh@17 PS1, Line 17: ### src/vendorcode/amd/agesa/f12: Update microcode to version 0x3000027 2011-09-13 line over 80 characters -- To view, visit https://review.coreboot.org/28425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic16c1c4b86576ee7505cceed871b47a2b82f3c56 Gerrit-Change-Number: 28425 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 31 Aug 2018 21:28:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: AMD microcodes: scripts for applying the unofficial (not-merged-yet) ...
by Mike Banon (Code Review) Aug. 31, 2018

Aug. 31, 2018

Mike Banon has uploaded this change for review. ( https://review.coreboot.org/28425 Change subject: AMD microcodes: scripts for applying the unofficial (not-merged-yet) updates ...................................................................... AMD microcodes: scripts for applying the unofficial (not-merged-yet) updates These scripts will help you to securely and conveniently apply the four changes 28273 , 28370 , 28378 , 28391 to update AMD microcodes or fix their formatting. Save to ./coreboot/ then run ./get_ucode_patches.sh , ./check... and ./apply... https://review.coreboot.org/c/coreboot/+/28273 src/vendorcode/amd/agesa/f15tn: Update microcode to version 0x600111F 2018-03-05 https://review.coreboot.org/c/coreboot/+/28370 src/vendorcode/amd/agesa/f16kb: Update microcode to version 0x7000110 2018-02-09 https://review.coreboot.org/c/coreboot/+/28378 src/vendorcode/amd/agesa/f12: Update microcode to version 0x3000027 2011-09-13 https://review.coreboot.org/c/coreboot/+/28391 src/vendorcode/amd/agesa: Improve formatting of some f12 and f14 microcodes Change-Id: Ic16c1c4b86576ee7505cceed871b47a2b82f3c56 Signed-off-by: Mike Banon <mikebdp2(a)gmail.com> --- A apply_ucode_patches.sh A check_ucode_patches.sh A get_ucode_patches.sh A sha256sums_correct.txt 4 files changed, 63 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/28425/1 diff --git a/apply_ucode_patches.sh b/apply_ucode_patches.sh new file mode 100755 index 0000000..65c3ebc --- /dev/null +++ b/apply_ucode_patches.sh @@ -0,0 +1,21 @@ +#!/bin/sh +### +### https://review.coreboot.org/c/coreboot/+/28273 +### src/vendorcode/amd/agesa/f15tn: Update microcode to version 0x600111F 2018-03-05 +### +patch -p1 < c448029.diff +### +### https://review.coreboot.org/c/coreboot/+/28370 +### src/vendorcode/amd/agesa/f16kb: Update microcode to version 0x7000110 2018-02-09 +### +patch -p1 < 88adcda.diff +### +### https://review.coreboot.org/c/coreboot/+/28378 +### src/vendorcode/amd/agesa/f12: Update microcode to version 0x3000027 2011-09-13 +### +patch -p1 < 6e72ba6.diff +### +### https://review.coreboot.org/c/coreboot/+/28391 +### src/vendorcode/amd/agesa: Improve formatting of some f12 and f14 microcodes +### +patch -p1 < e24e1f4.diff diff --git a/check_ucode_patches.sh b/check_ucode_patches.sh new file mode 100755 index 0000000..f6ba840 --- /dev/null +++ b/check_ucode_patches.sh @@ -0,0 +1,12 @@ +#!/bin/sh +rm -f ./sha256sums_my.txt +sha256sum ./c448029.diff > ./sha256sums_my.txt +sha256sum ./88adcda.diff >> ./sha256sums_my.txt +sha256sum ./6e72ba6.diff >> ./sha256sums_my.txt +sha256sum ./e24e1f4.diff >> ./sha256sums_my.txt +if cmp -s "./sha256sums_my.txt" "./sha256sums_correct.txt" +then + echo "SHA256 checksums are correct, please run ./apply_ucode_patches.sh" +else + echo "! MISMATCH ! See ./sha256sums_my.txt and ./sha256sums_correct.txt" +fi diff --git a/get_ucode_patches.sh b/get_ucode_patches.sh new file mode 100755 index 0000000..d23b2bc --- /dev/null +++ b/get_ucode_patches.sh @@ -0,0 +1,26 @@ +#!/bin/sh +rm -f ./*.diff && rm -f ./patch?zip +### +### https://review.coreboot.org/c/coreboot/+/28273 +### src/vendorcode/amd/agesa/f15tn: Update microcode to version 0x600111F 2018-03-05 +### +wget https://review.coreboot.org/changes/28273/revisions/3/patch?zip +unzip ./patch?zip && rm -f ./patch?zip # && patch -p1 < c448029.diff +### +### https://review.coreboot.org/c/coreboot/+/28370 +### src/vendorcode/amd/agesa/f16kb: Update microcode to version 0x7000110 2018-02-09 +### +wget https://review.coreboot.org/changes/28370/revisions/3/patch?zip +unzip ./patch?zip && rm -f ./patch?zip # && patch -p1 < 88adcda.diff +### +### https://review.coreboot.org/c/coreboot/+/28378 +### src/vendorcode/amd/agesa/f12: Update microcode to version 0x3000027 2011-09-13 +### +wget https://review.coreboot.org/changes/28378/revisions/2/patch?zip +unzip ./patch?zip && rm -f ./patch?zip # && patch -p1 < 6e72ba6.diff +### +### https://review.coreboot.org/c/coreboot/+/28391 +### src/vendorcode/amd/agesa: Improve formatting of some f12 and f14 microcodes +### +wget https://review.coreboot.org/changes/28391/revisions/2/patch?zip +unzip ./patch?zip && rm -f ./patch?zip # && patch -p1 < e24e1f4.diff diff --git a/sha256sums_correct.txt b/sha256sums_correct.txt new file mode 100755 index 0000000..c7142c6 --- /dev/null +++ b/sha256sums_correct.txt @@ -0,0 +1,4 @@ +68708a53a9a435ff6758c5a76a9f34262399b140b2dcc4b9da534817334e8a9d ./c448029.diff +c477357f19c948e25276d7c88380cc021600301e16d17092e7c28cdbf6f0ea92 ./88adcda.diff +36041d96feba2a2d4ebe5fb8739665062354fe5ebaf0434c35d1f6cc755b3fe2 ./6e72ba6.diff +ac811f95bae4030925783f166d7ad5b052930233b732a92243de55c6230e609c ./e24e1f4.diff -- To view, visit https://review.coreboot.org/28425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic16c1c4b86576ee7505cceed871b47a2b82f3c56 Gerrit-Change-Number: 28425 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>

1 0

Change in coreboot[master]: mainboard/google/kahlee/var/liara: Enable Synaptics touchpad device
by Martin Roth (Code Review) Aug. 31, 2018

Aug. 31, 2018

Martin Roth has uploaded a new patch set (#3) to the change originally created by Crystal Lin. ( https://review.coreboot.org/28398 ) Change subject: mainboard/google/kahlee/var/liara: Enable Synaptics touchpad device ...................................................................... mainboard/google/kahlee/var/liara: Enable Synaptics touchpad device Enable Synaptics touchpad device for liara BUG=b:113309346 BRANCH=master TEST=Verify touchpad on liara works with this change Change-Id: Icdafe34a00fd55d5338fa07ffa304e48e7b85e7b Signed-off-by: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> --- M src/mainboard/google/kahlee/Kconfig M src/mainboard/google/kahlee/variants/liara/devicetree.cb 2 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/28398/3 -- To view, visit https://review.coreboot.org/28398 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icdafe34a00fd55d5338fa07ffa304e48e7b85e7b Gerrit-Change-Number: 28398 Gerrit-PatchSet: 3 Gerrit-Owner: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> Gerrit-Reviewer: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/pmh7tool: Add option to read specific bit
by Felix Held (Code Review) Aug. 31, 2018

Aug. 31, 2018

Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/28388 ) Change subject: util/pmh7tool: Add option to read specific bit ...................................................................... util/pmh7tool: Add option to read specific bit Change-Id: I045383eedbcf438270e9c64329a8d910bb941ab8 Signed-off-by: Evgeny Zinoviev <me(a)ch1p.com> Reviewed-on: https://review.coreboot.org/28388 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M util/pmh7tool/pmh7tool.c 1 file changed, 27 insertions(+), 9 deletions(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved diff --git a/util/pmh7tool/pmh7tool.c b/util/pmh7tool/pmh7tool.c index d0c652e..f03d97e 100644 --- a/util/pmh7tool/pmh7tool.c +++ b/util/pmh7tool/pmh7tool.c @@ -53,16 +53,25 @@ pmh7_register_write(reg, val & ~(1 << bit)); } +uint8_t pmh7_register_read_bit(int16_t reg, uint8_t bit) +{ + uint8_t val; + + val = pmh7_register_read(reg); + return (val >> bit) & 1; +} + void print_usage(const char *name) { printf("usage: %s\n", name); printf("\n" - " -h, --help: print this help\n" - " -d, --dump: print registers\n" - " -w, --write <addr> <data>: write to register\n" - " -r, --read <addr>: read from register\n" - " -c, --clear-bit <addr> <bit>\n" - " -s, --set-bit <addr> <bit>\n" + " -h, --help: print this help\n" + " -d, --dump: print registers\n" + " -w, --write <addr> <data>: write to register\n" + " -r, --read <addr>: read from register\n" + " -b, --read-bit <addr> <bit> read bit\n" + " -c, --clear-bit <addr> <bit> clear bit\n" + " -s, --set-bit <addr> <bit> set bit\n" "\n" "Attention! Writing to PMH7 registers is very dangerous, as you\n" " directly manipulate the power rails, enable lines,\n" @@ -71,7 +80,7 @@ "\n"); } -enum action {HELP, DUMP, WRITE, READ, CLEAR, SET}; +enum action {HELP, DUMP, WRITE, READ, READBIT, CLEAR, SET}; int main(int argc, char *argv[]) { @@ -84,6 +93,7 @@ {"dump", 0, 0, 'd'}, {"write", 1, 0, 'w'}, {"read", 1, 0, 'r'}, + {"read-bit", 1, 0, 'b'}, {"clear-bit", 1, 0, 'c'}, {"set-bit", 1, 0, 's'}, {0, 0, 0, 0} @@ -94,7 +104,7 @@ exit(0); } - while ((opt = getopt_long(argc, argv, "hdw:r:c:s:", + while ((opt = getopt_long(argc, argv, "hdw:r:c:s:b:", long_options, &option_index)) != EOF) { switch (opt) { case 'd': @@ -107,6 +117,7 @@ break; case 'w': + case 'b': case 'c': case 's': input_addr = strtoul(optarg, NULL, 16); @@ -125,6 +136,9 @@ case 'w': act = WRITE; break; + case 'b': + act = READBIT; + break; case 'c': act = CLEAR; break; @@ -153,7 +167,7 @@ exit(1); } - if (act == SET || act == CLEAR) { + if (act == SET || act == CLEAR || act == READBIT) { if (input_data > 7) { fprintf(stderr, "Error: <bit> cannot be greater than 7.\n"); @@ -198,6 +212,10 @@ pmh7_register_write(input_addr, input_data); break; + case READBIT: + printf("%d\n", pmh7_register_read_bit(input_addr, input_data)); + break; + case CLEAR: pmh7_register_clear_bit(input_addr, input_data); break; -- To view, visit https://review.coreboot.org/28388 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I045383eedbcf438270e9c64329a8d910bb941ab8 Gerrit-Change-Number: 28388 Gerrit-PatchSet: 3 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: payloads/LinuxBoot: Fix remaining issues
by Philipp Deppenwiese (Code Review) Aug. 31, 2018

Aug. 31, 2018

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28401 to look at the new patch set (#2). Change subject: payloads/LinuxBoot: Fix remaining issues ...................................................................... payloads/LinuxBoot: Fix remaining issues * Update kernel versions * Fix initrd path handling Change-Id: Ia0641fd0c0db1e47ee4829b73871af662d4a6370 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M payloads/external/LinuxBoot/Kconfig M payloads/external/LinuxBoot/Makefile M payloads/external/LinuxBoot/targets/u-root.mk M payloads/external/Makefile.inc 4 files changed, 13 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/28401/2 -- To view, visit https://review.coreboot.org/28401 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia0641fd0c0db1e47ee4829b73871af662d4a6370 Gerrit-Change-Number: 28401 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0