coreboot-gerrit August 2018

coreboot-gerrit@coreboot.org

1 participants
1120 discussions

Change in coreboot[master]: mb/lenovo: Dual Graphics for xx20/xx30 ThinkPads
by Patrick Rudolph (Code Review) 31 Aug '18

31 Aug '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28393 ) Change subject: mb/lenovo: Dual Graphics for xx20/xx30 ThinkPads ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/28393/2/src/mainboard/lenovo/t430s/romstage… File src/mainboard/lenovo/t430s/romstage.c: https://review.coreboot.org/#/c/28393/2/src/mainboard/lenovo/t430s/romstage… PS2, Line 72: enum hybrid_graphics_req mode = HYBRID_GRAPHICS_INTEGRATED; why not using the hybrid graphics driver ? it looks like the code is the same. Just use: has_thinker1 = 1 has_panel_hybrid_gpio = 0 has_backlight_gpio = 0 I'm not sure about detect_gpio. If you want to make sure hybrid_graphics_mode isn't DISCRETE (which can't be set using nvramtool or nvramcui anyway) you could use set_option() here and then call early_hybrid_graphics. -- To view, visit https://review.coreboot.org/28393 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8842fef0fa1235eb91abf6b7e655ed4d8598adc7 Gerrit-Change-Number: 28393 Gerrit-PatchSet: 2 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 31 Aug 2018 07:13:03 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: riscv: update mtime initialization
by build bot (Jenkins) (Code Review) 31 Aug '18

31 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28372 ) Change subject: riscv: update mtime initialization ...................................................................... Patch Set 5: (2 comments) https://review.coreboot.org/#/c/28372/5/src/soc/ucb/riscv/ipi.c File src/soc/ucb/riscv/ipi.c: https://review.coreboot.org/#/c/28372/5/src/soc/ucb/riscv/ipi.c@25 PS5, Line 25: } adding a line without newline at end of file https://review.coreboot.org/#/c/28372/5/src/soc/ucb/riscv/mtime.c File src/soc/ucb/riscv/mtime.c: https://review.coreboot.org/#/c/28372/5/src/soc/ucb/riscv/mtime.c@23 PS5, Line 23: } adding a line without newline at end of file -- To view, visit https://review.coreboot.org/28372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5524732f6eb3841e43afd176644119b03b5e5e27 Gerrit-Change-Number: 28372 Gerrit-PatchSet: 5 Gerrit-Owner: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Fri, 31 Aug 2018 06:34:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Correct number of root ports for CNL PCH H
by Maulik V Vaghela (Code Review) 31 Aug '18

31 Aug '18

Hello Naresh Solanki, PraveenX Hodagatta Pranesh, Subrata Banik, Balaji Manigandan, Kin Wai Ng, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28399 to look at the new patch set (#2). Change subject: soc/intel/cannonlake: Correct number of root ports for CNL PCH H ...................................................................... soc/intel/cannonlake: Correct number of root ports for CNL PCH H CNL PCH H supports maximum 24 root ports while CNL PCH LP supports maximum 16 root ports. Change-Id: I2cc3ae282d4eb5da8b0618451e062a6c061f1d6f Signed-off-by: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> --- M src/soc/intel/cannonlake/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/28399/2 -- To view, visit https://review.coreboot.org/28399 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2cc3ae282d4eb5da8b0618451e062a6c061f1d6f Gerrit-Change-Number: 28399 Gerrit-PatchSet: 2 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kin Wai Ng <kin.wai.ng(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: riscv: separately define stack locations at different stages
by build bot (Jenkins) (Code Review) 31 Aug '18

31 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28383 ) Change subject: riscv: separately define stack locations at different stages ...................................................................... Patch Set 3: (2 comments) https://review.coreboot.org/#/c/28383/3/src/arch/riscv/include/arch/memlayo… File src/arch/riscv/include/arch/memlayout.h: https://review.coreboot.org/#/c/28383/3/src/arch/riscv/include/arch/memlayo… PS3, Line 24: #define CAR_STACK(addr, size) \ Macros with complex values should be enclosed in parentheses https://review.coreboot.org/#/c/28383/3/src/arch/riscv/include/arch/memlayo… PS3, Line 32: #define MEM_STACK(addr, size) \ Macros with complex values should be enclosed in parentheses -- To view, visit https://review.coreboot.org/28383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37a0c1928052cabf61ba5c25b440363b75726782 Gerrit-Change-Number: 28383 Gerrit-PatchSet: 3 Gerrit-Owner: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 31 Aug 2018 03:13:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: payloads/LinuxBoot: Fix remaining issues
by Philipp Deppenwiese (Code Review) 30 Aug '18

30 Aug '18

Philipp Deppenwiese has uploaded this change for review. ( https://review.coreboot.org/28401 Change subject: payloads/LinuxBoot: Fix remaining issues ...................................................................... payloads/LinuxBoot: Fix remaining issues * Update kernel versions * Fix initrd path handling * Use build/fit.dtb as default Change-Id: Ia0641fd0c0db1e47ee4829b73871af662d4a6370 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M payloads/external/LinuxBoot/Kconfig M payloads/external/LinuxBoot/Makefile M payloads/external/LinuxBoot/targets/u-root.mk M payloads/external/Makefile.inc 4 files changed, 14 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/28401/1 diff --git a/payloads/external/LinuxBoot/Kconfig b/payloads/external/LinuxBoot/Kconfig index 7a40645..2193ec7 100644 --- a/payloads/external/LinuxBoot/Kconfig +++ b/payloads/external/LinuxBoot/Kconfig @@ -50,12 +50,12 @@ default LINUXBOOT_KERNEL_STABLE config LINUXBOOT_KERNEL_STABLE - bool "4.15.3" + bool "4.14.67" help Stable kernel version config LINUXBOOT_KERNEL_LATEST - bool "4.17.11" + bool "4.18.5" help Latest kernel version @@ -63,8 +63,8 @@ config LINUXBOOT_KERNEL_VERSION string - default "4.17.11" if LINUXBOOT_KERNEL_LATEST - default "4.15.3" if LINUXBOOT_KERNEL_STABLE + default "4.18.5" if LINUXBOOT_KERNEL_LATEST + default "4.14.67" if LINUXBOOT_KERNEL_STABLE config LINUXBOOT_KERNEL_CONFIGFILE string "Kernel config file" @@ -82,7 +82,7 @@ config LINUXBOOT_DTB_FILE string "Compiled devicetree file" depends on LINUXBOOT_ARM64 - default "" + default "build/fit.dtb" config PAYLOAD_FILE default "payloads/external/LinuxBoot/linuxboot/kernel-image" diff --git a/payloads/external/LinuxBoot/Makefile b/payloads/external/LinuxBoot/Makefile index f259373..c051389 100644 --- a/payloads/external/LinuxBoot/Makefile +++ b/payloads/external/LinuxBoot/Makefile @@ -77,26 +77,26 @@ $(project_dir)/vmlinux.bin: $(kernel_dir)/vmlinux $(OBJCOPY) -O binary $< $@ -$(project_dir)/target.dtb: $(CONFIG_LINUXBOOT_DTB_FILE) +$(project_dir)/target.dtb: $(PWD)/$(CONFIG_LINUXBOOT_DTB_FILE) cp $< $@ $(project_dir)/vmlinux.bin.lzma: $(project_dir)/vmlinux.bin xz -c -k -f --format=lzma --lzma1=dict=1MiB,lc=3,lp=0,pb=3 $< > $@ -$(project_dir)/kernel-image: $(project_dir)/vmlinux.bin.lzma $(project_dir)/../arm64/kernel_fdt_lzma.its $(project_dir)/target.dtb $(project_dir)/initramfs.cpio.xz +$(project_dir)/kernel-image: $(project_dir)/vmlinux.bin.lzma $(project_dir)/../arm64/kernel_fdt_lzma.its $(project_dir)/target.dtb $(PWD)/$(CONFIG_PAYLOAD_USERSPACE) cp $(project_dir)/../arm64/kernel_fdt_lzma.its $(project_dir) mkimage -f $(project_dir)/kernel_fdt_lzma.its $@ endif ifeq ($(CONFIG_LINUXBOOT_UROOT),y) -$(project_dir)/initramfs.cpio.xz: +$(PWD)/$(CONFIG_PAYLOAD_USERSPACE): $(MAKE) -f targets/u-root.mk else -$(project_dir)/initramfs.cpio.xz: +$(PWD)/$(CONFIG_PAYLOAD_USERSPACE): echo "Building without u-root support" endif -payload: $(project_dir)/kernel-image $(project_dir)/initramfs.cpio.xz +payload: $(project_dir)/kernel-image $(PWD)/$(CONFIG_PAYLOAD_USERSPACE) clean: if [ -d "$(kernel_dir)" ]; then rm -rf $(kernel_dir); fi diff --git a/payloads/external/LinuxBoot/targets/u-root.mk b/payloads/external/LinuxBoot/targets/u-root.mk index f3c70a6..001f7c4 100644 --- a/payloads/external/LinuxBoot/targets/u-root.mk +++ b/payloads/external/LinuxBoot/targets/u-root.mk @@ -71,10 +71,10 @@ else ifneq ($(CONFIG_LINUXBOOT_UROOT_FILES),) cd $(uroot_dir); GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \ - -build=bb -files $(CONFIG_LINUXBOOT_UROOT_FILES) -o $(project_dir)/initramfs.cpio + -build=bb -files $(CONFIG_LINUXBOOT_UROOT_FILES) -o $(project_dir)/initramfs.cpio coreboot-app else cd $(uroot_dir); GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \ - -build=bb -o $(project_dir)/initramfs.cpio + -build=bb -o $(project_dir)/initramfs.cpio coreboot-app endif endif xz -f --check=crc32 -9 --lzma2=dict=1MiB --threads=$(CPUS) $(project_dir)/initramfs.cpio diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index f350622..8bd0dc3 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -274,7 +274,8 @@ CONFIG_LINUXBOOT_ARCH=$(CONFIG_LINUXBOOT_ARCH) \ CONFIG_LINUXBOOT_UROOT=$(CONFIG_LINUXBOOT_UROOT) \ CONFIG_LINUXBOOT_UROOT_FILES=$(CONFIG_LINUXBOOT_UROOT_FILES) \ - CONFIG_LINUXBOOT_DTB_FILE=$(CONFIG_LINUXBOOT_DTB_FILE) + CONFIG_LINUXBOOT_DTB_FILE=$(CONFIG_LINUXBOOT_DTB_FILE) \ + CONFIG_PAYLOAD_USERSPACE=$(CONFIG_PAYLOAD_USERSPACE) payloads/external/LinuxBoot/linuxboot/kernel-image: linuxboot -- To view, visit https://review.coreboot.org/28401 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia0641fd0c0db1e47ee4829b73871af662d4a6370 Gerrit-Change-Number: 28401 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>

1 0

Change in coreboot[master]: [WIP] Nvidia Optimus support for ThinkPads
by Evgeny Zinoviev (Code Review) 30 Aug '18

30 Aug '18

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28380 to look at the new patch set (#9). Change subject: [WIP] Nvidia Optimus support for ThinkPads ...................................................................... [WIP] Nvidia Optimus support for ThinkPads Based on siro's work #23041. Tested on ThinkPad W530. Adds ACPI code for dGPU power management. Depends on: https://review.coreboot.org/#/c/coreboot/+/28392 https://review.coreboot.org/#/c/coreboot/+/28393 What works (tested on 4.16.13-gentoo kernel): - power management via _PS0 and _DSM + _PS3 ACPI calls - nouveau driver - bumblebee (from the "develop" branch) - bbswitch - VGA ROM loading Known problems: - `lspci -s 01:00.0 -vv` turns dGPU on if it was off before. Not sure why it happens (probably it calls _PS0 at some point) or whether it should happen. - nvidia driver doens't work: [ 275.244113] NVRM: failed to copy vbios to system memory. [ 275.244345] NVRM: RmInitAdapter failed! (0x30:0xffff:663) [ 275.244433] NVRM: rm_init_adapter failed for device bearing minor number 0 [ 275.347956] NVRM: failed to copy vbios to system memory. [ 275.348140] NVRM: RmInitAdapter failed! (0x30:0xffff:663) [ 275.348163] NVRM: rm_init_adapter failed for device bearing minor number 0 Change-Id: I277808d6c1d8bd6e0a267a53f25471597698f8d5 Signed-off-by: Evgeny Zinoviev <me(a)ch1p.com> --- A src/drivers/lenovo/hybrid_graphics/acpi/gpu.asl A src/drivers/nvidia/optimus/acpi/optimus.asl A src/ec/lenovo/pmh7/acpi/pmh7.asl M src/mainboard/lenovo/t420/acpi/ec.asl M src/mainboard/lenovo/t420/dsdt.asl M src/mainboard/lenovo/t420s/acpi/ec.asl M src/mainboard/lenovo/t420s/dsdt.asl M src/mainboard/lenovo/t430/acpi/ec.asl M src/mainboard/lenovo/t430/dsdt.asl M src/mainboard/lenovo/t430s/acpi/ec.asl M src/mainboard/lenovo/t430s/dsdt.asl M src/mainboard/lenovo/t520/acpi/ec.asl M src/mainboard/lenovo/t520/dsdt.asl M src/mainboard/lenovo/t530/acpi/ec.asl M src/mainboard/lenovo/t530/dsdt.asl M src/northbridge/intel/sandybridge/acpi/peg.asl 16 files changed, 357 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/28380/9 -- To view, visit https://review.coreboot.org/28380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I277808d6c1d8bd6e0a267a53f25471597698f8d5 Gerrit-Change-Number: 28380 Gerrit-PatchSet: 9 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anonymous Coward (1002090)

1 0

Change in coreboot[master]: [WIP] Nvidia Optimus support for ThinkPads
by Evgeny Zinoviev (Code Review) 30 Aug '18

30 Aug '18

Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/28380 ) Change subject: [WIP] Nvidia Optimus support for ThinkPads ...................................................................... Patch Set 8: nvidia driver still doesn't work, log: [ 275.048429] nvidia: module license 'NVIDIA' taints kernel. [ 275.048432] Disabling lock debugging due to kernel taint [ 275.059390] nvidia-nvlink: Nvlink Core is being initialized, major device number 245 [ 275.059597] nvidia 0000:01:00.0: vgaarb: changed VGA decodes: olddecodes=io+mem,decodes=none:owns=none [ 275.059682] NVRM: loading NVIDIA UNIX x86_64 Kernel Module 396.45 Thu Jul 12 20:49:29 PDT 2018 (using threaded interrupts) [ 275.096566] nvidia-modeset: Loading NVIDIA Kernel Mode Setting Driver for UNIX platforms 396.45 Fri Jul 13 00:56:44 PDT 2018 [ 275.100189] [drm] [nvidia-drm] [GPU ID 0x00000100] Loading driver [ 275.100191] [drm] Initialized nvidia-drm 0.0.0 20160202 for 0000:01:00.0 on minor 1 [ 275.129266] resource sanity check: requesting [mem 0x000e0000-0x000fffff], which spans more than PCI Bus 0000:00 [mem 0x000e0000-0x000e3fff window] [ 275.129370] caller _nv028850rm+0x57/0x90 [nvidia] mapping multiple BARs [ 275.244113] NVRM: failed to copy vbios to system memory. [ 275.244345] NVRM: RmInitAdapter failed! (0x30:0xffff:663) [ 275.244433] NVRM: rm_init_adapter failed for device bearing minor number 0 [ 275.347956] NVRM: failed to copy vbios to system memory. [ 275.348140] NVRM: RmInitAdapter failed! (0x30:0xffff:663) [ 275.348163] NVRM: rm_init_adapter failed for device bearing minor number 0 -- To view, visit https://review.coreboot.org/28380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I277808d6c1d8bd6e0a267a53f25471597698f8d5 Gerrit-Change-Number: 28380 Gerrit-PatchSet: 8 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anonymous Coward (1002090) Gerrit-Comment-Date: Thu, 30 Aug 2018 20:57:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [WIP] Nvidia Optimus support for ThinkPads
by Evgeny Zinoviev (Code Review) 30 Aug '18

30 Aug '18

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28380 to look at the new patch set (#8). Change subject: [WIP] Nvidia Optimus support for ThinkPads ...................................................................... [WIP] Nvidia Optimus support for ThinkPads Based on siro's work #23041. Tested on ThinkPad W530. Adds ACPI code for dGPU power management. Depends on: https://review.coreboot.org/#/c/coreboot/+/28392 https://review.coreboot.org/#/c/coreboot/+/28393 What works (tested on 4.16.13-gentoo kernel): - power management via _PS0 and _DSM + _PS3 ACPI calls - nouveau driver (with a workaround, see below) - bumblebee (from the "develop" branch) - bbswitch - VGA ROM loading Known problems: - `lspci -s 01:00.0 -vv` turns dGPU on if it was off before. Not sure why it happens (probably it calls _PS0 at some point) or whether it should happen. Not tested yet: - nvidia proprietary driver Change-Id: I277808d6c1d8bd6e0a267a53f25471597698f8d5 Signed-off-by: Evgeny Zinoviev <me(a)ch1p.com> --- A src/drivers/lenovo/hybrid_graphics/acpi/gpu.asl A src/drivers/nvidia/optimus/acpi/optimus.asl A src/ec/lenovo/pmh7/acpi/pmh7.asl M src/mainboard/lenovo/t420/acpi/ec.asl M src/mainboard/lenovo/t420/dsdt.asl M src/mainboard/lenovo/t420s/acpi/ec.asl M src/mainboard/lenovo/t420s/dsdt.asl M src/mainboard/lenovo/t430/acpi/ec.asl M src/mainboard/lenovo/t430/dsdt.asl M src/mainboard/lenovo/t430s/acpi/ec.asl M src/mainboard/lenovo/t430s/dsdt.asl M src/mainboard/lenovo/t520/acpi/ec.asl M src/mainboard/lenovo/t520/dsdt.asl M src/mainboard/lenovo/t530/acpi/ec.asl M src/mainboard/lenovo/t530/dsdt.asl M src/northbridge/intel/sandybridge/acpi/peg.asl 16 files changed, 357 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/28380/8 -- To view, visit https://review.coreboot.org/28380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I277808d6c1d8bd6e0a267a53f25471597698f8d5 Gerrit-Change-Number: 28380 Gerrit-PatchSet: 8 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anonymous Coward (1002090)

1 0

Change in coreboot[master]: [WIP] Nvidia Optimus support for ThinkPads
by Evgeny Zinoviev (Code Review) 30 Aug '18

30 Aug '18

Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/28380 ) Change subject: [WIP] Nvidia Optimus support for ThinkPads ...................................................................... Patch Set 7: > Just some additional information if someone finds it useful: > nvidia proprietary driver won't work unless the _ROM method is > implemented. This is true even for qemu/kvm guest to which you can > pass the pci-rom argument. That is sufficient for nouveau though. > > Related threads: > https://old.reddit.com/r/VFIO/comments/6q7bf5/short_report_wip_got_the_nvid… > https://github.com/jscinoz/optimus-vfio-docs Thanks, I'll check this. -- To view, visit https://review.coreboot.org/28380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I277808d6c1d8bd6e0a267a53f25471597698f8d5 Gerrit-Change-Number: 28380 Gerrit-PatchSet: 7 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anonymous Coward (1002090) Gerrit-Comment-Date: Thu, 30 Aug 2018 20:29:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [WIP] Nvidia Optimus support for ThinkPads
by Evgeny Zinoviev (Code Review) 30 Aug '18

30 Aug '18

Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/28380 ) Change subject: [WIP] Nvidia Optimus support for ThinkPads ...................................................................... Patch Set 7: (1 comment) https://review.coreboot.org/#/c/28380/7//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/28380/7//COMMIT_MSG@41 PS7, Line 41: - VGA ROM for Nvidia GPU is not loaded from BIOS (i.e. coreboot). Need > I think I know why it doesn't work. […] Yes, I edited the device id and it works now, so I guess we can remove it from the list of "known problems". But we should document it later. -- To view, visit https://review.coreboot.org/28380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I277808d6c1d8bd6e0a267a53f25471597698f8d5 Gerrit-Change-Number: 28380 Gerrit-PatchSet: 7 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anonymous Coward (1002090) Gerrit-Comment-Date: Thu, 30 Aug 2018 20:28:36 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

← Newer
1
2
3
4
5
6
7
...
112
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2018