coreboot-gerrit August 2018

coreboot-gerrit@coreboot.org

1 participants
1120 discussions

Change in coreboot[master]: [WIP] Nvidia Optimus support for ThinkPads
by Anonymous Coward (Code Review) 30 Aug '18

30 Aug '18

Anonymous Coward (1002090) has posted comments on this change. ( https://review.coreboot.org/28380 ) Change subject: [WIP] Nvidia Optimus support for ThinkPads ...................................................................... Patch Set 7: Just some additional information if someone finds it useful: nvidia proprietary driver won't work unless the _ROM method is implemented. This is true even for qemu/kvm guest to which you can pass the pci-rom argument. That is sufficient for nouveau though. Related threads: https://old.reddit.com/r/VFIO/comments/6q7bf5/short_report_wip_got_the_nvid… https://github.com/jscinoz/optimus-vfio-docs -- To view, visit https://review.coreboot.org/28380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I277808d6c1d8bd6e0a267a53f25471597698f8d5 Gerrit-Change-Number: 28380 Gerrit-PatchSet: 7 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anonymous Coward (1002090) Gerrit-Comment-Date: Thu, 30 Aug 2018 20:24:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [WIP] Nvidia Optimus support for ThinkPads
by Evgeny Zinoviev (Code Review) 30 Aug '18

30 Aug '18

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Set grip sensor threshold
by Martin Roth (Code Review) 30 Aug '18

30 Aug '18

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/28381 ) Change subject: mb/google/poppy/variants/nautilus: Set grip sensor threshold ...................................................................... mb/google/poppy/variants/nautilus: Set grip sensor threshold Set threshold parameter for grip sensor STH9321 .ProxCtrl6: 75 .ProxCtrl7: 99 BUG=b:113303916 BRANCH=poppy TEST=Built and verified parameter passed to driver Change-Id: I8a410a23b5e3831fc8e90118b810fc2409a026eb Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.com> Reviewed-on: https://review.coreboot.org/28381 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Furquan Shaikh <furquan(a)google.com> Reviewed-by: Enrico Granata <egranata(a)chromium.org> --- M src/mainboard/google/poppy/variants/nautilus/devicetree.cb 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Enrico Granata: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb index 37edd8a..109d2b6 100644 --- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb @@ -334,6 +334,13 @@ register "desc" = ""SAR Proximity Sensor"" register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_A18_IRQ)" register "device_present_gpio" = "GPP_B20" + register "property_count" = "2" + register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" + register "property_list[0].name" = ""STH9321,reg_prox_ctrl6"" + register "property_list[0].integer" = "75" + register "property_list[1].type" = "ACPI_DP_TYPE_INTEGER" + register "property_list[1].name" = ""STH9321,reg_prox_ctrl7"" + register "property_list[1].integer" = "99" device i2c 28 on end end end # I2C #2 -- To view, visit https://review.coreboot.org/28381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8a410a23b5e3831fc8e90118b810fc2409a026eb Gerrit-Change-Number: 28381 Gerrit-PatchSet: 3 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Enrico Granata <egranata(a)chromium.org> Gerrit-Reviewer: Enrico Granata <egranata(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [WIP] Nvidia Optimus support for ThinkPads
by Evgeny Zinoviev (Code Review) 30 Aug '18

30 Aug '18

Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/28380 ) Change subject: [WIP] Nvidia Optimus support for ThinkPads ...................................................................... Patch Set 7: (1 comment) This change is ready for review. https://review.coreboot.org/#/c/28380/7//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/28380/7//COMMIT_MSG@29 PS7, Line 29: - nouveau driver unloading (`rmmod` or `modprobe -r`) does not work well: it > Can you test if it does work without the optimus patch? I could imagine it's related to missing ACPI […] Actually I discovered that it crashes with Lenovo BIOS too! Here is a dump: [ 42.530328] BUG: unable to handle kernel paging request at ffffc90004507970 [ 42.530389] IP: nouveau_backlight_exit+0x24/0x60 [nouveau] [ 42.530392] PGD 62588b067 P4D 62588b067 PUD 62588c067 PMD 621d82067 PTE 0 [ 42.530399] Oops: 0000 [#1] SMP PTI [ 42.530402] Modules linked in: xt_CHECKSUM iptable_mangle ipt_MASQUERADE iptable_nat acpi_call(O) xt_conntrack xt_NFLOG xt_policy xt_LOG xt_connlimit nf_conncount xt_limit cifs rndis_host cdc_subset ipheth cdc_acm cdc_ether usbnet mii i2c_dev vboxpci(O) vboxnetadp(O) btusb btrtl btbcm btintel vboxnetflt(O) vboxdrv(O) nouveau(-) iwldvm x86_pkg_temp_thermal iwlwifi coretemp ttm efivarfs fuse [ 42.530439] CPU: 5 PID: 8030 Comm: rmmod Tainted: G O 4.16.13-gentoo #10 [ 42.530441] Hardware name: LENOVO 2463A49/2463A49, BIOS G5ET92WW (2.52 ) 02/27/2013 [ 42.530474] RIP: 0010:nouveau_backlight_exit+0x24/0x60 [nouveau] [ 42.530477] RSP: 0018:ffffc900037afd80 EFLAGS: 00010212 [ 42.530480] RAX: 0000000000000000 RBX: ffffc90004507960 RCX: 0000000000000004 [ 42.530482] RDX: ffffffff00000001 RSI: ffff88061e449210 RDI: ffff88061eee0000 [ 42.530485] RBP: ffff88061e4491b8 R08: 0000000000000000 R09: ffffffffa01e34b0 [ 42.530487] R10: 0000000000000000 R11: 0000000000000040 R12: ffffffffa02dc730 [ 42.530489] R13: ffff88061e448000 R14: ffff880621db8100 R15: 0000000000000000 [ 42.530492] FS: 00007f62cb235740(0000) GS:ffff88063e340000(0000) knlGS:0000000000000000 [ 42.530494] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 42.530496] CR2: ffffc90004507970 CR3: 000000060448e002 CR4: 00000000001606e0 [ 42.530498] Call Trace: [ 42.530532] nouveau_display_destroy+0x24/0x70 [nouveau] [ 42.530563] nouveau_drm_unload+0x60/0xe0 [nouveau] [ 42.530571] drm_dev_unregister+0x37/0xe0 [ 42.530576] drm_put_dev+0x29/0x60 [ 42.530605] nouveau_drm_device_remove+0x42/0x70 [nouveau] [ 42.530611] pci_device_remove+0x31/0xa0 [ 42.530618] device_release_driver_internal+0x14f/0x220 [ 42.530622] driver_detach+0x2d/0x60 [ 42.530626] bus_remove_driver+0x43/0xa0 [ 42.530629] pci_unregister_driver+0x2f/0x90 [ 42.530661] nouveau_drm_exit+0x15/0xf58 [nouveau] [ 42.530666] SyS_delete_module+0x193/0x250 [ 42.530671] ? task_work_run+0x2e/0x90 [ 42.530675] do_syscall_64+0x55/0x100 [ 42.530682] entry_SYSCALL_64_after_hwframe+0x3d/0xa2 [ 42.530699] RIP: 0033:0x7f62cab9b5e7 [ 42.530701] RSP: 002b:00007ffe72e19058 EFLAGS: 00000202 ORIG_RAX: 00000000000000b0 [ 42.530704] RAX: ffffffffffffffda RBX: 00007ffe72e190a8 RCX: 00007f62cab9b5e7 [ 42.530706] RDX: 000000000000000a RSI: 0000000000000800 RDI: 00005615fc7e3808 [ 42.530708] RBP: 00005615fc7e37a0 R08: 00007ffe72e17fd1 R09: 000000000000000a [ 42.530710] R10: 00000000000008b1 R11: 0000000000000202 R12: 00007ffe72e19270 [ 42.530712] R13: 00007ffe72e19808 R14: 0000000000000000 R15: 00005615fc7e37a0 [ 42.530714] Code: 1f 84 00 00 00 00 00 41 55 41 54 49 c7 c4 30 c7 2d a0 55 53 4c 8b 6f 28 49 8b 9d b8 11 00 00 49 8d ad b8 11 00 00 48 39 eb 74 17 <8b> 73 10 85 f6 78 08 4c 89 e7 e8 9d 5d 9d e1 48 8b 1b 48 39 eb [ 42.530797] RIP: nouveau_backlight_exit+0x24/0x60 [nouveau] RSP: ffffc900037afd80 [ 42.530798] CR2: ffffc90004507970 [ 42.530802] ---[ end trace 2dc5a712a9603d67 ]--- And this is with coreboot: [ 66.973310] BUG: unable to handle kernel paging request at ffffc900085e7970 [ 66.973362] IP: nouveau_backlight_exit+0x24/0x60 [nouveau] [ 66.973365] PGD 66488b067 P4D 66488b067 PUD 66488c067 PMD 6613b9067 PTE 0 [ 66.973377] Oops: 0000 [#1] SMP PTI [ 66.973381] Modules linked in: xt_CHECKSUM iptable_mangle ipt_MASQUERADE iptable_nat acpi_call(O) xt_conntrack xt_NFLOG xt_policy xt_LOG xt_connlimit nf_conncount xt_limit cifs rndis_host cdc_subset ipheth cdc_acm cdc_ether usbnet mii i2c_dev iwldvm vboxpci(O) vboxnetadp(O) vboxnetflt(O) btusb btrtl btbcm btintel vboxdrv(O) nouveau(-) x86_pkg_temp_thermal coretemp iwlwifi ttm fuse [ 66.973433] CPU: 1 PID: 7972 Comm: rmmod Tainted: G O 4.16.13-gentoo #10 [ 66.973436] Hardware name: LENOVO 2463A49/2463A49, BIOS CBET4000 4.8-1380-g6a78a29f44 08/30/2018 [ 66.973483] RIP: 0010:nouveau_backlight_exit+0x24/0x60 [nouveau] [ 66.973488] RSP: 0018:ffffc90003937d80 EFLAGS: 00010212 [ 66.973493] RAX: 0000000000000000 RBX: ffffc900085e7960 RCX: 0000000000000004 [ 66.973497] RDX: ffffffff00000001 RSI: ffff88065c379210 RDI: ffff88065c369000 [ 66.973501] RBP: ffff88065c3791b8 R08: 0000000000000000 R09: ffffffffa01954b0 [ 66.973505] R10: 0000000000000000 R11: 0000000000000040 R12: ffffffffa028e730 [ 66.973509] R13: ffff88065c378000 R14: ffff8806608aa900 R15: 0000000000000000 [ 66.973515] FS: 00007fe57e96c740(0000) GS:ffff88067d240000(0000) knlGS:0000000000000000 [ 66.973519] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 66.973523] CR2: ffffc900085e7970 CR3: 000000065f2fe005 CR4: 00000000001606e0 [ 66.973527] Call Trace: [ 66.973576] nouveau_display_destroy+0x24/0x70 [nouveau] [ 66.973625] nouveau_drm_unload+0x60/0xe0 [nouveau] [ 66.973638] drm_dev_unregister+0x37/0xe0 [ 66.973646] drm_put_dev+0x29/0x60 [ 66.973689] nouveau_drm_device_remove+0x42/0x70 [nouveau] [ 66.973698] pci_device_remove+0x31/0xa0 [ 66.973708] device_release_driver_internal+0x14f/0x220 [ 66.973715] driver_detach+0x2d/0x60 [ 66.973721] bus_remove_driver+0x43/0xa0 [ 66.973727] pci_unregister_driver+0x2f/0x90 [ 66.973766] nouveau_drm_exit+0x15/0xf58 [nouveau] [ 66.973772] SyS_delete_module+0x193/0x250 [ 66.973778] ? task_work_run+0x2e/0x90 [ 66.973782] do_syscall_64+0x55/0x100 [ 66.973790] entry_SYSCALL_64_after_hwframe+0x3d/0xa2 [ 66.973793] RIP: 0033:0x7fe57e2d25e7 [ 66.973796] RSP: 002b:00007ffd9df9bb98 EFLAGS: 00000202 ORIG_RAX: 00000000000000b0 [ 66.973799] RAX: ffffffffffffffda RBX: 00007ffd9df9bbe8 RCX: 00007fe57e2d25e7 [ 66.973802] RDX: 000000000000000a RSI: 0000000000000800 RDI: 0000561bbded3808 [ 66.973804] RBP: 0000561bbded37a0 R08: 00007ffd9df9ab11 R09: 000000000000000a [ 66.973806] R10: 00000000000008b1 R11: 0000000000000202 R12: 00007ffd9df9bdb0 [ 66.973808] R13: 00007ffd9df9d808 R14: 0000000000000000 R15: 0000561bbded37a0 [ 66.973811] Code: 1f 84 00 00 00 00 00 41 55 41 54 49 c7 c4 30 e7 28 a0 55 53 4c 8b 6f 28 49 8b 9d b8 11 00 00 49 8d ad b8 11 00 00 48 39 eb 74 17 <8b> 73 10 85 f6 78 08 4c 89 e7 e8 9d 3d a2 e1 48 8b 1b 48 39 eb [ 66.973889] RIP: nouveau_backlight_exit+0x24/0x60 [nouveau] RSP: ffffc90003937d80 [ 66.973891] CR2: ffffc900085e7970 [ 66.973894] ---[ end trace 91d8759a29e86bc6 ]--- -- To view, visit https://review.coreboot.org/28380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I277808d6c1d8bd6e0a267a53f25471597698f8d5 Gerrit-Change-Number: 28380 Gerrit-PatchSet: 7 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Aug 2018 18:17:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/Kconfig: Fix missing device node /dev/tpm0 for H1
by Furquan Shaikh (Code Review) 30 Aug '18

30 Aug '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/28400 ) Change subject: mb/google/poppy/Kconfig: Fix missing device node /dev/tpm0 for H1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28400 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35287c6c54299c2677c41fc830675570b9d45a94 Gerrit-Change-Number: 28400 Gerrit-PatchSet: 1 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Aug 2018 16:49:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/lenovo: Dual Graphics for xx20/xx30 ThinkPads
by Evgeny Zinoviev (Code Review) 30 Aug '18

30 Aug '18

Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/28393 ) Change subject: mb/lenovo: Dual Graphics for xx20/xx30 ThinkPads ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/28393/1/src/mainboard/lenovo/t430s/romstage… File src/mainboard/lenovo/t430s/romstage.c: https://review.coreboot.org/#/c/28393/1/src/mainboard/lenovo/t430s/romstage… PS1, Line 76: ode == H > That will not power the dGPU if mode == dual graphics. […] Done -- To view, visit https://review.coreboot.org/28393 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8842fef0fa1235eb91abf6b7e655ed4d8598adc7 Gerrit-Change-Number: 28393 Gerrit-PatchSet: 2 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Aug 2018 16:32:34 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/lenovo: Dual Graphics for xx20/xx30 ThinkPads
by Evgeny Zinoviev (Code Review) 30 Aug '18

30 Aug '18

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28393 to look at the new patch set (#2). Change subject: mb/lenovo: Dual Graphics for xx20/xx30 ThinkPads ...................................................................... mb/lenovo: Dual Graphics for xx20/xx30 ThinkPads Add CMOS option that allows to use both integrated and discrete GPU. Change-Id: I8842fef0fa1235eb91abf6b7e655ed4d8598adc7 Signed-off-by: Evgeny Zinoviev <me(a)ch1p.com> --- M src/mainboard/lenovo/t420/cmos.layout M src/mainboard/lenovo/t420/romstage.c M src/mainboard/lenovo/t420s/cmos.layout M src/mainboard/lenovo/t420s/romstage.c M src/mainboard/lenovo/t430/cmos.layout M src/mainboard/lenovo/t430/romstage.c M src/mainboard/lenovo/t430s/cmos.default M src/mainboard/lenovo/t430s/cmos.layout M src/mainboard/lenovo/t430s/romstage.c M src/mainboard/lenovo/t520/romstage.c M src/mainboard/lenovo/t530/cmos.layout M src/mainboard/lenovo/t530/romstage.c 12 files changed, 52 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/28393/2 -- To view, visit https://review.coreboot.org/28393 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8842fef0fa1235eb91abf6b7e655ed4d8598adc7 Gerrit-Change-Number: 28393 Gerrit-PatchSet: 2 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/cannonlake: Correct number of root ports for CNL PCH H
by Subrata Banik (Code Review) 30 Aug '18

30 Aug '18

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/28399 ) Change subject: soc/intel/cannonlake: Correct number of root ports for CNL PCH H ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/28399/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/28399/1//COMMIT_MSG@9 PS1, Line 9: EDS#571182, this document is not available for community hence better not to provide some junk link for everyone. -- To view, visit https://review.coreboot.org/28399 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cc3ae282d4eb5da8b0618451e062a6c061f1d6f Gerrit-Change-Number: 28399 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kin Wai Ng <kin.wai.ng(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Aug 2018 15:46:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Fix comment errors for SMBUS
by Martin Roth (Code Review) 30 Aug '18

30 Aug '18

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/28366 ) Change subject: soc/intel/cannonlake: Fix comment errors for SMBUS ...................................................................... soc/intel/cannonlake: Fix comment errors for SMBUS On CannonLake PCH, SMBUS stays at Bus 0 Device 31 and Function 4, previous comment in southbridge.asl mention it as Function 3 that was a mistake. BUG=N/A TEST=N/A Change-Id: I29786457379809b6fcb592e1136ff612539e24dc Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> Reviewed-on: https://review.coreboot.org/28366 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/cannonlake/acpi/southbridge.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved diff --git a/src/soc/intel/cannonlake/acpi/southbridge.asl b/src/soc/intel/cannonlake/acpi/southbridge.asl index 4a62485..e4f29b6 100644 --- a/src/soc/intel/cannonlake/acpi/southbridge.asl +++ b/src/soc/intel/cannonlake/acpi/southbridge.asl @@ -37,7 +37,7 @@ /* Serial IO */ #include "serialio.asl" -/* SMBus 0:1f.3 */ +/* SMBus 0:1f.4 */ #include "smbus.asl" /* USB XHCI 0:14.0 */ -- To view, visit https://review.coreboot.org/28366 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I29786457379809b6fcb592e1136ff612539e24dc Gerrit-Change-Number: 28366 Gerrit-PatchSet: 2 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: Documentation/nb/intel/sandybridge/nri_registers.md: Fix mistake
by Martin Roth (Code Review) 30 Aug '18

30 Aug '18

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/28377 ) Change subject: Documentation/nb/intel/sandybridge/nri_registers.md: Fix mistake ...................................................................... Documentation/nb/intel/sandybridge/nri_registers.md: Fix mistake According to a comment on fa1a07b, the 100MHz clock is the Ivy Bridge only clock, not the 133MHz one. Change-Id: I28fed4a9264b96f93b9e88325f547a5db512514c Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/28377 Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M Documentation/northbridge/intel/sandybridge/nri_registers.md 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved diff --git a/Documentation/northbridge/intel/sandybridge/nri_registers.md b/Documentation/northbridge/intel/sandybridge/nri_registers.md index d5857ec..aa16644 100644 --- a/Documentation/northbridge/intel/sandybridge/nri_registers.md +++ b/Documentation/northbridge/intel/sandybridge/nri_registers.md @@ -2137,8 +2137,8 @@ +===========+==================================================================+ | 0:7| Selected multiplier: 100Mhz [7,12], 133Mhz [3,19] | +-----------+------------------------------------------------------------------+ -| 8 | - 1: 100Mhz reference clock | -| | - 0: 133Mhz reference clock (Ivy Bridge only) | +| 8 | - 1: 100Mhz reference clock (Ivy Bridge only) | +| | - 0: 133Mhz reference clock | +-----------+------------------------------------------------------------------+ | 31 | PLL busy | +-----------+------------------------------------------------------------------+ -- To view, visit https://review.coreboot.org/28377 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I28fed4a9264b96f93b9e88325f547a5db512514c Gerrit-Change-Number: 28377 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

← Newer
1
2
3
4
5
6
7
8
...
112
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2018