coreboot-gerrit August 2018

coreboot-gerrit@coreboot.org

1 participants
1120 discussions

Change in coreboot[master]: mb/lenovo: dGPU power handling on T430, T530
by Patrick Rudolph (Code Review) 30 Aug '18

30 Aug '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28392 ) Change subject: mb/lenovo: dGPU power handling on T430, T530 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/28392 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieab1a33b3c680c757cc0999660b5cb7e122474cc Gerrit-Change-Number: 28392 Gerrit-PatchSet: 3 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Aug 2018 06:02:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/lenovo: Dual Graphics for xx20/xx30 ThinkPads
by Patrick Rudolph (Code Review) 30 Aug '18

30 Aug '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28393 ) Change subject: mb/lenovo: Dual Graphics for xx20/xx30 ThinkPads ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/28393/1/src/mainboard/lenovo/t430s/romstage… File src/mainboard/lenovo/t430s/romstage.c: https://review.coreboot.org/#/c/28393/1/src/mainboard/lenovo/t430s/romstage… PS1, Line 76: power_en That will not power the dGPU if mode == dual graphics. PMH7 registers aren't cleared on reboot, only on battery and ext power failure. The hybrid graphics driver does it right. Also not hiding PEG10 will draw +1Watt even with disabled dGPU. -- To view, visit https://review.coreboot.org/28393 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8842fef0fa1235eb91abf6b7e655ed4d8598adc7 Gerrit-Change-Number: 28393 Gerrit-PatchSet: 1 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Aug 2018 05:58:43 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: riscv: Fix the definition of DEFINE_MPRV_READ
by Xiang Wang (Code Review) 30 Aug '18

30 Aug '18

Xiang Wang has uploaded this change for review. ( https://review.coreboot.org/28394 Change subject: riscv: Fix the definition of DEFINE_MPRV_READ ...................................................................... riscv: Fix the definition of DEFINE_MPRV_READ Must to set MXR, when needs to read the page which is execution-only. So make this change. Change-Id: I19519782fe791982a8fbd48ef33b5a92a3c48bfc Signed-off-by: Xiang Wang <wxjstz(a)126.com> --- M src/arch/riscv/include/vm.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/28394/1 diff --git a/src/arch/riscv/include/vm.h b/src/arch/riscv/include/vm.h index a30d6bb..60a8fb7 100644 --- a/src/arch/riscv/include/vm.h +++ b/src/arch/riscv/include/vm.h @@ -42,7 +42,7 @@ static inline type name(type *p); \ static inline type name(type *p) \ { \ - size_t mprv = MSTATUS_MPRV; \ + size_t mprv = MSTATUS_MPRV | MSTATUS_MXR; \ type value; \ asm ( \ "csrs mstatus, %1\n" \ -- To view, visit https://review.coreboot.org/28394 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I19519782fe791982a8fbd48ef33b5a92a3c48bfc Gerrit-Change-Number: 28394 Gerrit-PatchSet: 1 Gerrit-Owner: Xiang Wang <wxjstz(a)126.com>

1 0

Change in coreboot[master]: riscv: add support for supervisor binary interface (SBI)
by build bot (Jenkins) (Code Review) 30 Aug '18

30 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28096 ) Change subject: riscv: add support for supervisor binary interface (SBI) ...................................................................... Patch Set 9: (1 comment) https://review.coreboot.org/#/c/28096/9/src/arch/riscv/sbi.c File src/arch/riscv/sbi.c: https://review.coreboot.org/#/c/28096/9/src/arch/riscv/sbi.c@66 PS9, Line 66: if (IS_ENABLED(CONFIG_CONSOLE_SERIAL)) { braces {} are not necessary for any arm of this statement -- To view, visit https://review.coreboot.org/28096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6c1f21d2f085f02208305dc4e3a0f970d400c27 Gerrit-Change-Number: 28096 Gerrit-PatchSet: 9 Gerrit-Owner: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich (1001188) Gerrit-Comment-Date: Thu, 30 Aug 2018 05:40:44 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: riscv: add support for supervisor binary interface (SBI)
by build bot (Jenkins) (Code Review) 30 Aug '18

30 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28096 ) Change subject: riscv: add support for supervisor binary interface (SBI) ...................................................................... Patch Set 8: (2 comments) https://review.coreboot.org/#/c/28096/8/src/arch/riscv/sbi.c File src/arch/riscv/sbi.c: https://review.coreboot.org/#/c/28096/8/src/arch/riscv/sbi.c@30 PS8, Line 30: die("Please implement the %s function on your platform.",__func__); space required after that ',' (ctx:VxV) https://review.coreboot.org/#/c/28096/8/src/arch/riscv/sbi.c@67 PS8, Line 67: if (IS_ENABLED(CONFIG_CONSOLE_SERIAL)) { braces {} are not necessary for any arm of this statement -- To view, visit https://review.coreboot.org/28096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6c1f21d2f085f02208305dc4e3a0f970d400c27 Gerrit-Change-Number: 28096 Gerrit-PatchSet: 8 Gerrit-Owner: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich (1001188) Gerrit-Comment-Date: Thu, 30 Aug 2018 05:38:45 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: riscv: add support for supervisor binary interface (SBI)
by build bot (Jenkins) (Code Review) 30 Aug '18

30 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28096 ) Change subject: riscv: add support for supervisor binary interface (SBI) ...................................................................... Patch Set 7: (1 comment) https://review.coreboot.org/#/c/28096/7/src/arch/riscv/sbi.c File src/arch/riscv/sbi.c: https://review.coreboot.org/#/c/28096/7/src/arch/riscv/sbi.c@30 PS7, Line 30: die("Please implement the \"set_msip\" function on your platform."); Prefer using '"%s...", __func__' to using 'set_msip', this function's name, in a string -- To view, visit https://review.coreboot.org/28096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6c1f21d2f085f02208305dc4e3a0f970d400c27 Gerrit-Change-Number: 28096 Gerrit-PatchSet: 7 Gerrit-Owner: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich (1001188) Gerrit-Comment-Date: Thu, 30 Aug 2018 05:32:17 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: riscv: add support for supervisor binary interface (SBI)
by build bot (Jenkins) (Code Review) 30 Aug '18

30 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28096 ) Change subject: riscv: add support for supervisor binary interface (SBI) ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/#/c/28096/6/src/arch/riscv/sbi.c File src/arch/riscv/sbi.c: https://review.coreboot.org/#/c/28096/6/src/arch/riscv/sbi.c@30 PS6, Line 30: die("Please implement the \"set_msip\" function on your platform."); Prefer using '"%s...", __func__' to using 'set_msip', this function's name, in a string -- To view, visit https://review.coreboot.org/28096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6c1f21d2f085f02208305dc4e3a0f970d400c27 Gerrit-Change-Number: 28096 Gerrit-PatchSet: 6 Gerrit-Owner: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich (1001188) Gerrit-Comment-Date: Thu, 30 Aug 2018 05:19:56 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: riscv: add support for supervisor binary interface (SBI)
by build bot (Jenkins) (Code Review) 30 Aug '18

30 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28096 ) Change subject: riscv: add support for supervisor binary interface (SBI) ...................................................................... Patch Set 5: (4 comments) https://review.coreboot.org/#/c/28096/5/src/arch/riscv/sbi.c File src/arch/riscv/sbi.c: https://review.coreboot.org/#/c/28096/5/src/arch/riscv/sbi.c@29 PS5, Line 29: die("Please implement the \"set_msip\" function on your platform."); Prefer using '"%s...", __func__' to using 'set_msip', this function's name, in a string https://review.coreboot.org/#/c/28096/5/src/arch/riscv/sbi.c@83 PS5, Line 83: tf->gpr[10] = sbi_set_timer(tf->gpr[10] + ((uint64_t)tf->gpr[11] << 32)); line over 80 characters https://review.coreboot.org/#/c/28096/5/src/arch/riscv/sbi.c@104 PS5, Line 104: tf->gpr[10] = send_ipi((uintptr_t *)tf->gpr[10], IPI_SFENCE_VMA); line over 80 characters https://review.coreboot.org/#/c/28096/5/src/arch/riscv/sbi.c@107 PS5, Line 107: tf->gpr[10] = send_ipi((uintptr_t *)tf->gpr[10], IPI_SFENCE_VMA_ASID); line over 80 characters -- To view, visit https://review.coreboot.org/28096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6c1f21d2f085f02208305dc4e3a0f970d400c27 Gerrit-Change-Number: 28096 Gerrit-PatchSet: 5 Gerrit-Owner: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich (1001188) Gerrit-Comment-Date: Thu, 30 Aug 2018 05:05:16 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [WIP] Nvidia Optimus support for ThinkPads
by Evgeny Zinoviev (Code Review) 30 Aug '18

30 Aug '18

Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/28380 ) Change subject: [WIP] Nvidia Optimus support for ThinkPads ...................................................................... Patch Set 7: (1 comment) https://review.coreboot.org/#/c/28380/2/src/mainboard/lenovo/t430/cmos.layo… File src/mainboard/lenovo/t430/cmos.layout: https://review.coreboot.org/#/c/28380/2/src/mainboard/lenovo/t430/cmos.layo… PS2, Line 131: le > Do you think I should move has_thinker1 changes in devicetrees to a separate commit too? […] nevermind, already done -- To view, visit https://review.coreboot.org/28380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I277808d6c1d8bd6e0a267a53f25471597698f8d5 Gerrit-Change-Number: 28380 Gerrit-PatchSet: 7 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Aug 2018 00:15:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/lenovo: dGPU power handling on T430, T530
by Evgeny Zinoviev (Code Review) 30 Aug '18

30 Aug '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28392 to look at the new patch set (#3). Change subject: mb/lenovo: dGPU power handling on T430, T530 ...................................................................... mb/lenovo: dGPU power handling on T430, T530 Enable dGPU power handling on Lenovo ThinkPad T430, T530 via PMH7 register 0x50. Although there's no Thinker-1 chip on these models according to schematics, dGPU power control via PMH7 works the same as on T420/T520, so they can be considered Thinker-1-compatible. It can be tested from linux userspace using util/pmh7tool. To turn dGPU power off: pmh7tool -c 0x50 7 pmh7tool -c 0x50 3 To turn it on: pmh7tool -s 0x50 3 pmh7tool -s 0x50 7 To check whether it is on (bash): reg=0x$(pmh7tool -r 0x50) echo "$(( (( reg & 0x08 )) >> 3 ))" or just `pmh7tool -b 0x50 3` with https://review.coreboot.org/#/c/coreboot/+/28388/ Tested on ThinkPad W530. Change-Id: Ieab1a33b3c680c757cc0999660b5cb7e122474cc Signed-off-by: Evgeny Zinoviev <me(a)ch1p.com> --- M src/mainboard/lenovo/t430/devicetree.cb M src/mainboard/lenovo/t530/variants/t530/devicetree.cb M src/mainboard/lenovo/t530/variants/w530/devicetree.cb 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/28392/3 -- To view, visit https://review.coreboot.org/28392 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ieab1a33b3c680c757cc0999660b5cb7e122474cc Gerrit-Change-Number: 28392 Gerrit-PatchSet: 3 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
112
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2018