Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/28388
to look at the new patch set (#2).
Change subject: util/pmh7tool: Add option to read specific bit
......................................................................
util/pmh7tool: Add option to read specific bit
Change-Id: I045383eedbcf438270e9c64329a8d910bb941ab8
Signed-off-by: Evgeny Zinoviev <me(a)ch1p.com>
---
M util/pmh7tool/pmh7tool.c
1 file changed, 27 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/28388/2
--
To view, visit https://review.coreboot.org/28388
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I045383eedbcf438270e9c64329a8d910bb941ab8
Gerrit-Change-Number: 28388
Gerrit-PatchSet: 2
Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Felix Held has posted comments on this change. ( https://review.coreboot.org/28388 )
Change subject: util/pmh7tool: Add option to read specific bit
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/28388/1/util/pmh7tool/pmh7tool.c
File util/pmh7tool/pmh7tool.c:
https://review.coreboot.org/#/c/28388/1/util/pmh7tool/pmh7tool.c@170
PS1, Line 170: if (act == SET || act == CLEAR) {
add "|| act == READBIT"
--
To view, visit https://review.coreboot.org/28388
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I045383eedbcf438270e9c64329a8d910bb941ab8
Gerrit-Change-Number: 28388
Gerrit-PatchSet: 1
Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 29 Aug 2018 23:03:32 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Hello Stefan Reinauer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/28386
to look at the new patch set (#2).
Change subject: chromeec: PS2K node can't be under SIO node
......................................................................
chromeec: PS2K node can't be under SIO node
Some operating systems won't find the keyboard if it is under
the SIO node.
BRANCH=none
BUG=none
TEST=Boot Windows, observe that keyboard is working
Original-Signed-off-by: Stefan Reinauer <reinauer(a)google.com>
Original-Change-Id: I76b1ca9bf9243ffa861bed9c356a45377e7f43ef
Original-Reviewed-on: https://chromium-review.googlesource.com/895364
Change-Id: If99e15bef2173c44cecaa8fdeaa69381bd0e499a
Signed-off-by: Martin Roth <martinroth(a)chromium.org>
---
M src/ec/google/chromeec/acpi/superio.asl
1 file changed, 28 insertions(+), 28 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/28386/2
--
To view, visit https://review.coreboot.org/28386
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If99e15bef2173c44cecaa8fdeaa69381bd0e499a
Gerrit-Change-Number: 28386
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <reinauer(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/28374 )
Change subject: mainboard/google/kahlee: Enable EC firmware update screen
......................................................................
mainboard/google/kahlee: Enable EC firmware update screen
Grunt takes a few seconds to update the EC, so display a notification
screen while that's happening.
BUG=b:113286040
TEST=Boot Grunt with old EC firmware, see update screen
Change-Id: I95fc4d3430bac66c09f57a4d34abde08752e5f0e
Signed-off-by: Martin Roth <martinroth(a)google.com>
Reviewed-on: https://review.coreboot.org/28374
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Raul Rangel <rrangel(a)chromium.org>
Reviewed-by: Julius Werner <jwerner(a)chromium.org>
---
M src/mainboard/google/kahlee/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Julius Werner: Looks good to me, approved
Raul Rangel: Looks good to me, approved
diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig
index fbd1fb0..bde91a1 100644
--- a/src/mainboard/google/kahlee/Kconfig
+++ b/src/mainboard/google/kahlee/Kconfig
@@ -98,6 +98,7 @@
config VBOOT
select EC_GOOGLE_CHROMEEC_SWITCHES
select VBOOT_LID_SWITCH
+ select VBOOT_EC_SLOW_UPDATE if VBOOT_EC_SOFTWARE_SYNC
config VBOOT_VBNV_OFFSET
hex
--
To view, visit https://review.coreboot.org/28374
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I95fc4d3430bac66c09f57a4d34abde08752e5f0e
Gerrit-Change-Number: 28374
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Angel Pons has posted comments on this change. ( https://review.coreboot.org/28387 )
Change subject: src/drivers/spi/tpm: Fix typo
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/28387/1/src/drivers/spi/tpm/tpm.c
File src/drivers/spi/tpm/tpm.c:
https://review.coreboot.org/#/c/28387/1/src/drivers/spi/tpm/tpm.c@450
PS1, Line 450: Tpm
Should be "TPM" in uppercase, I don't know if there's any other.
--
To view, visit https://review.coreboot.org/28387
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb1e024821153865dd4a27a100f8a9c61151e0e1
Gerrit-Change-Number: 28387
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Wed, 29 Aug 2018 17:06:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No