March 2018 - coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: soc/intel/skylake/graphics: Ensure intel_gma_restore_opregion() is ca...

by Nico Huber (Code Review)

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/25466 Change subject: soc/intel/skylake/graphics: Ensure intel_gma_restore_opregion() is called ...................................................................... soc/intel/skylake/graphics: Ensure intel_gma_restore_opregion() is called Change-Id: If981fa3db12b3a4fe1411f4cce9bac8564697769 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/soc/intel/skylake/graphics.c 1 file changed, 8 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/25466/1 diff --git a/src/soc/intel/skylake/graphics.c b/src/soc/intel/skylake/graphics.c index 8991fa3..693c6c9 100644 --- a/src/soc/intel/skylake/graphics.c +++ b/src/soc/intel/skylake/graphics.c @@ -45,6 +45,11 @@ graphics_gtt_write(DDI_BUF_CTL_A, ddi_buf_ctl); } + /* IGD needs to Bus Master */ + u32 reg32 = pci_read_config32(dev, PCI_COMMAND); + reg32 |= PCI_COMMAND_MASTER | PCI_COMMAND_MEMORY | PCI_COMMAND_IO; + pci_write_config32(dev, PCI_COMMAND, reg32); + /* * GFX PEIM module inside FSP binary is taking care of graphics * initialization based on RUN_FSP_GOP Kconfig option and input @@ -53,15 +58,9 @@ * In case of non-FSP solution, SoC need to select another * Kconfig to perform GFX initialization. */ - if (IS_ENABLED(CONFIG_RUN_FSP_GOP)) - return; - - /* IGD needs to Bus Master */ - u32 reg32 = pci_read_config32(dev, PCI_COMMAND); - reg32 |= PCI_COMMAND_MASTER | PCI_COMMAND_MEMORY | PCI_COMMAND_IO; - pci_write_config32(dev, PCI_COMMAND, reg32); - - if (IS_ENABLED(CONFIG_MAINBOARD_USE_LIBGFXINIT)) { + if (IS_ENABLED(CONFIG_RUN_FSP_GOP)) { + /* nothing to do */ + } else if (IS_ENABLED(CONFIG_MAINBOARD_USE_LIBGFXINIT)) { if (!acpi_is_wakeup_s3() && display_init_required()) { int lightup_ok; gma_gfxinit(&lightup_ok); -- To view, visit https://review.coreboot.org/25466 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If981fa3db12b3a4fe1411f4cce9bac8564697769 Gerrit-Change-Number: 25466 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

2 years, 5 months

1
0
0 0

Change in coreboot[master]: drivers/intel/gma: Amend stride calculation of linear fb

by build bot (Jenkins) (Code Review)

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25451 ) Change subject: drivers/intel/gma: Amend stride calculation of linear fb ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/69335/ : FAILURE -- To view, visit https://review.coreboot.org/25451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f824ffd7d12835935e4e4bde29fe82dc3e16f9d Gerrit-Change-Number: 25451 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 31 Mar 2018 15:35:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

2 years, 5 months

1
0
0 0

Change in coreboot[master]: soc/intel/skylake: Hook up libgfxinit

by build bot (Jenkins) (Code Review)

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20113 ) Change subject: soc/intel/skylake: Hook up libgfxinit ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69334/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/23673/ : SUCCESS -- To view, visit https://review.coreboot.org/20113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79fbfed7732cf02d054530ea7ec0d34de32836ba Gerrit-Change-Number: 20113 Gerrit-PatchSet: 9 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 31 Mar 2018 15:30:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

2 years, 5 months

1
0
0 0

Change in coreboot[master]: cpu/x86/mtrr: Use single code path with/without holes

by build bot (Jenkins) (Code Review)

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21916 ) Change subject: cpu/x86/mtrr: Use single code path with/without holes ...................................................................... Patch Set 10: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/69333/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/23672/ : SUCCESS -- To view, visit https://review.coreboot.org/21916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iedf7dfad61d6baac91973062e2688ad866f05afd Gerrit-Change-Number: 21916 Gerrit-PatchSet: 10 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 31 Mar 2018 15:13:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

2 years, 5 months

1
0
0 0

Change in coreboot[master]: cpu/x86/mtrr: Optimize optimize_var_mtrr_hole()

by build bot (Jenkins) (Code Review)

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22119 ) Change subject: cpu/x86/mtrr: Optimize optimize_var_mtrr_hole() ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69332/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/23671/ : SUCCESS -- To view, visit https://review.coreboot.org/22119 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcdc0f3a4cc9be8592454bf977feb99deb0f529e Gerrit-Change-Number: 22119 Gerrit-PatchSet: 6 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 31 Mar 2018 15:13:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

2 years, 5 months

1
0
0 0

Change in coreboot[master]: cpu/x86/mtrr: Optimize hole carving strategy

by build bot (Jenkins) (Code Review)

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21915 ) Change subject: cpu/x86/mtrr: Optimize hole carving strategy ...................................................................... Patch Set 9: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/69331/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/23670/ : SUCCESS -- To view, visit https://review.coreboot.org/21915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefb064ce8c4f293490a19dd46054b966c63bde44 Gerrit-Change-Number: 21915 Gerrit-PatchSet: 9 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 31 Mar 2018 15:08:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

2 years, 5 months

1
0
0 0

Change in coreboot[master]: sb/intel/bd82x6x: Let mainboard override SPI opmenu

by build bot (Jenkins) (Code Review)

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23587 ) Change subject: sb/intel/bd82x6x: Let mainboard override SPI opmenu ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/69330/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/23669/ : SUCCESS -- To view, visit https://review.coreboot.org/23587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ceaf5b2d11365e21a2bebc9c5def1fcf0be8aad Gerrit-Change-Number: 23587 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 31 Mar 2018 15:01:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

2 years, 5 months

1
0
0 0

Change in coreboot[master]: inteltool: Add dumping of full PCR ports

by build bot (Jenkins) (Code Review)

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19593 ) Change subject: inteltool: Add dumping of full PCR ports ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69329/ : SUCCESS -- To view, visit https://review.coreboot.org/19593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iede4ac601355e2be377bc986d62d20098980ec35 Gerrit-Change-Number: 19593 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 31 Mar 2018 14:45:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

2 years, 5 months

1
0
0 0

Change in coreboot[master]: vboot: Add support for reading GBB flags

by build bot (Jenkins) (Code Review)

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25459 ) Change subject: vboot: Add support for reading GBB flags ...................................................................... Patch Set 4: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/69328/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/23668/ : SUCCESS -- To view, visit https://review.coreboot.org/25459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35ecb5ba964511379baa4e9f458ba2e8c6b74b4e Gerrit-Change-Number: 25459 Gerrit-PatchSet: 4 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 31 Mar 2018 06:07:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

2 years, 5 months

1
0
0 0

Change in coreboot[master]: vboot: Add support for reading GBB flags

by Furquan Shaikh (Code Review)

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/25459 ) Change subject: vboot: Add support for reading GBB flags ...................................................................... Patch Set 3: > Patch Set 3: Verified-1 > > Build Failed > > https://qa.coreboot.org/job/coreboot-gerrit/69327/ : FAILURE > > https://qa.coreboot.org/job/coreboot-checkpatch/23667/ : SUCCESS Failure doesn't seem related to this CL. -- To view, visit https://review.coreboot.org/25459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35ecb5ba964511379baa4e9f458ba2e8c6b74b4e Gerrit-Change-Number: 25459 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 31 Mar 2018 06:02:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

2 years, 5 months

1
0
0 0

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018