coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: vboot: Add support for reading GBB flags
by Duncan Laurie (Code Review) 30 Mar '18

30 Mar '18

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/25459 ) Change subject: vboot: Add support for reading GBB flags ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/25459/1/src/security/vboot/gbb.c File src/security/vboot/gbb.c: https://review.coreboot.org/#/c/25459/1/src/security/vboot/gbb.c@76 PS1, Line 76: gbb_header->flags gbb_get_flags() [so it calls gbb_init first] -- To view, visit https://review.coreboot.org/25459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35ecb5ba964511379baa4e9f458ba2e8c6b74b4e Gerrit-Change-Number: 25459 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 30 Mar 2018 01:39:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: amd/common/block/pi: Make agesa_heap_base() static
by Richard Spiegel (Code Review) 30 Mar '18

30 Mar '18

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/25457 ) Change subject: amd/common/block/pi: Make agesa_heap_base() static ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/25457/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/25457/1//COMMIT_MSG@11 PS1, Line 11: : C > No bug since it's not particularly google-specific. […] Ok, just asking. -- To view, visit https://review.coreboot.org/25457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ee162985ca1ea36461ea413416d98451a700f8c Gerrit-Change-Number: 25457 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 29 Mar 2018 23:34:50 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: vboot: Add support for reading GBB flags
by Furquan Shaikh (Code Review) 30 Mar '18

30 Mar '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/25459 ) Change subject: vboot: Add support for reading GBB flags ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/25459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35ecb5ba964511379baa4e9f458ba2e8c6b74b4e Gerrit-Change-Number: 25459 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 29 Mar 2018 22:39:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: amd/common/block/pi: Make agesa_heap_base() static
by Marshall Dawson (Code Review) 30 Mar '18

30 Mar '18

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/25457 ) Change subject: amd/common/block/pi: Make agesa_heap_base() static ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/25457/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/25457/1//COMMIT_MSG@11 PS1, Line 11: : C > Is there a bug associated to? Maybe this is a small patch for something else that does have a bug nu […] No bug since it's not particularly google-specific. I'm not even crazy about putting in test= as this is change is somewhat self-evident, and just adheres to good source hygiene. Any resulting ROM image is unchanged by this patch. -- To view, visit https://review.coreboot.org/25457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ee162985ca1ea36461ea413416d98451a700f8c Gerrit-Change-Number: 25457 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Comment-Date: Thu, 29 Mar 2018 22:24:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: vboot: Add support for reading GBB flags
by Furquan Shaikh (Code Review) 29 Mar '18

29 Mar '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/25459 Change subject: vboot: Add support for reading GBB flags ...................................................................... vboot: Add support for reading GBB flags This change adds basic support for reading flags from GBB header located in "GBB" section on SPI flash. Change-Id: I35ecb5ba964511379baa4e9f458ba2e8c6b74b4e Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/security/vboot/Makefile.inc A src/security/vboot/gbb.c A src/security/vboot/gbb.h 3 files changed, 117 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/25459/1 diff --git a/src/security/vboot/Makefile.inc b/src/security/vboot/Makefile.inc index 53462d9..6f18a35 100644 --- a/src/security/vboot/Makefile.inc +++ b/src/security/vboot/Makefile.inc @@ -23,6 +23,8 @@ verstage-generic-ccopts += -D__PRE_RAM__ -D__VERSTAGE__ +ramstage-y += gbb.c + bootblock-y += vbnv.c verstage-y += vbnv.c romstage-y += vbnv.c diff --git a/src/security/vboot/gbb.c b/src/security/vboot/gbb.c new file mode 100644 index 0000000..f217c79 --- /dev/null +++ b/src/security/vboot/gbb.c @@ -0,0 +1,77 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2018 Google Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <commonlib/region.h> +#include <console/console.h> +#include <fmap.h> +#include <security/vboot/gbb.h> +#include <string.h> + +#define GBB_FMAP_REGION_NAME "GBB" + +static GoogleBinaryBlockHeader *gbb_header; + +/* + * Read "GBB" region from SPI flash to obtain GBB header and validate + * signature. + * + * Return value: + * Success = 0 + * Error = 1 + */ +static int gbb_init(void) +{ + static bool init_done = false; + static struct region_device gbb_rdev; + size_t gbb_region_sz; + + if (init_done != false) + return 0; + + if (fmap_locate_area_as_rdev(GBB_FMAP_REGION_NAME, &gbb_rdev)) + return 1; + + gbb_header = rdev_mmap_full(&gbb_rdev); + gbb_region_sz = region_device_sz(&gbb_rdev); + + if (gbb_region_sz < sizeof(GoogleBinaryBlockHeader)) { + printk(BIOS_ERR, "%s: GBB header too small!\n", __func__); + return 1; + } + + if (memcmp(gbb_header->signature, GBB_SIGNATURE, GBB_SIGNATURE_SIZE)) { + printk(BIOS_ERR, "%s: Signature check failed!\n", __func__); + return 1; + } + + init_done = true; + return 0; +} + +uint32_t gbb_get_flags(void) +{ + if (gbb_init()) { + printk(BIOS_ERR, + "%s: Failure to initialize GBB. Returning flags as 0!\n", + __func__); + return 0; + } + return gbb_header->flags; +} + +bool gbb_is_flag_set(uint32_t flag) +{ + return !!(gbb_header->flags & flag); +} diff --git a/src/security/vboot/gbb.h b/src/security/vboot/gbb.h new file mode 100644 index 0000000..b7f0634 --- /dev/null +++ b/src/security/vboot/gbb.h @@ -0,0 +1,38 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2018 Google Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef __SECURITY_VBOOT_GBB_H__ +#define __SECURITY_VBOOT_GBB_H__ + +#include <stdint.h> +#include <gbb_header.h> + +/* + * Read flags field from GBB header. + * Return value: + * Success: 32-bit unsigned integer representing flags field from GBB header. + * Error : 0 + */ +uint32_t gbb_get_flags(void); + +/* + * Check if given flag is set in the flags field in GBB header. + * Return value: + * true: Flag is set. + * false: Flag is not set or failure to read GBB flags. + */ +bool gbb_is_flag_set(uint32_t flag); + +#endif /* __SECURITY_VBOOT_GBB_H__ */ -- To view, visit https://review.coreboot.org/25459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I35ecb5ba964511379baa4e9f458ba2e8c6b74b4e Gerrit-Change-Number: 25459 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: soc/amd: Add agesa_HeapRebase callout
by Richard Spiegel (Code Review) 29 Mar '18

29 Mar '18

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/25458 ) Change subject: soc/amd: Add agesa_HeapRebase callout ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/25458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieda202a6064302b21707bd7ddfabc132cd85ed45 Gerrit-Change-Number: 25458 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 29 Mar 2018 21:34:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: amd/stoneyridge: Use defined value for SPI flash MTRR
by Richard Spiegel (Code Review) 29 Mar '18

29 Mar '18

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/25455 ) Change subject: amd/stoneyridge: Use defined value for SPI flash MTRR ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/25455 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I006c7cfa0057b3ed4a21359fc8367caf6ec5baf3 Gerrit-Change-Number: 25455 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 29 Mar 2018 21:15:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: vc/amd/stoneyridge: Add definition for AGESA heap rebase
by Richard Spiegel (Code Review) 29 Mar '18

29 Mar '18

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/25456 ) Change subject: vc/amd/stoneyridge: Add definition for AGESA heap rebase ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/25456 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id23455779b1c8c4931ad1a3122587e09ad237ecc Gerrit-Change-Number: 25456 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 29 Mar 2018 21:06:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: amd/common/block/pi: Make agesa_heap_base() static
by Richard Spiegel (Code Review) 29 Mar '18

29 Mar '18

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/25457 ) Change subject: amd/common/block/pi: Make agesa_heap_base() static ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/25457/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/25457/1//COMMIT_MSG@11 PS1, Line 11: : C Is there a bug associated to? Maybe this is a small patch for something else that does have a bug number? Even if there's no need of test, we should at least add Test=none -- To view, visit https://review.coreboot.org/25457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ee162985ca1ea36461ea413416d98451a700f8c Gerrit-Change-Number: 25457 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Comment-Date: Thu, 29 Mar 2018 20:55:35 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/amd: Add agesa_HeapRebase callout
by build bot (Jenkins) (Code Review) 29 Mar '18

29 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25458 ) Change subject: soc/amd: Add agesa_HeapRebase callout ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69284/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/23626/ : SUCCESS -- To view, visit https://review.coreboot.org/25458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieda202a6064302b21707bd7ddfabc132cd85ed45 Gerrit-Change-Number: 25458 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 29 Mar 2018 20:41:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

← Newer
1
2
3
4
5
6
7
...
140
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018