September 2018 - coreboot-gerrit

Change in coreboot[master]: sb/amd/pi/hudson: Remove #if 1
by Angel Pons (Code Review) Sept. 30, 2018

Sept. 30, 2018

Angel Pons has posted comments on this change. ( https://review.coreboot.org/28830 ) Change subject: sb/amd/pi/hudson: Remove #if 1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28830 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4cf69dc3df2afaa8f33864374ea93548ab7ad810 Gerrit-Change-Number: 28830 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 30 Sep 2018 21:47:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Documentation: Spell "blob" in lowercase
by Angel Pons (Code Review) Sept. 30, 2018

Sept. 30, 2018

Angel Pons has posted comments on this change. ( https://review.coreboot.org/28827 ) Change subject: Documentation: Spell "blob" in lowercase ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/28827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I529561e4fc9889be7f9d6bd6d5f9a876e2007671 Gerrit-Change-Number: 28827 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 30 Sep 2018 21:13:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Documentation/.../gerrit_guidelines: Remove trailing colon from headings
by Angel Pons (Code Review) Sept. 30, 2018

Sept. 30, 2018

Angel Pons has posted comments on this change. ( https://review.coreboot.org/28832 ) Change subject: Documentation/.../gerrit_guidelines: Remove trailing colon from headings ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7344026f5753aebdd73f9fe414e96730c823ac26 Gerrit-Change-Number: 28832 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 30 Sep 2018 20:55:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Documentation/mainboard/gigabyte/ga-h61m-s2pv: Expand page
by Angel Pons (Code Review) Sept. 30, 2018

Sept. 30, 2018

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28833 Change subject: Documentation/mainboard/gigabyte/ga-h61m-s2pv: Expand page ...................................................................... Documentation/mainboard/gigabyte/ga-h61m-s2pv: Expand page Uniformize the Yes/No in the tables, expand the internal programming section and explain how to patch a defective flash descriptor. Change-Id: I972bb8948c29ce0eba46daa92ce6b6052db7b063 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M Documentation/mainboard/gigabyte/ga-h61m-s2pv.md 1 file changed, 35 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/28833/1 diff --git a/Documentation/mainboard/gigabyte/ga-h61m-s2pv.md b/Documentation/mainboard/gigabyte/ga-h61m-s2pv.md index 54c647e..05c793b 100644 --- a/Documentation/mainboard/gigabyte/ga-h61m-s2pv.md +++ b/Documentation/mainboard/gigabyte/ga-h61m-s2pv.md @@ -9,13 +9,13 @@ +---------------------+------------+ | Type | Value | +=====================+============+ -| Socketed flash | no | +| Socketed flash | No | +---------------------+------------+ | Model | MX25L3206E | +---------------------+------------+ | Size | 4 MiB | +---------------------+------------+ -| In circuit flashing | yes | +| In circuit flashing | Yes | +---------------------+------------+ | Package | SOIC-8 | +---------------------+------------+ @@ -23,13 +23,43 @@ +---------------------+------------+ | Dual BIOS feature | Yes | +---------------------+------------+ -| Internal flashing | yes | +| Internal flashing | Yes | +---------------------+------------+ ``` ### Internal programming -The main SPI flash can be accessed using [flashrom]. +The main SPI flash can be accessed using [flashrom]. The DualBIOS backup flash +chip is accessible as well using the `dualbiosindex` programmer parameter. +Since the flash recovery mechanism works even with coreboot installed on the +main flash chip (it still restores the vendor UEFI though), it is useful to +leave the backup chip untouched. + +### Notes about the original firmware + +The original IFD defines the BIOS region as the whole flash chip. While this is +not an issue if flashing a complete image, it confuses flashrom and trashes the +flash chip's contents when using the--ifd option. However, this can be easily +fixed by reading the IFD with flashrom, editing the correct values into it with +ifdtool and then reflashing it. + +Create a layout.txt with the following contents: + + 00000000:00000fff fd + 00180000:003fffff bios + 00001000:0017ffff me + +After that, simply run: + +```bash +sudo flashrom -p internal --ifd -i fd -r ifd.rom +ifdtool -n layout.txt ifd.rom +sudo flashrom -p internal --ifd -i fd -w ifd.rom.new +``` + +After flashing, power cycle the computer to ensure the new IFD is being used. +If only a reboot is done, the old IFD layout is still seen by flashrom, even if +the IFD on the flash chip is correctly defining the new region layout. ## Technology @@ -43,7 +73,7 @@ +------------------+--------------------------------------------------+ | SuperIO | ITE IT8728F | +------------------+--------------------------------------------------+ -| EC | | +| EC | None | +------------------+--------------------------------------------------+ | Coprocessor | Intel ME | +------------------+--------------------------------------------------+ -- To view, visit https://review.coreboot.org/28833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I972bb8948c29ce0eba46daa92ce6b6052db7b063 Gerrit-Change-Number: 28833 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in coreboot[master]: Documentation/.../gerrit_guidelines: Remove trailing colon from headings
by Jonathan Neuschäfer (Code Review) Sept. 30, 2018

Sept. 30, 2018

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/28832 Change subject: Documentation/.../gerrit_guidelines: Remove trailing colon from headings ...................................................................... Documentation/.../gerrit_guidelines: Remove trailing colon from headings They are unnecessary in headings, and look slightly irritating in the table of contents. Change-Id: I7344026f5753aebdd73f9fe414e96730c823ac26 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M Documentation/getting_started/gerrit_guidelines.md 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/28832/1 diff --git a/Documentation/getting_started/gerrit_guidelines.md b/Documentation/getting_started/gerrit_guidelines.md index e517dce..9210c84 100644 --- a/Documentation/getting_started/gerrit_guidelines.md +++ b/Documentation/getting_started/gerrit_guidelines.md @@ -13,8 +13,8 @@ Don't just assume that it's okay, even if someone on IRC says it is. -Summary: --------- +Summary +------- These are the expectations for committing, reviewing, and submitting code into coreboot git and gerrit. While breaking individual rules may not have immediate consequences, the coreboot leadership may act on repeated or @@ -33,8 +33,8 @@ * Don’t submit patches that you know will break other platforms. -More detail: ------------- +More detail +----------- * Don't violate the licenses. If you're submitting code that you didn't write yourself, make sure the license is compatible with the license of the project you're submitting the changes to. If you’re submitting code that @@ -98,8 +98,8 @@ working. -Recommendations for gerrit activity: ------------------------------------- +Recommendations for gerrit activity +----------------------------------- These guidelines are less strict than the ones listed above. These are more of the “good idea” variety. You are requested to follow the below guidelines, but there will probably be no actual consequences if they’re @@ -251,8 +251,8 @@ Other tags such as 'Commit-Queue' can simply be removed. -Expectations contributors should have: --------------------------------------- +Expectations contributors should have +------------------------------------- * Don't expect that people will review your patch unless you ask them to. Adding other people as reviewers is the easiest way. Asking for reviews for individual patches in the IRC channel, or by sending a direct request to an -- To view, visit https://review.coreboot.org/28832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7344026f5753aebdd73f9fe414e96730c823ac26 Gerrit-Change-Number: 28832 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: Documentation: Spell "blob" in lowercase
by Jonathan Neuschäfer (Code Review) Sept. 30, 2018

Sept. 30, 2018

Hello Angel Pons, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28827 to look at the new patch set (#2). Change subject: Documentation: Spell "blob" in lowercase ...................................................................... Documentation: Spell "blob" in lowercase It's not an acronym (outside of database software). Change-Id: I529561e4fc9889be7f9d6bd6d5f9a876e2007671 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M Documentation/lessons/lesson1.md M Documentation/mainboard/lenovo/xx20_series.md M Documentation/mainboard/lenovo/xx30_series.md M Documentation/northbridge/intel/sandybridge/nri_features.md 4 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/28827/2 -- To view, visit https://review.coreboot.org/28827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I529561e4fc9889be7f9d6bd6d5f9a876e2007671 Gerrit-Change-Number: 28827 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: Documentation/mb/lenovo/t4xx_series: Change "Steps to access the flas...
by Angel Pons (Code Review) Sept. 30, 2018

Sept. 30, 2018

Angel Pons has posted comments on this change. ( https://review.coreboot.org/28826 ) Change subject: Documentation/mb/lenovo/t4xx_series: Change "Steps to access the flash IC" to sub-heading ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/28826 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0685bb8734ad899c29618d24c0497e4fb8c0d01c Gerrit-Change-Number: 28826 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 30 Sep 2018 20:28:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Documentation: Spell "blob" in lowercase
by Jonathan Neuschäfer (Code Review) Sept. 30, 2018

Sept. 30, 2018

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/28827 ) Change subject: Documentation: Spell "blob" in lowercase ...................................................................... Patch Set 1: > Should this one be changed too? > > lessons/lesson1.md:By default, the BLOBS submodule is not > downloaded. This git submodule may be I thought about leaving this in for emphasis, but I'll use _this_ or *that* instead. Thanks. -- To view, visit https://review.coreboot.org/28827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I529561e4fc9889be7f9d6bd6d5f9a876e2007671 Gerrit-Change-Number: 28827 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 30 Sep 2018 20:27:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: Documentation: Spell "blob" in lowercase
by Angel Pons (Code Review) Sept. 30, 2018

Sept. 30, 2018

Angel Pons has posted comments on this change. ( https://review.coreboot.org/28827 ) Change subject: Documentation: Spell "blob" in lowercase ...................................................................... Patch Set 1: Code-Review+1 Should this one be changed too? lessons/lesson1.md:By default, the BLOBS submodule is not downloaded. This git submodule may be -- To view, visit https://review.coreboot.org/28827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I529561e4fc9889be7f9d6bd6d5f9a876e2007671 Gerrit-Change-Number: 28827 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 30 Sep 2018 20:21:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: arch/riscv: Update comment about mstatus initialization
by Jonathan Neuschäfer (Code Review) Sept. 30, 2018

Sept. 30, 2018

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/28831 Change subject: arch/riscv: Update comment about mstatus initialization ...................................................................... arch/riscv: Update comment about mstatus initialization Coreboot does not setup virtual memory anymore. Change-Id: I231af07b2988e8362d1cdd606ce889fb31136ff1 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/arch/riscv/bootblock.S 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/28831/1 diff --git a/src/arch/riscv/bootblock.S b/src/arch/riscv/bootblock.S index 95e1923..277c391 100644 --- a/src/arch/riscv/bootblock.S +++ b/src/arch/riscv/bootblock.S @@ -66,7 +66,7 @@ # clear any pending interrupts csrwi mip, 0 - # set up the mstatus register for VM + # set up the mstatus register call mstatus_init tail main -- To view, visit https://review.coreboot.org/28831 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I231af07b2988e8362d1cdd606ce889fb31136ff1 Gerrit-Change-Number: 28831 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0