Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/28024 )
Change subject: mainboard/opencellular/elgon: Add mainboard support
......................................................................
Patch Set 15: Code-Review+2
--
To view, visit https://review.coreboot.org/28024
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b809306cc48facbade5dc63846c4532b397e0b5
Gerrit-Change-Number: 28024
Gerrit-PatchSet: 15
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Sun, 30 Sep 2018 03:08:10 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/28789 )
Change subject: soc/cavium/cn81xx/spi: Add function to return SPI clock
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/28789
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07c95b9ea14d47da0497470487fa3f162f8012c8
Gerrit-Change-Number: 28789
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 30 Sep 2018 03:04:46 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/28803 )
Change subject: mb/google/poppy/variant/nocturne: increase touchscreen reset delay
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/28803/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/28803/1//COMMIT_MSG@9
PS1, Line 9: ms.
> ms
Done
https://review.coreboot.org/#/c/28803/1/src/mainboard/google/poppy/variants…
File src/mainboard/google/poppy/variants/nocturne/devicetree.cb:
https://review.coreboot.org/#/c/28803/1/src/mainboard/google/poppy/variants…
PS1, Line 294: register "generic.reset_delay_ms" = "10"
> I think it would be good to add the "disable_gpio_export_in_crs" option as well.
Done
--
To view, visit https://review.coreboot.org/28803
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I102b57ea5a10d22bee6d4f7c6f114b380a5d586b
Gerrit-Change-Number: 28803
Gerrit-PatchSet: 2
Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 30 Sep 2018 00:21:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Hello Caveh Jalali, Duncan Laurie, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/28803
to look at the new patch set (#2).
Change subject: mb/google/poppy/variant/nocturne: increase touchscreen reset delay
......................................................................
mb/google/poppy/variant/nocturne: increase touchscreen reset delay
Increase the reset delay for the touchscreen to 10 ms.
BUG=b:116857433
TEST='emerge-nocturne coreboot chromeos-bootimage', flash and boot
nocturne to kernel, log in and execute the following two commands:
echo "i2c-WCOM50C1:00" > /sys/bus/i2c/drivers/i2c_hid/unbind
echo "i2c-WCOM50C1:00" > /sys/bus/i2c/drivers/i2c_hid/bind
and verify the bind command does not echo back a
"-bash: echo: write error: No such device" error.
Change-Id: I102b57ea5a10d22bee6d4f7c6f114b380a5d586b
Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com>
---
M src/mainboard/google/poppy/variants/nocturne/devicetree.cb
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/28803/2
--
To view, visit https://review.coreboot.org/28803
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I102b57ea5a10d22bee6d4f7c6f114b380a5d586b
Gerrit-Change-Number: 28803
Gerrit-PatchSet: 2
Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>