coreboot-gerrit September 2018

coreboot-gerrit@coreboot.org

1 participants
886 discussions

Change in coreboot[master]: src/Kconfig: Drop a superfluous word
by Jonathan Neuschäfer (Code Review) 29 Sep '18

29 Sep '18

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/28798 Change subject: src/Kconfig: Drop a superfluous word ...................................................................... src/Kconfig: Drop a superfluous word Change-Id: I2d658e57d52f79c77be08599b9e525a46e30f732 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/28798/1 diff --git a/src/Kconfig b/src/Kconfig index ca75c0b..2777d26 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -153,7 +153,7 @@ a small self-decompression stub to its front. This can drastically reduce boot time on platforms where the bootblock is loaded over a very slow connection and bootblock size trumps all other factors for - speed. Since this using this option usually requires changes to the + speed. Since using this option usually requires changes to the SoC memlayout and possibly extra support code, it should not be user-selectable. (There's no real point in offering this to the user anyway... if it works and saves boot time, you would always want it.) -- To view, visit https://review.coreboot.org/28798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2d658e57d52f79c77be08599b9e525a46e30f732 Gerrit-Change-Number: 28798 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: drivers/generic: Add support for providing DSD properties
by Furquan Shaikh (Code Review) 29 Sep '18

29 Sep '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/28796 ) Change subject: drivers/generic: Add support for providing DSD properties ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://review.coreboot.org/28796 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ca6614f1ef322397618676bbf6da898bef18990 Gerrit-Change-Number: 28796 Gerrit-PatchSet: 4 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 29 Sep 2018 15:48:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: drivers/generic: Add support for providing DSD properties
by Furquan Shaikh (Code Review) 29 Sep '18

29 Sep '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28796 to look at the new patch set (#3). Change subject: drivers/generic: Add support for providing DSD properties ...................................................................... drivers/generic: Add support for providing DSD properties This change adds support in generic device driver to add properties to DSD table. This driver can be used by all generic devices that do not need any special handling other than simply adding device properties to be used by OS. BUG=b:112888584 Change-Id: I0ca6614f1ef322397618676bbf6da898bef18990 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/drivers/generic/generic/Kconfig M src/drivers/generic/generic/Makefile.inc A src/drivers/generic/generic/chip.h A src/drivers/generic/generic/generic.c 4 files changed, 132 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/28796/3 -- To view, visit https://review.coreboot.org/28796 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0ca6614f1ef322397618676bbf6da898bef18990 Gerrit-Change-Number: 28796 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: drivers/generic: Add support for providing DSD properties
by Furquan Shaikh (Code Review) 29 Sep '18

29 Sep '18

Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/28796 ) Change subject: drivers/generic: Add support for providing DSD properties ...................................................................... drivers/generic: Add support for providing DSD properties This change adds support in generic device driver to add properties to DSD table. This driver can be used by all generic devices that do not need any special handling other than simply adding device properties to be used by OS. BUG=b:112888584 Change-Id: I0ca6614f1ef322397618676bbf6da898bef18990 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/drivers/generic/generic/Kconfig M src/drivers/generic/generic/Makefile.inc A src/drivers/generic/generic/chip.h A src/drivers/generic/generic/generic.c 4 files changed, 131 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/28796/2 -- To view, visit https://review.coreboot.org/28796 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0ca6614f1ef322397618676bbf6da898bef18990 Gerrit-Change-Number: 28796 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nocturne: Add DMIC properties to ACPI DSD
by Furquan Shaikh (Code Review) 29 Sep '18

29 Sep '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/28797 Change subject: mb/google/poppy/variants/nocturne: Add DMIC properties to ACPI DSD ...................................................................... mb/google/poppy/variants/nocturne: Add DMIC properties to ACPI DSD This change uses the generic device driver to provide DMIC properties in ACPI table to the OS driver. BUG=b:112888584 Change-Id: I239f571bc29f02793f017a4713b5af03b23cfa3e Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/mainboard/google/poppy/Kconfig M src/mainboard/google/poppy/variants/nocturne/devicetree.cb 2 files changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/28797/1 diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index df59c5e..e757822 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -3,6 +3,7 @@ def_bool n select BOARD_ROMSIZE_KB_16384 select DRIVERS_GENERIC_GPIO_KEYS + select DRIVERS_GENERIC_GENERIC select DRIVERS_I2C_GENERIC select DRIVERS_I2C_HID select EC_GOOGLE_CHROMEEC diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb index 70a379c..87219f2 100644 --- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb @@ -437,7 +437,18 @@ end # LPC Interface device pci 1f.1 on end # P2SB device pci 1f.2 on end # Power Management Controller - device pci 1f.3 on end # Intel HDA + device pci 1f.3 on + chip drivers/generic/generic + register "hid" = ""DMIC"" + register "name" = ""DMIC"" + register "desc" = ""Generic DMIC"" + register "property_count" = "1" + register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" + register "property_list[0].name" = ""modeswitch_delay_ms"" + register "property_list[0].integer" = "35" + device generic 0 on end + end + end # Intel HDA device pci 1f.4 on end # SMBus device pci 1f.5 on end # PCH SPI device pci 1f.6 off end # GbE -- To view, visit https://review.coreboot.org/28797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I239f571bc29f02793f017a4713b5af03b23cfa3e Gerrit-Change-Number: 28797 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: drivers/generic: Add support for providing DSD properties
by Furquan Shaikh (Code Review) 29 Sep '18

29 Sep '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/28796 Change subject: drivers/generic: Add support for providing DSD properties ...................................................................... drivers/generic: Add support for providing DSD properties This change adds support in generic device driver to add properties to DSD table. This driver can be used by all generic devices that do not need any special handling other than simply adding device properties to be used by OS. BUG=b:112888584 Change-Id: I0ca6614f1ef322397618676bbf6da898bef18990 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/drivers/generic/generic/Kconfig M src/drivers/generic/generic/Makefile.inc A src/drivers/generic/generic/chip.h A src/drivers/generic/generic/generic.c 4 files changed, 131 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/28796/1 diff --git a/src/drivers/generic/generic/Kconfig b/src/drivers/generic/generic/Kconfig index 864b878..7b16b62 100644 --- a/src/drivers/generic/generic/Kconfig +++ b/src/drivers/generic/generic/Kconfig @@ -1,2 +1,3 @@ config DRIVERS_GENERIC_GENERIC bool + depends on HAVE_ACPI_TABLES diff --git a/src/drivers/generic/generic/Makefile.inc b/src/drivers/generic/generic/Makefile.inc index b7db254..37a873b 100644 --- a/src/drivers/generic/generic/Makefile.inc +++ b/src/drivers/generic/generic/Makefile.inc @@ -1 +1 @@ -# Empty +ramstage-$(CONFIG_DRIVERS_GENERIC_GENERIC) += generic.c diff --git a/src/drivers/generic/generic/chip.h b/src/drivers/generic/generic/chip.h new file mode 100644 index 0000000..64f1543 --- /dev/null +++ b/src/drivers/generic/generic/chip.h @@ -0,0 +1,35 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2018 Google LLC. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef __GENERIC_GENERIC_CHIP_H__ +#define __GENERIC_GENERIC_CHIP_H__ + +#include <arch/acpi_device.h> + +#define MAX_GENERIC_PROPERTY_LIST 10 + +struct drivers_generic_generic_config { + const char *hid; /* ACPI _HID (required) */ + const char *cid; /* ACPI _CID */ + const char *name; /* ACPI Device Name */ + const char *desc; /* ACPI _DDN */ + unsigned int uid; /* ACPI _UID */ + + /* Generic properties for exporting device-specific data to the OS */ + struct acpi_dp property_list[MAX_GENERIC_PROPERTY_LIST]; + int property_count; +}; + +#endif /* __GENERIC_GENERIC_CHIP_H__ */ diff --git a/src/drivers/generic/generic/generic.c b/src/drivers/generic/generic/generic.c new file mode 100644 index 0000000..44fe375 --- /dev/null +++ b/src/drivers/generic/generic/generic.c @@ -0,0 +1,94 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2018 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <arch/acpi_device.h> +#include <console/console.h> +#include <device/device.h> +#include <device/path.h> +#include <stdint.h> +#include <string.h> +#include "chip.h" + +static void generic_dev_fill_ssdt_generator(struct device *dev) +{ + struct acpi_dp *dsd; + struct drivers_generic_generic_config *config = dev->chip_info; + + if (!dev->enabled || !config) + return; + + if (!config->hid) { + printk(BIOS_ERR, "%s: ERROR: _HID required\n", dev_path(dev)); + return; + } + + acpigen_write_scope(acpi_device_scope(dev)); + acpigen_write_device(acpi_device_name(dev)); + acpigen_write_name_string("_HID", config->hid); + if (config->cid) + acpigen_write_name_string("_CID", config->cid); + acpigen_write_name_integer("_UID", config->uid); + acpigen_write_name_string("_DDN", config->desc); + acpigen_write_STA(acpi_device_status(dev)); + + dsd = acpi_dp_new_table("_DSD"); + acpi_dp_add_property_list(dsd, config->property_list, + config->property_count); + acpi_dp_write(dsd); + + acpigen_pop_len(); /* Device */ + acpigen_pop_len(); /* Scope */ + + printk(BIOS_INFO, "%s: %s at %s\n", acpi_device_path(dev), + config->desc ? : dev->chip_ops->name, dev_path(dev)); +} + +static const char *generic_dev_prepare_name(void) +{ + static char name[5]; + static unsigned int id; + + snprintf(name, sizeof(name), "G%03.3X", id++); + name[4] = '\0'; + return name; +} + +static const char *generic_dev_acpi_name(const struct device *dev) +{ + const struct drivers_generic_generic_config *config = dev->chip_info; + + if (config->name) + return config->name; + + return generic_dev_prepare_name(); +} + +static struct device_operations generic_dev_ops = { + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, + .acpi_name = &generic_dev_acpi_name, + .acpi_fill_ssdt_generator = &generic_dev_fill_ssdt_generator, +}; + +static void generic_dev_enable(struct device *dev) +{ + dev->ops = &generic_dev_ops; +} + +struct chip_operations drivers_generic_generic_ops = { + CHIP_NAME("Generic Device") + .enable_dev = &generic_dev_enable +}; -- To view, visit https://review.coreboot.org/28796 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0ca6614f1ef322397618676bbf6da898bef18990 Gerrit-Change-Number: 28796 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: soc/intel/common: add acpi_get_sleep_type to pmclib
by Bora Guvendik (Code Review) 29 Sep '18

29 Sep '18

Hello build bot (Jenkins), Hannah Williams, Shaunak Saha, I'd like you to reexamine a change. Please visit https://review.coreboot.org/28795 to look at the new patch set (#2). Change subject: soc/intel/common: add acpi_get_sleep_type to pmclib ...................................................................... soc/intel/common: add acpi_get_sleep_type to pmclib Change-Id: I3f4123657a375211f802a7d484a15353f9a256e9 Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> --- M src/soc/intel/cannonlake/romstage/power_state.c M src/soc/intel/common/block/pmc/pmclib.c M src/soc/intel/skylake/pmutil.c 3 files changed, 8 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/28795/2 -- To view, visit https://review.coreboot.org/28795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3f4123657a375211f802a7d484a15353f9a256e9 Gerrit-Change-Number: 28795 Gerrit-PatchSet: 2 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/common: add acpi_get_sleep_type to pmclib
by Bora Guvendik (Code Review) 29 Sep '18

29 Sep '18

Bora Guvendik has uploaded this change for review. ( https://review.coreboot.org/28795 Change subject: soc/intel/common: add acpi_get_sleep_type to pmclib ...................................................................... soc/intel/common: add acpi_get_sleep_type to pmclib Change-Id: I3f4123657a375211f802a7d484a15353f9a256e9 Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> --- M src/soc/intel/common/block/pmc/pmclib.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/28795/1 diff --git a/src/soc/intel/common/block/pmc/pmclib.c b/src/soc/intel/common/block/pmc/pmclib.c index 52bfaec..3fb3866 100644 --- a/src/soc/intel/common/block/pmc/pmclib.c +++ b/src/soc/intel/common/block/pmc/pmclib.c @@ -93,6 +93,14 @@ */ } +int acpi_get_sleep_type(void) +{ + struct chipset_power_state *ps; + + ps = pmc_get_power_state(); + return ps->prev_sleep_state; +} + static uint32_t pmc_reset_smi_status(void) { uint32_t smi_sts = inl(ACPI_BASE_ADDRESS + SMI_STS); -- To view, visit https://review.coreboot.org/28795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3f4123657a375211f802a7d484a15353f9a256e9 Gerrit-Change-Number: 28795 Gerrit-PatchSet: 1 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com>

1 0

Change in coreboot[master]: util/superiotool/smsc.c: Add some register dumps
by Angel Pons (Code Review) 28 Sep '18

28 Sep '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28794 Change subject: util/superiotool/smsc.c: Add some register dumps ...................................................................... util/superiotool/smsc.c: Add some register dumps The SCH3112, SCH3116 and SCH5127 were lacking a pin dump. Since their datasheets are available, add their pin dumps. The SCH3112, SCH3114 and SCH3116 are almost identical, they only differ in the number of serial ports. One hex value in the SCH3114 dump was in uppercase, that has been fixed as well. Datasheets used: - SCH311X: DS00001872A - SCH5127: DS00002081A Change-Id: Ic985526be9b09e0452eaf883904dfaf709b7e907 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M util/superiotool/smsc.c 1 file changed, 89 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/28794/1 diff --git a/util/superiotool/smsc.c b/util/superiotool/smsc.c index 21763ec..1f24e62 100644 --- a/util/superiotool/smsc.c +++ b/util/superiotool/smsc.c @@ -733,12 +733,37 @@ 0x00,0x00,0x00,0x00,RSVD,0x00,0x00,0x80,EOT}}, {EOT}}}, {0x7c, "SCH3112", { + {NOLDN, NULL, + {0x02,0x03,0x20,0x21,0x22,0x23,0x24,0x26,0x27, + 0x28,0x29,0x2a,0x2b,0x2c,0x2d,0x2e,0x2f,EOT}, + {0x00,RSVD,0x7c,RSVD,0x00,RSVD,0x44,MISC,0x00, + RSVD,0x00,0x00,0x00,0x00,0x00,0x00,0x00,EOT}}, + {0x0, "Floppy", + {0x30,0x60,0x61,0x70,0x74,0xf0,0xf1,0xf2,0xf4, + 0xf5,EOT}, + {0x00,0x03,0xf0,0x06,0x02,0x0e,0x00,0xff,0x00, + 0x00,EOT}}, + {0x3, "Parallel port", + {0x30,0x60,0x61,0x70,0x74,0xf0,0xf1,EOT}, + {0x00,0x00,0x00,0x00,0x04,0x3c,0x00,EOT}}, + {0x4, "COM1", + {0x30,0x60,0x61,0x70,0xf0,EOT}, + {0x00,0x00,0x00,0x00,0x00,EOT}}, + {0x5, "COM2", + {0x30,0x60,0x61,0x70,0xf0,0xf1,0xf2,EOT}, + {0x00,0x00,0x00,0x00,0x00,0x02,0x03,EOT}}, + {0x7, "Keyboard", + {0x30,0x70,0x72,0xf0,EOT}, + {0x00,0x00,0x00,0x00,EOT}}, + {0xa, "Runtime registers", + {0x30,0x60,0x61,0x62,0x63,0xf0,0xf1,0xf2,EOT}, + {0x00,0x00,0x00,0x00,0x00,NANA,0x00,0x04,EOT}}, {EOT}}}, {0x7d, "SCH3114", { {NOLDN, NULL, {0x02,0x03,0x20,0x21,0x22,0x23,0x24,0x26,0x27, 0x28,0x29,0x2a,0x2b,0x2c,0x2d,0x2e,0x2f,EOT}, - {0x00,RSVD,0x7D,RSVD,0x00,RSVD,0x44,MISC,0x00, + {0x00,RSVD,0x7d,RSVD,0x00,RSVD,0x44,MISC,0x00, RSVD,0x00,0x00,0x00,0x00,0x00,0x00,0x00,EOT}}, {0x0, "Floppy", {0x30,0x60,0x61,0x70,0x74,0xf0,0xf1,0xf2,0xf4, @@ -768,6 +793,43 @@ {0x00,0x00,0x00,0x00,0x00,EOT}}, {EOT}}}, {0x7f, "SCH3116", { + {NOLDN, NULL, + {0x02,0x03,0x20,0x21,0x22,0x23,0x24,0x26,0x27, + 0x28,0x29,0x2a,0x2b,0x2c,0x2d,0x2e,0x2f,EOT}, + {0x00,RSVD,0x7f,RSVD,0x00,RSVD,0x44,MISC,0x00, + RSVD,0x00,0x00,0x00,0x00,0x00,0x00,0x00,EOT}}, + {0x0, "Floppy", + {0x30,0x60,0x61,0x70,0x74,0xf0,0xf1,0xf2,0xf4, + 0xf5,EOT}, + {0x00,0x03,0xf0,0x06,0x02,0x0e,0x00,0xff,0x00, + 0x00,EOT}}, + {0x3, "Parallel port", + {0x30,0x60,0x61,0x70,0x74,0xf0,0xf1,EOT}, + {0x00,0x00,0x00,0x00,0x04,0x3c,0x00,EOT}}, + {0x4, "COM1", + {0x30,0x60,0x61,0x70,0xf0,EOT}, + {0x00,0x00,0x00,0x00,0x00,EOT}}, + {0x5, "COM2", + {0x30,0x60,0x61,0x70,0xf0,0xf1,0xf2,EOT}, + {0x00,0x00,0x00,0x00,0x00,0x02,0x03,EOT}}, + {0x7, "Keyboard", + {0x30,0x70,0x72,0xf0,EOT}, + {0x00,0x00,0x00,0x00,EOT}}, + {0xa, "Runtime registers", + {0x30,0x60,0x61,0x62,0x63,0xf0,0xf1,0xf2,EOT}, + {0x00,0x00,0x00,0x00,0x00,NANA,0x00,0x04,EOT}}, + {0xb, "COM3", + {0x30,0x60,0x61,0x70,0xf0,EOT}, + {0x00,0x00,0x00,0x00,0x00,EOT}}, + {0xc, "COM4", + {0x30,0x60,0x61,0x70,0xf0,EOT}, + {0x00,0x00,0x00,0x00,0x00,EOT}}, + {0xd, "COM5", + {0x30,0x60,0x61,0x70,0xf0,EOT}, + {0x00,0x00,0x00,0x00,0x00,EOT}}, + {0xe, "COM6", + {0x30,0x60,0x61,0x70,0xf0,EOT}, + {0x00,0x00,0x00,0x00,0x00,EOT}}, {EOT}}}, {0x81, "SCH5307", { {EOT}}}, @@ -776,7 +838,32 @@ {0x85, "SCH5317", { /* From sensors-detect */ /* The SCH5317 can have either 0x85 or 0x8c as device ID. */ {EOT}}}, - {0x86, "SCH5127", { /* From sensors-detect */ + {0x86, "SCH5127", { /* From sensors-detect, dump from datasheet */ + {NOLDN, NULL, + {0x02,0x03,0x20,0x21,0x22,0x23,0x24,0x26,0x27, + 0x28,0x2a,0x2b,0x2c,0x2d,0x2e,0x2f,EOT}, + {0x00,RSVD,0x86,RSVD,0x00,0x00,0x44,MISC,MISC, + RSVD,0x00,0x00,0x00,0x00,0x00,0x00,EOT}}, + {0x0, "Floppy", + {0x30,0x60,0x61,0x70,0x74,0xf0,0xf1,0xf2,0xf4, + 0xf5,EOT}, + {0x00,0x03,0xf0,0x06,0x02,0x0e,0x00,0xff,0x00, + 0x00,EOT}}, + {0x3, "Parallel port", + {0x30,0x60,0x61,0x70,0x74,0xf0,0xf1,EOT}, + {0x00,0x00,0x00,0x00,0x04,0x3c,0x00,EOT}}, + {0x4, "COM1", + {0x30,0x60,0x61,0x70,0xf0,EOT}, + {0x00,0x00,0x00,0x00,0x00,EOT}}, + {0x5, "COM2", + {0x30,0x60,0x61,0x70,0xf0,0xf1,0xf2,EOT}, + {0x00,0x00,0x00,0x00,0x00,0x02,0x03,EOT}}, + {0x7, "Keyboard", + {0x30,0x70,0x72,0xf0,EOT}, + {0x00,0x00,0x00,0x00,EOT}}, + {0xa, "Runtime registers", + {0x30,0x60,0x61,0x70,0xf0,0xf1,EOT}, + {0x00,0x00,0x00,0x00,0x00,RSVD,EOT}}, {EOT}}}, {0x89, "SCH5027", { /* From sensors-detect (no public datasheet) */ {EOT}}}, -- To view, visit https://review.coreboot.org/28794 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic985526be9b09e0452eaf883904dfaf709b7e907 Gerrit-Change-Number: 28794 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in coreboot[master]: drivers/intel/wifi: Add DID for Intel WIFI module 8260, 8275
by Subrata Banik (Code Review) 28 Sep '18

28 Sep '18

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/28793 Change subject: drivers/intel/wifi: Add DID for Intel WIFI module 8260, 8275 ...................................................................... drivers/intel/wifi: Add DID for Intel WIFI module 8260, 8275 Change-Id: I38d83370e96cff6822a96da5fa3d9af797ba1dc1 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/drivers/intel/wifi/wifi.c M src/include/device/pci_ids.h 2 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/28793/1 diff --git a/src/drivers/intel/wifi/wifi.c b/src/drivers/intel/wifi/wifi.c index df425fa..cdce6e2 100644 --- a/src/drivers/intel/wifi/wifi.c +++ b/src/drivers/intel/wifi/wifi.c @@ -312,6 +312,11 @@ /* Stone Peak 2 */ PCI_DEVICE_ID_SP_7265_SERIES_1_WIFI, PCI_DEVICE_ID_SP_7265_SERIES_2_WIFI, + /* Stone Field Peak */ + PCI_DEVICE_ID_SFP_8260_SERIES_1_WIFI, + PCI_DEVICE_ID_SFP_8260_SERIES_2_WIFI, + /* Windstorm Peak */ + PCI_DEVICE_ID_WSP_8275_SERIES_1_WIFI, /* Jefferson Peak */ PCI_DEVICE_ID_JP_9000_SERIES_1_WIFI, PCI_DEVICE_ID_JP_9000_SERIES_2_WIFI, diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index a6ed6d9..dc3abae 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -2995,6 +2995,9 @@ #define PCI_DEVICE_ID_JP_9000_SERIES_1_WIFI 0x9df0 #define PCI_DEVICE_ID_JP_9000_SERIES_2_WIFI 0x31dc #define PCI_DEVICE_ID_JP_9000_SERIES_3_WIFI 0xa370 +#define PCI_DEVICE_ID_SFP_8260_SERIES_1_WIFI 0x24f3 +#define PCI_DEVICE_ID_SFP_8260_SERIES_2_WIFI 0x24f4 +#define PCI_DEVICE_ID_WSP_8275_SERIES_1_WIFI 0x24fd #define PCI_DEVICE_ID_TP_9260_SERIES_WIFI 0x2526 #define PCI_DEVICE_ID_HrP_9560_SERIES_1_WIFI 0x34f0 #define PCI_DEVICE_ID_HrP_9560_SERIES_2_WIFI 0xa0f0 -- To view, visit https://review.coreboot.org/28793 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I38d83370e96cff6822a96da5fa3d9af797ba1dc1 Gerrit-Change-Number: 28793 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
89
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2018