coreboot-gerrit August 2018

coreboot-gerrit@coreboot.org

1 participants
1120 discussions

Change in coreboot[master]: mainboard/google/kahlee: Enable EC firmware update screen
by Julius Werner (Code Review) 28 Aug '18

28 Aug '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/28374 ) Change subject: mainboard/google/kahlee: Enable EC firmware update screen ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/28374/1/src/mainboard/google/kahlee/Kconfig File src/mainboard/google/kahlee/Kconfig: https://review.coreboot.org/#/c/28374/1/src/mainboard/google/kahlee/Kconfig… PS1, Line 101: if VBOOT_EC_SOFTWARE_SYNC nit: VBOOT_EC_SLOW_UPDATE already has a 'depends on VBOOT_EC_SOFTWARE_SYNC', this if clause is pretty pointless. -- To view, visit https://review.coreboot.org/28374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95fc4d3430bac66c09f57a4d34abde08752e5f0e Gerrit-Change-Number: 28374 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Aug 2018 22:27:50 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/vendorcode/amd/agesa/f12: Update microcode to version 0x3000027 2...
by Mike Banon (Code Review) 28 Aug '18

28 Aug '18

Mike Banon has uploaded this change for review. ( https://review.coreboot.org/28378 Change subject: src/vendorcode/amd/agesa/f12: Update microcode to version 0x3000027 2011-09-13 ...................................................................... src/vendorcode/amd/agesa/f12: Update microcode to version 0x3000027 2011-09-13 This microcode update for CPU ID 0x300F10 should improve the system stability. It is a part of microcode_amd.bin officially released by AMD at linux-firmware: it starts at 0x217C offset, and size is 0x03C0 as specified priorly at 0x2178. Old version: 0x300000F [2010-04-10] replaced by New version: 0x3000027 [2011-09-13] Change-Id: I9650fab377d957904318ebb393323c2509cfea26 Signed-off-by: Mike Banon <mikebdp2(a)gmail.com> --- M src/vendorcode/amd/agesa/f12/Config/OptionFamily12hInstall.h D src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x12/F12MicrocodePatch0300000f.c A src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x12/F12MicrocodePatch03000027.c M src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x12/Makefile.inc 4 files changed, 198 insertions(+), 1,038 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/28378/1 diff --git a/src/vendorcode/amd/agesa/f12/Config/OptionFamily12hInstall.h b/src/vendorcode/amd/agesa/f12/Config/OptionFamily12hInstall.h index ca0f79d..215342d 100644 --- a/src/vendorcode/amd/agesa/f12/Config/OptionFamily12hInstall.h +++ b/src/vendorcode/amd/agesa/f12/Config/OptionFamily12hInstall.h @@ -337,9 +337,9 @@ #define F12_LN_UCODE_0F #if AGESA_ENTRY_INIT_EARLY == TRUE - extern CONST MICROCODE_PATCHES ROMDATA CpuF12MicrocodePatch0300000f; + extern CONST MICROCODE_PATCHES ROMDATA CpuF12MicrocodePatch03000027; #undef F12_LN_UCODE_0F - #define F12_LN_UCODE_0F &CpuF12MicrocodePatch0300000f, + #define F12_LN_UCODE_0F &CpuF12MicrocodePatch03000027, #if OPTION_EARLY_SAMPLES == TRUE extern CONST MICROCODE_PATCHES ROMDATA CpuF12MicrocodePatch03000002; extern CONST MICROCODE_PATCHES ROMDATA CpuF12MicrocodePatch0300000e; diff --git a/src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x12/F12MicrocodePatch0300000f.c b/src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x12/F12MicrocodePatch0300000f.c deleted file mode 100644 index b4c8921..0000000 --- a/src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x12/F12MicrocodePatch0300000f.c +++ /dev/null @@ -1,1035 +0,0 @@ -/* $NoKeywords:$ */ -/** - * @file - * - * AMD Family_12 Microcode patch. - * - * Fam12 Microcode Patch rev 0300000F for 3010 or equivalent. - * - * @xrefitem bom "File Content Label" "Release Content" - * @e project: AGESA - * @e sub-project: CPU/FAMILY/0x12 - * @e \$Revision: 44324 $ @e \$Date: 2010-12-22 17:16:51 +0800 (Wed, 22 Dec 2010) $ - * - */ -/* - ****************************************************************************** - * - * Copyright (c) 2011, Advanced Micro Devices, Inc. - * All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions are met: - * * Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * * Redistributions in binary form must reproduce the above copyright - * notice, this list of conditions and the following disclaimer in the - * documentation and/or other materials provided with the distribution. - * * Neither the name of Advanced Micro Devices, Inc. nor the names of - * its contributors may be used to endorse or promote products derived - * from this software without specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND - * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE - * DISCLAIMED. IN NO EVENT SHALL ADVANCED MICRO DEVICES, INC. BE LIABLE FOR ANY - * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES - * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; - * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND - * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS - * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - ****************************************************************************** - */ -/*---------------------------------------------------------------------------------------- - * M O D U L E S U S E D - *---------------------------------------------------------------------------------------- - */ -#include "AGESA.h" -#include "cpuRegisters.h" -#include "cpuEarlyInit.h" - -/*---------------------------------------------------------------------------------------- - * D E F I N I T I O N S A N D M A C R O S - *---------------------------------------------------------------------------------------- - */ - -/*---------------------------------------------------------------------------------------- - * T Y P E D E F S A N D S T R U C T U R E S - *---------------------------------------------------------------------------------------- - */ - -// Patch code 0300000F for 3010 and equivalent -CONST MICROCODE_PATCHES ROMDATA CpuF12MicrocodePatch0300000f = -{{ -0x10, -0x20, -0x04, -0x10, -0x0f, -0x00, -0x00, -0x03, -0x03, -0x80, -0x20, -0x00, -0xab, -0x89, -0x5b, -0x29, -0x00, -0x00, -0x00, -0x00, -0x00, -0x00, -0x00, -0x00, -0x10, -0x30, -0x00, -0x00, -0x00, -0xaa, -0xaa, -0xaa, -0xbd, -0x02, -0x23, -0x47, -0x99, -0x0c, -0x51, -0xb9, -0xff, -0xff, -0x73, -0xe5, -0xff, -0xff, -0xd8, -0x51, -0xff, -0xff, -0x68, -0xa9, -0xff, -0xff, -0xc4, -0x88, -0xff, -0xff, -0xb0, -0xc9, -0xff, -0xff, -0xf0, -0x9a, -0x04, -0xfe, -0xff, -0x00, -0xc3, -0xb7, -0x14, -0xfd, -0xec, -0xf2, -0xff, -0xa3, -0x0e, -0xbf, -0x50, -0x55, -0xf0, -0xf7, -0xff, -0x0f, -0x3f, -0x7c, -0x63, -0xd9, -0x40, -0x83, -0xab, -0x01, -0x02, -0x87, -0x04, -0x7f, -0xd6, -0xe1, -0x97, -0x81, -0x01, -0xfe, -0xfd, -0xff, -0xfb, -0x87, -0x6f, -0x2f, -0x27, -0x78, -0x8d, -0xf0, -0x68, -0x1d, -0x7e, -0x19, -0x00, -0x40, -0xed, -0xd6, -0x0e, -0xc0, -0x3b, -0x26, -0x60, -0xe8, -0x80, -0x0f, -0x7f, -0x0e, -0xff, -0x95, -0x87, -0xcb, -0xc3, -0x3e, -0xfe, -0x29, -0xfc, -0x6f, -0x1c, -0x2e, -0x0f, -0xfb, -0x6a, -0x00, -0xb0, -0xe0, -0xf2, -0xef, -0xe1, -0xbf, -0xf7, -0x70, -0x79, -0xd8, -0xcd, -0xbf, -0x85, -0xff, -0xdf, -0xc2, -0xe5, -0x61, -0x33, -0xff, -0x16, -0xfe, -0x7d, -0x0b, -0x97, -0x87, -0xff, -0x3d, -0x00, -0xf8, -0x1f, -0xf8, -0x07, -0xf0, -0xfc, -0x03, -0xf8, -0x37, -0x7f, -0xe0, -0x1f, -0xc0, -0xf0, -0x0f, -0xe0, -0xdf, -0xff, -0x81, -0x7f, -0x00, -0xc3, -0x3f, -0x80, -0x7f, -0xfc, -0xff, -0x1e, -0x00, -0xf8, -0x0f, -0xfc, -0x03, -0x1b, -0xfe, -0x01, -0xfc, -0xe0, -0x3f, -0xf0, -0x0f, -0x6f, -0xf8, -0x07, -0xf0, -0x80, -0xff, -0xc0, -0x3f, -0xbf, -0xe1, -0x1f, -0xc0, -0x00, -0xfe, -0x7f, -0x0f, -0x01, -0xfc, -0x07, -0xfe, -0xfe, -0x0d, -0xff, -0x00, -0x07, -0xf0, -0x1f, -0xf8, -0xf8, -0x37, -0xfc, -0x03, -0x1f, -0xc0, -0x7f, -0xe0, -0xe0, -0xdf, -0xf0, -0x0f, -0x07, -0x00, -0xff, -0xbf, -0xff, -0x00, -0xfe, -0x03, -0x00, -0xff, -0x86, -0x7f, -0xfc, -0x03, -0xf8, -0x0f, -0x01, -0xfc, -0x1b, -0xfe, -0xf0, -0x0f, -0xe0, -0x3f, -0x07, -0xf0, -0x6f, -0xf8, -0xdf, -0x03, -0x80, -0xff, -0x81, -0x7f, -0x00, -0xff, -0x3f, -0x80, -0x7f, -0xc3, -0x07, -0xfe, -0x01, -0xfc, -0xff, -0x00, -0xfe, -0x0d, -0x1f, -0xf8, -0x07, -0xf0, -0xfc, -0x03, -0xf8, -0x37, -0xff, -0xef, -0x01, -0xc0, -0xff, -0xc0, -0x3f, -0x80, -0xe1, -0x1f, -0xc0, -0xbf, -0xfe, -0x03, -0xff, -0x00, -0x86, -0x7f, -0x00, -0xff, -0xf8, -0x0f, -0xfc, -0x03, -0x1b, -0xfe, -0x01, -0xfc, -0xe0, -0xff, -0xf7, -0x00, -0xc0, -0x7f, -0xe0, -0x1f, -0xdf, -0xf0, -0x0f, -0xe0, -0x00, -0xff, -0x81, -0x7f, -0x7f, -0xc3, -0x3f, -0x80, -0x01, -0xfc, -0x07, -0xfe, -0xfe, -0x0d, -0xff, -0x00, -0x00, -0xf0, -0xff, -0x7b, -0x0f, -0xe0, -0x3f, -0xf0, -0xf0, -0x6f, -0xf8, -0x07, -0x3f, -0x80, -0xff, -0xc0, -0xc0, -0xbf, -0xe1, -0x1f, -0xff, -0x00, -0xfe, -0x03, -0x00, -0xff, -0x86, -0x7f, -0x3d, -0x00, -0xf8, -0xff, -0xf8, -0x07, -0xf0, -0x1f, -0x03, -0xf8, -0x37, -0xfc, -0xe0, -0x1f, -0xc0, -0x7f, -0x0f, -0xe0, -0xdf, -0xf0, -0x81, -0x7f, -0x00, -0xff, -0x3f, -0x80, -0x7f, -0xc3, -0xff, -0x1e, -0x00, -0xfc, -0x0f, -0xfc, -0x03, -0xf8, -0xfe, -0x01, -0xfc, -0x1b, -0x3f, -0xf0, -0x0f, -0xe0, -0xf8, -0x07, -0xf0, -0x6f, -0xff, -0xc0, -0x3f, -0x80, -0xe1, -0x1f, -0xc0, -0xbf, -0xfe, -0x7f, -0x0f, -0x00, -0xfc, -0x07, -0xfe, -0x01, -0x0d, -0xff, -0x00, -0xfe, -0xf0, -0x1f, -0xf8, -0x07, -0x37, -0xfc, -0x03, -0xf8, -0xc0, -0x7f, -0xe0, -0x1f, -0xdf, -0xf0, -0x0f, -0xe0, -0x00, -0xff, -0xbf, -0x07, -0x00, -0xfe, -0x03, -0xff, -0xff, -0x86, -0x7f, -0x00, -0x03, -0xf8, -0x0f, -0xfc, -0xfc, -0x1b, -0xfe, -0x01, -0x0f, -0xe0, -0x3f, -0xf0, -0xf0, -0x6f, -0xf8, -0x07, -0x03, -0x80, -0xff, -0xdf, -0x7f, -0x00, -0xff, -0x81, -0x80, -0x7f, -0xc3, -0x3f, -0xfe, -0x01, -0xfc, -0x07, -0x00, -0xfe, -0x0d, -0xff, -0xf8, -0x07, -0xf0, -0x1f, -0x03, -0xf8, -0x37, -0xfc, -0xaf, -0x01, -0x00, -0x3f, -0xc0, -0x3f, -0x80, -0xff, -0x1f, -0xc0, -0xbf, -0xe1, -0x03, -0xff, -0x00, -0xfe, -0x7f, -0x00, -0xff, -0x86, -0x0f, -0xfc, -0x03, -0xf8, -0xfe, -0x01, -0xfc, -0x1b, -0x9f, -0xd7, -0x00, -0x60, -0xf7, -0xff, -0x3f, -0xc0, -0xf0, -0xed, -0x65, -0xff, -0xff, -0xff, -0xff, -0x04, -0xc3, -0x2f, -0x03, -0xad, -0xfc, -0x07, -0xfe, -0x01, -0x0d, -0xff, -0x00, -0xfe, -0xf0, -0xff, -0x7b, -0x00, -0xa0, -0xc1, -0xff, -0x1f, -0x7f, -0xf8, -0x96, -0xa2, -0x17, -0xff, -0xff, -0x7f, -0xca, -0xe1, -0x17, -0xe0, -0x00, -0xc3, -0xba, -0x71, -0x9f, -0x87, -0x7e, -0x00, -0x00, -0x28, -0xfb, -0x32, -0x4f, -0xa0, -0x10, -0xe0, -0xd0, -0x3a, -0xfc, -0x32, -0xdf, -0xcf, -0x7f, -0xe7, -0x61, -0xf7, -0xb0, -0xef, -0x7f, -0x3e, -0xff, -0x99, -0x85, -0xdd, -0xc3, -0xbe, -0x1d, -0x00, -0xfc, -0xff, -0xfc, -0x03, -0xf8, -0x0f, -0x01, -0xfc, -0x1b, -0xfe, -0xf0, -0x0f, -0xe0, -0x3f, -0x07, -0xf0, -0x6f, -0xf8, -0xc5, -0x37, -0x80, -0xff, -0xdf, -0x8b, -0xed, -0xe0, -0x7f, -0x0f, -0x00, -0xfe, -0x07, -0xfe, -0x01, -0xfc, -0xff, -0x00, -0xfe, -0x0d, -0x1f, -0xf8, -0x07, -0xf0, -0xfc, -0x03, -0xf8, -0x37, -0x7f, -0xe0, -0x1f, -0xc0, -0xf0, -0x0f, -0xe0, -0xdf, -0xff, -0xbf, -0x07, -0x00, -0xfe, -0x03, -0xff, -0x00, -0x86, -0x7f, -0x00, -0xff, -0xf8, -0x0f, -0xfc, -0x03, -0x1b, -0xfe, -0x01, -0xfc, -0xe0, -0x3f, -0xf0, -0x0f, -0x6f, -0xf8, -0x07, -0xf0, -0x80, -0xff, -0xdf, -0x03, -0x00, -0xff, -0x81, -0x7f, -0x7f, -0xc3, -0x3f, -0x80, -0x01, -0xfc, -0x07, -0xfe, -0xfe, -0x0d, -0xff, -0x00, -0x07, -0xf0, -0x1f, -0xf8, -0xf8, -0x37, -0xfc, -0x03, -0x01, -0xc0, -0xff, -0xef, -0x3f, -0x80, -0xff, -0xc0, -0xc0, -0xbf, -0xe1, -0x1f, -0xff, -0x00, -0xfe, -0x03, -0x00, -0xff, -0x86, -0x7f, -0xfc, -0x03, -0xf8, -0x0f, -0x01, -0xfc, -0x1b, -0xfe, -0xf7, -0x00, -0xe0, -0xff, -0xe0, -0x1f, -0xc0, -0x7f, -0x0f, -0xe0, -0xdf, -0xf0, -0x81, -0x7f, -0x00, -0xff, -0x3f, -0x80, -0x7f, -0xc3, -0x07, -0xfe, -0x01, -0xfc, -0xff, -0x00, -0xfe, -0x0d, -0xff, -0x7b, -0x00, -0xf0, -0x3f, -0xf0, -0x0f, -0xe0, -0xf8, -0x07, -0xf0, -0x6f, -0xff, -0xc0, -0x3f, -0x80, -0xe1, -0x1f, -0xc0, -0xbf, -0xfe, -0x03, -0xff, -0x00, -0x86, -0x7f, -0x00, -0xff, -0xf8, -0xff, -0x3d, -0x00, -0xf0, -0x1f, -0xf8, -0x07, -0x37, -0xfc, -0x03, -0xf8, -0xc0, -0x7f, -0xe0, -0x1f, -0xdf, -0xf0, -0x0f, -0xe0, -0x00, -0xff, -0x81, -0x7f, -0x7f, -0xc3, -0x3f, -0x80, -0x00, -0xfc, -0xff, -0x1e, -0x03, -0xf8, -0x0f, -0xfc, -0xfc, -0x1b, -0xfe, -0x01, -0x0f, -0xe0, -0x3f, -0xf0, -0xf0, -0x6f, -0xf8, -0x07, -0x3f, -0x80, -0xff, -0xc0, -0xc0, -0xbf, -0xe1, -0x1f, -0x0f, -0x00, -0xfe, -0x7f, -0xfe, -0x01, -0xfc, -0x07, -0x00, -0xfe, -0x0d, -0xff, -0xf8, -0x07, -0xf0, -0x1f, -0x03, -0xf8, -0x37, -0xfc, -0xe0, -0x1f, -0xc0, -0x7f, -0x0f, -0xe0, -0xdf, -0xf0, -0xbf, -0x07, -0x00, -0xff, -0x03, -0xff, -0x00, -0xfe, -0x7f, -0x00, -0xff, -0x86, -0x0f, -0xfc, -0x03, -0xf8, -0xfe, -0x01, -0xfc, -0x1b, -0x3f, -0xf0, -0x0f, -0xe0, -0xf8, -0x07, -0xf0, -0x6f, -0xff, -0xdf, -0x03, -0x80 -}}; - -/*---------------------------------------------------------------------------------------- - * P R O T O T Y P E S O F L O C A L F U N C T I O N S - *---------------------------------------------------------------------------------------- - */ - -/*---------------------------------------------------------------------------------------- - * E X P O R T E D F U N C T I O N S - *---------------------------------------------------------------------------------------- - */ diff --git a/src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x12/F12MicrocodePatch03000027.c b/src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x12/F12MicrocodePatch03000027.c new file mode 100644 index 0000000..456c51a --- /dev/null +++ b/src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x12/F12MicrocodePatch03000027.c @@ -0,0 +1,195 @@ +/* $NoKeywords:$ */ +/** + * @file + * + * AMD Family_12 Microcode patch. + * + * Fam12 Microcode Patch rev 03000027 for 3010 or equivalent. + * + * @xrefitem bom "File Content Label" "Release Content" + * @e project: AGESA + * @e sub-project: CPU/FAMILY/0x12 + * @e \$Revision: 58717 $ @e \$Date: 2011-09-13 23:20:11 +0800 (Tue, 13 Sep 2011) $ + * + */ +/* + ****************************************************************************** + * + * Copyright (c) 2011, Advanced Micro Devices, Inc. + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * * Neither the name of Advanced Micro Devices, Inc. nor the names of + * its contributors may be used to endorse or promote products derived + * from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL ADVANCED MICRO DEVICES, INC. BE LIABLE FOR ANY + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + ****************************************************************************** + */ +/*---------------------------------------------------------------------------------------- + * M O D U L E S U S E D + *---------------------------------------------------------------------------------------- + */ +#include "AGESA.h" +#include "cpuRegisters.h" +#include "cpuEarlyInit.h" + +/*---------------------------------------------------------------------------------------- + * D E F I N I T I O N S A N D M A C R O S + *---------------------------------------------------------------------------------------- + */ + +/*---------------------------------------------------------------------------------------- + * T Y P E D E F S A N D S T R U C T U R E S + *---------------------------------------------------------------------------------------- + */ + +// Patch code 03000027 for 3010 and equivalent +CONST MICROCODE_PATCHES ROMDATA CpuF12MicrocodePatch03000027 = +{{ + 0x11, 0x20, 0x09, 0x13, 0x27, 0x00, 0x00, 0x03, + 0x03, 0x80, 0x20, 0x00, 0x40, 0x00, 0x4f, 0x10, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x10, 0x30, 0x00, 0x00, 0x00, 0xaa, 0xaa, 0xaa, + 0xbd, 0x02, 0x19, 0xe3, 0x99, 0x0c, 0x06, 0x98, + 0x8a, 0x0f, 0x7b, 0x68, 0xc6, 0x11, 0x45, 0xd0, + 0x8c, 0x0e, 0x45, 0x3c, 0xff, 0xff, 0x29, 0xee, + 0xff, 0xff, 0x66, 0xdd, 0xff, 0xff, 0x53, 0x89, + 0x04, 0xfe, 0xff, 0x00, 0xc3, 0xb7, 0x14, 0xfd, + 0xec, 0xf2, 0xff, 0xa3, 0x0e, 0xbf, 0x50, 0x55, + 0xf0, 0xf7, 0xff, 0x0f, 0x3f, 0x7c, 0x63, 0xd9, + 0x80, 0x83, 0xab, 0x01, 0x02, 0x87, 0x04, 0x7f, + 0xd6, 0xe1, 0x97, 0x81, 0x01, 0xfe, 0xfd, 0xff, + 0xfb, 0x87, 0x6f, 0x2f, 0x27, 0x78, 0x8d, 0xf0, + 0x68, 0x1d, 0x7e, 0x19, 0x00, 0x40, 0xed, 0xd6, + 0x0e, 0xc0, 0x3b, 0x26, 0x60, 0xe8, 0x80, 0x0f, + 0x7f, 0x0e, 0xff, 0x95, 0x87, 0xcb, 0xc3, 0x3e, + 0xfe, 0x29, 0xfc, 0x6f, 0x1c, 0x2e, 0x0f, 0xfb, + 0x6a, 0x00, 0xc0, 0xe0, 0xf2, 0xef, 0xe1, 0xbf, + 0xf7, 0x70, 0x79, 0xd8, 0xcd, 0xbf, 0x85, 0xff, + 0xdf, 0xc2, 0xe5, 0x61, 0x33, 0xff, 0x16, 0xfe, + 0x7d, 0x0b, 0x97, 0x87, 0xff, 0x3d, 0x00, 0xf8, + 0xb4, 0x8d, 0x03, 0xf0, 0xf8, 0x03, 0x02, 0x1c, + 0xfa, 0xb4, 0x0e, 0xc0, 0xe0, 0xaf, 0x0d, 0xf0, + 0xff, 0x81, 0x7f, 0x00, 0xc3, 0x3f, 0x80, 0x7f, + 0x28, 0xb8, 0x1a, 0x00, 0xa0, 0xcf, 0xca, 0x01, + 0x0e, 0xfc, 0x01, 0xbd, 0xe0, 0x3f, 0xf0, 0x0f, + 0x6f, 0xf8, 0x07, 0xf0, 0x80, 0xff, 0xc0, 0x3f, + 0xbf, 0xe1, 0x1f, 0xc0, 0x00, 0xfe, 0x7f, 0x07, + 0xb7, 0x3c, 0xf8, 0xff, 0x3f, 0x0f, 0xff, 0x00, + 0x0f, 0x90, 0xfa, 0xff, 0xd1, 0x3f, 0x1c, 0x73, + 0x3f, 0xcb, 0xea, 0xff, 0x55, 0xff, 0xf0, 0xcf, + 0x06, 0x00, 0x36, 0xae, 0xfc, 0x09, 0xae, 0x23, + 0x06, 0x59, 0x87, 0x3f, 0xff, 0x07, 0x38, 0xfd, + 0xb9, 0xe8, 0x1f, 0x8e, 0xf0, 0x0f, 0xe0, 0x3f, + 0x07, 0xf0, 0x6f, 0xf8, 0x57, 0x03, 0x80, 0x1a, + 0x02, 0xff, 0x29, 0x03, 0x3f, 0xc0, 0xcf, 0xc3, + 0xff, 0xff, 0xa7, 0x9c, 0xff, 0x52, 0xd7, 0x07, + 0xff, 0xdf, 0x97, 0xfa, 0xf8, 0x7b, 0x7b, 0x1d, + 0x84, 0xab, 0x01, 0x40, 0x05, 0x6e, 0x1c, 0x80, + 0xc1, 0x1f, 0x10, 0xe0, 0xfe, 0x03, 0xff, 0x4a, + 0x87, 0x7f, 0x80, 0xcf, 0x09, 0xff, 0xff, 0x6f, + 0x1a, 0xfe, 0x01, 0xce, 0xe0, 0xff, 0xf7, 0x00, + 0xc0, 0x7f, 0xe0, 0x1f, 0xdf, 0xf0, 0x0f, 0xe0, + 0x00, 0xff, 0x81, 0x7f, 0x7f, 0xc3, 0x3f, 0x80, + 0x01, 0xfc, 0x07, 0xfe, 0xfe, 0x0d, 0xff, 0x00, + 0x00, 0xf0, 0xff, 0x7b, 0x0f, 0xe0, 0x3f, 0xf0, + 0xf0, 0x6f, 0xf8, 0x07, 0x3f, 0x80, 0xff, 0xc0, + 0xc0, 0xbf, 0xe1, 0x1f, 0xff, 0x00, 0xfe, 0x03, + 0x00, 0xff, 0x86, 0x7f, 0x3d, 0x00, 0xf8, 0xff, + 0xf8, 0x07, 0xf0, 0x1f, 0x03, 0xf8, 0x37, 0xfc, + 0xe0, 0x1f, 0xc0, 0x7f, 0x0f, 0xe0, 0xdf, 0xf0, + 0x81, 0x7f, 0x00, 0xff, 0x3f, 0x80, 0x7f, 0xc3, + 0xff, 0x1e, 0x00, 0xfc, 0x0f, 0xfc, 0x03, 0xf8, + 0xfe, 0x01, 0xfc, 0x1b, 0x3f, 0xf0, 0x0f, 0xe0, + 0xf8, 0x07, 0xf0, 0x6f, 0xff, 0xc0, 0x3f, 0x80, + 0xe1, 0x1f, 0xc0, 0xbf, 0xfe, 0x7f, 0x0f, 0x00, + 0xfe, 0x7f, 0xff, 0xad, 0x0f, 0xff, 0x5a, 0x3f, + 0xfa, 0xbf, 0xfc, 0xd7, 0x3c, 0xfc, 0x6b, 0xfd, + 0xcb, 0xff, 0xf6, 0x9f, 0xff, 0xf0, 0xcf, 0x75, + 0x00, 0xff, 0xbf, 0x07, 0x00, 0xfe, 0xbb, 0xff, + 0xfa, 0x87, 0x63, 0x2b, 0x63, 0xfd, 0xff, 0xff, + 0x7e, 0x0e, 0xfe, 0x01, 0x7f, 0xe5, 0xdf, 0xff, + 0xf8, 0x79, 0xf8, 0x07, 0x03, 0x80, 0xdc, 0x5a, + 0xff, 0x04, 0xf5, 0xff, 0x83, 0xad, 0xc3, 0x2f, + 0xfe, 0x01, 0xfc, 0x07, 0x00, 0xfe, 0x0d, 0xff, + 0xf8, 0x07, 0xf0, 0x1f, 0x03, 0xf8, 0x37, 0xfc, + 0xef, 0x01, 0xc0, 0xff, 0xff, 0x7f, 0x80, 0xef, + 0xdb, 0xcb, 0xfe, 0xe1, 0xff, 0xff, 0x09, 0xfe, + 0x5f, 0x06, 0x5a, 0x87, 0x0f, 0xfc, 0x03, 0xf8, + 0xfe, 0x01, 0xfc, 0x1b, 0xff, 0xf7, 0x00, 0xe0, + 0x83, 0xff, 0x3f, 0x40, 0xf0, 0x2d, 0x45, 0xff, + 0xfe, 0xff, 0xff, 0x2e, 0xc3, 0x2f, 0xc0, 0x95, + 0x86, 0x75, 0xe3, 0x00, 0x0f, 0xfd, 0x00, 0x3e, + 0x50, 0xf6, 0x65, 0x00, 0x20, 0x21, 0xc0, 0x9f, + 0x75, 0xf8, 0x65, 0xa0, 0x9f, 0xff, 0xce, 0xbf, + 0xee, 0x61, 0xdf, 0xc3, 0x7c, 0xfe, 0x33, 0xff, + 0xbb, 0x87, 0x7d, 0x0b, 0x00, 0xf8, 0xff, 0x3b, + 0x07, 0xf0, 0x1f, 0xf8, 0xf8, 0x37, 0xfc, 0x03, + 0x1f, 0xc0, 0x7f, 0xe0, 0xe0, 0xdf, 0xf0, 0x0f, + 0x6f, 0x00, 0xff, 0x8b, 0x17, 0xdb, 0xc1, 0xbf, + 0x1e, 0x00, 0xfc, 0xff, 0xca, 0x01, 0xa0, 0xaf, + 0x01, 0xbd, 0x0e, 0xfc, 0xfb, 0x4f, 0xe5, 0x3f, + 0xa7, 0xaa, 0x3f, 0xf8, 0xff, 0x7f, 0x00, 0xc0, + 0x9b, 0x4a, 0xf1, 0xe0, 0x5c, 0x0d, 0x00, 0x14, + 0x57, 0xeb, 0x00, 0xac, 0xfe, 0xda, 0x00, 0x0f, + 0xff, 0xff, 0x4f, 0xf0, 0xfc, 0x32, 0xd0, 0x3a, + 0x7f, 0xe0, 0x1f, 0xc0, 0xf0, 0x0f, 0xe0, 0xdf, + 0xff, 0xbf, 0x03, 0x00, 0xfe, 0xa7, 0xdf, 0x54, + 0x87, 0x7f, 0xaa, 0xfe, 0x58, 0xff, 0xff, 0x07, + 0x1f, 0xde, 0xa9, 0x90, 0x60, 0x02, 0xc0, 0x9f, + 0x75, 0xf8, 0x63, 0xd0, 0x80, 0xff, 0xdf, 0x03, + 0x25, 0xff, 0xdf, 0x7f, 0xe2, 0xc3, 0xbf, 0xd2, + 0x97, 0xfc, 0xdf, 0xff, 0xfd, 0x0f, 0xff, 0x4a, + 0x07, 0xf0, 0xbf, 0xac, 0xf9, 0x3c, 0xf4, 0x5b, + 0x01, 0xc0, 0x1c, 0xac, 0x1c, 0x00, 0x7a, 0xac, + 0xd0, 0xeb, 0xc0, 0x1f, 0xff, 0x5f, 0xfe, 0xfd, + 0xac, 0xc5, 0x83, 0x7f, 0xca, 0x01, 0xa0, 0xf7, + 0x01, 0x7c, 0x0e, 0xfa, 0xf7, 0x00, 0xa0, 0xff, + 0xf6, 0x5f, 0xcb, 0x7f, 0xaf, 0xf4, 0x7b, 0xf0, + 0xdd, 0x7f, 0x00, 0xff, 0xb1, 0x16, 0xfd, 0xc1, + 0xff, 0xff, 0x13, 0xfc, 0x7f, 0x0c, 0xb0, 0x0e, + 0x5b, 0x65, 0x00, 0x90, 0x3f, 0xf0, 0x6f, 0xe5, + 0x38, 0xb6, 0xfa, 0x7c, 0xda, 0x03, 0x7f, 0x82, + 0xe1, 0x97, 0xc1, 0xd6, 0xfe, 0x03, 0xff, 0x00, + 0x86, 0x7f, 0x00, 0xff, 0xf8, 0xff, 0x3d, 0x00, + 0xf2, 0x9f, 0xfd, 0xd7, 0x3c, 0xfc, 0x03, 0xfc, + 0xcb, 0xef, 0xff, 0xbf, 0x7f, 0xf0, 0x8f, 0xf5, + 0x29, 0xff, 0xd9, 0x7d, 0xd7, 0x83, 0xbf, 0xb7, + 0x00, 0xfc, 0xff, 0x1e, 0xfb, 0xfd, 0xcf, 0xfe, + 0x7e, 0x0e, 0xfe, 0xfd, 0x0f, 0xe0, 0x7f, 0xfb, + 0xa2, 0x3f, 0x38, 0xc6, 0x7f, 0x82, 0x01, 0x00, + 0x41, 0xd7, 0xe1, 0x8f, 0x0d, 0x00, 0x72, 0x6b, + 0xf8, 0x13, 0x0c, 0x00, 0x0c, 0xb6, 0x0e, 0xbf, + 0xfd, 0x07, 0xf0, 0xdf, 0x63, 0xd1, 0x1f, 0x1c, + 0x80, 0x3f, 0xc1, 0x00, 0xc7, 0x00, 0xeb, 0xf0, + 0xbf, 0x07, 0x00, 0xff, 0x03, 0xff, 0x00, 0xfe, + 0x7f, 0x00, 0xff, 0x86, 0x0f, 0xfc, 0x03, 0xf8, + 0xfe, 0x01, 0xfc, 0x1b, 0x3f, 0xf0, 0x0f, 0xe0, + 0xf8, 0x07, 0xf0, 0x6f, 0xff, 0xdf, 0x03, 0x80 +}}; + +/*---------------------------------------------------------------------------------------- + * P R O T O T Y P E S O F L O C A L F U N C T I O N S + *---------------------------------------------------------------------------------------- + */ + +/*---------------------------------------------------------------------------------------- + * E X P O R T E D F U N C T I O N S + *---------------------------------------------------------------------------------------- + */ diff --git a/src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x12/Makefile.inc b/src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x12/Makefile.inc index 740b96a..72e42f8 100644 --- a/src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x12/Makefile.inc +++ b/src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x12/Makefile.inc @@ -3,7 +3,7 @@ libagesa-y += F12IoCstate.c libagesa-y += F12MicrocodePatch03000002.c libagesa-y += F12MicrocodePatch0300000e.c -libagesa-y += F12MicrocodePatch0300000f.c +libagesa-y += F12MicrocodePatch03000027.c libagesa-y += cpuCommonF12Utilities.c libagesa-y += cpuF12BrandId.c libagesa-y += cpuF12BrandIdFm1.c -- To view, visit https://review.coreboot.org/28378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9650fab377d957904318ebb393323c2509cfea26 Gerrit-Change-Number: 28378 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>

1 0

Change in coreboot[master]: Documentation: add description for util/pmh7tool
by Evgeny Zinoviev (Code Review) 28 Aug '18

28 Aug '18

Hello Tom Hiller, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28368 to look at the new patch set (#2). Change subject: Documentation: add description for util/pmh7tool ...................................................................... Documentation: add description for util/pmh7tool Change-Id: Iab5daf101a9ff27aa49b7849bf6bf39362b8db09 Signed-off-by: Evgeny Zinoviev <me(a)ch1p.com> --- M Documentation/util.md M util/README.md A util/pmh7tool/description.md 3 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/28368/2 -- To view, visit https://review.coreboot.org/28368 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iab5daf101a9ff27aa49b7849bf6bf39362b8db09 Gerrit-Change-Number: 28368 Gerrit-PatchSet: 2 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: Documentation: add util/pmh7tool to util.md
by Evgeny Zinoviev (Code Review) 28 Aug '18

28 Aug '18

Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/28368 ) Change subject: Documentation: add util/pmh7tool to util.md ...................................................................... Patch Set 1: > There is a script under util called "util_readme" that auto > generates `Documentation/util.md` and `util/README.md` based on the > `description.md` file under each util directory. Can you add a > `description.md` for pmh7tool and run the script instead and submit > those as changes? Sorry, didn't know that. Sure. -- To view, visit https://review.coreboot.org/28368 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab5daf101a9ff27aa49b7849bf6bf39362b8db09 Gerrit-Change-Number: 28368 Gerrit-PatchSet: 1 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Aug 2018 21:57:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: Documentation/nb/intel/sandybridge/nri_registers.md: Fix mistake
by Felix Held (Code Review) 28 Aug '18

28 Aug '18

Felix Held has posted comments on this change. ( https://review.coreboot.org/28377 ) Change subject: Documentation/nb/intel/sandybridge/nri_registers.md: Fix mistake ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28377 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28fed4a9264b96f93b9e88325f547a5db512514c Gerrit-Change-Number: 28377 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 28 Aug 2018 18:44:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Documentation/nb/intel/sandybridge/nri_registers.md: Fix mistake
by Angel Pons (Code Review) 28 Aug '18

28 Aug '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28377 Change subject: Documentation/nb/intel/sandybridge/nri_registers.md: Fix mistake ...................................................................... Documentation/nb/intel/sandybridge/nri_registers.md: Fix mistake According to a comment on fa1a07b, the 100MHz clock is the Ivy Bridge only clock, not the 133MHz one. Change-Id: I28fed4a9264b96f93b9e88325f547a5db512514c Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M Documentation/northbridge/intel/sandybridge/nri_registers.md 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/28377/1 diff --git a/Documentation/northbridge/intel/sandybridge/nri_registers.md b/Documentation/northbridge/intel/sandybridge/nri_registers.md index d5857ec..aa16644 100644 --- a/Documentation/northbridge/intel/sandybridge/nri_registers.md +++ b/Documentation/northbridge/intel/sandybridge/nri_registers.md @@ -2137,8 +2137,8 @@ +===========+==================================================================+ | 0:7| Selected multiplier: 100Mhz [7,12], 133Mhz [3,19] | +-----------+------------------------------------------------------------------+ -| 8 | - 1: 100Mhz reference clock | -| | - 0: 133Mhz reference clock (Ivy Bridge only) | +| 8 | - 1: 100Mhz reference clock (Ivy Bridge only) | +| | - 0: 133Mhz reference clock | +-----------+------------------------------------------------------------------+ | 31 | PLL busy | +-----------+------------------------------------------------------------------+ -- To view, visit https://review.coreboot.org/28377 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I28fed4a9264b96f93b9e88325f547a5db512514c Gerrit-Change-Number: 28377 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in coreboot[master]: soc/amd/stoneyridge/enable_usbdebug.c: Update pci_ehci_dbg_set_port()
by build bot (Jenkins) (Code Review) 28 Aug '18

28 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28344 ) Change subject: soc/amd/stoneyridge/enable_usbdebug.c: Update pci_ehci_dbg_set_port() ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/28344/2/src/soc/amd/stoneyridge/include/soc… File src/soc/amd/stoneyridge/include/soc/southbridge.h: https://review.coreboot.org/#/c/28344/2/src/soc/amd/stoneyridge/include/soc… PS2, Line 311: #define DEBUG_PORT_MASK (BIT(16) | BIT(17) | (BIT(18)) Macros with complex values should be enclosed in parentheses -- To view, visit https://review.coreboot.org/28344 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb25992729d984b8570712f91a03a7cd1e9b8643 Gerrit-Change-Number: 28344 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Aug 2018 15:28:51 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/kahlee: Enable EC firmware update screen
by Raul Rangel (Code Review) 28 Aug '18

28 Aug '18

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/28374 ) Change subject: mainboard/google/kahlee: Enable EC firmware update screen ...................................................................... Patch Set 1: Code-Review+2 Ah, I see it sets the vboot flags -- To view, visit https://review.coreboot.org/28374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95fc4d3430bac66c09f57a4d34abde08752e5f0e Gerrit-Change-Number: 28374 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Aug 2018 15:18:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/kahlee: Enable EC firmware update screen
by Raul Rangel (Code Review) 28 Aug '18

28 Aug '18

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/28374 ) Change subject: mainboard/google/kahlee: Enable EC firmware update screen ...................................................................... Patch Set 1: Is coreboot updating the EC now? -- To view, visit https://review.coreboot.org/28374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95fc4d3430bac66c09f57a4d34abde08752e5f0e Gerrit-Change-Number: 28374 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 Aug 2018 15:08:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/kahlee: Enable EC firmware update screen
by Martin Roth (Code Review) 28 Aug '18

28 Aug '18

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/28374 Change subject: mainboard/google/kahlee: Enable EC firmware update screen ...................................................................... mainboard/google/kahlee: Enable EC firmware update screen Grunt takes a few seconds to update the EC, so display a notification screen while that's happening. BUG=b:113286040 TEST=Boot Grunt with old EC firmware, see update screen Change-Id: I95fc4d3430bac66c09f57a4d34abde08752e5f0e Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/mainboard/google/kahlee/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/28374/1 diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig index fbd1fb0..bde91a1 100644 --- a/src/mainboard/google/kahlee/Kconfig +++ b/src/mainboard/google/kahlee/Kconfig @@ -98,6 +98,7 @@ config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_LID_SWITCH + select VBOOT_EC_SLOW_UPDATE if VBOOT_EC_SOFTWARE_SYNC config VBOOT_VBNV_OFFSET hex -- To view, visit https://review.coreboot.org/28374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I95fc4d3430bac66c09f57a4d34abde08752e5f0e Gerrit-Change-Number: 28374 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2018