coreboot-gerrit September 2022

coreboot-gerrit@coreboot.org

1 participants
4678 discussions

[M] Change in coreboot[master]: mb/google/dedede/variants/shotzo: Turn off LAN power in S0ix
by build bot (Jenkins) (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Wisley Chen. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67373 ) Change subject: mb/google/dedede/variants/shotzo: Turn off LAN power in S0ix ...................................................................... Patch Set 7: (5 comments) File src/mainboard/google/dedede/mainboard.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158198): https://review.coreboot.org/c/coreboot/+/67373/comment/96ae0734_3240de66 PS7, Line 98: */ code indent should use tabs where possible File src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158198): https://review.coreboot.org/c/coreboot/+/67373/comment/d0c62b93_d805d38a PS7, Line 19: S0IX_EXIT, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158198): https://review.coreboot.org/c/coreboot/+/67373/comment/ec5912e3_b30900d0 PS7, Line 19: S0IX_EXIT, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158198): https://review.coreboot.org/c/coreboot/+/67373/comment/9ae3f353_f39c9724 PS7, Line 20: S0IX_ENTRY, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158198): https://review.coreboot.org/c/coreboot/+/67373/comment/94f19072_07f69428 PS7, Line 20: S0IX_ENTRY, please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/67373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id01089531503e62231c5ab19e4cd8056198b9acb Gerrit-Change-Number: 67373 Gerrit-PatchSet: 7 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 07 Sep 2022 03:04:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/dedede/variants/shotzo: Turn off LAN power in S0ix
by build bot (Jenkins) (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Tony Huang. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67373 ) Change subject: mb/google/dedede/variants/shotzo: Turn off LAN power in S0ix ...................................................................... Patch Set 6: (5 comments) File src/mainboard/google/dedede/mainboard.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158197): https://review.coreboot.org/c/coreboot/+/67373/comment/1f75dfaa_5697159b PS6, Line 98: */ code indent should use tabs where possible File src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158197): https://review.coreboot.org/c/coreboot/+/67373/comment/3c987db2_8df056e2 PS6, Line 19: S0IX_EXIT, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158197): https://review.coreboot.org/c/coreboot/+/67373/comment/c0198bcf_3c07fd99 PS6, Line 19: S0IX_EXIT, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158197): https://review.coreboot.org/c/coreboot/+/67373/comment/6468336e_a755ece6 PS6, Line 20: S0IX_ENTRY, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158197): https://review.coreboot.org/c/coreboot/+/67373/comment/67221fa4_a575d213 PS6, Line 20: S0IX_ENTRY, please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/67373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id01089531503e62231c5ab19e4cd8056198b9acb Gerrit-Change-Number: 67373 Gerrit-PatchSet: 6 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 07 Sep 2022 03:04:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/kinox: Modify fan speed/duty table
by Dtrain Hsu (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Ricky Chang. Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67307 ) Change subject: mb/google/brya/var/kinox: Modify fan speed/duty table ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/67307/comment/35f270f4_59fde1fd PS4, Line 11: BUG=b:244262869 > 'vaule' may be misspelled - perhaps 'value'? Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/67307 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5e885b96624d5fc31f1d42e3582c3ab01e08458 Gerrit-Change-Number: 67307 Gerrit-PatchSet: 5 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-Comment-Date: Wed, 07 Sep 2022 02:43:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/kinox: Modify fan speed/duty table
by Dtrain Hsu (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Dtrain Hsu, Ricky Chang. Hello Frank Wu, John Su, build bot (Jenkins), Tim Wawrzynczak, Sumeet R Pawnikar, Ricky Chang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67307 to look at the new patch set (#5). Change subject: mb/google/brya/var/kinox: Modify fan speed/duty table ...................................................................... mb/google/brya/var/kinox: Modify fan speed/duty table Modify fan speed/duty table follow "Duty table.xlsx". BUG=b:244262869 TEST=Boot to ChromeOS. Using SDV system, enter duty value,and then system feedback fan speed. Signed-off-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Change-Id: Id5e885b96624d5fc31f1d42e3582c3ab01e08458 --- M src/mainboard/google/brya/variants/kinox/overridetree.cb 1 file changed, 36 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/67307/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/67307 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5e885b96624d5fc31f1d42e3582c3ab01e08458 Gerrit-Change-Number: 67307 Gerrit-PatchSet: 5 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: acpi/acpigen_dptf: Modify DPTF_MAX_FAN_PERF_STATES to 20
by Dtrain Hsu (Code Review) 07 Sep '22

07 Sep '22

Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67390 ) Change subject: acpi/acpigen_dptf: Modify DPTF_MAX_FAN_PERF_STATES to 20 ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/67390/comment/e4263ccd_68b6e92c PS1, Line 12: BUG=b:244262869 > 'vaule' may be misspelled - perhaps 'value'? Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/67390 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iacd3ef0da926df5d174b215ab8ea4adc1a8b672e Gerrit-Change-Number: 67390 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Sep 2022 02:42:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpi/acpigen_dptf: Modify DPTF_MAX_FAN_PERF_STATES to 20
by Dtrain Hsu (Code Review) 07 Sep '22

07 Sep '22

Dtrain Hsu has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/67390 ) Change subject: acpi/acpigen_dptf: Modify DPTF_MAX_FAN_PERF_STATES to 20 ...................................................................... acpi/acpigen_dptf: Modify DPTF_MAX_FAN_PERF_STATES to 20 The Kinox fan speed/duty table has 20 elements so sets the DPTF_MAX_FAN_PERF_STATES from 10 to 20. BUG=b:244262869 TEST=Boot to ChromeOS. Using SDV system, enter duty value,and then system feedback fan speed. Signed-off-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Change-Id: Iacd3ef0da926df5d174b215ab8ea4adc1a8b672e --- M src/include/acpi/acpigen_dptf.h 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/67390/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67390 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iacd3ef0da926df5d174b215ab8ea4adc1a8b672e Gerrit-Change-Number: 67390 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: acpi/acpigen_dptf: Modify DPTF_MAX_FAN_PERF_STATES to 20
by build bot (Jenkins) (Code Review) 07 Sep '22

07 Sep '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67390 ) Change subject: acpi/acpigen_dptf: Modify DPTF_MAX_FAN_PERF_STATES to 20 ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158191): https://review.coreboot.org/c/coreboot/+/67390/comment/5a6982ed_f878a79a PS1, Line 12: BUG=b:244262869 'vaule' may be misspelled - perhaps 'value'? -- To view, visit https://review.coreboot.org/c/coreboot/+/67390 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iacd3ef0da926df5d174b215ab8ea4adc1a8b672e Gerrit-Change-Number: 67390 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Sep 2022 02:40:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpi/acpigen_dptf: Modify DPTF_MAX_FAN_PERF_STATES to 20
by Dtrain Hsu (Code Review) 07 Sep '22

07 Sep '22

Dtrain Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67390 ) Change subject: acpi/acpigen_dptf: Modify DPTF_MAX_FAN_PERF_STATES to 20 ...................................................................... acpi/acpigen_dptf: Modify DPTF_MAX_FAN_PERF_STATES to 20 The Kinox fan speed/duty table has 20 elements so sets the DPTF_MAX_FAN_PERF_STATES from 10 to 20. BUG=b:244262869 TEST=Boot to ChromeOS. Using SDV system, enter duty vaule,and then system feedback fan speed. Signed-off-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Change-Id: Iacd3ef0da926df5d174b215ab8ea4adc1a8b672e --- M src/include/acpi/acpigen_dptf.h 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/67390/1 diff --git a/src/include/acpi/acpigen_dptf.h b/src/include/acpi/acpigen_dptf.h index d9bd5e2..8fa8db8 100644 --- a/src/include/acpi/acpigen_dptf.h +++ b/src/include/acpi/acpigen_dptf.h @@ -44,7 +44,7 @@ /* Maximum found by automatic inspection (awk) */ DPTF_MAX_CHARGER_PERF_STATES = 10, - DPTF_MAX_FAN_PERF_STATES = 10, + DPTF_MAX_FAN_PERF_STATES = 20, /* From ACPI spec 6.3 */ DPTF_FIELD_UNUSED = 0xFFFFFFFFull, -- To view, visit https://review.coreboot.org/c/coreboot/+/67390 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iacd3ef0da926df5d174b215ab8ea4adc1a8b672e Gerrit-Change-Number: 67390 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: src: De-conflict CALIBRATION_REGION definitions
by Yu-Ping Wu (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Martin L Roth. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67382 ) Change subject: src: De-conflict CALIBRATION_REGION definitions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If6734f2a7d9be669586ea350fb9979fcd422b591 Gerrit-Change-Number: 67382 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Wed, 07 Sep 2022 02:39:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/kinox: Modify fan speed/duty table
by build bot (Jenkins) (Code Review) 07 Sep '22

07 Sep '22

Attention is currently required from: Dtrain Hsu, Ricky Chang. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67307 ) Change subject: mb/google/brya/var/kinox: Modify fan speed/duty table ...................................................................... Patch Set 4: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158190): https://review.coreboot.org/c/coreboot/+/67307/comment/d1ee82fe_9a44ae55 PS4, Line 11: BUG=b:244262869 'vaule' may be misspelled - perhaps 'value'? -- To view, visit https://review.coreboot.org/c/coreboot/+/67307 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5e885b96624d5fc31f1d42e3582c3ab01e08458 Gerrit-Change-Number: 67307 Gerrit-PatchSet: 4 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-Comment-Date: Wed, 07 Sep 2022 02:34:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2022