coreboot-gerrit September 2022

coreboot-gerrit@coreboot.org

1 participants
4674 discussions

[S] Change in coreboot[master]: soc/intel/cmn/graphics: Use pci_dev_request_bus_master for BM enabling
by Subrata Banik (Code Review) 01 Sep '22

01 Sep '22

Attention is currently required from: Jamie Ryu, Tim Wawrzynczak, Kapil Porwal, Ivy Jian, Arthur Heymans, Lean Sheng Tan, Eric Lai, Raj Astekar. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67273 ) Change subject: soc/intel/cmn/graphics: Use pci_dev_request_bus_master for BM enabling ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > This seems like a bug in depthcharge then, as it seems to be making an assumption about the state of the HW (i.e. BM bit set) before it uses it? If depthcharge is using DMA then IMHO it is responsible for configuring it correctly, including setting BM. Isn't that the case with depthcharge always? I remember one issue in CML days with SATA when FSP missed to configure the BM and we were seeing booting issue. Finally, we are seeing the similar issue in MTL again with IGD. Its better we configure required setting in coreboot being independent of FSP is my intention here. -- To view, visit https://review.coreboot.org/c/coreboot/+/67273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9ad9eee8379b7ea1e50224e3fabb347e5f14c25b Gerrit-Change-Number: 67273 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Comment-Date: Thu, 01 Sep 2022 15:31:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/docker/coreboot-jenkins-node: Install cmocka
by Nico Huber (Code Review) 01 Sep '22

01 Sep '22

Attention is currently required from: Felix Singer, Martin L Roth. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67272 ) Change subject: util/docker/coreboot-jenkins-node: Install cmocka ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > The coreboot-sdk coreboot build will continue to use 3rdparty/cmocka, I guess. […] It seems a little odd, all the other flashrom dependencies are also in coreboot-sdk. But tests are optional and coreboot builds anyway, so this is not a blocker. -- To view, visit https://review.coreboot.org/c/coreboot/+/67272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c168e480d6f4cbfbbd175ecb035c88bfcbac00b Gerrit-Change-Number: 67272 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Thu, 01 Sep 2022 15:28:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Patrick Georgi <patrick(a)coreboot.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/spd_tools: Rebuild utils when source changes
by Robert Zieba (Code Review) 01 Sep '22

01 Sep '22

Attention is currently required from: Caveh Jalali, Reka Norman. Robert Zieba has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67266 ) Change subject: util/spd_tools: Rebuild utils when source changes ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/67266 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4775fe0e00e0f5d4f8b4b47331d836aba53c0e69 Gerrit-Change-Number: 67266 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Sep 2022 15:03:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[refs/meta/config]: Replace -is:draft
by Patrick Georgi (Code Review) 01 Sep '22

01 Sep '22

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67281 ) Change subject: Replace -is:draft ...................................................................... Replace -is:draft That flag has been retired by Gerrit a long time ago and was replaced with -is:private and -is:wip for different aspects of what a draft change has been previously. Change-Id: Id4c569af1ad559fc87db55e76a8ca36d893e163d Reviewed-on: https://review.coreboot.org/c/coreboot/+/67281 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M project.config 1 file changed, 17 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved diff --git a/project.config b/project.config index 19161bb..128a402 100644 --- a/project.config +++ b/project.config @@ -38,4 +38,4 @@ [notify "coreboot-gerrit"] header = to email = coreboot-gerrit(a)coreboot.org - filter = -is:draft + filter = -is:private -is:wip -- To view, visit https://review.coreboot.org/c/coreboot/+/67281 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: refs/meta/config Gerrit-Change-Id: Id4c569af1ad559fc87db55e76a8ca36d893e163d Gerrit-Change-Number: 67281 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2022